GitLab

TBR=oilpan-reviews
BUG=522860
NOTRY=true

Review URL: https://codereview.chromium.org/1303953005

git-svn-id: svn://svn.chromium.org/blink/trunk@201060 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The input to the selector position and the rule position is known to
possibly overflow 12 and 18 bits respectively since the input comes from
unsigned positions into data structures known to keep more elements than
that. The selector and rule positions will be wrong regardlessly, unless
we make RuleData bigger.

Truncating the position to a max value instead of just letting it
overflow could be an option. It doesn't make sense for selector position
as trying to match any of the other selectors won't make any difference.

Truncating the rule position would make the cascading order correct when
comparing rules in the representable range with a rule outside the range,
while just letting it overflow starting from zero again will yield a
correct cascading order between two rules both outside of the
representable range.

Given that, I conclude to just remove the ASSERTs and not do anything
clever about values outside of the ranges.

BUG=519315
R=timloh@chromium.org

Review URL: https://codereview.chromium.org/1312703002

git-svn-id: svn://svn.chromium.org/blink/trunk@201059 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The added sheets passed into StyleSheetInvalidationAnalysis may either be
added or removed. When they are removed style elements from a shadow tree,
the style element may no longer have a containingShadowRoot if the element
has already been removed. That caused a crash when the containingShadowRoot
was accessed without a nullptr check.

Instead of deducing the scope from the style element, pass the stylesheet
collection TreeScope to the analysis object. The m_scopingNodes, which is
probably a left-over from <style scoped> has been removed.

Now, the shadow tree root node, or outermost shadow host if ::content
rules makes that necessary, is always marked sub-tree dirty. The previous
code-path could trigger id/class invalidation of separate elements when
the stylesheet contents had multiple owner nodes, but that was most likely
wrong if it could ever happen.

BUG=522860

Review URL: https://codereview.chromium.org/1313443003

git-svn-id: svn://svn.chromium.org/blink/trunk@201058 bbb929c8-8fbe-4397-9dbb-9b2b20218538

There are numerous flaky tests which are likely caused by race conditions
between testRunner.setPermission and subsequent operations.

Introduce a helper class which wraps testRunner.setPermission
with a promise based system which can be used to prevent races

BUG=(multiple)

Review URL: https://codereview.chromium.org/1305043004

git-svn-id: svn://svn.chromium.org/blink/trunk@201057 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch replaces forward class declarations |VisiblePosition| to include
directive of "VisiblePosition.h" as preparation of introducing
|VisiblePositionTemplate<Strategy>|, like |PositionAlgorithm<Strategy>|.

This patch is a preparation of making selection to handle granularity for web
component, http://crrev.com/1277863002

BUG=513568
TEST=n/a; No behavior changes

Review URL: https://codereview.chromium.org/1306243006

git-svn-id: svn://svn.chromium.org/blink/trunk@201056 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Currently DOMWindow::navigator returns a navigator associated with a frame
even when the window is detached from the frame and another window
is attached to it. That means calling frame()->document() may return
an incorrect document, for example.

This CL makes LocalDOMWindow::navigator return a navigator with
a null frame when the window is not associated to the frame.

BUG=522791

Review URL: https://codereview.chromium.org/1308723003

git-svn-id: svn://svn.chromium.org/blink/trunk@201055 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Test for Chromium change: https://codereview.chromium.org/1315483002

BUG=522900

Review URL: https://codereview.chromium.org/1312723002

git-svn-id: svn://svn.chromium.org/blink/trunk@201054 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This is a performance-optimization CL for oilpan builds. In oilpan, it is important
to explicitly clear on-heap collections in order not to leave unnecessary garbage
on the oilpan's heap.

BUG=

Review URL: https://codereview.chromium.org/1311683002

git-svn-id: svn://svn.chromium.org/blink/trunk@201053 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Review URL: https://codereview.chromium.org/1310643004

git-svn-id: svn://svn.chromium.org/blink/trunk@201052 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Remove entries that were asserting prior to crbug.com/521520 being fixed.

R=haraken,keishi
BUG=521102,521861
NOTRY=true

Review URL: https://codereview.chromium.org/1311733002

git-svn-id: svn://svn.chromium.org/blink/trunk@201051 bbb929c8-8fbe-4397-9dbb-9b2b20218538

I manually created more than 80 Chromium builds with various GC parameters and investigated a way to reduce the peak memory increase in memory.top_7_stress. This CL reduces the peak memory of Blogger by 6%, WordPress by 3% etc.

This CL does the following two things:

- Finish completeSweep() before starting a V8 minor GC.
- Give a chance to schedule a precise GC after V8 minor and major GCs.

BUG=474470

Review URL: https://codereview.chromium.org/1308163003

git-svn-id: svn://svn.chromium.org/blink/trunk@201050 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch introduces "EditingUtilitiesTest.cpp" as a home of a test for
|nextPositionOf()|.

This patch is a follow up patch of http://crrev.com/1305963003, which
introduce |nextPositionOf()| as replacement of |Position::next()|.

BUG=n/a
TEST=n/a; No behavior changes

Review URL: https://codereview.chromium.org/1308263002

git-svn-id: svn://svn.chromium.org/blink/trunk@201049 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Otherwise, invoking WebViewFrameWidget::close() from frame swap will
result in trying to clear the frame widget on the wrong main frame.

Other miscellaneous fixes:
- WebViewFrameWidget now uses smart pointers where appropriate for its
  members.
- WebViewFrameWidget's ctor also takes a WebWidgetClient* pointer.
  This is future-proofing to help merge the widget implementations in
  WebFrameWidget and WebView.

BUG=419087

Review URL: https://codereview.chromium.org/1310063002

git-svn-id: svn://svn.chromium.org/blink/trunk@201048 bbb929c8-8fbe-4397-9dbb-9b2b20218538

As the liveEdit happens, we ideally need to update uiLocation of the error
to the actual new script. However, this is a tedious task to do, so we
would simply defend againt exceptions thrown in UI.

R=pfeldman
NOTRY=true

Review URL: https://codereview.chromium.org/1312523002

git-svn-id: svn://svn.chromium.org/blink/trunk@201047 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The parameters are too verbose to write every time.

BUG=

Review URL: https://codereview.chromium.org/1236183002

git-svn-id: svn://svn.chromium.org/blink/trunk@201045 bbb929c8-8fbe-4397-9dbb-9b2b20218538

When cleaning out a ShadowRoot's child Nodes as part of its disposal,
the child Nodes will in some cases not have other references than the
shadow root. If so, the Node will be summarily deleted without being
notified of it being removed from its DOM tree first. By calling its
removedFrom().

As a Document need to maintain an accurate attached node count, arrange
for the otherwise-unreferenced Node's document to be decremented.

R=
BUG=521520

Review URL: https://codereview.chromium.org/1309083002

git-svn-id: svn://svn.chromium.org/blink/trunk@201044 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The two hooks are:
* WebLocalFrame::isNavigationPending
* WebViewClient::didFirstLayoutAfterFinishedParsing

The WebLocalFrame::isNavigationPending provides a
simple check whether the content of the document intends to
change the location (via Refresh or window.location change).

The WebViewClient::didFirstLayoutAfterFinishedParsing is called
when we finish the first layout after the document had finished
parsing. Another way to explain it is "first layout after
DOMContentLoaded".

BUG=521149
R=esprehn

Review URL: https://codereview.chromium.org/1309883003

git-svn-id: svn://svn.chromium.org/blink/trunk@201042 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Shange HarfBuzzShaper to not normalize non breaking space and update the
logic in adjustSpacing to correctly handle non breaking space characters
during word-space adjustments. The logic for word spacing adjustments is
based on the implementation in SimpleShaper which has been proven right.

R=pdr@chromium.org
BUG=523548
TEST=fast/text/word-spacing-nbsp.html

Review URL: https://codereview.chromium.org/1310803003

git-svn-id: svn://svn.chromium.org/blink/trunk@201041 bbb929c8-8fbe-4397-9dbb-9b2b20218538

move KeyUsageAllows to the class where its data is. That way the 
function and its contexts is much more understandable. 
This is first part, second part can be found here:
https://crrev.com/1181413009/

Review URL: https://codereview.chromium.org/1184123007

git-svn-id: svn://svn.chromium.org/blink/trunk@201040 bbb929c8-8fbe-4397-9dbb-9b2b20218538

custom scrollbars are not created when html element has overflow:scroll
style. Reconstruct scrollbars from native to custom scrollbar when 
html element has overflow:scroll style. 

BUG=518757

Review URL: https://codereview.chromium.org/1292513002

git-svn-id: svn://svn.chromium.org/blink/trunk@201039 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=523588

Review URL: https://codereview.chromium.org/1311593003

git-svn-id: svn://svn.chromium.org/blink/trunk@201038 bbb929c8-8fbe-4397-9dbb-9b2b20218538

It is weird that the SW update behavior changes when devtools open.

BUG=466871

Review URL: https://codereview.chromium.org/1307833003

git-svn-id: svn://svn.chromium.org/blink/trunk@201037 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Accumulating large draw command backlogs can result in janky
performance, and in extreme cases, a GPU denial of service. This
change fixes that problem by disabling deferred rendering when
high overdraw is detected. Cases where the overdraw overwrites
the entire canvas are not affected by this change and will
stay in deferred rendering mode because overwriting the entire
canvas resets the backlog.

BUG=522764, 522972

Review URL: https://codereview.chromium.org/1308853003

git-svn-id: svn://svn.chromium.org/blink/trunk@201036 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=522614

Review URL: https://codereview.chromium.org/1305373002

git-svn-id: svn://svn.chromium.org/blink/trunk@201034 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch moves |{next,previous}PositionOf()| to "EditingUtilities.{cpp,h}"
from "Position.{cpp,h}" to simplify "Position.{cpp,h}" for improving code
health since |{next,previous}PositionOf()| don't depend of implementation of
|PositionAlgorithm| template class.

BUG=518738
TEST=n/a; no behavior changes

Review URL: https://codereview.chromium.org/1310533002

git-svn-id: svn://svn.chromium.org/blink/trunk@201033 bbb929c8-8fbe-4397-9dbb-9b2b20218538

These unit tests verify that QuotaExceededErr is thrown when appending
data to an MSE SourceBuffer that is full. This new behavior was
ntroduced by the recent CLs:
https://codereview.chromium.org/1008463002/
https://codereview.chromium.org/1013923002/

BUG=421694

Review URL: https://codereview.chromium.org/1304953002

git-svn-id: svn://svn.chromium.org/blink/trunk@201032 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Manually rebaselining a pair of tests that fail on Debug due
to limitations of specifying Release/Debug for NeedsRebaseline.

BUG=509025
TBR=joelo

Review URL: https://codereview.chromium.org/1310023002

git-svn-id: svn://svn.chromium.org/blink/trunk@201031 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This is a followup CL of https://codereview.chromium.org/976543002/. In
that CL, sub-pixel accumulation is considered to calculate layerBounds,
foregroundBounds and backgroundBounds if renderLayer doesn't paint into
its own backing layer. But in that CL, sub-pixel accumulation didn't
apply to foregroundBounds and backgroundBounds for unpaginated layers.
This CL fixes above issue.

BUG=515395

Review URL: https://codereview.chromium.org/1278113003

git-svn-id: svn://svn.chromium.org/blink/trunk@201030 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Test is still timing out, but since the test doesn't log anything, it's
hard to tell if the test actually starts running. Adding some logging
so that on failures we can tell how far the test gets.

BUG=522646
TEST=test passes

Review URL: https://codereview.chromium.org/1308853005

git-svn-id: svn://svn.chromium.org/blink/trunk@201029 bbb929c8-8fbe-4397-9dbb-9b2b20218538

We made LayoutObject::previousPaintInvalidationRect() private but
DeprecatedPaintLayerScrollArea is a friend of LayoutObject, so missed
the change. This caused incorrect fake mouse move event on composited
scroll.

Will fix the friend access issue in
https://codereview.chromium.org/1306993002/.

BUG=516016
TEST=fast/events/overflow-composited-scroll-fake-mouse-move.html

Review URL: https://codereview.chromium.org/1309983002

git-svn-id: svn://svn.chromium.org/blink/trunk@201028 bbb929c8-8fbe-4397-9dbb-9b2b20218538

m_documentLoader is null. Here's the trace:

html_viewer.mojo!blink::DocumentLoader::isCommittedButEmpty() Line 105
html_viewer.mojo!blink::FrameLoader::finishedParsing() Line 485
html_viewer.mojo!blink::FrameLoader::stopAllLoaders() Line 981
html_viewer.mojo!blink::LocalFrame::detach(blink::FrameDetachType type) Line 281
html_viewer.mojo!blink::WebFrame::swap(blink::WebFrame * frame) Line 114

BUG=521663
TEST=none
R=japhet@chromium.org

Review URL: https://codereview.chromium.org/1298643003

git-svn-id: svn://svn.chromium.org/blink/trunk@201027 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=509025
TBR=joelo

Review URL: https://codereview.chromium.org/1312583002

git-svn-id: svn://svn.chromium.org/blink/trunk@201026 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Using dirtyLinesFromChangedChild() was the wrong choice in
https://codereview.chromium.org/1167543008 as it can dirty the
lineboxes of descendants and ancestors. We're only interested
in dirtying the lineboxes of the current parent as it is
only to one of them we will possibly attach the float.

I have more to do here to understand why I'm not getting a
height on the span in my new test, but this successfully
addresses the assert in bug 510703 and seems obviously more
correct than what I currently have.


BUG=510703

Review URL: https://codereview.chromium.org/1308433003

git-svn-id: svn://svn.chromium.org/blink/trunk@201025 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This is a preparation for a series of paint invalidation changes
for slimming paint v2.

- Combine layoutDidGetCalledSinceLastFrame into
  mayNeedPaintInvalidation because we handle them in the same way;

- Separate shouldCheckForChildPaintInvalidation from
  mayNeedPaintInvalidation to meet future slimming paint v2 needs;

- Mark some bit fields for future removal for slimming paint v2;

- Use direct m_bitfields access for private and simple setting and
  clearing of paint invalidation flags.

BUG=510908

Review URL: https://codereview.chromium.org/1302993003

git-svn-id: svn://svn.chromium.org/blink/trunk@201024 bbb929c8-8fbe-4397-9dbb-9b2b20218538

EventHandler currently have two state vars for tracking
node under mouse: m_nodeUnderMouse and m_lastNodeUnderMouse.
These two pointers are used primarily for mouse entry/exit
events, but they point to the same node until we are about
to send mouseenter/leave/over/out events. In the few cases
these pointers become unequal otherwise (happens only when
dispathMouseEvent is called with setUnder=false), it is not
clear why we didn't update the old state. My experiments
suggest that updating the old state doesn't hurt in these
cases. So it makes sense to nuke the m_lastNodeUnderMouse
state.

BUG=

Review URL: https://codereview.chromium.org/1293973004

git-svn-id: svn://svn.chromium.org/blink/trunk@201023 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Take care of a FIXME in SecurityOrigin.cpp to check the validity of any innerURL during construction and to handle invalidity as a 'unique' origin.

TBR=mkwst
BUG=514076

Review URL: https://codereview.chromium.org/1294933004

git-svn-id: svn://svn.chromium.org/blink/trunk@201022 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This test has been flaky all along because the sequence of events it
tries to observe is not fully observable. There's still some coverage of
the reset-animation-when-no-longer-running case elsewhere.

BUG=522652

Review URL: https://codereview.chromium.org/1292703004

git-svn-id: svn://svn.chromium.org/blink/trunk@201021 bbb929c8-8fbe-4397-9dbb-9b2b20218538

It still references LayoutState.

Review URL: https://codereview.chromium.org/1312533002

git-svn-id: svn://svn.chromium.org/blink/trunk@201020 bbb929c8-8fbe-4397-9dbb-9b2b20218538

CascadeOrder is always ignoreCascadeOrder after [1] and can be removed.

[1] https://codereview.chromium.org/1298173004

BUG=487125

Review URL: https://codereview.chromium.org/1291873005

git-svn-id: svn://svn.chromium.org/blink/trunk@201019 bbb929c8-8fbe-4397-9dbb-9b2b20218538

No change in behavior, just a minor cleanup.

NOTRY=true
R=leviw

Review URL: https://codereview.chromium.org/1308093002

git-svn-id: svn://svn.chromium.org/blink/trunk@201018 bbb929c8-8fbe-4397-9dbb-9b2b20218538