GitLab

With mask tiling, it is possible that a tiled mask gets a filter after
tiles are created. In order to make picture layer tilings throw away
tiles, we need to change the mask type from MULTI_TEXTURE_MASK to
SINGLE_TEXTURE_MASK, but mask type was set to be immutable as we do not
allow NOT_MASK to MASK conversion and vice versa.

This CL attempts to fix the demoting problem by making mask type a non-
const value and prevent NOT_MASK to MASK conversion by DCHECK.

BUG=567293
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2845143002
Cr-Commit-Position: refs/heads/master@{#468094}

BUG=707642
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2845773005
Cr-Commit-Position: refs/heads/master@{#468093}

In the (rare) case of a recording being started and the FilterData
structure being yanked away (and destroyed) from under
SVGFilterPainter's feet, we need to put the PaintController in a
consistent state before destroying it.
Add a new method SVGFilterRecordingContext::Abort() and call that when
SVGFilterPainter::FinishEffect encounters a null FilterData for the
LayoutObject.

BUG=713024
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2847133002
Cr-Commit-Position: refs/heads/master@{#468092}

BUG=none

Review-Url: https://codereview.chromium.org/2840413002
Cr-Commit-Position: refs/heads/master@{#468091}

This applies to Linux and Chrome OS (and Mac Views) until
713359 is fixed.

BUG=602756,713359

Review-Url: https://codereview.chromium.org/2839953005
Cr-Commit-Position: refs/heads/master@{#468090}

BUG=682420

Review-Url: https://codereview.chromium.org/2852543002
Cr-Commit-Position: refs/heads/master@{#468089}

std::less requires #include <functional>,
see e.g. http://en.cppreference.com/w/cpp/utility/functional/less

See the bug for more context.

BUG=716504

Review-Url: https://codereview.chromium.org/2849913002
Cr-Commit-Position: refs/heads/master@{#468088}

This CL
- Enables inline module scripts in ScriptLoader.
- Adds ModuleTreeLinker::FetchDescendantsForInlineScript() and
  related plumbing to ModuleTreeLinkerRegistry and Modulator.
  This is not yet spec'ed and we might need revisit once the spec is
  updated. https://github.com/whatwg/html/issues/2544
- Makes ModuleScript to store its |source_text| for CSP of inline scripts.

BUG=715369, 594639

Review-Url: https://codereview.chromium.org/2842923002
Cr-Commit-Position: refs/heads/master@{#468087}

Adds a 3 min delay before starting zero-touch enrollment during OOBE.

BUG=chromium:710716
TEST=browser test

Review-Url: https://codereview.chromium.org/2824283003
Cr-Commit-Position: refs/heads/master@{#468086}

Make FilterData::state_ only be checked and updated within
SVGFilterPainter, and not by SVGFilterRecordingContext or the local
painting helper.
Instead SVGFilterRecordingContext only manages the recording state, and
gets passed bounds while returning a paint record.
This simplifies some of the corner-cases with regards to how "aborted"
filters are handled, getting rid of some "FilterData is null" in many
cases.

BUG=713024
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2851753002
Cr-Commit-Position: refs/heads/master@{#468085}

Reland of SharedArrayBuffer throws serializing to indexeddb (patchset #1 id:1 of https://codereview.chromium.org/2845623002/ )

Reason for revert:
This CL was speculatively suspected as the cause of http://crbug.com/715567, but it turned out was unrelated.

Original issue's description:
> Revert of SharedArrayBuffer throws serializing to indexeddb (patchset #4 id:60001 of https://codereview.chromium.org/2838783002/ )
>
> Reason for revert:
> Suspect for http://crbug.com/715567 (crash when typing in hangouts chat window).
>
> Original issue's description:
> > SharedArrayBuffer throws serializing to indexeddb
> >
> > The StructuredDeserialize spec now has a special case for serializing
> > for storage: it doesn't allow SharedArrayBuffers to be serialized, and
> > instead throws a DataCloneError.
> >
> > BUG=chromium:714820
> >
> > Review-Url: https://codereview.chromium.org/2838783002
> > Cr-Commit-Position: refs/heads/master@{#467093}
> > Committed: https://chromium.googlesource.com/chromium/src/+/08d35f601c7cfbdc66f9a7f8836e32028d344559
>
> TBR=jbroman@chromium.org,haraken@chromium.org,jsbell@chromium.org,binji@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=chromium:714820
>
> Review-Url: https://codereview.chromium.org/2845623002
> Cr-Commit-Position: refs/heads/master@{#467325}
> Committed: https://chromium.googlesource.com/chromium/src/+/d86073fac8a47abe754598992e1b8424d7534b9f

TBR=jbroman@chromium.org,haraken@chromium.org,jsbell@chromium.org,gab@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=chromium:714820

Review-Url: https://codereview.chromium.org/2848933002
Cr-Commit-Position: refs/heads/master@{#468084}

Monthly update to the newest production version.

BUG=

Review-Url: https://codereview.chromium.org/2844243004
Cr-Commit-Position: refs/heads/master@{#468083}

https://skia.googlesource.com/skia.git/+log/0122af08f6af..2fcd4a480dee

$ git log 0122af08f..2fcd4a480 --date=short --no-merges --format='%ad %ae %s'
2017-04-28 benjaminwagner Revert "Only store width and height on SkPixelRef"
2017-04-28 msarett Revert "Revert "Delete copyTo(Allocator), hide copyTo() behind flag""
2017-04-28 reed add helper makeShader for the common Clamp case
2017-04-28 jvanverth Fix fast blur for shadow rrects.
2017-04-28 fmalita Scrub DeviceCM
2017-04-28 rmistry Testing permissions
2017-04-27 benjaminwagner Add non-Valgrind PreAbandonGpuContext bot.
2017-04-28 bsalomon Remove srgb flags from GrProcessorSet
2017-04-27 ethannicholas additional skslc vector optimizations
2017-04-28 reed add GM to compare atlas and vertices
2017-04-26 freiling handle GrVkTransferBuffer::Create failure
2017-04-27 benjaminwagner [infra/bots] Treat extra_config as a list.
2017-04-27 robertphillips Disable deferred proxies in Chrome
2017-04-27 msarett Only store width and height on SkPixelRef

Created with:
  roll-dep src/third_party/skia


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=benjaminwagner@chromium.org

Change-Id: I288f95ee249db9b974f75f41c78b062996ce97f4
Reviewed-on: https://chromium-review.googlesource.com/490686Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#468082}

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2821323002
Cr-Commit-Position: refs/heads/master@{#468081}

This patch makes |InsertTextCommand::DoApply()| not to call |ApplyStyle()| for
applying typing style when selection after inserting text is empty since
|ApplyStyle()| doesn't work with empty selection.

The issue 714311 and the attached test case insert text into OPTION element to
get empty selection after insertion, since we can't place selection inside
OPTION element.

BUG=714311
TEST=run_webkit_unit_tests --gtest_filter=InsertTextCommandTest.WithTypingStyle

Review-Url: https://codereview.chromium.org/2847763004
Cr-Commit-Position: refs/heads/master@{#468080}

Since GestureScrolls can be ended by either GestureScrollEnd or
GestureFlingStart, it seems wrong that OOPIF scroll bubbling, in
RenderWidgetHostViewChildFrame/CrossProcessFrameConnector doesn't
bubble GestureFlingStart.

This CL modifies the bubbling code to include bubbling of
GestureFlingStart, and re-enables a related DHECK in
RenderWidgetHostImpl.

BUG=695187
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2842203002
Cr-Commit-Position: refs/heads/master@{#468079}

Kernel 4.11 merges the commit that added linux/dma-buf.h
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=ef96152e6a36e0510387cb174178b7982c1ae879

This CL increases the required kernel to include this file to 4.11.

BUG=707604
R=danakj@chromium.org

Review-Url: https://codereview.chromium.org/2851803002
Cr-Commit-Position: refs/heads/master@{#468078}

This patch add DCHECK into |ApplyStyleCommand::DoApply()| to verify that we
don't apply |ApplyStyleCommand| to empty range to detect redundant command
execution for improving code health.

Actually, |ApplyStyleCommand::DoApply()| doesn't work with empty range, it
causes DCHECK for |Position.IsNull()| in |ComparePositions()|.

BUG=714311
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2848823002
Cr-Commit-Position: refs/heads/master@{#468077}

exo::Surface wasn't setting the device_scale_factor in CompositorFrames.
This was triggering a DCHECK when the SurfaceInfo for new cc::Surfaces
have device_scale_factor == 0.

BUG=b/37654593

Review-Url: https://codereview.chromium.org/2843723003
Cr-Commit-Position: refs/heads/master@{#468076}

Reland of [WebAPKs] Make WebAPK update flow more sensible (patchset #2 id:90001 of https://codereview.chromium.org/2845943006/ )

Reason for revert:
Reverting the revert now that https://chrome-internal-review.googlesource.com/c/363648/ has landed. That CL should prevent official builder from breaking

Original issue's description:
> Revert of [WebAPKs] Make WebAPK update flow more sensible (patchset #4 id:100001 of https://codereview.chromium.org/2827233006/ )
>
> Reason for revert:
> broke official-* bots, see crbug.com/716330
>
> Original issue's description:
> > [WebAPKs] Make WebAPK update flow more sensible
> >
> > Previously, whenever the shell_apk in shell_apk_version.gni there was a period
> > of time during which
> > - Chrome tries to update the WebAPK because the "shell_apk" version with which
> >   Chrome is compiled with was updated
> > - The WebAPK server is unable to fulfill the update request because the new
> >   ShellAPK has not yet been uploaded to the WebAPK server
> >
> > This CL splits shell_apk_version in shell_apk_version.gni into two variables:
> > |template_shell_apk_version| and |expected_shell_apk_version|
> >
> > The new flow for updating android/webapk/shell_apk will be:
> > 1) Write CL which:
> >    - Makes changes to code in android/webapk/shell_apk
> >    - Increments |template_shell_apk_version|
> >    This will:
> >    - Update the template ShellAPK which is built on the official build bot
> >    - Trigger an alert that the ShellAPK on the WebAPK Minting Server needs to
> >      be updated
> >    - Does not affect the "WebAPK update logic".
> > 2) Upload new ShellAPK template to the WebAPK Minting Server
> >    At this point:
> >    - new WebAPK installs will have the updated shell.
> >    - Chrome will still not request updates to the new ShellAPK version
> > 3) Write CL which:
> >    - Increments |expected_shell_apk_version|
> >    This will:
> >    - cause Chrome to request updates to the new ShellAPK version
> >
> > BUG=708053
> >
> > Review-Url: https://codereview.chromium.org/2827233006
> > Cr-Commit-Position: refs/heads/master@{#467708}
> > Committed: https://chromium.googlesource.com/chromium/src/+/d71abed75b07b4b9fc50591cbeb2b6c8874bf448
>
> TBR=hartmanng@chromium.org,hanxi@chromium.org,zpeng@chromium.org,dominickn@chromium.org,pkotwicz@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=708053
>
> Review-Url: https://codereview.chromium.org/2845943006
> Cr-Commit-Position: refs/heads/master@{#467966}
> Committed: https://chromium.googlesource.com/chromium/src/+/db08d35eab5d639a6ed751dd4e42dcd5b4f683ec

TBR=hartmanng@chromium.org,hanxi@chromium.org,zpeng@chromium.org,dominickn@chromium.org,timvolodine@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=708053

Review-Url: https://codereview.chromium.org/2847263002
Cr-Commit-Position: refs/heads/master@{#468075}

The current extension permission update bubble puts both old and new
permissions together in one list. This CL changes the bubble to only show the
new permissions.

BUG=443216

Review-Url: https://codereview.chromium.org/2821123002
Cr-Commit-Position: refs/heads/master@{#468074}

The "learn more" link has moved to the main content instead of the
details. Tests should check for it before clicking the details, since
mobile layouts will hide the main content after "details" is clicked.

BUG=674732

Review-Url: https://codereview.chromium.org/2845363003
Cr-Commit-Position: refs/heads/master@{#468073}

The lifetime of GuestViewBase doesn't match the lifetime of GuestViewMessageFilter, so it's possible that the GuestViewBase is already destroyed by the time this callback is called.

BUG=716223

Review-Url: https://codereview.chromium.org/2848723002
Cr-Commit-Position: refs/heads/master@{#468072}

BUG=

Review-Url: https://codereview.chromium.org/2848003002
Cr-Commit-Position: refs/heads/master@{#468071}

This shaves ~6ms off of our total skia render time for English. Similar numbers for other languages.

BUG=715591

Review-Url: https://codereview.chromium.org/2846023002
Cr-Commit-Position: refs/heads/master@{#468070}

BUG=707642

Review-Url: https://codereview.chromium.org/2846273002
Cr-Commit-Position: refs/heads/master@{#468069}

It's highly unlikely that this can happen, but just in case.

The voice search popup will keep staying with no other way to dismiss it except reopening the launcher, but I don't think we should take too much care of this edge case beyond simply not breaking.

Bug=712331

Review-Url: https://codereview.chromium.org/2848493004
Cr-Commit-Position: refs/heads/master@{#468068}

https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/f7157c2..2395287

BUG=693090,712096

TEST=bots

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2844363004
Cr-Commit-Position: refs/heads/master@{#468067}

A minor refactoring; the method will get a couple of other callers
in subsequent patches (which I'm breaking up for digestibility).

The new condition is something that currently will never be false;
subsequent patches will cause it be false sometimes.

BUG=701575

Review-Url: https://codereview.chromium.org/2846263002
Cr-Commit-Position: refs/heads/master@{#468066}

Make --enable-gpu-client-tracing work for the in-process context on the
render thread. This matches ContextProviderCommandBuffer implementation.

Review-Url: https://codereview.chromium.org/2850713002
Cr-Commit-Position: refs/heads/master@{#468065}

Fix SitePerProcessBrowserTest.ProcessTransferAfterError to not requiring modifying the mock HostResolver when using the network service.

This allows us to turn on the check that the host resolver isn't modified after SetUpOnMainThread in a future change.

BUG=713847

Review-Url: https://codereview.chromium.org/2847003003
Cr-Commit-Position: refs/heads/master@{#468064}

It now support backslashes in file paths and uses LF as EOL (instead of CRLF) even on Windows.

BUG=none

Review-Url: https://codereview.chromium.org/2846223002
Cr-Commit-Position: refs/heads/master@{#468063}

This anticipates when the size of the main frame's root layer is based on
the main frame's layout size.

BUG=701575
R=skobes@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2841113002
Cr-Commit-Position: refs/heads/master@{#468062}

Revert of Global Resource Coordinator: Basic service internals (patchset #30 id:560001 of https://codereview.chromium.org/2798713002/ )

Reason for revert:
Reverting as CoordinationUnitImplTest.CyclicGraphUnits is crashing on windows dbg. The output isn't very helpful:
https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.win%2FWin7_Tests__dbg__1_%2F59514%2F%2B%2Frecipes%2Fsteps%2Fservice_unittests%2F0%2Fstdout

 RUN      ] CoordinationUnitImplTest.CyclicGraphUnits

[114/116] CoordinationUnitImplTest.CyclicGraphUnits (CRASHED)
[115/116] CoordinatorImplTest.NoProcessLocalManagers (1 ms)
[116/116] CoordinatorImplTest.SeveralProcessLocalManagers (4 ms)
Retrying 1 test (retry #1)
[ RUN      ] CoordinationUnitImplTest.CyclicGraphUnits

[117/117] CoordinationUnitImplTest.CyclicGraphUnits (CRASHED)
Retrying 1 test (retry #2)
[ RUN      ] CoordinationUnitImplTest.CyclicGraphUnits

[118/118] CoordinationUnitImplTest.CyclicGraphUnits (CRASHED)
Retrying 1 test (retry #3)
[ RUN      ] CoordinationUnitImplTest.CyclicGraphUnits

[119/119] CoordinationUnitImplTest.CyclicGraphUnits (CRASHED)

Original issue's description:
> Global Resource Coordinator: Basic service internals
>
> This adds the basic internals of the GRC; CoordinationUnits which can form a DAG, receive events, and send back updated resource usage policies.
>
> A full prototype of GRC usage can be seen here: https://codereview.chromium.org/2710823003
>
> Service architecture doc: https://docs.google.com/document/d/1qec4DNDM2pLLIFfCBtnNQTxlNXQzjml69yC8SGU9bzI/edit#
>
> GRC parent doc (internal only): https://docs.google.com/document/d/1dx4KDbDFvP-GWwwrSPg8Gxx4kboIoPi8kDKTSXoTbC4/edit#heading=h.td4yhfm12fe3
>
> R=primiano@chromium.org,skyostil@chromium.org,fmeawad@chromium.org,rockot@chromium.org
> BUG=691886
>
> Review-Url: https://codereview.chromium.org/2798713002
> Cr-Commit-Position: refs/heads/master@{#468002}
> Committed: https://chromium.googlesource.com/chromium/src/+/de0f39d2a625433e60b5e22e1d2d3803f3d219e5

TBR=chrisha@chromium.org,dcheng@chromium.org,fmeawad@chromium.org,jam@chromium.org,nasko@chromium.org,primiano@chromium.org,rockot@chromium.org,skyostil@chromium.org,oysteine@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=691886

Review-Url: https://codereview.chromium.org/2851813002
Cr-Commit-Position: refs/heads/master@{#468061}

Only the WebContents is needed, don't keep a reference to Tab, that
keeps a reference to the Activity.

BUG=715724

Review-Url: https://codereview.chromium.org/2847533004
Cr-Commit-Position: refs/heads/master@{#468060}

SpdyFrameWithStreamIdIR was always kind of pointless.

This CL lands server change 153630764 by birenroy.

BUG=488484

Review-Url: https://codereview.chromium.org/2849713002
Cr-Commit-Position: refs/heads/master@{#468059}

BUG=707642

Review-Url: https://codereview.chromium.org/2844223006
Cr-Commit-Position: refs/heads/master@{#468058}

This change adds support for sending screen orientation change events
to out-of-process iframes as well as fixing the Screen.orientation
property on OOPIFs.

This change adds a PageMsg_UpdateScreenInfo that updates the
ScreenInfo for subframe renderers. The screen orientation is
still updated on the ViewMsg_Resize for the main frame.

The flow of dispatching the screen orientation update is:
1. The browser sends a ViewMsg_Resize to the main frame's renderer. The browser also sends PageMsg_UpdateScreenInfo to the OOPIF renderers.
2. The main frame renderer dispatches FrameHostMsg_FrameRectsChanged back to the browser process.
3. The browser process dispatches ViewMsg_Resize to the subframe renderers.
4. The subframe renderers dispatch the screen orientation event when they receive the resize IPC.

BUG=498287

Review-Url: https://codereview.chromium.org/2832093003
Cr-Commit-Position: refs/heads/master@{#468057}

https://codereview.chromium.org/2786463004/ caused the regression.
Now we paint cell's container backgrounds as display item of row/section
instead of cell, so when cell's geometry changes we need to invalidate
the container's backgrounds.

BUG=713050
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2851553002
Cr-Commit-Position: refs/heads/master@{#468056}

BUG=716442

Review-Url: https://codereview.chromium.org/2848883002
Cr-Commit-Position: refs/heads/master@{#468055}