- 04 Sep, 2019 40 commits
-
-
Francois Doray authored
The test is flaky on Chrome OS. TBR=dgozman@chromium.org Bug: 1000654 Change-Id: I566552569619751d76284e3ccfdabf1f942c7167 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1784623Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#693169}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/1f6f69209ec2..26a87516dc1b git log 1f6f69209ec2..26a87516dc1b --date=short --no-merges --format='%ad %ae %s' 2019-09-04 jmadill@chromium.org Remove overlay font hash from codegen. Created with: gclient setdep -r src/third_party/angle@26a87516dc1b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jmadill@chromium.org,jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jmadill@chromium.org,jmadill@google.com Bug: None Change-Id: I74e02537e98bbd5a41bf036b7ed35d67c55f0bdb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783813Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#693168}
-
Jan Wilken Dörrie authored
TBR=ulan@chromium.org Bug: 999004 Change-Id: If8eca8c8b94f91e67765f71d25b24eb53204b599 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782854Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#693167}
-
Jérôme Lebel authored
This patch removes dead code in MainController, ApplicationSettingsCommands and SettingsNavigationController, related to unified consent flag. This flag is now always true. Bug: 951313 Change-Id: I5a695d0b6c59ba24f1230b8f41b75a491ce6f226 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1784597 Auto-Submit: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#693166}
-
arthursonzogni authored
The test: BackForwardCacheBrowserTest.SchedulerTrackedFeaturesUpdatedWhileStoring has been reported to be flaky. It was added with a known potential for flakiness that has been resolved in this CL. Bug: 999738 Change-Id: I1342d3313fc3898067e33b7847631edbddd77058 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1781150Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Lowell Manners <lowell@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#693165}
-
Pavel Shmakov authored
When NotificationPermissionUpdater#onClientAppUninstalled is called, native might not have been loaded, so we need a ChromeFeatureList.isInitialized() check. Change-Id: Idc478bfc880264b15f0ad5303f87aba0756ded04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782853 Auto-Submit: Pavel Shmakov <pshmakov@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Commit-Queue: Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#693164}
-
Francois Doray authored
TBR=asvitkine@chromium.org,yrsun@chromium.org Bug: 996823 Change-Id: I76d2d25e687069e9a731393368df94a80edafa5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1784621Reviewed-by:
-
Stefano Sanfilippo authored
Bug: 993372, 992424 Change-Id: I23bd70836fd70ef1fa98de797f04b4a7f7d1546e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782851 Commit-Queue: Stefano Sanfilippo <ssanfilippo@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Daniel Vogelheim <vogelheim@chromium.org> Cr-Commit-Position: refs/heads/master@{#693162}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/86c39c71262d..45812a1faa61 git log 86c39c71262d..45812a1faa61 --date=short --no-merges --format='%ad %ae %s' 2019-09-04 halcanary@google.com gn: try to fix flutter roll Created with: gclient setdep -r src/third_party/skia@45812a1faa61 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jlavrova@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jlavrova@google.com Bug: None Change-Id: I140b55faa9b84395ee086f566301e0fa033b5c22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783812Reviewed-by:
-
Nico Weber authored
We now know how often these fire. Also use the new, more targeted -Wno-reorder-init-list which unblocks the roll from the cleanup. Bug: 999871,999886 Change-Id: I87c9b2e3fb75053c3ebaed2317192549570fefb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1784620 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#693160}
-
Jan Krcal authored
This CL updates the rest of the avatar toolbar button code to use the new API for retrieving the unconsented primary account from IdentityManager. Bug: 983182 Change-Id: Ib1c2be250a49ecfbab7e15e52130d834b5320457 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1781690 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#693159}
-
Ross McIlroy authored
Change-Id: I850e1fcb8a87c38ea54b91fb49bce304262da6e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783154 Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Auto-Submit: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#693158}
-
Satoshi Niwa authored
Also update ArcPolicyBridge, the sole user of these time values. Context : We have been using SessionManagerImpl::GetArcStartTimeTicks() for perf measurements, etc, but this doesn't work for ARCVM. This CL makes ArcSessionManager.arc_start_time() equivalent to SessionManagerImpl::GetArcStartTimeTicks() by using TimeTicks. Bug: b/140361966 Test: try Change-Id: Ic935ccdf8b2177abb0644551a3b422a5e5c0c25c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783687Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Commit-Queue: Satoshi Niwa <niwa@chromium.org> Cr-Commit-Position: refs/heads/master@{#693157}
-
Ren-Pei Zeng authored
Original MjpegDecodeAccelerator (MJDA) Mojo interface only permits shared memory buffers and I420 output format. This CL adds DecodeWithDmaBuf() function that enables DMA buffers and different output pixel formats. Bug: b:120057531 Test: Preview in camera apps with MJPEG stream. Change-Id: Ic5dbf2b0bf2ba13e295388db70b1ade7a117fb80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1547470 Commit-Queue: Ren-Pei Zeng <kamesan@chromium.org> Reviewed-by:
Ricky Liang <jcliang@chromium.org> Reviewed-by:
Jorge Lucangeli Obes <jorgelo@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Wei Lee <wtlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#693156}
-
Stephen Chenney authored
Switch to triggering input based on the signal to restart main frame updates and commits, rather than waiting for an actual main frame update and commit. Some frames have no content until input is received, so would never get any input with the previous approach. The input system now only suppresses input when either main frame updates or compositor commits are being deferred. There are maybe some narrow windows where input might get through but this seems the only reliable way to track the deferred states because some pages have non-standard sequences of deferral (such as about:blank and DevTools). Bug: 958424, 994288 Change-Id: I94957fbdbd3a6ef0ea309c4d633f1a510458ca6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768834Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Commit-Queue: Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#693155}
-
Kentaro Hara authored
This reverts commit 623f213f. Reason for revert: It turned out that we haven't yet reached consensus about the change. Original change's description: > Update Blink C++ styleguide > > This CL removes a couple of Blink-specific style rules per the discussion at blink-dev@ (https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/gNRO6_sMWRM/WNR2c6NdAAAJ). > > Bug: None > Change-Id: I125954a547c11d0021ef38fd6a9aff79f3d69fca > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771227 > Auto-Submit: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Jeremy Roman <jbroman@chromium.org> > Commit-Queue: Jeremy Roman <jbroman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#691153} TBR=jbroman@chromium.org,haraken@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: None Change-Id: Ie13c19e16803f87fc130d1483464ce051912df8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1784603Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#693154}
-
Ayu Ishii authored
This change follows this CL [1] and does further cleanup to remove the concept of timeouts from the SMS Receiver API mainly from the API interface and renderer process. [1] https://crrev.com/c/1783219 Bug: 1000376 Change-Id: If7b8c17e0f1332df17e374c6f84e772a267c4760 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783227Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Ayu Ishii <ayui@chromium.org> Cr-Commit-Position: refs/heads/master@{#693153}
-
Navid Zolghadr authored
This CL adds a runtime flag that sends the click and auxclick events as PointerEvents. There are more cases to fix such as context menu events and click from other paths such as touch and pointerlock. Bug: 989958 Change-Id: I0e440ceef29e6cad202bc7f07150c7f3b6b35da0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762792Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Reviewed-by:
Mustaq Ahmed <mustaq@chromium.org> Reviewed-by:
Ella Ge <eirage@chromium.org> Commit-Queue: Navid Zolghadr <nzolghadr@chromium.org> Cr-Commit-Position: refs/heads/master@{#693152}
-
Rune Lillesveen authored
We currently compute system colors as their rgba values based on color-scheme. However, color-scheme was not a high priority property, so changing color-scheme on the same element as the system color was set did not always yield the correct result as the color-scheme might have been applied too late. There is an open issue[1] for having system colors computing to themselves and resolve to an rgba value for the used value. That would mean we will have to change the internal storage for colors in ComputedStyle and possibly store a StyleColor with system color keywords in addition to currentcolor which currently computes to the keyword. For now, instead of introducing an even higher priority level, make color-scheme a high priority property, and delay application of the cascaded color property value to the ComputedStyle until we have applied other high priority properties. [1] https://github.com/w3c/csswg-drafts/issues/3847 Bug: 939811 Change-Id: I91ce04a55886507ee20aace9b2470a5ac5b43fbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773073 Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#693151}
-
Wei Lee authored
This is a reland of d66ef7a9 The original CL was wrongfully reverted in https://crrev.com/c/1783523.\ TBR=wtlee@chromium.org Original change's description: > Cleanup the usage of force-use-chrome-camera-app flag > > This CL removes all the usage of force-use-chrome-camera-app since we > make CCA the default camera app started from R76. > > Bug: b/140463175, 953690 > Test: Chrome can be compiled successfully > > Change-Id: Ib5430fc06c7c7420a3c04f21e3d0b5dbeeb4ec47 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1784023 > Commit-Queue: Wei Lee <wtlee@chromium.org> > Reviewed-by: Shik Chen <shik@chromium.org> > Cr-Commit-Position: refs/heads/master@{#693032} Bug: b/140463175, 953690 Change-Id: I8d023f34f28673aa67737d32f8945a52534bf67e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1784599Reviewed-by:
-
Maksim Moskvitin authored
We need to remove all stored sync metadata when user disabled sync. Nigori is not user type, so we have to remove everything related in this case. NigoriStorage::ClearData() just removes the corresponding file. Bug: 922900 Change-Id: Icfbb27f4a693122b3d048bdba857764d5dd83a97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782848 Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#693149}
-
Armando Miraglia authored
It was discovered that due the asynchronous nature of starting up a video capture device, it is possible to leave a callback holding a dangling pointer if the device is stopped before it is ready. This change makes sure that when such a stop operation occurse, also the callbacks associated to the sessions for the starting device are removed. BUG=998548 Change-Id: I27d42f266b83a2dbb26f7ecfd117cc5931564375 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782813Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Armando Miraglia <armax@chromium.org> Cr-Commit-Position: refs/heads/master@{#693148}
-
Olya Kalitova authored
Moves files related to Crostini default container management using Ansible into a separate subdirectory. This would add more structure to source code and reduce review cycle time. TEST=unit_tests --gtest_filter="Crostini*" Bug: 1000005 Change-Id: I3924a36f39a1e2ac5ede03bb3e57c69159a361dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1781449Reviewed-by:
Nicholas Verne <nverne@chromium.org> Reviewed-by:
Alex Oldemeier <aoldemeier@chromium.org> Commit-Queue: Olya Kalitova <okalitova@chromium.org> Cr-Commit-Position: refs/heads/master@{#693147}
-
Jérôme Lebel authored
Adding accessibility identifiers for Google services settings and manage sync settings views. Needed for crrev.com/i/1752430 Bug: 718061 Change-Id: I242a5f5e812260d00c4da2e33b9d8cb77088df8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783149Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Auto-Submit: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#693146}
-
Egor Pasko authored
The size is used only to reserve address space (with mmap(2)). In the kernel mmap(2) will always silently align to the next page. Hence lifting this check should be safe. Recently program headers changed in Chrome DSOs on Android so the amount of virtual address space to reserve became unaligned (when DFMs are enabled we need to reserve more address space than what we immediately require). It does not prevent the system android_dlopen_ext() from working (as checked by cjgrant@ on the bug), hence this change would likely make the crazylinker implementation of android_dlopen_ext() closer to the reference one. Though I did not verify the alignment of the reserved size for libmonochrome.so (potentially could still stay aligned because, after all, it is a different library from libchrome.so). The amount of testing for this hotfix is inspired by perf season: NO TESTING BEYOND CQ. Thanks for accepting this :) Bug: 998712 Change-Id: I330bda4ac47d2cda4b70a15a5a0c26174028723e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1784602Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Christopher Grant <cjgrant@chromium.org> Commit-Queue: Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#693145}
-
Jason Chase authored
Update the expiry to M81. We expect to move the related features to use Document Policy, meaning a new origin trial is likely. With expiry in M81 that would match if a new trial started in M79 (i.e. trial runs for M79-M81). That is, developers can then use this flag to test policies locally for the duration of a trial. Bug: 906163 Change-Id: Id40adcb0f77c3441635f47407a06af9d5828248b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783065Reviewed-by:
Ian Clelland <iclelland@chromium.org> Commit-Queue: Jason Chase <chasej@chromium.org> Cr-Commit-Position: refs/heads/master@{#693144}
-
Rayan Kanso authored
There are metrics that rely on the background recording service, which in turn uses the history service that runs on its own thread. That caused that test to be flaky, so this fix creates a test-only closure that is run after the metric has been recorded to make it determenistic. Bug: 998049 Change-Id: I88ead36796ef07fadf348e1da686b5b200c17509 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783152Reviewed-by:
Richard Knoll <knollr@chromium.org> Commit-Queue: Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#693143}
-
Roger Tawa authored
This policy is checked if scanning for malware on uploads is enabled. Only URLs whose host is in this list will be scanned. Also adds enum values to SendFilesForMalwareCheck to handle case of malware check during uploads. Bug: 991553 Change-Id: I55dd5529a0438cf375272c808102c2b9a8fe4f5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782513 Commit-Queue: Roger Tawa <rogerta@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#693142}
-
Nico Weber authored
Bug: 997673 Change-Id: Ibe3c484630173772f7dc457ee85856b68ab84a36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1784617 Commit-Queue: Nico Weber <thakis@chromium.org> Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Mirko Bonadei <mbonadei@chromium.org> Cr-Commit-Position: refs/heads/master@{#693141}
-
Lutz Justen authored
First batch of KerberosCredentialsManager unit tests. Also adds a test interface to FakeKerberosClient to - Set the task delay (tests set it to 0 to speed up the tests), - Record which functions are called for testing. BUG=chromium:952251 TEST=Unit tests succeed Change-Id: I14b3790d1dfb9809e0bc6b7b59a9b58d196e1929 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760951 Commit-Queue: Lutz Justen <ljusten@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Lutz Justen <ljusten@chromium.org> Auto-Submit: Lutz Justen <ljusten@chromium.org> Cr-Commit-Position: refs/heads/master@{#693140}
-
Michael Spang authored
GN doesn't understand conditional includes: ERROR at //chrome/utility/services.cc:74:11: Include not allowed. ^--------------------------------------------------------------------- It is not in any dependency of //chrome/utility:utility The include file is in the target(s): //components/services/pdf_compositor/public/mojom:mojom //components/services/pdf_compositor/public/mojom:mojom__generator at least one of which should somehow be reachable. Bug: 1000645, b/140414631 Change-Id: I94ab9df85f9c50f1999acec999e8c06a93eea6b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1784098 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:Nico Weber <thakis@chromium.org> Auto-Submit: Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#693139}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/b132e5cc..2e9e9171 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I4a23301c78f860c8263ade5f2250cf579b0f6068 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1784446Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#693138}
-
Mark Cogan authored
This CL set up the iOS app configuration needed for multi-window. This includes (a) a bunch of specific Info.plist additions, and (b) a storyboard file to be used as a default by each scene. These files are added if the gn argument ios_enable_multi_window is set to 'true'. By default it is 'false'. Note that enabling this arg will, in Chromium's current state, cause the app to launch with an empty window and do nothing (because there's no class to load as the scene delegate). Follow-up CLs will fill that gap, but they need the plist and storyboard in place first. Change-Id: I61e153cd2d5d5df12bbd6347151f864e44a2d4ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782815 Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#693137}
-
Andrei Chulkov authored
This CL adds Java code that retrieves the "story" parameter from the PasswordManagerOnboardingAndroid feature and sets sets the correct image accordingly. Bug: 983445 Change-Id: I53e046562faac7b26fe9f81feaad87786444a563 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1781642 Commit-Queue: Andrei Chulkov <achulkov@google.com> Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#693136}
-
Yasmin authored
Rename ClickToCallDialogtype to be used by other sharing features. Bug: 988461 Change-Id: I463868c7aae091a00cdd69cf139f9b84ca425ba8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778542 Commit-Queue: Yasmin Molazadeh <yasmo@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#693135}
-
Julie Jeongeun Kim authored
This CL converts HyphenationRequest and HyphenationPtr to new Mojo types. Bug: 955171, 978694 Change-Id: I3be08953612cc01ea30d1f2ed65ea971df263b9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778898 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
-
Dave Tapuska authored
No shadowing was enabled for base code but not the unittests. Add the config to the unittest component as well and fix issues. BUG=794619 Change-Id: Ia23a007d8fc66d4ad6a2f1682d09b31894caae81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776791Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#693133}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/154adeb6c998..630b14f4812c Created with: gclient setdep -r src-internal@630b14f4812c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I8ce43ac75d25af00466495089e8f7df8cda2057d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783811Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#693132}
-
Xiaocheng Hu authored
This patch fixes a regression introduced by crrev.com/c/1744799. Before the regression, the creator divides the pixel value of the length by the zooming after. The above patch incorrectly changed that into multiplication, which is the regression. This patch changes that back into a division. Bug: 999875 Change-Id: Ic5f07c2af52cdc94bde8b355e5c30a7f01c0a49c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783638 Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
-
chrome://flagsdalyk authored
The flag will only be shown on Mac OS, Windows, Chrome OS, and Android. Bug: 985589 Change-Id: I816e70d3cd2941cb10a041c4c2403782ed5efc74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1779078Reviewed-by:
Eric Orth <ericorth@chromium.org> Commit-Queue: Katharine Daly <dalyk@google.com> Cr-Commit-Position: refs/heads/master@{#693130}
-
