- 19 Jan, 2018 40 commits
-
-
Vadim Tryshev authored
There are some possible cleanups around StartPageService and SearchResourceManager that I plan for a separate CL. Bug: 781407 Change-Id: I9c9042e46d792bf5cf06fb0dc1c29cd8f6edb560 Reviewed-on: https://chromium-review.googlesource.com/874812 Commit-Queue: Vadim Tryshev <vadimt@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#530393}
-
Hayato Ito authored
See the discussion at https://github.com/whatwg/dom/pull/336 for details. Blink implemented it at https://codereview.chromium.org/2384403002, however, it turned out that both the web platform test and the implementation were wrong. This CL fixed the implementation, as well as the web platform test. Compatibility risk is almost none about this change. Bug: 655494 Change-Id: I084cd6b748c304f5f2b395f0b62ba02025385a98 Reviewed-on: https://chromium-review.googlesource.com/869693Reviewed-by:
Takayoshi Kochi <kochi@chromium.org> Commit-Queue: Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#530392}
-
Xing Liu authored
Currently Mojo Android bot can successfully build but will yields NoDevicesError. The cause might be the builder targets arm64 where default device list is arm32. This CL adds the correct device dimension. Bug: 783374 Change-Id: Id5edc08a62d6c1b8a08dde179ae849f4c6511fd7 Reviewed-on: https://chromium-review.googlesource.com/875250Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#530391}
-
Eric Lawrence authored
Update the HSTS preload list with manually-requested entries. TBR=palmer@chromium.org Change-Id: I7aadcbc4da452dc918226112b3085afa70892a20 Reviewed-on: https://chromium-review.googlesource.com/875255Reviewed-by:
Eric Lawrence <elawrence@chromium.org> Commit-Queue: Eric Lawrence <elawrence@chromium.org> Cr-Commit-Position: refs/heads/master@{#530390}
-
rbpotter authored
Bug: 792093 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I440a159be2cb7b1d393b041c3446349dfe8289fe Reviewed-on: https://chromium-review.googlesource.com/871511 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#530389}
-
Robert Ma authored
Importer is now trying to remove baselines for test with query strings in the names, e.g. https://chromium-review.googlesource.com/c/chromium/src/+/874798/1 We were lucky as the CL above didn't cause any actual damage (the rebaseline step added all removed baselines back), but it's too risky. Temporarily disable this feature before I fix it. TBR=qyearsley Bug: 800570 Change-Id: Id1f4b484badb7e2a651dbf6e37ccffe3d25fe7eb Reviewed-on: https://chromium-review.googlesource.com/874726Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#530388}
-
Jia authored
Bug: 784232 Change-Id: I72a9f20cbacba3a9dfc6b914094da573d61c6153 Reviewed-on: https://chromium-review.googlesource.com/874975Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Jia Meng <jiameng@chromium.org> Cr-Commit-Position: refs/heads/master@{#530387}
-
Karan Bhatia authored
This CL removes a duplicated dependency in a BUILD.gn file defined for DNR. BUG=696822 Change-Id: I29772cbd07a09bf630644c11ac977871896ca376 Reviewed-on: https://chromium-review.googlesource.com/875129Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#530386}
-
Simon authored
This way of sending try jobs is deprecated. Print an error message and redirect users to the docs on using Pinpoint. Running with trybot will produce this message: ERROR: This command has been removed. Please visit https://chromium.googlesource.com/chromium/src/+/master/docs/speed/perf_trybots.md for up-to-date information on running perf try jobs. Bug: 770009 Change-Id: I6c22aff02d76d56fad40b6fdaf167b16d22c3489 Reviewed-on: https://chromium-review.googlesource.com/874814 Commit-Queue: Simon Hatch <simonhatch@chromium.org> Reviewed-by:
Annie Sullivan <sullivan@chromium.org> Cr-Commit-Position: refs/heads/master@{#530385}
-
MinChen authored
[Reland]cros: Manual revert rename TabletPowerButtonController to ConvertiblePowerButtonController and create PowerButtonUtil. changes in this cl, Since we will put the logic of power button menu in TabletPowerButtonController instead of creating a new controller. Reverting related previous cls, 1. Revert rename TabletPowerButtonController to ConvertiblePowerButtonController. Related cl, https://chromium-review.googlesource.com/c/chromium/src/+/852518 2. Revert the creating of PowerButtonUtil. Related cl, https://chromium-review.googlesource.com/c/chromium/src/+/852905 Bug: 799524 Change-Id: I70eabc0436873149598c53c3caf3851958427a88 Reviewed-on: https://chromium-review.googlesource.com/875324Reviewed-by:
Dan Erat <derat@chromium.org> Commit-Queue: min c <minch@chromium.org> Cr-Commit-Position: refs/heads/master@{#530384}
-
Alex Moshchuk authored
This is a followup to address https://chromium-review.googlesource.com/c/chromium/src/+/871523/3/content/browser/frame_host/render_frame_host_manager.cc#2036 Bug: 802156 Change-Id: I1f261f4e0ca26e8c700a13ad15a76027d681d39c Reviewed-on: https://chromium-review.googlesource.com/875243Reviewed-by:
Charlie Reis <creis@chromium.org> Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#530383}
-
Giovanni Ortuño Urquidi authored
This reverts commit 304ec7f2. Reason for revert: The original patch enabled the back button on all Hosted App windows. This included Desktop PWA Hosted Apps that had a manifest with display:standalone which explicitly requests for no browser controls. Reverting this change for now until we can disable the back button for Desktop PWA Hosted Apps. Original change's description: > Enable V1app backbutton by default > > Added about flag in case for troubleshooting. > > BUG=749713 > TEST=manual > > Change-Id: I2f74535282bb8dccca38a4d8ad6f10af88140c62 > Reviewed-on: https://chromium-review.googlesource.com/860522 > Commit-Queue: Mitsuru Oshima <oshima@chromium.org> > Reviewed-by: Michael Wasserman <msw@chromium.org> > Cr-Commit-Position: refs/heads/master@{#529074} TBR=msw@chromium.org,oshima@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 749713 Change-Id: I9d405002dc9061d42f4acb7575b4e7c08e8ce925 Reviewed-on: https://chromium-review.googlesource.com/874491Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#530382}
-
Mark Pearson authored
Bug: Change-Id: Iffcdf7971cd0842b470e4a215ff1be026d8f4c8f Reviewed-on: https://chromium-review.googlesource.com/865832Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#530381}
-
Bill Budge authored
- Raises the limit of direct mapped allocations. WASM needs to be able to allocate 2GiB regions. Bug: chromium:801604 Change-Id: I77e905ff4ae6f5ca66de9daf30f19bb6f7b54089 Reviewed-on: https://chromium-review.googlesource.com/875301Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Bill Budge <bbudge@chromium.org> Cr-Commit-Position: refs/heads/master@{#530380}
-
Brandon Jones authored
Allows exclusive XRSessions to submit frames to the XR compositor, which enables the most basic end-to-end usage of the API. Bug: 670510 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I704aaac3325538e2db8f8b6d6f8d341492835a14 Reviewed-on: https://chromium-review.googlesource.com/871790 Commit-Queue: Brandon Jones <bajones@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#530379}
-
George Burgess IV authored
Without this, you need to change the AFDO filename every time if you want the world to be rebuilt. Bug: 794750 Test: touched an AFDO profile; ninja tried rebuilding ~21K files. Change-Id: I802feac51c52d66072860d2f341d7f88d10fdef1 Reviewed-on: https://chromium-review.googlesource.com/875137Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: George Burgess <gbiv@chromium.org> Cr-Commit-Position: refs/heads/master@{#530378}
-
Ken Rockot authored
This was disabled on Chrome OS + ASAN due to flakiness. I suspect the flakiness is caused by use of fork() in a multithreaded environment, via base::GetAppOutputAndError. This CL changes the offending test to not use the ContentBrowserTest fixture and instead simply call base::GetAppOutputAndError from a single-threaded unit test. The manually launched browser test in the launched subprocess remains unchanged. Renames the browser test fixture to ServiceManagerContentBrowserTest to disambiguate from the new non-browser-test test case. Bug: 803188 Change-Id: I5d1be42cb35ccc6ec79ed1cbda83018291aecaa2 TBR=jam Change-Id: I5d1be42cb35ccc6ec79ed1cbda83018291aecaa2 Reviewed-on: https://chromium-review.googlesource.com/875269 Commit-Queue: Ken Rockot <rockot@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#530377}
-
Thomas Guilbert authored
MediaPlayerRendererClient owns a StreamTextureWrapper via a unique_ptr with a custom deleter. The STW owns a StreamTextureProxy, which periodically calls back to the MPRC on the compositor thread. The STW's custom deleter starts by clearing the STP's callback into the MPRC. However, it is possible for the STP to start running the callback, just as the MPRC is being destroyed. The STW's unique_ptr is nulled, and the custom deleter blocks on the lock protecting the STP's callback. Simultaneously, the STP calls back in the MPRC, and tries to use a null STW pointer. This CL fixes the issue by making sure that the first thing that happens during the MPRC's destruction is clearing the STP's callback. This means that if there is simultaneously a call to the MPRC's dtor and the STP's callback, one of two things will happen: - The STP acquires the lock, the MPRC's destruction blocks, the callback completes successfully, the MPRC acquires the lock, the STP's callback is cleared and the MPRC is destroyed. - The MPRC acquires the lock, the STP blocks, the MPRC clears the STP's callback and continues its destruction, the STP acquires the lock and does not run the callback. Bug: 688466 Test: Manual sanity check Change-Id: I12904a788b8a8e9c7238fb952c497b41dd8f7d6b Reviewed-on: https://chromium-review.googlesource.com/875300Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#530376}
-
edchin authored
This CL achieves several objectives: 1) Removes the use of |rootViewController| to present UI. 2) Separates launching from the policy decider logic. The tab helper holds the policy decider logic. The app launcher coordinator does the actual app launching. 3) Better naming: "ExternalAppLauncher" was renamed to "AppLauncher". It is more concise, and "external" did not provide any value as there is no "internal app". 4) Better folder structure: the tab helper was pulled out to it's own folder /chrome/browser/app_launcher. The app launcher coordinator lives in /chrome/browser/ui/app_launcher. 5) Unit tests were added to the coordinator and tab helper. Bug: 791792 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I53ab441db05b85211102df169a264f0fcf53195c Reviewed-on: https://chromium-review.googlesource.com/837725 Commit-Queue: edchin <edchin@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#530375}
-
Sorin Jianu authored
TBR: kenrb@chromium.org Bug: 798476, 802828 Change-Id: I62f25924477f4d281483063bfb0a56b93252db90 Reviewed-on: https://chromium-review.googlesource.com/875294Reviewed-by:
Sorin Jianu <sorin@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#530374}
-
Peter Kasting authored
This applies the Harmony "toast" spacing values, using margins (a la the find bar). BUG=686285 TEST=none Change-Id: I6e60008ec44030661dabcd4d959229d76ee8f833 Reviewed-on: https://chromium-review.googlesource.com/875140Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#530373}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 4e871d8f. With Chromium commits locally applied on WPT: e8a79119 "Fixed wpt csp reporting tests and moved over chrome internal ones" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/10312 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md TBR=kereliuk No-Export: true Change-Id: I78df91b1009dc663433d267f7d12aa8d1afbdfd1 Reviewed-on: https://chromium-review.googlesource.com/874798 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#530372}
-
Jian Li authored
Thee're some differences between RFC 2047 which we should be used to encode header value and RFC 2045 for body: 1) Use CRLF+SPACE for soft line break. 2) SPACE and TAB should always be encoded. 3) Multiple encoded text should be used Did manual test with FAR file manager w/ Observer plugin and 7-Zip w/ eDecoder plugin. Bug: 794835 Change-Id: I5b87b7392d2208dd58bf512c7ee59c87bc32a85a Reviewed-on: https://chromium-review.googlesource.com/835009Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Jian Li <jianli@chromium.org> Cr-Commit-Position: refs/heads/master@{#530371}
-
Conley Owens authored
This change replaces the NewTabPageInterceptorService with a NewTabPageNavigationThrottle. The throttle reduces complexity, but it is also neutral regarding the network stack / network service, so it fixes the NewTabPageInterceptorServiceTests that were broken with the NetworkService feature enabled. These tests are now renamed NewTabPageNavigationThrottleTest. BUG=802926 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: Iec0664df33e79d6bcc18f60aecc4017de7f65858 Reviewed-on: https://chromium-review.googlesource.com/868994 Commit-Queue: Conley Owens <cco3@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#530370}
-
Eric Stevenson authored
This makes errors more readable and easier to debug. Bug: 771347 Change-Id: I4203e1fb4c9dbe76b58928369d6fc373590f6980 Reviewed-on: https://chromium-review.googlesource.com/874951Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#530369}
-
Artur Khachatryan authored
Test testGoBackAndGoForward appears to be flaky for Linux and mac platforms. Disabling test execution for those platforms. Test fails with the following error: UnknownError: unknown error: session deleted because of page crash from unknown error: cannot determine loading status from tab crashed (Session info: chrome=65.0.3324.0) (Driver info: chromedriver=2.35.530041 (c39e772a),platform=Linux 4.4.0-109-generic x86_64) Bug: chromium:803678 Change-Id: I7a4f0c5fd5cb9255b57e2e3e248e7d51787c0939 Reviewed-on: https://chromium-review.googlesource.com/875303Reviewed-by:John Chen <johnchen@chromium.org> Commit-Queue: Artur Khachatryan <khachatryan@chromium.org> Cr-Commit-Position: refs/heads/master@{#530368}
-
Bailey Berro authored
https://chromium.googlesource.com/chromiumos/platform/system_api.git/+log/15e1a468124f..1b879ee32f68 $ git log 15e1a4681..1b879ee32 --date=short --no-merges --format='%ad %ae %s' 2018-01-16 baileyberro smbprovider: Add DeleteEntryOptions protobuf to systemapi Created with: roll-dep src/third_party/cros_system_api Change-Id: Ib6852f507035e874f326e834c89be5a856a5286f Reviewed-on: https://chromium-review.googlesource.com/875232Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Commit-Queue: Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#530367}
-
erikchen authored
There's currently no mechanism to wait until profiling has started. This means that the results are racy, and sometimes don't contain heap dumps for the respective processes. Bug: 803568 Change-Id: I28b4ba5f741daaec7a8933cfd6c028abb8f83822 Reviewed-on: https://chromium-review.googlesource.com/874796Reviewed-by:
Dmitry Skiba <dskiba@chromium.org> Reviewed-by:
Maria Khomenko <mariakhomenko@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#530366}
-
Ted Meyer authored
https://chromium.googlesource.com/chromium/third_party/ffmpeg.git/+log/b64dedac9d1d..3e444ad8860b $ git log b64dedac9..3e444ad88 --date=short --no-merges --format='%ad %ae %s' 2018-01-17 tmathmeyer avcodec/arm/sbrdsp_neon: Use a free register instead of putting 2 things in one 2018-01-17 tmathmeyer Revert "Temporary fix for crbug/796028" Created with: roll-dep src/third_party/ffmpeg Change-Id: I007811a3f579db47dab19734c3e781d7103c82ac Reviewed-on: https://chromium-review.googlesource.com/871503Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#530365}
-
Victor Costan authored
Bug: 803669 Change-Id: Ia7368424b310f58883a9d76ec4abba711a26464c Reviewed-on: https://chromium-review.googlesource.com/875267 Commit-Queue: Victor Costan <pwnall@chromium.org> Commit-Queue: Joshua Bell <jsbell@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#530364}
-
Scott Violet authored
This avoids a PostTask and is needed for moving loading of local state earlier (when ResourceBundle won't be loaded). BUG=800358 TEST=covered by tests Change-Id: I7336dbec6474b0d29aa8596110f9c13ad5128148 Reviewed-on: https://chromium-review.googlesource.com/868735 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#530363}
-
Kent Tamura authored
The first CL generated by the tool is expected to break build, and the second CL generated by the tool is too large. We should fix build issues rather than reverting the CL. Bug: 578345 Change-Id: Ieee3f3a4a085759b345a844010c02664a3f45d1e Reviewed-on: https://chromium-review.googlesource.com/872814Reviewed-by:
Quinten Yearsley <qyearsley@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#530362}
-
Daniel Cheng authored
This is simlar to base::LazyInstance<T>::Leaky but intended for use in function-local scope. This is intended to be a drop-in replacement for: - CR_DEFINE_STATIC_LOCAL(...); in function scope - static T* x = new X; in function scope - static T& x = *new X; in function scope - base::LazyInstance<T> x; in global scope and should be preferred in new code. Change-Id: I75eda47e7dca8205f4086bd298839c261454a3e7 Reviewed-on: https://chromium-review.googlesource.com/869351 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#530361}
-
Yuichiro Hanada authored
When seeing a reserved keyboard shortcut, exo display server sends keyboard leave/enter event with pressed keys information instead of key events. only one IME is enabled. Bug: 801088 Test: Manual. Confirm that Ctrl-Space is sent to Android apps when Change-Id: I207434b45690f231601cb6187e35a806f8c69f89 Reviewed-on: https://chromium-review.googlesource.com/866655Reviewed-by:David Reveman <reveman@chromium.org> Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/heads/master@{#530360}
-
Renee Wright authored
Bug: 775360 Change-Id: I27ee051b48ca02cd6021638fb6a269a584b41384 Reviewed-on: https://chromium-review.googlesource.com/872692Reviewed-by:
nainar <nainar@chromium.org> Commit-Queue: Renée Wright <rjwright@chromium.org> Cr-Commit-Position: refs/heads/master@{#530359}
-
Sorin Jianu authored
TBR: creis Bug: 803641 Change-Id: I72aec7f22a7e9af818e9b27576a378095b8d4f46 Reviewed-on: https://chromium-review.googlesource.com/875189Reviewed-by:
Sorin Jianu <sorin@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#530358}
-
Daniel Bratell authored
The GetLocalState() method in cryptauth clashes with another GetLocalState() in jumbo builds, and since there is only one caller off this one, it might as well be inlined. Bug: 746957 Change-Id: I63e33c5c94930cd0dfeaa27c1421ce81c9865feb Reviewed-on: https://chromium-review.googlesource.com/873922Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#530357}
-
Eric Lawrence authored
Update entries in the HSTS preload list. TBR=palmer@chromium.org Change-Id: Idee0e0204f0027747fab7db2f45e7338a7c00bd3 Reviewed-on: https://chromium-review.googlesource.com/874600Reviewed-by:
Eric Lawrence <elawrence@chromium.org> Commit-Queue: Eric Lawrence <elawrence@chromium.org> Cr-Commit-Position: refs/heads/master@{#530356}
-
Patti authored
r530031 converted all the icons used in Page Info to vectors. Delete all the unused permissions icons that were previously used. Bug: 535074, 647551 Change-Id: Ic4e6648f61751ffa16a7afeb6f61f8a9088cdd3b Reviewed-on: https://chromium-review.googlesource.com/872471Reviewed-by:
Martin Šrámek <msramek@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Patti <patricialor@chromium.org> Cr-Commit-Position: refs/heads/master@{#530355}
-
Hector Carmona authored
This will make the code/error association very explicit by keeping the code snippet near the stack trace inside the error that is being investigated. See bug for screenshots/video. Bug: 800994 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I7a781bd304b498edf2a5b19d58635824a54a575b Reviewed-on: https://chromium-review.googlesource.com/861915 Commit-Queue: Hector Carmona <hcarmona@chromium.org> Reviewed-by:
Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#530354}
-