- 16 Jan, 2020 40 commits
-
-
Dan Harrington authored
Change-Id: I61465c05b77282e229bf472a57f044c092fe4079 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001121 Commit-Queue: Carlos Knippschild <carlosk@chromium.org> Auto-Submit: Dan H <harringtond@chromium.org> Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Cr-Commit-Position: refs/heads/master@{#732246}
-
Sara Kato authored
Currently arc_a11y_helper_bridge converts mojom actions to android actions, however it's cleaner if this handling is done in arc_a11y_util. Bug: b/145316954 Test: refactoring Test: ArcAccessibilityHelperBridgeTest.* passes Change-Id: I48e1367a479bfc2d44664c2c4de6ce96eda44daf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975478 Commit-Queue: Sara Kato <sarakato@chromium.org> Reviewed-by:
Hiroki Sato <hirokisato@chromium.org> Reviewed-by:
Sara Kato <sarakato@chromium.org> Cr-Commit-Position: refs/heads/master@{#732245}
-
Hiroki Sato authored
This change adds an extension API to set touch mode in ARC, which will be used in tast test. Bug: b:147116837 Test: tast run DUT arc.Accessibility* (crrev/c/1999865) Change-Id: I4bfdc11c5fec41e45207ceeffa0be0c985b172c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1997436 Commit-Queue: Hiroki Sato <hirokisato@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Cr-Commit-Position: refs/heads/master@{#732244}
-
Alex Newcomer authored
Increase for a few more milestones, this is soon to be deprecated. Bug: 1037252 Change-Id: I06d316ebd227a2938fff54196c3d86ce5e7ad6d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998459 Commit-Queue: Alex Newcomer <newcomer@chromium.org> Auto-Submit: Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#732243}
-
Alexandre Courbot authored
This member is only used in one method, and its initialization is very simple: image processor if present, otherwise decoder. So perform this choice in the method where it is actually used instead of carrying this member for the whole life of the decoder and making sure it is updated properly, at the risk of introducing bugs. BUG=None TEST=Video playback working on Hana. Change-Id: I52e23fae9edb057ed618c2da0834f60ae88fccf4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002249 Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Auto-Submit: Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
David Staessens <dstaessens@chromium.org> Cr-Commit-Position: refs/heads/master@{#732242}
-
Kent Tamura authored
This CL should have no behavior changes. Bug: 1040826 Change-Id: Iac5efeac96ddf437e3aa389c0669b0e19b131894 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002268 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#732241}
-
Rachel Sugrono authored
Rename test helper to follow the convention of other helper code that traverses into the shadow DOM. Bug: 907380 Change-Id: I7f6ee251a08995aa6b4052f7a87f4d6e3230414b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003154 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#732240}
-
Michael Spang authored
This exception shouldn't be necessary after e93c224e ("Make exclude_unwind_tables only dependent on is_official_build") as Chromecast does set is_official_build for release builds. Bug: 1040148 Change-Id: Ifb0d9c2e7388de287594487aba7abc866e3ab18c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993742 Commit-Queue: Michael Spang <spang@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#732239}
-
Sadrul Habib Chowdhury authored
Notify the trackers when a begin-main-frame processing is complete, so that the tracker can verify (with DCHECKs) that it is notified of the events in a well-defined and expected sequence. At the moment, there are synthesized 'begin main frame' notifications to the trackers that prohibit the DCHECK()s to be added, but we will be turning those on in follow up CLs. BUG=1021963 Change-Id: I01e8bb2d869a1707b6a1b412fdab0cadfde12255 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995461 Commit-Queue: Xida Chen <xidachen@chromium.org> Reviewed-by:
Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#732238}
-
Avery Musbach authored
Bug: None Change-Id: I0b5c75f9134472428d7510a1370388c63dd518e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003926Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Commit-Queue: Avery Musbach <amusbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#732237}
-
Aliaksei Shmanai authored
New string field input_source_description would contain a description of current media input source. For example, if some device has two AUX inputs, this filed could contain 'Left AUX'. Bug: internal b/118644722 Change-Id: I8a75f9663d8a4b0553eaa0ed177c7fc1af1bef4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880274Reviewed-by:
Luke Halliwell (slow) <halliwell@chromium.org> Commit-Queue: Luke Halliwell (slow) <halliwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#732236}
-
Theresa Wellington authored
BUG=1042092 TBR=juncai@chromium.org Change-Id: I5ed0d8b0ce326b216fc9527faff72c008292b16b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003302Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#732235}
-
Maksym Onufriienko authored
Bug: 1033112 Change-Id: I3ca2f000362ae4bf879363d8ca60cc82266acf8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998581 Commit-Queue: Maksym Onufriienko <monufriienko@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#732234}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/aea3d43d0b6a..f7d73bb52028 git log aea3d43d0b6a..f7d73bb52028 --date=short --first-parent --format='%ad %ae %s' 2020-01-15 wenbinzhang@google.com [Benchmarking] Add timeout for TakeScreenshot on Mac Created with: gclient setdep -r src/third_party/catapult@f7d73bb52028 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC wenbinzhang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1036447 Tbr: wenbinzhang@google.com Change-Id: I8e09cb2b91af02bbd32df088282afd32dc923b11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003759Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#732233}
-
Francois Marier authored
Bug: 1042139 Change-Id: Iec292ab19216670c2c947218313ae21ac4273158 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001855 Auto-Submit: Francois Marier <francois@brave.com> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#732232}
-
Tom Anderson authored
This is a reland of 5f865cce Original change's description: > Ignore weak undefined symbols when calculating dpkg dependencies > > This is needed after [1] used weak undefined symbols to test feature > support in libgbm. The dependencies for the Chrome debian package are > unchanged before/after this change. > > [1] https://chromium-review.googlesource.com/c/chromium/src/+/1988382 > > BUG=1031269 > R=thestig,thakis > CC=spang > > Change-Id: I760033d5883bf65a5a39316ea382766ae3754088 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992340 > Reviewed-by: Nico Weber <thakis@chromium.org> > Reviewed-by: Lei Zhang <thestig@chromium.org> > Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> > Cr-Commit-Position: refs/heads/master@{#730271} Bug: 1031269 Change-Id: I1975969c780e5b7e2d9974526a8527a4f3d36143 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001578 Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#732231}
-
Prabir Pradhan authored
After certain UX concerns regarding exiting pointer capture have been addressed, the pointer-lock protocol can be enabled for ARC windows. This change makes it so that the kExoPointerCapture flag no longer affects ARC windows and only affect Crostini windows. See go/exo-pointer-lock for more information. Bug: b/114112168 Test: manual testing using ArcPointerCaptureTestApp Change-Id: I2f54e587c40bccbbf38e630dbfaff0896c321771 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992188 Commit-Queue: Prabir Pradhan <prabirmsp@chromium.org> Auto-Submit: Prabir Pradhan <prabirmsp@chromium.org> Reviewed-by:
Nic Hollingum <hollingum@google.com> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#732230}
-
Aaron Colwell authored
Fixing an inconsistency in the partition selection in WebContentsImpl::CreateNewWindow(). The original code appeared to be conflating SiteInstance selection with partition_id selection. This was causing crashes when a new SiteInstance, created by the target_url in the noopener case, resulted in a site URL that had a different storage partition ID.(e.g. chrome-guest://blah). This change avoids the crashes by separating the 2 concerns. partition_id selection is now the same between noopener and normal paths. The special noopener SiteInstance behavior is now handled by not providing a SiteInstance in the CreateParams. This triggers the creation of a new SiteInstance, that does not share a BrowsingInstance with the original source SiteInstance. It also defers setting the site URL until we get the network response and are ready to commit. This provides the desired behavior and makes this case more consistent with other navigation scenarios. Bug: 965611 Change-Id: I054c2f793138a2b373bac6c61b0a85368f0adb4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949285 Commit-Queue: Aaron Colwell <acolwell@chromium.org> Auto-Submit: Aaron Colwell <acolwell@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#732229}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/cc93308cee32..772588160e90 git log cc93308cee32..772588160e90 --date=short --first-parent --format='%ad %ae %s' 2020-01-15 jalyn@microsoft.com Animations: Scale timeline when moving slider with keyboard 2020-01-15 hongchan@chromium.org Clean up after ESM migration of front_end/web_audio 2020-01-15 kahinds@microsoft.com Add screenreader support for Animation tool 2020-01-15 alchiem@microsoft.com Adding new performance histograms for performance tool launch 2020-01-15 alchiem@microsoft.com Adding new performance histograms for memory tool launch 2020-01-15 tvanderlippe@chromium.org Update README with format and check command Created with: gclient setdep -r src/third_party/devtools-frontend/src@772588160e90 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1040646,chromium:1042102,chromium:963183 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ice42d3fccbb78c0ffa8b69db68e7a527555eb37d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003762Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#732228}
-
Michael Thiessen authored
The InstalledAppProviderTest suite uses AsyncTask, which apparently requires a BrowserTaskEnvironment for the AsyncTask to actually run (sometimes it runs anyways - I don't know why). Bug: 1041909 Change-Id: Ida7a8ee8296ce489b560cec00e3b0ca2c4d7d982 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003751 Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#732227}
-
Rakib M. Hasan authored
R=isamsonov@google.com TBR=robertma@chromium.org Bug: 986447 Change-Id: I2f0e1ea4cdfb7ec2fd207db283663ca9d71eaaf7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002900Reviewed-by:
Rakib Hasan <rmhasan@google.com> Commit-Queue: Rakib Hasan <rmhasan@google.com> Cr-Commit-Position: refs/heads/master@{#732226}
-
Lukasz Anforowicz authored
Fixed: 1042360 Change-Id: I5e0cc2859131d8524e72b46964b398242da6f81a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002943 Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#732225}
-
Meredith Lane authored
This reverts commit af5c4bc1. Reason for revert: Deterministically crashes MSAN and debug CrOS builds, first failure here: https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests/17319 Original change's description: > Fix message_center::MessageView::OnSlideOut UAF > > Bug: 983009 > Change-Id: Ie285c4035bfc4c45e27e5f3fd6c34280d9f4c2d2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001943 > Reviewed-by: Peter Beverloo <peter@chromium.org> > Commit-Queue: Matthew Denton <mpdenton@chromium.org> > Cr-Commit-Position: refs/heads/master@{#732131} TBR=peter@chromium.org,tengs@chromium.org,mpdenton@chromium.org Change-Id: Ib8a7cfeaa6c81fca58cee2cbff7102a20ca1a474 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 983009 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003167Reviewed-by:
Meredith Lane <meredithl@chromium.org> Commit-Queue: Meredith Lane <meredithl@chromium.org> Cr-Commit-Position: refs/heads/master@{#732224}
-
Margaret Mary Kearney authored
Updating banner across Chrome apps docs for deprecation Change-Id: Ib29fc705ad37cc21c46eb7eb23daccf089a6d300 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003112 Commit-Queue: Meggin Kearney <mkearney@chromium.org> Reviewed-by:
Meggin Kearney <mkearney@chromium.org> Reviewed-by:
Anthony LaForge <laforge@chromium.org> Auto-Submit: Meggin Kearney <mkearney@chromium.org> Cr-Commit-Position: refs/heads/master@{#732223}
-
Felipe Salazar authored
Per @thomasanderson, the current minimum requirement is GLIBC 2.19. Bug: b/145962051, b/147656572 Change-Id: I1625753c6b0a2332015b78394740f0dba5a01519 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003254Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Felipe Salazar <felipesalazar@chromium.org> Auto-Submit: Felipe Salazar <felipesalazar@chromium.org> Cr-Commit-Position: refs/heads/master@{#732222}
-
James Darpinian authored
In https://crrev.com/c/1991969 I added a new, faster way to disable ARB_texture_rectangle support in ANGLE's shader translator. This change starts using it in Chrome, replacing the earlier change introduced in https://crrev.com/c/1842223 Bug: angleproject:3770 Change-Id: Ica718828581b49efc34230f9f53f28fdec77eb67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992548 Commit-Queue: James Darpinian <jdarpinian@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#732221}
-
Yutaka Hirano authored
Introduce the following messages: - QuicTransport.SendFin - QuicTransportClient.OnIncomingStreamClosed Bug: 1011392 Change-Id: If15ffb5bc7e619489cfc6e748300247a56ec888b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993075Reviewed-by:
Victor Vasiliev <vasilvv@chromium.org> Reviewed-by:
Adam Rice <ricea@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#732220}
-
Ryan Sturm authored
This experiment is in canary/dev and should be moved to Beta. Bug: 1038774 Change-Id: I4fc9c44e2b68aa58f9eee7210a625103f45edb01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992684 Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#732219}
-
Alexander Dunaev authored
This CL continues the refactor of X11 drag'n'drop code. Here some more code that does not depend on Aura or Views is moved from views::DesktopDragDropClientAuraX11 into ui::XDragDropClient. Bug: 1014860 Change-Id: I34a81a4a10866850659cbe8c053fe396be303b0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2000113Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Alexander Dunaev <adunaev@igalia.com> Cr-Commit-Position: refs/heads/master@{#732218}
-
Lei Zhang authored
Guard plugin code with BUILDFLAG(ENABLE_PLUGINS) in enterprise_reporting and extensions sub-directories. Also exclude c/b/extensions/plugin_manager.* when plugins are disabled. Also make modified files lint free. Bug: 1027360 Change-Id: I60328f7dd8747da65d4ad0ae6507697186bf9af1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1997654 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Reviewed-by:
David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#732217}
-
Alex Newcomer authored
Just add a test. Bug: 1042405 Change-Id: If115f047374428247f5b0ca199c235f7030ad225 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003443 Commit-Queue: Alex Newcomer <newcomer@chromium.org> Commit-Queue: Manu Cornet <manucornet@chromium.org> Auto-Submit: Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Manu Cornet <manucornet@chromium.org> Cr-Commit-Position: refs/heads/master@{#732216}
-
Demetrios Papadopoulos authored
Previously these were defined at the global scope, which does not play well with the tools used for migrating to Polymer3. It also pollutes the global namespace. Bug: 1026426 Change-Id: I8e99c6f83e78a8ac8e1a4073102f60abe70c6448 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002002 Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#732215}
-
jonross authored
Viz is on by default. This change removes the feature check. There were two remaining usages of the check in tests, this updates them Both pass when ran locally. IncompatibleApplicationsBrowserTest itself should have been unaffected. At the time others couldn't repro locally, but never tried debugging on swarming. The bot which demonstrated the failure no longer exists. So let's bring it back on. TEST=IncompatibleApplicationsBrowserTest, CastContentGpuClient Bug: 936425, 850517 Change-Id: I193ec76f311b093f3f1aa6cf609238a3c313134d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001554Reviewed-by:
Patrick Monette <pmonette@chromium.org> Reviewed-by:
Sergey Volk <servolk@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#732214}
-
Zhuoyu Qian authored
This CL update the function CacheStorageContext::DeleteForOrigin and BrowsingDataCacheStorageHelper::DeleteCacheStorage to use dedicated Origin type instead of GURL. Bug: 598424 Change-Id: I744de003425372eddb015da97beae099adbdae57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1997435Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Commit-Queue: Zhuoyu Qian <zhuoyu.qian@samsung.com> Cr-Commit-Position: refs/heads/master@{#732213}
-
Jay Harris authored
Previously, Nautilus and Nemo would know that file handling web apps could handle files, but not what types of files. This meant that web apps would not show up in the "Open With" menus of these file handlers. The cause of this issue was two fold: 1. xdg-desktop-menu install my-file.desktop only runs update-desktop-database when installing a system wide desktop file (in Chrome, we only ever install in user mode). 2. update-desktop-database doesn't run on ~/.local/share/applications unless explicitly requested to. This meant that the mimeinfo.cache file in ~/.local/share/applications (which these file managers use to determine what apps can open different mime types) was not being updated. The fix is to run update-desktop-database $XDG_DATA_HOME/applications after installing a new entry in the desktop menu, to ensure mimeinfo.cache is updated. Bug: 1027994 Change-Id: Ia71fa4d49030ecec6622a5b0ab8e18facc303274 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002043 Commit-Queue: Jay Harris <harrisjay@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#732212}
-
Miguel Casas authored
This CL replaces the DRM specific XB30 with AB30 where appropriate, and adds the necessary entries to support AB30 with SCANOUT usage. Test: forcing RGBA_1010102 as DisplaySnapshot::PrimaryFormat, and allowing for only an opaque FB (ToT wants both opaque and normal) the primary plane of the device is indeed XB30 as per /sys/kernel/debug/dri/0/state). and gl_unittests --gtest_also_run_disabled_tests and ozone_gl_unittests --gtest_also_run_disabled_tests AB30 test cases passing. Bug: 949260 Change-Id: Ie1841763b059971460597eded768a9a9827914b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1960073Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Michael Spang <spang@chromium.org> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#732211}
-
Weiliang Chen authored
Create OverlayProcessorOnGpu class which is an empty class on gpu thread. This uses the helper class created on previous CL. Following CLs will fill out its functionalities and make use of it. This is CL 2/? for sending the overlay candidates directly. R=rjkroege Bug: 979788 Change-Id: I50fb4e11bead2d990477cc056e807705340b39f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985301 Commit-Queue: weiliangc <weiliangc@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#732210}
-
Kenneth Russell authored
This reverts commit cc0504e5. Reason for revert: speculative revert suspecting this CL as the cause of recently introduced test flakes Original change's description: > blink: Ensure correct shared image lifetime for static bitmap images. > > AcceleratedStaticBitmapImages created by WebGL rely on creating a > GL texture backing for a shared image to ensure the shared image > outlives the StaticBitmapImage. This in turn assumes that even if the > client explicitly destroys a shared image mailbox via > SharedImageInterface, they can continue to use this mailbox as long as > an associated representation is alive. This pattern is not something we > want to support. > > This pattern also means that when a mailbox is stored on > SharedImageInterface, we can not safely assume that the metadata > associated with it can be cached correctly. > > This change fixes this by transitioning WebGL to use the same factory > method for creating StaticBitmapImages as used by canvas2d. This in > turn also does the following: > > 1) Ensures that the correct texture target is plumbed through with the > StaticBitmapImage. > 2) Eliminates the needs to plumb an image and a release callback through > a bunch of code. Since the image now owns the release callback. > 3) Cleans up code in MailboxTextureHolder used to keep the mailbox's > texture backing alive. > 4) TransferToImageBitmap currently works by marking the resource as > lost, which means it can not be recycled. These redundant > reallocations are avoided with this change. > > R=kbr@chromium.org > > Bug: 1036142 > Change-Id: I8824aa8d03a48e35e39744cc30c9d0313dcbed08 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1996124 > Reviewed-by: Alexander Timin <altimin@chromium.org> > Reviewed-by: Klaus Weidner <klausw@chromium.org> > Reviewed-by: Kenneth Russell <kbr@chromium.org> > Commit-Queue: Khushal <khushalsagar@chromium.org> > Auto-Submit: Khushal <khushalsagar@chromium.org> > Cr-Commit-Position: refs/heads/master@{#732100} TBR=kbr@chromium.org,khushalsagar@chromium.org,altimin@chromium.org,klausw@chromium.org Change-Id: Ic8c98f5f67d7c93c7e401846d1ff508e2b7159dc No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1036142, 1017162, 1042446, 1042481 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003615Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#732209}
-
Kunihiko Sakamoto authored
This extends all active SignedExchange histograms until 2020-10-01, and updates histogram owners appropriately. Bug: 1039320,1039319,1039318 Change-Id: Ieec4e5b07425aa881a395e44c748b8dce76800a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2000405Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#732208}
-
Vladimir Levin authored
This patch gathers the metrics for rendersubtree activation in UMA. R=chrishtr@chromium.org Change-Id: Id431799f9ff145ddb6413e37e43be6708ba626a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1999319 Commit-Queue: Stephen Chenney <schenney@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#732207}
-