- 15 Sep, 2016 36 commits
-
-
catapult-deps-roller authored
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/8484270f6d2c..5148bd4b2be6 $ git log 8484270f6..5148bd4b2 --date=short --no-merges --format='%ad %ae %s' 2016-09-14 nednguyen Fix typo with setting chrome category in TimelineBasedMeasurement 2016-09-14 nednguyen Revert of Revert "[Clock sync] Use clock sync manager to convert trace event timestamps" (patchset #1 id:1 of https://codereview.chromium.org/2345463003/ ) 2016-09-14 charliea Revert "[Clock sync] Use clock sync manager to convert trace event timestamps" 2016-09-14 nduca Add benjhayden@ to tracing OWNERS 2016-09-14 nednguyen Add breakdown UI for TTI & FMP metrics TBR=catapult-sheriff@chromium.org Review-Url: https://codereview.chromium.org/2340943002 Cr-Commit-Position: refs/heads/master@{#418752}
-
bnc authored
Review-Url: https://codereview.chromium.org/2339473005 Cr-Commit-Position: refs/heads/master@{#418751}
-
wangxianzhu authored
When we invalidate a media control, we need to invalidate the whole subtree because not only the top-level layout object but also the descendants may paint differently. BUG=645225 TEST=paint/invalidation/video-play-no-source-under-invalidation.html Review-Url: https://codereview.chromium.org/2343713003 Cr-Commit-Position: refs/heads/master@{#418750}
-
einbinder authored
Also stop matched brackets from breaking through syntax highlighting. BUG=none Review-Url: https://codereview.chromium.org/2334073002 Cr-Commit-Position: refs/heads/master@{#418749}
-
asargent authored
When we changed content verification to strict mode (crbug.com/601512), it turns out that the code for downloading missing verified_contents.json files from the webstore had two longstanding bugs that we never noticed due to insufficient tests: a) Returning the results of a boolean expression as an integer b) Use after free of an object The end result is that when the patch for crbug.com/601512 hit stable, many users became unable to run the EFF's HTTPS Everywhere and Privacy Badger extensions because those are uploaded via a special process where the webstore does not have a copy of their private key and cannot include the verified_contents.json file in the .crx file; rather we rely on being able to download it after install but fail due to the above mentioned bugs. This patch fixes the bugs and also introduces a change which clears the corruption "disable reason" on extension autoupdate, so that users who had the extension disabled because of this bug can get it re-enabled automatically by an extension autoupdate. BUG=643814 Review-Url: https://codereview.chromium.org/2336403002 Cr-Commit-Position: refs/heads/master@{#418748}
-
wangxianzhu authored
BUG=637316 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2343673003 Cr-Commit-Position: refs/heads/master@{#418747}
-
arthursonzogni authored
This patch prevents the FrameLoader to send 'complete' notification when there is still a navigation handled by the client ongoing. This bug caused several tests to end too early and fail. In contrast, there were tests that passed previously, but actually fail. R=japhet@chromium.org BUG=576261 Review-Url: https://codereview.chromium.org/2269653002 Cr-Commit-Position: refs/heads/master@{#418746}
-
lshang authored
To prevent long search terms to go out of card-title bar. BUG=644229 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2318343004 Cr-Commit-Position: refs/heads/master@{#418745}
-
mostynb authored
The build should fail early if //device/media_transfer_protocol is included with dbus explicitly disabled. BUG=632297 Review-Url: https://codereview.chromium.org/2333573003 Cr-Commit-Position: refs/heads/master@{#418744}
-
thomasanderson authored
BUG=620169 R=dpranke@chromium.org Review-Url: https://codereview.chromium.org/2338373003 Cr-Commit-Position: refs/heads/master@{#418743}
-
agrieve authored
BUG=646165 Review-Url: https://codereview.chromium.org/2341903002 Cr-Commit-Position: refs/heads/master@{#418742}
-
mdjones authored
The "close all incognito tabs" notification can close tabs when chrome is not in the foreground. This action bypasses the animation that would ordinarily reset the normal button's opacity. In order to correctly reset this opacity, setIsIncognito will be called even if the button is not visible. BUG=642682 Review-Url: https://codereview.chromium.org/2335403004 Cr-Commit-Position: refs/heads/master@{#418741}
-
michaeln authored
BUG=584574 Review-Url: https://codereview.chromium.org/2333893002 Cr-Commit-Position: refs/heads/master@{#418740}
-
mdjones authored
BUG= Review-Url: https://codereview.chromium.org/2325623003 Cr-Commit-Position: refs/heads/master@{#418739}
-
littledan authored
BUG=chromium:646199 Review-Url: https://codereview.chromium.org/2340583004 Cr-Commit-Position: refs/heads/master@{#418738}
-
bpastene authored
Will switch to gce bot if nothing regresses. BUG= Review-Url: https://codereview.chromium.org/2338353002 Cr-Commit-Position: refs/heads/master@{#418737}
-
pdr authored
The PropertyTreeState does not include scroll information and should be renamed GeometryPropertyTreeState to reflect the real behavior. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2338373004 Cr-Commit-Position: refs/heads/master@{#418736}
-
gangwu authored
mplement SharedModelTypeProcessor::GetAllNodes for USS, so "Sync Node Browser" tab in chrome://sync-internals/ will show USS data. BTW, modelTypeWorker already ignore the root folder from server. BUG=645303 Review-Url: https://codereview.chromium.org/2319973003 Cr-Commit-Position: refs/heads/master@{#418735}
-
bnc authored
Minor cleanup after https://crrev.com/2217173002 to reduce code divergence. BUG=488484 Review-Url: https://codereview.chromium.org/2344613002 Cr-Commit-Position: refs/heads/master@{#418734}
-
rdevlin.cronin authored
SyncExtensionFunctions, AsyncExtensionFunctions, ChromeSyncExtensionFunctions, and ChromeAsyncExtensionFunctions are deprecated. Remove ChromeSyncExtensionFunctions from: - launcher_search_provider - hotword_private - i18n - identity - omnibox BUG=634140 Review-Url: https://codereview.chromium.org/2344653002 Cr-Commit-Position: refs/heads/master@{#418733}
-
mattm authored
This also removes the native hostname checking workarounds. BUG=570909,588789,621684 Review-Url: https://codereview.chromium.org/2101303005 Cr-Commit-Position: refs/heads/master@{#418732}
-
chrome://settingsmsw authored
Avoid Shell and PowerStatus access for display/power options. BUG=646558,548429,644348 TEST=No crash accessing chrome://settings in chrome --mash. R=stevenjb@chromium.org Review-Url: https://codereview.chromium.org/2341783005 Cr-Commit-Position: refs/heads/master@{#418731}
-
mariakhomenko authored
Adds new color for the launch button and changes star assets to match. Also changes to the new Play logo. BUG=646929 Review-Url: https://codereview.chromium.org/2335153003 Cr-Commit-Position: refs/heads/master@{#418730}
-
steel authored
This CL changes the extensions build to have BUILD.gn's in (almost) all leaf directories. This accomplishes several things, a.) Makes it very clear of what files belong to which component/API. For example, to see which files exist in the audio API, one needs to parse the massive single //extensions/browsers/BUILD.gn to find the main API source list, then look if any of the exception conditions (is_chromeos, is_linux, etc) also contain any of the audio API files. This is now all in one //extensions/browser/api/audio/BUILD.gn, making it easier to parse and understand the build of each component. b.) It makes dependencies clearer. Currently we have no idea which dependency in the huge dependency list in //extensions/browser/BUILD.gn is needed by which API. With individual build files, we can now specify dependencies for just the component that needs them. This CL tries to do this but some dependencies are used by enough components that we've just included them for all (//content/browser/public, //skia). This is not ideal but at worst, it is still much better than the current build. Since we're now moving APIs over from //chrome/browser/extensions over to //extensions/browser, this becomes even more important. All APIs that get moved over now can use this new format for their build files. jamescook@, rockot@, xiyuan@ - FYI R=rdevlin.cronin@chromium.org BUG=641155 Review-Url: https://codereview.chromium.org/2336843002 Cr-Commit-Position: refs/heads/master@{#418729}
-
rch authored
Review-Url: https://codereview.chromium.org/2347433003 Cr-Commit-Position: refs/heads/master@{#418728}
-
tedchoc authored
TEST=Actually use the feature. Turn on "Don't keep activities", leave a CCT, click on it from recents. See that your final page is visible. BUG=606513 Review-Url: https://codereview.chromium.org/2336413002 Cr-Commit-Position: refs/heads/master@{#418727}
-
hanxi authored
This class was supposed to delete when AddToHomescreenManager was introduced (https://codereview.chromium.org/2292133003/), but wasn't. Delete it now. Review-Url: https://codereview.chromium.org/2343433003 Cr-Commit-Position: refs/heads/master@{#418726}
-
horo authored
InstallEvent interface was introduced only for ForeignFetch. https://github.com/w3c/ServiceWorker/commit/98843d032cd668cda4c7e46f0e44245840cb5d4e But according to the spec we should use InstallEvent interface for install event. https://w3c.github.io/ServiceWorker/#execution-context-events So we will use InstallEvent interface even if ForeignFetch feature is disabled. BUG= Review-Url: https://codereview.chromium.org/2339083002 Cr-Commit-Position: refs/heads/master@{#418725}
-
steel authored
I haven't worked with audio in a while and am now missing enough context that I shouldn't be on the owners files. Removing myself. Need stevenjb's lgtm for removing me from //chromeos/dbus/OWNERS. R=jennyz@chromium.org, stevenjb@chromium.org BUG=None. Review-Url: https://codereview.chromium.org/2338263003 Cr-Commit-Position: refs/heads/master@{#418724}
-
msw authored
Move aura window properties to WmWindowAura. (towards supporting [Shelf]WindowWatcher in mash) Cleanup ShelfItem and ShelfItemDetails structs. Remove unused ash support for UserManagerView BUG=634150 TEST=Automated tests; no shelf functionality changes. R=sky@chromium.org Review-Url: https://codereview.chromium.org/2332393003 Cr-Commit-Position: refs/heads/master@{#418723}
-
twellington authored
The document mode migration code was changed in 4804efe6 to skip document mode migration if a shared preference was not set. On older versions of Chrome, that shared preference wasn't set even though the user was in document mode. Migration was skipped and all tabs were lost. Revert to the old logic of using another shared preference to help determine if the user is in document mode. BUG=646146 Review-Url: https://codereview.chromium.org/2340743004 Cr-Commit-Position: refs/heads/master@{#418722}
-
yusukes authored
This depends on https://chromium-review.googlesource.com/#/c/384594/ BUG=b:31254747 TEST=manually confirmed that the method is actually called Review-Url: https://codereview.chromium.org/2332153002 Cr-Commit-Position: refs/heads/master@{#418721}
-
takumif authored
This CL fixes the bug in which the media router dialog would sometimes fail to show on OSX. We make MediaRouterDialogDelegate::GetDialogSize() set the dialog size the first time it's called by WebDialogConstrainedWindowSheet::updateSheetPosition(), so that the custom window is not initialized with size 0. BUG=633403 Review-Url: https://codereview.chromium.org/2275413002 Cr-Commit-Position: refs/heads/master@{#418720}
-
ckrasic authored
R=asvitkine@chromium.org, rch@chromium.org BUG= Review-Url: https://codereview.chromium.org/2342663003 Cr-Commit-Position: refs/heads/master@{#418719}
-
qyearsley authored
This CL also adds more logging in update_w3c_test_expectations.py, and changes deps_updater.py to run this script with the --verbose flag. Purpose of this CL: 1. Make it easier to diagnose issues with w3c-test-autoroller in the future. 2. Start to make update-w3c-test-expectations better to use directly. BUG=643761 Review-Url: https://codereview.chromium.org/2337183002 Cr-Commit-Position: refs/heads/master@{#418718}
-
rockot authored
Introduces a new content::AssociatedInterfaceRegistry and content::AssociatedInterfaceProvider to serve as Channel-associated interface counterparts to their shell namesakes. RenderFrameHost and RenderFrame each have both of these things on them, and they're routed to the other side using a new RouteProvider interface buried in RenderProcessHostImpl / ChildThreadImpl on either end. Also adds a WebContentsInterfaceRegistry to every WebContents, and a helper WebContentsFrameBindingSet<T> to allow consumers to very easily manage the lifetime of associated interface bindings for each frame in a WebContents. See the follow-up patch for example usage. Part a series of CLs to enable and demonstrate WebContents associated interfaces: 1. https://codereview.chromium.org/2309513002 2. https://codereview.chromium.org/2316963005 3. This CL 4. https://codereview.chromium.org/2310583002 BUG=612500 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Review-Url: https://codereview.chromium.org/2310563002 Cr-Commit-Position: refs/heads/master@{#418717}
-
- 14 Sep, 2016 4 commits
-
-
derat authored
Add initial unit tests for chromeos::PowerManagerClient's suspend-delay-handling code. More coming soon. BUG=646912 Review-Url: https://codereview.chromium.org/2345593002 Cr-Commit-Position: refs/heads/master@{#418716}
-
skobes authored
This is to get feedback from canary users. It will be reverted on 2016-09-16. BUG=624074 Review-Url: https://codereview.chromium.org/2335363003 Cr-Commit-Position: refs/heads/master@{#418715}
-
sdy authored
Revert of BackgroundGradientView: -drawBackground: → -drawRect: (patchset #2 id:40001 of https://codereview.chromium.org/2336453002/ ) Reason for revert: AnimatableView inherits from BackgroundGradientView, so a number of other views which *don't* want backgrounds end up inheriting from BackgroundGradientView. This widened the scope of the change beyond what I intended. Original issue's description: > BackgroundGradientView: -drawBackground: → -drawRect: > > BackgroundGradientView had a -drawBackground: method that its clients > were expected to call. This change moves background drawing to > -drawRect: so that the it happens by default. > > Subclasses that did custom drawing already override -drawRect:, but this > removes a couple of overrides that just forwarded to -drawBackground:. > > BUG=589943 > > Committed: https://crrev.com/6b1939a26d2839136aeeba2aa0e359fce0c20281 > Cr-Commit-Position: refs/heads/master@{#418358} TBR=thakis@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=647018 Review-Url: https://codereview.chromium.org/2339143003 Cr-Commit-Position: refs/heads/master@{#418714}
-
xunjieli authored
Add a bool argument in FilterData() to signal that upstream's eof has been reached. R=rdsmith@chromium.org BUG=474859 Review-Url: https://codereview.chromium.org/2331193005 Cr-Commit-Position: refs/heads/master@{#418713}
-