- 27 Feb, 2018 40 commits
-
-
Ali Tofigh authored
This update is required for work that is underway related to management of Chrome browsers for enterprise users. The google_update_idl.idl file was originally provided by the Google Update team. It has been modified as described in the README.chromium file in this CL. The change was tested with Chrome-branded builds with target_cpu set to "x86" and "x64". I followed these steps to make sure that this change does not break Chrome updates. 1. Manully set the version of Chrome in src/chrome/VERSION to a version prior to that which is currently served on the Dev channel. 2. Compile with is_chrome_branded=true and target_cpu set to one of "x86" or "x64". 3. Install the build as a Dev-channel Chrome using setup.exe on a 64-bit Win10 machine. 4. Navigate to chrome://help and make sure that the update process works as expected. Bug: 796270 Change-Id: I6962b8874a7e825d41834860de0eb0fe92f5a6e3 Reviewed-on: https://chromium-review.googlesource.com/924474 Commit-Queue: Ali Tofigh <alito@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#539457}
-
Colin Blundell authored
The conversion is straightforward, getting the email address of the primary account from IdentityManager rather than SigninManager and AccountTrackerService. Straightforward unittest conversions are also made. NOTE: This CL was not tested manually as I don't know how to exercise this functionality. TBR=sdefresne@chromium.org Bug: 809435 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I7e145538b9e8634326a409c812b03a04c0254b05 Reviewed-on: https://chromium-review.googlesource.com/913390Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#539456}
-
Alexander Timin authored
Create base/task/task_scheduler and base/task/sequence_manager directories, add OWNERS files and README.md stub. R=gab@chromium.org BUG=783309 Change-Id: Ic30cfac8ce71e5f0553fcfb6c95e05750d15d265 Reviewed-on: https://chromium-review.googlesource.com/934444 Commit-Queue: Alexander Timin <altimin@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#539455}
-
Owen Min authored
Screenshot: https://drive.google.com/file/d/1H0fFnEPwxOtIwXQ_XOyChjaR-V88klKq/view?usp=sharing Bug: 803191 Change-Id: Ifdf428b592eb2c7bd497a40044e06a74338a247e Reviewed-on: https://chromium-review.googlesource.com/938631Reviewed-by:
Roger Tawa <rogerta@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#539454}
-
Gustav Sennton authored
Static WebView methods are implemented using the class WebViewFactoryProvider.Statics, in this CL we implement the corresponding class for the WebView support library. Bug: 816506 Change-Id: I3909a8f1b78a79ed06895da0611ca643231e1716 Reviewed-on: https://chromium-review.googlesource.com/939391Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Gustav Sennton <gsennton@chromium.org> Cr-Commit-Position: refs/heads/master@{#539453}
-
Gyuyoung Kim authored
RenderThreadImpl::ClearMemory has been purging only font cache in Skia. But, it would be good if we purge more cache data in RenderThreadImpl::ClearMemory, because it has mainly called under out of memory. I found SkGraphics::PurgeAllCaches purges more cache data, so this CL calls it instead of calling SkGraphics::SetFontCacheLimit. void SkGraphics::PurgeAllCaches() { SkGraphics::PurgeFontCache(); SkGraphics::PurgeResourceCache(); SkImageFilter::PurgeCache(); } Although I add a new test to measure if RenderThreadImpl::ClearMemory purges memory, it's not completed yet. But, this CL can be covered by tests for MemoryPressureListener. (i.e, RenderWidgetHostViewAuraTest.DiscardDelegatedFramesWithMemoryPressure.) Bug: None Change-Id: I6d702e02c84a04c98489bc3f20b52f55beed1452 Reviewed-on: https://chromium-review.googlesource.com/910732Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung.kim@lge.com> Cr-Commit-Position: refs/heads/master@{#539452}
-
Colin Blundell authored
https://chromium-review.googlesource.com/904992 added a new AutofillClient::GetIdentityManager() interface. That CL mistakenly had the ChromeAutofillClient and ChromeAutofillClientIOS implementations return the IdentityManager instance associated with the current Profile. It should actually be the IdentityManager instance associated with the *original Profile* (/ChromeBrowserState) to be parallel with those clients' constructions of the ProfileIdentityProvider instances whose usage IdentityManager is replacing in //components/autofill. Note that I verified that these are the only client implementations that need this fix: - AWAutofillClient returns nullptr for both the IdentityProvider and the IdentityManager. - WebViewAutofillClient (in //ios) doesn't use the original ChromeBrowserState for anything, I assume because it doesn't have incognito. This bug was uncovered by the UBSanVptr bot. Thanks, UBSanVptr bot! Bug: 798413, 814308 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I3e87888bc622204a29b4f9d3990fa39e8b165eb3 Reviewed-on: https://chromium-review.googlesource.com/928654Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#539451}
-
Thomas Tangl authored
This CL updates the promo strings in the user menu for turning on sync. A new string is added for the case when there are signed in web accounts. Bug: 814979 Change-Id: I028514d8894a2f8372784f7ff3a69c34c0573bf0 Reviewed-on: https://chromium-review.googlesource.com/934286 Commit-Queue: Thomas Tangl <tangltom@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#539450}
-
Ken Rockot authored
Plumbs through some additional WebRequestInfo fields in the Network Service path to enable <webview> WebRequest (and declarative WebRequest) APIs to work as expected. Bug: 721414 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I78eda1c4f286623f1d82e3e5be60dd9beff517bc Reviewed-on: https://chromium-review.googlesource.com/938675Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#539449}
-
Jinsong Fan authored
The CL: 1. Add BUILDFLAG::ENABLE_SPELLCHECK in aw_main_delegate.cc 2. Remove redundant include spellcheck_build_features.h Bug: None Change-Id: Idc77171292fd0515240e52d86ac83fbdb4744534 Reviewed-on: https://chromium-review.googlesource.com/939221Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#539448}
-
Greg Thompson authored
This bubble is shown to a user when a relaunch is needed for an update and the user's administrator has set the RelaunchNotification policy to 1 (recommended). The bubble is shown each time the UpgradeDetector moves the UpgradeNotificationAnnoyanceLevel to LOW, ELEVATED, or HIGH; and is shown on a recurring schedule while the level is at or above HIGH. BUG=511300 Change-Id: Idd235ec0a3bef3b24484ab5cd40cb7b2a28bf450 Reviewed-on: https://chromium-review.googlesource.com/906774 Commit-Queue: Greg Thompson <grt@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#539447}
-
Fabio Tirelo authored
With the introduction of the 3p removal trigger, the concern is that subtitles make the card too heavy, so we are simply removing them. I will also send a follow-up CL to remove subtitle from the "Reset settings" trigger. Not sending here, because I want to add other people on that change for discussion. Bug: 816666 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Iae7c588c72f109e676212ceaf858177b21b22f5d Reviewed-on: https://chromium-review.googlesource.com/938623 Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#539446}
-
Rune Lillesveen authored
We used OriginalStyleForLayoutObject which doesn't update animations or stacking context. This is a reland of [1] which was reverted because the added unit test failed on Android because option elements do not create layout objects with the platform's theme. [1] https://crrev.com/4b96f800bd6d6c017ac14ab19e7b341c1a6efcc6 Bug: 813348, 813439, 813836 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I55d5f944e86ccaa326f01caa7f48606021f8df14 Reviewed-on: https://chromium-review.googlesource.com/939163 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#539445}
-
Mikel Astiz authored
The change makes SessionsSyncManager smaller which is good for our upcoming changes to introduce an alternative implementation based on USS. Bug: 681921 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I6e8ed8b3b588b6a8da5e9b6b90be6ed9f479b04c Reviewed-on: https://chromium-review.googlesource.com/918863 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Nicolas Zea <zea@chromium.org> Cr-Commit-Position: refs/heads/master@{#539444}
-
Ioana Pandele authored
Bug: 814574 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I396ff63e3e0d94e635dcf88e2d6bf0b6061e3b10 Reviewed-on: https://chromium-review.googlesource.com/930471 Commit-Queue: Ioana Pandele <ioanap@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#539443}
-
Per Åhgren authored
The reporting to the histogram is added in the WebRTC CL https://webrtc-review.googlesource.com/c/src/+/53066. The metric for the histogram is the amount of skew shifts detected for each minute in a call. It should be noted that the metric is also reported for the case where there are 0 skew shifts. Furthermore, the metric is capped to 20 shifts per minute. Bug: chromium:814962 Change-Id: Ie6c7bb9b8e43c5b8ca8f77ac45e7b0eb2235aded Reviewed-on: https://chromium-review.googlesource.com/933201Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Per Åhgren <peah@chromium.org> Cr-Commit-Position: refs/heads/master@{#539442}
-
Daniel Bratell authored
A forward declaration claimed there was a ::viz::cc:CompositorFrame class, and that introduction of a namespace ::viz::cc caused confusion with the ::cc namespace and compilation errors in some jumbo build configurations. The real CompositorFrame is in viz::CompositorFrame so fixing the forward declaration also removed the namespace clash. Change-Id: I1cd4fe729591855172f5a07aca2e2c7f3e8db9fa Reviewed-on: https://chromium-review.googlesource.com/939390Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#539441}
-
Alexei Svitkine authored
This is a no-op change that paves way for changing the logic such that multiple features could be associated with a default group. Bug: 816696 Change-Id: Ic8f202dcb52316ad2c3e4310c3c0ecac18f092c6 Reviewed-on: https://chromium-review.googlesource.com/938654Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#539440}
-
Emily Stark authored
This CL adds a new net error code for legacy Symantec certificates that are being distrusted in M66 and M70. The net error code will display on the interstitial, allowing the specific problem to be diagnosed from just a screenshot of the interstitial. We can also use it to decide when to put a console message in DevTools. Because there is code that maps net error -> CertStatus -> net error, this also requires a new CertStatus flag for the error. Bug: 815219 Change-Id: Ic15d6c96f8bdef38c26157af13bbf099fee43b70 Reviewed-on: https://chromium-review.googlesource.com/934969 Commit-Queue: Ryan Sleevi <rsleevi@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Cr-Commit-Position: refs/heads/master@{#539439}
-
gogerald authored
Bug: 812297 Change-Id: Iebd00dd49749c279088149b3b7fc6ba79aced58b Reviewed-on: https://chromium-review.googlesource.com/932748Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#539438}
-
Robert Ma authored
So that layout_tests.port.factory can return the correct list of builders and ports that contain Fuchsia. One use case of these lists is to get rid of stray expectations after rebaseline (similar to Android). Bug: 778467 Change-Id: Ia41fba2ea802518ce0d8418a02d07bd26250b5bc Reviewed-on: https://chromium-review.googlesource.com/938584Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#539437}
-
Adam Rice authored
Because UnderlyingSourceBase did not have a "type" getter the type was inherited from Object.prototype, causing a crash when that returned something other than "undefined". BUG=806644 Change-Id: I709dc0469396e350f9494f102398a6d5bb5ff8d5 Reviewed-on: https://chromium-review.googlesource.com/936825 Commit-Queue: Adam Rice <ricea@chromium.org> Reviewed-by:
Takeshi Yoshino <tyoshino@chromium.org> Cr-Commit-Position: refs/heads/master@{#539436}
-
John Budorick authored
TBR=martiniss@chromium.org Bug: 812533 Change-Id: I575e5215b9fdeed07ff90949e7c637fed5de08b9 Reviewed-on: https://chromium-review.googlesource.com/937981Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#539435}
-
Scott Violet authored
And instead have each tree maintain the mapping between client-id and ServerWindow. One of the things the id() encoded was the creator. Numerous places still need that, so I kept it. BUG=none TEST=covered by tests Change-Id: Ie6fc4833ce20a7c05bbe6ee1139ef361320d24d6 Reviewed-on: https://chromium-review.googlesource.com/936426Reviewed-by:
Ria Jiang <riajiang@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#539434}
-
Christian Fremerey authored
This is to enable experiment-controlled rollout of MediaFoundation based video capture on platforms where it is supported. Bug: 792640 Change-Id: I325b3112d25b07ac6eb012bd3e8c59aaea131ff1 Reviewed-on: https://chromium-review.googlesource.com/917284 Commit-Queue: Christian Fremerey <chfremer@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Cr-Commit-Position: refs/heads/master@{#539433}
-
Ganesh Borle authored
Bug: 561800 Change-Id: I4b851241568d86a10475585130780ad73ebcf4ce Reviewed-on: https://chromium-review.googlesource.com/934361Reviewed-by:
srirama chandra sekhar <srirama.m@samsung.com> Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: srirama chandra sekhar <srirama.m@samsung.com> Cr-Commit-Position: refs/heads/master@{#539432}
-
Dianna Hu authored
This CL lands server change 185528812 by dahollings. BUG=488484 Change-Id: I265c7d8354b5258fbbf7d39cb446d3dda4f8c25f Reviewed-on: https://chromium-review.googlesource.com/937687Reviewed-by:
Bence Béky <bnc@chromium.org> Commit-Queue: Dianna Hu <diannahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#539431}
-
Dianna Hu authored
This CL lands server change 185561279 by assar. BUG=488484 Change-Id: I19a1525a9bfb6ec6b7f01ac163b9044f98f4fbd9 Reviewed-on: https://chromium-review.googlesource.com/937690Reviewed-by:
Bence Béky <bnc@chromium.org> Commit-Queue: Dianna Hu <diannahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#539430}
-
Henrik Boström authored
TBR=zakerinasab@chromium.org No-Try: True Bug: 816914 Change-Id: Ib62c7af7241350e80c18412b2c898734fe7b9074 Reviewed-on: https://chromium-review.googlesource.com/939470Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#539429}
-
xlai authored
ImageBitmapRenderingContext is supposed to be shipped in Chrome 55 as stated in the Chrome Platform Status here: https://www.chromestatus.com/feature/5709799995998208. However, the code itself bars this feature from being accessible by users. Bug: 658734 Change-Id: I7b54bbee58529507411109866885623ef5b7a999 Reviewed-on: https://chromium-review.googlesource.com/938461Reviewed-by:
Justin Novosad <junov@chromium.org> Commit-Queue: Olivia Lai <xlai@chromium.org> Cr-Commit-Position: refs/heads/master@{#539428}
-
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 The AutoRoll server is located here: https://afdo-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: I98b7c3aef6dfc64ba9ddef02305208867ad2ab60 Reviewed-on: https://chromium-review.googlesource.com/938575Reviewed-by:
afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#539427}
-
yoshiki iguchi authored
Recently I made some fileds deprecated (crrev.com/c/917845), in addition, we need to make them optional to remove these fields. Test None (doesn't change any behavior) Bug: None Change-Id: Ic1afc986013fb3f395fd1f1e89f19a9c13852b7a Reviewed-on: https://chromium-review.googlesource.com/936948Reviewed-by:
Jorge Lucangeli Obes <jorgelo@chromium.org> Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org> Cr-Commit-Position: refs/heads/master@{#539426}
-
Nico Weber authored
Bug: 816435 Change-Id: Iae8fd393c8fae53387ecf02d5e5779a44dee3030 Reviewed-on: https://chromium-review.googlesource.com/936588 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/heads/master@{#539425}
-
Mostyn Bramley-Moore authored
There are multiple g_instance_for_testing globals after https://chromium-review.googlesource.com/c/chromium/src/+/935841 - let's rename one of them to avoid jumbo build breakage. TBR=primiano@chromium.org Bug: 815234,775547 Change-Id: I184578b694e59dad8b06643db199f32820fd5887 Reviewed-on: https://chromium-review.googlesource.com/938821 Commit-Queue: Mostyn Bramley-Moore <mostynb@vewd.com> Reviewed-by:
Mostyn Bramley-Moore <mostynb@vewd.com> Cr-Commit-Position: refs/heads/master@{#539424}
-
Oleh Prypin authored
It's also flaky on Android, so disable on all platforms Bug: chromium:807638 No-Try: True Change-Id: I0b7dc9cb14198c590538f3a8125e47636fc2c1d7 Reviewed-on: https://chromium-review.googlesource.com/939162 Commit-Queue: Oleh Prypin <oprypin@chromium.org> Reviewed-by:
Patrik Höglund <phoglund@chromium.org> Cr-Commit-Position: refs/heads/master@{#539423}
-
Owen Min authored
Bug: 816499 Change-Id: Ib3ecf6730908289be6f799c7df39d3667f1552d0 Reviewed-on: https://chromium-review.googlesource.com/937657Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#539422}
-
Henrik Boström authored
This reverts commit 637c7485. Reason for revert: Suspected culprit of consistent Linux MSan Tests failures of GpuImageDecodeCacheTest.NonLazyImageUploadDownscaled since https://uberchromegw.corp.google.com/i/chromium.memory/builders/Linux%20MSan%20Tests/builds/8195 Original change's description: > cc: Ensure correct scaling for non-lazy images in GPU cache. > > When using a non-lazy (bitmap) image in the GPU cache, we assume the > upload to be scaled at the mip-level required for draw, when we > actually use the original image for the upload. Fix this by considering > non-lazy scaled images as lazy generated. This also ensures we use > lower gpu memory, by caching downscaled uploads. > > R=ericrk@chromium.org > > Bug: 815045, 814219 > Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel > Change-Id: I4b7d3f4edbcf0e5ba5574512f662a3fdf53cabd6 > Reviewed-on: https://chromium-review.googlesource.com/935441 > Reviewed-by: Zhenyao Mo <zmo@chromium.org> > Reviewed-by: Eric Karl <ericrk@chromium.org> > Commit-Queue: Khushal <khushalsagar@chromium.org> > Cr-Commit-Position: refs/heads/master@{#539276} TBR=zmo@chromium.org,khushalsagar@chromium.org,ericrk@chromium.org Change-Id: I441305f1ebfa962b3a78e5fa53f2169996fae196 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 815045, 814219 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/939361Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#539421}
-
Henrik Boström authored
TBR=ericwilligers@chromium.org No-Try: True Bug: 816868 Change-Id: I0ccb2fa2ad89e2dfcbfb8e15e2dfb8fbc1e8e85b Reviewed-on: https://chromium-review.googlesource.com/939176Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#539420}
-
Henrik Boström authored
This reverts commit d690c638. Reason for revert: Suspect for Linux MSAN bot consistent failures, first one being: https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Linux%20Trusty%20MSAN/builds/6338 Original change's description: > [heap-profiler] Merge DOM node and its JS wrapper node in heap snapshot. > > Each DOM node has a corresponding JS wrapper node. In heap snapshot > they appear as duplicates. > > Example retaining path with duplicates: > - [1] in InternalNode @2041178784 > - [1] in HTMLDivElement @2041079168 // DOM node > - [3] in HTMLDivElement @2231 // JS wrapper > - retainer in Window / @2105 > > The heap snapshot generator now can merge an embedder node with a node > returned by EmbedderGraph::Node::WrapperNode() function. > > This patch implements the WrapperNode() function for each DOM node. > > Bug: chromium:811925 > Change-Id: I9ea6bc7e45f8ab3d54828b9ac61f7230d04d8019 > Reviewed-on: https://chromium-review.googlesource.com/928503 > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > Commit-Queue: Ulan Degenbaev <ulan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#539132} TBR=ulan@chromium.org,haraken@chromium.org,mlippautz@chromium.org Change-Id: If05b23d13bb68f0dc870cc047b399ed43c4472f6 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:811925 Reviewed-on: https://chromium-review.googlesource.com/939341Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#539419}
-
Xi Cheng authored
Bug: 734095 Change-Id: Ia29c55079a1fa0be50ef2053636b63288c0d92d6 Reviewed-on: https://chromium-review.googlesource.com/938656Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Cr-Commit-Position: refs/heads/master@{#539418}
-