- 25 Jan, 2019 40 commits
-
-
chaopeng authored
The device scale factor is not properly applied in CrossProcessFrameConnector::TransformPointToLocalCoordSpaceLegacy We're using current_surface_scale_factor() which does not seem to provide the correct value. We want GetDeviceScaleFactor(). Test: SitePerProcessInternalsHitTestBrowserTest.ScrollNestedLocalNonFastScrollableDiv after crrev.com/c/1427607 landed Bug: 923069 Change-Id: Iae748780d0657d7674cf4ba76a276ad03cc28a74 Reviewed-on: https://chromium-review.googlesource.com/c/1435834Reviewed-by:
Kevin McNee <mcnee@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Jianpeng Chao <chaopeng@chromium.org> Cr-Commit-Position: refs/heads/master@{#626115}
-
Elly Fong-Jones authored
This change replaces @available(macOS 10.10, *) with true and removes API_AVAILABLE(macos(10.10)) annotations, then simplifies code where possible as a result. Bug: 841631 Change-Id: I55e0fbf23d836951354506f2058a419ebc95bb8b Reviewed-on: https://chromium-review.googlesource.com/c/1437254Reviewed-by:
-
Ken Rockot authored
JSON manifests are deprecated. Also removes unnecessary use of test catalogs in favor of inline test service manifests. Bug: 895616 Change-Id: I1fb3263c351c01a4edc56238d65cffa3e6dd68d3 Reviewed-on: https://chromium-review.googlesource.com/c/1436696Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#626113}
-
Maksim Moskvitin authored
The old migration way requires changing of sync settings to complete the migration (https://codereview.chromium.org/11961030/). That way also blocks updates in SyncPrefs class required for crbug.com/906611 since it uses SyncPrefs internal logic. New way is implemented outside of SyncPrefs and force the migration on browser start. Bug: 906611 Change-Id: I0518798c5246e6436449ab79ddd648e68a52507c Reviewed-on: https://chromium-review.googlesource.com/c/1434281Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Dominic Battré <battre@chromium.org> Auto-Submit: Maksim Moskvitin <mmoskvitin@google.com> Cr-Commit-Position: refs/heads/master@{#626112}
-
Ken Rockot authored
JSON manifests are deprecated. This also removes an unnecessary test catalog in favor of defining test service manifests inline. Bug: 895616 Change-Id: I5bd634654bdef124b61e97bb232eeb29114073a1 Reviewed-on: https://chromium-review.googlesource.com/c/1436875Reviewed-by:
-
Moe Ahmadi authored
Renames translate_popup_menu_coordinator and translate_popup_menu_mediator to translate_infobar_coordinator and translate_infobar_mediator as they have more responsiblities than only displaying/dismissing the translate infobar popup menus, e.g., handling translate options notifications. Bug: 910994 Change-Id: Id6e0df35ee8216b3d498ab407f58e08c4314ae40 Reviewed-on: https://chromium-review.googlesource.com/c/1436941 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Mark Cogan <marq@chromium.org> Auto-Submit: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#626110}
-
Peng Huang authored
The presentation feedback is currently synthesized from the swap-end time, and the work to get the real presentation-feedback is tracked in https://crbug.com/c/925010 Bug: 919882, 925010 Change-Id: I1d3f7853d5578252ffd96fa63efb59882dccce82 Reviewed-on: https://chromium-review.googlesource.com/c/1434076 Commit-Queue: Peng Huang <penghuang@chromium.org> Auto-Submit: Peng Huang <penghuang@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#626109}
-
Chris Lu authored
Implements logic for FindInPageSearch option to search and highlight matches. Searching for non-ascii not currently supported. Bug: 896867 Change-Id: I362d3cebacfced1537742fbbab9ad323d6edeafd Reviewed-on: https://chromium-review.googlesource.com/c/1407665Reviewed-by:
Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#626108}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/91ef1c316730..19ec8ef577ff git log 91ef1c316730..19ec8ef577ff --date=short --no-merges --format='%ad %ae %s' 2019-01-25 ahassani@chromium.org Revert "paygen: improve GenrateStatefulPayload's implementation" Created with: gclient setdep -r src/third_party/chromite@19ec8ef577ff The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I8a4f27ed98f319db586ff36cca9eebf190ee54ee Reviewed-on: https://chromium-review.googlesource.com/c/1437004Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#626107}
-
Elly Fong-Jones authored
This is a reland of d86a6561 Original change's description: > mac: roll to 10.13 SDK > > This change causes the default hermetic SDK to be version 10.13 (aka Xcode 9.3). > This also bumps the minimum build host version to 10.13.2, since that > is the earliest version on which Xcode 9.3 runs. > > Bug: 780980 > Change-Id: I6da3f7d3a060a22d71d5ee18bb88f51d5aedb0a2 > Reviewed-on: https://chromium-review.googlesource.com/c/1394742 > Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> > Reviewed-by: Nico Weber <thakis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#620032} Bug: 780980 Change-Id: Iea403cc2dcbfc56ce54a6ad72ca4d2729b520fd0 Reviewed-on: https://chromium-review.googlesource.com/c/1436942 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#626106}
-
Vlad Tsyrklevich authored
In r624120 I reduced the number of allocations used by GWP-ASan from MaxAllocations/TotalPages 32/128 to 6/20. These are good parameters for widespread use to limit the amount of memory/perf regression on stable; however, it makes it much less likely GWP-ASan will catch newly introduced bugs on canary/dev. Add a multiplier by which to increase the GWP-ASan parameters on canary/dev to ensure we maintain good coverage of new code. Bug: 896019 Change-Id: I1ce59c25878ef0c066e04a0dedeba1f3aa97ec0d Reviewed-on: https://chromium-review.googlesource.com/c/1429240 Commit-Queue: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Reviewed-by:
Vitaly Buka <vitalybuka@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Auto-Submit: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Cr-Commit-Position: refs/heads/master@{#626105}
-
Matt Menke authored
Windows 10 now maps audio/webm to *.weba by default. This CL fixes a test that change broken (MimeUtilTest.GetPreferredExtensionForMimeType), and adds a secondary mapping for audio/webm to weba. Bug: 923502 Change-Id: Ia2e3344c5bf270a6bcfe5154ce8a4e28285821fc Reviewed-on: https://chromium-review.googlesource.com/c/1436939Reviewed-by:
Asanka Herath <asanka@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#626104}
-
Oskar Sundbom authored
The current generator is maintaining a value of 0 when silent and varying between 0 and 128 when beeping. As it generates unsigned 8 bit audio, this means it's stuck at the lowest value when silent, rather than at the mid-point. This has confused a test. Bug: 892534 Change-Id: I4bf5d676ef58e0443716213a5650baacf3f11b8c Reviewed-on: https://chromium-review.googlesource.com/c/1430074Reviewed-by:
Max Morin <maxmorin@chromium.org> Commit-Queue: Oskar Sundbom <ossu@chromium.org> Cr-Commit-Position: refs/heads/master@{#626103}
-
Christian O. Andersson authored
Design doc: https://docs.google.com/document/d/188BbgvTdhKf8bXikCL-JMduEclJOd9GxhKu79hmSVdo/edit We wish to provide a means of optionally suppressing the display of the webview error page so that applications that wish to display their own error content may do so without presenting a poor user experience. Test: run_webview_instrumentation_test_apk -f AwSettingsTest#testShouldSuppressErrorPage Change-Id: I15c42acd7d562e7d37bb4f84d92267db49f0a55a Reviewed-on: https://chromium-review.googlesource.com/c/1185001 Auto-Submit: Christian O. Andersson <cricke@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Commit-Queue: Christian O. Andersson <cricke@chromium.org> Cr-Commit-Position: refs/heads/master@{#626102}
-
Xida Chen authored
This CL creates a CrossThreadKeywordValue, and use it in the CrossThreadStyleValueFromComputedStyle. Unit tests are added to ensure the correctness. Bug: 895579 Change-Id: Id5972634732489473dcb49dd54e8856e93d8752c Reviewed-on: https://chromium-review.googlesource.com/c/1427780 Commit-Queue: Xida Chen <xidachen@chromium.org> Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#626101}
-
David 'Digit' Turner authored
When the input is a tiny empty .jar file (e.g. 22 bytes that only include an empty End Of Central Directory record) as shown below, ijar generated an invalid output, which was supposed to only contain a single 'empty' file with length 0. The problem was due to the fact that MappedOutputFile did the following: - First call ftruncate(fd, 22) to size the output file from an estimate of the input file (blindly assuming the result would be smaller). - Later call ftruncate(fd, 108) to size the output with its 'final' size. Unfortunately, the kernel interpreted that as _extending_ the file size, and overwriting the new bytes with zero. In practice, this means that the buffer's content before the second ftruncate() was: 00000000: 50 4b 03 04 0a 00 00 00 00 00 00 00 00 00 00 00 00000010: 00 00 00 00 00 00 00 00 00 00 05 00 00 00 64 75 00000020: 6d 6d 79 50 4b 01 02 00 00 0a 00 00 00 00 00 00 00000030: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 05 00000040: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00000050: 00 64 75 6d 6d 79 50 4b 05 06 00 00 00 00 01 00 00000060: 01 00 33 00 00 00 23 00 00 00 00 00 And after ftruncate() became: 00000000: 50 4b 03 04 0a 00 00 00 00 00 00 00 00 00 00 00 00000010: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00000020: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00000030: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00000040: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00000050: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00000060: 00 00 00 00 00 00 00 00 00 00 00 00 The result only contains a Local File Header record, but has no longer a final End Of Central Directory record, and is thus no longer a valid zip archive! This is fixed by this CL by ensuring that the initial ftruncate() is at least one page long. A sanity check is also added to return an error if the output file is larger than its input for some unexpected reason. This is not needed on Windows, which closes the file then later changes its size. -- example tiny input zip file of 22 00000000: 504b 0506 0000 0000 0000 0000 0000 0000 PK.............. 00000010: 0000 0000 0000 BUG=925257 R=agrieve@chromium.org,dpranke@chromium.org,benmason@chromium.org Change-Id: If06b3ca88fee2dceaebacb427741ef48311cb38d Reviewed-on: https://chromium-review.googlesource.com/c/1436361Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#626100}
-
edchin authored
The preferred pattern for TabHelpers is to create them in AttachTabHelpers(), then set any necessary delegate in BVC or elsewhere. A DCHECK should be placed anywhere the delegate is used so that there aren't silent failures. This CL makes SadTabTabHelper conform to the preferred pattern. Change-Id: If6d7b5287c99835f950e6dfc0aaac7c595dd16e5 Reviewed-on: https://chromium-review.googlesource.com/c/1404578Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#626099}
-
Sebastien Marchand authored
This also adds it to the whitelist used in third_party/blink/renderer/DEPS Gab/Francois, I've used your refactoring script for this, the rule is: matches = re.compile(r'(\n *[^/\n][^/\n]*base::Bind(Once|Repeating)?\b[^*])', re.DOTALL).findall(content) if not matches: return False updated_content = refactor_lib.AddInclude(file_path, content, "base/bind.h") if updated_content == content: return False # Write updated file refactor_lib.WriteFile(file_path, updated_content) TBR=fdoray@chromium.org Change-Id: I7a9a991255a560c6ebedaade47cffe1ac1c7baff Reviewed-on: https://chromium-review.googlesource.com/c/1437069 Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Reviewed-by:François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#626098}
-
Mohamed Amir Yosef authored
Bug: 902349 Change-Id: I14ca95a063835d72ca48d9c49c4a45f816e5fb55 Reviewed-on: https://chromium-review.googlesource.com/c/1424881 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
-
Geoff Lang authored
Since https://chromium-review.googlesource.com/c/chromium/src/+/1005017/ EGL is enabled on Mac but not used by default. The disable_es3_gl_context workaround removes the kGLImplementationDesktopGLCoreProfile GL implementation from the list of allowed implementations which now defaults to using EGL when the intention is that it falls back to a non-core desktop GL profile. Reorder the implementations so that the fallback happens as expected. BUG=918365 Change-Id: Ibf9ae089897f32508dd83fed41cfdc8412e9c7bb Reviewed-on: https://chromium-review.googlesource.com/c/1437060Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Cr-Commit-Position: refs/heads/master@{#626096}
-
Sam Maier authored
Pre-native Java tasks are now having their priority set when started. Also switches dynamicmodule's ModuleLoader to use the TaskTrait's priority setting instead of manually setting the thread priority. Bug: 863457 Change-Id: Iee601ca1e18e2637f8e930c6d212c8115e682fc3 Reviewed-on: https://chromium-review.googlesource.com/c/1407374Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Benoit L <lizeb@chromium.org> Commit-Queue: Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#626095}
-
Mohamed Amir Yosef authored
The implemented logic is based on the analogous in to that in PasswordSyncableService::ProcessSyncChanges(). Bug: 903249 Change-Id: Ibbc607b8ee380cd7b3c790ab3273a2e4d7d7819f Reviewed-on: https://chromium-review.googlesource.com/c/1429960 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
-
Sebastien Marchand authored
Gab/Francois, I've used your refactoring script for this, the rule is: matches = re.compile(r'(\n *[^/\n][^/\n]*base::Bind(Once|Repeating)?\b[^*])', re.DOTALL).findall(content) if not matches: return False updated_content = refactor_lib.AddInclude(file_path, content, "base/bind.h") if updated_content == content: return False # Write updated file refactor_lib.WriteFile(file_path, updated_content) TBR=fdoray@chromium.org Change-Id: I5c6805a75e4e11d0d30bf7dd62fb49963f922acb Reviewed-on: https://chromium-review.googlesource.com/c/1437062Reviewed-by:Sébastien Marchand <sebmarchand@chromium.org> Reviewed-by:
-
Hans Wennborg authored
Ran `tools/clang/scripts/upload_revision.py 352138`. Bug: 924185 Change-Id: I54d3c8fe506198fb3acab9b63187a7d15ee0d433 Reviewed-on: https://chromium-review.googlesource.com/c/1436036Reviewed-by:
-
Hajime Hoshi authored
This CL switches task runners at several places from per-thread to per-frame. The purpose of this change is to make it possible to freeze tasks for bfcache. bfcache is a new feature to freeze a tab for quick back-forwarding. When a tab goes frozen, we can stop per-frame task runners while we cannot per-thread task runners since per-thread task runners can be shared between multiple tags/pages. As a frozen tab must not execute any JavaScript, all JavaScript execution must be on per-frame task runners, which can be suspended. Bug: 913912 Change-Id: Ic0deb8d3cb421e2a25ee25a5dd81b3387b83e3bb Reviewed-on: https://chromium-review.googlesource.com/c/1405960Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Tao Bai <michaelbai@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#626091}
-
Kyle Milka authored
Remove old config for Local NTP and add a new one for the Local NTP with promos and Doodles. Bug: 583289 Change-Id: I0fff16d02c949becd859437a235a62571e821955 Reviewed-on: https://chromium-review.googlesource.com/c/1436145Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#626090}
-
Chromium WPT Sync authored
Using wpt-import in Chromium ddbf25ac. With Chromium commits locally applied on WPT: f643497e "[resource-timing] Modify is_secure_context_ based on resource" 20defaa4 "[LayoutNG] ComputeReplacedSize min/max width/height fix" 40748e1e "Upstream fast/workers to external/wpt/workers: first batch." 6691ad3f "Fix preload tests failing on wpt.fyi dashboard, second attempt" 13151b26 "Worker: Fix wpt/workers/semantics/run-a-worker/003.html for shared workers" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: jsbell@chromium.org, mek@chromium.org: external/wpt/webstorage NOAUTOREVERT=true TBR=markdittmer No-Export: true Change-Id: Id029ef7a892acb6a5530336caabbec9ce77269ad Reviewed-on: https://chromium-review.googlesource.com/c/1437055Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#626089}
-
Sebastien Marchand authored
Gab, I've used your refactoring script for this, the rule is: matches = re.compile(r'(\n *[^/\n][^/\n]*base::Bind(Once|Repeating)?\b[^*])', re.DOTALL).findall(content) if not matches: return False updated_content = refactor_lib.AddInclude(file_path, content, "base/bind.h") if updated_content == content: return False # Write updated file refactor_lib.WriteFile(file_path, updated_content) TBR=gab@chromium.org Change-Id: I6cca9dff7fa4937fd7accdc57fe774674f6c147b Reviewed-on: https://chromium-review.googlesource.com/c/1437100 Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Reviewed-by:Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#626088}
-
Guido Urdaneta authored
The constructor should throw TypeError if sdpMid and sdpMLineIndex are both null. The RTCIceCandidateInit parameter in the RTCIceCandidate constructor is optional. This CL makes minor changes to WPT tests: * RTCIceTransport-extension.https.html is made spec compliant by constructing RTCIceCandidates that don't have both sdpMid and sdpMLineIndex null. * RTCIceCandidate-constructor.html has error-reporting improvements. Bug: 683094 Change-Id: I875142d50bf761b934be3a0325029c458aa465c8 Reviewed-on: https://chromium-review.googlesource.com/c/1425616 Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#626087}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ab68058ef255..03e626851265 Created with: gclient setdep -r src-internal@03e626851265 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I34fb0554b590f79b3ba476d582e6fa9495d843da Reviewed-on: https://chromium-review.googlesource.com/c/1437000Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#626086}
-
Antonio Gomes authored
Differently than other similar migrations to IdentityManager, this one had a peculiarity: The SigninProfileAttributesUpdater instance being tested is created with the Profile, so if the primary account gets set any later than inline during Profile creation, SigninProfileAttributesUpdater will not see be "authenticated" on ChromeOS. This happens because the OnPrimaryAccountSet observer callback does not get fired on ChromeOS. In order to overcome this, this CL: - Adds a GetIdentityTestEnvironmentFactoriesWithPrimaryAccountSet method to IdentityTestEnvironmentProfileAdaptor. - Adds a BuildAuthenticatedServiceInstanceForTesting method to IdentityManagerFactory - Used the new machinery under ifdef OS_CHROMEOS guards in the test bootstrap. This way, the CL ensures that the primary account is set before the SigninProfileAttributesUpdater instance is created on ChromeOS, which is what the tests require. BUG=920225 Change-Id: Ic82aa0815651ee35154c11d599ce0ab37db26701 Reviewed-on: https://chromium-review.googlesource.com/c/1409982 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#626085}
-
Francois Doray authored
Bug: 833989 Change-Id: Iabb35b57c55214f932853df61fe431c85120cdae Reviewed-on: https://chromium-review.googlesource.com/c/1434014Reviewed-by:
-
Matt Menke authored
Previously, WebSocketTransportConnectSubJob registered sockets with the WebSocketEndpointLockManager, and WebSocketTransportClientSocketPool unregistered them before destroying them. This will no longer work with a flat socket pool, as WebSocketTransportClientSocketPool will contain a mixture of TCP sockets and SSL sockets. In the latter case, the SSL sockets will be wrapping a TCP socket that was registed with the WebSocketEndpointLockManager, but the pool will have no access to those wrapped sockets. This CL creates a WebSocketStreamSocket class, which wraps the TCP connections, and registers and unregisters them with the WebSocketEndpointLockManager as needed. This is part of an effort to flatten the socket pools. https://docs.google.com/document/d/1g0EA4iDqaDhNXA_mq-YK3SlSX-xRkoKvZetAQqdRrxM/edit Merge commit 'refs/changes/47/1423347/4' of https://chromium.googlesource.com/chromium/src into pools11 Bug: 472729 Change-Id: Id86c696ab8a6df047398b6cb8ff2c31304b0fe8f Reviewed-on: https://chromium-review.googlesource.com/c/1425792 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#626083}
-
Paul Wankadia authored
https://chromium.googlesource.com/external/github.com/google/re2.git/+log/68752454406a..a8176127eebc $ git log 687524544..a8176127e --date=short --no-merges --format='%ad %ae %s' 2019-01-25 junyer Crudely limit the use of various character classes when fuzzing. 2019-01-21 junyer Oops, std::string_view requires C++17. 2019-01-21 junyer Support constructing StringPiece from std::string_view. 2019-01-21 junyer Add Clang 8 to the Travis CI matrix. Created with: roll-dep src/third_party/re2/src R=mmoroz@chromium.org Bug: 0 Change-Id: I23911a1ee484df3ab4a64042f49782a7cfc9aa4f Reviewed-on: https://chromium-review.googlesource.com/c/1436592Reviewed-by:
Max Moroz <mmoroz@chromium.org> Commit-Queue: Max Moroz <mmoroz@chromium.org> Cr-Commit-Position: refs/heads/master@{#626082}
-
Morten Stenshorne authored
So HandleNewFormattingContext() doesn't need that parameter. Change-Id: I6cffdc158b748cd31c6c9cdd709162788de87a76 Reviewed-on: https://chromium-review.googlesource.com/c/1436363Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#626081}
-
Alexandre Frechette authored
Bug: 850947 Change-Id: I5dc5cd129f5755006f55df12ec83c97c21a57c72 Reviewed-on: https://chromium-review.googlesource.com/c/1426059Reviewed-by:
anthonyvd <anthonyvd@chromium.org> Commit-Queue: Alexandre Frechette <frechette@chromium.org> Cr-Commit-Position: refs/heads/master@{#626080}
-
Oskar Sundbom authored
Bug: 925325 Tbr: andreasbutler@google.com Change-Id: I9318ec953363252d54236686683c5d23221df0ff Reviewed-on: https://chromium-review.googlesource.com/c/1436370Reviewed-by:
Oskar Sundbom <ossu@chromium.org> Commit-Queue: Oskar Sundbom <ossu@chromium.org> Cr-Commit-Position: refs/heads/master@{#626079}
-
Oskar Sundbom authored
This reverts commit 051153e8. Reason for revert: The new tests hit a use-of-uninitialized-value on MSAN bots see: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20ChromiumOS%20MSan%20Tests/10910 Bug: 925333 Original change's description: > Fix chromevox state transition announcement > > - When ChromeVox is enabled, launcher state transitions to peeking or > fullscreen are now announced. > - This fix also removes the ability to focus on the expand arrow while > in fullscreen. > > Bug: 779687 > Change-Id: I942737bed53c258272aaea1a379cb7dd4053f605 > Reviewed-on: https://chromium-review.googlesource.com/c/1423741 > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> > Reviewed-by: David Tseng <dtseng@chromium.org> > Reviewed-by: Weidong Guo <weidongg@chromium.org> > Commit-Queue: Matthew Mourgos <mmourgos@chromium.org> > Cr-Commit-Position: refs/heads/master@{#625756} TBR=dmazzoni@chromium.org,dtseng@chromium.org,weidongg@chromium.org,mmourgos@chromium.org Change-Id: I9309c3e6e194163faca077c0fb36a42434ca5dce No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 779687 Reviewed-on: https://chromium-review.googlesource.com/c/1436373Reviewed-by:
-
Richard Knoll authored
This makes sure that we forward the close event when a user clicks on the close button we show in native linux notifications for cinnamon. Bug: 924478 Change-Id: I490d9250c85dbaaca1132bc75a273e2c070c2ad8 Reviewed-on: https://chromium-review.googlesource.com/c/1429044 Commit-Queue: Richard Knoll <knollr@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#626077}
-
Robbie Gibson authored
This CL fixes a bug in the ClipboardURLProvider text suggestion when the copied text matches the url of the current page. The text suggestion appears, when it should be suppressed, like the url suggestion. It also slightly changes the suggested_url_count logic. Before, if the omnibox was opened and the clipboard was empty, the url would be reset. Now, that no longer happens (because it's difficult to tell if the match failed because the both the url and the text clipboard were empty or if the current element on the clipboard was filtered out for some other reason [e.g. the url matched the current page's url]). Bug: 924127 Change-Id: I7f327fd68689cf0fa7b8ee73ec46109e77ecf9ac Reviewed-on: https://chromium-review.googlesource.com/c/1426689 Commit-Queue: Robbie Gibson <rkgibson@google.com> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#626076}
-
