- 27 May, 2020 40 commits
-
-
Hsin-Yu Chao authored
Bug: b/156333981 Change-Id: Ieec9421a98119684f3ad901b16c1ad8dbe8998ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2196082Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Commit-Queue: Hsinyu Chao <hychao@chromium.org> Cr-Commit-Position: refs/heads/master@{#772093}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/aef138255c4c..94b3d7589061 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC tasak@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1069072,chromium:1073232,chromium:1085525 Tbr: tasak@google.com Change-Id: Id06ca384c77a125f4f1ee1c1adca6e7e7f20c6a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217077Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#772092}
-
Julian Watson authored
Bug: 1077160 Bug: 1049453 Change-Id: I231edda50a25fbc5b5ae4c9238e07a10d8a41548 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2206868Reviewed-by:
Timothy Loh <timloh@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Julian Watson <juwa@google.com> Cr-Commit-Position: refs/heads/master@{#772091}
-
David Grogan authored
Change the blink runtime flag to be fully controlled by the finch flag so that we can still use finch as a kill switch if necessary. (With the old kEnableOnly, "stable" in runtime enabled features json would override the finch server's value.) Bug: 845235 Change-Id: I7610b078a52674b3e8fa06d87d33f82e96761d35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216595Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: David Grogan <dgrogan@chromium.org> Cr-Commit-Position: refs/heads/master@{#772090}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=benmason@chromium.org Change-Id: I654dbb9790d9e8a928eef03dc35d4437795c257d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217116Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#772089}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/c3f19085..c1f72606 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I23bf017113c7c09efc8e88eb5f7cb7f4e4931053 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216688Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#772088}
-
Wan-Teh Chang authored
Call SetEmbeddedColorProfile() before SetSize() in MaybeCreateDemuxer(). Create the ColorProfile from either an ICC profile (preferred) or the CICP color description (always present, from either the nclx colr box in the container or the AV1 sequence header for the frames). This requires always decoding the first frame (because we need to decode the AV1 sequence header) when we are asked to decode metadata such as size and frame count. Add ColorCorrectImage(), which calls skcms_Transform() if ColorTransform() returns a non-null transform. Change DecodeFrameCount() to return frame_buffer_cache_.size() if the image decoder has already failed, as some other image decoders do. This causes FrameCount() to return 0 if the decoding of the first frame fails. Use the GetAsFullRangeRGB() version of the src color space as the dst color space of the gfx::ColorTransform for YUV-to-RGB color conversion. This allows us to enable the AVIF image tests guarded by FIXME_CRASH_IF_COLOR_TRANSFORMATION_IS_ENABLED and FIXME_CRASH_IF_COLOR_BEHAVIOR_IS_IGNORE. Since we now always decode the first frame when we are asked to decode metadata, the notion of "error phase" for the invalid static image tests no longer applies. Invalid static images now always fail in the "parse" phase. TODO: 1. Improve the tests for the color spaces that libyuv supports. Since libyuv's numerical accuracy is not as good as gfx::ColorTransform, this will require relaxing the thresholds for pixel value differences for some AVIF image tests. Bug: 1076555 Change-Id: I2a312da1f917fe2cef7ef2f342a3aa52bda6445d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209638 Commit-Queue: Wan-Teh Chang <wtc@google.com> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#772087}
-
Sara Kato authored
There were inconsistent usages of node.state.type, and node.state[State.type]. Also fix closure_compiler errors. AX-Relnotes: n/a. Bug: None (refactoring). Test: webui_closure_compile, shows no errors Change-Id: I78483d79336c8e71df34309f2ba306e7ac07d031 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210604Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Sara Kato <sarakato@chromium.org> Auto-Submit: Sara Kato <sarakato@chromium.org> Cr-Commit-Position: refs/heads/master@{#772086}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/e370ec6de4fa..6a029fc9d84e 2020-05-27 jiajie.hu@intel.com Only download binutils in standalone build 2020-05-27 yunchao.he@intel.com Implement texture subresource on Vulkan 2020-05-26 natlee@microsoft.com Fire map callback if map async operation fails 2020-05-26 rharrison@chromium.org Rolling 9 dependencies If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I9029990bc62a7210832b08bcbf4af4f11e3febc6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217074Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#772085}
-
Hugo Benichi authored
This patch ensures ensures that ARC++ gets updated with the layer 3 IP configurations of all active networks, including host VPN networks. To do so this patch changes two parts in ArcNetHostImpl: 1) First, shill properties are now always asynchronously retrieved and cached for active networks. Asynchronous network properties requests are now sent to shill when chromeos::NetworkStateHandlerObserver's NetworkPropertiesUpdated() or NetworkListChanged() callbacks are triggered, only for currently active networks. When the properties are received, a call to net.mojom ActiveNetworkChanged is triggered. This replaces the previous net.mojom ActiveNetworksChanged triggers on every callback invocation of chromeos::NetworkStateHandlerObserver's ActiveNetworksChanged and DefaultNetworkChanged. 2) When net.mojom NetworkConfiguration objects are created, on top of device properties (not available for VPNs) and ONC properties obtained from the cached chromeos::NetworkState, cached shill properties are also used for populating the IP configuration. This allows to obtain the layer 3 IP configuration for VPNs, which have neither an associated Device nor any cached layer 3 information in chromeos::NetworkState. This change makes the retrieval of IP configurations from ONC properties mostly obsolete. A follow-up patch will remove that code. BUG=b:145960788 BUG=b:143258259 BUG=b:155129178 BUG=crbug:991189 TEST=Flashed chrome, tested various connectivity setup with multiple networks, including L2TP connections and Chrome 3p VPN connections. Change-Id: If3e511212f491a5ec6533c8fb259c49eab29295b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210335 Commit-Queue: Hugo Benichi <hugobenichi@google.com> Auto-Submit: Hugo Benichi <hugobenichi@google.com> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#772084}
-
Regan Hsu authored
This reverts commit 8603f25b. Reason for revert: metrics recorder is missing some resources in Polymer2 settings, causing some breakage Original change's description: > [CrOS settings] Port os_reset_page/ and localized_link/ to Polymer3 > > - Forks TestLifetimeBrowserProxy into test_os_lifetime_browser_proxy.js > - create new os_settings_v3_browsertest.js > > Bug: 1045266 > Change-Id: I4500646fda8e8208d7bc63b405594592f9a7fce2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2190976 > Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com> > Reviewed-by: dpapad <dpapad@chromium.org> > Reviewed-by: Regan Hsu <hsuregan@chromium.org> > Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> > Cr-Commit-Position: refs/heads/master@{#771716} TBR=khorimoto@chromium.org,dpapad@chromium.org,hsuregan@chromium.org,tjohnsonkanu@google.com Change-Id: I99a42fac621b3fd5dab766f1dbe476ba52aa58b6 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1045266 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216914Reviewed-by:
Regan Hsu <hsuregan@chromium.org> Commit-Queue: Regan Hsu <hsuregan@chromium.org> Cr-Commit-Position: refs/heads/master@{#772083}
-
Asami Doi authored
Some of the core interfaces (URLLoader, URLLoaderClient and URLLoaderFactory) are good to have a diagram for overall of them since they are complicated. This CL just add the URL for the diagram about URLLoader. Change-Id: I0e4c662aa6446eae43ac661b09ff870015786425 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209778Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Asami Doi <asamidoi@chromium.org> Cr-Commit-Position: refs/heads/master@{#772082}
-
Andrew Xu authored
Re-enable HotseatShelfAppBrowserTest.TappingAppIconsHidesHotseat. Fix one things: In ShelfWidget, contextual nudge related function should not be called when the contextual nudge feature is disabled. Verify this CL with MSAN test. Bug: 1021011 Change-Id: Iff1755001e41e28cfe0490e014502ad711e0b90c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207613 Commit-Queue: Andrew Xu <andrewxu@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#772081}
-
Shakti Sahu authored
This CL fixes 1 - If we get redundant calls to the TileSuggestionProcessor, ignore them and don't update the underlying widget. This will prevent the previous suggestion from flashing up momementarily before new tile set is loaded. 2 - Default ItemAnimator is removed to prevent the jank 3 - Only reload the tile if NTP is reloaded via home button. For regular page load, don't animate query tiles (fixes submit query flow jank) 4 - Fix for international languages - ASCII comparison is not enough for non-english languages. string16 is used for comparison purposes, which fixes the omnibox flow for query tiles (Bug 1086672) Bug : 1086672, 1081557 Change-Id: I8536759fb3f7a9c9c00ddb56f5c12f40df26a114 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211661 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#772080}
-
Jonah Chin authored
Using RasterInterface's CopySubTexture() proved costly. Reverting to replaceBackendTexture in non OOP-R mode to regain lost perf. OOP-R mode will continue to use RasterInterface for copy-on-write. Bug: 1082399, 1082403 Change-Id: I80e1b285e4d7c4336a706d1e5f006afd676f0b2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216591Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: Jonah Chin <jochin@microsoft.com> Cr-Commit-Position: refs/heads/master@{#772079}
-
Rouslan Solomakhin authored
Before this patch, the C++ payment_app.h interface exposed a gfx::ImageSkia type icon, which is difficult to pass to Java. This patch changes payment_app.h interface from gfx::ImageSkia to SkBitmap. After this patch, the C++ payment_app.h interface exposes an SkBitmap type icon, which is easier to pass to Java. Design: https://bit.ly/cross-platform-pay-app-factory Bug: 1022512 Change-Id: I506bec37b1bb298452e1ebe51cc4bd1731d8d032 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212495 Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Liquan (Max) Gu <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#772078}
-
Asanka Herath authored
The hash function originally picked was SuperFastHash(), but we are running into a few limitations. Justification for the new function is explained in identifiability_metrics.cc. Bug: 973801 Change-Id: I6743d72c5b18dc86cf9fe3d4a8d98ef49fbcd7b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213403Reviewed-by:
Caleb Raitto <caraitto@chromium.org> Commit-Queue: Asanka Herath <asanka@chromium.org> Cr-Commit-Position: refs/heads/master@{#772077}
-
Jiewei Qian authored
This CL makes `default-src 'self';` the default Content Security Policy for chrome-untrusted:// URLDataSource. This stops chrome-untrusted:// from using resources from a different origin, unless CSP explicitly allows them. To prevent breakage of existing chrome-untrusted:// WebUIs, we override their default-src to an empty value, and create bug tracker issues for relevant teams to update their CSP. This is a preparation for enabling Fetch API for chrome-untrusted:// scheme. Bug: 1023741 Change-Id: I2e5cfe3877c1e996a678e04aacd378f044332bb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208588 Commit-Queue: Jiewei Qian <qjw@chromium.org> Reviewed-by:
Oleh Lamzin <lamzin@google.com> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Reviewed-by:
Rachel Carpenter <carpenterr@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#772076}
-
Erik Anderson authored
The enums.xml had grown stale due to multiple net errors getting added without also running update_net_error_codes.py. Change-Id: I176da2ddb72567e0c15b46e11392f9140b03c6bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216703 Commit-Queue: Erik Anderson <Erik.Anderson@microsoft.com> Commit-Queue: Matt Menke <mmenke@chromium.org> Auto-Submit: Erik Anderson <Erik.Anderson@microsoft.com> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#772075}
-
Xida Chen authored
Bug: None Change-Id: Iab10726bf0aa4e4aa13803dbec856a0d52142bf1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2198683Reviewed-by:
weiliangc <weiliangc@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#772074}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/24f3a385a38c..0c7d654c7474 2020-05-27 iannucci@chromium.org [bb] Update bb tool to contain latest protos. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1015181,chromium:1086729 Tbr: agable@chromium.org Change-Id: I9dbb2ac1121a2d68b43edb4ab03fc7301d6beaaf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217071Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1590508570-0988b56e609cb55046e696ff8ca55766d5b1565c.profdata to chrome-win32-master-1590537495-1aec0e09840eb111f0a85749393637fa50872c10.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: Ieaa1041592710b382eefed1221a8a151c27dfb88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217075Reviewed-by:
-
Ben Joyce authored
Switched robolectric to be located in android_deps. Local modifications are handled by creating a local_robolectric_jar, and then having the target depend on that, local_robolectric_jar while using a jar_exclude_patterns to remove the original class (to avoid a duplicate class issue.) See design doc: https://docs.google.com/document/d/1fTW40HEoqKvVyuOTWqwhJDK8OL0zX0AHpN-oZ7Wi2GM/edit?usp=sharing After this lands and doesn't cause any breakages, will remove the unnecessary robolectric jars in third_'party/robolectric. Bug: 1060721 Change-Id: I7ec486177795ac1b0bf8fad6a52e63b815a61dc4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2186743 Commit-Queue: benjamin joyce <bjoyce@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Auto-Submit: benjamin joyce <bjoyce@chromium.org> Cr-Commit-Position: refs/heads/master@{#772071}
-
Karandeep Bhatia authored
Do this by introducing a new entry to the LoadRulesetResult enum which is logged to metrics. Also, since the enum is now not solely bound to the RulesetMatcher::CreateVerifiedMatcher result, move it outside the RulesetMatcher scope and change it to be an enum class. Also introduce a version of GetBucketCount to HistogramTester which supports enum classes. BUG=754526 Change-Id: Ib3a626d4f43581a0e875f3c9b66cc6704b77f550 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2205116 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#772070}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/934b9996ee4d..64391c4a55c7 2020-05-26 herb@google.com Reland "generate vertex data in onPrepare" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC westont@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: westont@google.com Change-Id: I6a48a492950ccef2792e3c0b00a7a12d09e9aca9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214996Reviewed-by:
-
Regan Hsu authored
Add missing "Google Drive Search Suggestion" ("Chrome [browser] will access your drive to make search suggestions in the address bar") toggle to "Sync and Google Services". SplitSettingsSync must be disabled and "Omnibox Google drive document suggestions" flag must be enabled to see this change. When both flags are set to default, there is no visible impact. https://screenshot.googleplex.com/NPiR2gTUVKT Bug: 1083029 Change-Id: Idbfcb7bb3f287fbcc5ffa8a333f39c2aef9cdc6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213931 Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by:Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#772068}
-
Katie D authored
Bug: 1047957 Change-Id: Ied78b3132b920698f7e5178c72e1583627f10b49 AX-Relnotes: Fixes crash when dragging STS box and doing a mousewheel. Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216376Reviewed-by:
Anastasia Helfinstein <anastasi@google.com> Commit-Queue: Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#772067}
-
Shakti Sahu authored
This CL tries to fix the multiline text for query tiles. It also tries to make the tile wider so that longer text can fit in. Bug: 1085110 Change-Id: I4de898920435ed96fe3c2811db1e6b8544cefbc4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210663 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#772066}
-
Dominic Farolino authored
Bug: N/A Change-Id: I60d6097499d49c178d0da83197bb2316a2240e37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215257Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#772065}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/be61a7c024b6..aef138255c4c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC mpearson@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1039904,chromium:1083349 Tbr: mpearson@google.com Change-Id: I9bfe0c5001ba69ab37c4f45e43c114c4b4982d29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216762Reviewed-by:
-
nancylingwang@google.com authored
Ash(ShelfController) should observe AppRegistryCache to get the app notification badging information. Ash can't depend on chrome/*, so move AppRegistryCache to components directory to split AppRegistryCache from chrome. BUG=1068884 Change-Id: I215d02203a25f61a0b1dcb9a1a92d69768b4bd93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210208Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#772063}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/0d4647dffe2f..a5e07cc3db44 2020-05-26 tommi@webrtc.org Rename more death test to *DeathTest 2020-05-26 handellm@webrtc.org AsyncResolver: remove dependency on SignalThread. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ia8e869fb068956b083336956da9edadc9a125c11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214997Reviewed-by:
-
Nidhi Jaju authored
ServiceWorkerDatabase for a OOM crash investigation Bug: 848194 Change-Id: Ie6f08af06575c024fe4f81e5725f3235b286d086 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215652Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Nidhi Jaju <nidhijaju@google.com> Cr-Commit-Position: refs/heads/master@{#772061}
-
Rakina Zata Amni authored
With crrev.com/c/2121522, some main-frame same-site navigations will result in a new BrowsingInstance, SiteInstance, RenderFrameHost, RenderView, etc. This CL updates expectations of an extensions/ test that didn't expect a change of RenderFrameHosts etc. on same-site navigations. This CL does not include fixes for other tests in chrome/ content/, components/, and layout tests (they're fixed in other CLs) For more details, see doc: https://docs.google.com/document/d/1lHdkKLUe8H6ZP6ALwj-dsus7oYcuc93HkSCHCcerItg/edit?usp=sharing Bug: 977562 Change-Id: I8b1d61ab107b6cead501fee669f90aeca6c7a34c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212224 Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Reviewed-by:
-
Eric Willigers authored
The flag MediaSessionSeeking has been stable since 2019-08. Bug: 977375 Change-Id: I626de5ee229586f729681825e74d3d57e8c3b36e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209938Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#772059}
-
Chong Gu authored
These tests will add a total of ~6 minutes to bot time and run time per builder run. Bug: 1086742 Change-Id: I29e42d62dc92569f86e941e1417cab6bd3a991a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217011Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Chong Gu <chonggu@google.com> Cr-Commit-Position: refs/heads/master@{#772058}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/f3393ea589ec..a03bec408ff6 2020-05-26 sadrul@chromium.org [tests] Re-enable some scroll-related unit-tests. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC eseckler@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:934649 Tbr: eseckler@google.com Change-Id: I17f18f967db52a9a0e6a0f93d44881e8b65bcee7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214998Reviewed-by:
-
En-Shuo Hsu authored
Add UMA to log the return event from a socket connecting to the Bluetooth device through SCO. This will be used to monitor how frequent the underlying SCO connection setups fail and if our fixes address the issue. The CL on CRAS side: http://crrev.com/c/2198851 BUG=b:2198851 TEST=Deploy adhd and chrome on DUT and verify the event is recorded at chrome: //histogram/Cras Change-Id: I84a817bb01b033e7250c1f5d9e7c4915d5d95851 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208793Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: En-Shuo Hsu <enshuo@chromium.org> Cr-Commit-Position: refs/heads/master@{#772056}
-
Gabriel Charette authored
Note to QA: This CL is purely mechanical and shouldn't be blamed for future regressions on touched files. Only migrate explicit usage of content::BrowserThread in step #1 as these are the only ones that clearly map to a fully qualified call to content::Get(UI|IO)ThreadTaskRunner(). Script @ https://crbug.com/1026641#c91 Will make BrowserTaskTraits optional when empty in a follow-up (can't before end of migration because of cyclic dependency between browser_thread.h and browser_task_traits.h). (will TBR fdoray@ post-review for mechanical change) TBR=fdoray@chromium.org AX-Relnotes: n/a. Bug: 1026641 Change-Id: I27615773472c97d9bfd981c8c9e783c26525b51a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211138Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Auto-Submit: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#772055}
-
Victor Hugo Vianna Silva authored
This CL introduces a new frontendId field to chrome.passwordsPrivate types for passwords and exceptions. This field will be used to group existing duplicates across stores in future CLs. Bug: 1049141 Change-Id: Ib856778e0a06043e44d2d624d4440c38a3358527 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210462Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Commit-Queue: Victor Vianna <victorvianna@google.com> Cr-Commit-Position: refs/heads/master@{#772054}
-
