GitLab

https://skia.googlesource.com/skia.git/+log/f64e958e897a..c880346ba5d1

git log f64e958e897a..c880346ba5d1 --date=short --first-parent --format='%ad %ae %s'
2019-12-18 reed@google.com Detect when perspective is really affine, and update the matrix as we handoff
2019-12-18 mtklein@google.com Reland "roll clang_win"
2019-12-18 mtklein@google.com demote -fsanitize=pointer-overflow to warning
2019-12-18 herb@google.com Only checksum and query a valid descriptor
2019-12-18 bsalomon@google.com "fix" formatting of auto generated cpp from fp

Created with:
  gclient setdep -r src/third_party/skia@c880346ba5d1

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC borenet@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: borenet@google.com
Change-Id: Id9bb6bf1eb4c7bebc8dda0d7ea6cfc6557659024
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974781Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#726189}

This reverts commit d2613d46.

Reason for revert: Retrying after increasing and reconfiguring RBE
workers. This CL will land if win_chromium_compile_dbg_ng remains
stable over the course of a day in MTV.

Original change's description:
> Revert "infra: Migrate builders to Goma RBE (Win Week 4)"
> 
> This reverts commit cde0fa7b.
> 
> Reason for revert: large number of builds on win_chromium_compile_dbg_ng failing w/ goma issues, e.g.
> 
> https://ci.chromium.org/p/chromium/builders/try/win_chromium_compile_dbg_ng/461710
> https://ci.chromium.org/p/chromium/builders/try/win_chromium_compile_dbg_ng/461518
> 
> Original change's description:
> > infra: Migrate builders to Goma RBE (Win Week 4)
> >
> > CI:
> > -win32-archive-rel
> > -win32-archive-dbg
> > -Libfuzzer Upload Windows ASan
> > -Windows deterministic
> > -Mojo Windows
> > -win-celab-builder-rel
> > -win-asan
> > -Win 10 Fast Ring
> > -win-annotator-rel
> > -win-pixel-builder-rel
> > -win32-arm64-rel
> > -WebRTC Chromium Win Builder
> > -WebRTC Chromium FYI Win Builder
> > -WebRTC Chromium FYI Win Builder (dbg)
> > -win-swangle-x86
> > -win-swangle-x64
> > -win-swangle-tot-angle-x86
> > -win-swangle-tot-angle-x64
> > -win-swangle-tot-swiftshader-x86
> > -win-swangle-tot-swiftshader-x64
> >
> > Try:
> > -win_archive
> > -win_mojo
> > -win-asan
> > -win-annotator-rel
> > -win-swangle-try-x86
> > -win-swangle-try-tot-angle-x86
> > -win-swangle-try-x64
> > -win-swangle-try-tot-swiftshader-x86
> > -win-swangle-try-tot-angle-x64
> > -win-swangle-try-tot-swiftshader-x64
> > -win-libfuzzer-asan-rel
> > -win10-blink-rel
> > -win7-blink-rel
> > -win10_chromium_x64_rel_ng_exp
> > -win-celab-try-rel
> >
> > Schedule of migration:
> > https://docs.google.com/spreadsheets/d/1TZhpasm6iceYm7zqkyEtZ1wn9ZcpREfH4LV4cusICJA/edit#gid=0
> >
> > Bug: 950413
> > Change-Id: I476de2fe97d88f3b636b97b91457b0b61ffe30d1
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1924184
> > Reviewed-by: Aaron Gable <agable@chromium.org>
> > Commit-Queue: Simon Que <sque@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#724036}
> 
> # Not skipping CQ checks because original CL landed > 1 day ago.
> 
> Bug: 950413
> No-Try: true
> Change-Id: I1a8eab16c75972803d4867f172e4da77ef2f3c41
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1967566
> Reviewed-by: Ben Pastene <bpastene@chromium.org>
> Commit-Queue: John Budorick <jbudorick@chromium.org>
> Commit-Queue: Ben Pastene <bpastene@chromium.org>
> Auto-Submit: John Budorick <jbudorick@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#724696}

TBR=sque@chromium.org,agable@chromium.org,bpastene@chromium.org,jbudorick@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 950413
Change-Id: I873e02a4ffc5e8d23c7cd17d9c0231d48226e0bd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1971630Reviewed-by: Simon Que <sque@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Ben Pastene <bpastene@chromium.org>
Commit-Queue: Simon Que <sque@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726188}

login attempt.

Bug: 993430
Change-Id: I2f632393463bfa530b98e3c604d8b368cfff0024
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954539
Commit-Queue: Rakesh Soma <rakeshsoma@google.com>
Reviewed-by: Tien Mai <tienmai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726187}

Bug: 871934
Change-Id: I00dfc3b02b12159af95090c13e5aaab1b45364f2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1969984Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Commit-Queue: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726186}

Specifically moving:
 - manage_a11y_page
 - switch_access_subpage
 - tts_subpage

These subpages are no longer used anywhere other than OS Settings.

Bug: 1026455
Change-Id: I1f22f73ea66158e100a98407ce6850ebccd9f5b1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1972620
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726185}

For multi-display dragging from overview, there shall be a drop target
in the display being dragged in.

Test: manual
Bug: 961170
Change-Id: If8439a301310f82896a776589c3d6be751b9504e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1972297Reviewed-by: Sammie Quon <sammiequon@chromium.org>
Commit-Queue: Avery Musbach <amusbach@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726184}

This reverts commit 79fc11a5.

Reason for revert: Broke android-archive-rel build.
https://ci.chromium.org/p/chromium/builders/ci/android-archive-rel/7634

Original change's description:
> Implement __cxa_pure_virtual to avoid undefined symbol error
> 
> "undefined symbol: __cxa_pure_virtual" will happen when building
> //base/android/linker:chromium_android_linker with
> use_clang_coverage = true
> 
> It seems we can use infinite loop to avoid this error:
> https://stackoverflow.com/questions/920500/what-is-the-purpose-of-cxa-pure-virtual
> 
> 
> Bug: 1018780
> Change-Id: I97cc0a495320c4ede1ecd43cf1b7816b58646960
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1968050
> Commit-Queue: Yun Liu <yliuyliu@google.com>
> Reviewed-by: Ross McIlroy <rmcilroy@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#726178}

TBR=digit@chromium.org,rmcilroy@chromium.org,yliuyliu@google.com

Change-Id: Ia68fbab2f43bed74b8e134397973b83dcc5bf6e8
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1018780
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974294Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726183}

Also adds .ini file reading & writing logic.

Bug: 922145
Change-Id: I6abd19f70dc610f2b8b0e0bb5068ef0d64bf659a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1973194Reviewed-by: Yun Liu <yliuyliu@google.com>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726182}

https://quiche.googlesource.com/quiche.git/+log/ce445c76d..e223d0ec

$ git log ce445c76d..e223d0ec6 --date=short --no-merges --format='%ad %ae %s'
2019-12-18 dschinazi@google.com Internal QUICHE change
2019-12-18 ianswett@google.com Define kAlarmGranularity and use it in the non-test QUIC code.
2019-12-18 wub@google.com gfe-relnote: (n/a) Add a Bbr2Sender::GetTargetBytesInflight function and use it in Bbr2ProbeBwMode. Refactor only, no behavior change.

Change-Id: I30bac31d7255f70031ae9af4fcc1653841d067ec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974812
Commit-Queue: David Schinazi <dschinazi@chromium.org>
Commit-Queue: Ryan Hamilton <rch@chromium.org>
Reviewed-by: Ryan Hamilton <rch@chromium.org>
Auto-Submit: David Schinazi <dschinazi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726181}

This is a first draft to get something out there.
I'm thinking I will rotation the chart to swap x and y later.

Bug: 1030840
Change-Id: I0b5c8204cb5be8f3d3708efc5588c382a8ce0d5b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974836Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: John Chen <johnchen@chromium.org>
Commit-Queue: Caleb Rouleau <crouleau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726180}

Instead of timing out when reading of the file fails, actually report
an error.

Bug: none
Change-Id: I1a32f3b1bc1361eb61ba17d86e67bf8d05692033
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974394Reviewed-by: Noel Gordon <noel@chromium.org>
Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726179}

"undefined symbol: __cxa_pure_virtual" will happen when building
//base/android/linker:chromium_android_linker with
use_clang_coverage = true

It seems we can use infinite loop to avoid this error:
https://stackoverflow.com/questions/920500/what-is-the-purpose-of-cxa-pure-virtual


Bug: 1018780
Change-Id: I97cc0a495320c4ede1ecd43cf1b7816b58646960
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1968050
Commit-Queue: Yun Liu <yliuyliu@google.com>
Reviewed-by: Ross McIlroy <rmcilroy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726178}

This change removes the copy constructor for ImportantDomainInfo to
prevent accidental copies of instances. The change also gets rid
calls to said constructor.

Bug: 1034140
Change-Id: Ib4fe05701df84922333c864f8c6094c95f8a192e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1967739
Commit-Queue: Jarryd Goodman <jarrydg@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726177}

R=rch@chromium.org

Change-Id: Ib9e27b96a4f2b7bb6975444dc3ba57472afa6897
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974611Reviewed-by: Ryan Hamilton <rch@chromium.org>
Commit-Queue: Victor Vasiliev <vasilvv@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726176}

Bug: 1035482
Change-Id: I68c34d0a3c2b2bb5867bcf1142d87a7a67434217
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974692
Commit-Queue: Saman Sami <samans@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726175}

<This change is hidden behind a flag>

As part of migrating PK rule-based IMEs to native code, this CL migrates
activate/deactivate to native code path.

We port RuleBasedController#onActivate/onDeactivate in
chos/pk/rulebasedcontroller.js.

Note that we need these to call through to the extension, as it has
side effects that may affect the extension when it is running (e.g.
when VK is up).

We also added a bunch of metrics collection that was in the extension
code.

Note that the JS code has already been guarded by the runtime flag.

Bug: 1009903
Change-Id: Ib72ea3916d6f66c17c6553a7f137e1eb1647e181
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1970294
Commit-Queue: Darren Shen <shend@chromium.org>
Reviewed-by: Shu Chen <shuchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726174}

Add a flag to show Cast sessions in the Global Media Controls UI.

Bug: 987479
Change-Id: Iaeb93ec79365319020bde0c216091a861d8de509
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1971050Reviewed-by: Tommy Steimel <steimel@chromium.org>
Commit-Queue: Takumi Fujimoto <takumif@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726173}

This is a reland of c6e3166e

Original change's description:
> Convert base::Bind etc in services/ (1/2)
> 
> This covers removal of deprecated base::Bind, base::Callback,
> base::Closure, base::Passed across services/data_decoder/ and
> services/device/.
> 
> Bug: 1007831
> Change-Id: I03ca32424d53e91e6720e9209cb19a564a19de96
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1970231
> Reviewed-by: Matt Reynolds <mattreynolds@chromium.org>
> Reviewed-by: Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org>
> Commit-Queue: Ken Rockot <rockot@google.com>
> Cr-Commit-Position: refs/heads/master@{#725374}

Bug: 1007831
Change-Id: Ic9be3c5e1d9db3d7addaf1c952506dd33e8b8ad3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974754Reviewed-by: Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org>
Commit-Queue: Ken Rockot <rockot@google.com>
Cr-Commit-Position: refs/heads/master@{#726172}

Using 'simulateSelect()' should generate only one "select" event, but since the
state value wasn't being reset it was also creating additional ones for each
following frame. This wasn't causing problems for the single existing test
using it (events_session_select_subframe), but is a trap for other uses.

Change-Id: I87cd55b1c0654d0183aa39af9bd5ad178d7409da
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974682Reviewed-by: Piotr Bialecki <bialpio@chromium.org>
Commit-Queue: Klaus Weidner <klausw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726171}

If a frame is throttled, then it may have dirty layout by the time
PageAnimator::UpdateHitTestOcclusionData runs. There is no empirical
evidence that render throttling is actually causing the crashes in the
wild, so also add a diagnostic CHECK.

BUG=1035029
R=chrishtr@chromium.org

Change-Id: Ie8d1aa5d48cf94832616403e27965722b809020b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1972230Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: Stefan Zager <szager@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726170}

Introduce a WebContentsObserver test helper that tracks the console
for a message to be introduced, and records seen messages. This
leverages the new WebContentsObserver::OnDidAddMessageToConsole()
method.

This also replaces content::ConsoleObserverDelegate. It's superior
because it doesn't require replacing the existing WebContentsDelegate -
which can at best be extra work and at worst cause different behavior
and mask test issues.

Use the new class in BrowserTest.NoJavaScriptDialogsActivateTab, which
is an example of where it's better and more ergonomic. Instead of
having a custom ConsoleObserverDelegate that forwards along certain
calls (here, GetJavaScriptDialogManager()) to the original
WebContentsDelegate, we just instantiate a
WebContentsConsoleObserver.

Bug: 1034150
Change-Id: Id5776f93fdcd747305ac62960d0f1b5a29d318d6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974490
Commit-Queue: Peter Boström <pbos@chromium.org>
Auto-Submit: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Peter Boström <pbos@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726169}

This reverts commit 4b1723f2.

Reason for revert:crbug.com/1035586

Original change's description:
> Remove native deps from chrome_junit_tests
> 
> And adds an "assert_no_deps" to prevent regressions.
> Would be nice to assert that the junit target does not depend on //base,
> but it looks like all grit targets depend on //base, and fixing that
> would require a larger refactor.
> 
> Bug: None
> Change-Id: I970cdb458d50a32f55165756a10e66857470d75a
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1953400
> Reviewed-by: Peter Wen <wnwen@chromium.org>
> Reviewed-by: Matt Reynolds <mattreynolds@chromium.org>
> Commit-Queue: Andrew Grieve <agrieve@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#723080}

TBR=wnwen@chromium.org,agrieve@chromium.org,mattreynolds@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: None
Change-Id: I5f5d1e67637e6aa4d1008b8227c84ce114bcf867
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974586Reviewed-by: Alexander Cooper <alcooper@chromium.org>
Commit-Queue: Alexander Cooper <alcooper@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726168}

Previously, the keyboard layout was read in the context of the network
process, which wasn't necessarily the same as the keyboard the user
currently had activated. This CL moves querying the keyboard to the
desktop process, which is able to determine the active window and query
that window's keyboard layout.

Bug: 1026029
Change-Id: I3475113d428fe141e419b519d55a4cf99e508471
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949295
Commit-Queue: Erik Jensen <rkjnsn@chromium.org>
Reviewed-by: Matthew Denton <mpdenton@chromium.org>
Reviewed-by: Joe Downing <joedow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726167}

In this patch we add a |NGPhysicalFragment::IsPaintedAtomically| flag
to determine if a fragment should be painted atomically.

This is treated as the source of truth, v.s. checking if something is
an atomic-inline, a flex-item, etc.

This bit also in the |NGConstraintSpace| as a parent layout will
determine if a child should be painted atomically (as it typically has
this information).
See calls to |NGConstraintSpaceBuilder::SetIsPaintedAtomically|.

This passes two additional tests.

Bug: 845235
Change-Id: I145ca8c53c667727ed776d6901bb1b76bfd9063c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1924877Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: David Grogan <dgrogan@chromium.org>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726166}

Using TerminateProcess to exit from utility processes has dropped the
crash rate significantly so it makes sense to apply the same recipe to
ppapi processes. Over 80% of utility and ppapi process crashes are
during shutdown so using TerminateProcess will get rid of most of the
crashes, thus making triage easier.

TerminateProcess is also faster.

Bug: 1024560
Change-Id: I214e0bdcaddfdac41a7d6f5dd2ff3a0e749871a4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1972896Reviewed-by: Ken Rockot <rockot@google.com>
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726165}

Replaces waiting on a histogram recording to know when a navigation is
complete with a content::WaitForLoadStop(). This seems to address the
flakey timeout I was reproducing locally.

Bug: 1032558, 1035377
Change-Id: I2a6e032ea6b112988699ea06275bbd28ec261362
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974431
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726164}

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll
Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast
Tbr: cr-fuchsia+bot@chromium.org
Change-Id: Ibaa2022172bc5395ec295f1a639a18c4f560d467
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974789Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#726163}

The reason for this issue is a bubble dialog does not get the correct
bounds if the anchor window changes bounds when the anchor window has an
un-identity transform in place. This CL forces the bubble dialog
relayout itself when the anchor window's transform reset to the identity
transform.

Bug: 1035512
Change-Id: I3e73400320ecb5df99016ff1f53e6325dca2a1ad
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974594Reviewed-by: Sammie Quon <sammiequon@chromium.org>
Commit-Queue: Xiaoqian Dai <xdai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726162}

The metric is sending twice as much data as it should, and we
are about to add a corresponding compositor latency metric. Hence
we need to reduce the sampling rate by a factor of 4.

Bug: 1035531
Change-Id: If3dfcce9db624d28495c1f44c4887f55cf004326
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974610
Auto-Submit: Stephen Chenney <schenney@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Stephen Chenney <schenney@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726161}

Instead it (and its devired class WebRtcAudioDeviceImpl) operate
over WTF::String.

BUG=923394
R=guidou@chromium.org

Change-Id: I13928733af68463d789170ebb7aa7a6836288b55
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1970138Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Cr-Commit-Position: refs/heads/master@{#726160}

https://pdfium.googlesource.com/pdfium.git/+log/8cb6a652ad24..3567a9a85896

git log 8cb6a652ad24..3567a9a85896 --date=short --first-parent --format='%ad %ae %s'
2019-12-18 thestig@chromium.org Roll third_party/depot_tools/ fe18a43d5..603782044 (20 commits; 3 trivial rolls)
2019-12-18 thestig@chromium.org Avoid crash in CPDF_SecurityHandler::GetUserPassword().
2019-12-18 tsepez@chromium.org Unify FPDF_FORMFILLINFO versioning and mark V2 as experimental
2019-12-18 dhoss@chromium.org Add --disable-javascript flag to test_runner.py

Created with:
  gclient setdep -r src/third_party/pdfium@3567a9a85896

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pdfium-autoroll
Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: pdfium-deps-rolls@chromium.org
Change-Id: Icabc3e679d59004acfd783a8be4b70793cbd44d7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974592Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#726159}

Update chrome/android/javatests/src/org/chromium/chrome/browser/explore_sites/OWNERS
with the UI>Browser>NewTabPage>ExploreSites component. This should help
triaging, and I think will make FindIt automatically apply the label
the bugs found in running these tests.

Bug: None
Change-Id: I6b39fcbcc59ccb78a69573ef29ffbefece3e7344
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974597Reviewed-by: Justin DeWitt <dewittj@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726158}

The root of the Fuchsia semantic tree always has root id 0. This isn't
a constraint in Chromium, so some special handling has been added to
ensure the semantic tree received by Fuchsia maintains a consistent,
valid state.

Test: Expanded AccessibilityBridgeTest.

Bug: fuchsia:42172
Change-Id: Ic1e2398e0a6793bcbfef36643af64b78f79fea22
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954321
Commit-Queue: Sharon Yang <yangsharon@chromium.org>
Reviewed-by: Kevin Marshall <kmarshall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726157}

Right now, the extension may need to reset the state of an engine w/o
deactivating it. For example, if the user starts voice input, we need
to reset the engine state (voice input is not an engine; if it was an
engine, everything will work because we would deactivate the current
engine before starting voice input).

So far, this has been fine because the extension contained both UI
and IME code. But when we move to a native model, UI will no longer
contain IME code, so it will need to signal to IMF to reset the state
of the engine.

We add a new private API for resetting the engine.

Bug: 1009903
Change-Id: I7e0b9a18a308d5e9834a4a341d71192b37745b98
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1971047Reviewed-by: Shu Chen <shuchen@chromium.org>
Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Commit-Queue: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726156}

... to use WTF::Vector instead.

BUG=923394
R=guidou@chromium.org

Change-Id: I08ddf7cbaac201f8b6e93aa1f4ba1addbc55f3d0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1970133Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Cr-Commit-Position: refs/heads/master@{#726155}

This change will alter the focus behavior for the quick settings
and message center when chrome vox is enabled. The initial focus
will now go to the entire widgets rather than the first element.

Bug: 1021133
Change-Id: Ifea0cc6e1ee59bd94f8a52a846e8f0abdfcb5744
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1973157Reviewed-by: Tim Song <tengs@chromium.org>
Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726154}

Note that the CL introduces a copy routine, prior to
calling the backed libwebrtc functionality.

BUG=787254
R=guidou@chromium.org

Change-Id: Ia571015e723b3f9338308319647bd3496eb42d65
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1969611Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Cr-Commit-Position: refs/heads/master@{#726153}

-Splits bookmarkCurrentTabWithTitle into 2 methods: bookmarkCurrentTabWithTitle
and waitForBookmarkModelLoaded.

-Creates setupBookmarksWhichExceedsScreenHeight, removeBookmarkWithTitle and
moveBookmarkWithTitle, verifyBookmarksWithTitle on BookmarkEarlGrey and
their equivalent on the AppInterface.

- Various changes on BookmarkEarlGreyUI to fix EG2 errors.

Change-Id: I8d6ed0247dbf23b8157917942d96598342a5362c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1973363
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726152}

It is not injected anymore and has been replaced by
SharedPreferencesManager.

Bug: 1022102
Change-Id: Ia4e42bbc4706766ca7b7adba8110c4784b7e8df1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1955809
Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
Reviewed-by: Peter Conn <peconn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726151}

Adds tests for the Hunspell fallback logic (Windows hybrid spell checking)
submitted here:
https://chromium-review.googlesource.com/c/chromium/src/+/1918277

- Adds browser tests for SpellCheckHostChromeImpl
- Adds component tests for the new SpellcheckHostMetrics
- Adds component test coverage for the new SpellcheckPlatform methods in the
  Windows platform test
    - Created a bug to track splitting the single test into multiple ones
- Adds component tests for SpellcheckProvider
    - Creates a new FakeSpellCheck class to fake the count of enabled spell
      check locales, which is needed to control when to call into the
      browser spell checker

Bug: 463364, 1035450
Change-Id: Ie3e692c0d5d5970ed2ab7612018198bf42049139
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1972573
Auto-Submit: Guillaume Jenkins <gujen@google.com>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726150}