- 01 Nov, 2018 40 commits
-
-
mark a. foltz authored
Cast Setup in Chrome is deprecated and is being removed in M72. This removes the Media Router context menu item to access Cast Setup. This patch also restricts navigation in the chrome://cast WebUI to Cast Offers, which is not being deprecated. Tested by manually navigating to various chrome://cast URLs. Screenshot: https://drive.google.com/open?id=1XRpTGtqiQ458eLdJ0oY72OObmU85XRfQ Bug: 895580 Change-Id: I7c94f00cebe80246c11d17e163f5e92ed1ecbdcc Reviewed-on: https://chromium-review.googlesource.com/c/1308085Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Commit-Queue: mark a. foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/master@{#604662}
-
Xi Han authored
In this CL, we move the creates FeatureList and setup field trials from AwBrowserMainParts::PreCreateThreads() to AwMainDelegate::PostEarlyInitialization(). So it happens before ServiceManagerContext is created and the TaskSchedueler starts in ContentMainRunnerImpl::Run(). Bug: 887468,899376 Change-Id: Ie4d3223cf5206d8aadb537b7b80d9e196d4512be Reviewed-on: https://chromium-review.googlesource.com/c/1305876Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Paul Miller <paulmiller@chromium.org> Commit-Queue: Xi Han <hanxi@chromium.org> Cr-Commit-Position: refs/heads/master@{#604661}
-
Regan Hsu authored
MultiDevice.DeviceSyncService.SetSoftwareFeatureState.Result.FailureReason Add metrics which breaks down the percentages of reasons when failure occurs on SetSoftwareFeatureState. Bug: 870138 Change-Id: I277eeb3f0e0e3fe4418affb91977c7ddf74a9365 Reviewed-on: https://chromium-review.googlesource.com/c/1308979Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Regan Hsu <hsuregan@chromium.org> Cr-Commit-Position: refs/heads/master@{#604660}
-
Miguel Casas-Sanchez authored
crrev.com/c/1294870 uprev'ed Pixel_CanvasLowLatency2D, this CL now reenables it. To monitor: android-marshmallow-arm64-rel bot. Bug: 865957 Change-Id: I89eb31722c430b0134093a7d9db51ae469b76652 Reviewed-on: https://chromium-review.googlesource.com/c/1306648Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#604659}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/cc9857f9b84d..51fdcfba7593 git log cc9857f9b84d..51fdcfba7593 --date=short --no-merges --format='%ad %ae %s' 2018-11-01 perezju@chromium.org [pinpoint_cli] Add command to check status of pinpoint jobs Created with: gclient setdep -r src/third_party/catapult@51fdcfba7593 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:879526 TBR=sullivan@chromium.org Change-Id: Idc405fc3595cf37011392ee0b745e683ab4435eb Reviewed-on: https://chromium-review.googlesource.com/c/1313029Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#604658}
-
Gaurav Dhol authored
Add guard to avoid using x86 header for ARM64 Resolves this error ./base/atomicops_internals_x86_msvc.h(62,3): error: use of undeclared identifier '__faststorefence' __faststorefence(); Bug: 893460 Change-Id: I82b31e0470c63b4465b430768a73071722e16ed3 Reviewed-on: https://chromium-review.googlesource.com/c/1301195Reviewed-by:
Mark Mentovai <mark@chromium.org> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#604657}
-
Peter Kotwicz authored
This CL changes the WebAPK to send the name of the launching activity only for share targets. The goal of this CL are: - In an upcoming CL I will send an intent to Chrome to relaunch the WebAPK. This CL removes the need to send the action which launched the WebAPK to Chrome. (ACTION_SEND can be assumed if the org.chromium.webapk.selected_share_target_activity_class_name extra is set.) - Add a layer of defense in depth for POST share targets. An incoming intent is for a POST share target if: 1) org.chromium.webapk.selected_share_target_activity_class_name is set on the intent 2) The <meta-data> for the passed in activity has a org.chromium.webapk.shell_apk.shareEnctype key. BUG=817263, 885313 Change-Id: I3667d257f711f1e474a44e3fd9aaf5c41552f30c Reviewed-on: https://chromium-review.googlesource.com/c/1307075 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:Xi Han <hanxi@chromium.org> Cr-Commit-Position: refs/heads/master@{#604656}
-
liberato@chromium.org authored
This change affects how overlays are chosen on Android. Previously, DisplayResourceProvider would notify all resources that requested a promotion hint, unless they were scheduled for deletion. The intent was that only the resources that are used for the current frame would receive hints. However, that no longer works. The DisplayResourceProvider was sending hints to resources that weren't considered for overlay, such as resources used by a previous CompositorFrame. The result was that the requestor would be told that the resource wasn't promotable, and would try to switch away from SurfaceView. In reality, it just wasn't supposed to be on the screen. Instead, we now explicitly construct a list of resource IDs that are used by DrawQuads, and limit the hints to those. We do this only if any resource (displayed or not) is requesting promotion hints, which should prevent the overlay processor from doing the extra work except when the results actually will be used. Bug: 900438 Change-Id: Iba56e256b08233c9c05bd299d0ecd4a556807ccd Reviewed-on: https://chromium-review.googlesource.com/c/1310498 Commit-Queue: Frank Liberato <liberato@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#604655}
-
Francois Doray authored
These histograms record the size of the resident memory per process type and in total. Resident memory is influenced by factors we control (e.g. memory that is not accessed can be swapped) and factors we don't control (e.g. an unrelated process using a lot of memory can force memory in our process to be swapped). Histograms are recorded once per UMA ping. These histograms are added to answer the following question: - Do the efforts we make to reduce the amount of memory accessed by frozen renderers has an impact on the size of their working set? Bug: 885293 Change-Id: I7cb3b1b5bd4d927277f5f4c9e96455dc0ff2ef94 Reviewed-on: https://chromium-review.googlesource.com/c/1301847 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#604654}
-
Kelvin Jiang authored
The placeholder icon for an extension is the first letter of the extension's name on a grey background. extension->name() (which we currently use) is padded with formatting characters if RTL mode is enabled, and grabbing the first character in that case does not get us the extension's actual name. Fix is implemented by reversing the RTL adjustment of the extension's name before getting the first letter. Bug: 869358 Change-Id: I986c2aade64e981ce634f5d14befd21df759d9cd TEST: This behavior is difficult to automatically test. To test manually: 1) Load an extension without an icon set in the manifest and note the appearance of the placeholder icon. 2) Navigate to chrome://flags and toggle "force ui direction" to RTL (search for rtl to find this flag), then click to relaunch when prompted. 3) The extension placeholder icon's appearance should not change and should show the first letter of the extension's name as defined in the manifest. Change-Id: I986c2aade64e981ce634f5d14befd21df759d9cd Reviewed-on: https://chromium-review.googlesource.com/c/1302633Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Kelvin Jiang <kelvinjiang@chromium.org> Cr-Commit-Position: refs/heads/master@{#604653}
-
Daniel Rubery authored
CheckClientDownloadRequest was using 3 methods to prevent use-after-free (weak pointers, ref counting, and cancelable tasks). This CL replaces all of those with weak pointers, so that CheckClientDownloadRequest can be singly owned by the DownloadProtectionService. Bug: 889986 Change-Id: I098d207df9fccd7842c7fdc65dba94c75ec8b062 Reviewed-on: https://chromium-review.googlesource.com/c/1289956 Commit-Queue: Daniel Rubery <drubery@chromium.org> Reviewed-by:
Nathan Parker <nparker@chromium.org> Cr-Commit-Position: refs/heads/master@{#604652}
-
Alex Clarke authored
Now you have to set SetDelayedFenceAllowed in the spec if you want to use delayed fences on a particular TaskQueue. Bug: 897751 Change-Id: I5ca9869ae6999fde264e2553e451c1b08fe90204 Reviewed-on: https://chromium-review.googlesource.com/c/1309776 Commit-Queue: Alex Clarke <alexclarke@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#604651}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/ab688385cfbd..a69842065243 git log ab688385cfbd..a69842065243 --date=short --no-merges --format='%ad %ae %s' 2018-11-01 thestig@chromium.org Update third_party/yasm/BUILD.gn. 2018-11-01 thestig@chromium.org Roll third_party/skia/ edc6ea7a9..b98fb5b08 (131 commits; 1 trivial rolls) 2018-11-01 thestig@chromium.org Roll third_party/skia/ ffbcc3fad..edc6ea7a9 (1 commit) 2018-11-01 tsepez@chromium.org Make CPDF_ContentMarkItem stop caching the properties dict. 2018-11-01 tsepez@chromium.org Remove notion of file writing from CFX_GlobalData Created with: gclient setdep -r src/third_party/pdfium@a69842065243 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:900552 TBR=dsinclair@chromium.org Change-Id: Iaa3e70c669163835e43a0ca57563cd4406d90b3d Reviewed-on: https://chromium-review.googlesource.com/c/1313032Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/fe45da4f047e..189013bef993 git log fe45da4f047e..189013bef993 --date=short --no-merges --format='%ad %ae %s' 2018-11-01 sprang@webrtc.org Update QualityTestVideoEncoder to use GetEncoderInfo() 2018-11-01 sprang@webrtc.org Updated ScopedVideoEncoder to use GetEncoderInfo() 2018-11-01 aleloi@webrtc.org Make the extra seturation margin configurable. 2018-11-01 sprang@webrtc.org JitterEstimator: Remove old LowRate exp and add trial for upper bound. 2018-11-01 nisse@webrtc.org Add implicit conversion between rtc:PacketTime and int64_t. 2018-11-01 sprang@webrtc.org Add ability to enable frame dumping decoder via field trial. Created with: gclient setdep -r src/third_party/webrtc@189013bef993 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Id38bc5fbedab85675e94ce93d87568c88b7db314 Reviewed-on: https://chromium-review.googlesource.com/c/1313031Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/fa7df23d8b0c..460a43deb18f git log fa7df23d8b0c..460a43deb18f --date=short --no-merges --format='%ad %ae %s' 2018-11-01 herb@google.com Remove the unused buffers for unique glyph handling 2018-11-01 halcanary@google.com tools/skqp/make_universal_apk -> python 2018-11-01 mtklein@google.com test for hash collision with memcmp 2018-11-01 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skia/third_party/skcms 1ce6da5c8d99..26679709b32f (1 commits) 2018-11-01 herb@google.com Reland "Move from a functional to object based interface between Painter and SkDraw" 2018-11-01 caryclark@skia.org update bookmaker build docs Created with: gclient setdep -r src/third_party/skia@460a43deb18f The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel BUG=chromium:900835 TBR=herb@chromium.org Change-Id: I5ebde540f95053b8135a2ccaace218c1348882e0 Reviewed-on: https://chromium-review.googlesource.com/c/1313030Reviewed-by:
-
Ian Kilpatrick authored
We spend a lot of time collecting floats. This is for an edge-case calculation when shape-outside is specified on another float. Typically this doesn't happen. This change checks if a float is added with shape outside, and invalidates the derived_geometry_ member to indicate it needs to track these objects now. This removes one of the last large allocations in the exclusion space code, and improves micro-benchmarks by 5-10%. Bug: 635619 Change-Id: I32abb143959e28c526c16e779f9e2dc9c0992d56 Reviewed-on: https://chromium-review.googlesource.com/c/1309144Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#604647}
-
Josh Karlin authored
Change-Id: I2939d0b4f8e82f241f8b80d91417b2bb3483bf5d Reviewed-on: https://chromium-review.googlesource.com/c/1312683 Commit-Queue: Josh Karlin <jkarlin@chromium.org> Commit-Queue: Peter Beverloo <peter@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#604646}
-
Robert Iannucci authored
The currently pinned version doesn't understand SHA256 package IDs. Update these pins to the currently deployed vpython version. R=bpastene@chromium.org, dgarrett@chromium.org Bug: 878994 Change-Id: I8e5dd3023fd91f3e8f2155638d3464b23f05906f Reviewed-on: https://chromium-review.googlesource.com/c/1312976Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Robbie Iannucci <iannucci@chromium.org> Cr-Commit-Position: refs/heads/master@{#604645}
-
Alexandre Frechette authored
To increase visibility of the translate button on smaller screen device, we put it above the share button. See discussion in PRD: go/chrome-translate-manual-trigger. SCREENSHOT: https://screenshot.googleplex.com/NWuZVLCYSPn.png Bug: 883456 Change-Id: I7d334995e9cf7d15c312d23027c99ea52937d27e Reviewed-on: https://chromium-review.googlesource.com/c/1287093Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Alexandre Frechette <frechette@chromium.org> Cr-Commit-Position: refs/heads/master@{#604644}
-
Ryan Sturm authored
This adds tests to verify that opt outs are actually recorded and tracked appropriately for Previews. Bug: 900724,778793 Change-Id: Ib927645256eeeb7df08092eeb80f5652f295edbc Reviewed-on: https://chromium-review.googlesource.com/c/1311375 Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Doug Arnett <dougarnett@chromium.org> Cr-Commit-Position: refs/heads/master@{#604643}
-
Luke Zielinski authored
The legacy SBER pref has been completely replaced by the Scout pref. This change removes the legacy SBER string and removes the checkbox from the unified and un-unified UIs. Bug: 662944 Change-Id: Icae674d21de1782dfaef5cc125a9bc79cbf4fa1a Reviewed-on: https://chromium-review.googlesource.com/c/1312624Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f4ede5cbd079..f6fd71fba4d7 Created with: gclient setdep -r src-internal@f6fd71fba4d7 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:891734 TBR=mmoss@chromium.org Change-Id: Ieda6abbeb66e9c2beed6f216d0d3c7e74071f710 Reviewed-on: https://chromium-review.googlesource.com/c/1313008Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#604641}
-
Becca Hughes authored
Debug information that is common across all media session types should be populated by media internals instead of the sessions themselves. This removes the need for duplicating logic across session types. Test: MediaInternalsAudioFocusTest BUG=875004 Change-Id: I0395e49423593d255973464658dbe41a3aa15b66 Reviewed-on: https://chromium-review.googlesource.com/c/1300103Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#604640}
-
Sergey Ulanov authored
FuchsiaVideoDecoder needs to be able to return frames with stride != width. Previously VideoFrameLayout::Wrap*() functions didn't allow to wrap such frames. This CL adds VideoFrame::WrapExternalDataWithLayout() which allows to pass frame layout explicitly. FuchsiaVideoDecoder uses the new function to create VideoFrame instances it returns. Bug: 876519 Change-Id: I2deaa15e5311dafd1c30a80a525530e2d70ee8e9 Reviewed-on: https://chromium-review.googlesource.com/c/1303965 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#604639}
-
Paul Meyer authored
This test is meant to crash the render process intentionally, and so should not be run on ASan bots. Bug: 900926 Change-Id: I0399dcbccf7974684837ab43c5f00892cce07b0b Reviewed-on: https://chromium-review.googlesource.com/c/1312979Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Paul Meyer <paulmeyer@chromium.org> Cr-Commit-Position: refs/heads/master@{#604638}
-
Erik Luo authored
Clients will need to render a generic object/DOMNode, and be able to call `select()` to select the first child in the resulting TreeOutline. This CL: - Turns Common.Renderer > UI.Renderer - Returns a tree, so interested clients can use it Bug: 865674 Change-Id: Id877537a3c8713b99d34e6a4558037e0c8b3a111 Reviewed-on: https://chromium-review.googlesource.com/c/1298023Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Joel Einbinder <einbinder@chromium.org> Commit-Queue: Erik Luo <luoe@chromium.org> Cr-Commit-Position: refs/heads/master@{#604637}
-
Peter Wen authored
Commands used: - `rm -rf third_party/android_deps/libs/[!O]*` - `tools/android/roll/android_deps/fetch_all.py --update-all` Added text license for GNU v2 with classpath exception since one dep was downloading a full html page for it. Bug: 900912 Change-Id: Ib3213d41259da0921e9d66cea2d08af2f29d383c Reviewed-on: https://chromium-review.googlesource.com/c/1312563Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#604636}
-
Rayan Kanso authored
This was previously submitted as cl/1160848 This is the first step in supporting uploads for Background Fetch Bug: 774054 Change-Id: I325302b77313b38f211cb035522f80308cc83e14 Reviewed-on: https://chromium-review.googlesource.com/c/1297973 Commit-Queue: Rayan Kanso <rayankans@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/a6b8b8078371..5d27da308ea5 git log a6b8b8078371..5d27da308ea5 --date=short --no-merges --format='%ad %ae %s' 2018-11-01 fmayer@google.com Merge "profiling: Add proto for heapprofd." Created with: gclient setdep -r src/third_party/perfetto@5d27da308ea5 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: Ibf2e80a90dd73c5b913511b45666b0a1c7f9a6e3 Reviewed-on: https://chromium-review.googlesource.com/c/1313028Reviewed-by:
-
Jordan Demeulenaere authored
Change-Id: I6eedb76b32a2ea78b7779daab37785bff0e00174 Reviewed-on: https://chromium-review.googlesource.com/c/1312478Reviewed-by:
Stephane Zermatten <szermatt@chromium.org> Commit-Queue: Jordan Demeulenaere <jdemeulenaere@chromium.org> Cr-Commit-Position: refs/heads/master@{#604633}
-
David Quiroz Marin authored
Deprecate histogram and remove all references. Bug: 894043 Change-Id: I101f75fc0882a7844a58507a194eb1a5efde207e Reviewed-on: https://chromium-review.googlesource.com/c/1308755 Commit-Queue: David Quiroz Marin <davidqu@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Reviewed-by:
-
James Hawkins authored
The get*Enabled method is no longer called in release. R=hansberry@chromium.org Bug: 899324 Test: none Change-Id: I91261c61ae5f666cf45c14e6c71512f3a7c70a42 Reviewed-on: https://chromium-review.googlesource.com/c/1312094Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
-
Andrew Comminos authored
If a BaseAudioContext is uninitialized, its render thread will no longer clear associated orphaned render nodes (as it is stopped). Instead of checking whether or not the context has reported itself as being closed (which is independent of the initialization state), simply check the initialization state itself. R=hongchan@chromium.org Bug: 858834 Change-Id: I5b088d17122b0c86270ff8ca75b13ab1487a2131 Reviewed-on: https://chromium-review.googlesource.com/c/1284697 Commit-Queue: Andrew Comminos <acomminos@fb.com> Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#604630}
-
Ned Nguyen authored
These days, perf bots are managed by swarming service. If needed, it's better to address keychain issues with swarming infra instead. Removing the keychain metrics help clean the code of speedometer benchmark. Bug: 714231 Change-Id: I3d18bc8da20f904cb254d3d1b2b016a4de05b203 Reviewed-on: https://chromium-review.googlesource.com/c/1312968Reviewed-by:
Erik Chen <erikchen@chromium.org> Reviewed-by:
Emily Hanley <eyaich@chromium.org> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#604629}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/0ccf17e9..17a4d822 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I9470694b01f764e707a7f40d3f5986d870810379 Reviewed-on: https://chromium-review.googlesource.com/c/1312932Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#604628}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/2256c2786cc8..ab688385cfbd git log 2256c2786cc8..ab688385cfbd --date=short --no-merges --format='%ad %ae %s' 2018-11-01 thestig@chromium.org Roll third_party/skia/ b547579d0..ffbcc3fad (556 commits; 56 trivial rolls) 2018-11-01 thestig@chromium.org Roll third_party/skia/ 53956d9bf..b547579d0 (1 commit) 2018-11-01 thestig@chromium.org Roll third_party/skia/ 449624811..53956d9bf (842 commits; 71 trivial rolls) 2018-11-01 thestig@chromium.org Roll third_party/skia/ 9d080a1d5..449624811 (1 commit) 2018-11-01 thestig@chromium.org Roll third_party/skia/ 0917fad2c..9d080a1d5 (87 commits; 5 trivial rolls) 2018-11-01 thestig@chromium.org Roll third_party/skia/ 386d9cf40..0917fad2c (1 commit) 2018-11-01 thestig@chromium.org Roll third_party/skia/ 91e260f4d..386d9cf40 (7 commits) Created with: gclient setdep -r src/third_party/pdfium@ab688385cfbd The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I82b88b8c7ffea8aafc1c617f662623d30b362429 Reviewed-on: https://chromium-review.googlesource.com/c/1313010Reviewed-by:
-
Mustaq Ahmed authored
Change-Id: I4b30c9adb106e85e2e713af0d931f900123885be Bug: 900198 Reviewed-on: https://chromium-review.googlesource.com/c/1307845Reviewed-by:
-
James Hawkins authored
This method did nothing given that no event listener was registered for the auth attempt listener in the WebUI. R=hansberry@chromium.org Bug: 899324 Test: none Change-Id: I4f46d553ee95538a468b05a434f609ab60c7ca52 Reviewed-on: https://chromium-review.googlesource.com/c/1312300Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Reviewed-by:
-
Kevin Bailey authored
In a RTL UI, we'd like the arrow keys to behave intuitively which means they must be reversed from in LTR mode. Also, it makes a slight behavior change: To handle the case of not being able to unfocus the button if the cursor is moved away from the end, we now unfocus the button as soon as the Omnibox is clicked (which makes sense in terms of moving the "focus".) Bug: 894788 Change-Id: I3323a5b2575bdbaad45853799044f21efa65ac63 Reviewed-on: https://chromium-review.googlesource.com/c/1280847 Commit-Queue: Kevin Bailey <krb@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#604624}
-
Tom McKee authored
Rename step_queueing_times_ to sliding_window_ to better clarity. Bug: 883487 Change-Id: I778db437b734a8e498efb69eb3aeff20aeb7cc47 Reviewed-on: https://chromium-review.googlesource.com/c/1299548 Commit-Queue: Tom McKee <tommckee@chromium.org> Reviewed-by:
-
