- 09 Jul, 2019 40 commits
-
-
Devlin Cronin authored
Update the metrics reloaded to the sideload wipeout bubble: - Remove ExtensionBubble.WipeoutUserSelection. It's not interesting, since there is no choice presented to the user (it's informational only). - Push back expiration of ExtensionBubble.ExtensionWipeoutCount to December 2020, and update the description (it previously stated it was only logged if any extensions affected by the wipeout were found; this is incorrect. It's logged on every profile startup). Bug: 975659 Change-Id: I99fe82f69cf48fb77cc791b826c7da4ce0c647b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1689342Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#675818}
-
Yuly Novikov authored
as flaky on ANGLE Android. Skip suppression was lifted in https://chromium-review.googlesource.com/c/chromium/src/+/1355239, so this can be simplified now. TBR=kbr Bug: 979444 No-try: true Change-Id: I1f27637be5da63442dead3a1cc723c3f4c49b5ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1693173Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#675817}
-
Brian Sheedy authored
Updates some portions of the GPU Skia Gold markdown documentation, such as the new triage process using the links reported in Milo. Bug: 965234 Change-Id: If22ee0f6e7af1054df98630f2f9ebb616a8fdbf9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1668092 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#675816}
-
Xiaocheng Hu authored
Spec on blur radius says [1]: "... Specifies the blur radius. Negative values are not allowed." Current implementation performs parse time range check, which is incorrect as calc() doesn't always have a double value. And spec requires clamping instead of parse time check for calc() [2]: "Parse-time range-checking of values is not performed within math functions, and therefore out-of-range values do not cause the declaration to become invalid. However, the value resulting from an expression must be clamped to the range allowed in the target context." This patch changes it to pass |kValueRangeNonNegative| to |ConsumeLength| as it handles non-negative calc() more properly. This is also preparation for adding DCHECK into GetDoubleValue() to avoid calling it on calc() without a double value. [1] https://drafts.csswg.org/css-backgrounds-3/#shadow-blur-radius [2] https://drafts.csswg.org/css-values-4/#calc-range Bug: 979895 Change-Id: Ia8c36641f4ec4111ecf5a94a6ffc6eaacf22049c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1691747Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#675815}
-
Harsh Patel authored
Encoded each table in address_rewriter_rules into single strings separated by the null terminator. As a result address_rewriter parses these strings instead. This results in a decrease in binary size due to less read only relocations. Bug: 958792 Change-Id: I672c3541ddc52c9324bccf5f8ccae674c119518d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1682550 Commit-Queue: Sam Maier <smaier@chromium.org> Reviewed-by:
Sam Maier <smaier@chromium.org> Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Cr-Commit-Position: refs/heads/master@{#675814}
-
Eric Orth authored
As per-platform differences are now separated out at a deeper level (per-platform DnsConfigService inside SystemDnsConfigChangeNotifier), unified the DNS config stuff to be located directly in NetworkChangeNotifier rather than in per-platform subclasses. Required some minor fixes to mock NCN usage, especially custom mocks that were overriding NCN and now getting full DNS config changes (and added env threading requirements that those tests were not setup to handle). For now, HostResolverManager is still listening through NetworkChangeNotifier. It will be updated to directly use SystemDnsConfigChangeNotifier in the next CL. Bug: 971411 Change-Id: Ib0353041dbf60f311e993eb98f8d4b719ce0d2e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1666288 Commit-Queue: Eric Orth <ericorth@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Sky Malice <skym@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
anthonyvd <anthonyvd@chromium.org> Reviewed-by:
Nicolas Zea <zea@chromium.org> Reviewed-by:
Asanka Herath <asanka@chromium.org> Cr-Commit-Position: refs/heads/master@{#675813}
-
Ella Ge authored
Previously we use tick_clock_->Now() on dispatching queued input for scroll resampling, but the time is not actual vsync time/frame time. It's not regular and can affect by delays in the pipeline, and this causes some bad prediction result. This CL changes to use frame_time from BeginFrameArgs, which is the correct vsync time. Besides, this also disable deliver input on high latency mode when resampling is enable. Because resampling/prediction on high latency doesn't make sense, there is no "correct" timestamp in this case. Bug: 969697 Change-Id: I5516656c1d1419cf5fbf990a23122bb04a4fbe33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1681263Reviewed-by:
Robert Flack <flackr@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#675812}
-
Kristi Park authored
Change-Id: Ib0a2a79f3a1b60f212911b8e95701b5d3d7c027f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1691681Reviewed-by:
Kyle Milka <kmilka@chromium.org> Commit-Queue: Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#675811}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/cb8b4a5716ba..3fe8c3a30396 git log cb8b4a5716ba..3fe8c3a30396 --date=short --no-merges --format='%ad %ae %s' 2019-07-09 geofflang@chromium.org Refactor the wait/signalSemaphore entry points to be on the Semaphore object 2019-07-09 shrekshao@google.com Fix regex parenthesis missing escaping backslash 2019-07-09 ianelliott@google.com Vulkan: Add support for GL_RGBA8-to-GL_RGB5_A1 2019-07-09 ianelliott@google.com Vulkan: Note that KHR-GLES3.texture_repeat_mode.* tests pass Created with: gclient setdep -r src/third_party/angle@3fe8c3a30396 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: I544a4a305b6720e75c19fd3ade12aa63e181dbcc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1693443Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#675810}
-
rbpotter authored
It is clear from current data that rotating the PDF in Print Preview is a very uncommon user action, and the usage does not change significantly over time, so it is not necessary to retain this histogram. Bug: 975060 Change-Id: Iea2c21e6d7bf0dee4cc3cf59aa2746edbb1e8a84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1691337Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#675809}
-
Yuly Novikov authored
In preparation for upgrade to Ubuntu 19.04, where these tests are flaky. Only 'Linux FYI Release (AMD R7 240)' remains. Bug: 927465, 966500, 978103 Change-Id: I270743a1cdd3f9a11f843fd2e30d58608e4de503 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1691324Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#675808}
-
Brian Sheedy authored
Switches most of the GPU pixel test expectations from "Failure" to "Skip". This is so that tests that are failing 100% of the time don't hog the number of triage links we can report in Milo. Bug: 968276 Change-Id: Ied61a7bfdd6273d1674c47d0e6fbc960205f5c88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1691141Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#675807}
-
Gil Dekel authored
This CL adds the function CreateContextAndScopedVASurface() to the VaapiWrapper, which attempts to create a context and surface and return a std::unique_ptr<ScopedVASurface> to the client. This CL is needed for the following change: https://crrev.com/c/1672404 Bug: 868400, 980379 Test: jpeg_decode_accelerator_unittest Change-Id: Ic98ec612aed7ae221698e42f5b77378bbb0fc26d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1693361 Commit-Queue: Gil Dekel <gildekel@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Reviewed-by:
Andres Calderon Jaramillo <andrescj@chromium.org> Cr-Commit-Position: refs/heads/master@{#675806}
-
Alex Moshchuk authored
This histogram is about to expire, and since its usage has been low, remove the logic to record it and mark the corresponding histograms.xml entry as deprecated. Bug: 975349 Change-Id: I6560b4b3e602a037547a28d4e38a4e02931c5fb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1690748Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Auto-Submit: Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#675805}
-
Abhishek Bhardwaj authored
This change performs an update check when the update checker timer expires. BUG=924762 TEST=Unit tests. Change-Id: Idc4dcfb3a0d9eff6f0a24b6a8f9f2fa4080710cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663590 Commit-Queue: Abhishek Bhardwaj <abhishekbh@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#675804}
-
Michael Ludwig authored
Change-Id: I7495436489b6af83ad01f42fd35aa2cb40bebd06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1693283 Commit-Queue: Michael Ludwig <michaelludwig@google.com> Commit-Queue: weiliangc <weiliangc@chromium.org> Auto-Submit: Michael Ludwig <michaelludwig@google.com> Reviewed-by:
weiliangc <weiliangc@chromium.org> Cr-Commit-Position: refs/heads/master@{#675803}
-
Kristi Park authored
Convert mouse events to drag events. This allows us to use DataTransfer to set the URL data necessary for dragging and dropping links. Screencast: https://drive.google.com/open?id=131GJk4um_TGzgXxQ3KeQcDfJ87jh-W19 Bug: 961569 Change-Id: I8460a5e101f167efa15f34ca810244c9edd46900 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1686789 Commit-Queue: Kristi Park <kristipark@chromium.org> Reviewed-by:
Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#675802}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/071d26b8c191..123c46068daa git log 071d26b8c191..123c46068daa --date=short --no-merges --format='%ad %ae %s' 2019-07-09 perezju@chromium.org [Telemetry] Move remaining telemetry_info attributes to story_run Created with: gclient setdep -r src/third_party/catapult@123c46068daa The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:973837 TBR=sadrul@google.com Change-Id: I30096aa3a6928998128fada02a55f0316506c84c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692489Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#675801}
-
Sonny Rao authored
Update owners as those listed have all left the project, and bump the expiration by a year on those that were marked as expiring for M77. Bug: chromium:975316 Change-Id: I374bac4738524477ce4cac878c58db179be8599d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1685688 Auto-Submit: Sonny Rao <sonnyrao@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Sonny Rao <sonnyrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#675800}
-
Gayane Petrosyan authored
Previously, the 'Customize' button was hidden for windows that are shorter than the new customization dialog. Seems like this is too aggressive. Only hide 'Customize' button to now overlap with OGB. Bug: 981847, 972976, 972962, 972480, 959097 Change-Id: Ia335400c2ac8f77d8ffb645ebb82fee2e3f61c8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692876Reviewed-by:
Kristi Park <kristipark@chromium.org> Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Cr-Commit-Position: refs/heads/master@{#675799}
-
Mustafa Emre Acer authored
crrev.com/c/1140307 introduced protection against double clicks: It disallowed clicks when they happen shortly after a view is shown. This prevents unintentional double clicks but doesn't protect users when they are tricked into repeatedly clicking at the same location. In this scenario, double click protection is only good for the double click interval on that platform (e.g. 500 ms on Windows). After that, subsequential clicks are still accepted. This CL adds an additional check to prevent repetitive clicks happening with short intervals. As an example, if a dialog is shown at t0 (assuming a 500 ms double click interval): - A click at t0 + 200 ms is ignored by the double click protection - A subsequent click at t0 + 600 ms is ignored by this protection - Another click at t0 + 1150 ms is accepted Change-Id: I501c00aeda46bcbd434323f21c4b8433d04d2038 Bug: 63773 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1686858 Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#675798}
-
Katie Dillon authored
The trace event spanning multiple tasks is no longer used and can be removed. This cl also changes the name of the task trace event in ThreadControllerWithMessagePumpImpl to match the task trace event in ThreadControllerImpl. Bug: 980697 Change-Id: I1c3dbc31e64cb7cbd5d87e1c6336775230d4a80a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1688338 Commit-Queue: Katie Dillon <kdillon@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Cr-Commit-Position: refs/heads/master@{#675797}
-
Dana Fried authored
Missed adding code in interpolating layout to do correct linear interpolation. Also realized that we needed to tweak the API for LayoutManagerBase just a bit in order to support a correct implementation of both InterpolatingLayoutManager and AnimatingLayoutManager. See https://chromium-review.googlesource.com/c/chromium/src/+/1653898 for the original set of changes that added LayoutManagerBase as well as additional context. Bug: 898632 Change-Id: If5c1460c01d1c04e9df310c8022d75e021ac27a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1687369 Commit-Queue: Dana Fried <dfried@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#675796}
-
Mohamed Amir Yosef authored
The following histograms were scheduled to expire in M77, however, they are still useful and hence extending their life time till M82. Sync.BookmarksDuplicationsAtAssociation Sync.BookmarksModelSyncStateAtNewDuplication Sync.CommitLatency Bug: 969933,975491 Change-Id: If35bfd0a39c5d91a8bd7edfbb900373ce9827c16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692166 Auto-Submit: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#675795}
-
Robert Ogden authored
Step 1 of 3 for caching prober results. This CL adds caching by network id (more or less just the connection type), and the URL host:port being probed. Future CLs on this thread: * Step 2 - async revalidate cache entries after some expiry * Step 3 - persist to disk with PrefService Bug: 977603 Change-Id: If84f74e4cdf29eba16f864c34e08170d65ee2d20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1691548 Commit-Queue: Robert Ogden <robertogden@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#675794}
-
Ahmed Fakhry authored
This is a useful histogram, so postpone its expiry until after M79. BUG=975200 Change-Id: Id6b8c2b5d76d1c65cc8dac1291ab0eaaa74e1494 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1691867Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#675793}
-
Geoff Lang authored
Chrome uses this function on recent versions of Android. BUG=979342 Change-Id: Ia2fe4bca8f77896ee57d6033441109cf34b41e36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1686784 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#675792}
-
Mustaq Ahmed authored
The feature was enabled in M72 through content_feature kUserActivationV2, see crrev.com/c/796938. This means the RuntimeEnabledFeature gets enabled through content in general but this is not true for few unit tests. This CL fixes the problem with RuntimeEnabledFeature and fixes the affected unit tests. Bug: 696617 Change-Id: I50c3b22a5dfc6eb145ac00892bb3120b7c02e9ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1689038Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Mustaq Ahmed <mustaq@chromium.org> Cr-Commit-Position: refs/heads/master@{#675791}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/d406d536..13c48a77 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I79b61ceb6fee94dd6034e934d140e85240cf2bf3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1693062Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#675790}
-
Michael Thiessen authored
Bug: 982364 Change-Id: I002b7dfb13e7e1ad2d98bd935992851ec6769acc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692040Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#675789}
-
John Chen authored
In W3C mode, when execution of a command results in an unknown status, ChromeDriver was crashing due to an uninitialized variable. Now fixed. Bug: chromedriver:3007 Change-Id: I662dfdf9d4d6b5de3396f90258e1df3d1cfebae5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1693168 Commit-Queue: John Chen <johnchen@chromium.org> Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Auto-Submit: John Chen <johnchen@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#675788}
-
Yoav Weiss authored
The related bug was long closed, but one lonely CH related test lingered in TestExpectations. This CL makes sure it lingers no more. Bug: 972569 Change-Id: Ibfb9dcadd1b53973872fdb73cb5603542dec40cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692175Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Yoav Weiss <yoavweiss@chromium.org> Cr-Commit-Position: refs/heads/master@{#675787}
-
Charlie Harrison authored
We're still looking at data from this histogram Change-Id: Ia1353e2ae5677a2b39ca355593cdc3780d021428 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1690567Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#675786}
-
Jian Li authored
Bug: 878105,878103,878098,878096,878094,878092,878086 Change-Id: I2de8a7417a082c4bf3f80d4ec53538b853cb2726 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1682276 Commit-Queue: Jian Li <jianli@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#675785}
-
Austin Eng authored
This patch also updates Blink to match Dawn API changes. https://dawn.googlesource.com/dawn.git/+log/8f93871dfff5..f697fe3b7dd2 git log 8f93871dfff5..f697fe3b7dd2 --date=short --no-merges --format='%ad %ae %s' 2019-07-09 shaobo.yan@intel.com Add dynamic attribute in bind group layout binding Created with: gclient setdep -r src/third_party/dawn@f697fe3b7dd2 CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel TBR=cwallez@chromium.org Change-Id: I61db2ec057ef067961013aebb690daa50b6d975c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1693206Reviewed-by:
Austin Eng <enga@chromium.org> Commit-Queue: Austin Eng <enga@chromium.org> Cr-Commit-Position: refs/heads/master@{#675784}
-
Angel Alvarez authored
This involves the following changes: 1) Adding new dimensions in the XML to meet the spec for the explore sites page. 2) Adding new tile views using new dimensions. 3) setting the tile view to use in CategoryCardViewHolderFactory. 4) Adjustments to the code for RoundedIconGenerator and RoundedBitmapDrawable so that the icon size and radius are programmatically adjusted. 5) Removal of an extra resize in ExploreSitesTileView which cause icons to scale too many times creating resizing artifacts for both dense and regular views. The RoundedBitmapDrawable already handles density based resizing. These changes form the bulk of the explore sites densification view changes. What is left will be tweaks to padding on the category cards and changes in tile quantity rendering logic. Moved new dense feature params to a custom CondensedVariation, to be wrapped under the condensed feature param in ExploreSitesVariation. Added new supporting enums and utilities to allow access to condensed variation from ExploreSitesBridge. Bug: 977713 Change-Id: I795372339ea6350da6767aa613c55aeb2383bbaa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1681955Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Cathy Li <chili@chromium.org> Commit-Queue: Angel Alvarez <angelii@google.com> Cr-Commit-Position: refs/heads/master@{#675783}
-
Caitlin Fischer authored
Bug: 980547 Change-Id: I779b3324041f68e257f8e8f1a8cd75a943066919 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1684564Reviewed-by:
Tommy Martino <tmartino@chromium.org> Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Cr-Commit-Position: refs/heads/master@{#675782}
-
Jimmy Gong authored
- This CL contains three new components: - CupsPrintersEntry: encapsulates a printer list entry. - CupsPrintersEntryList: iron list container for CupsPrinterEntry's - CupsSavedPrinters: component that holds a CupsPrinterEntryList and contains only SavedPrinters. - First step in redesigning the printer lists in settings. - Next step is to implement NearbyPrinters component. - Adds BrowserTests to test the three new components. - Hides CupsSavedPrinters behind a feature flag. - Pulls out TestCupsPrintersBrowserProxy its own separate test utils file. - This puts CupsSavedPrinters at feature parity with CupsPrinterList's implementation of SavedPrinters. Bug:965721 Test: end to end manual, browserTests Change-Id: Iac2c7985e484732a04afc2f4e9d557db3fe5f2d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1639068 Commit-Queue: jimmy gong <jimmyxgong@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#675781}
-
Jeremy Roman authored
Bug: 980937 Change-Id: I7c29a1820e1ce2df735284c430883a3250d7d044 Tbr: dcheng@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692488Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#675780}
-
chrome://settingsMay Lippert authored
Some parts of the printing code refer to chrome://settings directly while using SettingsWindowManager to open the URL. This results in the browser settings opening in the OS settings surface when the split settings flag is on. Also fix an issue where the main page behavior is not opening the advanced section correctly when opening OS settings to an advanced route. BUG=980264 Change-Id: Ib69e17790b880ef068c059d4e6133c2e05e0448b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1686543Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: May Lippert <maybelle@chromium.org> Cr-Commit-Position: refs/heads/master@{#675779}
-