- 04 Nov, 2020 40 commits
-
-
Alex Turner authored
This will aid in constructing a catalog of known font digests for the identifiability study. Change-Id: Ic0d4b603513aed6c5f1fec7d3606a371119e2707 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399446Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Reviewed-by:
Asanka Herath <asanka@chromium.org> Commit-Queue: Alex Turner <alexmt@chromium.org> Cr-Commit-Position: refs/heads/master@{#824015}
-
Sigurdur Asgeirsson authored
This class is for observers that observe only one source. This is more readable and slightly more efficient than using base::ScopedObserver, where an observer has zero or one subscriptions. Change-Id: Iefd987ce006aa2106249cf2708f63d90326814ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518028Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Patrick Monette <pmonette@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#824014}
-
Chrome Metrics Logs authored
Updates the expires_after attribute for 194 histograms that show frequent access in the past 90 days. These are the 95% most frequently used histograms over that time that do not already have a date later than or within 60 days of 2021-02-01. TBR=chromium-metrics-reviews@google.com Change-Id: I41163acda25dc95371561ed787c1e61b21e2cef5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518692Reviewed-by:
Chrome Metrics Logs <chrome-metrics-team+robot@google.com> Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Cr-Commit-Position: refs/heads/master@{#824013}
-
Renato Silva authored
Change-Id: Idb6cb5718a907d08fb08597ce4666ec9bc4e04b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517481 Auto-Submit: Renato Silva <rrsilva@google.com> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#824012}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/5399fa01a3e1..62e571e6bb4c 2020-11-04 alexrudenko@chromium.org Add align-self icons to the Styles panel 2020-11-04 jacktfranklin@chromium.org Fix bad falsey check for numeric values in emulation mode 2020-11-04 aerotwist@chromium.org TypeScriptify TimelineOverviewPane.js 2020-11-04 szuend@chromium.org TypeScrip-ify profiler/CPUProfileView.js 2020-11-04 jacktfranklin@chromium.org Add dark mode patch option to `createShadowRootWithCoreStyles` 2020-11-04 szuend@chromium.org TypeScriptify profiler/IsolateSelector.js 2020-11-04 aerotwist@chromium.org TypeScriptify FilmStripView.js 2020-11-04 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2020-11-04 szuend@chromium.org TypeScript-ify profiler/ProfileHeader.js 2020-11-04 tvanderlippe@chromium.org Typecheck timeline/TimelineTreeView.js with TypeScript 2020-11-04 jobay@google.com Remove redundant aria labels and update tests 2020-11-04 janscheffler@chromium.org [Network] Fix incorrectly unescaped ampersand on windows If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1122511,chromium:1139945 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I41aa6d24ef0bc0ffb452f17399a123cf6dac76b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519653Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#824011}
-
arthursonzogni authored
The value is not sent to blink yet. As a result, the same origin computed from blink and the browser process might differ by their |nonce_|. Bug: 888079 Change-Id: I1c884a2e72e4d79fb9663d152cb011cc219f320f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2502477Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#824010}
-
Lily Chen authored
This adds a histogram to log, for SameParty cookies, whether the attribute was applied correctly (i.e. whether the cookie both had Secure and did not have SameSite=Strict). Bug: 1142606 Change-Id: I512f0dd83896d917022ece0da2e85ac6f0d7392c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510195Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Reviewed-by:
Weilun Shi <sweilun@chromium.org> Commit-Queue: Lily Chen <chlily@chromium.org> Cr-Commit-Position: refs/heads/master@{#824009}
-
Roman Aleksandrov authored
Fixed: 1127303 Change-Id: I933f39e41be145aa85af41a632acf387c2be690f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414174 Commit-Queue: Roman Aleksandrov <raleksandrov@google.com> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#824008}
-
Dominique Fauteux-Chapleau authored
This CL refactors tests in ContentAnalysisDelegate to use Connector policies directly instead of the indirect helpers that map to legacy policies. Bug: 1109242 Change-Id: I3521f023b0e6497e6d570e8bfa83551a00d9d920 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510192 Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Cr-Commit-Position: refs/heads/master@{#824007}
-
Marc Treib authored
This reverts commit 9e3dabc4. Reason for reland: This CL was not actually the cause of the test failures (https://crrev.com/c/2519333 fixed them). Original change's description: > Revert "[AF] Add account indication footer to AutofillSaveCardInfoBar" > > This reverts commit ba7d8814. > > Reason for revert: SaveCardBubbleViewsFullFormBrowserTestWithAutofillUpstream.Upload_ClickingNoThanksClosesBubble and a bunch of other tests started failing in https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests/21164 > > > Original change's description: > > [AF] Add account indication footer to AutofillSaveCardInfoBar > > > > The footer is shown only to signed-in users have more than one account, and who do not sync. > > > > Screenshot with feature enabled in light mode: > > https://screenshot.googleplex.com/ApVmkMVQakM6ai9 > > > > Screenshot with feature enabled in dark mode: > > https://screenshot.googleplex.com/BJB2jUuGoH3T5jM > > > > Bug: 1135847 > > Change-Id: Ia2e031a48920e44e66503fab62f26ed87b8e1d92 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2496184 > > Commit-Queue: Anne Lim <annelim@google.com> > > Reviewed-by: Marc Treib <treib@chromium.org> > > Reviewed-by: Matthew Jones <mdjones@chromium.org> > > Reviewed-by: Jared Saul <jsaul@google.com> > > Cr-Commit-Position: refs/heads/master@{#823710} > > TBR=treib@chromium.org,mdjones@chromium.org,jsaul@google.com,bsazonov@chromium.org,annelim@google.com > > Change-Id: I5f235bc5843acf4ea504a78762907a019576e656 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1135847 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518852 > Reviewed-by: Christian Dullweber <dullweber@chromium.org> > Commit-Queue: Christian Dullweber <dullweber@chromium.org> > Cr-Commit-Position: refs/heads/master@{#823942} TBR=treib@chromium.org,mdjones@chromium.org,jsaul@google.com,dullweber@chromium.org,bsazonov@chromium.org,annelim@google.com # Not skipping CQ checks because this is a reland. Bug: 1135847 Change-Id: I7d1a7ad2bc6b5c30d2b859c9f68bfee34992ff95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517530Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#824006}
-
David Schinazi authored
This will allow us to start experimenting in Beta. R=asvitkine@chromium.org Change-Id: I7a93235c712b1f24015058c02417899c5cc5914d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517224 Auto-Submit: David Schinazi <dschinazi@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#824005}
-
Mikel Astiz authored
The newly-introduced metrics explore different predicates to determine whether a bookmark is a duplicate. These variants are more strict and involve not only URL equality, but also title equality and (in a separate metric) parent equality. Change-Id: I8ac7ce46b235e31ec855d55fcc5bf0cad8ef9fff Bug: 1068378 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514155Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#824004}
-
Mugdha Lakhani authored
Bug: 1104925 Change-Id: Ic128c5577ce8a9c079bab701630a1680cbb3380c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517723 Auto-Submit: Mugdha Lakhani <nator@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#824003}
-
Andrew Grieve authored
This reverts commit 8e2b3210. Reason for revert: Breaks angle_unittests on emulator Original change's description: > Reland #2: Android: Use locally-build devil deps only when build_with_chromium=true > > This reverts commit 85773e52. > > Reason for reland: > * Fixed data deps > * _BuildWithChromium() handles missing key > > Original change's description: > > Revert "Reland "Android: Use locally-build devil deps only when build_with_chromium=true"" > > > > This reverts commit f8b7ec28. > > > > Reason for revert: Causing all builds to fail on android-pixel2-perf failing > > > > Original change's description: > > > Reland "Android: Use locally-build devil deps only when build_with_chromium=true" > > > > > > This reverts commit b47e9c83. > > > > > > Reason for reland: Updated more .pydeps files. > > > > > > Original change's description: > > > > Revert "Android: Use locally-build devil deps only when build_with_chromium=true" > > > > > > > > This reverts commit 49fdeca1. > > > > > > > > Reason for revert: Breaking presubmit due to stale .pydeps file: > > > > android_webview/tools/run_cts.pydeps > > > > > > > > Original change's description: > > > > > Android: Use locally-build devil deps only when build_with_chromium=true > > > > > > > > > > Bug: 1120190 > > > > > Change-Id: I763e42a7ae69d14eb61caebd220844b756d6d171 > > > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2480842 > > > > > Commit-Queue: Andrew Grieve <agrieve@chromium.org> > > > > > Reviewed-by: Ben Pastene <bpastene@chromium.org> > > > > > Cr-Commit-Position: refs/heads/master@{#819489} > > > > > > > > TBR=agrieve@chromium.org,bpastene@chromium.org > > > > > > > > Change-Id: I960ad355283c66951e5931f61e25421c5a5dfdf7 > > > > No-Presubmit: true > > > > No-Tree-Checks: true > > > > No-Try: true > > > > Bug: 1120190 > > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490857 > > > > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > > > > Commit-Queue: Andrew Grieve <agrieve@chromium.org> > > > > Cr-Commit-Position: refs/heads/master@{#819668} > > > > > > TBR=agrieve # reland > > > > > > Bug: 1120190 > > > Change-Id: I8f3e21182e83a3e88da52331d56a8bef76507939 > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490558 > > > Commit-Queue: Andrew Grieve <agrieve@chromium.org> > > > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#819810} > > > > TBR=agrieve@chromium.org,bpastene@chromium.org > > > > # Not skipping CQ checks because original CL landed > 1 day ago. > > > > Bug: 1120190, 1141891 > > Change-Id: I490f2e8a972b260a81b942e248c0f920af11db46 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495335 > > Reviewed-by: John Chen <johnchen@chromium.org> > > Commit-Queue: John Chen <johnchen@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#820355} > > Bug: 1120190 > Bug: 1141891 > Change-Id: Ic7a398fcd8cb5f45a03c20acbd4e9c7300442f38 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2497153 > Reviewed-by: Ben Pastene <bpastene@chromium.org> > Commit-Queue: Andrew Grieve <agrieve@chromium.org> > Cr-Commit-Position: refs/heads/master@{#823651} TBR=agrieve@chromium.org,bpastene@chromium.org Change-Id: Ia586b0d8f68795e493074ba6b00ac36c529eb1ed No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1120190 Bug: 1145570 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519425Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#824002}
-
Peter E Conn authored
This CL takes the Mojo changes from: https://chromium-review.googlesource.com/c/chromium/src/+/2484038 and adds an Android implementation for them. Once these mojo changes are wired up on the Blink side, I'll add some tests to DigitalGoodsTests. Bug: 1139795 Change-Id: Ib8c92cbc619b8977f37d3a9b59a3045d5c1bbb7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510271 Commit-Queue: Peter Conn <peconn@chromium.org> Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Glen Robertson <glenrob@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#824001}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/b049cadeb140..0bd50c9043c7 2020-11-04 wl@gnu.org Typo. 2020-11-04 wl@gnu.org docs/CHANGES: Updated. 2020-11-03 heftig Fix documentation build. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/freetype-chromium Please CC drott@google.com,thestig@google.com,bungeman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux-blink-rel;luci.chromium.try:mac10.12-blink-rel;luci.chromium.try:win10-blink-rel;luci.chromium.try:win7-blink-rel Tbr: drott@google.com,thestig@google.com,bungeman@google.com Change-Id: Ibc858fb318df6e41726fef1abe2091a2de3faef5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519411Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
Ben Wagner <bungeman@chromium.org> Commit-Queue: Ben Wagner <bungeman@chromium.org> Cr-Commit-Position: refs/heads/master@{#824000}
-
Filip Gorski authored
Change-Id: I65a0590b3d745b0a209ae8c7a7fc634e50ac4f54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518728Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#823999}
-
K. Moon authored
The experiment to disable PDF partial loading was successful, so we're making it the default now. The PdfPartialLoading and PdfIncrementalLoading features will be kept for now for tests that rely on these features (often to test mostly unrelated behaviors). Fixed: 1115149 Change-Id: Iea45106f919d1fa608fcf6cfc28e432c88d4d75b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505972 Commit-Queue: Jesse Doherty <jwd@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Daniel Hosseinian <dhoss@chromium.org> Auto-Submit: K. Moon <kmoon@chromium.org> Cr-Commit-Position: refs/heads/master@{#823998}
-
Rayan Kanso authored
Also disable it for WebLayer since it doesn't work in that context. Bug: 1051508 Change-Id: I5368d2c803547cccb54e0e981a77b688ec528a84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2516702 Commit-Queue: Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Mugdha Lakhani <nator@chromium.org> Cr-Commit-Position: refs/heads/master@{#823997}
-
Andrew Grieve authored
This reverts commit 16ccdc07. Reason for reland: CL did improve some metrics. Original change's description: > Revert "Android: Remove -fprofile-sample-accurate from blink core" > > This reverts commit c2bb3798. > > Reason for revert: Reverting to see what perf alerts fire. > > Original change's description: > > Android: Remove -fprofile-sample-accurate from blink core > > > > This trades off some size for performance. > > > > Binary-Size: Trading size for speed > > Bug: 1125115 > > Change-Id: If18e8ef4449dec6aab4494fa7d04063d8d94b845 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491540 > > Reviewed-by: George Burgess <gbiv@chromium.org> > > Commit-Queue: Andrew Grieve <agrieve@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#819964} > > Bug: 1125115 > Change-Id: Iebce1fffa79b590fd015d0054f9fe2da9e3bb3a3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2498088 > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Reviewed-by: George Burgess <gbiv@chromium.org> > Commit-Queue: Andrew Grieve <agrieve@chromium.org> > Cr-Commit-Position: refs/heads/master@{#822847} Bug: 1125115 Change-Id: I62345561bb892ba49da433f692caf317b96a1837 Binary-Size: Trading size for perf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514376 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
George Burgess <gbiv@chromium.org> Cr-Commit-Position: refs/heads/master@{#823996}
-
Sigurd Schneider authored
Flags removed: --harmony-import-meta https://crrev.com/c/2509943 --harmony-dynamic-import https://crrev.com/c/2509942 Bug: v8:6693, v8:5785 Change-Id: I0628db7d48f4991c185fd6f8e9f49d5f7eb91094 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517685Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#823995}
-
zhiyuancai authored
Bug: 997250 Change-Id: I929aed84f8a7bee7371506a731dd453d10597662 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490032 Commit-Queue: Zhiyuan Cai <zhiyuancai@google.com> Reviewed-by:
Yue Zhang <yuezhanggg@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#823994}
-
Mirko Bonadei authored
Change Log: https://chromium.googlesource.com/external/github.com/abseil/abseil-cpp/+log/962b067540..e9e9b9fc74 Full diff: https://chromium.googlesource.com/external/github.com/abseil/abseil-cpp/+/962b067540..e9e9b9fc74 No .def file changes. Bug: None Change-Id: Idc3bf05ba596c683c9088d5e9fd9e6ad739b9bd7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517945Reviewed-by:
Danil Chapovalov <danilchap@chromium.org> Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Cr-Commit-Position: refs/heads/master@{#823993}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/97469f4abe0a..a8f4c91114b5 2020-11-04 kjlubick@google.com [canvaskit] Expose MakeRasterDirectSurface If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bsalomon@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: bsalomon@google.com Change-Id: I2e0d87ea46e2966327128d205f4574fb663e6a03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519169Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#823992}
-
Illia Klimov authored
This CL fixes an issue caused by the initializetion of ScopedFeatureList in a multithread environment. Bug: 1143265, 1143584, 1143505, 1143035 Change-Id: I711cebe4a1743a01095359d93e991601603b2d0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518055 Commit-Queue: Illia Klimov <elklm@google.com> Auto-Submit: Illia Klimov <elklm@google.com> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#823991}
-
Michael Thiessen authored
Updates imports in chrome/android/javatests/ to use the base/ CriteriaHelper Bug: 1134178 Change-Id: I9e789401078f5b9245b14e821cf1990b1e33acc7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518893 Auto-Submit: Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#823990}
-
David Tseng authored
This reverts commit 176b96aa. Reason for revert: <INSERT REASONING HERE> Tts .so works with this in a non-default config; error in config during testing. Follow up with the right perms for default build. Original change's description: > Give tts service sysinfo syscall perms > > As of > https://chromium-review.googlesource.com/c/chromium/src/+/2510736 > > the tts service, which runs a prebuilt containing tensorFlow, now asks for > sysinfo. > > R=mpdenton@chromium.org > > Test: patch the above change and makes sure the tts works. > Change-Id: If578d0bb6617390a5919ac33b4b04970a33da317 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514759 > Reviewed-by: Matthew Denton <mpdenton@chromium.org> > Commit-Queue: David Tseng <dtseng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#823347} TBR=dtseng@chromium.org,mpdenton@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: I17009ffe0468e096c522fe18700c19735b5572d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519713Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#823989}
-
kylechar authored
This reverts commit afc72427. Reason for revert: Speculative revert for Windows GPU process failing to start in debug. See https://crbug.com/1145558. Original change's description: > Reland "Only pass executable sections to OnDllLoaded for patching" > > This is a reland of df9e203b > > Original change's description: > > Only pass executable sections to OnDllLoaded for patching > > > > On recent Windows insider builds GetModuleHandleExW loads sections for > > inspection as non-executable images, rather than as files. This leads > > to our hooks detecting the SEC_IMAGE attribute and potentially patching > > functions (e.g. for user32.dll). > > > > This caused content_browsertests to fail as it pinned user32.dll in some > > processes. With this change, the tests run again. > > > > See crbug.com/1143397 for a full discussion. > > > > Bug: 1143397 > > Change-Id: I3b75464d0442160a417e4cb7084306841aaf76f7 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2511531 > > Reviewed-by: Will Harris <wfh@chromium.org> > > Commit-Queue: Alex Gough <ajgo@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#823354} > > Bug: 1143397 > Change-Id: Ibacc1ba6105665c32ea445a7f63178163585efbc > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515783 > Auto-Submit: Alex Gough <ajgo@chromium.org> > Commit-Queue: Alex Gough <ajgo@chromium.org> > Commit-Queue: Will Harris <wfh@chromium.org> > Reviewed-by: Will Harris <wfh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#823679} TBR=wfh@chromium.org,ajgo@chromium.org Change-Id: I8d37d7dae54327ea84d9d2d327bb183a18c5337a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1143397, 1145558 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518917Reviewed-by:
kylechar <kylechar@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#823988}
-
Nick Diego Yamane authored
Context: Wayland Protocol needed to be extended to make it possible to properly support full Chromium's tab dragging experience. Further details in the Design document [1]. This patch contains the first round of Wayland Ozone backend (client side) changes needed to leverage the extended-drag protocol extension to implement the remaining tab/window dragging missing features, whereas the main one is the ability to set a toplevel shell surface (browser window) as the "dragged surface", making it to be anchored to the pointer cursor as it's dragged around, as well as being smoothly droppable anywhere in the workspace, which is not possible with the standard Wayland DND protocol. [1] https://docs.google.com/document/d/1s6OwTi_WC-pS21WLGQYI39yw2m42ZlVolUXBclljXB4/edit?usp=sharing R=msisov@chromium.org Bug: 896640, 1099418 Change-Id: I8a19670fd4ad64d49a9aa202548c22065870dd90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401319 Commit-Queue: Nick Yamane <nickdiego@igalia.com> Reviewed-by:
Maksim Sisov (GMT+2) <msisov@igalia.com> Reviewed-by:
Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#823987}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1604468747-3cefb59c2b4481c91d9a2d5b4d4a31bc448420c5.profdata to chrome-linux-master-1604491008-3c33d4506f1877c8f5c193fdb795c1a4d1ae6438.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Iae7902b0f8b79fcd28b77986ec391e44dadfc8a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519165Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#823986}
-
Sorin Jianu authored
There could be executions path in the code where early returns in the callback implementations return an empty vector instead of a vector of CrxComponent of the same size as the input parameter of the callback. When this occurs, the original code indexes out of bounds and crashes. With the fix, if the callback returns fewer values than the number of components checked for updates, the UpdateClient::Update call is rejected by the update engine, and completed with a specific error code. Bug: 1144880 Change-Id: If45910c7c9ea0ca940b2d5a3d936b96a31d9c684 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518001Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#823985}
-
arthursonzogni authored
This is intended to be merged into M87 Beta M87. This is actually the #3 crasher on 87.0.4280.38 I have no clue what the problem is here. This patch removes the consequences of the bug, not the cause. This is caused by receiving RFH::OnAssociatedInterfaceRequest() after the process has called ResetIPC and the RenderFrameHost has called InvalidateMojoConnection(). This patch just ignore the call when this happens, because it doesn't expect receiving any call from the renderer anymore. Bug: 1123438 Change-Id: I1ada1d3a27f53198afc84ec56f00e0a278fdbd90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517586Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#823984}
-
Titouan Rigoudy authored
This removes our reliance on RenderFrameHostImpl::last_successful_url(), which is discouraged, and more directly checks that an error page is committed or not. Fixed: chromium:1137741 Change-Id: I59f51bdc2802011e82f573fb49c8ace6bb0de402 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517559 Commit-Queue: Titouan Rigoudy <titouan@chromium.org> Auto-Submit: Titouan Rigoudy <titouan@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#823983}
-
Stephane Zermatten authored
This change extends the on_top filter to allow controlling: - whether it should call scrollIntoViewIfNeeded - whether it should accept element that it cannot check, because they are outside of the viewport Bug: b/171464034 Change-Id: Ifa7de037325a10ca4c5ed5fe45d962f5289e8c76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2513646 Commit-Queue: Stephane Zermatten <szermatt@chromium.org> Reviewed-by:
Sandro Maggi <sandromaggi@google.com> Cr-Commit-Position: refs/heads/master@{#823982}
-
Frédéric Wang authored
This CL removes the title argument from registerProtocolHandler() as agreed in the WHATWG [1]. See also the discussion on the blink-dev mailing list [2]. The only other browser implementation was in Firefox but it has been removed [3]. [1] https://github.com/whatwg/html/pull/5425 [2] https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/cZh5f1Ymj14/rLz2Xsy0BAAJ [3] https://groups.google.com/d/msg/mozilla.dev.platform/T633aemFPJU/dbv5_iB8AgAJ Bug: 1072461 Change-Id: Ia9f60203939fc756950d511c923a3e9dd2256100 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2157531 Commit-Queue: Frédéric Wang <fwang@igalia.com> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#823981}
-
Corentin Wallez authored
In python3 map() return an iterable but doesn't actually do the map yet, so the exception for the file being on another drive was produced in code later and not caught. Force the expansion of the iterable using list(map(...)). Bug: 941669 Change-Id: I4f56f25a42cab102f4cd2f988907a60ec7e816af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517583Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#823980}
-
Rune Lillesveen authored
Change-Id: I182f05b751b12cd30ff44f6cb09b6c13cb128510 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519450 Auto-Submit: Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#823979}
-
Kevin Ellis authored
Addresses regression introduced in: https://chromium-review.googlesource.com/c/chromium/src/+/2369433 ComputedStyleUtils::ComputedPropertyValue can return a null value if the value cannot be parsed, which leads to a potential null pointer dereference. Bug: 1126364 Change-Id: I31a74283a4cbfe9c6875fb9c832d6085ab21ae39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517044Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Kevin Ellis <kevers@chromium.org> Cr-Commit-Position: refs/heads/master@{#823978}
-
Francois Doray authored
On startup, ::NtQuerySystemInformation() is invoked to get the number of hard faults and determine if the startup is "warm" or "cold". The function can fail if the provided buffer is too small. In that case, we resize the buffer to the size requested by the function and we retry. In some cases, the size returned by the function is very large (> 1 MB). It is undesirable to invoke a function to fill a large buffer just to record startup histograms. This CL does not get the hard fault count if it requires a buffer with a size >= 512 KB. The failure to get the hard fault count is reported in the "undetermined" bucket of the Startup.Temperature histogram. Histograms suffixed with the startup temperature are obviously not recorded. Bug: 1085716 Change-Id: I0864a2af26e07cddcab4e094d344473ccbb5b9a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302829Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#823977}
-
Christian Dullweber authored
This reverts commit 7b6fabaa. Reason for revert: Lots of crostini tests are failing since https://ci.chromium.org/p/chrome/builders/ci/chromeos-eve-chrome/11029 Original change's description: > Reland "Reland "Crostini settings string changes."" > > This is a reland of 6b11534a > > OK, this time for sure. The tast-test change below was submitted, but the > relevant ChromeOS uprev was blocked for days. This is now through so we > can reland again, for real this time. > > Original change's description: > > Reland "Crostini settings string changes." > > > > This is a reland of da531d49 > > > > Now that https://chromium-review.googlesource.com/c/chromiumos/platform/tast-tests/+/2505407 > > is landed, this should be safe. > > > > Original change's description: > > > Crostini settings string changes. > > > > > > Instead of "Linux (Beta)", now shows as "Developers" > > > > > > Bug: 1140370 > > > Change-Id: Id4e076b5d918e41e22e5c59d65958da9e75a3f55 > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486528 > > > Commit-Queue: Nicholas Verne <nverne@chromium.org> > > > Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> > > > Reviewed-by: David Munro <davidmunro@google.com> > > > Auto-Submit: Nicholas Verne <nverne@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#820205} > > > > Bug: 1140370 > > Change-Id: Ibb5bd28f9647847dddaf109e9da86d91b17dd863 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505324 > > Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> > > Reviewed-by: David Munro <davidmunro@google.com> > > Commit-Queue: Nicholas Verne <nverne@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#822525} > > Bug: 1140370 > Change-Id: I76e0dfa45877db5d633a70126c0f5bd2a70a15f9 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515799 > Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> > Commit-Queue: Nicholas Verne <nverne@chromium.org> > Cr-Commit-Position: refs/heads/master@{#823503} TBR=khorimoto@chromium.org,nverne@chromium.org,davidmunro@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1140370 Change-Id: Icc3b386e702e544e153d1e8893e5781a281d29c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519452Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#823976}
-