- 01 Oct, 2020 40 commits
-
-
Alex Rudenko authored
This CL proposes refactoring Init/DoInit methods by moving the overlay and frontend parameters to the constructor to avoid confusion about at what time they are set on a tool. Also, it removes DoInit/Init methods and moves the ScreenshotTool's init to the constructor as well. Change-Id: I246c1383c66f6977c0b69fd82938a6c7baa192e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2428926Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Alex Rudenko <alexrudenko@chromium.org> Cr-Commit-Position: refs/heads/master@{#812677}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1601531335-6ddc6aeaa45d1043385555e19eae524fbb6fe60e.profdata to chrome-mac-master-1601553580-dedfc7e09ce8d42299369759d9da080930ec4031.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC sebmarchand@chromium.org,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: sebmarchand@chromium.org,jeffyoon@google.com,liaoyuke@google.com Change-Id: I1c23a70af0d44682123b0a5ecec10da83a4c58a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442717Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#812676}
-
Mohsen Izadi authored
When two WebCoalescedInputEvent's are coalesced, the latency info of the old event is assigned to the newer event. However, in all cases, the newer event thrown away after coalescing. So, there is no point in setting its latency info and we can simplify the code by removing this assignment and making the newer event a const reference. Bug: 1079116 Change-Id: Ia340920b74cf8dcf2d3de319b9a8a255f31fb076 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437481Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Mohsen Izadi <mohsen@chromium.org> Cr-Commit-Position: refs/heads/master@{#812675}
-
David Bokan authored
This test wants to check scrolling over a scrollbar but was scrolling over the scroll corner instead. The scroll corner is considered part of the scroller when scrolling from the main thread but not when scrolling from the compositor thread. This CL move the point to be over the scrollbar so that the test has consistent behavior on main and compositor threads. We also move it to fast/scrolling so it gets test coverage on both threads. Some cleanup has broken rename detection in Gerrit. See Base->PS1 for rename and above change. PS1->PS2 makes the test more readable. Bug: 915926,1090860 Change-Id: I25afd7c214505d38c08e456496d5bfa5a47ee74b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442353Reviewed-by:
Liviu Tinta <liviutinta@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#812674}
-
Michael Checo authored
Screenshots: - Diagnostics App (before) http://shortn/_yLwB4ZAKfO - Diagnostics App (after) http://shortn/_u5OBuBN0Bm Bug: 1125150 Test: browser_tests --gtest_filter=DiagnosticsApp* Change-Id: I688332b4ee48867be5b20e9ee0834914f0f6e0f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440927Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Commit-Queue: Michael Checo <michaelcheco@google.com> Cr-Commit-Position: refs/heads/master@{#812673}
-
Alice Wang authored
This CL improves the sign-in error retry flow by adding a sign-in state check before signing in and keep WebSigninBridge when there is a sign-in error. Bug: 1133704 Change-Id: Id4c1bba4f5af997ccfeb43972ba622eb5268d823 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440582Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#812672}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: I88ce6b1968db26a9a65690bf10a472af2e863f00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442712Reviewed-by:
-
Peter Kasting authored
Bug: 772945 Change-Id: I392d3bde5479806c1f9e03151dd25a8f394c7dcc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441129 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Cr-Commit-Position: refs/heads/master@{#812670}
-
Alice Wang authored
TBR=mcarlen@chromium.org Bug: 1134118 Change-Id: Icd716e4e698fc46a720ad769503bd79f036861a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442018Reviewed-by:
Alice Wang <aliceywang@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#812669}
-
kylechar authored
There have been multiple user reports about green flashes when navigating to or away from video with SkiaRenderer. ImageContextImpl doesn't hold any sort of reference to legacy GL textures while it's using them and was relying on the client holding the a reference. However, if a renderer is destroyed, and therefore all of it's references released, before the display compositor draws something else the video texture can be deleted while Skia is still using it to draw. This resulted in solid green, solid black or just missing quads in place of the video. Hold onto a reference to TexturePassthrough to prevent the texutre from being deleted early in this case. Bug: 1118166 Change-Id: Id35120b7c2cf5c11d0bb8d26812b2794e851a8fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441951Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#812668}
-
Ian Kilpatrick authored
This patch tracks the bounds of any inflow children (no floats, or out-of-flow positioned objects). This is only done for scrollable containers. This is used to correctly determine the layout-overflow of a fragment. Bug: 1066616 Change-Id: I334176cdf61f6eda92573e169719dbf7a2f62995 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432225Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#812667}
-
Michael Hablich authored
This is a roll-back to 8.7.220. This is the most stable candidate out of the latest Canaries. If this commit results in failures in Blink please contact the Blink sheriff. They may need to make changes to Blink because of the roll-back. When in doubt please try to contact the committer and reviewers of this CL before reverting it. TBR=machenbach@chromium.org Change-Id: I079691a99c37d77015884f99ee701fbbea767214 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442017Reviewed-by:
Michael Hablich <hablich@chromium.org> Commit-Queue: Michael Hablich <hablich@chromium.org> Auto-Submit: Michael Hablich <hablich@chromium.org> Cr-Commit-Position: refs/heads/master@{#812666}
-
Christian Biesinger authored
These are new tests added by mozilla, testing https://github.com/w3c/csswg-drafts/issues/5550 R=futhark@chromium.org Bug: 1133835 Change-Id: Ifa3127600540d783f59c8ffe31fccb27d41de4ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442376 Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Auto-Submit: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#812665}
-
harrisonsean authored
The scheduled callback is no longer called if there is no update. Both scheduled and oneoff callbacks not used if there is an error. Bug: 1078782, 1133907 Change-Id: Ib88f35db3f0dc8243b7a6a5e150bda10e6799552 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440631Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Sean Harrison <harrisonsean@chromium.org> Cr-Commit-Position: refs/heads/master@{#812664}
-
Reda Tawfik authored
This CL sorts the credentials in AllPasswordsBottomSheet alphabetically according to second-level domain name. Bug: 1133326, 1104132 Change-Id: I31bd63c51a0e842a3a8f92470a30f56342886471 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440889Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Commit-Queue: Reda Tawfik <redatawfik@google.com> Cr-Commit-Position: refs/heads/master@{#812663}
-
Sadrul Habib Chowdhury authored
Use atomic memcpy to read/write the smoothness data, and report the UKM data. BUG=1115139 Change-Id: I7bf40d0be0ad45e094c0f8910188edf48004ab92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422421 Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Steve Kobes <skobes@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Kramer Ge <fangzhoug@chromium.org> Cr-Commit-Position: refs/heads/master@{#812662}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/95949e4c8ae8..0d0e5bfe429c 2020-10-01 wolfi@chromium.org Fix tabs shown on reload 2020-10-01 sigurds@chromium.org Improve Settings types for checkboxes 2020-10-01 tvanderlippe@chromium.org Typecheck elements/MarkerDecorator.js with TypeScript If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ie11991058fa74022fd7ae98e8c64e9ceb2ddaa77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441984Reviewed-by:
-
Antonio Gomes authored
This CL implements the tabs.removeCSS extension API, that removes from a page CSS which was previously injected by a call to tabs.insertCSS(), similarly to Firefox' [1]. [1] https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/API/tabs/removeCSS The main difference between this implementation and the one in Firefox is that in Chrome's an extension can only remove its own CSS, not CSS injected by other extensions. This CL is based on the original work of https://crrev.com/c/918606 by Manish Jethani <m.jethani@eyeo.com>. BUG=608854 Change-Id: Ib448dbbe1f56b9c2db692794ce4fd210437f60a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250506 Commit-Queue: Antonio Gomes (GMT-4) <tonikitoo@igalia.com> Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#812660}
-
Tanmoy Mollik authored
For Sync Setup Incomplete error and auth error sync engine may not be initialized. And for unrecoverable error sync engine may shut down. This cl adds a separate flow for these two errors. Bug: 1131992 Change-Id: I979d7731142ba935add868dde9026def2b95dad3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440579 Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#812659}
-
Esmael El-Moslimany authored
Bug: 1110069 Change-Id: I9d8cce94e913ba4915c4903a5bdc9e6fa0f1cdb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441448 Commit-Queue: Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Alex Gough <ajgo@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Auto-Submit: Esmael Elmoslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#812658}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/492d4a85a2f0..2fde3fac998c 2020-10-01 hjd@google.com Merge "ui: Don't go via trackState for trackState.id" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: If2ebff5a82f567254fb4b367005aaecb0317c313 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442709Reviewed-by:
-
henrika authored
As discussed: landing behind a flag so we can learn more by testing it on more Windows laptops. Will eventually be launched using an experiment. This round is mainly for local testing purposes and to add UMA so we can track how many devices that support raw audio capture. NOTRY=true Tbr: beccahughes Bug: 1133643 Change-Id: Iae1a5ad45fb8ca7db192e0d3ea779e3803d372d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440055Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Markus Handell <handellm@google.com> Reviewed-by:
Olga Sharonova <olka@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#812656}
-
Viktor Semeniuk authored
This change adds test case coverage for the scenario when the Passwords screen is shown from the Breach Dialog. Bug: 1129871 Change-Id: I10148da8a6356a918f7d468eac7014977c3f3594 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437815 Commit-Queue: Viktor Semeniuk <vsemeniuk@google.com> Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#812655}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/11d94d866e23..3d5e8c4c466d 2020-10-01 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 18cdc317 to 5efa84e2 (627 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: jonahr@google.com Change-Id: I719b5c12a93f6b9351dce0c59b31c5f1fd18bfe4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441983 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
-
Nela Kaczmarek authored
This change creates HashAffiliationFetcher skeleton that extends AffiliationFetcherBase. This fetcher will provide additional privacy layer as it will request affiliations for a larger group of facets by passing only the prefixes of hashed URLs. Bug: 1108279 Change-Id: I4a2b09aa7d8c3c51f4b30ba966a17ba5afb9b09b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423883 Commit-Queue: Nela Kaczmarek <nelakaczmarek@google.com> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#812653}
-
Bao-Duy Tran authored
Bug: None Change-Id: I90086d0b1e4c350d0155dc0e39848863dac6298f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437720Reviewed-by:
My Nguyen <myy@chromium.org> Reviewed-by:
Keith Lee <keithlee@chromium.org> Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Commit-Queue: Bao-Duy Tran <tranbaoduy@chromium.org> Cr-Commit-Position: refs/heads/master@{#812652}
-
Olivier Yiptong authored
The use of the system APIs sometimes return duplicates. This change adds measures to prevent duplicates from occurring in the enumerations and measures their incidence. This CL treats fonts having the same postscript name as unique. This follows what Mac OS does: https://developer.apple.com/fonts/TrueType-Reference-Manual/RM06/Chap6name.html And also mirrors the matching behavior in @font-face src: local matching. Bug: 1043306 Change-Id: I9c8cdd26a47e0f54c4c5c35c2df80f1bed46e4bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438875 Commit-Queue: Brian White <bcwhite@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Auto-Submit: Olivier Yiptong <oyiptong@chromium.org> Cr-Commit-Position: refs/heads/master@{#812651}
-
Andy Paicu authored
Bug: 1126689 Change-Id: I23b1ee8095a7f7ee14ab589e82e5e7e7a1a086b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414292Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Matt Reynolds <mattreynolds@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Andy Paicu <andypaicu@chromium.org> Cr-Commit-Position: refs/heads/master@{#812650}
-
Milica Selakovic authored
Permission prompts should be dismissed while Autobot is running, but prompt should not be denied ir acceped. User should see prompt again and decide if wants to allow or deny permission. Bug: 1133783 Change-Id: I7665ffab65c1388c605a8f19f4ee5fc131063e4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440759Reviewed-by:
Clemens Arbesser <arbesser@google.com> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Commit-Queue: Milica Selakovic <selakovic@google.com> Cr-Commit-Position: refs/heads/master@{#812649}
-
Andrew Shulaev authored
Context: https://docs.google.com/document/d/1J4N3V5UmzZL9BZGNrn95E4xJu4cz3ynbg21zXR-J_qA/edit# Bug: 1007635 Change-Id: I62505df729c87f425b4d5589d32e83874ef12368 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440635 Auto-Submit: Andrew Shulaev <ddrone@google.com> Commit-Queue: Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Reviewed-by:
-
Michael Ershov authored
This reverts commit 503df9e6. Reason for revert: See the bug: crbug.com/1134123 Original change's description: > [Telemetry SWX] Add lid events > > Create and make available mojo interface for chrome://. > > Add implementation in chrome://. > > Add implementation in chrome-untrusted://. > > Add implementation for cros_healthd fake onLidOpened event emitter. > > Add browser test for lid event listener. > > Bug: b:167523716 > Change-Id: I4281778d451264f57154913330d8cd5ba83cb4f8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2389981 > Reviewed-by: Tom Sepez <tsepez@chromium.org> > Reviewed-by: Maksim Ivanov <emaxx@chromium.org> > Reviewed-by: Oleh Lamzin <lamzin@google.com> > Reviewed-by: Mahmoud Gawad <mgawad@google.com> > Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org> > Commit-Queue: Laurențiu Olteanu <lolteanu@google.com> > Cr-Commit-Position: refs/heads/master@{#812623} TBR=tsepez@chromium.org,emaxx@chromium.org,ortuno@chromium.org,lamzin@google.com,mgawad@google.com,lolteanu@google.com Change-Id: Ieaf49f9ddf39fcc0c6460bd64de3fdf334b4141e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: b:167523716 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440668Reviewed-by:
Michael Ershov <miersh@google.com> Commit-Queue: Michael Ershov <miersh@google.com> Cr-Commit-Position: refs/heads/master@{#812647}
-
Christian Biesinger authored
As per https://github.com/w3c/csswg-drafts/issues/5084, serializing the specified style for 0/0 should remain 0/0; only computed style should change. R=futhark@chromium.org Bug: 1086606 Change-Id: Iedf56b7dbcb3d0268db8d34d5a554c54a3bdafac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2439647 Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Auto-Submit: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
-
Matthias Körber authored
This CL adds migration logic for structured addresses. In the migration process, all tokens that are present in unstructured addresses are either set to being observed or verified depending on the verification status of the overall AutofillProfile. Change-Id: I4fdb9eb528a6a474448fc682ffde2571d2639b5e Bug: 1099202 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440663 Commit-Queue: Matthias Körber <koerber@google.com> Reviewed-by:
Christoph Schwering <schwering@google.com> Cr-Commit-Position: refs/heads/master@{#812645}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: Id364ca6b4584b2f7c14033dc2171d8090b3bb578 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441982Reviewed-by:
-
sandromaggi authored
AutofillAssistantPersonalDataManagerTest#testCreateAndEnterAddress The flakes seem to be real flakes. Bug: 1130016d Change-Id: Id3a0f7d00c4b27675f3ac38681e4b7015ce9e999 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442529Reviewed-by:
Luca Hunkeler <hluca@google.com> Commit-Queue: Sandro Maggi <sandromaggi@google.com> Cr-Commit-Position: refs/heads/master@{#812643}
-
Christian Dullweber authored
Move text to the bottom and revert to individual margins as the divider does not work as expected. Bug: 1077766 Change-Id: I7ade4dfd6d1315581dce1cf6b3670490652ff401 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440511Reviewed-by:
Ehimare Okoyomon <eokoyomon@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#812642}
-
Kent Tamura authored
This CL renames them as following, and make them returning true for LayoutNGTextControl* classes. - IsTextArea() -> IsTextAreaIncludingNG() - IsTextControl() -> IsTextControlIncludingNG() - IsTextField() -> IsTextFieldIncludingNG() This CL has no behavior changes because LayoutNGTextControl* classes are not used yet. Bug: 1040826 Change-Id: I0c6c2c39a7d32fbb1a454f3e97a263b1258cff33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442396 Commit-Queue: Kent Tamura <tkent@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Auto-Submit: Kent Tamura <tkent@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#812641}
-
Takashi Sakamoto authored
This fixes a bug of https://chromium-review.googlesource.com/c/chromium/src/+/2418631 Bug: 998048 Change-Id: Iffb7b291d3e0689781e5dea7d011e74b68f186bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437668 Commit-Queue: Takashi Sakamoto <tasak@google.com> Reviewed-by:
Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#812640}
-
Nela Kaczmarek authored
This CL adds a vector of pending fetchers that enable handling parallel requests. It uses a new struct FetchInfo to group together the fetcher, dedicated callback and requested origins, which facilitates processing each response. Bug: 1117045 Change-Id: I0f7529d02266f2cc20e8e0e4f4c77638483ce1b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436329 Commit-Queue: Nela Kaczmarek <nelakaczmarek@google.com> Reviewed-by:
-
Hiroshige Hayashizaki authored
This CL moves: - TRACE_EVENT - v8::TryCatch and related exception handling - RethrowErrorsOption from ScriptController/WorkerOrWorkletScriptController to V8ScriptRunner. This CL doesn't change the behavior. Bug: 1111134, 1129743 Change-Id: I62db5643acdf362a44420e7cf5694839bca4c4a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351605 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#812638}
-
