GitLab

Buttons are now 39x39, giving them bigger click/tap target zones,
spacing them further apart, and centering them within the switcher area.
The actual image sizes have not changed.

Moved the separator line up 1px to make room and to match the mocks.

Also added a new test of the exact dimensions of the app launcher, to
make sure we don't accidentally enlarge the window (which would have
been easy to accidentally do in this patch).

BUG=411775

Review URL: https://codereview.chromium.org/581923002

Cr-Commit-Position: refs/heads/master@{#295934}

Adding -gdwarf-4 to make DWARF-4 the output format.
 * gcc 4.6 outputs DWARF-2 by default
 * gcc 4.7 outputs DWARF-4 by default
 * clang <3.4 outputs DWARF-3 by default
 * clang >3.4 outputs DWARF-4 by default

DWARF-4 is the latest debug output format which includes features for
macro-expansion, better var tracking and other similar options.

From http://gcc.gnu.org/onlinedocs/gcc/Debugging-Options.html
> -gdwarf-4
>  Produce debugging information in DWARF format (if that is
>  supported). The value of version may be either 2, 3 or 4; the
>  default version for most targets is 4.  Note that with DWARF
>  Version 2, some ports require and always use some non-conflicting
>  DWARF 3 extensions in the unwind tables.
>
>  Version 4 may require GDB 7.0 and -fvar-tracking-assignments for
>  maximum benefit.

BUG=

Review URL: https://codereview.chromium.org/198363002

Cr-Commit-Position: refs/heads/master@{#295933}

BUG=397741

Review URL: https://codereview.chromium.org/587013003

Cr-Commit-Position: refs/heads/master@{#295932}

Cr-Commit-Position: refs/heads/master@{#295931}

Skipping the test case for source tag. This might be failing because still there are issues related with audio tags control attribute.

BUG=411987

Review URL: https://codereview.chromium.org/585093004

Cr-Commit-Position: refs/heads/master@{#295930}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/8bc0f5b..08e97a9

TBR=

Review URL: https://codereview.chromium.org/586423002

Cr-Commit-Position: refs/heads/master@{#295929}

This is a partial revert of commit 6c4617fc (r282586), "Experimental app
list: Added a current page indicator to the launcher.".

Latest mocks indicate the selected page by changing its icon to blue,
rather than having a blue line above the icon. The reason we are
removing this now is for spacing reasons -- we need to move the grey
separator line up by 1px but the blue line can't be moved up unless we
shrink the contents view.

BUG=411775

Review URL: https://codereview.chromium.org/590023002

Cr-Commit-Position: refs/heads/master@{#295928}

The following supressions are no longer needed:
bug_94195
bug_94345
bug_96069
bug_96568a
bug_96568b
bug_98568
bug_99304
bug_99308
bug_99321
bug_99435

BUG=94195,94345,96069,98568,99304,99308,99321,99435
TBR=groby@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/593593002

Cr-Commit-Position: refs/heads/master@{#295927}

Cleaning up weak_ptr_factory destruction order in "src/chrome/browser/history"
module. WeakPtrFactory should remain the last member so it'll be destroyed and
invalidate its weak pointers before any other members are destroyed.

BUG=303818

Review URL: https://codereview.chromium.org/574313002

Cr-Commit-Position: refs/heads/master@{#295926}

TBR=gene@chromium.org

Review URL: https://codereview.chromium.org/587103002

Cr-Commit-Position: refs/heads/master@{#295925}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/29c857d..a392c9d

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=borenet@google.com

Review URL: https://codereview.chromium.org/593553002

Cr-Commit-Position: refs/heads/master@{#295924}

Cleaning up weak_ptr_factory destruction order in "src/chrome/browser/chromeos"
module. WeakPtrFactory should remain the last member so it'll be destroyed and
invalidate its weak pointers before any other members are destroyed.

BUG=303818

Review URL: https://codereview.chromium.org/572873002

Cr-Commit-Position: refs/heads/master@{#295923}

BUG=416214
TEST=Manual, see bug

Review URL: https://codereview.chromium.org/588873002

Cr-Commit-Position: refs/heads/master@{#295922}

This patch adds a note to the FeatureObserver summary in histograms.xml
about the incorrect numbers due to crbug.com/341631.

BUG=341631

Review URL: https://codereview.chromium.org/160773002

Cr-Commit-Position: refs/heads/master@{#295921}

Given that MediaStream objects in the Blink side are allocated on Oilpan's heap, we need to trigger a GC to collect MediaStream objects in the Chromium side that depend on the lifetime of the MediaStream objects in the Blink side.

This CL adds Heap::collectAllGarbage to TearDown methods of MediaStream content_unittests. This guarantees that MediaStream objects used in the content_unittests are collected before the content_unittests finish. Otherwise, the LSan complains that the MediaStream objects leak in the content_unittests.

This is an issue that happens only in testing.

BUG=340522

Review URL: https://codereview.chromium.org/566793002

Cr-Commit-Position: refs/heads/master@{#295920}

Adding CanMinimize() (like CanMaximize()) function to WidgetDelegate class.
So that ColorChooserView or any other view inheriting WidgetDelegate, can
decide whether its window can show minimize button.

BUG=365768

R=sadrul@chromium.org

TEST=
1. Go to a page with <input type=color>. Here is one http://jsbin.com/yotasure/1
2. Click on the color input button to bring up the color picker window and observe
3. Color picker window should not have minimize button.

Review URL: https://codereview.chromium.org/567463002

Cr-Commit-Position: refs/heads/master@{#295919}

This API implementation is compiled on Chrome OS only, so the permission should
be available on Chrome OS only.

TEST=Tested manually that still works on Chrome OS.
BUG=248427

Review URL: https://codereview.chromium.org/581303002

Cr-Commit-Position: refs/heads/master@{#295918}

ImageButton::SetMinimumImageSize allows the client to explicitly set a
size larger than the image contained within the button. The image will
be aligned inside the button according to its alignment setting.

ImageButton::SetPreferredSize had a misleading name (since in fact it
only sets the size when there is no image) and is no longer needed. Its
original usage (r50040) is now gone. It wasn't having any effect in
either of its two remaining callers, since they always set an image
immediately afterwards. Therefore, deleted this method and removed both
calls to it. Note that we are keeping the default behaviour that an
ImageButton with no image has a size of 16x14. I wanted to remove this,
but the list of potential clients that could be relying on it is huge.

BUG=415909

Review URL: https://codereview.chromium.org/583843003

Cr-Commit-Position: refs/heads/master@{#295917}

The default app icon resource exists in the //extensions module resources
file and all implementations return the same icon. There's no need to delegate
this out.

BUG=none
TEST=app_shell, athena_main and chrome all run in debug without assertions
about missing resources

Review URL: https://codereview.chromium.org/586853004

Cr-Commit-Position: refs/heads/master@{#295916}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/fdff3fb..8bc0f5b

TBR=

Review URL: https://codereview.chromium.org/590893002

Cr-Commit-Position: refs/heads/master@{#295915}

the notification order test.

* Before this patch, file_system_operation_impl_unittest can not test
  the notification order because it doesn't have the update observer.

BUG=410198
TEST=content_unittests

Review URL: https://codereview.chromium.org/579153002

Cr-Commit-Position: refs/heads/master@{#295914}

Test input streams that do not meet encoder size requirements exactly.
Because ARM platform need 64 bytes alignment for starting address of YUV
planes of frames, use MemoryMappedFile to create input buffer and copy
data line by line from visible size to coded size. So VEA test can
test more Hangout resolutions now.

Original flow: prepare input memory -> initialize VEAClient -> initialize Encoder
New flow: initialize VEAClient -> get coded size -> prepare input memory

BUG=378166
TEST=Manually run auto test with h264 and vp8 on peach pit.
     Pass ./base_unittests --gtest_filter=MemoryMappedFileTest.*

Review URL: https://codereview.chromium.org/430583005

Cr-Commit-Position: refs/heads/master@{#295913}

BUG=377410
R=vabr@chromium.org,dbeam@chromium.org
TEST=In chrome://settings/passwords, revealed passwords should be editable.

Review URL: https://codereview.chromium.org/489103004

Cr-Commit-Position: refs/heads/master@{#295912}

BUG=
TBR=stgao@chromium.org

Review URL: https://codereview.chromium.org/585343002

Cr-Commit-Position: refs/heads/master@{#295911}

NOTRY=true

Review URL: https://codereview.chromium.org/591723002

Cr-Commit-Position: refs/heads/master@{#295910}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/70e09f7..fdff3fb

TBR=

Review URL: https://codereview.chromium.org/591953002

Cr-Commit-Position: refs/heads/master@{#295909}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/00a138c..29c857d

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=borenet@google.com

Review URL: https://codereview.chromium.org/588053002

Cr-Commit-Position: refs/heads/master@{#295908}

These tests are flaky on OSX 10.6.
Also revert attempted fix: https://codereview.chromium.org/568673004 .

BUG=405386

Review URL: https://codereview.chromium.org/582803005

Cr-Commit-Position: refs/heads/master@{#295907}

Provide a method to get the chromium version for use as the
data reduction proxy version.

BUG=410127

Review URL: https://codereview.chromium.org/533003002

Cr-Commit-Position: refs/heads/master@{#295906}

BUG=408964
TEST=Manual

Review URL: https://codereview.chromium.org/554393008

Cr-Commit-Position: refs/heads/master@{#295905}

BUG=339240
TBR=joaodasilva@chromium.org

Review URL: https://codereview.chromium.org/591943002

Cr-Commit-Position: refs/heads/master@{#295904}

Broke check_licenses step http://build.chromium.org/p/chromium/builders/Linux/builds/53652/steps/check_licenses/logs/stdio

This reverts commit 7c33f442.

R=dzhioev@chromium.org
BUG=

Review URL: https://codereview.chromium.org/592603004

Cr-Commit-Position: refs/heads/master@{#295903}

BUG=348066
TEST=None
R=dpranke@chromium.org

Review URL: https://codereview.chromium.org/585283002

Cr-Commit-Position: refs/heads/master@{#295902}

Cr-Commit-Position: refs/heads/master@{#295901}

Cr-Commit-Position: refs/heads/master@{#295900}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/3c196de..00a138c

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=borenet@google.com

Review URL: https://codereview.chromium.org/589923002

Cr-Commit-Position: refs/heads/master@{#295899}

Disable NaClBrowserTestNewlib.IrtException on Windows to see if that gets rid of the hung browser test binaries.

BUG=416272
TBR=uekawa@chromium.org

Review URL: https://codereview.chromium.org/591883002

Cr-Commit-Position: refs/heads/master@{#295898}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/e266d9c..70e09f7

TBR=

Review URL: https://codereview.chromium.org/588933002

Cr-Commit-Position: refs/heads/master@{#295897}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/bcf65c8..e266d9c

TBR=

Review URL: https://codereview.chromium.org/587653004

Cr-Commit-Position: refs/heads/master@{#295896}

Sometimes, the status icon was shown in unexpected timing. This might be because the animation is re-fired when the dom is restyled. This patch fixes it.

BUG=none
TEST=Open window->play video->pause->close window. Repeat it 20 times and observe no issue.

Review URL: https://codereview.chromium.org/573233002

Cr-Commit-Position: refs/heads/master@{#295895}