- 19 Mar, 2018 40 commits
-
-
Raphael Kubo da Costa authored
GCC is stricter than clang when it comes to class members' names and how they can change the meaning of a previously existing symbol with the same name: ../../third_party/WebKit/Source/core/layout/ScrollbarsTest.cpp:45:3: error: declaration of ‘blink::EventHandler& blink::{anonymous}::ScrollbarsTest::EventHandler()’ [-fpermissive] } ^ In file included from ../../third_party/WebKit/Source/core/layout/ScrollbarsTest.cpp:10:0: ../../third_party/WebKit/Source/core/input/EventHandler.h:79:19: error: changes meaning of ‘EventHandler’ from ‘class blink::EventHandler’ [-fpermissive] class CORE_EXPORT EventHandler final ^~~~~~~~~~~~ https://gcc.gnu.org/bugzilla/show_bug.cgi?id=84709 contains a longer explanation, but essentially having an |EventHandler()| method can change the meaning of references to |EventHandler| in the code depending on where it is declared, which contradicts the C++ standard. Fix it by renaming the method to |GetEventHandler()|. Change-Id: Ie2fbab48e3e1f68a80f07d95ccf07bd048df1451 Reviewed-on: https://chromium-review.googlesource.com/968512 Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Reviewed-by:
Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#544044}
-
Dominik Röttsches authored
Remove src/ from Chromium repo and retrieve HarfBuzz sources from the mirror at [1]. Cherry picks can be done by HarfBuzz OWNERS by pushing new branches to refs/heads/chromium/ of [1]. This was tested and confirmed working in:: https://chromium-review.googlesource.com/c/chromium/src/+/937502 [1] https://chromium.googlesource.com/external/github.com/harfbuzz/harfbuzz/ Bug: 814305 Change-Id: I8760f734839012b1c9c9b9b07f11fa71000e5531 Reviewed-on: https://chromium-review.googlesource.com/928761Reviewed-by:
Ben Wagner <bungeman@chromium.org> Reviewed-by:
Behdad Esfahbod <behdad@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#544043}
-
gogerald authored
This could happen when show has not been called, Bug: 721362 Change-Id: I1bae92bbf87c9ccc63326d4d1ffd7c798cb4aadc Reviewed-on: https://chromium-review.googlesource.com/968708Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#544042}
-
Raphael Kubo da Costa authored
GCC is stricter than clang when it comes to class members' names and how they can change the meaning of a previously existing symbol with the same name: Document* Document() { return &dummy_context_.GetDocument(); } ^ In file included from ../../third_party/WebKit/Source/modules/credentialmanager/CredentialsContainerTest.cpp:12:0: ../../third_party/WebKit/Source/core/dom/Document.h:248:19: error: changes meaning of ‘Document’ from ‘class blink::Document’ [-fpermissive] class CORE_EXPORT Document : public ContainerNode, ^~~~~~~~ ../../third_party/WebKit/Source/modules/credentialmanager/CredentialsContainerTest.cpp:114:72: error: declaration of ‘blink::ScriptState* blink::{anonymous}::CredentialManagerTestingContext::ScriptState()’ [-fpermissive] ScriptState* ScriptState() { return dummy_context_.GetScriptState(); } ^ In file included from ../../third_party/WebKit/Source/bindings/core/v8/ScriptValue.h:37:0, from ../../third_party/WebKit/Source/bindings/core/v8/ScriptFunction.h:34, from ../../third_party/WebKit/Source/bindings/core/v8/ScriptPromise.h:35, from ../../third_party/WebKit/Source/bindings/core/v8/ExceptionState.h:34, from ../../third_party/WebKit/Source/bindings/core/v8/V8BindingForTesting.h:8, from ../../third_party/WebKit/Source/modules/credentialmanager/CredentialsContainerTest.cpp:10: ../../third_party/WebKit/Source/platform/bindings/ScriptState.h:66:23: error: changes meaning of ‘ScriptState’ from ‘class blink::ScriptState’ [-fpermissive] class PLATFORM_EXPORT ScriptState : public RefCounted<ScriptState> { ^~~~~~~~~~~ https://gcc.gnu.org/bugzilla/show_bug.cgi?id=84709 contains a longer explanation, but essentially having a |Document()| or |ScriptState()| method can change the meaning of references to the outside types in the code depending on where it is declared, which contradicts the C++ standard. Fix it by renaming the methods to |GetDocument()| and |GetScriptState()|. Change-Id: I037d009c52a5e44838e90d1b8ea330acf922afaa Reviewed-on: https://chromium-review.googlesource.com/968515Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Cr-Commit-Position: refs/heads/master@{#544041}
-
Raphael Kubo da Costa authored
GCC is stricter than clang when it comes to class members' names and how they can change the meaning of a previously existing symbol with the same name: ../../third_party/WebKit/Source/core/input/PointerEventManagerTest.cpp:90:3: error: declaration of ‘blink::EventHandler& blink::PointerEventManagerTest::EventHandler()’ [-fpermissive] } ^ In file included from ../../third_party/WebKit/Source/core/input/PointerEventManagerTest.cpp:8:0: ../../third_party/WebKit/Source/core/input/EventHandler.h:79:19: error: changes meaning of ‘EventHandler’ from ‘class blink::EventHandler’ [-fpermissive] class CORE_EXPORT EventHandler final ^~~~~~~~~~~~ ../../third_party/WebKit/Source/core/input/TouchEventManagerTest.cpp:21:3: error: declaration of ‘blink::EventHandler& blink::TouchEventManagerTest::EventHandler()’ [-fpermissive] } ^ In file included from ../../third_party/WebKit/Source/core/input/TouchEventManagerTest.cpp:9:0: ../../third_party/WebKit/Source/core/input/EventHandler.h:79:19: error: changes meaning of ‘EventHandler’ from ‘class blink::EventHandler’ [-fpermissive] class CORE_EXPORT EventHandler final ^~~~~~~~~~~~ https://gcc.gnu.org/bugzilla/show_bug.cgi?id=84709 contains a longer explanation, but essentially having an |EventHandler()| method can change the meaning of references to |EventHandler| in the code dependending on where it is declared, which contradicts the C++ standard. Fix it by renaming the method to |GetEventHandler()|. Change-Id: I2d54280bb86a2af0bc9920115ba16fdb49ad7186 Reviewed-on: https://chromium-review.googlesource.com/968491Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Cr-Commit-Position: refs/heads/master@{#544040}
-
Benoit Lize authored
Allows the client to set a referrer policy for the parallel request. Bug: 816837 Change-Id: I0a7525fa90079f5dd971e3bfe5565a0fb3c3b10b Reviewed-on: https://chromium-review.googlesource.com/966443Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#544039}
-
Finnur Thorarinsson authored
Remove helper functions for posting tasks and a bit of header cleanup. Note: This was split of from review: https://chromium-review.googlesource.com/c/chromium/src/+/963685 Bug: 734095 Change-Id: If3a58f70c1ffcc63c2998adc27eb885f20f8fe46 Reviewed-on: https://chromium-review.googlesource.com/963324 Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Xi Cheng <chengx@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#544038}
-
Fredrik Söderquist authored
Restructure the code so that traversing a LayoutObject's resources is shared, and rename ResourceContainsCycles to TraverseResourceContainer. Hoist the side-effects (clearing out resources with cycles) to the caller. Bug: 534817, 769774 Change-Id: Icd8200a2cd9073487479e32827a9fdeb1d8d04c4 Reviewed-on: https://chromium-review.googlesource.com/966661Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#544037}
-
xlai authored
Same as canvas.toBlob(), the OffscreenCanvas.convertToBlob() are running on idle tasks by default. When idle tasks do not begin for a long time, they force encoding on the current thread. As idle tasks are not enabled on layout tests unless "--enable-threaded-compositing" flag is turned on, we therefore do both virtual and non-virtual tests to ensure complete test coverage of both execution paths--idle-task mode and force-encoding mode. The non-virtual tests need to be marked as [Slow] as the CanvasAsyncBlobCreator is waiting for the idle tasks for a threshold time before switching to force-encoding mode. Bug: 817091 Change-Id: I2c7da9e27ee2d24e1a5e6ee1c36597b46f052aca Reviewed-on: https://chromium-review.googlesource.com/964395Reviewed-by:
Justin Novosad <junov@chromium.org> Commit-Queue: Olivia Lai <xlai@chromium.org> Cr-Commit-Position: refs/heads/master@{#544036}
-
Michael Lippautz authored
Bug: chromium:757440 Change-Id: Ibb3961a8ccf96578e4b5493714a79a0a55411025 Reviewed-on: https://chromium-review.googlesource.com/968506 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#544035}
-
Robert Kaplow authored
Currently if there is no whitelist, we record everything. We shouldn't do this since if a user has no field trial params (first run, etc.), they will record everything, avoiding the whitelist. Also changed a bitwise and to && while I was making a change. No-op but seems bad style (and apparently can be different as & doesn't shortcut). Bug: 820632 Change-Id: I3fd3b1ca6669294e61467bb0f4d0ad87fb2ff576 Reviewed-on: https://chromium-review.googlesource.com/957384 Commit-Queue: Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#544034}
-
Anthony Vallee-Dubois authored
Bug: NONE Change-Id: If299b18f98887d02f9db800effcda4ddc3e11e5a Reviewed-on: https://chromium-review.googlesource.com/968670 Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#544033}
-
Antoine Labour authored
Perhaps counterintuitively, Elf64_Word is 32 bits. Don't use it to manipulate file sizes. BUG=780860 Change-Id: I0a80e10b46400dcd0e0e43061755494267d67a06 Reviewed-on: https://chromium-review.googlesource.com/954326 Commit-Queue: Michael Moss <mmoss@chromium.org> Reviewed-by:
Michael Moss <mmoss@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#544032}
-
Raphael Kubo da Costa authored
GCC is stricter than clang when it comes to class members' names and how they can change the meaning of a previously existing symbol with the same name: ../../third_party/WebKit/Source/core/frame/LocalFrameViewTest.cpp:72:77: error: declaration of ‘blink::{anonymous}::AnimationMockChromeClient& blink::{anonymous}::LocalFrameViewTest::ChromeClient() const’ [-fpermissive] AnimationMockChromeClient& ChromeClient() const { return *chrome_client_; } ^ In file included from ../../third_party/WebKit/Source/core/loader/EmptyClients.h:39:0, from ../../third_party/WebKit/Source/core/layout/LayoutTestHelper.h:17, from ../../third_party/WebKit/Source/core/frame/LocalFrameViewTest.cpp:10: ../../third_party/WebKit/Source/core/page/ChromeClient.h:94:19: error: changes meaning of ‘ChromeClient’ from ‘class blink::ChromeClient’ [-fpermissive] class CORE_EXPORT ChromeClient : public PlatformChromeClient { ^~~~~~~~~~~~ https://gcc.gnu.org/bugzilla/show_bug.cgi?id=84709 contains a longer explanation, but essentially having a |ChromeClient()| method can change the meaning of references to |ChromeClient| in the code dependending on where it is declared, which contradicts the C++ standard. Fix it by renaming the method to |GetAnimationMockChromeClient()|. Change-Id: I3d92e960384ba6b8d1885f7fed2618085ce19855 Reviewed-on: https://chromium-review.googlesource.com/968425Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Cr-Commit-Position: refs/heads/master@{#544031}
-
Daniel Vogelheim authored
Increases fuzzer coverage to match changes in cl 924187. Hopefully also fixes the referenced bug, because this now explicitly initializes CachedDocumentParameters::integrity_features when called from the fuzzer. Bug: 818396 Change-Id: Ica18606543bd5cb36df567a132a6fe2b1da9620f Reviewed-on: https://chromium-review.googlesource.com/968508 Commit-Queue: Daniel Vogelheim <vogelheim@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Max Moroz <mmoroz@chromium.org> Cr-Commit-Position: refs/heads/master@{#544030}
-
Charles Harrison authored
Bug: 810203 Change-Id: I69036af7dab173d84afaf39b52653461225d3e3b Reviewed-on: https://chromium-review.googlesource.com/909413Reviewed-by:
Cait Phillips <caitkp@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#544029}
-
Raphael Kubo da Costa authored
GCC is stricter than clang when it comes to class members' names and how they can change the meaning of a previously existing symbol with the same name: ../../third_party/WebKit/Source/core/exported/WebFrameTest.cpp: At global scope: ../../third_party/WebKit/Source/core/exported/WebFrameTest.cpp:12592:3: error: declaration of ‘blink::LocalFrameView* blink::SlimmingPaintWebFrameTest::LocalFrameView()’ [-fpermissive] } ^ In file included from ../../third_party/WebKit/Source/core/frame/LocalFrame.h:41:0, from ../../third_party/WebKit/Source/core/page/Page.h:33, from ../../third_party/WebKit/Source/core/page/PageVisibilityObserver.h:31, from ../../third_party/WebKit/Source/core/html/canvas/HTMLCanvasElement.h:44, from ../../third_party/WebKit/Source/core/html/canvas/CanvasRenderingContext.h:32, from ../../third_party/WebKit/Source/core/html/canvas/ImageData.h:34, from ../../third_party/WebKit/Source/bindings/core/v8/serialization/SerializedColorParams.h:8, from ../../third_party/WebKit/Source/bindings/core/v8/serialization/V8ScriptValueSerializer.h:11, from ../../third_party/WebKit/Source/core/exported/WebFrameTest.cpp:45: ../../third_party/WebKit/Source/core/frame/LocalFrameView.h:105:19: error: changes meaning of ‘LocalFrameView’ from ‘class blink::LocalFrameView’ [-fpermissive] class CORE_EXPORT LocalFrameView final ^~~~~~~~~~~~~~ https://gcc.gnu.org/bugzilla/show_bug.cgi?id=84709 contains a longer explanation, but essentially having a |LocalFrameView()| method can change the meaning of references to |LocalFrameView| in the code dependending on where it is declared, which contradicts the C++ standard. Fix it by renaming the method to |GetLocalFrameView()|. Change-Id: I3aa9502080708653bdff68eaec51fe61850b4877 Reviewed-on: https://chromium-review.googlesource.com/968424Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Cr-Commit-Position: refs/heads/master@{#544028}
-
Juan Antonio Navarro Perez authored
device_utils.GetPids is being deprecated. Switch its clients to use ListProcesses and GetApplicationPids instead. Bug: catapult:#4103 Change-Id: I32e935918ea8f9da586caa91c5e9e8a0b6ac65a2 Reviewed-on: https://chromium-review.googlesource.com/962801 Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#544027}
-
Becca Hughes authored
When opening a new tab for the same origin as a the current tab, the new tab was incorrectly linked to the currently open tab's MediaEngagementSession. This adds a check to only allow the sessions to be linked if the new tab navigation originated from a link on the current tab. BUG=819807 Change-Id: I02f892372f1aa92f830f891a369732a4fc7b8883 Reviewed-on: https://chromium-review.googlesource.com/962242 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#544026}
-
sebsg authored
Bug: 822849 Change-Id: If2c0f615f4b9e610ca9ec745e081622efed1d887 Reviewed-on: https://chromium-review.googlesource.com/967081 Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#544025}
-
Vadym Doroshenko authored
TBR=msw@chromium.org Bug: 823043 Change-Id: I4c113f6630340907aec7870487176a2046f035ac Reviewed-on: https://chromium-review.googlesource.com/968602Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#544024}
-
Vadym Doroshenko authored
TBR=emaxx@chromium.org TBR=pastarmovj@chromium.org Bug: 822975 Change-Id: I03062d8eb1c8c3221cf07eb08587e4d9c97ed5e2 Reviewed-on: https://chromium-review.googlesource.com/968507Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#544023}
-
Hans Wennborg authored
We've had poor Android test coverage on the ToT bots, as shown by the recent clang roll. Historically that's been due to flakiness of running Android tests. But now that everything's on swarming it should be better, and this uses the config from linux_android_rel_ng which runs on the CQ and seems to be very stable. Bug: 817298 Change-Id: Ie992c49c9a86037529f8ac6bd70c7ce7b732850c Reviewed-on: https://chromium-review.googlesource.com/968243Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#544022}
-
Mathieu Perreault authored
Bug: 821917 Test: components_unittests --gtest_filter=Suggestions* Change-Id: Ia6a4389b42c42936ba9d0f8014e2d32b8426a70d Reviewed-on: https://chromium-review.googlesource.com/967872Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#544021}
-
https://skia.googlesource.com/skia.git/+log/4410d7ff7572..fe0253f8bb64 $ git log 4410d7ff7..fe0253f8b --date=short --no-merges --format='%ad %ae %s' 2018-03-16 robertphillips Alter GrSurface/GrSurfaceProxy flags to prepare for GrTexture/GrTextureProxy -specific flags Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=jvanverth@chromium.org Change-Id: I94940df71f0dbfc15035ee1eca38968f15bc26e7 Reviewed-on: https://chromium-review.googlesource.com/968541 Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#544020}
-
jonross authored
Filter out new consisten Mac filters in viz_content_browsertests and viz_browser_tests TEST=viz_browser_tests, viz_content_browsertests_ TBR=kylechar@chromium.org Bug: 760181 Change-Id: Idde59c0abb342a19bf5539b4771ea7aca586bc51 Reviewed-on: https://chromium-review.googlesource.com/968545Reviewed-by:
Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#544019}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/8c5929de..9cf8abb7 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: Ief0faf2cb789048efc5fb6c50fbc64c212398b95 Reviewed-on: https://chromium-review.googlesource.com/968344Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#544018}
-
Alexander Timin authored
Move throttling code to scheduler/common/ as a preparation to enable throttling for worker threads. R=alexclarke@chromium.org BUG=776416 Change-Id: I78e4e249bcacf7ccc0c6feae48cd44a534c36a56 Reviewed-on: https://chromium-review.googlesource.com/966621 Commit-Queue: Alexander Timin <altimin@chromium.org> Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Cr-Commit-Position: refs/heads/master@{#544017}
-
Etienne Pierre-Doray authored
This CL deletes Label Manager sources and unittests since it is not used anymore. Bug: 729154 Change-Id: Ic8e9cc8dbebd4317d53c0b48ac683b44de99593b Reviewed-on: https://chromium-review.googlesource.com/967051Reviewed-by:
Samuel Huang <huangs@chromium.org> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#544016}
-
Rayan Kanso authored
Use BuildInfo directly to check the SDK version in NotificationSettings. Bug: 821431 Change-Id: Ie3ca8b6dc2cf200ab06d3e1aa6820bca341db1c5 Reviewed-on: https://chromium-review.googlesource.com/966284 Commit-Queue: Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Anita Woodruff <awdf@chromium.org> Cr-Commit-Position: refs/heads/master@{#544015}
-
Pawel Osciak authored
This reverts commit 6683995b. Reason for revert: crbug.com/823235 Original change's description: > Vaapi: Remove ConditionVariables and use PostTask > > This CL removes the use of the ConditionVariables inside VaVDA and > uses instead PostTask()ing. This removes blocking the worker > thread, which allows for moving other tasks there, e.g. the > Surface Blit (as done in the follow up WIP CL crrev.com/c/947341) > > For all that goodness, this CL: > > - Refactors the waiting logic that on ToT is spread between > GetCurrInputBuffer_Locked() and WaitForSurfaces_Locked() and > simplifies it in DecodeTask() itself. > > - Moves the |curr_input_buffer_| filling logic in > GetCurrInputBuffer_Locked() into DecodeTask() proper. > > - Reduces the scoped of the |lock_| in DecodeTask() (note that > |curr_input_buffer_| and |decode_| are only used on the decoder > thread -- added a .h comment). > > Minor stuff: This CL also moves together the declaration of the > related member vars |input_buffers_|, |curr_input_buffer_| and > |available_va_surfaces_| > > TEST=simplechrome+crosvideo (including seeks) on soraka, and > v_d_a_unittest with h264, vp8, vp9 (with dcheck_always_on=true). > > Bug: 717265 > Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel > Change-Id: Ib167115dd2a4ebaeaea3ba3b5a205779d659f479 > Reviewed-on: https://chromium-review.googlesource.com/949283 > Commit-Queue: Miguel Casas <mcasas@chromium.org> > Reviewed-by: Daniele Castagna <dcastagna@chromium.org> > Cr-Commit-Position: refs/heads/master@{#542955} TBR=posciak@chromium.org,kcwu@chromium.org,mcasas@chromium.org,dcastagna@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 717265 Cq-Include-Trybots: luci.chromium.try:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I62361a33067140eb42112ccf7613136137bc30e2 Reviewed-on: https://chromium-review.googlesource.com/967967 Commit-Queue: Pawel Osciak <posciak@chromium.org> Reviewed-by:
Pawel Osciak <posciak@chromium.org> Cr-Commit-Position: refs/heads/master@{#544014}
-
Patrik Höglund authored
We want Chromium to build with enable_webrtc=false. I will initially add a build bot in chromium.webrtc. Bug: chromium:811678 Change-Id: If3f23a70f0102f5b65bb46e5e91eee3c0b1bbeb2 Reviewed-on: https://chromium-review.googlesource.com/960125 Commit-Queue: Patrik Höglund <phoglund@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#544013}
-
Asanka Herath authored
This flag was originally added to ui::base::win to suppress a specific error message when attempting to open a file via the shell using the "open" verb. The flag has additional side-effects and shouldn't be used when invoking ShellExecute(). R=grt@chromium.org Bug: 819809 Change-Id: I7db2344982dd206c85a73928e906c21e06a47a9e Reviewed-on: https://chromium-review.googlesource.com/966964 Commit-Queue: Greg Thompson <grt@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#544012}
-
Boris Sazonov authored
This reverts commit 1fa1c441. Reason for revert: broke downstream builders Original change's description: > android build: Split process_resources GN rule and script. > > The process_resources() GN template and the associated > process_resources.py script are huge and difficult to understand > because they can be used to perform two slightly related > different things. > > In preparation for a future CL that will introduce a new resource > compilation mode, this CL tries to clarify the situation by splitting > them into two sets of GN template + script: > > - prepare_resources() + prepare_resources.py, which are > used to create .resources.zip archives of raw/uncompiled > resources for resource related targets, as well as > generating a corresponding R.txt and .srcjar(R.java) > file. > > This corresponds to what process_resources() did when > it was called from android_resources() and junit_binary(). > > Note that this always generates non-final resource IDs, > as well as a dummy onResourcesLoaded() method, necessary > to compile, but not link, the ResourceRewriter class > used to implement the system webview feature. > > - compile_resources() + compile_resources.py, which are used > to compile all resource dependencies of a given binary > (e.g. android_apk) into an intermediate .ap_ file. > > This corresponds to the behaviour of process_resources() > when called from android_apk(). This generates final > resource IDs by default, unless |shared_resources| or > |shared_resources_whitelist| is used. > > Also, as a simplification, |shared_resources_whitelist| > now implies |shared_resources|, except that it restrict > the list of non-final resource IDs. > > - Removed generate_constant_ids, since compile_resources() > will always generate constant ids unless shared resources > are being used. And prepare_resources() always generates > non-constant IDs, as before the CL. > > + Add documentation for the prepare_resources() and > compile_resources() internal GN rules, to make them > a little less intimidating. > > + Removed |app_as_shared_lib|, since even before this CL all > resources were generated with package ID 0x7f anyway, or > fixed a compile_resources() time. Hence |shared_resources| > did the exact same thing. > > + Improve --help output for prepare_resources.py and > compile_resources.py by using option groups for inputs > and outputs. > > R=agrieve@chromium.org,yfriedman@chromium.org,estevenson@chromium.org,trevordixon@chromium.org > > Bug: 820459 > Change-Id: If05ac24a57c4dfa11f9ce43c30ab22e957b2765d > Reviewed-on: https://chromium-review.googlesource.com/957095 > Commit-Queue: David Turner <digit@chromium.org> > Reviewed-by: agrieve <agrieve@chromium.org> > Cr-Commit-Position: refs/heads/master@{#543957} TBR=digit@chromium.org,yfriedman@chromium.org,agrieve@chromium.org,estevenson@chromium.org,trevordixon@chromium.org Change-Id: I38d7922928cc6222750e057bc4a602a1faaec59e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 820459 Reviewed-on: https://chromium-review.googlesource.com/968461Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#544011}
-
Kunihiko Sakamoto authored
This patch makes SignedExchangeHandler populate the minimal set of timing info for the HTTP exchange response, so that devtools' network timeline will show reasonable values. Bug: 803774 Change-Id: Ida0d34f7bab86f5ff674b776fe5fca511111c87c Reviewed-on: https://chromium-review.googlesource.com/967632Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#544010}
-
Colin Blundell authored
Change-Id: I2e894379abc801ef364a9228b89e3cc23eaf408c Reviewed-on: https://chromium-review.googlesource.com/968247 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#544009}
-
Florian Uunk authored
last_auth_error_ was set from OnGetTokenFailure, but then never cleared in onGetTokenSuccess. This meant that the error could stay around, even if the causing token issue was resolved. BUG=822182 Change-Id: I135baa55d8e81860313dd02f2ca432f0482c3c10 Reviewed-on: https://chromium-review.googlesource.com/964334 Commit-Queue: Florian Uunk <feuunk@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#544008}
-
Gyuyoung Kim authored
As skia font cache, we need to limit the memory usage of skia resource cache for the low-end device as well. But, as the font cache, it's hard to estimate what is the limit value the best for each low-end device. So it would be good if we give them the power to limit to use the resource cache. This CL introduces a new command line switch to limit the skia resource cache size. Bug: 823210 Change-Id: Icc55a8701fe2fa94bdc0ee09b428c19031c131a5 Reviewed-on: https://chromium-review.googlesource.com/968006 Commit-Queue: Gyuyoung Kim <gyuyoung.kim@lge.com> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#544007}
-
https://webrtc.googlesource.com/src.git/+log/8a1b20a21329..9fa35e528528 $ git log 8a1b20a21..9fa35e528 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Id4c6302826bb881e8b31332c5304b354457130c5 Reviewed-on: https://chromium-review.googlesource.com/967951 Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#544006}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/6887bb98..8c5929de Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: Id1149be5925c8733c6cf4be6ad75bee0ca955827 Reviewed-on: https://chromium-review.googlesource.com/967953Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#544005}
-