GitLab

NetLog is going to be moved into the network service process.
We should switch to traceevent for logging purpose instead.

BUG=767450

Change-Id: Ic81994a1685057f73716fa7b33a366f94d50dd26
Reviewed-on: https://chromium-review.googlesource.com/750050
Commit-Queue: Min Qin <qinmin@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515051}

Bug: 782858
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: If4a5bc70f8a9eac788960abfb3e2b4db5eec2438
Reviewed-on: https://chromium-review.googlesource.com/755214Reviewed-by: Justin Novosad <junov@chromium.org>
Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Mike Reed <reed@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515050}

This CL is the third CL of implementing OfflinePageModelTaskfied.
It contains:
- GetPages* workflow, with GetOfflineIdByClientId.
- Related tests for GetPages* workflow.

More details: go/offline-page-model-migration

Bug: 753595
Change-Id: Ie95389fdb7ac6bfa61fb1ed663f0aa3583c3d11d
Reviewed-on: https://chromium-review.googlesource.com/752688Reviewed-by: Peter Williamson <petewil@chromium.org>
Reviewed-by: Filip Gorski <fgorski@chromium.org>
Reviewed-by: Dmitry Titov <dimich@chromium.org>
Commit-Queue: Yafei Duan <romax@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515049}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/ba9cf60e..ad1474a1

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org

Change-Id: I159eaadcac569a24b382f2f239da50c4df070ae6
Reviewed-on: https://chromium-review.googlesource.com/758919Reviewed-by: v8 autoroll <v8-autoroll@chromium.org>
Commit-Queue: v8 autoroll <v8-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515048}

This change sets the 'toolbar ready for captute' flag when a tab is
shown rather than waiting for the URL to be updated. When a tab is
reparented for Chrome Home, the activity restarts and resets the flag.
Since the URL of the tab technically hasn't changed, the onUrlUpdated
even is not called and the URL bitmap is therefore never updated.

BUG=781692

Change-Id: I209f81d4f9bed0e2566d7a42c84294c8af1b863e
Reviewed-on: https://chromium-review.googlesource.com/757816Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Matthew Jones <mdjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515047}

This pass focuses on ML::SNTA in same scope as RunLoop variable
Scripted via https://bugs.chromium.org/p/chromium/issues/detail?id=781352#c1

The script should have replaced a MessageLoop::ScopedNestableTaskAllower
in the same scope as a RunLoop with a RunLoop of
Type::kNestableTasksAllowed. If there was a comment above the
MessageLoop::ScopedNestableTaskAllower, it should have been moved
alongside the augmented RunLoop.

Please CQ if LGTY

This CL was uploaded by git cl split.

R=jam@chromium.org

Bug: 781352
Change-Id: I2c2c6cb8f19d5c3163c0a0012df38d67822dbf42
Reviewed-on: https://chromium-review.googlesource.com/758930
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515046}

Fixes bug where detect minified code would expect the string to always
exist on content for UISourceCode. We now check it's nullcase.

R=lushnikov,einbinder
BUG=None

Change-Id: Ie3c28d246017075549b0fca6c262b2f84bc77bff
Reviewed-on: https://chromium-review.googlesource.com/758746Reviewed-by: Joel Einbinder <einbinder@chromium.org>
Reviewed-by: Andrey Lushnikov <lushnikov@chromium.org>
Commit-Queue: Blaise Bruer <allada@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515045}

This CL adds |chromeos_board| Gaia URL parameter.

Bug: 782641
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ib9980437bc95c5ca0287721798cd93f32ef87970
Reviewed-on: https://chromium-review.googlesource.com/758716Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Alexander Alekseev <alemate@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515044}

UseRenderPass() has two use cases, either to set up a render pass
as the framebuffer for drawing at the start of the draw, or to restore
us back to that state after making some intermediate change to which
framebuffer is bound.

UseRenderPass() has some optimizations where it can return false and
not do anything, if it detects that we don't want to draw the render
pass. The first use case, in DrawRenderPass() makes use of this return
value to avoid drawing anything.

Other callers to UseRenderPass() do not check the return value because
we're already drawing the pass and they are trying to restore state. If
it early outs for these it would be unexpected and produce bugs.

Currently DecideRenderPassAllocationsForFrame modifies render passes to
try avoid such bugs, but there are other ways to encounter the bug.

This changes UseRenderPass() to never early out so the latter cases will
not avoid resetting the framebuffer. The former case can avoid
UseRenderPass() entirely by checking CanSkipRenderPass(). If it is true,
then it does not need to be drawn.

Also, we will now ensure that UseRenderPass() is called after using a
ScopedUseGrContext when drawing a RenderPassDrawQuad. Currently on errors
it would early out before restoring the framebuffer, which could cause
bugs for the next quads in the RenderPass. This was introduced when the
UseRenderPass() call was moved out of the ~ScopedUseGrContext()
destructor in https://codereview.chromium.org/2203033005.

This all came up via https://chromium-review.googlesource.com/c/chromium/src/+/757027#message-b6e905925e834419ff448e2093a392053d5d321a

R=enne@chromium.org, wutao@chromium.org

Bug: 782044, 738190, 782042
Change-Id: Ib4662c5fee3f326642add12bbfe3d51e51dff1c9
Reviewed-on: https://chromium-review.googlesource.com/757049
Commit-Queue: danakj <danakj@chromium.org>
Reviewed-by: enne <enne@chromium.org>
Reviewed-by: Tao Wu <wutao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515043}

This is dead code as cairo is no longer used.

No functional change.

Change-Id: I7d7f207d604de8c8f9bbf1098b7ecb1f91fa5685
Reviewed-on: https://chromium-review.googlesource.com/755656Reviewed-by: danakj <danakj@chromium.org>
Commit-Queue: Michael Spang <spang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515042}

If exclude list parameter is provided during the registration process,
then all the devices are checked for duplicate registration by calling
'check-only' sign to device. If any one of the device response with
success, this means that there is duplicate registration and process is
terminated after waiting for user presence verification and response
code U2fReturnCode::CONDITIONS_NOT_SATISFIED is returned to the caller.
If all devices pass the duplication registration check, then we proceed
to normal registration process.

Bug: 664630
Change-Id: Iaa70490084c7086185e721b5e22d30f73ee9b66d
Reviewed-on: https://chromium-review.googlesource.com/739927
Commit-Queue: Jun Choi <hongjunchoi@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515041}

Implement Focusptions for focus() under a experimental flag.
FocusOptions has a boolean preventScroll (default false) to
prevent scrolling.

spec: https://html.spec.whatwg.org/multipage/interaction.html#focus-management-apis
web-platform-tests:
https://github.com/w3c/web-platform-tests/pull/7915
https://github.com/w3c/web-platform-tests/pull/7917

Intent to implement and ship:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/55sC81ciQgY

Bug: 734166
Change-Id: I47c1ebd9aebfc48064f9712d11c4d07ab8fabfa4
Reviewed-on: https://chromium-review.googlesource.com/731225Reviewed-by: Rick Byers <rbyers@chromium.org>
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
Commit-Queue: Ella Ge <eirage@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515040}

Plumb serialization/restore logic for the scroll anchor selector, offset, and
simhash.
Add declarations of SerializeAnchor, RestoreAnchor, and SerializedAnchor
struct.
Add dummy implementations of serialize/restore.
Add a runtime flag.

BUG=734679
R=skobes@chromium.org,creis@chromium.org

Change-Id: I68171d0ed3a63e44e4afc6ec8766170beb4508e0
Reviewed-on: https://chromium-review.googlesource.com/611058
Commit-Queue: Patrick Noland <pnoland@google.com>
Reviewed-by: Charlie Reis <creis@chromium.org>
Reviewed-by: Ojan Vafai <ojan@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Steve Kobes <skobes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515039}

Bug: 746953
Change-Id: I4de7e03f07fa19b0d7c136f2ca6021c8dd8cdd3d

TBR=dpranke@chromium.org

Change-Id: I4de7e03f07fa19b0d7c136f2ca6021c8dd8cdd3d
Reviewed-on: https://chromium-review.googlesource.com/755717
Commit-Queue: Mostyn Bramley-Moore <mostynb@vewd.com>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515038}

Migrate MessageLoop::ScopedNestableTaskAllower to RunLoop::Type::kNestableTasksAllowed in /ppapi/proxy

This pass focuses on ML::SNTA in same scope as an anonymous RunLoop().Run()
Scripted via a small tweak of https://bugs.chromium.org/p/chromium/issues/detail?id=781352#c1
which focused on RunLoops with a variable name.

The script should have replaced a MessageLoop::ScopedNestableTaskAllower
in the same scope as a RunLoop with a RunLoop of
Type::kNestableTasksAllowed. If there was a comment above the
MessageLoop::ScopedNestableTaskAllower, it should have been moved
alongside the augmented RunLoop.

Please CQ if LGTY

This CL was uploaded by git cl split.

R=piman@chromium.org

Bug: 781352
Change-Id: I3900a4cb18da2d78bf6815a582bc69460fe18423
Reviewed-on: https://chromium-review.googlesource.com/758659
Commit-Queue: Gabriel Charette <gab@chromium.org>
Commit-Queue: Antoine Labour <piman@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515037}

Originally reviewed on https://chromium-review.googlesource.com/740621

This is relanding plus fixing the racing documented in crbug.com/781349

BUG=744658,781349
TEST=bots
R=danakj@chromium.org,piman@chromium.org

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: If050057299a17ab76ee247c5c790a4e159ffef9d
Reviewed-on: https://chromium-review.googlesource.com/755520
Commit-Queue: Zhenyao Mo <zmo@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515036}

Currently there is logic which ensures the geolocation permission is
displayed in Site Details for the default search engine when the
location link is clicked from Settings>Search Engines. Since we've
enabled location consistency, this logic isn't needed as the location
setting will always be set and displayed appropriately.

Bug: 780344
Change-Id: Ie04f096194b4ee3ebd6ecb601db2fa8f744cb663
Tbr: finnur@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/758017
Commit-Queue: Raymes Khoury <raymes@chromium.org>
Reviewed-by: Ben Wells <benwells@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515035}

Bug: 774623
Change-Id: I45cfb7bbc9ce13a29dc084d86f9624f8a8744e49
Reviewed-on: https://chromium-review.googlesource.com/758613Reviewed-by: Joe Mason <joenotcharles@chromium.org>
Commit-Queue: Joe Mason <joenotcharles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515034}

We should not be updating the ChildFrameCompositingHelper's primary SurfaceInfo
unless some synchronized property has changed.

Updating the primary SurfaceInfo induces a commit when nothing might've changed.

Furthermore, Blink gets confused a change is triggered on scroll, and hits a
document lifecycle DCHECK. This CL addresses this by avoiding updating the
SurfaceLayer of the OOPIF/BrowserPlugin unless the size or ScreenInfo has
changed.


Bug: 672962
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I776990691beb2f58b0178c08da617b4bdb6df468
Reviewed-on: https://chromium-review.googlesource.com/759128
Commit-Queue: Fady Samuel <fsamuel@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515033}

When dragging one TabbedPane tab past another, we reorder the elements
in DOM, leading to a frame rendered without the ':hover' style and
flickering.

This CL ensures the hover-style is applied while dragging.

Screenshot: https://imgur.com/a/REtNp

Bug: 772298
Change-Id: Ib8a54cd6c6358d8d569aa94cf8e5c68aa2822037
Reviewed-on: https://chromium-review.googlesource.com/747079
Commit-Queue: Erik Luo <luoe@chromium.org>
Reviewed-by: Alexei Filippov <alph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515032}

r514562 disabled DeclarativeNetRequestBrowserTest.BlockRequests_UrlFilter on
windows debug bots since the test was flaky. It seems that the test was timing
out most of the times.

This CL splits out DeclarativeNetRequestBrowserTest.BlockRequests_Separator
from it, to decrease its running time and re-enables the test.

BUG=782326, 696822

Change-Id: I4932cd9be67cad267ffa085a38d0a551cc8702ab
Reviewed-on: https://chromium-review.googlesource.com/757830Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Commit-Queue: Karan Bhatia <karandeepb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515031}

This test is a fine subject matter for WPT.

Bug: 486308, 688116
Change-Id: I91d8484286094c695fe2219f0c017e25e8bfd34c
Reviewed-on: https://chromium-review.googlesource.com/759168Reviewed-by: Tsuyoshi Horo <horo@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515030}

Bug: 780828,734150
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I4c4bf7965c6420e3c3213982361296fe7861d61e
Reviewed-on: https://chromium-review.googlesource.com/756885Reviewed-by: Mike Baxley <baxley@chromium.org>
Commit-Queue: Menglu Huang <huangml@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515029}

The original CL caused mash_browser_test flake because the test was not
waiting for in-flight window bounds/visibility changes to apply, so
there was a race between browser, window server and ash.

Original CL description:
* Add a mojo shelf test API
* Convert 2 tests to use it

Bug: 781925, 678687
Test: browser_tests --mash
Change-Id: Icfe23d4c8c3bcd84bff8dc46d2c9680cc656ce50
Reviewed-on: https://chromium-review.googlesource.com/755344Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#514582}

TBR=tsepez@chromium.org

Change-Id: Icfe23d4c8c3bcd84bff8dc46d2c9680cc656ce50
Reviewed-on: https://chromium-review.googlesource.com/759034Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515028}

We should throw if 'only-if-cached' is specified as cache mode on a Request
whose mode is not 'same-origin'.

Bug: 453190
Change-Id: I751ae6e5c470c5404a2a7bde43e5aedb4059edc2
Reviewed-on: https://chromium-review.googlesource.com/758376
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Adam Rice <ricea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515027}

This CL introduces new calls to TopPresentedViewController() that will need to
be fixed in the future, but it is better to make this dependency explicit for
now.

BUG=754642

Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I62f2e6d1d11f7c77f78d10eefd347ff78f49069e
Reviewed-on: https://chromium-review.googlesource.com/758566
Commit-Queue: Rohit Rao (ping after 24h) <rohitrao@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515026}

Currently we log a specific deprecation warning for Flash media
requests. This isn't necessary when kUseFeaturePolicyForPermissions is
enabled because we log a warning as a part of the failed permission
request.

Bug: 689802
Change-Id: I4c332684ad61fa023136719e8461e4ef3bf4eade
Reviewed-on: https://chromium-review.googlesource.com/754462Reviewed-by: Timothy Loh <timloh@chromium.org>
Commit-Queue: Raymes Khoury <raymes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515025}

Apparently we had no test for centered alignment under these
circumstances, so adding one.

R=eae@chromium.org

Bug: 750553
Change-Id: I786a86371703f689783ca9ed4ab95fe8a692663a
Reviewed-on: https://chromium-review.googlesource.com/759300
Commit-Queue: Christian Biesinger <cbiesinger@chromium.org>
Commit-Queue: Emil A Eklund <eae@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515024}

Allows PostProcessors to optimize sound for stereo pairing.

Bug: b/69018076
Test: cast_audio_backend_unittests
Change-Id: I95c86b526092d05fab883d62eee75b887fa7cd7a
Reviewed-on: https://chromium-review.googlesource.com/757990Reviewed-by: Stephen Lanham <slan@chromium.org>
Commit-Queue: Benjamin Shaya <bshaya@google.com>
Cr-Commit-Position: refs/heads/master@{#515023}

(1) //third_party/cld2 is deleted since it contains all cld2 code.

(2) //third_party/cld is deleted since it contains the flag to switch
between cld2 and cld3.

(3) //chrome/test/data/cld2_component/ is deleted since cld2 is gone.

(4) chrome/browser/ui/webui/ records cld versions; and is now hard 
coded to be cld3; The related dependencies in DEPS and BUILD.gn 
are also deleted.  

(5) components/translate/core/language_dection/ uses cld, which is now
changed to cld3 for the head file and dependencies.
 
(6) components/translate/cotent/render has the decencies to cld2,
which I believe is unnecessary; So simply delete it.

(7) extensions/render/ uses cld, which is now changed to cld3 for the
head file and dependencies.

(8) cld2 related enum and uma histogram are also obsoleted.
 
(9) also changed other related dependencies.

Bug: 771778
Change-Id: Ice64df4d60087e41a97b152e88690402b501b99e
Reviewed-on: https://chromium-review.googlesource.com/734680Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Commit-Queue: Charles . <charleszhao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515022}

Bug: 782060
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I332131e580a564a95d67ae16ec7a6b8faf833f43
Reviewed-on: https://chromium-review.googlesource.com/757025Reviewed-by: Mike Baxley <baxley@chromium.org>
Commit-Queue: Menglu Huang <huangml@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515021}

This CL:
* Provides an interface in ChromotingClientRuntime to allow mobile client
  to fetch OAuth token from a centralized place.
* Provides iOS implementation for the OAuthTokenGetter.
* Passes the token getter to the transport context so that it can be used
  to fetch the ice config.

The centralized OAuthTokenGetter will be used for WebRTC protocol and
will also be used for telemetry logging. I'll send a follow up CL to
implement the OAuthTokenGetter for Android and refactor the auth logic
in telemetry logger.

Bug: 780736
Change-Id: I91b6f3dac8271e27b18854daddd52637a0a66add
Reviewed-on: https://chromium-review.googlesource.com/754410Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
Commit-Queue: Yuwei Huang <yuweih@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515020}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/4a2cb46cd601..1413d75bc715

$ git log 4a2cb46cd..1413d75bc --date=short --no-merges --format='%ad %ae %s'

Created with:
  roll-dep src/third_party/depot_tools


The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=phajdan.jr@chromium.org

Change-Id: I7f0de85ba46c1e8925796db399f3d58bafc89a82
Reviewed-on: https://chromium-review.googlesource.com/759224Reviewed-by: depot-tools-roller . <depot-tools-roller@chromium.org>
Commit-Queue: depot-tools-roller . <depot-tools-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515019}

This CL updates the Debian sysroot we use for CrOs bots to
Debian Stretch, and adds libva* packages. With that, the va-*
files in //media/gpu are added to the compilation. Those files
had a few style nits addressed in crrev.com/c/757742 that should
land first.

Bug: 782394
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I86e2ab11764a623c48113a161036bd494dbcf44c
Reviewed-on: https://chromium-review.googlesource.com/757069
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Kuang-che Wu <kcwu@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515018}

Split out the tested code into a static method.

BUG=782041

Change-Id: I24aafa02a7294b92253061280080c65a218c74cc
Reviewed-on: https://chromium-review.googlesource.com/757978Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515017}

https://skia.googlesource.com/skia.git/+log/9eccfff67472..065b41dd9078

$ git log 9eccfff67..065b41dd9 --date=short --no-merges --format='%ad %ae %s'
2017-11-08 egdaniel Revert "Prepare to enable explicit gpu resource allocation"
2017-11-08 stani Implement readPixels from float buffer, when half float is missing
2017-11-08 liyuqian Support toggling flags
2017-11-08 robertphillips Prepare to enable explicit gpu resource allocation
2017-11-08 reed change default props for PictureImage to be unknown_pixel_geometry
2017-11-08 brianosman Use ListBox for slide picker in Viewer
2017-11-08 caryclark move parts of SkPoint to SkPointPriv
2017-11-08 angle-deps-roller Roll skia/third_party/externals/angle2/ 8f8edd6ea..6db1c2e88 (1 commit)
2017-11-08 reed add surfaceprops param to SkCanvas::MakeRasterDirect
2017-11-08 brianosman In Viewer, use a GL window for Raster mode
2017-11-08 angle-deps-roller Roll skia/third_party/externals/angle2/ cda6af196..8f8edd6ea (1 commit)
2017-11-08 ethannicholas Revert "Revert "added a missing programBinarySupport check""
2017-11-07 bungeman Glyphs without paths don't draw with paths.
2017-11-07 bsalomon Allow mock GrContexts to "support" shader derivatives

Created with:
  roll-dep src/third_party/skia


The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=egdaniel@chromium.org

Change-Id: I59ef0b7b496ce44e0e8166e31455de0e86a7d23c
Reviewed-on: https://chromium-review.googlesource.com/759156
Commit-Queue: Ben Wagner <bungeman@chromium.org>
Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515016}

Windows needs the location in screen coordinates rather than DIP.

Also:

- Added a timeout to ui_controls::internal::SendMouseMoveImpl so that an
  error message is logged and the callback is run after
  TestTimeout::action_timeout(). This helps protect against cases where
  another window is on top of the test window, or the mouse is moved
  into la la land where Windows doesn't call the test's hook proc.

- New logging in the guts of ui_controls_internal_win.cc will emit error
  messages when the mouse ends up in the wrong place following a call to
  ui_controls::internal::SendMouseMoveImpl.

- SendMouseMoveUITest.Probe has been added to interactive_ui_tests to
  verify some simple calls to controls::SendMouseMoveNotifyWhenDone.

BUG=764415
R=sky@chromium.org

Change-Id: I27d6ffad59635913b28ae41e1410f4d6461d3355
Reviewed-on: https://chromium-review.googlesource.com/753905
Commit-Queue: Greg Thompson <grt@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515015}

v1 packaged apps are failing to respond to the "Close" option in their
shelf (task bar) item's context menu. The fix is to include unpinned
apps when looking for the shelf item, since we currently find the
shelf item from the app ID in order to find its windows and close them.

The comments and class names for launcher items aren't completely
accurate (see discussion in bug and review) but this is at least a
minor improvement.

Bug: 775416
Change-Id: I3e26a1cf5bf5f24d86d9e35379ce21ec677bc68a
Reviewed-on: https://chromium-review.googlesource.com/724274
Commit-Queue: Michael Giuffrida <michaelpg@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515014}

Previous bulk renaming left a few methods incorrectly named AxObject*
instead of AXObject*. While we're at it, rename
Document::AXObjectCache() to Document::GetOrCreateAXObjectCache() to
clarify that it may have side effects (and ExistingAXObjectCache may
be preferable).

Bug: None
Change-Id: Ibe3081d9577fdaf6958f33caa4094e91969660c7
Reviewed-on: https://chromium-review.googlesource.com/747815Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Aaron Leventhal <aleventhal@chromium.org>
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515013}

This mimics what we do on the native side. We simply copy the TW
res dirs to new HK dirs, which should have minimal effects on APK size
since the strings already exist in resources.arsc.

Bug: 780847
Change-Id: I474ee3ac4e270231ee5bea812c37e969b11a628b
Reviewed-on: https://chromium-review.googlesource.com/757185
Commit-Queue: Eric Stevenson <estevenson@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515012}