- 15 Jan, 2021 40 commits
-
-
Brandon Wylie authored
Bug: 1147581 Change-Id: I291f529cbb1686c6135791b99268f3cb310d4c98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587562Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Patrick Noland <pnoland@chromium.org> Commit-Queue: Brandon Wylie <wylieb@chromium.org> Cr-Commit-Position: refs/heads/master@{#844193}
-
Shuran Huang authored
Bug: 1136102 Change-Id: I6fe26dbf5f0c83672136aebe8f4a50846b4cc559 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633347Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Shuran Huang <shuuran@chromium.org> Cr-Commit-Position: refs/heads/master@{#844192}
-
David Tseng authored
In ChromeVox background page on startup via console: Error: Failed to load resource: net::ERR_FAILED From chrome-extension://invalid/ (repeated 43 times). The underlying sre_browser.js packed js script is making failed XMLHttpRequest calls, blocked by CORS policy. R=akihiroota@chromium.org Bug: none Change-Id: Id2d46ab3976dfc5b85d993403d587e85d4c66600 AX-Relnotes: n/a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632869Reviewed-by:
Akihiro Ota <akihiroota@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#844191}
-
Matt Giuca authored
Adds people who are now responsible for Desktop PWAs as the rightful owners, and a few other changes. Change-Id: I7e76fb4d5902ded0a2d422ede66f440c4db48a05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409894 Commit-Queue: Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Reviewed-by:
David Bienvenu <davidbienvenu@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Chase Phillips <cmp@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Auto-Submit: Matt Giuca <mgiuca@chromium.org> Cr-Commit-Position: refs/heads/master@{#844190}
-
Alison Maher authored
Update the stored type of inner multicols with pending OOFs added in CL:2612392 from NGBlockNode to LayoutBox*. This was requested as it makes converting NGBlockNode to a GarbageCollected class easier. Bug: 1079031 Change-Id: If2bf19de5774b7f003650b2c8f923cba4adfbe3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2630730 Commit-Queue: Alison Maher <almaher@microsoft.com> Reviewed-by:
Yuki Yamada <yukiy@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#844189}
-
Basia Zimirska authored
This CL fixes an issue with the UI not being updated after the profile loads and the policy becomes available. Now after a callback about profile creation is called, updating mic visibility is requested. Testing this change: I didn't test it end to end with my own policy server, I did it in a somewhat hacky way with a bool variable that was flipped in the callback to make sure that UI is updated. Bug: 1161022 Change-Id: I4fc8ab9067044b9198efaba0b94acf0199504492 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623164Reviewed-by:
Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Josh Simmons <jds@google.com> Commit-Queue: Basia Zimirska <basiaz@google.com> Cr-Commit-Position: refs/heads/master@{#844188}
-
Olivier Robin authored
Unittests rely on ScopedFeatureList which does not work because of these static values. Bug: 1166714 Change-Id: Ie3b0ff8beac1efa2398c68e77725ff69fce9cc2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627405 Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#844187}
-
David Black authored
Child bubbles have padding and child spacing such that there are gaps between holding space sections and child bubble edges as well as gaps between holding space sections within the same child bubble. Moving selection clearing to child bubbles instead of section views eliminates what the user might otherwise perceive as dead spots. Bug: 1167248 Change-Id: I561f2862258189fa9960d6c25de7bd6da124771a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632808Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#844186}
-
Yue Zhang authored
TBR: yusufo@chromium.org Bug: 1157892 Change-Id: I6199dacb72f3e9e9133d28115a7a621a8c0297fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613954Reviewed-by:
Yue Zhang <yuezhanggg@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Cr-Commit-Position: refs/heads/master@{#844185}
-
Jonathan Wright authored
BoringSSL recently added Neon and hardware crypto optimization support for the Windows on Arm (WoA) platform. Enable use of these optimized functions in the Chromium BoringSSL BUILD.gn file. Change-Id: Ic5229f73f3a52bdb291f68819f4cb6862e1c4798 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632753Reviewed-by:
David Benjamin <davidben@chromium.org> Commit-Queue: David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#844184}
-
Renjie Tang authored
Change-Id: I5fbffa18e477d5e24fe3a772f1ed97f92d9b985e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2573678 Commit-Queue: Renjie Tang <renjietang@chromium.org> Reviewed-by:
David Schinazi <dschinazi@chromium.org> Cr-Commit-Position: refs/heads/master@{#844183}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/goldctl-mac-chromium-autoroll Please CC bsheedy@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: bsheedy@chromium.org Change-Id: I445ae1f4b5cb389bb1280fda96dd53400aa53633 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633444Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#844182}
-
Toby Huang authored
This CL removes dead code related to legacy supervised users and renames TODO(crbug/866790) to TODO(crbug/1155729), which is the main bug for tracking legacy supervised user code removal. Bug: 866790 Change-Id: I7ece1ef3e9f4dd548d8f3387d98082f490030d12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626194Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Dan S <danan@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Dan S <danan@chromium.org> Auto-Submit: Toby Huang <tobyhuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#844181}
-
Yuke Liao authored
This reverts commit e2f3b551. Reason for revert: Breaks local user flow when entering chrome_sdk ERROR at //build/config/chromeos/rules.gni:180:11: Undefined identifier. _symlink_targets[2], ^----------------- See //chromeos/BUILD.gn:239:3: whence it was called. generate_runner_script("cros_test_wrapper") { ^-------------------------------------------- See //BUILD.gn:442:7: which caused the file to be included. "//chromeos:chromeos_unittests", Original change's description: > Lacros: create lacros tast test targets > > This CL creates gn targets for lacros tast tests, and the main > motivation is to run lacros tast tests on Chromium CI. > > Bug: 1158590 > Change-Id: I783779c3386a39743b8227367189b0b87832b9dc > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606188 > Commit-Queue: Yuke Liao <liaoyuke@chromium.org> > Reviewed-by: Ben Pastene <bpastene@chromium.org> > Reviewed-by: Dirk Pranke <dpranke@google.com> > Cr-Commit-Position: refs/heads/master@{#844127} TBR=dpranke@google.com,liaoyuke@chromium.org,bpastene@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: I1e51bf2e6aa97bfc40beba7d2693b68361cab2bc No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1158590 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633782Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#844180}
-
Yue Zhang authored
Instead of using one boolean value in profile pref to record dismiss/restore state of cart module, this CL introduces two boolean values to record whether the module is temporarily hidden or permanently removed. Bug: 1157892 Change-Id: I01d95a62fca6466ab893c7be8afbc20b5065ddf6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625816Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
-
Victor Costan authored
Moving features to the Storage Service requires the ability to talk to the Quota system via mojo. storage::QuotaClient is one of the interfaces that needs to be mojofied. Migrating all QuotaClient usage to mojo in one CL is risky, because this CL would introduce timing changes to 7 storage systems (AppCache, Cache Storage, File System, IndexedDB, NativeIO, Service Workers, WebSQL). Therefore, QuotaClient will be migrated piece by piece. This CL introduces the storage::mojom::QuotaClient interface, and integrates it with QuotaManager. To facilitate a gradual migration, QuotaManager will support both mojofied and non-mojofied QuotaClients. QuotaManager tests will cover both types of clients, to ensure correct operation throughout the migration. Other tests that integrate with QuotaManager will use mojofied clients, because this reduces future churn. To maximize test coverage, QuotaManager's support for mojofied QuotaClients is written on top of the support for non-mojofied QuotaClients. This CL also adds TODOs documenting the cleanup that will be required once all QuotaClients are mojofied. Bug: 1016065 Change-Id: I6df5a97763447e41eb3b523e180a6c13dfa3199c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610633 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Reviewed-by:
Matthew Denton <mpdenton@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#844178}
-
Dave Tapuska authored
Move GetPluginInfo to be a method on the PepperHost mojom object. This code path is used for content layer (content shell is one example) to load plugins. (chrome embedders use a ContentClient override). Remove the now useless RenderFrameMessageFilter. BUG=1157519 Change-Id: I0c1e4c74b86351169637b72c4224c9000ca70945 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2630545 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Bill Budge <bbudge@chromium.org> Cr-Commit-Position: refs/heads/master@{#844177}
-
Etienne Bergeron authored
These histograms are no longer used. The timing and count information is already available into RenderText for every platforms. There is no need to have a windows specific histograms. R=robliao@chromium.org Bug: 1151976 Change-Id: I0c90c44ace8f6607a55112a117a75cdd5b4eb20f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611585Reviewed-by:
Robert Liao <robliao@chromium.org> Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Cr-Commit-Position: refs/heads/master@{#844176}
-
Moe Ahmadi authored
This is a useful metric to monitor the adoption of the promo browser commands. Fixed: 1165094 Change-Id: I2df2e242cc072eb5ee74716a029eae111373584b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632065Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#844175}
-
Mike Dougherty authored
Bug: 1164846 Change-Id: I975c02ac34bb4e37a06ae7759eaffb7984f95065 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628024Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Chris Thompson <cthomp@chromium.org> Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#844174}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/goldctl-linux-chromium-autoroll Please CC bsheedy@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: bsheedy@chromium.org Change-Id: Icc88c13289498fcfcc2c39167d5c81552bb2c8db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633171Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/3100aca993ac..1502a9ec072f 2021-01-15 vidorteg@microsoft.com [Loc] Migrate event_listener pane to Localization V2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1136655 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Id2a9e3e8dfd61dd665a51c036a2f1ed4dae1f602 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633134Reviewed-by:
-
Andy Paicu authored
Bug: 1138595 Change-Id: I7b5ab3739842122e5b71f208b4e0bb237636ee3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2624608 Commit-Queue: Andy Paicu <andypaicu@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#844171}
-
Ross McIlroy authored
BUG=v8:9684 Change-Id: I724817e74370ecb3ef2f931fc16dc2324bd73629 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632612 Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> Auto-Submit: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#844170}
-
Ella Ge authored
Bug: 1155353 Change-Id: I1057fa0184ac79b6b28f1f0a863d6d630dc3f816 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2630068Reviewed-by:
Peter Conn <peconn@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#844169}
-
Fabrice de Gans-Riberi authored
The test is flaky. TBR=atwilson@chromium.org Bug: 1167239 Change-Id: I44c744fb99848edb28f63821e899b93e2993e41d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633093Reviewed-by:
Fabrice de Gans-Riberi <fdegans@chromium.org> Reviewed-by:
Yi Gu <yigu@chromium.org> Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Cr-Commit-Position: refs/heads/master@{#844168}
-
Brian Ho authored
A page flip can result in a SWAP_NAK_RECREATE_BUFFERS signal, indicating that the backing buffers must be recreated. Since the buffers are entirely uninitialized, we should damage the entire screen for the next draw [1]. Unfortunately, this doesn't work in SkiaRenderer because the GPU thread performs the actual reallocation [2] and then posts a task to the Viz thread to update the damage. The task taces with the next invocation of DirectRenderer::DrawFrame, so there's no guarantee that the new damage will be picked up in time for the next frame. If it isn't, we will present a buffer with uninitialized data. This CL fixes this issue by pausing SwapBuffer invocations after reallocating buffers until we receive a frame with full screen damage (e.g. the Viz thread catches up with the GPU thread). [1] https://source.chromium.org/chromium/chromium/src/+/master:components/viz/service/display_embedder/gl_output_surface_buffer_queue.cc;l=263;drc=3c0194e7917daed5debe0d0772393e5784367e01 [2] https://source.chromium.org/chromium/chromium/src/+/master:components/viz/service/display_embedder/skia_output_device_buffer_queue.cc;l=458;drc=7ccffaf0933ccc647c744bf66971bcf5f33a676a Bug: 1156182 Change-Id: Ibf0bf3d6903c4c4f2dadcfc71dfda36a03b513d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2630227Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Commit-Queue: Brian Ho <hob@chromium.org> Cr-Commit-Position: refs/heads/master@{#844167}
-
Collin Baker authored
Ensures subscribers know when a thumbnail is cleared, and avoids sending them stale thumbnails from previous requests. Fixed: 1163121 Change-Id: I31d881808fb2a6bb14ae20b7d5b2d67545b585c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628031Reviewed-by:
Dana Fried <dfried@chromium.org> Commit-Queue: Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#844166}
-
Garrett Beaty authored
Bug: 1167232 Change-Id: I04177bb8c4cc7f0c31f8fe2a549f0ce837529b81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633094Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Cr-Commit-Position: refs/heads/master@{#844165}
-
Michael Crouse authored
This fixes some path and test data issues that cause tests to fail when enabling TFLite in the build. This also creates a TFLite resolver for Chrome with the set of ops to be supported initially. Bug: 1165517 Change-Id: Ib0acdcb380578e94f4b7172b5ebe27ab6faafc25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631186Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Sophie Chang <sophiechang@chromium.org> Commit-Queue: Michael Crouse <mcrouse@chromium.org> Cr-Commit-Position: refs/heads/master@{#844164}
-
Rakib M. Hasan authored
Adding this command line argument fixes an issue with tests running on Android M x86 emulator builders. The issue is that the emulator fails to reboot after disabling boot verification. Bug: 1114563, 1165307 Change-Id: Iab36b6c2c2ec3766e259fc1cfaa4c25fdc4fbb7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631159Reviewed-by:
-
Fabrice de Gans-Riberi authored
The test is flaky. TBR=achuith@chromium.org Bug: 1167243 Change-Id: I40dae90f9e18013b673c4a5188500bacf2d79c3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633095 Auto-Submit: Fabrice de Gans-Riberi <fdegans@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/5a6fda1a6fcc..54449966dd2e 2021-01-15 senorblanco@chromium.org Workaround ANGLE hang with a glFlush(). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC dsinclair@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: dsinclair@google.com Change-Id: Ic7ea8a8acc69373179e51e8b41a5b8b8a6204b93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633661Reviewed-by:
-
Caitlin Fischer authored
The server-side config shows that this on only old versions of Chrome. Plus, as of [1] the feature is enabled on TOT for desktop. [1] crrev.com/c/2063530 Bug: 1126640 Change-Id: I17afe09c1da894411f66ef7791a1c1edc441d00a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632126 Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#844160}
-
philipel authored
Bug: webrtc:12271 Change-Id: I343ab2a1a6ff4d7740e0074d008382b4d45b9580 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631266Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Philip Eliasson <philipel@chromium.org> Cr-Commit-Position: refs/heads/master@{#844159}
-
Fabrice de Gans-Riberi authored
The test is failing flakily TBR=mlamouri@chromium.org Bug: 1167236 Change-Id: I9091e1fa70540e2967c71c8cdd22a2aec343c8f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632806Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Auto-Submit: Fabrice de Gans-Riberi <fdegans@chromium.org> Cr-Commit-Position: refs/heads/master@{#844158}
-
Matthew Mourgos authored
This change updates the position of the clipboard nudge when the shelf is set to auto-hide. Also updates position for the case when side shelf is set to left or right. Bug: 1165974 Change-Id: Ib44089b2a8df58e12c4dd54c23aa21b17a374d3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628737 Commit-Queue: Matthew Mourgos <mmourgos@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#844157}
-
Joe DeBlasio authored
This CL expands the list of common words ignored by target embedding to the full list from //components/url_formatter/spoof_checks/common_words. It also removes words that are on that list from the existing list of common words (which is maintained as a supplemental list). This CL also adds a little bit of logic to disable common word detection on domains that are in the special list of domains that are allowed to be embedded, but only at the end (domains that are higher-value that use common word). This is necessary since, e.g., "office" is a common word on the full common word list, but not in the old list. A side effect of this change is that the common word list is included in Android. This list causes a big bump in binary size. A future edit may reduce the size of the word list used for Android, but that'll be a substantial engineering effort, and this list is an important mitigation in a security feature. The list is efficiently stored as a DAFSA, so I know of no obvious way to shrink it down. Binary-Size: Size increase is unavoidable (see above). Bug: 1154726 Change-Id: I417d92761377f6b6e11772b8f06c9b36b5083676 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2630738 Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#844156}
-
Angus L. M. McLean IV authored
Bug: 760279 Change-Id: I122f307af8047932ee593e8f4baccd5591d74ad4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622767Reviewed-by:
Ahmed Mehfooz <amehfooz@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Angus McLean <angusmclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#844155}
-
arthursonzogni authored
The culprit has been reverted: https://chromium-review.googlesource.com/c/chromium/src/+/2625867 and we verified the crashed were gone. R=danakj@chromium.org Bug: 1153966,1153961 Change-Id: Ic99bbed56808188c92a34b8761e43b5621cf9e0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632988Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Auto-Submit: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#844154}
-
