- 13 Mar, 2018 40 commits
-
-
Patrick Monette authored
This is made possible now that the MTA is initialized on every sequenced task runner of the Task Scheduler. It also fixes the possible hangs on the UI thread when the automation thread was joined on destruction. Bug: 819789 Change-Id: I8964275d97c3302eaa7888e9c827d5e954c2b9eb Reviewed-on: https://chromium-review.googlesource.com/955673 Commit-Queue: Patrick Monette <pmonette@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#542838}
-
Luna Lu authored
1. Without specifying allow attribute, frame policy inherits correctly. 2. With allow attribute, frame policy inherits from and overrides header policy correctly. Updating allowfullscreen and allowpaymentrequest correctly updates frame policy. 3. Frame policy is not affected by the frame's document policy. Bug: 732003 Change-Id: Ib41f883a779f11c564c91cfc03ff1224330108f5 Reviewed-on: https://chromium-review.googlesource.com/850896 Commit-Queue: Luna Lu <loonybear@chromium.org> Reviewed-by:
Ian Clelland <iclelland@chromium.org> Cr-Commit-Position: refs/heads/master@{#542837}
-
https://webrtc.googlesource.com/src.git/+log/4160441178a0..313385726692 $ git log 416044117..313385726 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: If8b248617e9a6df50f524b12caf5deedc1173fa0 Reviewed-on: https://chromium-review.googlesource.com/960579Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#542836}
-
Charles Harrison authored
This partially fixes breakage to gmail, which wants to redirect mail.google.com -> accounts.google.com for auto-logout. See the design doc for relaxing tab-under protection: https://docs.google.com/document/d/1N-0etmATN6PhQt-m9S8sCgfz88zv8lZ2dBFdqKlzsPg/edit?ts=5aa2f94e# It feels like this change is the least controversial and it won't reduce the efficacy of the intervention. Bug: 661629 Change-Id: I01c7435a12515aacf011a722ee155d60cb1d6bae Reviewed-on: https://chromium-review.googlesource.com/959689 Commit-Queue: Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#542835}
-
bsheedy authored
Adds VrShellControllerInputTest#testControllerScrollingNative, which ensures that scrolling via the Daydream controller works on the chrome://history NativePage. Bug: 737168 Change-Id: Idfa83286ee56a4c245634e64dc3d80a3ef0a8d43 Reviewed-on: https://chromium-review.googlesource.com/959609 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#542834}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/70196515..5018e7b8 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: Id0cf0686f7d71ba052c65417ce3ace164abe6ea8 Reviewed-on: https://chromium-review.googlesource.com/960588Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#542833}
-
David Jacobo authored
The bookmark star was for many years the rightmost icon and still is on !CrOS. We mistakenly added the intent picker icon on its right, besides fixing that, reevaluating the order of the first 4 icons. More precisely, this CL rearranges the first 4 rightmost icons in this order (rightmost first): - bookmarks icon - zoom icon - find icon - intent picker icon Bug: None. Test: Build, manual test. Change-Id: I5676a9550dbf383a446a19854a3b810bf961fc2b Reviewed-on: https://chromium-review.googlesource.com/958085Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: David Jacobo <djacobo@chromium.org> Cr-Commit-Position: refs/heads/master@{#542832}
-
Sammie Quon authored
Bug: none Test: ash_unittest WindowSelectorTest.* Change-Id: I81ecfd00386944e3cf285909cca847581643c377 Reviewed-on: https://chromium-review.googlesource.com/949610 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#542831}
-
Mike Reed authored
Strict refactoring change: just renaming existing calls. TBR= Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I725ab3b4e83a2eb218cd90217a19d68947cc05d6 Reviewed-on: https://chromium-review.googlesource.com/960569 Commit-Queue: Mike Reed <reed@chromium.org> Reviewed-by:
Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/master@{#542830}
-
Sorin Jianu authored
The header names have been changed, we need to make a string substitution t o update them: X-GoogleUpdate-Interactivity -> X-Goog-Update-Interactivity X-GoogleUpdate-AppId -> X-Goog-Update-AppId X-GoogleUpdate-Updater -> X-Goog-Update-Updater Bug: 647516 Change-Id: I147ca276837ece5e9e8c28aa3a871b5ac5cae3b5 Reviewed-on: https://chromium-review.googlesource.com/959555Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#542829}
-
Antonio Gomes authored
Code in //ui/ozone/platform/wayland/fake_server.cc|h is quite convoluted today. This a 2/n of a seriee of patches that clean it up. CL adds a SetImplementation templatized function to be used instead of using wl_resource_set_implementation directly. BUG=None R=rjkroege@chromium.org Change-Id: I802c0b1ddbe68dd98da225eb5d4e04da2ab6b2e0 Reviewed-on: https://chromium-review.googlesource.com/960521 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Cr-Commit-Position: refs/heads/master@{#542828}
-
https://pdfium.googlesource.com/pdfium.git/+log/0c6b98182403..7a1aa5f65911 $ git log 0c6b98182..7a1aa5f65 --date=short --no-merges --format='%ad %ae %s' 2018-03-13 rharrison Remove usage of FXSYS_*ASCIIlower/upper methods Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I56e6faeee8bcd020a1a94a6d592305d59ba268e8 Reviewed-on: https://chromium-review.googlesource.com/960589Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#542827}
-
edchin authored
These tests have been failing on these device bots: (iPad Air iOS 10.3.3) on iOS-10.3.3 (iPhone 6s iOS 10.3.3) on iOS-10.3.3 Since March 7, revision: 1cbfed836fceb54df561b43e7cd8e5d65ea41137 TBR=huangml Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I69616206990b473a3ea828136e87166a11308950 Reviewed-on: https://chromium-review.googlesource.com/960842 Commit-Queue: edchin <edchin@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#542826}
-
Ted Choc authored
BUG= Change-Id: I85bc675f3b14b27ecbf6b63a46f2876b72a7fbe1 Reviewed-on: https://chromium-review.googlesource.com/953371 Commit-Queue: Ted Choc <tedchoc@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#542825}
-
https://skia.googlesource.com/skia.git/+log/4ce53a6ffd3c..fd6ed022db18 $ git log 4ce53a6ff..fd6ed022d --date=short --no-merges --format='%ad %ae %s' 2018-03-13 angle-skia-autoroll Roll skia/third_party/externals/angle2/ 64e5ed2ab..f0b30dd8b (2 commits) 2018-03-13 caryclark protect SkPathMeasure against NaN 2018-03-13 brianosman Revert "Reland "Add SkColorSpaceXform_skcms"" 2018-03-13 brianosman Reland "Add SkColorSpaceXform_skcms" 2018-03-13 bsalomon Remove yoda rule from style guide 2018-03-12 caryclark fix a couple pathops fuzzers Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=stephana@chromium.org Change-Id: I6d6d5b9d346d52cc71ed32ec3c90928243b54f62 Reviewed-on: https://chromium-review.googlesource.com/960563Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#542824}
-
Eric Karl authored
Currently, Android supports --enable-low-end-device-mode, but requires that the flag be set/visible to Java. This limits the usefulness, as we can't apply this flag via C++ in test scenarios. This change modifies SysInfo::IsLowEndDevice to behave like SysInfo::AmountOfAvailablePhysicalMemory in its handling of flags: flags are checked / applied in platform-independent C++ before forwarding to a platform-specific impl function in the case that the default behavior was not overridden. Change-Id: Ic2952ed5d2eb199f4daaa60aa2f1eb6dad87d205 Reviewed-on: https://chromium-review.googlesource.com/959301Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#542823}
-
Fredrik Söderquist authored
This CL transitions the ReferenceFilterOperation (used for 'filter') from SVGElementProxy to SVGResource. It introduces ExternalSVGResource as a new subclass of SVGResource. ExternalSVGResource handles loading of an external document, and notifies clients as needed when said document finishes loading. Since this leaves SVGElementProxy unused, it is removed together with some related structures. This also allows some code to be simplified because we no longer need a TreeScope (or Node) in some places. Bug: 769774 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: If6cbbf32e0269878bdea897fcf0b8e41c062b0f6 Reviewed-on: https://chromium-review.googlesource.com/955684Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#542822}
-
Nektarios Paisios authored
Will be used by AXSelectionBehavior in an upcoming patch which will determine if setting the selection on an AXRange that corresponds to an invalid DOM range should extend or shrink the range. R=dmazzoni@chromium.org Change-Id: I04d2e5aeb747aafb6e6f88e7fc5bd9304ba50d63 Reviewed-on: https://chromium-review.googlesource.com/952484 Commit-Queue: Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#542821}
-
edchin authored
This CL configures the tab grid toolbars for the current size class. For example, a portrait phone will have a bottom toolbar whereas an iPad will have a FAB. This CL configures based on size classes, not device idioms. Bug: 804499 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I56cb26e43f92ee6152bd5b1e1d747bafbc052880 Reviewed-on: https://chromium-review.googlesource.com/959921 Commit-Queue: edchin <edchin@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
-
Albert Chaulk authored
This will be required for some extensions to run Bug: b/74441258, b/73383411 Test: load local content script, verify it prints to console Change-Id: Ia2499c789a263c7a589c6a9dcc519495879d48e7 Reviewed-on: https://chromium-review.googlesource.com/957647Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: Albert Chaulk <achaulk@chromium.org> Cr-Commit-Position: refs/heads/master@{#542819}
-
rodmartin authored
Bugs: 820546, 820554, 821063 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I0022b28d5b3289e9b87f2f06498cbd03212d19c4 Reviewed-on: https://chromium-review.googlesource.com/929754Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Dave Schuyler <dschuyler@chromium.org> Reviewed-by:
Georges Khalil <georgesak@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: Martin Rodriguez <rodmartin@google.com> Cr-Commit-Position: refs/heads/master@{#542818}
-
stkhapugin@chromium.org authored
CL 905511 introduced a bug where previously BVC was defocusing the omnibox by sending selectedTabChanged to the toolbar, but this was broken. Since the location bar now directly observes the webstate with its mediator, use this to defocus omnibox when the webstate changes. Bug: 813944 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ibc67faaae115032e0a3c6e6b5e3879d7e52f8f0f Reviewed-on: https://chromium-review.googlesource.com/960663Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#542817}
-
Ian Clelland authored
The renderer feature was removed in https://crrev.com/86dad9f3, except for the linkage between browser and renderer in c/c/runtime_features.cc. This CL removes that link, as well as the base::Feature for the removed feature, and the entry in chrome://flags. Bug: 704650 Change-Id: Iddf4038c7c2f4c8d7a45770262b977d78996b696 Reviewed-on: https://chromium-review.googlesource.com/957478Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Ian Clelland <iclelland@chromium.org> Cr-Commit-Position: refs/heads/master@{#542816}
-
https://webrtc.googlesource.com/src.git/+log/e61bf67b99a9..4160441178a0 $ git log e61bf67b9..416044117 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: If63b7a76fff3b1bf83ba302a1191e20005fdafb9 Reviewed-on: https://chromium-review.googlesource.com/960622Reviewed-by:
-
jonross authored
There are a series of tests currently flaking on Windows with timeouts, and no errors. This change disables them via the Viz filter. TBR=kylechar@chromium.org TEST=viz_browser_tests Bug: 794961 Change-Id: I4f2bfabc461f78cd9d187b610472c396d3c91a0b Reviewed-on: https://chromium-review.googlesource.com/960576Reviewed-by:
Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#542814}
-
Peter Kotwicz authored
According to the docs (https://developer.android.com/reference/android/content/pm/ShortcutManager.html) ShortcutManager#requestPinShortcut() throws an IllegalStateException if "The caller doesn't have a foreground activity or a foreground service, or the device is locked." We create a home screen shortcut if WebAPK install fails. WebAPK installs time out and fail out after 3 minutes. A user may be using a different app by the time that the time out occurs. This CL catches and ignores IllegalStateExceptions thrown by ShortcutHelper#requestPinShortcut() Bug=819725 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Iceab1a25a0d80b9869cfc523f091c3af8e590a76 Reviewed-on: https://chromium-review.googlesource.com/959751 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#542813}
-
Taylor Brandstetter authored
Bug: chromium:820806 Change-Id: I36340c31ee6c5c88a4049d346ed9af9dbff43392 Reviewed-on: https://chromium-review.googlesource.com/959525Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#542812}
-
Eugene But authored
This adds Drive icon below "Download state" icon. UI Mocks: https://docs.google.com/presentation/d/1GzbAoJrpW9IAQF78afh5SZLWJWErNcC67t_ctujjEus/edit#slide=id.g2f6fee2339_3_0 Bug: 791806 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Id0405502a338aacfe4c2de331adbca89f1fe747e Reviewed-on: https://chromium-review.googlesource.com/956700 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#542811}
-
Luna Lu authored
Bug: 821455 Change-Id: I49c24c67d5eec2672829ceb9eeaa5f63019d20a3 Reviewed-on: https://chromium-review.googlesource.com/960572 Commit-Queue: Luna Lu <loonybear@chromium.org> Reviewed-by:
Luna Lu <loonybear@chromium.org> Cr-Commit-Position: refs/heads/master@{#542810}
-
Scott Violet authored
EventRewriters don't honor the target, and so generally expect the root_location and location to be the same. This patch changes EventSource::SendEventToSink() to create a new Event if the existing has differing locations (and a target). BUG=817112 TEST=covered by tests Change-Id: I29f9cafe962194938c8e457aabc3a5ce6b379649 Reviewed-on: https://chromium-review.googlesource.com/959803Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#542809}
-
Luna Lu authored
This reverts commit cadbec0d. Reason for revert: <INSERT REASONING HERE> Original change's description: > Revert "Reland "Add Finch feature to gate Enterprise Password Protection"" > > This reverts commit fb1f63f0. > > Reason for revert: Suspect breaking the build https://ci.chromium.org/buildbot/chromium/Linux%20x64/60367 > > Original change's description: > > Reland "Add Finch feature to gate Enterprise Password Protection" > > > > This is a reland of 063960e4 > > > > Original change's description: > > > Add Finch feature to gate Enterprise Password Protection > > > > > > Also added finch experiment to fieldtrial_testing_config.json > > > > > > Bug: 804490,818559 > > > Change-Id: I70b0bfdaf7d59ca91f27d634363221b5f3cdb403 > > > Reviewed-on: https://chromium-review.googlesource.com/942308 > > > Commit-Queue: Jialiu Lin <jialiul@chromium.org> > > > Reviewed-by: Luke Z <lpz@chromium.org> > > > Reviewed-by: Gayane Petrosyan <gayane@chromium.org> > > > Reviewed-by: Vadym Doroshenko <dvadym@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#542502} > > > > TBR=lpz@chromium.org, dvadym@chromium.org, gayane@chromium.org > > > > Bug: 818559 > > Change-Id: Ia7e8378b28255a61a70e65e89b50912bda5b8e7f > > Reviewed-on: https://chromium-review.googlesource.com/960221 > > Commit-Queue: Jialiu Lin <jialiul@chromium.org> > > Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org> > > Reviewed-by: Vadym Doroshenko <dvadym@chromium.org> > > Reviewed-by: Jialiu Lin <jialiul@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#542786} > > TBR=pastarmovj@chromium.org,gayane@chromium.org,dvadym@chromium.org,jialiul@chromium.org,lpz@chromium.org > > Change-Id: Ie78ca40253f255e5893f108c8ddc4178514a0f50 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 818559 > Reviewed-on: https://chromium-review.googlesource.com/960641 > Reviewed-by: Luna Lu <loonybear@chromium.org> > Commit-Queue: Luna Lu <loonybear@chromium.org> > Cr-Commit-Position: refs/heads/master@{#542791} TBR=pastarmovj@chromium.org,gayane@chromium.org,dvadym@chromium.org,jialiul@chromium.org,lpz@chromium.org,loonybear@chromium.org Change-Id: I284f008a5a7378c34c7412c124cddf26b404d6c2 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 818559 Reviewed-on: https://chromium-review.googlesource.com/960642Reviewed-by:
-
Joshua Peraza authored
14dbd3531d98 gn win: Get main test binaries building 6cf4f928eb08 gn win: Add auxiliary test binaries used by end_to_end_test.py 36679d572ba0 win: Don't assume offsets the same when kDoesNotObserveDaylightSavingTime 9ab4fbf1e1a7 win: Improve child crash location test 798f6540435f gn win: Use new toolchain names to support both x86 and x64 83a83c5b0050 Roll mini_chromium to e7e8237 a483e2c599b8 Fix names of Windows trybots after server-side rename 38b20ca57efc Relocate CaptureContext to misc and implement on Linux a8ad3bdbdfb1 linux: fix incorrect fallthrough 73e862e15a6c fuchsia: Exclude capture_context_test.cc from test build b83f4c731d8f Let UUID::InitializeFromString accept StringPiece16 too f878f155172b fuchsia: Add flock() stub to get test binaries linking again e5bbdaff87a9 Pass FilePath to Settings in Initialize() c45ba7920e01 Make NewReport objects own their associated database resources 7d5487fc44b3 minidump: add switch cases to handle linux/android and ARM c406797ce620 Add UploadReport to manage database resources during upload 7faa2ef89872 Get CrashpadInfo address via a .note, rather than dynamic symtab 8d0d999d9245 Add a cross-platform database implementation b43858c9903f fuchsia: Start of ModuleSnapshot and ProcessReader implementations 6667fa25595a fuchsia: Fixes to TestPaths 90cde8e30f7d Disable upload on Android 4094c2628d33 Address review comments for 8d0d999 a4d7fb4cc390 Use .long for pointers on 32-bit platforms 5e5b927b38ca Build crashpad_client_linux.cc on Android eec1e17ab558 Fix two bugs in memset()ing CrashpadInfo on size mismatch 4717300fa4ce Reset CrashpadInfo after CrashpadInfoReader tests f9d160ffc6bb Revert "Reset CrashpadInfo after CrashpadInfoReader tests" 6798ba912e96 Reset CrashpadInfo after CrashpadInfoReader tests 0429216f59b1 linux: Add CrashReportExceptionHandler f38af628c9dc fuchsia: Don't fail rename if source == dest 040360239343 Fix CrashpadInfoSizes_ClientOptions/CrashpadInfoSizes_ClientOpt ions 10222b12362c fuchsia: Disable TimeZone.Basic test as timezones are non- functional 5cb869392eed fuchsia: Compile out LoggingLock/UnlockFile, add DCHECKs to Settings 4b7895615808 Add .hidden to CRASHPAD_NOTE_REFERENCE 8ee14eef08f3 fuchsia: Fix some packaging when run isn't from Crashpad source root 4a9d422652a1 Turn fuchsia trybots on by default ec33c25797f9 fuchsia: Don't include sys/resource.h, recently removed from SDK 8b738cd24d59 Don't include crash_report_database_generic.cc on Win/Mac d2a866978b89 Makes 'all' build on Linux d8d03172c278 arm: Capture context around pc and registers ebad8bd925c3 Don't spawn an upload thread if url is empty 0520fdff1edc linux: Move ScopedPrSetPtracer to util/ 38540eaf71cb Add handler options for Linux/Android 01105719d767 linux: add CRASHPAD_SIMULATE_CRASH() 3dd85dc12638 fuchsia: Make ImageAnnotationReader[Test] work cab259330f2e fuchsia: Pass more data out of module snapshot 1aae5cedaf1e Refactor ModuleSnapshot(Linux|Fuchsia) into ModuleSnapshotElf 4d96e4e504ef fuchsia: Return ModuleSnapshot* out of ProcessSnapshotFuchsia 2290a826af1e Pull (most) platform-specific MemorySnapshots out 3030ae54171a fuchsia: Fix ninja auto-regen after run 61f1013ee4ef fuchsia: Add some thread reading to ProcessReader and a test c69ba3d52783 non-win: Add Multiprocess::SetExpectedChildTerminationBuiltinTrap() f130822b9f4b linux: Add CrashpadClient tests 2b05eb522fa4 Rename ProcessReader to platform-suffixed versions fa2a03fbdd0f linux: Add CrashpadClient::SetFirstChanceExceptionHandler() cd3afe616e63 Linux: Pull and use clang toolchain in third_party 8e80a575d15f Linux: Pull a sysroot if pulling a local clang fae18c2fc492 fuchsia: Add implementation of ThreadSnapshot a869ae18d256 Workaround for death test failure when in threadsafe mode on Mac 8a12f5893050 fuchsia: Take bots off CQ pending flake investigation 9affa2a0e72d Optionally stub out the libcurl-based implementation of HTTPTransport dec23bef5769 win gn: reintroduce flags to disable warnings 746ce1a63703 Roll mini_chromium to 987bde8 493e29bc3df0 win: Use correct format specifier a45e88602b90 Skip ELF notes with a p_vaddr of zero 71d90608828d Add Linux trybots to CQ 449506d59c6a Roll mini_chromium to ef0df11 82777cff5848 win: fix warnings when building with clang 23b2156fb694 Don’t read beyond a StringPiece’s bounds in StringToNumber() 4375233ad2da win: fix 64-bit build 8175825f45fd win: use version.lib instead of mincore.lib 07da37aec70e win: fix crashy test program c27a1aaea086 win: Fix -Wmicrosoft-cast warning Also, Add new metrics enums values. Use the new CrashReportDatabase interface. Bug: crashpad:30 Change-Id: I36a6469046983c6ffdb1512436a915ee1a7bb49d Reviewed-on: https://chromium-review.googlesource.com/959764 Commit-Queue: Joshua Peraza <jperaza@chromium.org> Reviewed-by:Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#542807}
-
Abhishek Arya authored
std::string is null-terminated and can hide some overflow bugs. Use base::StringPieceInput instead which is not null-terminated. Change-Id: Ib3f6f00dfc47491ddc5ce7c347dd894f0c043268 Reviewed-on: https://chromium-review.googlesource.com/960564Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Abhishek Arya <inferno@chromium.org> Cr-Commit-Position: refs/heads/master@{#542806}
-
David Roger authored
Bug: 809617 Change-Id: I1dfc3ea20e44146b450e0ef380c82f70493b68d4 Reviewed-on: https://chromium-review.googlesource.com/960281Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#542805}
-
edchin authored
The selection was previously done simulataneously with insertions/deletions, which resulted in one-off selection error. Selection should be done after any insert/delete operation. Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Iea75f1233a587fe0970fd01219a96de10255968f Reviewed-on: https://chromium-review.googlesource.com/959723Reviewed-by:
-
Jiaquan He authored
When we show the launcher for the first time, we set the placeholder text, but it doesn't show. This commit schedule to paint the placeholder text when it changes. Bug: 733662 Change-Id: I332c6e426171e19f4a035b6fa940f68f3721c058 Reviewed-on: https://chromium-review.googlesource.com/959436Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Jiaquan He <hejq@google.com> Cr-Commit-Position: refs/heads/master@{#542803}
-
Eugene But authored
The strings has not beed finalized yet, and will be updated in a separate CL. Bug: 821188 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I28e4883e84ec07e003c6a799d7a060640ee41038 Reviewed-on: https://chromium-review.googlesource.com/959589 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by:
Louis Romero <lpromero@chromium.org> Cr-Commit-Position: refs/heads/master@{#542802}
-
Luna Lu authored
Bug: 816475 Change-Id: I8e79dd6d18b34aa46f0a64a15b4adfeb161c6544 Reviewed-on: https://chromium-review.googlesource.com/960566 Commit-Queue: Luna Lu <loonybear@chromium.org> Reviewed-by:
-
Gauthier Ambard authored
This CL removes the background color on the blur content view. Bug: 821375 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I2378bb075927bf5ba7ffd8a7a69bbc90c5328377 Reviewed-on: https://chromium-review.googlesource.com/960036 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#542800}
-
Michael Lippautz authored
- Avoid nullptr checks when the visitor knows that it should be non-null - Avoid duplicate methods: MarkHeader and MarkHeaderNoTracing are enough represent all use cases - Style cleanups Bug: chromium:757440 Change-Id: I8f4ed806670a1d4e9967a16596b520cb8133cfc3 Reviewed-on: https://chromium-review.googlesource.com/959963Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#542799}
-
