GitLab

Essentially the same fix as http://crrev.com/44709.

BUG=140177
TEST=Select text in a notification and verify it to be highlighted.

Review URL: https://chromiumcodereview.appspot.com/10825150

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150236 0039d316-1c4b-4281-b951-d872f2087c98

* Create an enum PromoType and a data member promo_type_ of NotificationPromo.
* InitFromJson, InitFromPrefs, HandleClosed and HandleViewed all take a PromoType now.
* HandleClosed and HandleViewed are static.
* Add an anon function PromoTypeToString for conversion from PromoType to string.
* Improve unit tests TestViewed() and TestClosed().

BUG=123061
TEST=unit tests. Manual.

Review URL: https://chromiumcodereview.appspot.com/10836099

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150235 0039d316-1c4b-4281-b951-d872f2087c98

Refactor shell_util.cc to use ScopedVector<RegistryEntry> instead of std::list<RegistryEntry*>

BUG=139597
TEST=Chrome shows up in the Open With context menu immediately post-install (not after first-run/make default).
Make sure App Paths still work (i.e. launch "chrome.exe" from Run dialog).

For the OpenWith test (say you're testing OpenWith for .htm files), make sure that you delete Chrome ProgIds from:
HKEY_CURRENT_USER\Software\Microsoft\Windows\CurrentVersion\Explorer\FileExts\.htm\OpenWithProgids
(they are automatically copied there by Windows so if you have previously installed Chrome on this machine and made it default at least once Windows will have picked this up already).

Review URL: https://chromiumcodereview.appspot.com/10823178

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150234 0039d316-1c4b-4281-b951-d872f2087c98

BUG=130182
TEST=manually


Review URL: https://chromiumcodereview.appspot.com/10826145

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150233 0039d316-1c4b-4281-b951-d872f2087c98

Previously it was done on didStopLoading for _any_ frame.
That causes a stream of spurious favicon URL updates for
every <iframe>.
This is now moved to on didFinishLoad and get triggered only
for the main frame.  This ensures that icon loads always get
initiated after all of the other page resources have been
fetched.  Note that DidFinishDocumentLoad runs potentially
before all subresources have been fetched, which means that
the icon requests may compete with subresources for network
bandwidth.  didFinishLoad is the closest place to where
IconController does it, and we already have icons at this point.

BUG=131567

Review URL: https://chromiumcodereview.appspot.com/10831163

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150232 0039d316-1c4b-4281-b951-d872f2087c98

BUG=115372


Review URL: https://chromiumcodereview.appspot.com/10823094

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150231 0039d316-1c4b-4281-b951-d872f2087c98

BUG=141020
TEST=content_browsertests
TBR=jam@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10855016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150230 0039d316-1c4b-4281-b951-d872f2087c98

The pin icon allows pinning and unpinning the start screen. The icon used changes depending on whether the page is currently pinned or not.

BUG=129598
TEST=Test pages can be pinned and unpinned from metro mode


Review URL: https://chromiumcodereview.appspot.com/10800054

TBR=sky@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10828193

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150229 0039d316-1c4b-4281-b951-d872f2087c98

Currently all conversions to or from PNG will request (and so possibly
create and cache) an ImageSkia intermediate representation.

Depends on http://codereview.chromium.org/10799014/

BUG=123865

TEST=

Review URL: https://chromiumcodereview.appspot.com/10799014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150228 0039d316-1c4b-4281-b951-d872f2087c98

In certain failure cases at initialization time (caused by a race) we used to call
AddDestructionObserver before we would make the surface current, causing us to
destroy the surface before OnWillDestroyStub had a chance to be called, so we
wouldn't RemoveDestructionObserver and we'd call into a dead pointer.

This fixes it. By the time MakeCurrent is called, we know we have a ref to the
surface and it won't destroy it until GpuCommandBufferStub::Destroy, after
OnWillDestroyStub is called.

BUG=140502
TEST=attach debugger to renderer, add a breakpoint to CommandBufferProxyImpl::Initialize, right-click and "view page source" (breakpoint should hit), kill new tab, and only then continue breakpoint. Observe no GPU process crash.

Review URL: https://chromiumcodereview.appspot.com/10831169

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150227 0039d316-1c4b-4281-b951-d872f2087c98

This CL changes the email box to be checked for chrome os and unchecked for Chrome.

R=jhawkins@chromium.org
BUG=140946


Review URL: https://chromiumcodereview.appspot.com/10834194

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150226 0039d316-1c4b-4281-b951-d872f2087c98

After the last chrome remote desktop webapp update (version 1.6.1180.51) V1 authenticators should never be used, so it's
safe to remove them now.

BUG=110483

Review URL: https://chromiumcodereview.appspot.com/10830184

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150225 0039d316-1c4b-4281-b951-d872f2087c98

Cleaned up usage of std::wstring in src/remoting. Added presubmit warning supressions for the remaning instances because they depend on hard-to-change public APIs.

BUG=133003


Review URL: https://chromiumcodereview.appspot.com/10824166

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150224 0039d316-1c4b-4281-b951-d872f2087c98

These tests are not part of content_unittests

BUG=


Review URL: https://chromiumcodereview.appspot.com/10827187

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150223 0039d316-1c4b-4281-b951-d872f2087c98

BUG=138550

Review URL: https://chromiumcodereview.appspot.com/10834196

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150222 0039d316-1c4b-4281-b951-d872f2087c98

We override resource_types for subresources based on mime_types to not have to
deal with types such as PREFETCH, SUBRESOURCE, etc. But we should not do this
for main frame requests which we want to treat separately.

BUG=140838


Review URL: https://chromiumcodereview.appspot.com/10829195

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150221 0039d316-1c4b-4281-b951-d872f2087c98

BUG=140232


Review URL: https://chromiumcodereview.appspot.com/10834176

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150220 0039d316-1c4b-4281-b951-d872f2087c98

This makes {{Enter,Exit} {Presentaiton Mode,Fullscreen}} symmetric, per
https://docs.google.com/open?id=0B4kReKV-OI17Y1lscGhISEtCYjg

BUG=114373
TEST=The actions in the above diagram work.
TBR=yzshen

Review URL: https://chromiumcodereview.appspot.com/10836086

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150219 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None.
TEST=Verify that first/last cols icons also moves when trying to make an invalid page transition in app list.

TBR=sky@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10832169

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150218 0039d316-1c4b-4281-b951-d872f2087c98

BUG=136951


Review URL: https://chromiumcodereview.appspot.com/10824121

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150217 0039d316-1c4b-4281-b951-d872f2087c98

As is suggested in crbug.com/133956 comment #5,
- add " at " between date and time
- use dot instead of colon for time, since colon is not allowed for HFS+/FAT32

BUG=133956, 140355


Review URL: https://chromiumcodereview.appspot.com/10827177

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150216 0039d316-1c4b-4281-b951-d872f2087c98

BUG=140085


Review URL: https://chromiumcodereview.appspot.com/10827149

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150215 0039d316-1c4b-4281-b951-d872f2087c98

Add a simple HTTPS server for testing getUserMedia. Popups used to be allowed through
--disable-popup-blocking, but this has a bug where the resulting popup cannot be resized
smaller. Instead, allow popups by modifying the prefs.
BUG=chromedriver:118,chromedriver:126
TEST=none

Review URL: https://chromiumcodereview.appspot.com/10828135

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150214 0039d316-1c4b-4281-b951-d872f2087c98

BUG=140093
TEST=none
TBR=gbillock@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10831147

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150213 0039d316-1c4b-4281-b951-d872f2087c98

This was causing the test to occasionly not pick up changes.

Tested with: nbuild content_shell_test_apk && touch content/shell/android/javatests/src/org/chromium/content_shell/ContentShellUrlTest.java && nbuild content_shell_test_apk


Review URL: https://chromiumcodereview.appspot.com/10830171

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150210 0039d316-1c4b-4281-b951-d872f2087c98

Add leveldb test files that the try servers can't process.  From http://codereview.chromium.org/10826159/

TBR=jsbell
BUG=108223

Review URL: https://chromiumcodereview.appspot.com/10828191

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150209 0039d316-1c4b-4281-b951-d872f2087c98

In response to the recent media failure (http://crbug.com/133808) we need
tests which actually run over http and request enough data to trigger the
more complex behaviors of our http loader.

In this CL I've modified all the existing tests to wait for playthrough
over both file:// and http:// protocols.  Additionally I've checked in a
large (~4.2MB) test file (with nsylvain's approval) for triggering the
buffering issue in the bug mentioned above.

BUG=134034
TEST=These tests. Eventually try bots.


Review URL: https://chromiumcodereview.appspot.com/10647007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150208 0039d316-1c4b-4281-b951-d872f2087c98

This change causes the code to take a different HFONT creation path, which doesn't exhibit the issue.

BUG=139206
TEST=Launch print preview under Windows 8 (desktop mode is fine). Print headers and footers shouldn't have a ridiculously large font size.

Review URL: https://chromiumcodereview.appspot.com/10837080

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150207 0039d316-1c4b-4281-b951-d872f2087c98

Add ResourceResponseHead members to IPC_STRUCT_TRAITS. Without this, missing member will not be sent with ipc messages, and cause InterProcessTimeTicksConverter never work

BUG= 139093
TEST= no test

Review URL: https://chromiumcodereview.appspot.com/10829031
Patch from Pan Deng <pan.deng@intel.com>.

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150206 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none


Review URL: https://chromiumcodereview.appspot.com/10829160

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150205 0039d316-1c4b-4281-b951-d872f2087c98

Note that this does not support the full functions of screenshots.
It merely makes possible to save the screenshot .png file to  /drive.
What are *not* yet included in this patch are:
- Show/upload the images from "Report issue" (crbug:140622).
- Taking care of name collisions. For now, when a screenshot is taken
  after a short time period of another screenshot, the new comer will
  overwrite or recorded as ".. (1).png", depending on timing.

Not quite good, but for M22, I hope it is better than nothing.

BUG=138593

Review URL: https://chromiumcodereview.appspot.com/10830179

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150204 0039d316-1c4b-4281-b951-d872f2087c98

BUG=128108
Test=This is a test.


Review URL: https://chromiumcodereview.appspot.com/10826170

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150203 0039d316-1c4b-4281-b951-d872f2087c98

TBR=ananta@chromium.org,apatrick@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10836116

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150202 0039d316-1c4b-4281-b951-d872f2087c98

Start freeing buffers after Append() calls if total size of the stream goes
above a hard cap. This caps per-stream, not per-video tag.

BUG=125070

Review URL: https://chromiumcodereview.appspot.com/10853013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150201 0039d316-1c4b-4281-b951-d872f2087c98

After http://crosbug.com/29043 is resolved, Profile* is not used
in GData operations, except that GDataAuthService::Initialize (and
hence indirectly GDataOperationRunner) does indeed refers
to profile for OAuth2 refresh token.

BUG=none
TEST=existing tests (there should be no behavior change)

Review URL: https://chromiumcodereview.appspot.com/10831122

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150200 0039d316-1c4b-4281-b951-d872f2087c98

It may contains cached printers list.

BUG=139001
TEST=none

Review URL: https://chromiumcodereview.appspot.com/10825172

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150199 0039d316-1c4b-4281-b951-d872f2087c98

TBR=garykac@chromium.org
BUG=140995

Review URL: https://chromiumcodereview.appspot.com/10836122

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150198 0039d316-1c4b-4281-b951-d872f2087c98

Many of the remoting_unittests that were excluded for TSan do not
exist anymore or were renamed. Tests that do exist should pass now.

BUG=110729,132164

Review URL: https://chromiumcodereview.appspot.com/10855008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150196 0039d316-1c4b-4281-b951-d872f2087c98

for extensions that use the OAuth API.

I made the same changes in a previous cl (Issue 9298035), which were approved, but then the patch went stale, and I needed to recreate the work.

BUG=110560

Review URL: https://chromiumcodereview.appspot.com/9968064

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150195 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150193 0039d316-1c4b-4281-b951-d872f2087c98