- 31 Oct, 2019 40 commits
-
-
Hesen Zhang authored
- Change the dialog title. Bug: 1020283 Change-Id: I794834076f17bf95880f737f30598a4bc234f9fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894172 Commit-Queue: Hesen Zhang <hesen@chromium.org> Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Hesen Zhang <hesen@chromium.org> Auto-Submit: Hesen Zhang <hesen@chromium.org> Cr-Commit-Position: refs/heads/master@{#711500}
-
Timothy Loh authored
This CL fixes the histogram name PluginVm.EngagementTime.PluginVm in histograms.xml to match the code, PluginVm.EngagementTime.PluginVmTotal. This name is computed in the code dynamically by GuestOsEngagementMetrics::RecordEngagementTimeToUmaIfNeeded(). Bug: 990252 Change-Id: I33389fe949a0594d4d506033478d7ec0cccf2cd9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892472 Auto-Submit: Timothy Loh <timloh@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#711499}
-
Avery Musbach authored
Bug: None Change-Id: If2039c5071a352c0ae6733a2b2270c584a32edd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891124 Commit-Queue: Avery Musbach <amusbach@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#711498}
-
Caroline Rising authored
When trying to disable tests via the instantiation name tests were still running when they should have been disabled. TBR=hbos@chromium.org Bug: 993020 Change-Id: Ic1df1c65158acc39714bc2393668d2b21240c7bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894313Reviewed-by:
Caroline Rising <corising@chromium.org> Commit-Queue: Caroline Rising <corising@chromium.org> Cr-Commit-Position: refs/heads/master@{#711497}
-
Tetsui Ohkubo authored
In exo::Pointer, SetCursorType provides system wide cursor shape change while UpdateCursor updates the cursor per Widget. Because of that, by followng the steps below, we can cause a glitch. In order to prevent that, we should call UpdateCursor at the end of SetFocus. 1. Initially, the cursor is normal on both windows. Window #1: cursor kPointer(focused), Window #2: cursor kPointer Shown cursor: kPointer 2. ARC calls SetCursorType(kNone). Window #1: cursor kNone(focused), Window #2: cursor kPointer Shown cursor: kNone 3. Press Alt-Tab to focus Window #2. ARC calls SetCursorType(kPointer). Window #1: cursor kNone, Window #2: cursor kPointer (focused) Shown cursor: kPointer 4. Move the cursor to the location in Window #1. ARC thinks it should be kPointer, but SetCursorType is not called as it's already called. As a result, kNone is shown although kPointer should be shown. Window #1: cursor kNone, Window #2: cursor kPointer (focused) Shown cursor: kNone TEST=manual(Follow the repro steps in #2 of the bug) BUG=b:132095671 Change-Id: Iea860a0f2099b6b1d5d20dc8483ec1ae975792bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885130Reviewed-by:
-
arthursonzogni authored
We used (or wanted to used it) for the projects: - NavigationMojoResponse. - PerNavigationMojoInterface - NavigationImmediateResponse. Everything landed. Moreover, after dgozman@ works, receiving CommitNavigation() and sending back DidCommitNavigation() are done in a single task. Previous worries about delay caused by task scheduling are gone. These histogram are not really useful anymore. They are ranked 98th percentile by storage size. We should remove them. Bug: 882710,984406,1019038 Change-Id: Ia138074043390f424f752ae28cdceeab056fe803 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893269Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Nasko Oskov <nasko@chromium.org> Auto-Submit: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#711495}
-
Kevin Ellis authored
Removes PlayStateUpdateScope for Animation::play and aligns its implementation with the web-animations spec found here: https://drafts.csswg.org/web-animations/#playing-an-animation-section Cleanup patches are still needed to transition from tracking the active playback rate to the pending playback rate and to remove dependencies on flags that are being deprecated. BUG: 960944 Change-Id: Ie5fbbd46c7a4d0f61cdb0e511cc9d8b8569f2d37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891125Reviewed-by:
Majid Valipour <majidvp@chromium.org> Commit-Queue: Kevin Ellis <kevers@chromium.org> Cr-Commit-Position: refs/heads/master@{#711494}
-
Matt Mueller authored
The flag is used in the pathbuilder impl in cert_verify_tool, and will also be useful in unittests. Change-Id: I4613701d01a1e4e96bcfd8501074ecdb965150da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894104Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Commit-Queue: Matt Mueller <mattm@chromium.org> Cr-Commit-Position: refs/heads/master@{#711493}
-
Stephen Martinis authored
This reverts commit ed064683. Reason for revert: Running out of capacity, see https://crbug.com/1020376 Original change's description: > android-pie-arm64-rel cq experiment to 100%. > > Bug: 765833 > Change-Id: I9558db3934ebae0252f0fd4f2861c3c4441d7020 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871639 > Auto-Submit: Andrew Luo <aluo@chromium.org> > Reviewed-by: Aaron Gable <agable@chromium.org> > Commit-Queue: Aaron Gable <agable@chromium.org> > Cr-Commit-Position: refs/heads/master@{#711093} TBR=agable@chromium.org,aluo@chromium.org Change-Id: I074d0a0dd94d53b6967496b7df42c9fa3ccf39e7 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 765833 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894045Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#711492}
-
David Black authored
The previous format string failed to account for the fact that int64_t is sometimes a long, sometimes a long long depending on architecture. Now, using int32_t which should be sufficiently large for our needs. Bug: 1019711 Change-Id: Ib509b00c4340ed085ac78596af04f46c97878cfd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891575Reviewed-by:
Tao Wu <wutao@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#711491}
-
Andrew Xu authored
The previous CL was reverted because it assumes that the title of the first shelf icon is "Chromium", which is not true under official build. This CL replaces the hard-code check with the function to fetch the icon's title. Meanwhile, this CL merges shelf_widget_test_api into shelf_test_api. /////////////////////////////////////////////////////////////////////// Previous CL description: This CL accomplishes the following things: (1) Designate the previous/next focusable widget for navigation widget, hotseat widget and status area widget. It prevents the accessibility ring from being trapped in one widget. (2) Ensures that the hotseat is shown when the shelf app icon gets the accessibility focus. (3) Implements the test api to facilitate browser tests to access the shelf widget code. Bug: 1010219 Change-Id: Ibe522a6396c61f8b9bb7af01f34106f21500fdf6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892155 Commit-Queue: Andrew Xu <andrewxu@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#711490}
-
Samuel Huang authored
Previously DevUiLoaderThrottle::OnDevUiDfmInstallWithStatus() calls CancelDeferredNavigation() and passes BLOCK_REQUEST. However, this is not an allowed value, and triggers a DCHECK in NavigationRequest::CancelDeferredNavigationInternal(). This CL fixes the bug by replacing BLOCK_REQUEST with CANCEL. Bug: 1020272 Change-Id: I32c442bed726cf28f81864a683ca87d051555fa8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894116 Commit-Queue: Samuel Huang <huangs@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#711489}
-
Jared Saul authored
The Autofill enablement toggle switch was broken up a while back into separate toggles for addresses and payments; this CL logs them separately. It also cleans up some prefs/test code that was still using the overall toggle function, which is actually a little confusing since the original pref is no longer used. Fixed: 1017950 Change-Id: I63ca53cff3f4133b0dae1f35f0c6da5c4dd557f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880206 Commit-Queue: Jared Saul <jsaul@google.com> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
John Wu <jzw@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Matthias Körber <koerber@google.com> Cr-Commit-Position: refs/heads/master@{#711488}
-
Omer Katz authored
This check verified that either concurrent marking was enabled, or the worklist for keeping v8 references found by concurrent markers is empty. Checking that the worklist is empty when concurrent markers are active results in a data race. Switching the order of the conditions in the DCHECK means will only check the worklist if we don't have any concurrent markers. Bug: 986235 Change-Id: I0c4b15c944c3d52dc72fb150b47b97b03d475f17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892772 Commit-Queue: Omer Katz <omerkatz@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#711487}
-
Mitsuru Oshima authored
This will fix the zoom not working issue when running on desktop. I probably forgot to remove this before sending. Bug: None Change-Id: Ia2f50b46aefb427a80cbb84c32f7233ad010b0d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893357Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#711486}
-
Stephen Roe authored
aemu-linux-arm64 is an optional third_party package added by gclient which should not be checked in to git. Bug: 1000907 Change-Id: I97d083b9c1949eea8264ed280ef3004b4c566a1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893973Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Commit-Queue: Stephen Roe <steveroe@google.com> Cr-Commit-Position: refs/heads/master@{#711485}
-
Xianzhu Wang authored
Bug: 1007981, 693741, 959941, 979352, 979002 Change-Id: I62ad1fcefb403e5998029fbeec043154e399c75d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890994 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#711484}
-
Kevin Bailey authored
But allow flag override. Uses max of 8 and URL limit of 7. Desktop only. Will be managed by a Finch roll-out. Bug: 964049 Change-Id: I29db26586dda34c2eaeda2744feb5718010c2648 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891458 Commit-Queue: Kevin Bailey <krb@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#711483}
-
Lijin Shen authored
The incognito icons are visually a little big. This CL is going to replace the resources of icons on tab switcher mode. Bug: 1013272 Change-Id: I591166cb85995ab9bb61c57f3ef3cb5705fcfa49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1887844 Commit-Queue: Lijin Shen <lazzzis@google.com> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#711482}
-
John Abd-El-Malek authored
This is more aligned with Android style guide. Change-Id: I2c31408f8a4d8c59de187e8015981e46eb1d4105 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894314 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Auto-Submit: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#711481}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/3ff097ff2055..ba65c156cf76 git log 3ff097ff2055..ba65c156cf76 --date=short --no-merges --format='%ad %ae %s' 2019-10-31 jmadill@chromium.org Capture/Replay: Implement GetFramebufferParameter capture. Created with: gclient setdep -r src/third_party/angle@ba65c156cf76 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ynovikov@google.com Bug: None Change-Id: I5d579ce2ae74ca520aaa4b5737ba8fd519e60705 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893147Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#711480}
-
Brandon Wylie authored
RadioButtonWithDescription & friends don't support adding via code. This change wraps up the view properly to allow for inflation and adds a layout to host the buttons and proxy checked events between the custom code and the standard callbacks. Bug: 1015218 Change-Id: Ic4bc5e1d01ee982a4513f9c9b202c40646b8739f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869024 Commit-Queue: Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Ender <ender@google.com> Reviewed-by:
Patrick Noland <pnoland@chromium.org> Cr-Commit-Position: refs/heads/master@{#711479}
-
Brian Sheedy authored
Reverts the recent change to automatically trigger try-nougat-phone-tester and android-oreo-arm64-dbg on VR CLs. It appears that there isn't quite enough capacity for these two builders to support regular tryjob runs. The Pie tester should still catch most VR-related issues before CLs land. TBR=bpastene@chromium.org Change-Id: I0e127af80d0c1a5d7153d779991dce172fdb6eb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894394Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#711478}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/7823aeb8d6da..5b6ccbb6b599 git log 7823aeb8d6da..5b6ccbb6b599 --date=short --no-merges --format='%ad %ae %s' 2019-10-31 benjaminwagner@google.com [infra] Upgrade MacBookAir to 10.15. 2019-10-31 herb@google.com ...finally! 2019-10-31 michaelludwig@google.com Move tessellation math into GrQuadUtils 2019-10-31 benjaminwagner@google.com Add Pixel4 jobs Created with: gclient setdep -r src/third_party/skia@5b6ccbb6b599 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jcgregorio@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jcgregorio@google.com Bug: None Change-Id: Ib64a85da78e47841407032d75eb6d9066a2bd39f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894255Reviewed-by:
-
Stephen Roe authored
gsync error message from alexclarke@ (inside 'host_os == "linux" and checkout_fuchsia and checkout_fuchsia_for_arm64_host') ValueError: invalid "and": exactly 2 operands required Bug: 1000901 Change-Id: Iea261c3cbbc65c92a3c79a43c1abfdaa1e3e1411 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893190Reviewed-by:
-
Joe Mason authored
R=robertocn@chromium.org Bug: 1013608 Change-Id: Icf9fd7235a22d91adacc1b1595353e0060147175 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893375Reviewed-by:
Roberto Carrillo <robertocn@chromium.org> Commit-Queue: Joe Mason <joenotcharles@chromium.org> Cr-Commit-Position: refs/heads/master@{#711475}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/7aa214a27bca..f016a6633058 git log 7aa214a27bca..f016a6633058 --date=short --no-merges --format='%ad %ae %s' 2019-10-31 primiano@google.com Merge "UI: Simplify WASM interop" 2019-10-31 fmayer@google.com Merge "Fix next ID." Created with: gclient setdep -r src/third_party/perfetto@f016a6633058 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: Id4939f00a44e482e6551ba5b30c42e4a31698d5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893146Reviewed-by:
-
Jacob DeWitt authored
That class is specific to the Gamepad API integration that was used by WebVR, so we can remove it now. Bug: 1017848 Change-Id: I8b3022fbf59bd12ead6678b39b744efb2e57f428 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888120 Commit-Queue: Jacob DeWitt <jacde@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#711473}
-
Sebastien Marchand authored
On Stable 1 GB corresponds to the 60th percentile for total resident set, setting the limit to 1GB will let Chrome work fine with 3-4 tabs. Bug: 980965 Change-Id: If4f0b6171eb159c3781290b8060617d57d399327 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893580 Auto-Submit: Sébastien Marchand <sebmarchand@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#711472}
-
Nico Weber authored
The MDM service is disabled in Chromium branded builds, but it can be enabled in tests via the GoogleMdmEscrowServiceEnablerForTesting class. The class used to be available only in GOOGLE_CHROME_BUILD builds. To not use GOOGLE_CHROME_BUILD in a .h file, make the class available always and make it a no-op in GOOGLE_CHROME builds. That simplifies a few tests, removes a dependency on the GOOGLE_CHROME_BRANDING buildflag header target, and makes it easy to remove GOOGLE_CHROME_BUILD from mdm_utils.h/cc While here, also remove the unused parameter for GoogleMdmEscrowServiceEnablerForTesting's constructor. Bug: 961769 Change-Id: I1dfdbdf056634d1e47272f397c11919193bf7fc3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894295 Commit-Queue: Nico Weber <thakis@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#711471}
-
Peter Kasting authored
This unifies the code that decides to use the system theme, as well as the code that uses a dark Aura theme in incognito. Bug: none Change-Id: If775c5eb1d3e51cfa8b2458c86736c6457828eb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1887877 Auto-Submit: Peter Kasting <pkasting@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#711470}
-
Sam Maier authored
This changes the paradigm on retrieving resources. Before, for these functions, you needed to know whether your resources were compressed to know to call the right function. Now, we can call it without knowing if there is decompression under the covers. This also allows others to use std::string return types for convenience, even if they don't use compression. TBR: trivial renaming outside of reviewed area Bug: 1003433 Change-Id: I0200d083d4a2d8f8fef98591e9c2e4188488a471 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874514 Commit-Queue: Sam Maier <smaier@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#711469}
-
Caleb Rouleau authored
Use a BenchmarkConfig object to keep track of a benchmark that should be scheduled on a platform (via a shard map). This allows us to keep track of whether a benchmark should be abridged or not. A followup changelist will edit the sharding scripts to use this new object. Then later we can start marking specific benchmarks as abridged. Bug: 965158 Change-Id: Ib8f492852a567094fa85b507d59701e188503f4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893985Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#711468}
-
Charles Zhao authored
Based on the bug report, the GetTabFeatures() crashes on a line when accessing it's own member variables which indicates the pointer maybe empty. Based on recent change in https://chromium-review.googlesource.com/c/chromium/src/+/1816004 It's very likely that web_contents_data becomes nullptr in some cases. Bug: 1017222 Change-Id: Iec58d533af478cc37f96cbedc263884e7e34bf1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884407Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Charles . <charleszhao@chromium.org> Commit-Queue: Charles . <charleszhao@chromium.org> Cr-Commit-Position: refs/heads/master@{#711467}
-
Ken MacKay authored
Bug: internal b/143559499 Change-Id: I57244b6fb772f15ffb4c9f31c4194a2f98d55801 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894263 Commit-Queue: Kenneth MacKay <kmackay@chromium.org> Commit-Queue: Yuchen Liu <yucliu@chromium.org> Auto-Submit: Kenneth MacKay <kmackay@chromium.org> Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#711466}
-
Etienne Bergeron authored
This CL is replacing the control characters with the "Replacement Codepoints". The codepoints in that area are: Unicode Character Category 'Other, Control' a) u+0000 -> u+001f b) u+007f (delete) c) 0080 -> 009f The codepoints from a) and b) are already handled properly. For codepoints from c), it is quite common to have no glyphs (win7). """ Most of these characters play no explicit role in Unicode text handling. The characters U+0000 <control-0000> (NUL), U+0009 <control-0009> tab key (HT), U+000A <control-000A> newline (LF), U+000D <control-000D> (CR), and U+0085 <control-0085> (NEL) are commonly used in text processing as formatting characters. """ see: https://en.wikipedia.org/wiki/Unicode_control_characters Bug: 1011818 Change-Id: I23010faf9130806db3884720e4a90c0723802893 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894041 Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#711465}
-
Xiaohan Wang authored
Fallback to new decoder after initial decode error is an important event to understand what is happening in the media pipeline. This CL adds a MEDIA_ERROR(WARNING) for this case. Bug: 1020245 Change-Id: Ia1e8948c3aa0f80b7d16f5ca48dae69e27f93a1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893521 Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#711464}
-
Mitsuru Oshima authored
Bug: 1019485 Change-Id: I250b837d286a12a0fed6960569c59f91753976e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1889115Reviewed-by:
Jun Mukai <mukai@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#711463}
-
Dan Beam authored
R=dpapad@chromium.org Fixed: 1020309 Change-Id: Ia2e3b95679ee9444aae0f533678fc389fff7307f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894252 Commit-Queue: Dan Beam <dbeam@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Auto-Submit: Dan Beam <dbeam@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#711462}
-
Jeff Yoon authored
Infra failures for 10b61 (Xcode 10.1 GM) due to MobileDeviceDevelopment.pkg untrusted. Upgrading XCode to 11.1 GM and fixing dimensions to Mac-10.14. Bug: 1019931 Change-Id: I7507da8965146dfe5a66c012deac9dd36c8cda52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894261Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Jeff Yoon <jeffyoon@chromium.org> Cr-Commit-Position: refs/heads/master@{#711461}
-
