GitLab

This will not change the functionality now, but will be used
when caption is moved to chrome for ARC++ apps.

BUG=762816

Change-Id: Ia25d13eba37b31677a265b9f3e8b09953a5dd8e5
Reviewed-on: https://chromium-review.googlesource.com/786545
Commit-Queue: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: David Reveman <reveman@chromium.org>
Reviewed-by: Tao Wu <wutao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520811}

Followup to https://chromium-review.googlesource.com/c/chromium/src/+/800950

Bug: None
Change-Id: If1bbf18575ca1b0562499c899960ac003a7678c9
Reviewed-on: https://chromium-review.googlesource.com/802474
Commit-Queue: Charlie Harrison <csharrison@chromium.org>
Commit-Queue: Steven Holte <holte@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520810}

Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I084dedb73e3b5ccc0d958aef88c54e0d8cf820bd
Reviewed-on: https://chromium-review.googlesource.com/795492
Commit-Queue: Hiroshi Ichikawa <ichikawa@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520809}

The gfx::PresentationFlags is defined as enum class(the new c++ style),
but the binary operator | can not be used for enum class. So this CL
changes enum class to enum. And because the old enum style doesn't
have a scope, to avoid polluting gfx namespace, this cl also moves
the gfx::PresentationFlags into struct gfx::PresentationFeedback.

Bug: 776877
Change-Id: I4a16b6e4766199aabf2d006b07be6413b2a80c3b
Reviewed-on: https://chromium-review.googlesource.com/801756
Commit-Queue: Peng Huang <penghuang@chromium.org>
Reviewed-by: David Reveman <reveman@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520808}

If there are any non-composited position:sticky objects that stick
to the root layer, then we must force main thread scrolling to
prevent an "over-scrolling" effect.

BUG=711468
R=skobes@chromium.org,pdr@chromium.org,bokan@chromium.org

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2;master.tryserver.chromium.linux:linux_layout_tests_root_layer_scrolls
Change-Id: I4c36eaf118b8d4d0078c4d5c5e8b633eb71fe733
Reviewed-on: https://chromium-review.googlesource.com/797221
Commit-Queue: Stefan Zager <szager@chromium.org>
Reviewed-by: Robert Flack <flackr@chromium.org>
Reviewed-by: Steve Kobes <skobes@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520807}

"unsafe-eval" CSP directive is enabled in
WorkerOrWorkletScriptController::Evaluate(). This function is called for classic
script evaluation, not for module script evaluation that worklets depend on.
This means the current implementation doesn't work for worklets.

To enable the directive for worklets, this CL moves the part from Evaluate() to
InitializeContextIfNeeded() that is supposed to be called for both classic and
module script evaluation.

This CL also fixes ExecutionContext handling in
CodeGenerationCheckCallbackInMainThread(). This path is called not only from
Document but also from PaintWorklet.

This change is tested for workers by existing CSP tests, and will be tested for
worklets by tests to be added by a following change:
https://chromium-review.googlesource.com/c/chromium/src/+/771051

Bug: 773786
Change-Id: I29232a4297b2f4819f1fe28f3230fc7ea4f769f6
Reviewed-on: https://chromium-review.googlesource.com/799654Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520806}

We are getting an NPE on stable for getAssetStatements and it is not
entirely clear from where from the crash stack. The metadata being null
here seems to be the most likely culprit. Adding a null check for that
as a bandaid fix.

BUG=787831
TBR=mariakhomenko@chromium.org

Change-Id: Ie538e4dda791de27d87c2359671037fa75fcc12b
Reviewed-on: https://chromium-review.googlesource.com/802089
Commit-Queue: Yusuf Ozuysal <yusufo@chromium.org>
Reviewed-by: Matt Giuca <mgiuca@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520805}

This reverts commit 6edaf9cb.

Reason for revert: revert for crbug.com/790750

Original change's description:
> mash: make ash learn/control SpokenFeedbackEnabled
> 
> changes:
> - Move Is{Toggle}SpokenFeedbackEnabled code to ash, which used to be
>   AccessibilityDelegate and called into chrome. This won't work in
>   mustash world. This change breaks the delegate way, by having prefs
>   in ash, the Is{Set} could be done in ash.
> - Change ToggleSpokenFeedbackEnabled to SetSpokenFeedbackEnabled to
>   align with other method names.
> 
> feedback enabled update the tray icon visibility. This is one step
> forward.
> 
> Bug: 594887
> Test: tested on emulator with --mash. Could see toggling spoken
> Change-Id: I3a9c4277f6d1e8bfb2b03777011f6f2f9055d296
> Reviewed-on: https://chromium-review.googlesource.com/777780
> Commit-Queue: Qiang(Joe) Xu <warx@chromium.org>
> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
> Reviewed-by: James Cook <jamescook@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#519898}

TBR=jamescook@chromium.org,xiyuan@chromium.org,warx@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 594887, 790750
Change-Id: I29bb0871036990b8e72ff22897575825d3e1674d
Reviewed-on: https://chromium-review.googlesource.com/802615Reviewed-by: Qiang(Joe) Xu <warx@chromium.org>
Commit-Queue: Qiang(Joe) Xu <warx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520804}

This test was "failing" in root-layer-scrolls mode but it wasn't related
to what this test is checking. Since this test just dumps the layer tree
it was reflecting changes to where scroll offsets are reported in the
tree.

I've rewritten the test to use testharness.js removing all expectation
files and replacing them with a simple assertion that the scroll offset
isn't changed by drag selecting text.

Bug: 781431
Change-Id: I8391caeea794cbdaebfb2b7b86e5c3d9da6268fa
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_root_layer_scrolls
Reviewed-on: https://chromium-review.googlesource.com/802178Reviewed-by: Stefan Zager <szager@chromium.org>
Commit-Queue: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520803}

Changing SafeManifestParser to use the SafeXmlParser service instead of
having a dedicated Mojo interface for doing the parsing of extension
manifests.
SafeXmlParser parses the XML in a sandboxed process and returns a
base::Value that can be traversed in the browser process.

As a result, the mojom, traits, typemap files have been removed.
The implementation of the parsing has been moved to
safe_manifest_parser.cc.

The update_manifest_unittest.cc was moved to
safe_manifest_parser_unittest.cc and split into several tests (no
changes to the logic).

Bug: 786613
Change-Id: Ia586ea0e9689d45130013b6d4d992318eb9b7dc4
Reviewed-on: https://chromium-review.googlesource.com/777939
Commit-Queue: Jay Civelli <jcivelli@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520802}

Convert some bare new()s and a theoretical memory leak into
MakeUnique's.

Bug: 
Change-Id: I1e80714c42f2d7575e774ffdbe2b8f2d5c83c6de
Reviewed-on: https://chromium-review.googlesource.com/801350
Commit-Queue: Kevin Bailey <krb@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520801}

Reason for revert: crashers.

TBR: piman@chromium.org
Bug: 789436
Change-Id: I34a72d3f528189099be6c67eb671809e052a1cb3
Reviewed-on: https://chromium-review.googlesource.com/801993
Commit-Queue: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520800}

With this CL, ResourceLoader puts priority information to
ResourceLoadSchedler when RendererSideResourceScheduler feature is
enabled.

Bug: 785770
Change-Id: I4b18df640770e9bc775eae7305d6e858155e82de
Reviewed-on: https://chromium-review.googlesource.com/795632
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520799}

See the bugs and cxx post for justification and details:
https://groups.google.com/a/chromium.org/forum/#!topic/cxx/RkOHzIK6Tq8

This change was done using clang-tidy as described here:
https://chromium.googlesource.com/chromium/src/+/lkcr/docs/clang_tidy.md

In some cases the the tool leaves behind a string of commas where it
replaced a member initializer list
(https://bugs.llvm.org/show_bug.cgi?id=35051). They were cleaned up with:
  git diff --name-only | \
    xargs sed -E -i 's/(^\s*|\)\s*):[ ,]*= default/\1 = default/'

BUG=778959,778957
This CL was uploaded by git cl split.

R=eroman@chromium.org

Change-Id: I0c2a41fbeee3648e886b70f259e333176ffa4334
Reviewed-on: https://chromium-review.googlesource.com/799595Reviewed-by: Eric Roman <eroman@chromium.org>
Commit-Queue: Chris Watkins <watk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520798}

UIApplicationState was incorrectly casted into a bool making
UIApplicationStateActive (which has a numerical value of 0) to be
incorrectly interpreted as "not active".

Fixing bug w/o unit test for now. Test will be updated in a
follow up CL.

Bug: 781361
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ia7fd52a5809873777c01981079cde9c3fe5e8008
Reviewed-on: https://chromium-review.googlesource.com/802464Reviewed-by: Gregory Chatzinoff <gchatz@chromium.org>
Commit-Queue: Peter Lee <pkl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520797}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/8076c2854d33..009150b7afe1

$ git log 8076c2854..009150b7a --date=short --no-merges --format='%ad %ae %s'
2017-11-30 tandrii bot_update: be explicit when checking out branches.

Created with:
  roll-dep src/third_party/depot_tools


The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=phajdan.jr@chromium.org

Change-Id: Ida539255420d4972b505310ab4c500a018c5d2ac
Reviewed-on: https://chromium-review.googlesource.com/801982Reviewed-by: depot-tools-roller . <depot-tools-roller@chromium.org>
Commit-Queue: depot-tools-roller . <depot-tools-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520796}

See the bugs and cxx post for justification and details:
https://groups.google.com/a/chromium.org/forum/#!topic/cxx/RkOHzIK6Tq8

This change was done using clang-tidy as described here:
https://chromium.googlesource.com/chromium/src/+/lkcr/docs/clang_tidy.md

In some cases the the tool leaves behind a string of commas where it
replaced a member initializer list
(https://bugs.llvm.org/show_bug.cgi?id=35051). They were cleaned up with:
  git diff --name-only | \
    xargs sed -E -i 's/(^\s*|\)\s*):[ ,]*= default/\1 = default/'

BUG=778959,778957
This CL was uploaded by git cl split.

R=eroman@chromium.org

Change-Id: I512ed97a2ee5edffd3ee590aa13b54d40f7baefc
Reviewed-on: https://chromium-review.googlesource.com/799532Reviewed-by: Eric Roman <eroman@chromium.org>
Commit-Queue: Chris Watkins <watk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520795}

Bug:internal b/68950223
Test:none

Change-Id: I200bb5cd32b7ae1962a0f6b07ef90916e2b3f352
Reviewed-on: https://chromium-review.googlesource.com/756371
Commit-Queue: Sandeep Vijayasekar <sandv@chromium.org>
Reviewed-by: Sergey Volk <servolk@chromium.org>
Reviewed-by: Fredrik Hubinette <hubbe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520794}

These strings will be used in a dropdown menu (which will replace the
"always use mirroring" checkbox) in the route controls.

Bug: 774245
Change-Id: If851a0c80cf715f360f30238273d926783f72a5b
Reviewed-on: https://chromium-review.googlesource.com/798590
Commit-Queue: mark a. foltz <mfoltz@chromium.org>
Reviewed-by: mark a. foltz <mfoltz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520793}

See the bugs and cxx post for justification and details:
https://groups.google.com/a/chromium.org/forum/#!topic/cxx/RkOHzIK6Tq8

This change was done using clang-tidy as described here:
https://chromium.googlesource.com/chromium/src/+/lkcr/docs/clang_tidy.md

In some cases the the tool leaves behind a string of commas where it
replaced a member initializer list
(https://bugs.llvm.org/show_bug.cgi?id=35051). They were cleaned up with:
  git diff --name-only | \
    xargs sed -E -i 's/(^\s*|\)\s*):[ ,]*= default/\1 = default/'

BUG=778959,778957
This CL was uploaded by git cl split.

R=rdsmith@chromium.org

Change-Id: Iaa09ab9de500925202c420a47243ccbb28a4f67b
Reviewed-on: https://chromium-review.googlesource.com/799570Reviewed-by: Randy Smith <rdsmith@chromium.org>
Commit-Queue: Chris Watkins <watk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520792}

See the bugs and cxx post for justification and details:
https://groups.google.com/a/chromium.org/forum/#!topic/cxx/RkOHzIK6Tq8

This change was done using clang-tidy as described here:
https://chromium.googlesource.com/chromium/src/+/lkcr/docs/clang_tidy.md

In some cases the the tool leaves behind a string of commas where it
replaced a member initializer list
(https://bugs.llvm.org/show_bug.cgi?id=35051). They were cleaned up with:
  git diff --name-only | \
    xargs sed -E -i 's/(^\s*|\)\s*):[ ,]*= default/\1 = default/'

BUG=778959,778957
This CL was uploaded by git cl split.

R=jochen@chromium.org

Change-Id: Ie446e2916697e7878d30abe052018508897b2dc7
Reviewed-on: https://chromium-review.googlesource.com/799513Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Commit-Queue: Chris Watkins <watk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520791}

Bug: 788655
Change-Id: Ib43359d84663d72719853c63d910ae2d2d03eabb
Reviewed-on: https://chromium-review.googlesource.com/801995Reviewed-by: Ryan Sleevi <rsleevi@chromium.org>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Commit-Queue: Matt Mueller <mattm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520790}

Introduces AnnotationProcessingUtils, which provides:
- AnnotationExtractor, a class allowing to retrieve one or many
annotations in reverse declaration order from a class or a test
description
- AnnotationProcessor, a rule to simplify the use of the above
extractor in the context of tests (here used as parent for @Features
rule).
- Utility methods to simplify the use of the above extractor in other
contexts (here used in SkipChecks)

Bug: 783160,754778
Change-Id: I8ca0793e1229c6268266c75791a44615b8f93f57
Reviewed-on: https://chromium-review.googlesource.com/789192
Commit-Queue: Nicolas Dossou-Gbété <dgn@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520789}

Also distinguish between no hashes available (e.g. loaded from disk
cache) and no publicly trusted hashes (e.g. private CA) in the
.Request metric. Given that this only affected Canary metrics for
a week, the metric is intentionally not renamed.

BUG=787635,788563

Change-Id: I7ff97cd3ecd20b308e6cc85df5c549608251dcbe
Reviewed-on: https://chromium-review.googlesource.com/802214Reviewed-by: Ryan Sleevi <rsleevi@chromium.org>
Reviewed-by: Eric Roman <eroman@chromium.org>
Commit-Queue: Ryan Sleevi <rsleevi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520788}

If the URL of an alerting page can be unwrapped, do so. This
improves the ability of the user to tell what page is showing
the alert.

BUG=696454
TEST=the dialog in that bug is labeled.

Change-Id: I71358be49418ab6d4a88e04f317241e134e361ce
Reviewed-on: https://chromium-review.googlesource.com/797677
Commit-Queue: Avi Drissman <avi@chromium.org>
Reviewed-by: Mustafa Emre Acer <meacer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520787}

See the bugs and cxx post for justification and details:
https://groups.google.com/a/chromium.org/forum/#!topic/cxx/RkOHzIK6Tq8

This change was done using clang-tidy as described here:
https://chromium.googlesource.com/chromium/src/+/lkcr/docs/clang_tidy.md

In some cases the the tool leaves behind a string of commas where it
replaced a member initializer list
(https://bugs.llvm.org/show_bug.cgi?id=35051). They were cleaned up with:
  git diff --name-only | \
    xargs sed -E -i 's/(^\s*|\)\s*):[ ,]*= default/\1 = default/'

BUG=778959,778957
This CL was uploaded by git cl split.

R=ryansturm@chromium.org

Change-Id: Ieca9aba1a234144ae4c7a7040a647936abcc0bf0
Reviewed-on: https://chromium-review.googlesource.com/799591Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Commit-Queue: Chris Watkins <watk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520786}

Allow double-click highlighting of an extension id by putting a space
between "ID:" and the extension id.

Bug: 790040

Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Iccd3e1d4ecf15981c601f1685c4d0a44d7131179
Reviewed-on: https://chromium-review.googlesource.com/798792
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520785}

Adds sForceUmaEnabledForTesting to bypass
 UMA enabled check for testing purposes.

Bug: 771446
Change-Id: I755495a567963b7d18669d988e28203b36f7a678
Reviewed-on: https://chromium-review.googlesource.com/801233
Commit-Queue: Daniel Park <danielpark@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520784}

Removes "using base::" statements in ax_* files.

Replace uses of UTF8ToUTF16(DoubleToString()) with NumberToString16.

TBR=dcheng@chromium.org

Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I27a38273d29cea1dbcaaf77712da6c449bfbce5b
Reviewed-on: https://chromium-review.googlesource.com/802195
Commit-Queue: Brett Wilson <brettw@chromium.org>
Reviewed-by: Brett Wilson <brettw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520783}

This reverts commit 19f5db9f.

Reason for revert: Trying to reland

Original change's description:
> Revert "[css-typed-om] Implement CSSNumericValue.parse."
>
> This reverts commit 86e5b818.
>
> Reason for revert: Added test is failing on Mac, e.g.
> https://storage.googleapis.com/chromium-layout-test-archives/Mac10_11_Tests/20861/layout-test-results/results.html
>
> FAIL Parsing a calc with mixed compatible units returns correct CSSMathValue assert_equals: expected "px" but got "number"
>
> Original change's description:
> > [css-typed-om] Implement CSSNumericValue.parse.
> >
> > This patch implements CSSNumericValue.parse. We reuse the existing
> > calc() parser, modifying it to keep bracket information since the result
> > of CSSNumericValue.parse is sensitive to brackets. We also have to
> > merge certain nodes in the parsed calc tree (e.g. calc(1 + 2 + 3) gets
> > merged into one sum node).
> >
> > Spec: https://drafts.css-houdini.org/css-typed-om-1/#dom-cssnumericvalue-parse
> >
> > Bug: 776173, 788570
> > Change-Id: Ia4bef7c3a2eb580d11a5e51d3921ed52e1f17bf3
> > Reviewed-on: https://chromium-review.googlesource.com/792670
> > Reviewed-by: nainar <nainar@chromium.org>
> > Commit-Queue: Darren Shen <shend@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#520361}
>
> TBR=nainar@chromium.org,shend@chromium.org
>
> Change-Id: Ib2acc1f4fc07390c75ecdda9991f984a55009a81
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 776173, 788570
> Reviewed-on: https://chromium-review.googlesource.com/798991
> Reviewed-by: Timothy Loh <timloh@chromium.org>
> Commit-Queue: Timothy Loh <timloh@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#520421}

Change-Id: I204827390b8de101f7868aeb4c384ed8fa649fd9
Bug: 776173, 788570
Reviewed-on: https://chromium-review.googlesource.com/798992Reviewed-by: nainar <nainar@chromium.org>
Reviewed-by: Darren Shen <shend@chromium.org>
Commit-Queue: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520782}

Bug: 598854
Change-Id: I5275313a9c97084ec78347741b443c2935ae4a92
Reviewed-on: https://chromium-review.googlesource.com/794048Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520781}

This reverts commit 09d525a9.

Reason for revert: revert for a clean revert of crrev.com/c/777780

Original change's description:
> mash: convert PlayEarcon/PlayShutdownSound through mojo call
> 
> changes:
> - Remove PlayEarcon/PlayShutdownSound from ash::AccessibilityDelegate.
>   Convert them calling into chrome through mojo call.
> - PlayShutdownSound gets shutdown sound duration asynchronously from
>   chrome in ash::AccessibilityController. Synchronize the real shutdown
>   timer's beginning when getting shutdown sound duration.
> 
> TBR=xiyuan@chromium.org
> 
> work when SpokenFeedbackEnabled is moved to ash. And add several test
> coverage.
> 
> Bug: 618070
> Test: tested on device without --mash, it works fine. --mash should
> Change-Id: I82b3ce684983e3de658e8d165f90a47cf754f4f6
> Reviewed-on: https://chromium-review.googlesource.com/773629
> Commit-Queue: Qiang(Joe) Xu <warx@chromium.org>
> Reviewed-by: Qiang(Joe) Xu <warx@chromium.org>
> Reviewed-by: James Cook <jamescook@chromium.org>
> Reviewed-by: Tom Sepez <tsepez@chromium.org>
> Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#520441}

TBR=jamescook@chromium.org,xiyuan@chromium.org,dmazzoni@chromium.org,dtseng@chromium.org,tsepez@chromium.org,warx@chromium.org

Change-Id: I3673182425fa0cb4702036d326b83a275415d5de
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 618070, 790750
Reviewed-on: https://chromium-review.googlesource.com/802614Reviewed-by: Qiang(Joe) Xu <warx@chromium.org>
Commit-Queue: Qiang(Joe) Xu <warx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520780}

|now_| and |now_ticks_| in TestMockTimeTaskRunner were read or written
without a lock. So, when PostDelayedTask() and NowTicks() are called
on different threads, it hits TSan failure.

This CL adds lock for all access to them to avoid the data race.

Change-Id: I562e2bfbd46b481b41faa05906b19c8664654812
Reviewed-on: https://chromium-review.googlesource.com/798819Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520779}

Change-Id: I679eafa7719553792404d3c0549b5a7877d34c86
Reviewed-on: https://chromium-review.googlesource.com/791513Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520778}

For fragmentation, if we have a break token, the inline coordinate
may still be non-zero at the start of a next fragmentainer, if the
block we're fragmenting has an inline-start margin.
Furthermore, even the block coordinate may be non-zero, if
clearance has been applied.

R=cbiesinger@chromium.org

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: I998eabbbc2434574aff2e63dc7114f942c3c92c3
Reviewed-on: https://chromium-review.googlesource.com/799970
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520777}

Bug: 
Change-Id: I73558b750b22f68f0048babd8e8960d851255753
Reviewed-on: https://chromium-review.googlesource.com/801661Reviewed-by: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Commit-Queue: Maria Khomenko <mariakhomenko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520776}

Previously SetSelection did DCHECK for null DataSrouce, which was wrong.
According to Wayland document, we should clears the clipboard when null
DataSource is passed.

Bug; 789831
Test: exo_unittests

Change-Id: I9bff52cb4259b2d02faeb6a6e32353d0e3da4f2c
Reviewed-on: https://chromium-review.googlesource.com/798815
Commit-Queue: Daichi Hirono <hirono@chromium.org>
Reviewed-by: David Reveman <reveman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520775}

https://pdfium.googlesource.com/pdfium.git/+log/fee910e6f81f..1980f10ff2b8

$ git log fee910e6f..1980f10ff --date=short --no-merges --format='%ad %ae %s'
2017-11-30 dsinclair Simplify XDP parsing code
2017-11-30 dsinclair Rename XFA_ATTRIBUTEENUM to XFA_AttributeEnum enum class
2017-11-30 dsinclair Move packet information into simple parser
2017-11-30 dsinclair Make parsers work off XFA_PacketType enum
2017-11-30 dsinclair A CXFA_Node can only be in one packet
2017-11-30 dsinclair Cleanup XFA packet code
2017-11-30 rharrison Rewrite lower level details of extracting text from page
2017-11-30 dsinclair Create CXFA_Node::NameToAttributeEnum
2017-11-30 dsinclair Move setting of XML content back to specific set methods
2017-11-30 dsinclair Rename GetAttributeEnumById to CXFA_Node::AttributeEnumToName
2017-11-30 dsinclair Remove the packets from attribute data.
2017-11-30 dsinclair Generate XFA node attribute information
2017-11-30 thestig Fix GBK2K-H CMap usage.
2017-11-30 thestig Use initializer list in CPDF_DataAvail ctor.
2017-11-30 thestig Relax checks in CFX_FaceCache::LoadGlyphPath().

Created with:
  roll-dep src/third_party/pdfium
BUG=654578,788864


The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: Ic87fbd3ca5dbec12418aa60db84ae9e894431881
Reviewed-on: https://chromium-review.googlesource.com/802188
Reviewed-by: <pdfium-deps-roller@chromium.org>
Commit-Queue: <pdfium-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520774}

It appears that on certain devices/variations of Android, the
implementation of Dialog.show() can end up with the same ViewRootImpl
being added to the WindowManager twice, resulting in a
BadTokenException.

This change adds a safer variant of shouldShowIncognitoIntent, the
aptly named shouldShowIncognitoIntentSafe, that returns a boolean to
indicate whether we successfully showed the alert dialog or not,
allowing us to log the error but handle the failure without crashing.

TBR=bshe@chromium.org

Bug: 782602
Change-Id: Iea5bd3b8f45c9824e34f581d208653a206b65c1e
Reviewed-on: https://chromium-review.googlesource.com/801257
Commit-Queue: Troy Hildebrandt <thildebr@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520773}

First, convert all enums and structs used by existing IPCs to mojo

Next CL will define the Host and Renderer interfaces.

Bug: 611938
Change-Id: I689b7399ad903197073ca15763d73d5bfff3207f
Reviewed-on: https://chromium-review.googlesource.com/790174Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: Nick Carter <nick@chromium.org>
Reviewed-by: Joshua Bell <jsbell@chromium.org>
Commit-Queue: Nicholas Verne <nverne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520772}