GitLab

BUG=725470
NOTRY=TRUE
TBR=shinyak

Review-Url: https://codereview.chromium.org/2902753002
Cr-Commit-Position: refs/heads/master@{#473948}

on x86/c64 bots. The problem was that VrShellDelegate.java depends on
VrFeedbackStatus.java which was only available when enable_vr was set to true.
This CL build VrFeedbackStatus as part of chrome_java_sources instead of
chrome_vr_java_sources.

Original CL: https://codereview.chromium.org/2887383002/
Revert: https://codereview.chromium.org/2896933002/

Revert "Revert "Show an infobar prompting the user to enter feedback when they exit VR""

This reverts commit 007ec6f3.

TBR=mthiesse
BUG=706438

Review-Url: https://codereview.chromium.org/2899013002
Cr-Commit-Position: refs/heads/master@{#473947}

TBR=wychen@chromium.org,yusufo@chromium.org,mlamouri@chromium.org

Bug: 725534
Change-Id: Ifc0696d08d82d0ea41fc96c7ef09e54cf161b3f2
Reviewed-on: https://chromium-review.googlesource.com/512365Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#473946}

Before this patch, typing "3103106000" into a phone number field in web
payments UI on desktop would leave the field as-is, which is difficult
to read.

This patch extends ValidationDelegate to also handle text field
formatting. Formatting happens only when the user is typing at the end
of the field or when user has left the field (blur). Typing in the
middle of the field does not cause reformat because Views does not have
functionality to position the cursor, which is required to make
auto-formatting feel natural.

After this patch, typing "3103106000" into a phone number field in web
payments UI on desktop will format-as-you-type this number into "+1
310-310-6000".

Bug: 725161
Change-Id: Id39de49e2a79a681ff2615541489be057b37d2de
Reviewed-on: https://chromium-review.googlesource.com/511422Reviewed-by: Anthony Vallee-Dubois <anthonyvd@chromium.org>
Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#473945}

Revert of Why do we have this line when it makes sliders look editable? (patchset #2 id:20001 of https://codereview.chromium.org/2893963002/ )

Reason for revert:
Is causing test failures such as https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%281%29/builds/67395

DumpAccessibilityEventsTest.AccessibilityEventsAriaSliderValueTextChange

c:\b\c\b\win\src\content\browser\accessibility\dump_accessibility_browsertest_base.cc(363): error: Value of: is_different
  Actual: true
Expected: false
[4988:5300:0523/092002.409:37981750:ERROR:dump_accessibility_browsertest_base.cc(388)] Diff:
* Line Expected
- ---- --------
*    1 EVENT_OBJECT_VALUECHANGE on role=ROLE_SYSTEM_SLIDER value="2%" IA2_STATE_EDITABLE,IA2_STATE_VERTICAL
     2 <-- End-of-file -->
Actual
------
EVENT_OBJECT_VALUECHANGE on role=ROLE_SYSTEM_SLIDER value="2%" IA2_STATE_VERTICAL
<-- End-of-file -->

Original issue's description:
> Why do we have this line when it makes sliders look editable?
>
> BUG=None
>
> Review-Url: https://codereview.chromium.org/2893963002
> Cr-Commit-Position: refs/heads/master@{#473911}
> Committed: https://chromium.googlesource.com/chromium/src/+/b78f1ba01120e4f9dfa9faf541b670d893883cfe

TBR=dmazzoni@chromium.org,aleventhal@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=None

Review-Url: https://codereview.chromium.org/2900953004
Cr-Commit-Position: refs/heads/master@{#473944}

UI screenshot:
https://drive.google.com/open?id=0Byo6-Nuda2jgSUJKeTBQMndhbnc
Constraints screenshot:
https://drive.google.com/open?id=0Byo6-Nuda2jgYnZ3SnRPdERxQzA

BUG=682880

Review-Url: https://codereview.chromium.org/2901663002
Cr-Commit-Position: refs/heads/master@{#473943}

BUG=724491

Review-Url: https://codereview.chromium.org/2895693002
Cr-Commit-Position: refs/heads/master@{#473942}

This CL adds metrics that report success for downloading favicons on
demand (both for existing code for PopularSites and for the new code for
MostLikely).

BUG=536988

Review-Url: https://codereview.chromium.org/2888393002
Cr-Commit-Position: refs/heads/master@{#473941}

BUG=None

Review-Url: https://codereview.chromium.org/2886763003
Cr-Commit-Position: refs/heads/master@{#473940}

When chromevox is enabled or the braille is connected, a notification will be shown to
users through the notification center. The screenshot of the notifications can be found
in the crbug.

TEST=TrayAccessibilityTest.ShowNotification

BUG=685845

Review-Url: https://codereview.chromium.org/2838903002
Cr-Commit-Position: refs/heads/master@{#473939}

BUG=724157

Review-Url: https://codereview.chromium.org/2899873002
Cr-Commit-Position: refs/heads/master@{#473938}

If the TPM is not ready, don't try to load the system token. It would
fail anyway and prevent the TPM initialization process from running on
user sign-in (because TPMTokenLoader only performs the initialization
process once). Also, delay system token initialization until cryptohome
is ready.

BUG=725346,655266
TEST=Manual test on Chrome OS:
(1) On a freshly resetted device (not enrolled, not owned), the system
    token is simply not loaded on the sign-in screen
(2) On an enrolled device, the system token is loaded on the sign-in
    screen. Device-wide EAP-TLS networks can connect.
In both cases, there should be no errors related to TPM init in
  /var/log/chrome/chrome.

Change-Id: If810287747f05361ffa3a0a06fe9f2c8988ea676
Reviewed-on: https://chromium-review.googlesource.com/512662Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Pavol Marko <pmarko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#473937}

BUG=725532
TBR=changwan@chromium.org

Review-Url: https://codereview.chromium.org/2898213002
Cr-Commit-Position: refs/heads/master@{#473936}

The flat_tree pretty-printer is hooked up so that base::flat_set can be
displayed.

The regular expressions for base::Value were incorrect. These were separated
out into three exact matches for clarity.

Point and Rect printers were removed. The default view shows the data well
enough, and it's confusing to see different member names being printed than the
actual class has in it.

Review-Url: https://codereview.chromium.org/2895973003
Cr-Commit-Position: refs/heads/master@{#473935}

https://skia.googlesource.com/skia.git/+log/92de631edd3e..e980174d0f3a

$ git log 92de631ed..e980174d0 --date=short --no-merges --format='%ad %ae %s'
2017-05-23 mtklein simpler portable round()
2017-05-23 reed add gm to test alpha in drawPatch
2017-05-23 jvanverth Fix TSAN error for shadow cache
2017-05-23 scroggo Revert "sk_fgetsize to not use ftell."

Created with:
  roll-dep src/third_party/skia


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=brianosman@chromium.org

Change-Id: Ie34a0e5421dab869ca3809669bc630d413c35f83
Reviewed-on: https://chromium-review.googlesource.com/512364Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#473934}

This adds URLRequestContextBuilderV8, which can construct a
URLRequestContext using either type of ProxyResolver. When using such
a resolver, the ProxyService will fetch requests using the
URLRequestContext that was created with the builder.

Added a subclass instead of modifying URLRequestContextBuilder so it
can continue to be used without depending on V8.

This was originally landed in
https://codereview.chromium.org/2881613002/, and reverted in
https://codereview.chromium.org/2888043008/.  This version of the CL
fixes a test-only lifetime issue.

BUG=717253, 724471

Review-Url: https://codereview.chromium.org/2898073002
Cr-Commit-Position: refs/heads/master@{#473933}

BUG=596760

Review-Url: https://codereview.chromium.org/2901843002
Cr-Commit-Position: refs/heads/master@{#473932}

|new Document()| creates a new Document instance.

Intent-to-implement-and-ship:
https://groups.google.com/a/chromium.org/forum/#!msg/Blink-dev/IxyBdzkSU98/LJ12LwjKAAAJ

This CL fixes 168 failures in external/wpt/.

WPT changes:
* Adds 'origin' check to dom/nodes/Document-constructor.html.
* Adds dom/nodes/Document-constructor-svg.svg
* Adds dom/nodes/Document-constructor-xml.xml

BUG=238234, 643043

Review-Url: https://codereview.chromium.org/2881323002
Cr-Commit-Position: refs/heads/master@{#473931}

WebView applications can throw run-time exceptions within
WebView-callbacks. When such an exception is thrown from the callback
passed to evaluateJavascript it is not correctly propagated to Android's
feedback mechanism. This is because that callbacks is called through
JNI, and the default way (in Chromium) of handling Java exceptions
thrown on the Java-side of JNI calls is to print the stack trace for the
current exception to the logcat when the JNI call returns to native, and
then intentionally crash in native.

With this CL we avoid the problem of propagating a Java exception back
through JNI and the native stack by posting the WebView-callback (which
can cause the Java exception) as a new task to the current Java Handler.
In that way any Java exception thrown inside the WebView-callback can be
propagated directly up to the Android framework's
UncaughtExceptionHandler which then properly reports the Exception
through the framework's crash reporting mechanism.

BUG=719396

Review-Url: https://codereview.chromium.org/2900033002
Cr-Commit-Position: refs/heads/master@{#473930}

BUG=722949

Review-Url: https://codereview.chromium.org/2884393002
Cr-Commit-Position: refs/heads/master@{#473929}

Review-Url: https://codereview.chromium.org/2898153002
Cr-Commit-Position: refs/heads/master@{#473928}

This API will allow to use DidStartNavigation callback instead of
deprecated -[CRWWebDelegate webWillReload].
DidStartNavigation will check if NavigationContext::GetPageTransition
returns reload transition to act on reload navigation.

BUG=674991

Review-Url: https://codereview.chromium.org/2896623003
Cr-Commit-Position: refs/heads/master@{#473927}

BUG=
R=nparker@chromium.org

Review-Url: https://codereview.chromium.org/2895213004
Cr-Commit-Position: refs/heads/master@{#473926}

This enum controls whether tasks posted within the scope of a
ScopedTaskEnvironment can run as they are posted or have to wait
until a call to RunUntilIdle() to run.

BUG=724077
TBR=gab@chromium.org

Review-Url: https://codereview.chromium.org/2891363005
Cr-Commit-Position: refs/heads/master@{#473925}

BUG=None

Review-Url: https://codereview.chromium.org/2884213002
Cr-Commit-Position: refs/heads/master@{#473924}

- Adds support for textfields with UIPickerView to edit view controller.
- Mediator dynamically creates editor fields based on selected country.
- Mediator loads regions asynchronously and notifies view controller.
- Hooks up address edit coordinator with country selection coordinator.
note: There is still no validation and saving the form results in DCHECK

http://imgur.com/a/P52tS

BUG=602666

Review-Url: https://codereview.chromium.org/2893353002
Cr-Commit-Position: refs/heads/master@{#473923}

Instead of dispatching events at begin-frame + offset, dispatch events
at regular intervals (~16ms). The timer starts at an offset from the
first begin frame.

BUG=722921

Review-Url: https://codereview.chromium.org/2886263002
Cr-Commit-Position: refs/heads/master@{#473922}

The following args are required to generate map files that work with
//tools/binary_size/supersize on Linux:
  * is_official_build = true
  * allow_posix_link_time_opt = false
  * generate_linker_map = true

BUG=723798

Review-Url: https://codereview.chromium.org/2896633002
Cr-Commit-Position: refs/heads/master@{#473921}

and corresponding tests.

BUG=718475

Review-Url: https://codereview.chromium.org/2884013002
Cr-Commit-Position: refs/heads/master@{#473920}

On macOS when the adapter turns off all devices are disconnected[1] but
didDisconnectPeripheral is not called by the OS.

This was causing us to think that the device was still connected,
keep around all its attributes and dispatch operations on the device
even though the device was disconnected.

Fixes the issue by calling didDisconnectPeripheral for each of our
connected BluetoothDevices.

[1] https://developer.apple.com/reference/corebluetooth/cbcentralmanagerdelegate/1518888-centralmanagerdidupdatestate?language=objc

Bug: 724300, 511025
Change-Id: I1dc0f63fcf55949a4596f0ba05a87f158840df16
Reviewed-on: https://chromium-review.googlesource.com/511882
Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Reviewed-by: Vincent Scheib <scheib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#473919}

ShoudlOfferTranslate now only requires a TranslateEventProto. This simplifies the API, and ensures consistency between logging and inference.

Also, removing unused includes and cleaning up unittests.

BUG=723739

Review-Url: https://codereview.chromium.org/2890843003
Cr-Commit-Position: refs/heads/master@{#473918}

Add, implement, and call some methods in NetworkDelegate to check
whether sites are allowed to store reports and clients.

BUG=704259,676324

Review-Url: https://codereview.chromium.org/2891133003
Cr-Commit-Position: refs/heads/master@{#473917}

Before this patch, phone numbers in web payments UI on desktop were
displayed without formatting, e.g., "3103106000". This is hard to read.
This patch changes address and contact info to use formatted phone
numbers in labels and editors, e.g., "+1 310-310-6000".

Bug: 725196
Change-Id: I03ceb8e095f1e21c085ab19ab59b963464408f80
Reviewed-on: https://chromium-review.googlesource.com/511063Reviewed-by: Anthony Vallee-Dubois <anthonyvd@chromium.org>
Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#473916}

BUG=721943
TBR=dfalcantara@chromium.org

Review-Url: https://codereview.chromium.org/2884563002
Cr-Commit-Position: refs/heads/master@{#473915}

This makes the "testDataDirectory" and the "testWebSocketPort" keys
being optional in the test config that can be accessed via the
chrome.test.getConfig method.

This allows to skip filling of these keys with some fake values in tests
that are not inherited from ExtensionApiTest.

Bug: chromium:626343
Change-Id: I142ddc22af7b798bc93484086a42b39d5fbd466d
Reviewed-on: https://chromium-review.googlesource.com/511142Reviewed-by: Finnur Thorarinsson <finnur@chromium.org>
Commit-Queue: Maksim Ivanov <emaxx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#473914}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/213c7195..4eb9e4f0

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2896283002
Cr-Commit-Position: refs/heads/master@{#473913}

The SwiftShader repository now contains the Subzero source code using
a Git subtree.

BUG=swiftshader:47

TEST=bots

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2862803003
Cr-Commit-Position: refs/heads/master@{#473912}

BUG=None

Review-Url: https://codereview.chromium.org/2893963002
Cr-Commit-Position: refs/heads/master@{#473911}

Disable benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_health.memory_desktop.browse:social:twitter

It is flaky. See bug

TBRing a contributor to the test file.

BUG=725386
TBR=nednguyen

Review-Url: https://codereview.chromium.org/2896293002
Cr-Commit-Position: refs/heads/master@{#473910}

Use ids instead in case objects disappear before we have a chance
to fire the events.

BUG=725203

Review-Url: https://codereview.chromium.org/2900893003
Cr-Commit-Position: refs/heads/master@{#473909}