- 11 Jul, 2019 40 commits
-
-
Nazerke authored
Bug: 973040, 979183 Change-Id: I2ec413e4220129bcd8bc29975c51fd29c17190c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1678177 Commit-Queue: Nazerke Kalidolda <nazerke@google.com> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Auto-Submit: Nazerke Kalidolda <nazerke@google.com> Cr-Commit-Position: refs/heads/master@{#676335}
-
Yutaka Hirano authored
Fix mojo connection error handling on extensions to fix flaky tests. Document that in network_context.mojom. Bug: 981467, 967524 Change-Id: I51cd834ca71cb712b1538196ba5e2d730a0c2eed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1689554 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Adam Rice <ricea@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#676334}
-
Darren Shen authored
There's a bug with SetCompositionRange: 1. XKB calls SetCompositionRange. 2. InputMethodEngine asks text client to underline the text. 3. InputMethodEngine does not update local composition, so it's empty. 4. XKB switches input methods. 5. When disabling the InputMethodEngine, we commit the composition text. But it thinks composition text is empty! 6. InputMethodEngine commits nothing and XKB will switch to new input method, with existing text left in composition. To avoid this stale cache issue, we'll use ConfirmCompositionText instead of committing the cached composition. We will remove the cached composition in a future patch. TEST=InputMethodChromeOSTest.ConfirmCompositionText* InputMethodEngineTest.TestDisableAfterSetCompositionRange Bug: 980437 Change-Id: Ia7cdf2d6be7d892595211dfaca67a1eefc71686c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1687720Reviewed-by:Shu Chen <shuchen@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#676333}
-
Adam Ettenberger authored
It's unsafe to look at any node other than the node being updated while handling AXTree::UpdateNode. Removing logic in |AXEventGenerator::OnNodeDataWillChange| which called |GetUnignoredParent| and moved it to where the event is handled with a stable tree in |BrowserAccessibilityManagerWin::FireGeneratedEvent|. Bug: 651614, 974444 Change-Id: I1e0254ea25003c827f625bbb9a256f66a3817a19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1693776 Commit-Queue: Adam Ettenberger <adettenb@microsoft.com> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Kurt Catti-Schmidt <kschmi@microsoft.com> Cr-Commit-Position: refs/heads/master@{#676332}
-
chrome://autofill-internalsDominic Battre authored
This CL introduces logging mechanisms for chrome://autofill-internals that are more high fidelity than what we have today. They allow to log structured data, use colors to indicate the context, etc. As a first usecase, the CL starts logging parsed forms. Bug: 928595 Change-Id: Ib304de4dafe0686ed9f8d6720f43b2416c49c8dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1689204 Commit-Queue: Dominic Battré <battre@chromium.org> Reviewed-by:
Chris Palmer <palmer@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#676331}
-
Gabriel Charette authored
This reverts commit 7c7e0f8d. Reason for revert: crbug.com/982998 (flaky on win7_rel) Original change's description: > UIA: Upon visibility change, fire UIA_AriaPropertiesPropertyId event > > - Implemented firing property changed event for > UIA_AriaPropertiesPropertyId - hidden upon visibility change > introduced by aria-hidden and visibility:hidden, accompanied by > associated browser dump tests. > > - Documentation on UI Automation AriaProperties > (see the second table's last column for AriaProperties > properties): > https://docs.microsoft.com/en-us/windows/desktop/WinAuto/uiauto-ariaspecification > > Bug: 928949 > Change-Id: I7808ba8fe352d515a054027217afc34892b38732 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1659970 > Commit-Queue: Victor Fei <vicfei@microsoft.com> > Reviewed-by: Katie Dektar <katie@chromium.org> > Reviewed-by: Ian Prest <iapres@microsoft.com> > Cr-Commit-Position: refs/heads/master@{#675876} TBR=katie@chromium.org,iapres@microsoft.com,vicfei@microsoft.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 928949, 982998 Change-Id: I401c2a439a35b22232655e3bba91977f3c450538 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696846Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#676330}
-
Colin Blundell authored
This CL moves the files that are currently in the //components/signin/core/browser:shared GN target into the structure described in this document: https://docs.google.com/document/d/1p_kahITGFgv7PehQ61-thRVR3Hrdaf3tLryMytTRPYs/edit# Namely, files intended for usage by the entire signin component and its consumers are moved into a new //signin/public/base/ directory. Files that are conceptually part of the IdentityManager public interface are moved into //signin/public/identity_manager/. This change was done in two parts: 1. A script that did the code moves and corresponding renames, include path changes, etc. 2. Manual followup that changed GN files and DEPS to reflect the new structure. For ease of reviewing, I uploaded 1 as the original PS and 2 as PS2. TBR=jochen@chromium.org Bug: 952788 Change-Id: I88afc79b426f3acc954d78006ed88d4cd0579672 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1687239Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#676329}
-
Aga Wronska authored
Bug: 975504 Change-Id: Id28552a8f51501accccbf0b640245ac981f9a13b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1691910Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#676328}
-
Leon Han authored
This CL removes those unnecessary things from content/common/service_worker/service_worker_types.h, follow-up CLs will remove all dependencies on it from all code other than content/browser/service_worker/, then move/merge it into content/browser/service_worker/ finally. BUG=789854 Change-Id: Ied002b16718d345bd038f11c4486d703cdc4bdfb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692206Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Leon Han <leon.han@intel.com> Cr-Commit-Position: refs/heads/master@{#676327}
-
Jinsuk Kim authored
This CL modifies the feature flag overscroll navigation so that users can enable/disable navigation sheet as an option. Bug: 937946 Change-Id: Id7bf39054d561927be74262331226ce112ef7caf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1694184 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#676326}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I47238b1530a47dbd48415d2fd17a6ca752c43ed7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1697171Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#676325}
-
Noel Gordon authored
Update the metadata sub-system to extract RAW image file ifd via Image Loader. Add metadata/BUILD.gn dependency on Image Loader. Change metadata box controller to request ifd for RAW images, and show the result in the <files-metadata-box>. Change ‘openQuickViewImageRaw’ test to verify that RAW image metadata is shown in the metadata box. Test: browser_tests —gtest_filter=“QuickView*openQuickViewImageRaw” Bug: 965370 Change-Id: Ie70aba24904e392724c3ce6b1183f1b24b207b06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1697701 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Alex Danilo <adanilo@chromium.org> Cr-Commit-Position: refs/heads/master@{#676324}
-
Naoki Fukino authored
We are still monitoring Cryptohome.MigrationUI.* metrics to see if the migration of cryptohome encryption stay normal over version-ups of Chrome OS. Let me unset the expiracy of the metric. Bug: 975971 Test: None Change-Id: I9431d5263bfc43b19e0a9a035c5c1770592c124b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692462Reviewed-by:
Junichi Uekawa <uekawa@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Naoki Fukino <fukino@chromium.org> Auto-Submit: Naoki Fukino <fukino@chromium.org> Cr-Commit-Position: refs/heads/master@{#676323}
-
Peter K. Lee authored
This fixed unit test failures when Manual Translate is enabled by default. This is required for http://crrev/c/1693506. Change-Id: I462487633925de4c19f6a65ba986df3d96bb881b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695654 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
-
Henrique Ferreiro authored
Remove unnecessary includes from //components/user_manager public API and fix its build dependencies. Change-Id: Ia275cd10bfdf49013e604b59e8f3c19b3df880ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695542Reviewed-by:
-
Austin Tankiang authored
The "Open with" context menu item can contain an icon displayed on the right. This icon is implemented as a background image, so the text can overlap the icon if it is too long. Fix this by adding a margin to the end of the element when we show an icon. Bug: 958719 Change-Id: Ic8108e8300cdd1c584d483ce442e2a6362814bae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1697001Reviewed-by:
Noel Gordon <noel@chromium.org> Reviewed-by:
-
Omer Katz authored
Both PreFinalizers reset host_ pointer and close binding_. Bug: 981043 Change-Id: I8f4a22e696e3c5c0532b8021d0ae1c207e9fef0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692417Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Omer Katz <omerkatz@chromium.org> Cr-Commit-Position: refs/heads/master@{#676319}
-
Omer Katz authored
Replaced dtor with equivalent pre-finalizer. Bug: 981043 Change-Id: I6a5e4df7ae5438c3dafee0122d3965564fbf7ffb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692416Reviewed-by:
-
Julie Jeongeun Kim authored
This CL is a part of moving access token management to OAuth2AccessTokenManager. It is specifically a step toward folding DeviceO2TSDelegate into DeviceO2TS now that the latter is no longer an O2TS subclass. It moves RefreshTokenIsAvailable and GetAccounts from DeviceO2TSDelegate to DeviceO2TS not to refer to |delegate_|. Bug: 967598 Change-Id: I75faec6e9aa747dc908f9d9c2782dd01e426b847 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692382Reviewed-by:
-
Matt Falkenhagen authored
Refactoring only. There's no need for the interface. Bug: 926114, 824858 Change-Id: Ia7d5784f3f87710e26cde7469f655655e74e846f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1694248Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/f304969e0f53..4e6a4416e5df git log f304969e0f53..4e6a4416e5df --date=short --no-merges --format='%ad %ae %s' 2019-07-11 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-07-11 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 4e71b2bc2546..9668237739a2 (7 commits) 2019-07-11 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update Go deps 2019-07-11 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src 9d81bd85..17462d53 (335 commits) 2019-07-11 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 8c4c9e37bf96..28ae0a4b2810 (3 commits) Created with: gclient setdep -r src/third_party/skia@4e6a4416e5df The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=fmalita@google.com Change-Id: I45b32c82b7554e6f776017b241affff603266292 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1697166Reviewed-by:
-
Noel Gordon authored
Bug: 965370 Change-Id: I63542b98125102022fb00a79b12ef64ad1ad4439 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1697125Reviewed-by:
-
Staphany Park authored
Change-Id: Ic0a245f29020ec2c2b8679ed56f285312312d126 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696834 Commit-Queue: Victor Costan <pwnall@chromium.org> Auto-Submit: Staphany Park <staphany@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#676313}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8f0eabe40a7c..b1d9da985777 Created with: gclient setdep -r src-internal@b1d9da985777 The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=hcarmona@google.com,hajimehoshi@google.com,jbroman@google.com Change-Id: I9c5797980b72a987da8c0631543cab8c1114065a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1697044Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#676312}
-
Takashi Sakamoto authored
Bug: 981058 Change-Id: Iea49ab3f5dc112ccf4475f08d807d2ff8ed94f51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692111 Commit-Queue: Takashi Sakamoto <tasak@google.com> Reviewed-by:
Doug Arnett <dougarnett@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#676311}
-
Hitoshi Yoshida authored
Date and RegExp were IDL type, but they were removed in Oct. 2015.[1] In current spec, they are not reserved words and can be used as identifiers. This CL drops these words from keywords in Blink IDL parser, to follow the current spec. [1] https://github.com/heycam/webidl/pull/69 Bug: 839389 Change-Id: I2592573ba0c1875a3e828a54adfc5e040184d3fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696842Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#676310}
-
Wei Lee authored
This CL removes cache fps range entry if SetFpsRange() gets invalid input so that it will use default fps range rather than unexpected cache range. In addition, it fixes a bug of method typo in options.js and avoids reporting error when the SetFpsRange() fails intendedly. Bug: None Test: Manually. Change-Id: I924a663607a5d0829c8f0aa5873a7488aca072f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1687569 Auto-Submit: Wei Lee <wtlee@chromium.org> Reviewed-by:
Shik Chen <shik@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Sheng-hao Tsao <shenghao@chromium.org> Commit-Queue: Wei Lee <wtlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#676309}
-
Fergal Daly authored
low cost when off-screen. Exposes .mjs files as http-available files for web_tests. This required adding .mjs to the mime config and various things in BUILD files. Add .mjs as javascript to the mime configs for webtest server. Delete old virtual-scroller code. Bug: 979108 Change-Id: Idfde0bb23263b571fc3abf98845bb7d0327baf07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1680170 Commit-Queue: Fergal Daly <fergal@chromium.org> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#676308}
-
Fergal Daly authored
mac-rel is being weird, so NOTRY=true TBR=aboxhall@chromium.org NOTRY=true Bug: 982234,982998 Change-Id: I2f8998ac253cba11bbe319c5cf890b913093abd3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1697403 Commit-Queue: Fergal Daly <fergal@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#676307}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/08a3d8e2a0d8..78dec0421b69 git log 08a3d8e2a0d8..78dec0421b69 --date=short --no-merges --format='%ad %ae %s' 2019-07-11 eliribble@chromium.org Show nice error on failure to enumerage input files. Created with: gclient setdep -r src/third_party/depot_tools@78dec0421b69 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:983006 TBR=agable@chromium.org Change-Id: I33d052c6b39b0fc3c0946e7e8459088e7a5ba1ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1697048Reviewed-by:
-
Antonio Gomes authored
This CL is a prepraration step to Onion souping webmediaplayer_ms.cc|h, webmediaplayer_ms_compositor.cc|h. It is part of phase 4.4, described in the design doc [1]. [1] https://docs.google.com/document/d/1rHJGi1U72qZsOGIctIf7GKRaY8d7BgtVW8MaMYumzYY/ BUG=704136 R=haraken@chromium.org, hiroshige@chromium.org Change-Id: Ifa20c5e06feae9433a6c8438f845546088b025f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692389 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Auto-Submit: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
-
Alex Oldemeier authored
This CL adds the Termina kernel version to Crostini enterprise reports. This CL has three parts: - Add a pref to cache the Termina VM kernel version. Also rename the pref containing the Termina component version to make its content more transparent. - If reporting is enabled, a call to concierge's GetEnterpriseReportingInfo is made on Crostini startup to write the Termina kernel version to the pref. - Finally, the pref is copied to the status proto at device status collection time. Test: unit_tests --gtest_filter="Crostini*", browser_tests --gtest_filter="DeviceStatusCollectorTest.*Crostini*" Bug: 844468 Change-Id: I8b53a7e75b365311433a47f532e10d415f56c33c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642556Reviewed-by:
Nicholas Verne <nverne@chromium.org> Reviewed-by:
Denis Kuznetsov <antrim@chromium.org> Reviewed-by:
Fergus Dall <sidereal@google.com> Commit-Queue: Alex Oldemeier <aoldemeier@chromium.org> Cr-Commit-Position: refs/heads/master@{#676304}
-
Matthew Cary authored
The fuzzer uses the shared memory API to create a file descriptor (Harness::GetFileDescriptor). This change updates that creation from the legacy shared memory API to the new one. There is no functional change. Bug: 795291 Change-Id: I186fc316c15c19fea08b04b76d8c663cdb673eb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695410Reviewed-by:
Nic Hollingum <hollingum@google.com> Commit-Queue: Matthew Cary (CET) <mattcary@chromium.org> Cr-Commit-Position: refs/heads/master@{#676303}
-
Christopher Lam authored
Bug: 972967 Change-Id: I72724aa1509386424e2c656d2d3b03cda9752a23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1694247Reviewed-by:
Alan Cutter <alancutter@chromium.org> Commit-Queue: calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#676302}
-
Hayato Ito authored
Bug: 982290 TBR: lushnikov@chromium.org Change-Id: I9bb2b2566028faa150c3f5af1525d2143e8930e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696904 Commit-Queue: Hayato Ito <hayato@chromium.org> Reviewed-by:
Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#676301}
-
Julian Watson authored
BUG=chromium:978332 Change-Id: I1320e91db83af8e23e73d0c408ee13ed09778c26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1694501 Auto-Submit: Julian Watson <juwa@google.com> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Commit-Queue: Julian Watson <juwa@google.com> Cr-Commit-Position: refs/heads/master@{#676300}
-
Tsuyoshi Horo authored
Currently when a main SXG is served from PrefetchedSignedExchangeCache was_in_prefetch_cache flag is set, but was_fetched_via_cache flag is not set. So "Cached" suffixed PageLoad.Clients.SignedExchange UMAs are not recorded. To fix this, this CL set was_fetched_via_cache flag when we set was_in_prefetch_cache flag. Bug: 935267 Change-Id: I22bbd9554b871ad1f1c9e3268af113ed9c22de59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696961Reviewed-by:
-
Miyoung Shin authored
This CL replaces the use of std::array of std containers with WTF::Vector in *test.cc files and removes unnecessary including <array> header. Bug: 952716 Change-Id: Ifb5349c03921a61394fc438e5d0501f3c8f9ac99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695361Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/d3f699407f75..08a3d8e2a0d8 git log d3f699407f75..08a3d8e2a0d8 --date=short --no-merges --format='%ad %ae %s' 2019-07-11 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-07-11 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-07-10 vadimsh@chromium.org [lucicfg] Update to the latest version. Created with: gclient setdep -r src/third_party/depot_tools@08a3d8e2a0d8 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I0dd9eaca65a9abe440a23ab0c5c223ec96f23579 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696831Reviewed-by:
-
Takuto Ikuta authored
We already have 32core machine in luci.chromium.try pool. https://chromium-swarm.appspot.com/botlist?c=id&c=task&c=os&c=status&d=asc&f=cores%3A32&f=pool%3Aluci.chromium.try&f=builderless%3A1&k=builderless&s=id Bug: 956776, 954450 Change-Id: I8ee1a5343c01add4717cbc26c60451364aa41d14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1697123 Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Yoshisato Yanagisawa <yyanagisawa@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#676296}
-
