GitLab

This patch should be reverted once it is fixed. We should also add a unittest
before re-enabling.

BUG=404317
TBR=wiltzius@chromium.org
NOTRY=True

Review URL: https://codereview.chromium.org/502153002

Cr-Commit-Position: refs/heads/master@{#291751}

Since other methods separate supported binary image MIME types from SVG,
where SVG was detected as a "non image type" along with XML, and since I
needed a method to detect MIME types that can be displayed as an image,
I've added such a method.

BUG=398443

Review URL: https://codereview.chromium.org/471913002

Cr-Commit-Position: refs/heads/master@{#291750}

R=scottmg@chromium.org

Review URL: https://codereview.chromium.org/498393002

Cr-Commit-Position: refs/heads/master@{#291749}

Compiling Error:

../../chrome/browser/shell_integration_linux.cc:294:13: error: unused function 'QuoteCommandLineForDesktopFileExec' [-Werror,-Wunused-function]
std::string QuoteCommandLineForDesktopFileExec(
            ^
../../chrome/browser/shell_integration_linux.cc:310:12: error: unused variable 'kDesktopEntry' [-Werror,-Wunused-const-variable]
const char kDesktopEntry[] = "Desktop Entry";
           ^
../../chrome/browser/shell_integration_linux.cc:312:12: error: unused variable 'kXdgOpenShebang' [-Werror,-Wunused-const-variable]
const char kXdgOpenShebang[] = "#!/usr/bin/env xdg-open";
           ^
3 errors generated.

The above mentioned function and variables are only used from GetNoDisplayFromDesktopFile,
only when support for GLIB is enabled.

Review URL: https://codereview.chromium.org/499823002

Cr-Commit-Position: refs/heads/master@{#291748}

BUG=357693

Review URL: https://codereview.chromium.org/477103003

Cr-Commit-Position: refs/heads/master@{#291747}

Revert of Update V8 to version 3.29.16.1 (merged r23332). (patchset #2 of https://codereview.chromium.org/499943002/)

Reason for revert:
Breaks mips.

Original issue's description:
> Update V8 to version 3.29.16.1 (merged r23332).
>
> TBR=yangguo@chromium.org
>
> Committed: https://chromium.googlesource.com/chromium/src/+/755cec945ca48f3175845f38219ca06f90c423d8

TBR=yangguo@chromium.org,ulan@chromium.org,bmeurer@chromium.org,rmcilroy@chromium.org
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/497363003

Cr-Commit-Position: refs/heads/master@{#291746}

One piece of feedback we've received is that users want an
explicit full-screen control rather than tying it to
maximize. Simply adding a full-screen button means that the
window has six icons of varying crypticness (crypticality?)

This CL prepares the ground for adding a full-screen button
while reducing clutter. It moves the Options and Disconnect
buttons to the left-hand side of the window, while leaving
them adjacent to the window controls in full-screen mode.

There are two main changes to the CSS. The first is that we
no longer use "display: table"; I thought this was needed to
get rid of the implicit spaces between the icons, but
"display: flex" does the job just as well. The second is to
do with how the etched borders are rendered. Previously, a
button was responsible for rending both the light and dark
highlights to the left and bottom. This worked because they
were all right-aligned, but with the new layout, each button
renders all of its borders.

Review URL: https://codereview.chromium.org/498813003

Cr-Commit-Position: refs/heads/master@{#291745}

This deletes code that was previously used for deciding if the
expanded content whitelist for GPU rasterization should be used.
Blink now uses the expanded whitelist by default (that is,
WebSettings::setUseExpandedHeuristicsForGpuRasterization is
now a no-op), so this code is no longer needed.

BUG=404866

Review URL: https://codereview.chromium.org/496503002

Cr-Commit-Position: refs/heads/master@{#291744}

BUG=406055

Review URL: https://codereview.chromium.org/497333002

Cr-Commit-Position: refs/heads/master@{#291743}

Gosh the DCHECK for #inputs == 1 was located _after_ removing the
input XD

Interesting that no one else hit this problem, including myself.

BUG=407046

Review URL: https://codereview.chromium.org/498213002

Cr-Commit-Position: refs/heads/master@{#291742}

Passed after fix landed in latest Skia roll:
  http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux/builds/36066/steps/webkit_tests/logs/stdio

BUG=406425

Review URL: https://codereview.chromium.org/501103003

Cr-Commit-Position: refs/heads/master@{#291741}

Tie Domain Reliability uploads to metrics reporting -- halt uploads when
reporting is turned off. (Keep recording, since we will eventually be able to
access reports through JavaScript as well.)

BUG=407170

Review URL: https://codereview.chromium.org/491753003

Cr-Commit-Position: refs/heads/master@{#291740}

This new system call can be used to set NO_NEW_PRIVS, install a BPF filter,
and synchronize that filter across the thread group.

BUG=308763,308775
TEST=New SandboxBPF.Tsync test where kernel support is available.
R=jln@chromium.org

Review URL: https://codereview.chromium.org/494743003

Cr-Commit-Position: refs/heads/master@{#291739}

R=benjhayden@chromium.org
BUG=405717

Review URL: https://codereview.chromium.org/502613003

Cr-Commit-Position: refs/heads/master@{#291738}

BUG=341408

Review URL: https://codereview.chromium.org/475763005

Cr-Commit-Position: refs/heads/master@{#291737}

For testing purposes, allow shell.createWindow() to load a non-extension
URL.

BUG=none
TEST=none

Review URL: https://codereview.chromium.org/487533006

Cr-Commit-Position: refs/heads/master@{#291736}

NOTRY=true

Review URL: https://codereview.chromium.org/487363006

Cr-Commit-Position: refs/heads/master@{#291735}

With current implementation the on parsing the credit card field heuristics
matches to the autofill::kExpirationYearRe and apparently it's assumes that a
4-digit credit card field (i.e. ServerFieldType CREDIT_CARD_EXP_DATE_4_DIGIT_YEAR).

This patch considers *maxlength* attribute in addition to see whether the feild
is 2-digit input field or not.

BUG=406247

Review URL: https://codereview.chromium.org/493393003

Cr-Commit-Position: refs/heads/master@{#291734}

(Since we've switched to git, I used dabead0c to check that
committing was working ok before landing a semantic change.)

Cr-Commit-Position: refs/heads/master@{#291733}

BUG=352290

Review URL: https://codereview.chromium.org/496873006

Cr-Commit-Position: refs/heads/master@{#291732}

Since GN runs its scripts in a different current directory than GYP, I had to update the remoting html template script to be able to handle this situation.

Also includes many misc linking fixes:
  - Sets enable_nacl to false.
  - Add renderer context menu component
  - Adds many missing files

R=sergeyu@chromium.org

Review URL: https://codereview.chromium.org/498773005

Cr-Commit-Position: refs/heads/master@{#291731}

Two issues fixed in the error message handling code:
 1. Error response to session-info message is interpreted as old peer
    that doesn't support current auth protocol. That's not necessary
    anymore.
 2. Errors received after session-terminate were not ignored as they
    should.

BUG=402735

Review URL: https://codereview.chromium.org/493573002

Cr-Commit-Position: refs/heads/master@{#291730}

Add a "last_commit_position" script so we can use commit positions for GN builds rather than git hashes. Remove the old last_change target in build/util which is no longer used.

Fix ozone GN build.
Fix Windows GN build.

R=jamesr@chromium.org

Review URL: https://codereview.chromium.org/483403005

Cr-Commit-Position: refs/heads/master@{#291729}

Entries remove themselves from their backend's |active_entries_| at two
distinct points in their lifetime; after a successful doom and on
destruction.

Entries are also added to |active_entries_| in one of two possible places;
early in opening/creating an entry from its key, and during iteration, after
successfully opening an entry from its hash alone.

We weren't carefully tracking this relationship, and so entries previously
would double remove themselves from the backend, which could create
races that could cause entries to not open. For instance, creating an entry,
dooming it, closing it, then creating a new entry with the same key could
race, and the doom's completion would remove the closing entry from
|active_entries_|, allowing a subsequent OpenEntry() to fail because it
found an half baked entry.

To avoid exposing the state of the backend to the entry, this patch
introduces an abstraction to Entry to allow observation of destruction. This
abstraction is then used to register the backend as entries are placed in
|active_entries_|.

R=jkarlin@chromium.org,ttuttle@chromium.org,pasko@chromium.org
BUG=317138,404676

Review URL: https://codereview.chromium.org/478573003

Cr-Commit-Position: refs/heads/master@{#291728}

This is the Chromium side of the change to convert the linux_asan
builder to a recipe.

BUG=399729

Review URL: https://codereview.chromium.org/464063004

Cr-Commit-Position: refs/heads/master@{#291727}

net: add a batch of HSTS preloads.
Cr-Commit-Position: refs/heads/master@{#291726}

Introduced by r290692.

BUG=406968

Review URL: https://codereview.chromium.org/470803008

Cr-Commit-Position: refs/heads/master@{#291725}

Includes the following CLs:

Attempt to let nss's SSSE3 files build with clang-cl.
Review URL: https://codereview.chromium.org/493883002/

BUG=82385
TBR=wtc@chromium.org

Review URL: https://codereview.chromium.org/503063003

Cr-Commit-Position: refs/heads/master@{#291724}

BUG=

Review URL: https://codereview.chromium.org/491443005

Cr-Commit-Position: refs/heads/master@{#291723}

R=pdr
NOTRY=true

Review URL: https://codereview.chromium.org/463333003

Cr-Commit-Position: refs/heads/master@{#291722}

TBR=piman@chromium.org
BUG=169282

Review URL: https://codereview.chromium.org/501913002

Cr-Commit-Position: refs/heads/master@{#291721}

1. The popup needs to hide when the renderer resizes (akin to hiding on scroll or orientation change).
2. There was a race condition where the renderer could say Show() then Hide(), but the Hide() would fall on deaf ears because the popup was still waiting for webdata.

The linked bug occurred when the render view was auto-resized /after/ an orientation change. After the orientation change we'd get a text field changed event which would trigger the popup to reshow. The fix is to make the renderer resizing close the popup, but (2) and (3) above were necessary for this to actually work.

BUG=401752

Review URL: https://codereview.chromium.org/482643004

Cr-Commit-Position: refs/heads/master@{#291720}

In Hangout Remote Desktop, we need to show message windows from the background page for authentication.

This CL introduces the MessageWindow class, which supports showing of both confirm dialogs and message boxes.

BUG=405628

Review URL: https://codereview.chromium.org/493813002

Cr-Commit-Position: refs/heads/master@{#291719}

Part of the refactoring effort to consolidate all fileapi/quota/webkit_database/webkit_blob-related code into a single namespace, directory, and component. Discussed here: https://groups.google.com/a/chromium.org/forum/#!topic/storage-dev/aQall8GOrS4

This is itself part of a larger refactoring effort to get rid of the webkit/ directory, as recorded in the following bug:

BUG=338338
TBR=darin@chromium.org

Review URL: https://codereview.chromium.org/498273002

Cr-Commit-Position: refs/heads/master@{#291718}

BUG=304341
TEST=RenderFrameHostManagerTest.Disown*

Review URL: https://codereview.chromium.org/505443002

Cr-Commit-Position: refs/heads/master@{#291717}

Password Manager shouldn't push empty pair username/password. We should track how it happens and how often.

BUG=404012

Review URL: https://codereview.chromium.org/493123002

Cr-Commit-Position: refs/heads/master@{#291716}

BUG=392478
NOTRY=true

Review URL: https://codereview.chromium.org/469343003

Cr-Commit-Position: refs/heads/master@{#291715}

* It was possible to click behind the dialog screen by scrolling it out of the way.
* When connecting to a host, scroll-bars appeared, regardless of the window size.

Review URL: https://codereview.chromium.org/478033004

Cr-Commit-Position: refs/heads/master@{#291714}

BUG=406053

Review URL: https://codereview.chromium.org/490333002

Cr-Commit-Position: refs/heads/master@{#291713}

When PictureLayerImpl chooses a scale to raster at, we should accept
tiles at that scale as complete, and not try wait for tiles at some
other scale to be filled in. Such a tiling may not even exist.

R=enne, vmpstr
BUG=406433

Committed: https://chromium.googlesource.com/chromium/src/+/60c7d86bb7685d8ca04ee53ae20fcdd6cd37eb5f

Review URL: https://codereview.chromium.org/484363003

Cr-Commit-Position: refs/heads/master@{#291712}