GitLab

These will be implemented in WebRTC soon (https://codereview.webrtc.org/2964593002/).

Change-Id: Ic1fd11f3463d8fe29b157cdf3095386b33489940
Reviewed-on: https://chromium-review.googlesource.com/563833Reviewed-by: Henrik Boström <hbos@chromium.org>
Commit-Queue: Zach Stein <zstein@google.com>
Cr-Commit-Position: refs/heads/master@{#486180}

Add the capability for clients to be notified when the service fails
initialization.

Bug: 735347
Change-Id: Id274a68c76893ae2286f1f9945a1255d8b592aaa
Reviewed-on: https://chromium-review.googlesource.com/542476Reviewed-by: Jian Li <jianli@chromium.org>
Reviewed-by: Shakti Sahu <shaktisahu@chromium.org>
Commit-Queue: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486179}

This flag was removed long ago in https://crrev.com/35503005 but remains
as a flag in the Android virtual test suite. This patch removes it, it
should be a no-op.

Bug: 285397
Change-Id: I5e99d279e96baea3b495150f19b4e52a193a92d1
Reviewed-on: https://chromium-review.googlesource.com/562926Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Commit-Queue: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486178}

Introduces a Channel::Error enum so reported errors can have a little
more context (was the channel just disconnected, or did it read bad
data?)

Uses the existing optional ProcessErrorCallback on a NodeChannel to
notify embedders when bad data is received, either in BrokerHost,
specific NodeChannel messages, or Channel in general.

This means that any such failures will now get proper crash reports when
happening on renderer-to-browser connections.

BUG=741712
R=jcivelli@chromium.org

Change-Id: Ia9152207f32c4adff669fded68ca66f9240ffc1c
Reviewed-on: https://chromium-review.googlesource.com/568621
Commit-Queue: Ken Rockot <rockot@chromium.org>
Reviewed-by: Jay Civelli <jcivelli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486177}

Add a method that resets FileMonitor in a hard recovery attempt.  This
CL will, with subsequent CLs that add similar recovery methods to other
components, allow recovering (or at least cleaning up) a failed
DownloadService Controller.

The cleanup steps are:
1. Try to erase all files in the directory.
2. Attempt to re-initialize the component (make sure the directory is
created and accessed).
3. Return the result of the re-initialization to the caller.

BUG=736222

Change-Id: Ic5a8ad63c836eedd37aebaa817fb201a9a36663f
Reviewed-on: https://chromium-review.googlesource.com/567865
Commit-Queue: David Trainor <dtrainor@chromium.org>
Reviewed-by: Shakti Sahu <shaktisahu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486176}

Enable more layout tests with network service after certificate errors were also ignored in r485664.

BUG=713857
TBR=yzshen@chromium.org

Change-Id: I3bbc5454090eb5a6ade2343518072187c8ce17e6
Reviewed-on: https://chromium-review.googlesource.com/568691Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486175}

Currently, DialogOverlays can be created in frames that are pending
or in hidden WebContents. These DOs would count towards the maximal
overlay count, and not actually be visible.

This CL prevent DOs from being created in frames that would not be
immediately visible, and cleans up DOs as soon as their containing
frames are no longer visible.

Bug: 710186
Change-Id: I8f9d870e5d7c0995b00464c72cad87d9c57f9a68
Reviewed-on: https://chromium-review.googlesource.com/565757
Commit-Queue: Thomas Guilbert <tguilbert@chromium.org>
Reviewed-by: Bo Liu <boliu@chromium.org>
Reviewed-by: Frank Liberato <liberato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486174}

Console used to format holes in an Array very similarly to Array entries that
contained the value 'undefined'. The former showed up as 'undefined x n',
(e.g. `new Array(2)` or `[,,1]`) while the latter showed up as multiple
'undefined's (e.g. `[undefined, undefined]`). The two cases are functionally
different, since `0 in Array(1)` !== `0 in [undefined]`.

This CL reduces confusion by using 'empty x n' instead of 'undefined x n'
for holes in an Array.

BUG=732021

Review-Url: https://codereview.chromium.org/2977463002
Cr-Commit-Position: refs/heads/master@{#486173}

This allows 2 things:
1- it makes the validation logic a lot simpler: we can just test the shared
   memory id/size/offset in BeginQuery and QueryCounter commands, and if it
   validates we can ensure it stays valid throughout the query lifetime, so
   it removes a lot of failure paths
2- it ensures we don't need to wait for the query to be completed before freeing
   its memory on the client side, giving us the potential to reduce round trips

Bug: 741215
Change-Id: I63a76594c2d8299c4dead5b297d304a9aa204948
Reviewed-on: https://chromium-review.googlesource.com/567721
Commit-Queue: Antoine Labour <piman@chromium.org>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486172}

BUG=740769
TBR=zmo@chromium.org

Change-Id: I73c1a95ad06c6f5e0eecd32c6be691840f26afce
Reviewed-on: https://chromium-review.googlesource.com/568909
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486171}

In PaymentDetailsUpdate which is used to update the payment request using
updateWith(), total is an optional field. On the other hand, in
PaymentDetailsInit which is used in the construction of the payment request,
total is a required field. This CL allows for that distinction.

Bug: 602666
Change-Id: I2109a1b5af1bad881d6e3bb63590448ac16aabd0
Reviewed-on: https://chromium-review.googlesource.com/568286
Commit-Queue: mahmadi <mahmadi@chromium.org>
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486170}

The user may see flickering of autocomplete text if onDraw() is called
inside keyboard app's batch edited IME operations.

For example, consider the following sequence of events:

1) beginBatchEdit()
2) commitText()
3) onDraw()
4) endBatchEdit()
5) onDraw()

With current implementation, onDraw() at step 3) and onDraw() at step 5)
may see different getText() because we remove span at beginBatchEdit()
and does not add a new one until endBatchEdit().

In order to ensure that span is added at the end of every IME operation,
even including beginBatchEdit(), the current internal calls to
beginBatchEdit() and endBatchEdit() have been separated out as
onBeginImeCommand() and onEndImeCommand(), respectively. And then
beginBatchEdit() and endBatchEdit() will simply increment / decrement
batch edit count inside these new IME command guards.

And we remove / add span in the IME command guards even when they are
not the outermost ones, to ensure that onDraw() can see the span when
necessary.

Note that notification is not affected thanks to the count guard.

BUG=539536

Change-Id: Ia1f044dd3c2669658dd363e4375f841c9c448f37
Reviewed-on: https://chromium-review.googlesource.com/568914Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Alexandre Elias <aelias@chromium.org>
Commit-Queue: Changwan Ryu <changwan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486169}

Now that (1) csswg-test is merged into wpt, and (2) the importer is
given GitHub credentials, it can now be simplified and can reuse the
LocalWPT functionality.

Change-Id: I2f84ceee5f7263cd7ec56cb0dc6d474079dde8d5
Reviewed-on: https://chromium-review.googlesource.com/566060
Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>
Reviewed-by: Jeff Carpenter <jeffcarp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486168}

BUG=739258

Review-Url: https://codereview.chromium.org/2972943002
Cr-Commit-Position: refs/heads/master@{#486167}

This CL adds messages to tell users when there are no extensions installed, as well as when their search filtering yields no results.

BUG=729863
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2974583003
Cr-Commit-Position: refs/heads/master@{#486166}

Now that we have a patch for the ARM A12/A17 errata, it is safe to try
building ARM Thumb without frame-pointers again, since we don't need
them.

We leave frame-pointers enabled in ChromeOS for 64-bit.

The Windows case is tweaked to use current_cpu rather than target_cpu,
and the Android case is explicitly gated on is_android.

Bug: 740806, 711784
Change-Id: I2fff46d1a3a8d78d12c389f95a20acf54013318d
Reviewed-on: https://chromium-review.googlesource.com/567608
Commit-Queue: Wez <wez@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486165}

e1396f8a changed the presubmit to allow
ScopedAllowIO in browser tests. From the discussion it seemed like the
intention was to allow it in all tests though. This changes the
presubmit to at least allow usage in unit tests.

Also update the error message to no longer refer to the deprecated
blocking pool and FILE thread.

Change-Id: Ibcc18f502b8c47a50a424a2ffe6eab04291e685b
Reviewed-on: https://chromium-review.googlesource.com/569014Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486164}

No functional changes.

Bug: 
Change-Id: I02c494be7028763e017f5bd01710d2285e98dd01
Reviewed-on: https://chromium-review.googlesource.com/568693Reviewed-by: Yash Malik <ymalik@chromium.org>
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486163}

Change-Id: I4aad3d6e360b3e7c02366c9eee65399cfbec82cb
Reviewed-on: https://chromium-review.googlesource.com/564298Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Michael Case <mikecase@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486162}

Bug: 
Change-Id: Id828c8df4eed5d104b4ce311bf7aa1f4bcd6411c
Reviewed-on: https://chromium-review.googlesource.com/568701
Commit-Queue: Pavel Feldman <pfeldman@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486161}

Also add request_origin to this struct.

Bug: 734753
Change-Id: I210bf0fa177f1379693b6b432c12f48b89d8cd28
Reviewed-on: https://chromium-review.googlesource.com/558564Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Filip Gorski <fgorski@chromium.org>
Reviewed-by: vitaliii <vitaliii@chromium.org>
Reviewed-by: Justin DeWitt <dewittj@chromium.org>
Commit-Queue: Cathy Li <chili@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486160}

As long as chrome://media-internals is open, it should preserve log
entries. Log entries are still removed from the backing store, so these
players will be removed if the page is reloaded.

This CL also changes the trigger for backing store removal to include
tab crashes. Previously there was no reliable way to remove a logs for a
player from a crashed tab, which is problematic if the tab is incognito.

Bug: 741132
Change-Id: I92b152fa6578c3728ab22a45786e188d93fb87f2
Reviewed-on: https://chromium-review.googlesource.com/567644
Commit-Queue: Dan Sanders <sandersd@chromium.org>
Reviewed-by: Matthew Wolenetz <wolenetz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486159}

This CL adds a browser test to check that the ChromeExpectCTReporter is properly
created and set up to receive reports, particularly for dynamic Expect-CT
violations. It also enables the dynamic Expect-CT feature on the waterfall.

BUG=679012,642517

Change-Id: I3ea01207ea5852b9bd0bbb1d90799ee4555c854e
Reviewed-on: https://chromium-review.googlesource.com/566572Reviewed-by: Jesse Doherty <jwd@chromium.org>
Reviewed-by: Mustafa Emre Acer <meacer@chromium.org>
Commit-Queue: Emily Stark <estark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486158}

Also fixes up some formatting errors that have snuck into histograms.xml.

BUG=none
TEST=none
R=mek@chromium.org

Change-Id: If99bf87ea428dbe61204cad9092d3e0ad2c77d7d
Reviewed-on: https://chromium-review.googlesource.com/568854Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Commit-Queue: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486157}

Updates the total number of menu items to reflect the fact that an item
was deleted. Also added a comment in order to prevent this from
happening again.

Bug: 682880
Change-Id: I0893cd9e4eda6f1b7238cc2fcfe892d30a1cb42c
Reviewed-on: https://chromium-review.googlesource.com/565175
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Reviewed-by: Jean-François Geyelin <jif@chromium.org>
Reviewed-by: Louis Romero <lpromero@chromium.org>
Reviewed-by: Ed Chin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486156}

Replace callbacks with promises.

Bug: 
Change-Id: I677ec63941ec827f559921dc4205fff9eae6a841
Reviewed-on: https://chromium-review.googlesource.com/564086
Commit-Queue: Eugene Ostroukhov <eostroukhov@chromium.org>
Reviewed-by: Alexei Filippov <alph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486155}

This change adds Adaptive Icons (Android API 26 feature) for the
Chromoting Android Client.  I generated the new foreground and round
icons using Android Studio (based off of the legacy xxxhdpi logo) and am
using a base white background.

Note that I needed to add a suppression for the new XML files.  This
apprears to be due to the version of lint being used as previous
versions of Android did not require xml files in the mipmap or drawable
folders.

BUG=704154

Change-Id: I7f58634fdc758aec25e67369d26f68b41262ae5b
Reviewed-on: https://chromium-review.googlesource.com/566992
Commit-Queue: Joe Downing <joedow@chromium.org>
Reviewed-by: Lambros Lambrou <lambroslambrou@chromium.org>
Reviewed-by: Peter Wen <wnwen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486154}

Views a11y: Obey DialogDelegate::GetAccessibleWindowRole() rather than making a dialog-within-a-dialog

Currently both views::RootView and a dialog's ContentsView() are
populating AX_ROLE_DIALOG. This sets up a weird dialog-within-a-dialog.
Also, since the ContentsView doesn't include the title and dialog
buttons, it creates a nested group that excludes the dialog buttons and
is hard to navigate with a11y tools since it hides the dialog contents
inside the group.

To fix, just rely on views::RootView to populate the window role, and
obey GetAccessibleWindowRole() when deciding whether to notify a11y
tools of the window appearance.

BUG=741285

Review-Url: https://codereview.chromium.org/2980713002
Cr-Commit-Position: refs/heads/master@{#486153}

Cmd+B and gutter click both toggle breakpoint on a line. Gutter click + shift
also disabled the current breakpoint. This CL aligns Cmd+Shift+B to disable the
current breakpoint as well.

BUG=741115

Review-Url: https://codereview.chromium.org/2977753002
Cr-Commit-Position: refs/heads/master@{#486152}

Bug: 734219
Change-Id: If2e79ab1b2a86ad704ff579d78fd94a7e14df752
Reviewed-on: https://chromium-review.googlesource.com/567660
Commit-Queue: Jared Saul <jsaul@google.com>
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486151}

This is ported form skia fixing https://skia-review.googlesource.com/c/17327/
and https://skia-review.googlesource.com/c/16427/

BUG=710443
TEST=WebGL conformance test:framebuffer-texture-clear.html
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2934733002
Cr-Commit-Position: refs/heads/master@{#486150}

This includes all of filters/ but primarily we want this for any
GpuVideoDecoder changes. Many of the other things in filters/ are
related to VDA/GVD processing, so just include them all.

There doesn't seem to be a PostUploadHook which allows you to
filter based on files anyways...

BUG=none
TEST=none

Change-Id: I53cb8d74ec9bff4152e6bac87e0047410cc58f72
Reviewed-on: https://chromium-review.googlesource.com/567722Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486149}

Change-Id: I3d454f70f477b5ada2608c85dd8b54badf89fa71
Reviewed-on: https://chromium-review.googlesource.com/569000Reviewed-by: Jeff Carpenter <jeffcarp@chromium.org>
Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486148}

Bug: None
Change-Id: I619491887eb97abc493debfeaf20ae260c222f33
Reviewed-on: https://chromium-review.googlesource.com/568820Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486147}

This is needed to run Mus in-process until crbug.com/741106 is fixed.

BUG=722527

Review-Url: https://codereview.chromium.org/2978833002
Cr-Commit-Position: refs/heads/master@{#486146}

I am factoring out some code in DropdownPopupWindow.measureContentWidth() that
determines the widest view in a ListView into a helper method in UiUtils so I
can use it for the spell check menu I'm working on in
https://codereview.chromium.org/2931443003.

Bug: 715365
Change-Id: I59bfc348eac62d07c6deb375bca6b808856911dd
Reviewed-on: https://chromium-review.googlesource.com/566594
Commit-Queue: Ryan Landay <rlanday@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486145}

Right now in html canvas 2d's drawImage API, the image decoding are done
on the main thread, and this task could be heavy when the image is big.
What we hope is to give people an option to call createImageBitmap(SVG)
which does the image decoding in a background thread, and then canvas
drawImage API can draw the image bitmap which is already in a decoded
state.

Bug: 580202
Change-Id: I79cfd46b4e2f154e9fde111b932125a9745571a2
Reviewed-on: https://chromium-review.googlesource.com/558398Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Justin Novosad <junov@chromium.org>
Commit-Queue: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486144}

The counters added here are for methods and attributes that take up
a non-trivial portion (4-10%) of time spent doing Blink C++ on some websites
from the v8_top25 benchmark.

Bug: 724543
Change-Id: Idbab1de4b7128a4a934ca22a7b739c2fa5b035bc
Reviewed-on: https://chromium-review.googlesource.com/565682
Commit-Queue: Adithya Srinivasan <adithyas@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486143}

These methods are never called by other classes, no need to mark them public.

Bug: 
Change-Id: I453e5831d60ac2970029c16fdd3011b012120695
Reviewed-on: https://chromium-review.googlesource.com/565963Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486142}

Bug: 713188
Change-Id: If8d923129a063160caaef22d3908f6f5f7aef2bc
Reviewed-on: https://chromium-review.googlesource.com/565446Reviewed-by: Eugene But <eugenebut@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Misha Efimov <mef@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486141}