- 01 Dec, 2020 40 commits
-
-
Peter Wen authored
Prebuilt jars do not need the full classpath since they are either jars ready to be passed to ijar, or they just need a dep on a non-java target to unzip the jar from its aar. Previously header jars could depend on impl jars due to passing the full classpath for prebuilt jars, but this should not happen as it defeats the purpose of header jars being fast to compile. Added a regression test to ensure chrome_java__header doesn't depend on base_java__impl. Original CL: https://crrev.com/c/2567618 Fixed: - Added back missing transitive header deps. Tbr: cduvall@chromium.org Bug: 1154302 Change-Id: Ib1810ee0c4646d14e8e75372427594c456be8366 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567628Reviewed-by:
Peter Wen <wnwen@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Auto-Submit: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#832551}
-
Adrian Elder authored
Doing this to match other sizes and lengths it is compared with. Bug: 1150460 Change-Id: If20ecddb55527ca603a86dc9db2ba3a3a5f7ebcb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568375Reviewed-by:
Miriam Zimmerman <mutexlox@chromium.org> Commit-Queue: Adrian Elder <aelder@chromium.org> Cr-Commit-Position: refs/heads/master@{#832550}
-
Lukasz Anforowicz authored
The NavigationRequest::OnRequestStarted has been empty since https://crrev.com/c/2551736 and the only non-empty override of NavigationURLLoaderDelegate::OnRequestStarted was in TestNavigationURLLoaderDelegate. This CL refactors the unit tests so they no longer depend on OnRequestStarted and then deletes this method altogether. Bug: 1150940 Change-Id: I9ff794db70e07915e6572fcd9fb96c0edb08ef23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551681 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#832549}
-
Christopher Cameron authored
This addresses two related problems. * An ImageBitmap's color parameters can be anything that is specified by an SkImageInfo. This is sort-of-smashed-into CanvasColorParams during serialization and deserialization. * The function ImageBitmap::CopyBitmapData implicitly does some sort of format and color conversion. In ImageBitmap::GetCanvasColorParams, replace the function with a GetSkImageInfo function (since that's what's used internally anyway). In ImageBitmap::Create, replace this function with one that uses a SkPixmap (since that's what the arguments are converted to). In ImageBitmap::CopyBitmapData, make the caller specify an SkImageInfo to indicate the desired target format. CanvasColorParams should be removed entirely from the serialization and deserialization code. This will be done in a follow-up patch. Bug: 1121448, 1150969 Change-Id: I66936823160098c6f60fcdce2d20abce828b5e42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567482Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#832548}
-
Daniel Murphy authored
This is a reland of d3cc95bb Original change's description: > [WebAppProvider] Test OS hook uninstallation calls & completion logic. > > This patch adds the virtual methods to the uninstallation path, and adds > corresponding tests for those in the unittests file. > > R=phillis@chromium.org > > Change-Id: I316145e6030d16ff3a28bf7fecb3d2cdbac940d4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545864 > Commit-Queue: Daniel Murphy <dmurph@chromium.org> > Reviewed-by: Phillis Tang <phillis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#832087} Change-Id: Ie95af999acb33e2970dd2b9350ff9316cf6f7af5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567820 Commit-Queue: Daniel Murphy <dmurph@chromium.org> Commit-Queue: Phillis Tang <phillis@chromium.org> Auto-Submit: Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Phillis Tang <phillis@chromium.org> Cr-Commit-Position: refs/heads/master@{#832547}
-
Alan Screen authored
Adding support for PrintBackend queries to happen out of the browser process requires related data structures to be made available via a Mojo interface. These are moved into their own mojom file separate from the common definition in printing/mojom since they are specific to a new process being introduced and do not need to be encumbered by the dependencies which exist for print.mojom. Add PrinterBasicInfo to the definitions. This will support forthcoming queries such as EnumeratePrinters and FetchCapabilities. Bug: 809738 Change-Id: I7a87e747a9b58f8e0f8460ecf85fb27466a0a8f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438580Reviewed-by:
Chris Palmer <palmer@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Daniel Hosseinian <dhoss@chromium.org> Commit-Queue: Alan Screen <awscreen@chromium.org> Cr-Commit-Position: refs/heads/master@{#832546}
-
David Tseng authored
Scenario: - two (or more) component extensions request binding of TtsStreamFactory - requests are received in TtsService - there is only one concrete Receiver instance - each request closes the connection to any previously bound TtsStreamFactory connections As a result, any previous connections will be closed prematurely e.g. before the extension can call createGoogleTtsStream. Fix this by keeping around all PendingReceiver instances and process them whenever we can. Specifically, once the extension creates a specific tts stream, process the next pending request for a factory. Test: manual. Observe errors without this change in some rare timing instances where an extension gets a tts stream factory but is disconnected before creating a stream. Observe no such error with this change. R=dmazzoni@chromium.org Fixed: 1131321 Change-Id: Ie0a2803fff809ada42038001fa015e1a6fb63e0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2561540 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#832545}
-
Steve Kobes authored
These logs can now be viewed on official release builds with the flags: --enable-logging=stderr --vmodule=layout_shift*=1 This will make it easier to debug CLS issues for folks who may not have a Chromium checkout handy. Change-Id: Ic273684711b3dfd4e34827eca8cfe4deda744d48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568351 Commit-Queue: Steve Kobes <skobes@chromium.org> Reviewed-by:
Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#832544}
-
Mike Reed authored
Skia now supports explicit controls over the sampling technique: - filtering: nearest, linear, cubic (only works with mipmaps:none) - mipmaps: none, nearest, linear (allows trilerp) See SkSamplingOptions.h Switching to these means skia no longer "changes" the technique based on heuristics (like the direction of the scaling): you always get what you ask for (more predictable). Need to rebaseline tests, as sometimes (e.g.) Skia used to treat "High Qualitty" (ala bicubic) as just bilinear when downscaling. The SkFilterQuality enum is deprecated: it is mapped as follows: kNone. : [ filter:nearest, mipmap:none ] kLow : [ filter:linear, mipmap:none ] kMedium : [ filter:linear, mipmap:nearest ] kHigh : [ filter:cubic, mipmap:none ] You can now specify these directly when you create an ImageShader. Specifying the enum in SkPaint is depcrecated, and will be removed. Bug: skia:7650 Change-Id: I5251b195fbc8ff7e71d3aa76fdc3dde139a35c0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2562751 Commit-Queue: Mike Reed <reed@google.com> Reviewed-by:
Florin Malita <fmalita@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#832543}
-
Noel Gordon authored
Comment only change. No-try: true Bug: 1145029 Change-Id: Ibca0b51f42857bf792b475ecd5361b9ccd045446 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567240 Auto-Submit: Noel Gordon <noel@chromium.org> Reviewed-by:
Alex Danilo <adanilo@chromium.org> Commit-Queue: Alex Danilo <adanilo@chromium.org> Cr-Commit-Position: refs/heads/master@{#832542}
-
chrome://usb-internalsrbpotter authored
Since the underlying issue with grit has been addressed, reland this change. Bug: 1132403, 1150466 Change-Id: Icdf25bae36b3f525f1b0319621dbbd112e95917f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566747 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#832541}
-
Aya ElAttar authored
- Fixed OSExchangeDataProviderNonBacked::Clone to copy the data source object. Bug: 1154232 Change-Id: I2127ff9be7bbc5e9784b91644a8639ffea8b3893 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2563722Reviewed-by:
Darwin Huang <huangdarwin@chromium.org> Commit-Queue: Aya Elsayed <ayaelattar@chromium.org> Cr-Commit-Position: refs/heads/master@{#832540}
-
Elly Fong-Jones authored
Bug: 1154345 Change-Id: Iaa6bf09e84318eaefccc2b12a5599b765580eedd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568356Reviewed-by:
Adithya Srinivasan <adithyas@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#832539}
-
Kenneth Russell authored
The test has become unexpectedly flaky on these two platforms. Bug: 1154088 Change-Id: Iefcc66352fd603b1cbc807db46b67c8a52cd73d9 Tbr: rjkroege@chromium.org Tbr: zmo@chromium.org No-Try: True Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566308Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#832538}
-
Yi Gu authored
This patch first splits the test into two to test UMA / UKM separately. For UMA test, it - adds a run loop to make sure the JavaScript has been executed. - adds a call to |FetchHistogramsFromChildProcesses| to make sure that the necessary render process could be initialized before fetching the histograms. crrev.com/c/1804574 updated the functionality of this helper function. Bug: 1141862 Change-Id: Id119b2b01d0f46faab56cd0739e78a5fbeadf2c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566250 Commit-Queue: Yi Gu <yigu@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Cr-Commit-Position: refs/heads/master@{#832537}
-
Mark Schillaci authored
This CL updates the aria-haspopup support on Android. With the current implementation, we communicate "pop up button" as the role description for any element with a non-trivial haspopup value. With this change, we now differentiate between some values of aria-haspopup. Namely, for values of "true" and "menu", we will now set a role description of: "menu pop up button" and for a value of aria-haspopup="dialog", we will set a role description of: "dialog pop up button" and for the remaining roles (listbox, tree, and grid), we will keep the original "pop up button". We also update the mapping of aria-haspopup to classname on Android. We have been setting it as android.widget.Spinner, but this is not the best fit. With this change we use the default mapping to android.view.View. We also update the ax_node_object implementation of aria-haspopup to no longer consider unknown values as menu, but to consider them false. AX-Relnotes: Added more precise utterances for aria-haspopup values. Bug: 1090145, 1117588 Change-Id: I5090352d04d91ddf63a98d817d74c477ed2f294f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2561638Reviewed-by:
Mark Schillaci <mschillaci@google.com> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Reviewed-by:
-
Xida Chen authored
The ScrollbarController::GetScrollDeltaForScrollbarPart function currently returns int, where under FractionalScrollOffset it should return float. As a matter of fact, its call site is already expecting a float. This CL makes that function return a float value, as a result, two layout tests pass. Bug: 1150389 Change-Id: I542794304f34002021961fba3b48a26383ccfdc5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566152 Commit-Queue: Xida Chen <xidachen@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#832535}
-
Mitsuru Oshima authored
Bug: 1150492 Change-Id: Ifd8e735f5682ffc6f09ebcddc22f43cbcd5300ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2562158Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#832534}
-
Yann Dago authored
Bug: 1149460 Change-Id: Iade593c9fef6a96f362d823d8c267f559632d5ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2562228 Commit-Queue: Yann Dago <ydago@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Cr-Commit-Position: refs/heads/master@{#832533}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1606802354-2e3be99fee27d60bc23828ee78c917e6dcb3614e.profdata to chrome-win32-master-1606813079-a344323d078b1a32606141a981583fdc5b0903fc.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I06178834c1827b937224a67c4e36260874a05697 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567814Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#832532}
-
Michael Hansen authored
Adjusts the plural form of the string for the "unreachable contacts" message to make the rest of the sentence use plural forms where appropriate. Screenshot: https://screenshot.googleplex.com/7NWXZtQ7t2CTaWK.png Fixed: b:174502944 Change-Id: Id8fc82cbed9e22cae6a1893bde6be534f12689bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568430Reviewed-by:
James Vecore <vecore@google.com> Commit-Queue: Michael Hansen <hansenmichael@google.com> Cr-Commit-Position: refs/heads/master@{#832531}
-
Clark DuVall authored
This will hopefully improve performance in Android N (and earlier versions). See bug for more details. Bug: 1154056 Change-Id: I80f976761e24a14fa20f8d7d1de5f2058197ec58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566339Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#832530}
-
Idries Hamadi authored
Bug: 1083005 Change-Id: I76662c2ae7db8b047b01421b1e6a2c9d863cf643 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2563541Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Auto-Submit: Idries Hamadi <idries@google.com> Commit-Queue: Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#832529}
-
Sonny Sasaka authored
Privacy has approved this log feature. So flipping the flag to let this be tested on canary and dev channel. Bug: b:172273364 Change-Id: I91fa3a30f617aa36c2ae24ea42c15c9045996aee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568264Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Sonny Sasaka <sonnysasaka@chromium.org> Cr-Commit-Position: refs/heads/master@{#832528}
-
Gabriel Charette authored
TBR=qjw@chromium.org Bug: 1154381 Change-Id: I0cbc9db695164c008f4a3fd76f2be5f5fbf51a38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568454 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#832527}
-
Chris Davis (EDGE) authored
This is a reland of 4edc0503. With the fix in clang for the delay load crash previously hit with this change I am relanding this. Bug: 1132179 Original change's description: > Add dbghelp.dll to delay load list > > Currently, many of the binaries have a static dependency on dbghelp.dll. > This results in dbghelp getting loaded in all chrome processes. Upon > inspection, dbghelp.dll is only necessary for stack sampling and mini > dump handing in crashpad. Stack sampling is only enabled by default on > unofficial builds of dev and canary. All other times we are needlessly > loading this module which brings in 300k of image file refset and 60k > of Copy on Write costs per process. This change adds it to the delay > load list. > > Change-Id: I13da0ce0735431c5c51cdbc9ba2cfea0cc3cded7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336541 > Commit-Queue: Chris Davis <chrdavis@microsoft.com> > Reviewed-by: Cliff Smolinsky <cliffsmo@microsoft.com> > Reviewed-by: Bruce Dawson <brucedawson@chromium.org> > Reviewed-by: Nico Weber <thakis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#796707} Change-Id: I5f946d76af853c2d277f670b99479e874e784f44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523245Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Cliff Smolinsky <cliffsmo@microsoft.com> Commit-Queue: Chris Davis <chrdavis@microsoft.com> Cr-Commit-Position: refs/heads/master@{#832526}
-
Michael Thiessen authored
BaseActivityTestRule is meant as a chromium replacement to ActivityTestRule, fixing a number of issues with the class and providing more flexibility. Bug: 1146574 Change-Id: I4a722700c88fe1881d5dcacd098a30bab3adb774 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2555901 Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#832525}
-
Rune Lillesveen authored
This is in preparation for being able to share FontFaceCache between CSSFontSelectors which share the same @font-face rules via the same set of StyleSheetContents. Bug: 336876 Change-Id: I65b0aec9077b54465d74f48a66230679a854346d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2562380 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#832524}
-
Elly Fong-Jones authored
Bug: 1154345 Change-Id: I9294122e63a9d319fae7c1b4200eff08d2b6d640 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568261 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/4f7b9247..ac41b8da Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I42dd6789990f19c30f5012562a041674f4feb446 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567495Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#832522}
-
Joel Riley authored
Also created two new window layers, positioning the focus ring and the highlight layers below the select-to-speak panel components. AX-Relnotes: N/A Bug: 1143814 Change-Id: I37c9c6eb4fda6326ac78e82550fdc3ea02d116b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553981 Commit-Queue: Joel Riley <joelriley@google.com> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#832521}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/6c54473c3710..684460d29eb4 2020-12-01 msavigny@google.com Add remote-disabled support for reclient in autoninja. 2020-12-01 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1149386 Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: Ied0e4f6a2c014f6ff5c34aa4da16db4b54911e1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568134Reviewed-by:
-
Xiaoqian Dai authored
Bug: 1153877 Change-Id: I4140a53d43aac2e2eae377c9108ce27b9b3d5597 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566301 Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#832519}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1606802354-186e0b734d39b05126048ed00a5f975d199f5c7c.profdata to chrome-win64-master-1606834243-e828e7c1abf6992c40e6e24872b0e913b727a4f7.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I1885226bffda23181ea02c000cad96adb96ac0b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567821Reviewed-by:
-
Dave Tapuska authored
Remove some springboards RenderWidget was used to call into blink. The callees can do it directly themselves. Remove RenderWidgetDelegate it does nothing anymore. Use GetLocalRootWebFrameWidget() instead of GetLocalRootRenderWidget()->GetWebWidget() BUG=1097816 Change-Id: Iea3bf7936aae4f01220dcd425c38daadad999212 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2562788 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
-
Michael Bai authored
No functionality change Bug: 1151542 Change-Id: I5c3acb2dc12e84bf4c9d3a1d01fb5c4b7e64ab39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566336Reviewed-by:
Dominic Battré <battre@chromium.org> Commit-Queue: Michael Bai <michaelbai@chromium.org> Cr-Commit-Position: refs/heads/master@{#832516}
-
Yusuke Sato authored
This is a follow-up CL for https://chromium-review.googlesource.com/c/chromium/src/+/2559533 BUG=None TEST=try Change-Id: I8b0624083dfd94110ede99b4f79ed0011d832727 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2561048Reviewed-by:
Willie Koomson <wvk@google.com> Commit-Queue: Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#832515}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/df873e5fa6d3..0c47015b57a0 2020-12-01 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 9dff6a3bb595 to bfb211914759 (4 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: ianelliott@google.com Change-Id: Ibf1d40d67f9a1ab663d2b55f4ffc41fc69c49d35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566363Reviewed-by:
-
Andrew Xu authored
The bug was introduced by https://crrev.com/c/2542925 The problem is: the contents view's insets are ignored when setting a menu item's height. To solve this bug, all constants related to multipaste menu views are grouped in one file. It increases the code readability. Bug: 1154070 Change-Id: Ie44ecf40afd1796ce6d18ccd8be921c29ee79199 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566448Reviewed-by:
David Black <dmblack@google.com> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Andrew Xu <andrewxu@chromium.org> Cr-Commit-Position: refs/heads/master@{#832513}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/356cef301b81..0c2cc2356170 2020-12-01 mtklein@google.com rearrange types in SkRuntimeEffect program_fn() 2020-12-01 herb@google.com use SkGlyphRect to record subrun bounds 2020-12-01 csmartdalton@google.com Extract reusable functions from stroke tessellation shaders 2020-12-01 mtklein@google.com disambiguate skvm::bit_cast() 2020-12-01 ethannicholas@google.com Allow SkASSERTF to take zero varargs parameters 2020-12-01 mtklein@google.com remove "half" term from SkVM If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC westont@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: westont@google.com Change-Id: Ibb28e22d160aa26545d22337452060844e5b9bf6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568370Reviewed-by:
-
