GitLab

Bug: 1095619
Change-Id: Iff442fa0efdb30288648349c6bcfccb33dee3a7f
AX-Relnotes: n/a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260393Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: Alexander Surkov <asurkov@igalia.com>
Cr-Commit-Position: refs/heads/master@{#781952}

As part of making GestureStateListener.onScrollOffsetOrExtentChange
work again (
https://chromium-review.googlesource.com/c/chromium/src/+/2222623 )
I made it so that the browser gets any change in RenderFrameMetaData
when an infobar is present and the root-scroll-offset changes.
Unfortunately this regressed some perf tests. The test are triggering
an infobar to show, and then scrolling through the whole page without
dismissing. Uma stats indicate this isn't that uncommon, so it seems
worth fixing.

This patch creates a one off message (OnRootScrollOffsetChanged)
that is sent if root scrolls have been requested and the frame would
not normally be sent to the client.

https://pinpoint-dot-chromeperf.appspot.com/job/139b3471120000
is a pinpoint run that shows this gives back some portion of the
loss. In order to get back all the performance, a more complex
patch is likely needed. Given branch is Thursday, I'm landing this
patch now to give back some of the performance.


BUG=1091451

Change-Id: I54cc55a6dab1dc716978eb7d25cb932bfb662ee5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2257407Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: kylechar <kylechar@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781951}

This change cleans up instances where the original browser context,
returned by Profile::GetOriginalProfile(), was referred to instead as
the "master" context. This term is uninclusive and doesn't match the
name used elsewhere.

Bug: 1097189
Change-Id: Ie051677987f7d6decf6c7d25a2a5d191ee270e53
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261700
Auto-Submit: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org>
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781950}

In the FrameSequenceTracker trace events, include stats only from the
'effective thread' (i.e. the thread driving the effect), instead of
including both main and compositor-threads.

BUG=1095186

Change-Id: I60666ce16a288a9d4a7fcd9cc27418fd4807b6b5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261398
Auto-Submit: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: Xida Chen <xidachen@chromium.org>
Reviewed-by: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781949}

Bug: b/158630837
Test: manually.
Change-Id: I1a5158d54c8c4bd941c37d036c5be535175e9aa9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261370Reviewed-by: Tao Wu <wutao@chromium.org>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Commit-Queue: Meilin Wang <meilinw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781948}

Roll Chrome Win64 PGO profile from chrome-win64-master-1592999982-7acc1dacb3c35b59c797d873c3b61ca4b0010cd2.profdata to chrome-win64-master-1593007185-9f44ccb8893f05162537134149388feea4a6ce51.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium
Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: chrome/try:win64-chrome
Tbr: jeffyoon@google.com,liaoyuke@google.com
Change-Id: I73cbc2c98d6b5cdb23e92205c21473becb8626e5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264388Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#781947}

Bug: 1098387
Change-Id: I7bf459692cf7746bea954264cd749ffb5f32d047
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261095Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781946}

Bug: 1066263
Change-Id: I4548f13ad9e34b0b64c8d09e006c2cfa0dca365e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260877
Commit-Queue: Evan Stade <estade@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781945}

This is equivalent to the ThreadPoolInstance configuration that the
GPU process was implicitly getting from ChildProcess::ChildProcess
(constructed from GPUProcess::GPUProcess). Modulo the added ability to
explicitly name this ThreadPool and have independent metrics :).

The ThreadPoolInstance is still started at virtually the same order as
before so semantics should be equivalent for the GPU process.

This is necessary otherwise etienneb's fix for crbug.com/1091259
is a no-op in production due to the early-bail if there's no
ThreadPoolInstance on init (added for tests, breaks prod).

R=chromium-metrics-reviews@google.com, sunnyps@chromium.org

Bug: 1091259
Change-Id: I3ce25ac70bb4d1980e3d38ae6f90851041632bd7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255655
Commit-Queue: Zhenyao Mo <zmo@chromium.org>
Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Auto-Submit: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781944}

This is a reland of 6eda333b

The test-only bug which elicited the revert has been fixed,
so this is relanding the original CL unmodified.

Original change's description:
> Add MojoDedicatedThread field trial testing config
>
> Bug: 1082761
> Change-Id: Ief2b018876f8cb2ad77495c7158db5c53fd8c206
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2240407
> Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
> Commit-Queue: Ken Rockot <rockot@google.com>
> Cr-Commit-Position: refs/heads/master@{#777367}

Bug: 1082761
Tbr: asvitkine@chromium.org
Change-Id: Icefe444d49199e402a772775f687374b7c14b1c6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264732
Commit-Queue: Ken Rockot <rockot@google.com>
Reviewed-by: Ken Rockot <rockot@google.com>
Cr-Commit-Position: refs/heads/master@{#781943}

This CL changes to use forward declarations of other IDL dictionary
types in header files of IDL dictionaries.
This change is to clear circular inclusions between dictionaries.


Bug: 839389, 1060478
Change-Id: Idcc18de01999aae18f5204669b6950cbdf825fd1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248390
Commit-Queue: Hitoshi Yoshida <peria@chromium.org>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781942}

Bug:1098806

Tbr: dominickn@chromium.org
Change-Id: I85a5d9fe282450d466c8942adfbee70d03347f90
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264617Reviewed-by: Patrick Noland <pnoland@chromium.org>
Commit-Queue: Patrick Noland <pnoland@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781941}

This reverts commit a361d30d.

Reason for revert: Fixed test failure from crbug.com/1097635

Original change's description:
> Revert "bluetooth/winrt: Observe discovery failures"
>
> This reverts commit e44abb7d.
>
> Reason for revert: Fails on Win DBG builder.
>
> Original change's description:
> > bluetooth/winrt: Observe discovery failures
> >
> > Change BluetoothAdapterWinrt to subscribe to
> > BluetoothLEAdvertisementWatcher::Stopped events. The event fires if
> > scanning for LE advertisements has been cancelled by the application or
> > due to an error. Once the event is received, mark all active
> > BluetoothDiscoverySession instances inactive, which will cause
> > BluetoothAdapter::IsDiscovering() to return false.
> >
> > Also make BluetoothAdapterWinrt call Observer::DiscoveringChanged().
> >
> > Change-Id: If4abf65f09b4d20b89b53adb63dad89939ddcceb
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255549
> > Commit-Queue: Martin Kreichgauer <martinkr@google.com>
> > Commit-Queue: Martin Kreichgauer <martinkr@chromium.org>
> > Reviewed-by: Reilly Grant <reillyg@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#780539}
>
> TBR=reillyg@chromium.org,martinkr@chromium.org
> BUG: 1097635
> # Not skipping CQ checks because original CL landed > 1 day ago.
>
> Change-Id: I5b2e012bee60c94d735f95aa49cf90db2adff016
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255946
> Reviewed-by: Fergal Daly <fergal@chromium.org>
> Commit-Queue: Fergal Daly <fergal@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#780660}

TBR=reillyg@chromium.org,martinkr@google.com,fergal@chromium.org,martinkr@chromium.org

# Not skipping CQ checks because this is a reland.

Change-Id: Ia924fe22558e323d4b56813ec8018de228e5a36d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2257564Reviewed-by: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Martin Kreichgauer <martinkr@google.com>
Cr-Commit-Position: refs/heads/master@{#781940}

Test is flaky.

TBR=oshima@chromium.org

Bug: 1098810
Change-Id: I6cc56badc887f0f7743492b92d0ec705e52fa3b7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264796Reviewed-by: Chrome Cunningham <chcunningham@chromium.org>
Commit-Queue: Chrome Cunningham <chcunningham@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781939}

This patch fixes an issue where VK show/hide APIs were not able to
execute when an EditContext was active as the manual policy was only
evaluated for editable elements and not for EditContext.

Bug: 856269

Change-Id: Id5d6614252675e360baaeb9c76e7c6ed68795aa7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261953
Commit-Queue: Anupam Snigdha <snianu@microsoft.com>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781938}

|container| should be |self.container|. This causes Diff() to fail in
SuperSize-console.

TBR=agrieve@chromium.org

Bug: 1040645
Change-Id: Ie82e63f6449b905e628ebf884fd157c603dc6bf7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264753Reviewed-by: Samuel Huang <huangs@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Samuel Huang <huangs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781937}

Bug: 1098472
Test: manual test
Change-Id: Iffdfc41e4b408fc2c99112e3b27f20e196ade911
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261879Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Li Lin <llin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781936}

This service is required.

Bug: 1094035
Change-Id: I9f13d02df4edcaa411b3c32dd9408594b5864586
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255781
Auto-Submit: David Dorwin <ddorwin@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Commit-Queue: David Dorwin <ddorwin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781935}

This matches the external intent handling in Chrome, where a WebApk is
opened without a chooser dialog when it's the only non-browser handler
for an intent.

WebApkValidator, WebApkVerifySignature, and some constants are moved
to //components/webapk in a directory and build target structure that
mirrors //chrome/android/webapk, i.e. separate "client" and "common"
libraries.

Bug: 1063874
Change-Id: I55fb0968489a4a919bb383b182413e913091a020
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254350
Commit-Queue: Evan Stade <estade@chromium.org>
Reviewed-by: Peter Kotwicz <pkotwicz@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781934}

This takes care of the case where `url_loader_` posts the callback,
then Cancel() is called before the callback's task was executed,
deleting the object. Following this CL, since now a WeakPtr is used,
that task will just be nullified.

Bug: 1092071
Change-Id: If93c9f9ebef272a648d5eaf9578c5f060de48263
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260614
Commit-Queue: Elad Alon <eladalon@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781933}

The change to always cache the base computed style safeguarded against
reusing it to optimize style recalculation when not appropriate, but not
against DCHECK verification that the same results would be produced.
By only fetching the cached style when it can be used, we ensure that it
can be validated as well.

Bug: 1098371, 1098254
Change-Id: Ie0366189af809ecd9bc9b6018292ef54a516b8d1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261168
Commit-Queue: Kevin Ellis <kevers@chromium.org>
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781932}

The feature is enabled by default, so we don't need to use the feature
flag that enables it.

Bug: N/A
Change-Id: I7d404fdbf0111ffc8b94fc8afc75a84a8a3eb944
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258341Reviewed-by: Scott Little <sclittle@chromium.org>
Commit-Queue: Dominic Farolino <dom@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781931}

Change-Id: Ibfd730d29f853614d3781106c9e1cf96209fdf48
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261485
Commit-Queue: Nate Chapin <japhet@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Scott Haseley <shaseley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781930}

This is consistent with what we do for ARC++ mojom APIs and should help
spread the review load a bit.

Bug: none
Change-Id: I984838644b64c371b040cf355e3ddcdb83c6b210
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264795
Auto-Submit: James Cook <jamescook@chromium.org>
Commit-Queue: Jorge Lucangeli Obes <jorgelo@chromium.org>
Reviewed-by: Jorge Lucangeli Obes <jorgelo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781929}

This reverts commit 5906c258.

Reason for revert: It breaks release component builds (see crbug.com/1098761).

Original change's description:
> Abseil component build (default symbols visibility).
>
> This CL introduces an Abseil component on which all Chromium Abseil
> clients will have to depend on.
>
> Abseil doesn't export symbols explicitly, so for the moment Chromium
> exports all of them when is_component_build=true. On Android, Linux and
> Mac -fvisibility=default is used while on Windows a .def file is
> generated at Abseil roll time.
>
> Bug: 1046390
> Change-Id: I1697eb9e0179cee01badcf1b687acd94160e5f6d
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2174434
> Commit-Queue: Mirko Bonadei <mbonadei@chromium.org>
> Reviewed-by: Nico Weber <thakis@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#781225}

TBR=thakis@chromium.org,mbonadei@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

TBR=thakis@chromium.org

Bug: 1046390, 1098761
Change-Id: I7d456be38a42f1ea0a130e1a5305c3d515e26588
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264060
Commit-Queue: Mirko Bonadei <mbonadei@chromium.org>
Reviewed-by: Mirko Bonadei <mbonadei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781928}

This relands commit 0b009d85.

Original change's description:
> WebLayer: hook up CookieControlsBridge.
>
> When enabled, and when third party cookies are being blocked, this will
> show an extra toggle in the page info bubble.
>
> Test: run_weblayer_shell example.com --args="--enable-features=\"ImprovedCookieControls\""
> Bug: 1071775
>
> Change-Id: Ib0a6d6a1c80cafa4b8aeeea19cb9919df55a7f83
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2240011
> Reviewed-by: Mugdha Lakhani <nator@chromium.org>
> Reviewed-by: Ted Choc <tedchoc@chromium.org>
> Reviewed-by: Christian Dullweber <dullweber@chromium.org>
> Commit-Queue: Evan Stade <estade@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#781552}

Bug: 1071775
Change-Id: I6233d790786d4445df0f57406f1143701eebda2e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264793Reviewed-by: Christian Dullweber <dullweber@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781927}

Tests were occasionally failing due to having an unexpected extra app
counted in ExtensionBrowserTest::InstallOrUpdateExtension. This was
because the test is awaiting the new BMO system to complete an install
but not the async legacy extension-based install that is fired
simultaneously by the new system. If the legacy install happens to
complete between counting num_before and num_after then we saw the web
app as an extra, unexpected installed extension.

Bug: 1094616
Change-Id: I2a14717e3f84102497c7a42c5b30bd6a5f868ed4
Fixed: 1094616
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2262357Reviewed-by: Alexey Baskakov <loyso@chromium.org>
Reviewed-by: Glen Robertson <glenrob@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Auto-Submit: Glen Robertson <glenrob@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781926}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/fb3f068d..a7f8bc43

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: Iabe51be723bccd92e959821c39b9cab103a9e069
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264672Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#781925}

In catapult a new metric is being added to measure the time spent doing
memory ablation.
  https://chromium-review.googlesource.com/c/catapult/+/2187206

We previously enabled the tracing categories needed to enable this metric
  https://chromium-review.googlesource.com/c/chromium/src/+/2246931

This change adds the new metric to rendering and loading benchmarks.

Bug: 908462
Change-Id: Id7cc2bce51a002733d9419d3ef3b6e1969fb25a0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259487Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781924}

This is really testing the default we set up our testing system with,
which is not very interesting to test.  It can fail sometimes.
We don't really need the test.  We will soon remove the flag anyway.

Bug: 1085154
Change-Id: I41d1ead40f6943e0022c71d859351ebc4e7d4e9c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261181Reviewed-by: Carlos Knippschild <carlosk@chromium.org>
Commit-Queue: Peter Williamson <petewil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781923}

Currently, we have two places (outside of Blink... three in total, but
that's for another day) where we compute requests' referrers, nominally
according to [1, Algorithm 8.1].

This change makes a couple alterations to
URLRequestJob::ComputeReferrerForPolicy (one of the places) to bring it
in line with the behavior in content::Referrer::SanitizeForRequest
(another). With this change, ComputeReferrerForPolicy will:
- truncate requests with referrers longer than 4096 bytes to the
initiating origin;
- respect the CapReferrerToOriginOnCrossOrigin base::Feature, which
adds an optional layer of referrer truncation on top of whatever's
specified by the operative referrer policy; and
- use GURL::GetAsReferrer to strip the referrer before returning it
[1, Algorithm 8.4].

One detail worth mentioning is the behavior change concerning requests
with referrers with !GURL::SchemeIsValidForReferrer. GURL::GetAsReferrer
actually does two things: first, it strips the URL for use as a referrer
in the sense of [1, Algorithm 8.4]; second, it returns GURL() if the
URL does not satisfy GURL::SchemeIsValidForReferrer. Previously, since
URLRequestJob::ComputeReferrerForPolicy wasn't calling GetAsReferrer, it
let URLs through with !SchemeIsValidForReferrer. After the change, it
will now return GURL() for these URLs, which seems like the desired
behavior given that it's how content::Referrer::SanitizeForRequest and
blink::SecurityPolicy::GenerateReferrer behave.

This change is a precursor to getting rid of
content::Referrer::SanitizeForRequest (more specifically, removing all
of its business logic and just delegating to
URLRequestJob::ComputeReferrerForPolicy). There is one notable way in
which it does *not* bring URLRequestJob::ComputeReferrerForPolicy
directly in line with content::Referrer::SanitizeForRequest:
content::Referrer::SanitizeForRequest currently returns an empty
referrer for requests with *destinations* of non-HTTP(S) scheme, but
this behavior is not mandated by the standard and disagrees
with the logic in both URLRequestJob and blink::SecurityPolicy; the 2014
CL implementing it [2] does not contain a specific motivation for the
behavior.

[1]:
https://w3c.github.io/webappsec-referrer-policy/#parse-referrer-policy-from-header
[2]: https://codereview.chromium.org/438283002

Bug: 1094526
Change-Id: I80c6cd51f56a220e4e3f78fa32d7e8faccd09a85
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2243992Reviewed-by: Dominic Farolino <dom@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Auto-Submit: David Van Cleve <davidvc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781922}

* Convert enum -> enum class
* Rename values for consistency and clarity
* Rename/modify helpers for brevity and clarity
* Move values and helpers to .cc to keep .h shorter
* Use helpers more consistently

Bug: none
Change-Id: I12987b7c7dd8dd4589bbada0f23688309ece95fc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2256362
Commit-Queue: Shakti Sahu <shaktisahu@chromium.org>
Reviewed-by: Shakti Sahu <shaktisahu@chromium.org>
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781921}

Ensures the switch access extension is not unloaded until
the disable dialog is accepted by the user. This allows users
to use switch access switches to accept or cancel the dialog.

AX-Relnotes: n/a
Bug: 1095212
Change-Id: I0c34d1e8c3669faedf27bdbc9d45e4c7b5b29736
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261185
Commit-Queue: Katie Dektar <katie@chromium.org>
Reviewed-by: Anastasia Helfinstein <anastasi@google.com>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781920}

non-cq has been migrated. removing stale unused definition.

Bug: 912681
Change-Id: I169b2cc91c08004ce7cf5ebfacb3b4413f910c10
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2256443Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Commit-Queue: Jeff Yoon <jeffyoon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781919}

On non-iOS platforms RecordMainFrameNavigation is called from
NavigationMetricsRecorder::DidFinishNavigation. This CL moves
RecordMainFrameNavigation call from PageLoaded callback to
DidFinishNavigation callback to match other platforms.

This CL changes the frequency of logged page load metrics on iOS,
so old histograms were marked as obsolete and suffix "2" was
added to new histograms names.

Bug: None
Change-Id: I47dc6d7051a88cb8b51957a224c4c771965a4623
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2240350
Commit-Queue: Avi Drissman <avi@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Ramin Halavati <rhalavati@chromium.org>
Reviewed-by: Christopher Thompson <cthomp@chromium.org>
Reviewed-by: Emily Stark <estark@chromium.org>
Auto-Submit: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781918}

Today, TaskQueueThrottler invokes OnWakeUp() on all its BudgetPools
when it pumps throttled tasks. If a TaskQueueThrottler contains
sets of TaskQueues controlled by different WakeUpBudgetPools with
different wake up intervals, whenever a WakeUpBudgetPool allows a
wake up for its TaskQueues, other WakeUpBudgetPools record the
wake up and allow their TaskQueues to run (even if this doesn't
respect their wake up interval).

With this CL, the next granted run time is tracked for each TaskQueue.
When there is a wake up, instead of invoking BudgetPool::OnWakeUp()
on all BudgetPools, we invoke it only on BudgetPools for which at least
one queue has reached its next granted run time. This ensures that a
wake up in a task queue controlled by a set of BudgetPools does not
affect task queues controlled by an independent set of BudgetPools.

Also, an artefact of this change is that increasing the wake up
interval of a WakeUpBudgetPool reschedules wake ups that are already
scheduled (before, increasing the wake up interval did not affect an
already scheduled wake up).

Bug: 1075553
Change-Id: I79a57ae99d51103f4b5a10b71802816cf58026fd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260952
Commit-Queue: François Doray <fdoray@chromium.org>
Reviewed-by: Oliver Li <olivierli@google.com>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781917}

Adds driver 26.20.100.8141 as a target for both HD 630 and UHD 630 GPUs
for stable GPU testerse, as the driver has been qualified and the
upgrade will be rolled out in the near future.

Bug: 1053803
Change-Id: I6de2c27bcedd71b05829c7c52e3aea754c1bdc23
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258679
Auto-Submit: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781916}

Looks like this is one of two issues causing the current query
to not find the assigned machine:

https://chromium-swarm.appspot.com/task?id=4cffe1b5410d6110&o=true&w=true

TBR=mark@chromium.org

Bug: 1098454
Change-Id: If294766c1e94e1dcfd9d7b0b99f148cf8d8dff0b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264260
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781915}

Replaces Criteria.equals usage as part of the migration.

See https://groups.google.com/a/chromium.org/g/java/c/ZSj5TANUy8Q/m/gFL8BCVmBgAJ
for more details.

BUG=1071247

Change-Id: I921183f206930fd668fd39178bde892b7c309c3a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261107Reviewed-by: Evan Stade <estade@chromium.org>
Commit-Queue: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781914}

No behavior change.

The 11 SDK linker warns that building for both 10.6 and 10.7 is
deprecated and we build with -fatal_warnings, to that's a build error.

Ideally we get a flag to disable this warning. Else we could not pass
-fatal_warnings for this target and have a linker wrapper again to
filter out the warning ( :/ ), or we could bump up the deployment
target (which after this change requires changing only a single
number instead of 2). But that's for a future CL.

Bug: 1098738
Change-Id: I7952345f1333be023fab997cbf81baf394dfcc40
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264592
Auto-Submit: Nico Weber <thakis@chromium.org>
Commit-Queue: Mark Mentovai <mark@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781913}