- 30 Aug, 2018 40 commits
-
-
erikchen authored
This CL adds two new heap profiling modes: "utility-sampling" and "utility-and-browser". The former mode will profile all utility processes at startup, with 1/3 probability. The latter will profile all utility processes and the browser process [currently just useful for tests]. In addition to some small plumbing and tests, this CL modifies UtilityThreadImpl::Init to call "GetContentClient()->OnServiceManagerConnected(connection);". The callback OnServiceManagerConnected() was not getting propagated to the ChromeContentClient in the utility process [this was a bug]. The profiling process itself is a utility process and must never be profiled -- that will cause deadlock. This is avoided by adding an early out to Client::StartProfiling for the utility process. The newly added tests confirm that we don't deadlock even when attempting to profile all utility processes. Change-Id: I74e2921d7ceff6150080c182db756be9ac0d076b Bug: 878431 Reviewed-on: https://chromium-review.googlesource.com/1195836Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#587699}
-
Jeremy Roman authored
This code only ever waits not at all (equivalent to doing nothing) or forever (equivalent to using Wait), so drop TimedWait. This both makes the code simpler and clearer, and drops the only usage of the WTF::Mutex "absolute time" semantics. This helps clear the path for adopting base-style semantics for TimedWait instead. Bug: 856641 Change-Id: I912b01b475173b965c7990cb4d3476c2eb21fae5 Reviewed-on: https://chromium-review.googlesource.com/1183592Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#587698}
-
erikchen authored
The script to compare deterministic builds was recently fixed to actually generate .isolated files. Unfortunately, there are many .isolated files which are not deterministic. This CL adds them to the whitelist. Bug: 879249 Change-Id: I4368e776baac80a66976e399b4eb0b94ed44b2ed Reviewed-on: https://chromium-review.googlesource.com/1196866Reviewed-by:
Marc-Antoine Ruel <maruel@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#587697}
-
Scott Violet authored
GetExtraHitTestShapeRects() is called solely from WindowTargeter::EventLocationInsideBounds(). As CustomTargeter completely overrides EventLocationInsideBounds() there is no need to also override GetExtraHitTestShapeRects(). This removes the unnecessary override. I'm also removing the implementation of Surface::GetHitTestShapeRects() to the test, as that is now the only place that needs to call it. BUG=878836 TEST=covered by tests Change-Id: I75569904bdfe5bd4d4384436488e4cc0b224ee3d Reviewed-on: https://chromium-review.googlesource.com/1196913Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#587696}
-
Sunny Sachanandani authored
GL_COMMANDS_ISSUED_CHROMIUM is sufficient for shared memory GpuMemoryBuffers because they're uploaded using glTexImage2D (see GLImageMemory::CopyTexImage). This should reduce the number of idle wakeups in the GPU process, and reduce the CPU time spent on such queries which is quite high on Windows. Bug: 830084, 622491 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I8111b3d7f12abbf900383d45e2a74394848e83fd Reviewed-on: https://chromium-review.googlesource.com/1189126 Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#587695}
-
Clark DuVall authored
This reverts commit 34141782. Reason for revert: Caused Finch seed freshness regression, see http://crbug.com/879252 and http://crbug.com/879115 Original change's description: > Reland "Reland "Migrate ResourceRequestAllowedNotifier to NetworkConnectionTracker"" > > This is a reland of e00fddec > > Needed to initialize variables in ChromeBrowserMainBrowserTest for asan/msan. > Verified this works with msan build. > > Original change's description: > > Reland "Migrate ResourceRequestAllowedNotifier to NetworkConnectionTracker" > > > > This is a reland of a9ed46b7 > > > > ChromeBrowserMainBrowserTest.VariationsServiceStartsRequestOnNetworkChange > > was flaky in the original change. Added logic in the test to wait for the > > connection type change. > > > > Only diffs from original are in chrome/browser/chrome_browser_main_browsertest.cc > > > > Original change's description: > > > Migrate ResourceRequestAllowedNotifier to NetworkConnectionTracker > > > > > > A getter is used for NetworkConnectionTracker because some services that > > > use ResourceRequestAllowedNotifier are initialized early in browser > > > startup (e.g. VariationsService), and only perform the initialization > > > of ResourceRequestAllowedNotifier later on the UI thread. The getter > > > allows us to run get the connection tracker at that point so we don't get > > > DCHECKs about being on the UI thread when running > > > content::GetNetworkConnectionTracker(). > > > > > > This also moves the NetworkConnectionTracker in ios/ from BrowserState to > > > ApplicationContext, which is available everywhere. It also matches non-IOS > > > usage more closely, since we have it as a global there. > > > > > > Bug: 868021 > > > Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet > > > Change-Id: I130c6b47feb90f0f7f0776ccc65666414a1ae802 > > > Reviewed-on: https://chromium-review.googlesource.com/1180360 > > > Reviewed-by: Eugene But <eugenebut@chromium.org> > > > Reviewed-by: Robert Sesek <rsesek@chromium.org> > > > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > > > Reviewed-by: Robbie McElrath <rmcelrath@chromium.org> > > > Commit-Queue: Clark DuVall <cduvall@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#584849} > > > > TBR=eugenebut@chromium.org,rsesek@chromium.org,rmcelrath@chromium.org,jam@chromium.org > > > > Bug: 868021 > > Change-Id: I5941b72474657159f0d4a1e6667fd77a3c475887 > > Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet > > Reviewed-on: https://chromium-review.googlesource.com/1185602 > > Reviewed-by: Clark DuVall <cduvall@chromium.org> > > Reviewed-by: Robbie McElrath <rmcelrath@chromium.org> > > Commit-Queue: Clark DuVall <cduvall@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#585387} > > TBR=eugenebut@chromium.org,rsesek@chromium.org,rmcelrath@chromium.org,jam@chromium.org > > Bug: 868021, 876861 > Change-Id: I46fccf072d0b3080603e97c73ff055ac7c45e723 > Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet > Reviewed-on: https://chromium-review.googlesource.com/1187081 > Commit-Queue: Clark DuVall <cduvall@chromium.org> > Reviewed-by: Clark DuVall <cduvall@chromium.org> > Cr-Commit-Position: refs/heads/master@{#585565} TBR=jam@chromium.org,eugenebut@chromium.org,rsesek@chromium.org,rmcelrath@chromium.org,cduvall@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 868021, 876861, 879252, 879115 Change-Id: If0417f53386a94de0ec3b64c283df123c673ec03 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs Reviewed-on: https://chromium-review.googlesource.com/1197325 Commit-Queue: Clark DuVall <cduvall@chromium.org> Reviewed-by:
Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#587694}
-
Clark DuVall authored
This reverts commit ac880b3a. Reason for revert: Causing crash after audit in incognito window: http://crbug.com/879060 Original change's description: > Convert tcp_device_provider.cc to mojo host resolver > > Bug: 874653 > Change-Id: I95b968427344a4c9821c0985ae1f89c153036bcd > Reviewed-on: https://chromium-review.googlesource.com/1185626 > Commit-Queue: Clark DuVall <cduvall@chromium.org> > Reviewed-by: Andrey Kosyakov <caseq@chromium.org> > Cr-Commit-Position: refs/heads/master@{#586738} TBR=caseq@chromium.org,ericorth@chromium.org,cduvall@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 874653, 879060 Change-Id: I72e7268a8b208a2f91e53f84601d5e89a3c66a41 No-Try: true Reviewed-on: https://chromium-review.googlesource.com/1197109 Commit-Queue: Clark DuVall <cduvall@chromium.org> Reviewed-by:
-
Joe Mason authored
Get changes from the internal repo since last branch point: - Replace hardcoded company name with COMPANY_SHORTNAME_STRING - Add more paths to PreFetchedPaths - Replace some VLOG statements with LOG(INFO) - Enforce that RegKeyPath takes only predefined keys in rootkey - Add chrome-cleanup-tool-test to keys in registry unit tests - Add Chrome policy key constants to registry_util.h - Replace StringPrintf with StrCat R=csharp Bug: 830892 Change-Id: I71c0c3f03ce852c4af4738056187512cfea9f82e Reviewed-on: https://chromium-review.googlesource.com/1195802Reviewed-by:
Chris Sharp <csharp@chromium.org> Commit-Queue: Joe Mason <joenotcharles@chromium.org> Cr-Commit-Position: refs/heads/master@{#587692}
-
Pedro Amaral authored
Bug: 874615 Change-Id: Ieeb98e2fedf2958259f7e06e65eadc31ad6b8aaf Reviewed-on: https://chromium-review.googlesource.com/1197323Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Pedro Amaral <amaralp@chromium.org> Cr-Commit-Position: refs/heads/master@{#587691}
-
Ivan Sandrk authored
Field text was changed in a previous CL which increased the width of the text, but the field width wasn't adjusted for this thereby creating a visual artifact. Screenshot before adjusting: https://screenshot.googleplex.com/cEJmBzFpvJO.png Screenshot after adjusting: https://screenshot.googleplex.com/Pbe9mXmp1RK.png Bug: 865947 Change-Id: Ia12ad95bc0c96e540e0aa7ee1fa9949803efe97c Reviewed-on: https://chromium-review.googlesource.com/1196583Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Ivan Šandrk <isandrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#587690}
-
David Davidović authored
Add scrypt as a key derivation method to the proto and also to the client-side KeyDerivationMethod enum. Add feature which, when disabled, effectively treats scrypt as an unknown key derivation method altogether. Wire up scrypt key derivation in Nigori, so that it is exposed externally. Add tests to ensure that Nigori correctly derives scrypt keys, that SyncEncryptionHandlerImpl passes the new key derivation method correctly to observers and that, when the feature is disabled, scrypt code paths are not triggered. This is beneficial in mitigating risk related to the introduction of scrypt, as it can be completely disabled via Finch if need be. Bug: 877933 Change-Id: Icf940a02ef03b172c84d828d96b264c574151f7c Reviewed-on: https://chromium-review.googlesource.com/1194006Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
vitaliii <vitaliii@chromium.org> Commit-Queue: David Davidović <davidovic@google.com> Cr-Commit-Position: refs/heads/master@{#587689}
-
Lei Zhang authored
Also remove chrome/browser/usb/DEPS which is completely redundant. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I4080d3f68745030420b196fefc28d3010e9d1c3a Reviewed-on: https://chromium-review.googlesource.com/1195738 Commit-Queue: Michael Spang <spang@chromium.org> Reviewed-by:
Michael Spang <spang@chromium.org> Reviewed-by:
Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#587688}
-
Sahel Sharify authored
This cl converts all tests in fast/scrolling that are using event sender other than the following two keyboard tests: keyboard-scroll-before-layout.html keyboard-scroll-page-scale.html Bug: 846424 Change-Id: Id6c10046d591724c347bf931ae877e1cb8b7d3c2 Reviewed-on: https://chromium-review.googlesource.com/1196826 Commit-Queue: Sahel Sharify <sahel@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#587687}
-
Kevin Marshall authored
This plumbing provides activation and focusing of the WindowTreeHost's child windows, enabling full use of the mouse and keyboard in content views. Also fixed some IWYU linter errors. Bug: 878439 Change-Id: I0fc344b69edf78ca3aff39f615951cfa016718b2 Reviewed-on: https://chromium-review.googlesource.com/1194868 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#587686}
-
Denis Kuznetsov authored
Bug: 876689 Change-Id: I999a7cdfaf703e898365b5838d06fc2d8615abe7 Reviewed-on: https://chromium-review.googlesource.com/1194075 Commit-Queue: Denis Kuznetsov <antrim@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#587685}
-
Etienne Pierre-doray authored
This CL uses ScopedBlockingCall to mark blocking calls in /chrome/browser/web_applications. This CL was created by replacing calls to AssertBlockingAllowed() with instantiations of ScopedBlockingCall(MAY_BLOCK). I kindly ask the reviewer to make sure of the following: - ScopedBlockingCall is instantiated in a scope with minimal CPU usage. If this is not the case, ScopedBlockingCall should be instantiated closer to the blocking call. See scoped_blocking_call.h for more info. Please let me know when/where the blocking call happens if this needs to be changed. - Parameter |blocking_type| matches expectation (MAY_BLOCK/WILL_BLOCK). See BlockingType for more info. While I assumed MAY_BLOCK by default, that might not be the best fit if we know that this callsite is guaranteed to block. - The ScopedBlockingCall's scope covers the entirety of the blocking operation previously asserted against by the AssertBlockingAllowed(). This CL was uploaded by git cl split. R=dominickn@chromium.org Bug: 874080 Change-Id: I82b1024084057eebf5425a8e42c5ee6b677f6b46 Reviewed-on: https://chromium-review.googlesource.com/1191788 Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#587684}
-
Etienne Pierre-doray authored
Original CL intention was: This CL uses ScopedBlockingCall to mark blocking calls in /extensions/browser/api/system_storage. This CL was created by replacing calls to AssertBlockingAllowed() with instantiations of ScopedBlockingCall(MAY_BLOCK). I kindly ask the reviewer to make sure of the following: - ScopedBlockingCall is instantiated in a scope with minimal CPU usage. If this is not the case, ScopedBlockingCall should be instantiated closer to the blocking call. See scoped_blocking_call.h for more info. Please let me know when/where the blocking call happens if this needs to be changed. - Parameter |blocking_type| matches expectation (MAY_BLOCK/WILL_BLOCK). See BlockingType for more info. While I assumed MAY_BLOCK by default, that might not be the best fit if we know that this callsite is guaranteed to block. - The ScopedBlockingCall's scope covers the entirety of the blocking operation previously asserted against by the AssertBlockingAllowed(). This CL was uploaded by git cl split. R=ningxin.hu@intel.com Bug: 874080 Change-Id: Ia8cf19506aa212d07e8dad54a07940f6e878799c Reviewed-on: https://chromium-review.googlesource.com/1191195 Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#587683}
-
Etienne Pierre-doray authored
This CL uses ScopedBlockingCall to mark blocking calls in /ios/chrome/browser/snapshots. This CL was created by replacing calls to AssertBlockingAllowed() with instantiations of ScopedBlockingCall(MAY_BLOCK). I kindly ask the reviewer to make sure of the following: - ScopedBlockingCall is instantiated in a scope with minimal CPU usage. If this is not the case, ScopedBlockingCall should be instantiated closer to the blocking call. See scoped_blocking_call.h for more info. Please let me know when/where the blocking call happens if this needs to be changed. - Parameter |blocking_type| matches expectation (MAY_BLOCK/WILL_BLOCK). See BlockingType for more info. While I assumed MAY_BLOCK by default, that might not be the best fit if we know that this callsite is guaranteed to block. - The ScopedBlockingCall's scope covers the entirety of the blocking operation previously asserted against by the AssertBlockingAllowed(). This CL was uploaded by git cl split. R=justincohen@chromium.org Bug: 874080 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I5df9b85d1914370ea2ada752c18bc5861f1591fc Reviewed-on: https://chromium-review.googlesource.com/1191408Reviewed-by:Justin Cohen <justincohen@chromium.org> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#587682}
-
John Z Wu authored
This is needed to ensure that callbacks installed on translate.js can be registered before element.js executes. Change-Id: Idefe034e77879169b57185bcad88066d1917de82 Bug: 877706 Reviewed-on: https://chromium-review.googlesource.com/1189060 Commit-Queue: John Wu <jzw@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#587681}
-
chaopeng authored
This CL add the scroll snap data to ScrollNode for BGPT. I manually tested scroll snap. TEST=fast/scroll-snap/snap-scrolls-visual-viewport.html still flaky. Bug: 877106 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-gen-property-trees;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I4199e4a7474c08e1b27b5d54528b1b371164fd62 Reviewed-on: https://chromium-review.googlesource.com/1195106Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
-
Stephen Martinis authored
This is a reland of 025bf217 Original change's description: > Remove Windows debug bots from consoles > > They've been a bit flaky, and I don't want to bother sheriffs with them > yet. > > Bug: 878915 > Change-Id: Ia37db9742e3bf7e58a2efba8ab4032f7b121620e > Reviewed-on: https://chromium-review.googlesource.com/1195926 > Reviewed-by: John Budorick <jbudorick@chromium.org> > Commit-Queue: Stephen Martinis <martiniss@chromium.org> > Cr-Commit-Position: refs/heads/master@{#587409} Bug: 878915 Change-Id: I65ea5aa215a235cdfc2b93c4804f69a93a953e95 Reviewed-on: https://chromium-review.googlesource.com/1196919Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#587679}
-
Sebastien Marchand authored
Report the number of tabs/windows at regular interval, this'll be useful to help measure if a given change affects how users use tabs. Change-Id: Ic08861825c064afa736ecaeac98cc9855890f109 Reviewed-on: https://chromium-review.googlesource.com/1194871 Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Reviewed-by:
Robert Kaplow (slow) <rkaplow@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#587678}
-
Lei Zhang authored
Fix lint errors as well. BUG=537099 Change-Id: Ie36f7530d574229495f24119e74f15e0a1fb2d71 Reviewed-on: https://chromium-review.googlesource.com/1188640 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Katie Dektar <katie@chromium.org> Reviewed-by:
-
Becca Hughes authored
Move the media session and audio focus related switches to the media session service. BUG=875004 Change-Id: I54dad1eb47ac6288895ea3cac3824b181080f3e3 Reviewed-on: https://chromium-review.googlesource.com/1188747Reviewed-by:
Stephen Lanham <slan@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#587676}
-
rbpotter authored
These tests are timing out periodically. Match the removal of browser_tests, since the behavior is expected to be the same. Bug: 876224 Change-Id: I76183e78fde8f10a1feae67db51ca4336a4c652e Reviewed-on: https://chromium-review.googlesource.com/1197322Reviewed-by:
-
Xiaohan Wang authored
This CL updates blink and chromium to support persistent-usage-record session, which is behind a flag. To enable the support, use the following command line flag: --enable-blink-features=EncryptedMediaPersistentUsageRecordSession ExternalClearKey key system is also updated to declare support for this session type, even though in the implementation it doesn't do anything special. No other CDMs support this session type yet, which will be done later. TBR=foolip@chromium.org Bug: 856925 Cq-Include-Trybots: luci.chromium.try:linux_chromium_dbg_ng Change-Id: Iff38bc79f43e375144f045564e045a830d86699a Reviewed-on: https://chromium-review.googlesource.com/1119565 Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
John Rummell <jrummell@chromium.org> Cr-Commit-Position: refs/heads/master@{#587674}
-
Victor Costan authored
This way, callers that have a base::StringPiece[16] can avoid copying the data into an {std::string, base::String16} just to call GURL::Resolve(). Change-Id: I0c7d73ac55d102bc0bc39afe36efccc33e938e14 Reviewed-on: https://chromium-review.googlesource.com/1195740Reviewed-by:Chris Palmer <palmer@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#587673}
-
Joe Downing authored
We are adjusting these based on user feedback. Many users found that 10 minutes was not enough time to complete common tasks which requried assistance. Based on usage data, 30 minutes should be enough for the majority of sessions. Also increasing the timeout for the continue window to give the person being helped more time to find and click the continue button. Change-Id: I9a55568363e2bf79d6a82523c1a520364fbd3507 Reviewed-on: https://chromium-review.googlesource.com/1183539 Commit-Queue: Joe Downing <joedow@chromium.org> Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Cr-Commit-Position: refs/heads/master@{#587672}
-
Lei Zhang authored
r372827 allowed chrome/browser/ to include components/, at the top level, so there are now many rules inside chrome/browser/ that are redundant. Change-Id: I73a7c2c191f4511e64dc14ed4f4ecaa0f2790fcc Reviewed-on: https://chromium-review.googlesource.com/1195737Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#587671}
-
Etienne Pierre-doray authored
This CL uses ScopedBlockingCall to mark blocking calls in /chromeos/printing. This CL was created by replacing calls to AssertBlockingAllowed() with instantiations of ScopedBlockingCall(MAY_BLOCK). I kindly ask the reviewer to make sure of the following: - ScopedBlockingCall is instantiated in a scope with minimal CPU usage. If this is not the case, ScopedBlockingCall should be instantiated closer to the blocking call. See scoped_blocking_call.h for more info. Please let me know when/where the blocking call happens if this needs to be changed. - Parameter |blocking_type| matches expectation (MAY_BLOCK/WILL_BLOCK). See BlockingType for more info. While I assumed MAY_BLOCK by default, that might not be the best fit if we know that this callsite is guaranteed to block. - The ScopedBlockingCall's scope covers the entirety of the blocking operation previously asserted against by the AssertBlockingAllowed(). This CL was uploaded by git cl split. R=thestig@chromium.org Bug: 874080 Change-Id: Ic3048f1874bd6d575a061c5f9f773df4850d6d32 Reviewed-on: https://chromium-review.googlesource.com/1191099Reviewed-by:Sean Kau <skau@chromium.org> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#587670}
-
Steve Anton authored
Bug: 868068 Change-Id: I339a79b5709425b2e7d0d4d50f0bfa0602afc7ab Reviewed-on: https://chromium-review.googlesource.com/1170171Reviewed-by:
Henrik Boström <hbos@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Commit-Queue: Steve Anton <steveanton@chromium.org> Cr-Commit-Position: refs/heads/master@{#587669}
-
Anne Lim authored
Migrate dupplicate experiments which exists in both autofill_experiments.* and autofill_features.* to become features. Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I322b2aaf66433c0f5b3e8d84e975c403ce6bc273 Reviewed-on: https://chromium-review.googlesource.com/1197105Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Reviewed-by:
Maxim Kolosovskiy <kolos@chromium.org> Commit-Queue: Anne Lim <annelim@google.com> Cr-Commit-Position: refs/heads/master@{#587668}
-
Luna Lu authored
This CL is based on: https://chromium-review.googlesource.com/c/chromium/src/+/1150725 Design doc: https://docs.google.com/document/d/1yh_-ayeaFV0EjuR51U641zbrPAB0Baqj6UrC9bT9iqQ/edit#heading=h.y7amr11fn0tb This CL implements "intrinsicSize" attribute for HTMLVideoElement. The value of "intrinsicSize" overrides the intrinsic size: 1. When no width and (or) height is specified, the value of "intrinsicSize" will be used to determine the area to layout the video content. 2. videoWidth and videoHeight will return the value defined by "intrinsicSize". See explainer: https://github.com/ojanvafai/intrinsicsize-attribute/blob/master/README.md Bug: 874629 Change-Id: If4aeceee2299c50aa7b4c9bdf8fef7cb3e7eea70 Reviewed-on: https://chromium-review.googlesource.com/1191926 Commit-Queue: Luna Lu <loonybear@chromium.org> Reviewed-by:
Steve Kobes <skobes@chromium.org> Cr-Commit-Position: refs/heads/master@{#587667}
-
Greg Thompson authored
No change for Google Chrome builds, but Chromium builds will switch from "Browse the web" to the (until now) unused string "Access the Internet" in chromium_strings.grd. This is another step toward getting rid of BrowserDistribution. BUG=none R=chengx@chromium.org TBR=bauerb@chromium.org Change-Id: I0ec49957d6b6b930593549bcfd17fec1fa013ccf Reviewed-on: https://chromium-review.googlesource.com/1196036 Commit-Queue: Greg Thompson <grt@chromium.org> Reviewed-by:
Xi Cheng <chengx@chromium.org> Cr-Commit-Position: refs/heads/master@{#587666}
-
Jared Saul authored
If credit card upload is not offered, Chrome can fall back to offering local save instead. It shouldn't do this for existing local cards. Bug: 878177 Change-Id: I84ba77525864000a34aaa14b51305e854cd23c99 Reviewed-on: https://chromium-review.googlesource.com/1192405 Commit-Queue: Jared Saul <jsaul@google.com> Reviewed-by:
-
Charlene Yan authored
Bug: 876690, 876682, 879154 Change-Id: Ia72f26e9d7e0402868dd628fa2e10492b46a2cee Reviewed-on: https://chromium-review.googlesource.com/1194728 Commit-Queue: Charlene Yan <cyan@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#587664}
-
Tommy Steimel authored
This reverts commit 66a05dbb. Reason for revert: The null checks are not solving the crash. Must be a deeper issue where the style object is garbage Original change's description: > [Media Controls] Switch to using GetLayoutObject Style > > This CL modifies the zoom calculation in the overlay play button to use > GetLayoutObject's Style instead of ComputedStyleRef. This will > (hopefully) prevent a crash we're seeing when accessing > ComputedStyleRef. > > Bug: 870490 > Change-Id: Id830798f1c781ef1eddffe153875be21f128237e > Reviewed-on: https://chromium-review.googlesource.com/1192139 > Reviewed-by: Becca Hughes <beccahughes@chromium.org> > Commit-Queue: Tommy Steimel <steimel@chromium.org> > Cr-Commit-Position: refs/heads/master@{#586482} TBR=beccahughes@chromium.org,steimel@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 870490 Change-Id: I7027f2da320588650e9f683914e53d8a349821bd Reviewed-on: https://chromium-review.googlesource.com/1197163Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#587663}
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/175653356591..e2807b42c18d git log 175653356591..e2807b42c18d --date=short --no-merges --format='%ad %ae %s' 2018-08-30 derat@chromium.org chromeos_config: Increase TastVMTest timeout to 30 minutes. 2018-08-30 dgarrett@google.com push_image: Make --buildroot adjustable. 2018-08-30 achuith@chromium.org chrome_chromeos_lkgm: Use commandline.ArgumentParser instead. Created with: gclient setdep -r src/third_party/chromite@e2807b42c18d The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I29919e3876a91fa9bd9c099172413f317910e1c1 Reviewed-on: https://chromium-review.googlesource.com/1196687Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#587662}
-
Byoungkown authored
Using "use_jumbo_build=true" args in GN, speed up builds in components/cdm. Bug: None Change-Id: I179d6d4bfa22ddbe1025aa396b31f2e3598ba7e3 Reviewed-on: https://chromium-review.googlesource.com/1193722 Commit-Queue: Byoungkwon Ko <codeimpl@gmail.com> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#587661}
-
Hongchan Choi authored
Context: https://github.com/web-platform-tests/wpt/pull/12606 Change the logic of should.throw() so we can handle 3 cases - should(someExpression).throw(); should(someExpression).throw(TypeError); should(someExpression).throw(DOMException, 'NotSupportedError'); The generic error (except for DOMException) can be passed without the second argument, but this change will enforce the second arg when the expected error is a DOMException type. This touches many test files, so the work will be done in several steps: 1. Change audit.js, audionodeoptions.js on both locations. (wpt, non-wpt) 2. Update affected test files with the script. 3. Update the rest of test files which can't be updated programmatically. Bug: 865614 Test: All layout tests pass. Change-Id: I16acacb26c194a0ff950aca05e931195bf55167f Reviewed-on: https://chromium-review.googlesource.com/1184146 Commit-Queue: Hongchan Choi <hongchan@chromium.org> Reviewed-by:
Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#587660}
-
