GitLab

There's no reason for them to be virtual. Also removed a
field I missed in a previous CL.

BUG=477847

Review URL: https://codereview.chromium.org/1111553002

Cr-Commit-Position: refs/heads/master@{#327174}

The Google style guide states that only one of {virtual,override,final} should be used for each declaration, since override implies virtual and final implies both virtual and override.

This patch was manually generated using a regex and a text editor.

BUG=417463

Review URL: https://codereview.chromium.org/1101023002

Cr-Commit-Position: refs/heads/master@{#327173}

Enhanced MirrorWindowController to manage multiple mirroring windows.

BUG=365662

Review URL: https://codereview.chromium.org/1107733006

Cr-Commit-Position: refs/heads/master@{#327172}

Use ExtensionSystem::Ready instead of NOTIFICATION_EXTENSIONS_READY.

R=kalman@chromium.org
BUG=354459

Review URL: https://codereview.chromium.org/1102193002

Cr-Commit-Position: refs/heads/master@{#327171}

Chrome no longer supports API 14 and 15

BUG=473837

Review URL: https://codereview.chromium.org/1109963003

Cr-Commit-Position: refs/heads/master@{#327170}

This cl disables BeginFrame scheduling for OOPIF.
We will enable this for OOPIF when we have a architecture for delivering
BeginFrame message for OOPIF.

R=kenrb@chromium.org, brianderson@chromium.org, creis@chromium.org
BUG=471411

Review URL: https://codereview.chromium.org/1107763002

Cr-Commit-Position: refs/heads/master@{#327169}

BUG=362214

Review URL: https://codereview.chromium.org/1098983003

Cr-Commit-Position: refs/heads/master@{#327168}

Exclude PluginPowerSaverBrowserTest.PluginMarkedEssentialAfterPosterClicked from DrMemory for timing out.

BUG=481687
TBR=tommycli@chromium.org

Review URL: https://codereview.chromium.org/1109973003

Cr-Commit-Position: refs/heads/master@{#327167}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/1e14c28..9b3210f

TBR=tkent@chromium.org,pdr@chromium.org

Review URL: https://codereview.chromium.org/1111533002

Cr-Commit-Position: refs/heads/master@{#327166}

Without these, a GN clobber build fails, and we get warnings
during the non-compile builds.

R=garykac@chromium.org
BUG=

Review URL: https://codereview.chromium.org/1108953002

Cr-Commit-Position: refs/heads/master@{#327165}

This CL contains several fixes needed to make the ChromeOS GN debug component build link.

R=brettw@chromium.org, erg@chromium.org, garykac@chromium.org, kjellander@chromium.org
BUG=433082
CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_chromium_gn_chromeos_dbg;tryserver.chromium.mac:mac_chromium_gn_rel;tryserver.chromium.win:win8_chromium_gn_rel,win8_chromium_gn_dbg

Review URL: https://codereview.chromium.org/1054963007

Cr-Commit-Position: refs/heads/master@{#327164}

This CL also add OWNERS file for ApiCompatibilityUtils

BUG=473837

Review URL: https://codereview.chromium.org/1082303004

Cr-Commit-Position: refs/heads/master@{#327163}

This patch adds a version of rasterize and record on key silk cases with
--enable-slimming-paint.

BUG=464910

Review URL: https://codereview.chromium.org/1106823003

Cr-Commit-Position: refs/heads/master@{#327162}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/a6f7507..d7c014f

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=humper@google.com

Review URL: https://codereview.chromium.org/1107953003

Cr-Commit-Position: refs/heads/master@{#327161}

Since the width of this dialog is no longer fixed, this CL also updates base.resizeWindowToContent to set the width as well as the height, and adds support for centering.

BUG=b/19796166

Review URL: https://codereview.chromium.org/1081813007

Cr-Commit-Position: refs/heads/master@{#327160}

I fixed local crashes in https://codereview.chromium.org/1107133002
The bot fails on gl_surface init, which I can't repro:
  http://build.chromium.org/p/chromium.mojo/builders/Chromium%20Mojo%20Linux/builds/4898/steps/app_tests/logs/stdio

[0427/144427:ERROR:gl_surface_x11.cc(98)] XOpenDisplay failed.
[0427/144427:ERROR:gl_surface_x11.cc(62)] NativeViewGLSurfaceOSMesa::InitializeOneOff failed.
[0427/144427:FATAL:gl_surface.cc(136)] Check failed: InitializeOneOffImplementation( impl, fallback_to_osmesa, gpu_service_logging, disable_gl_drawing).

BUG=480040
TEST=Bot goes green again.
TBR=sky@chromium.org

Review URL: https://codereview.chromium.org/1106363002

Cr-Commit-Position: refs/heads/master@{#327159}

BUG=477846
NOTRY=true

Review URL: https://codereview.chromium.org/1106353002

Cr-Commit-Position: refs/heads/master@{#327158}

BUG=480785

Cr-Commit-Position: refs/heads/master@{#327157}

BUG=46422
TBR=jhawkins for .grdp

Review URL: https://codereview.chromium.org/1056023003

Cr-Commit-Position: refs/heads/master@{#327156}

Revert of Add CPP API for BLE advertisments. (patchset #12 id:220001 of https://codereview.chromium.org/1054743003/)

Reason for revert:
Breaks component=shared_library build (missing export?)

../../device/bluetooth/bluetooth_adapter_chromeos.cc:321: error: undefined reference to 'chromeos::BluetoothAdvertisementChromeOS::BluetoothAdvertisementChromeOS(scoped_ptr<device::BluetoothAdvertisement::Data, base::DefaultDeleter<device::BluetoothAdvertisement::Data> >, scoped_refptr<chromeos::BluetoothAdapterChromeOS>)'
../../base/memory/scoped_ptr.h:128: error: undefined reference to 'device::BluetoothAdvertisement::Data::~Data()'
../../device/bluetooth/bluetooth_adapter_chromeos.cc:322: error: undefined reference to 'chromeos::BluetoothAdvertisementChromeOS::Register(base::Callback<void ()> const&, base::Callback<void (device::BluetoothAdvertisement::ErrorCode)> const&)'
obj/device/bluetooth/device_bluetooth.bluetooth_adapter_chromeos.o(.debug_addr+0x6f20): error: undefined reference to 'chromeos::BluetoothAdvertisementChromeOS::Register(base::Callback<void ()> const&, base::Callback<void (device::BluetoothAdvertisement::ErrorCode)> const&)'

Original issue's description:
> Add CPP API for BLE advertisments.
>
> This CL adds the new classes, changes to existing classes and tests for adding
> the CPP API for LE advertisements. The design for this is available at
> http://go/chrome-ble-advertising.
>
> R=armansito@chromium.org, jamuraa@chromium.org
> BUG=466375
>
> Committed: https://crrev.com/c96da18077ef4b5ab28cb8b2684cd84386075e5a
> Cr-Commit-Position: refs/heads/master@{#327128}

TBR=armansito@chromium.org,jamuraa@chromium.org,scheib@chromium.org,rkc@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=466375

Review URL: https://codereview.chromium.org/1111563002

Cr-Commit-Position: refs/heads/master@{#327155}

The Google style guide states that only one of {virtual,override,final} should be used for each declaration, since override implies virtual and final implies both virtual and override.

This patch was manually generated using a regex and a text editor.

BUG=417463

Review URL: https://codereview.chromium.org/1100633004

Cr-Commit-Position: refs/heads/master@{#327154}

Also remove third_party\mojo_services\src\http_server which is unused.

BUG=479353

Review URL: https://codereview.chromium.org/1109943002

Cr-Commit-Position: refs/heads/master@{#327153}

Revert of Classify navigations without page id in parallel to the existing classifier. (patchset #34 id:660001 of https://codereview.chromium.org/1002803002/)

Reason for revert:
Caused compile error in "Google Chrome Mac" bot:

https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Mac/builds/726

Original issue's description:
> Classify navigations without page id in parallel to the existing classifier.
>
> For now, this only happens in debug builds.
>
> BUG=369661
> TEST=NavigationControllerBrowserTest.NavigationTypeClassification_*
> TEST=Every other test on the planet.
>
> Committed: https://crrev.com/d8d93348bbd8c646c337bdaa40fc0c64204fc5ff
> Cr-Commit-Position: refs/heads/master@{#327122}

TBR=phajdan.jr@chromium.org,clamy@chromium.org,creis@chromium.org,hajimehoshi@chromium.org,isherman@chromium.org,jeremyim@chromium.org,mattm@chromium.org,mnaganov@chromium.org,mvanouwerkerk@chromium.org,nasko@chromium.org,stevenjb@chromium.org,bengr@chromium.org,avi@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=369661

Review URL: https://codereview.chromium.org/1104403002

Cr-Commit-Position: refs/heads/master@{#327152}

Summary of changes available at:
https://chromium.googlesource.com/external/trace-viewer/+log/ba605a2..eea44df

eea44df  Add "evdev" to input latency category filter
c2dae9e  Fix core.analysis.table_builder_test.instantiateEmptyTable_withEmptyValue breaking Travis CI

TBR=dsinclair

Review URL: https://codereview.chromium.org/1103323003

Cr-Commit-Position: refs/heads/master@{#327151}

This CL adds a post upload hook to add extra try bots list to the CL description in order to run
Telemetry benchmarks on Perf trybots in addtion to CQ trybots if the CL
contains any changes to Telemetry benchmarks.

BUG=462581

Review URL: https://codereview.chromium.org/1060763002

Cr-Commit-Position: refs/heads/master@{#327150}

There are similar test files that are used by non-android specific
testing that can be used instead.

BUG=457403

Review URL: https://codereview.chromium.org/1092383003

Cr-Commit-Position: refs/heads/master@{#327149}

R=sky@chromium.org
BUG=

Review URL: https://codereview.chromium.org/1091513005

Cr-Commit-Position: refs/heads/master@{#327148}

WebKit has been fixed in
https://src.chromium.org/viewvc/blink?revision=193998&view=revision

BUG=None
TEST=trybots
R=thestig@chromium.org
TBR=sergeyu@chromium.org,cpu@chromium.org

Review URL: https://codereview.chromium.org/1053123010

Cr-Commit-Position: refs/heads/master@{#327147}

BUG=473837

Review URL: https://codereview.chromium.org/1106183005

Cr-Commit-Position: refs/heads/master@{#327146}

R=brettw@chromium.org
BUG=

Review URL: https://codereview.chromium.org/1110793002

Cr-Commit-Position: refs/heads/master@{#327145}

BUG=471928

Review URL: https://codereview.chromium.org/1099553003

Cr-Commit-Position: refs/heads/master@{#327144}

Delivering the FIRST_NONEMPTY_PAINT phase changing event to base/. This concludes the client-side “phased profiling” work.

I’m removing TODO items, and the DIFFS introduced by this should remind the reviewers that there are open questions that they wanted to re-raise, assuming the the CL doesn’t make it clear that the way it’s implemented is OK.

If there are still concerns, we should agree on one important thing before we resume the discussions: phase change delivery chain doesn’t go through metrics provider. It starts at the event source (FirstWebContentsProfiler), then goes to TrackingSynchronizer, then goes to base/. Once we agree on the design of this chain, it will make sense to go to more detailed discussions and open questions.
BUG=456354

Review URL: https://codereview.chromium.org/1021053003

Cr-Commit-Position: refs/heads/master@{#327143}

Revert of [media] Replace MessageLoopProxy usage with ThreadTaskRunnerHandle (patchset #3 id:40001 of https://codereview.chromium.org/1108773002/)

Reason for revert:
see https://code.google.com/p/chromium/issues/detail?id=481632

Original issue's description:
> Replace MessageLoopProxy usage with ThreadTaskRunnerHandle in src/media.
>
> MessageLoopProxy is deprecated.
> This basically does a search and replace:
>
> MessageLoopProxy::current() -> ThreadTaskRunnerHandle::Get().
>
> BUG=391045
>
> Committed: https://crrev.com/902e992a9b6447028bf8d4f3540892c425984b8f
> Cr-Commit-Position: refs/heads/master@{#327075}

TBR=anujk.sharma@samsung.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=391045

Review URL: https://codereview.chromium.org/1105163004

Cr-Commit-Position: refs/heads/master@{#327142}

ScopedFileDescriptor was initially introduced to facilitate the
management of a 'lifeline' FD used when asking permission_broker to
open a port in the device's firewall on CrOS.  It's actually a scoped
wrapper around DBus::FileDescriptor, not a platform file descriptor. I
would like to use it to facilitate some other similar functionality in
which I create a pipe and pass one end over DBus, so it seems like a
good idea to move ScopedFileDescriptor into the dbus library directly.

This reverts commit ee9dc849.

BUG=chromium:481340
TEST=FirewallHole unit tests still pass
TBR=stevenjb, reillyg, keybuk

Review URL: https://codereview.chromium.org/1108083003

Cr-Commit-Position: refs/heads/master@{#327141}

ANGLE can now create child windows and requires UI messages to be handled.
Because it is not possible to determine if ANGLE will use a child window
when creating surfaces, always use a UI message loop.

BUG=angleproject:961

Review URL: https://codereview.chromium.org/1097283005

Cr-Commit-Position: refs/heads/master@{#327140}

Update the native_viewport CommandLine usage pattern.
(codereview.chromium.org/1057603003 removed per-app args)

Re-enable window_manager_apptests with test and headless flags.
(our FYI waterfall: http://build.chromium.org/p/chromium.mojo/console)

BUG=480040
TEST=Tests pass on the waterfall.
R=sky@chromium.org
TBR=jochen@chromium.org

Review URL: https://codereview.chromium.org/1107133002

Cr-Commit-Position: refs/heads/master@{#327139}

The UI objects (specifically DataReductionProxySettings) already creates
a BooleanPrefMember for kDataReductionProxyEnabled and checks for changes
on it, then propagates this information to DataReductionProxyIOData via
DataReductionProxyIOData::SetProxyPrefs.

It also negates the need to pass a BooleanPrefMember to BypassStats when
ultimately all we care about is the boolean value.

BUG=472290

Review URL: https://codereview.chromium.org/1057473003

Cr-Commit-Position: refs/heads/master@{#327138}

CredentialManagerClientTest has crashed on Android since commit
d94a4430 was merged.

BUG=481415

Review URL: https://codereview.chromium.org/1103083002

Cr-Commit-Position: refs/heads/master@{#327137}

BUG=473837

Review URL: https://codereview.chromium.org/1106293003

Cr-Commit-Position: refs/heads/master@{#327136}

Previously this was a component which fails on the Windows component build because there are no exported symbols. In GYP this is a static library, which should generally be source_sets in GN.

TBR=keybuk@chromium.org

Review URL: https://codereview.chromium.org/1107103002

Cr-Commit-Position: refs/heads/master@{#327135}