- 08 Nov, 2019 40 commits
-
-
Yoshifumi Inoue authored
This patch makes |LayoutInline::HitTestCulledInline()| faster by using container (<span>, line box, etc. instead of LayoutBlockFlow) rooted cursor instead of containing block cursor to limit number of fragments to scan. This is follow-up the CL[1] which changed |LayoutInline::HitTestCulledInline()| to use containing block rooted cursor. Here is elapsed time of hit tests with 2922 culled inline <span>'s in sample file attach in http://crbug.com/1008523 - Legacy: 7,772ms - Before this: 79,5556ms - After this: 2,068ms So, this patch makes hit test on culled inline <span> 38 times. [1] http://crrev.com/c/1862534: Make LayoutInline to utilize NGInlineCursor Bug: 1008523 Change-Id: I93633b965fd305f81438981a236369376b151775 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903768 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#713736}
-
Aga Wronska authored
This test was very flaky on linux-chromeos-dbg. Bug: 1022591 Change-Id: I9b306c9a426432f87688cffedb3460e254f4f77c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903818Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#713735}
-
Kouhei Ueno authored
Bug: 981740 Change-Id: I40605b9b6b343a3e0b4a12fe3b0e5e0b6f992390 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903182 Commit-Queue: Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Fergal Daly <fergal@chromium.org> Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#713734}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=benmason@chromium.org Change-Id: Idc75da0324ae551f014054afc8f03ca03c245cfb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903689Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#713733}
-
Luciano Pacheco authored
Follow up to CL:1869562 With native HTML Imports removed, the polyfill works by adding the imported content to the <head>, with this document.getElementById() can return elements added in the <head> which isn't intended to be returned. For example in the CL above, a "#delete" <command> was conflicting with a SVG icon <g id="delete">. When native HTML imports were used the imported content would be added to a shadow DOM avoiding this conflict. No change in behaviour, this is a preventive change, so it's covered by current suite of tests. Change-Id: Icfbaf9d690a63059de5d22f28c4f7b81919ff640 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904554Reviewed-by:
Alex Danilo <adanilo@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#713732}
-
Gyuyoung Kim authored
This CL converts remained old Mojo types of FuzzInterface interface to new Mojo types. Major changes are as below, - Convert mojom::InterfaceFactoryPtr to mojo::PendingRemote|Remote<mojom::FuzzInterface> - Convert mojo::InterfaceFactoryRequest to mojo::PendingReceiver<mojom::FuzzInterface> - Convert mojo::Binding to mojo::Receiver Bug: 955171 Change-Id: If4e276a27bb86098cd5af1e863578c8d30dc535d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893606Reviewed-by:Ken Rockot <rockot@google.com> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#713731}
-
Maggie Cai authored
This is a reland of c9ea6cb3 Original change's description: > [IntentHandling] Connect App Service with Pref Service. > > This CL connects the App Service with the Pref Service. This is to > allow the App Service store and retrieve preferred apps from the > preferences file. > > BUG=853604 > > Change-Id: I2802173d80126595966626af5d1ff1f42761c49f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892475 > Reviewed-by: Gabriel Charette <gab@chromium.org> > Reviewed-by: Nancy Wang <nancylingwang@chromium.org> > Reviewed-by: Dominick Ng <dominickn@chromium.org> > Commit-Queue: Maggie Cai <mxcai@chromium.org> > Cr-Commit-Position: refs/heads/master@{#713174} Bug: 853604 Change-Id: Iccf547d2f4a747d37c63df0441e3009a3e2209f1 TBR=gab@chromium.org Change-Id: Iccf547d2f4a747d37c63df0441e3009a3e2209f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1905027 Commit-Queue: Maggie Cai <mxcai@chromium.org> Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#713730}
-
Alex Danilo authored
When a panel item is set to an error type, the primary text can wrap to 2 lines and the secondary text should not be shown. Change the error panel initialization to set the primary text to a default generic error string, and the secondary text to blank. Adds unit test to confirm the expected behaviour. Bug: 1021307 Tests: browser_tests --gtest_filter=FileManagerJsTest.FilesDisplayPanel Change-Id: Id9251b9cfae3050dc6fd8005c214d920f6173a44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904562 Commit-Queue: Alex Danilo <adanilo@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#713729}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/8095ffd42db6..cc4b158ee494 git log 8095ffd42db6..cc4b158ee494 --date=short --no-merges --format='%ad %ae %s' 2019-11-08 vbendeb@chromium.org trigger_cr50_signer: change default signer type and key set Created with: gclient setdep -r src/third_party/chromite@cc4b158ee494 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: If1404173c6ac6f5518b3a5838329742aa0d95f98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1905048Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#713728}
-
Aleks Totic authored
NG Tables assume that in a single table either all elements are Legacy, or they are all NG. This patch makes TABLE force legacy if cell is forced legacy. Bug: 958381 Change-Id: I7fd7b943dc5a7df41a0d5b21d292e33654ec23ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898150 Commit-Queue: Aleks Totic <atotic@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#713727}
-
Hiroki Sato authored
http://crrev/c/1574898 deleted the implementation of AXActionData::ToString, but the declaration in the header still exists. This CL deletes the obsolete declaration. Bug: None Change-Id: Id7c96debb4d72939d951e55b8bdc6305c6aab473 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1905026 Commit-Queue: Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#713726}
-
Jiawei Li authored
This reverts commit 4956f503. Reason for revert: Decided to move forward with both Android and Linux Merge-With: eureka-internal/333206 Original change's description: > Revert "[chromecast] Add bindings_manager_cast target for Android build" > > This reverts commit d08541bb. > > Reason for revert: In favor of focusing on supporting Linux build for now. > > Original change's description: > > [chromecast] Add bindings_manager_cast target for Android build > > > > Previously, bindings_manager_cast target was guarded by is_linux. This > > should be available for all non-fuchsia builds. > > > > Bug: internal b/141398875 > > Test: CQ > > Change-Id: I21d95c65040956dd4446eff61dbd50acbb3f4e20 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815949 > > Reviewed-by: Kevin Marshall <kmarshall@chromium.org> > > Reviewed-by: Yuchen Liu <yucliu@chromium.org> > > Commit-Queue: Jiawei Li <lijiawei@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#699041} > > TBR=kmarshall@chromium.org,yucliu@chromium.org,lijiawei@chromium.org > > Change-Id: I6d42eb1f3bfa79904cc5c0b39576e47c409ff30f > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: internal b/141398875 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1818465 > Commit-Queue: Yuchen Liu <yucliu@chromium.org> > Reviewed-by: Yuchen Liu <yucliu@chromium.org> > Auto-Submit: Jiawei Li <lijiawei@chromium.org> > Cr-Commit-Position: refs/heads/master@{#699058} TBR=kmarshall@chromium.org,yucliu@chromium.org,lijiawei@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: internal b/141398875 Change-Id: I219e0e8dcad0f14329b721d9bbaf257b64ee5e52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903816 Commit-Queue: Jiawei Li <lijiawei@chromium.org> Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#713725}
-
Sergey Ulanov authored
FuchsiaVideoDecoder is supposed to wait for video frames to be rendered before returning the underylying buffer to the decoder to reuse it. The corresponding logic was already implemented, but it wasn't working properly because the decoder wasn't setting READ_LOCK_FENCES_ENABLED flag in the generated frames. As result VideoResourceUpdater wasn't setting read_lock_fences_enabled flag in corresponding TransferableResources and so Viz wasn't returning sync token for these resources. Now the decoder sets READ_LOCK_FENCES_ENABLED flag, so frame reuse is synchronized properly. Bug: b/143308693 Change-Id: I9746c69c4a6cbd1c6ea1c708731f1cf8fc620a94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904951 Auto-Submit: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Commit-Queue: David Dorwin <ddorwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#713724}
-
Melissa Zhang authored
On devices with tablet form factor, links clicked from Chrome should not automatically launch preferred ARC apps, but instead open the page with the intent picker such that the user can make a selection. BUG=1019549 Change-Id: Idc87b70d5216dba58063d652c10bf4d969aaeedf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900510Reviewed-by:
Maggie Cai <mxcai@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Melissa Zhang <melzhang@chromium.org> Cr-Commit-Position: refs/heads/master@{#713723}
-
Sadrul Habib Chowdhury authored
Add some DCHECK-only code to validate that a CompositorFrame is always submitted only between calls to WillBeginImplFrame() and DidFinishImplFrame() (i.e. when a valid BeginFrameArgs is being tracked by the LayerTreeHostImpl). Change-Id: I9f344135163d8fabf15c7b670a4a80eb25079e18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894912 Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#713722}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/52591f688023..76eaab6b8cef git log 52591f688023..76eaab6b8cef --date=short --no-merges --format='%ad %ae %s' 2019-11-08 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-11-08 csmartdalton@google.com Implement multisample "disable" in Vulkan Created with: gclient setdep -r src/third_party/skia@76eaab6b8cef If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC ethannicholas@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ethannicholas@google.com Bug: None Change-Id: I593777cbc50f9e415b5e9aa8444bbdea945bca3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904164Reviewed-by:
-
Julie Jeongeun Kim authored
This CL is a part of effort for converting mojom::URLLoaderClient to new Mojo types. It converts mojo::Binding<network::mojom::URLLoaderClient> to mojo::Receiver<network::mojom::URLLoaderClient>. On a follow-up CL, URLLoaderClientPtr will be handled with new Mojo types. Bug: 955171 Change-Id: Id297a6c86ea7b113d333d0ccb2a41611328c0aeb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895107Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
Luke Halliwell (slow) <halliwell@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
-
John Palmer authored
The new metric will capture more detail at the tail of the distribution than the existing metrics do. Internal CL adding the metric: http://cl/278538382 Change-Id: I4be1eb48fa97f847b0ee8f70f128bbb5e26bfc68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900511 Commit-Queue: John Palmer <jopalmer@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#713719}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/a14152fd51b9..1917f7a09940 git log a14152fd51b9..1917f7a09940 --date=short --no-merges --format='%ad %ae %s' 2019-11-08 martiniss@chromium.org Revert "Fetch the input commit ref when both ref and id are specified." Created with: gclient setdep -r src/third_party/depot_tools@1917f7a09940 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: chromium:922150,chromium:1022617 Change-Id: I0104ad01275923ee4ff662b1dc6fb2902861f9ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904339Reviewed-by:
-
Tsuyoshi Horo authored
This reverts commit c9ea6cb3. Reason for revert: Caused flaky compile failure. BUG=1022637 Original change's description: > [IntentHandling] Connect App Service with Pref Service. > > This CL connects the App Service with the Pref Service. This is to > allow the App Service store and retrieve preferred apps from the > preferences file. > > BUG=853604 > > Change-Id: I2802173d80126595966626af5d1ff1f42761c49f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892475 > Reviewed-by: Gabriel Charette <gab@chromium.org> > Reviewed-by: Nancy Wang <nancylingwang@chromium.org> > Reviewed-by: Dominick Ng <dominickn@chromium.org> > Commit-Queue: Maggie Cai <mxcai@chromium.org> > Cr-Commit-Position: refs/heads/master@{#713174} TBR=gab@chromium.org,dominickn@chromium.org,mxcai@chromium.org,nancylingwang@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 853604 Change-Id: Ie0adee8d67e28801eb1e92cc47f13d15276ed1ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904564Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#713717}
-
rbpotter authored
Run clang-format on chrome/browser/resources/extensions and chrome/test/data/webui/extensions These directories were left unformatted when converting to Polymer 3 in order to reduce the diff created when migrating and make it easier to see the changes required for migration. Bug: 1004967 Change-Id: Ic1eb0ee43eccd56c340d0cf3956e29136b96d10e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904488Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#713716}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/275467d3f177..c2eeedf46266 Created with: gclient setdep -r src-internal@c2eeedf46266 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:None Change-Id: Iada7593f3ed1758ee6387029c1a9bf84b47cb7b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904820Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#713715}
-
Sophie Chang authored
I left the SRP check there since that contains more hosts and doing the HasHint check for every host is probably not worth it. Bug: 1022624 Change-Id: I1b4c782df2c9fb76e08e09d3674178420a5a3728 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904822Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/master@{#713714}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/26c5a8d1e381..8095ffd42db6 git log 26c5a8d1e381..8095ffd42db6 --date=short --no-merges --format='%ad %ae %s' 2019-11-08 stevenjb@chromium.org Only copy resources/chromeos/ to the image, not all of resources/ 2019-11-08 stevenjb@chromium.org deploy_chrome: Copy compressed files in locales/ 2019-11-07 achuith@chromium.org xbuddy: Remove subprocess from xbuddy. Created with: gclient setdep -r src/third_party/chromite@8095ffd42db6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I919809a6f5c6a3232c39836a434f62fdbceea2d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904819Reviewed-by:
-
sczs authored
- Creates ConfirmInfobarTypeBlockPopups Suffix for InfobarConfirm metrics. - Records the new Histogram on blocked_popup_tab_helper Bug: 1020280 Change-Id: I78422370a2f9658bd98b02ed45445bb7adbe9b0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899557 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#713712}
-
Klaus Weidner authored
Ensure that the anchors_data in a frame is populated after processing anchors creation for that frame. This fixes an issue where a new anchor was reported as created in the promise, but only started appearing in the frame's list of anchors with a one-frame delay, resulting in losing custom data that the application may have stored on the anchor object. Also update the example to fix a couple of misused fields for non-reticle mode. This should fix the issue where the sunflowers weren't appearing at the touched point. Change-Id: I042f2e88f1fa4f0e09bacfcd4b93c89abe501bf6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903822 Commit-Queue: Klaus Weidner <klausw@chromium.org> Commit-Queue: Piotr Bialecki <bialpio@chromium.org> Auto-Submit: Klaus Weidner <klausw@chromium.org> Reviewed-by:
Piotr Bialecki <bialpio@chromium.org> Cr-Commit-Position: refs/heads/master@{#713711}
-
Austin Eng authored
This CL exposes WebGPU in Worker contexts behind a runtime enabled flag. It also removes the usage of blink::Platform::GraphicsInfo which was copied from WebGL context creation. It's completely unused right now and WebGPU should collect context creation errors differently. Platform::GraphicsInfo is not safe for cross-thread usage. Bug: chromium:852089 Change-Id: I9447b73f2bf45b32895f6d38818a8e7339de5efa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809755Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Commit-Queue: Austin Eng <enga@chromium.org> Cr-Commit-Position: refs/heads/master@{#713710}
-
Yoichi Osato authored
That's because we've decided not to unify op code and data on a datapipe. Change-Id: I1d9d83d10108552c6ba04b240ee71c2298d7663e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903226Reviewed-by:
Adam Rice <ricea@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#713709}
-
Julie Jeongeun Kim authored
This CL cleans up old mojo types for mojom::ChromeRenderFrame using PendingAssociatedReceiver and AssociatedReceiver. Bug: 955171 Change-Id: I895ad427e08292c8f671fef3965eddbabd9f0003 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902184Reviewed-by:
-
Rakib M. Hasan authored
These tags will be used to find active expectations for a test run on a certain system. Bug: chromium:986447 Change-Id: Iaa2cea234b80ff010581cd3991dbb015cb8995e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904270Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Rakib Hasan <rmhasan@google.com> Cr-Commit-Position: refs/heads/master@{#713707}
-
Miguel Casas authored
This CL continues substituting LOG_ASSERT()s with ASSERT_TRUE()s, where the function has void(...) signature, or with ADD_FAILURE() otherwise. This avoids crashing the test binary in Tast test runs. Bug: 1020776 Change-Id: I228dc570d5b1c19fdc766313d194f637f8418f58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904848Reviewed-by:
David Staessens <dstaessens@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#713706}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/81a8d282d356..52591f688023 git log 81a8d282d356..52591f688023 --date=short --no-merges --format='%ad %ae %s' 2019-11-08 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@52591f688023 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC ethannicholas@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ethannicholas@google.com Bug: None Change-Id: I667cc2d8bcaeac9bf7cc092c52e3a7a8b6a1ba79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903933Reviewed-by:
-
Anastasia Helfinstein authored
Switch Access has been occasionally getting console errors because a node's location is undefined. This CL adds checks to avoid that. Bug: None Change-Id: Id7ea375fd82b2100cafc4d3d4bb0d9226d183b6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904542Reviewed-by:
Aran Gilman <gilmanmh@google.com> Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Cr-Commit-Position: refs/heads/master@{#713704}
-
Kevin Bailey authored
After a previous change, it was apparent that OmniboxEditModel was exposing more members than it needed to, and that the code was a little more complicated than necessary. This CL encapsulates the call, so that no data needs to be public, and the code is simpler. Change-Id: Ibb3dcc23148d1e2568f54a9645de4c4267e3d2b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903619Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Kevin Bailey <krb@chromium.org> Cr-Commit-Position: refs/heads/master@{#713703}
-
Eric Roman authored
Bug: 1021236 Change-Id: I8e9f75916d13a388d2074811c8b09fe9eda3229f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898775 Auto-Submit: Eric Roman <eroman@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#713702}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/72a245e4c678..a14152fd51b9 git log 72a245e4c678..a14152fd51b9 --date=short --no-merges --format='%ad %ae %s' 2019-11-07 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@a14152fd51b9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: None Change-Id: Ib472fd469cba6ab06605c1d2f83b4008ed5ad39c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904807Reviewed-by:
-
Joel Hockey authored
In order to save space on rootfs, we will store crosh and terminal assets gzipped. This CL allows the data source to serve non-compressed or gzipped files. E.g. on a request for chrome://terminal/js/terminal.js, we first search for /usr/share/chromeos-assets/crosh_builtin/js/terminal.js, and serve it if it exists, else we search for /usr/share/chromeos-assets/crosh_builtin/js/terminal.js.gz and serve the uncompressed contents. Bug: 1022250 Change-Id: I3060d86d64b43673ad7c75606083fad2dc3b33fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903170Reviewed-by:
calamity <calamity@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#713700}
-
Sophie Chang authored
Bug: 969558 Change-Id: I12fb95184b6d663a424bafe97cc2e6d640cdddeb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902112 Commit-Queue: Sophie Chang <sophiechang@chromium.org> Reviewed-by:
-
Clark DuVall authored
Adds EmbeddedTestServerRule to InstrumentationActivityTestRule so all tests have access to the test server without needing to start/stop it themselves. This is similar to what ChromeActivityTestRule does. Change-Id: I17820927c9bd9d8ac2d36fecb794f611de697975 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904689 Commit-Queue: Clark DuVall <cduvall@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#713698}
-
Darren Shen authored
In https://codereview.chromium.org/2035753003, we started switching the user account as soon as the user focused on a user pod in the lock screen. This was to update parts of the "shelf user icon" based on the focused user pod. However, this has unintended consequences. When the screen is locked, the system is in a special "locked" state. Switching the active user assumes we're in interactive user session state, so it breaks this assumption system wide. One unintended consequence is on IMEs: The lock screen code assumes that active user can only change after auth success, and uses this assumption for managing the user's IME state. This causes the IME state to be incorrectly restored in some cases, which breaks keyboard typing for some users, breaks the virtual keyboard, and shows an incorrect list of IMEs in the shelf. We revert this change as it may have consequences for not just IMEs. We need to implement this feature in a different way (without switching the active user). Bug: 911699, 942392, 980792, b:143235444, b:143906227, 614926 Change-Id: I0691256ecad20c683003004d99469692b4e4ac8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904558 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#713697}
-
