GitLab

Bug: 987014
Change-Id: Id8b75318fba5382077523114781d29f8f45a301e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819353
Commit-Queue: Archana Simha <archanasimha@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#718289}

Bug: 978298
Change-Id: I2e1a00223a2313511667f93063192b4e98475346
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931078
Commit-Queue: Jasper Chapman-Black <jaspercb@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#718288}

https://pdfium.googlesource.com/pdfium.git/+log/26b030de1b76..e87972e30da4

git log 26b030de1b76..e87972e30da4 --date=short --no-merges --format='%ad %ae %s'
2019-11-22 tsepez@chromium.org Fix downcast in CXFA_FFTextEdit.

Created with:
  gclient setdep -r src/third_party/pdfium@e87972e30da4

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pdfium-autoroll
Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: chromium:1026918
Tbr: pdfium-deps-rolls@chromium.org
Change-Id: I99f2443f4efdb0ab23268e332a4e8036b5ceec75
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931163Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#718287}

This reverts commit 7798da0c.

Reason for revert: Enable by default again for M80.

Original change's description:
> [ios] Change EmbedderBlockRestoreUrl default official value.
> 
> Change-Id: Ib1049641e3035846e6e26ca545206dc28e576ece
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929266
> Commit-Queue: Justin Cohen <justincohen@chromium.org>
> Reviewed-by: Rohit Rao <rohitrao@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#718157}

TBR=rohitrao@chromium.org,justincohen@chromium.org

Change-Id: I10827d3b4cfa295b4f9d40ffb54b193b2dbf2273
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931201Reviewed-by: Justin Cohen <justincohen@chromium.org>
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#718286}

This CL whitelists the WebRTC statistics total (squared) inter frame delay
and adds two derived statistics, average inter frame delay and the
standard deviation of the inter frame delay.

Bug: webrtc:11108
Change-Id: I1b8e4c38a0093e622341f67590e930102a534d5f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929819Reviewed-by: Henrik Boström <hbos@chromium.org>
Commit-Queue: Johannes Kron <kron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#718285}

Bug: 1017632
Change-Id: Ibb873519cbeb0b83dab5e15661e7dbe21c1f5b22
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879199Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Commit-Queue: Yann Dago <ydago@chromium.org>
Cr-Commit-Position: refs/heads/master@{#718284}

This should be fixed in v8 via https://crrev.com/c/1930615.

R=ahaas@chromium.org

Bug: chromium:1025184, chromium:1027131
Change-Id: Ic9be384a777910b6da59f1a9252be88638d6c8f4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930557Reviewed-by: Andreas Haas <ahaas@chromium.org>
Commit-Queue: Clemens Backes <clemensb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#718283}

Add an specific shelf background type for the in-app shelf, which is
shown on tablet mode. This will help have more control of the trasitions
to or from in-app state.

Bug: 1024645
Change-Id: I091cfcd529c2dd632366bb12341cc482bb37cace
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928013Reviewed-by: Alex Newcomer <newcomer@chromium.org>
Reviewed-by: Manu Cornet <manucornet@chromium.org>
Commit-Queue: Ana Salazar <anasalazar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#718282}

This patch sanitizes clipboard markup before pasting it into document
by removing all pasted style elements and serializing them onto
elements as inline style. In this way, we stop stylesheets in clipboard
markup from being applied to the original elements in the document.

This patch follows the same approach as in WebKit [1]:
- First create a dummy document to insert the markup
- Then computes style and layout in the dummy document
- Re-serialize the dummy document as the markup to be inserted. This
  reuses the code path that we serialize a selection range into
  clipboard, where we need to serialize element computed style into
  inline styles so that the element styles are preserved.
- Make sure all style elements are removed before inserting markup
  into document

This patch also adds a complete test to ensure that content pasted from
Excel is still properly styled, which is the main reason we used to
preserve style elements in clipboard markup [2].

[1] https://trac.webkit.org/changeset/223440
[2] http://crbug.com/121163

Bug: 1017871
Change-Id: I3bb5a4ae7530a3fdef5ba251975e004857c06f1e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1922919
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#718281}

Change-Id: I18672227a10a1988ce252a8fbf528684c317714d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931267Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Commit-Queue: Pavel Feldman <pfeldman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#718280}

R=enne@chromium.org

Bug: 1024966
Change-Id: Ie6e4e3956a85e2acdf0be7efcbd47a4e9e000a9a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931200
Commit-Queue: Daniel Murphy <dmurph@chromium.org>
Reviewed-by: enne <enne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#718279}

These tests are intermittently timing out on Marshmallow, but
appear to be fine on earlier versions.

BUG=1023426
TBR=twellington@chromium.org

Change-Id: Icce89903bf810bfd075880d86d6e3b72cad2be72
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931149
Commit-Queue: Donn Denman <donnd@chromium.org>
Reviewed-by: Donn Denman <donnd@chromium.org>
Auto-Submit: Donn Denman <donnd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#718278}

https://chromium.googlesource.com/chromium/llvm-project/compiler-rt/lib/fuzzer.git/+log/b9f51dc8c980..debe7d2d1982

$ git log b9f51dc8c..debe7d2d1 --date=short --no-merges --format='%ad %ae %s'
2019-10-11 jakehehrlich [libFuzzer] Don't prefix absolute paths in fuchsia.
2019-10-09 jakehehrlich [libFuzzer] Fix Alarm callback in fuchsia.
2019-10-01 morehouse [libFuzzer] Remove lazy counters.
2019-09-27 hctim [libFuzzer] Dump trace and provide correct msg for overwritten input.
2019-09-26 hctim [libFuzzer] [NFC] Fix grammar error with "it's"
2019-09-17 jakehehrlich [libFuzzer] Always print DSO map on Fuchsia libFuzzer launch
2019-09-16 dor1s [libFuzzer] Remove unused version of FuzzedDataProvider.h.
2019-09-11 dor1s [libFuzzer] Make -merge=1 to reuse coverage information from the control file.
2019-08-22 mcgov LibFuzzer support for 32bit MSVC
2019-08-21 sammccall reland [gtest] Fix printing of StringRef and SmallString in assert messages.
2019-08-12 dor1s [libFuzzer] Merge: print feature coverage number as well.
2019-08-09 dor1s [libFuzzer] Merge: print stats after reading the output corpus dir.
2019-08-08 dor1s [compiler-rt] Add ConsumeProbability and ConsumeFloatingPoint methods to FDP.
2019-08-06 dor1s [compiler-rt] Rename FuzzedDataProvider.h to .hpp and other minor changes.
2019-08-05 kongyi Build libfuzzer libcxx-static with PIC
2019-08-05 dor1s [compiler-rt] Move FDP to include/fuzzer/FuzzedDataProvider.h for easier use.
2019-07-31 nico compiler-rt: Rename .cc file in lib/sanitizer_common to .cpp
2019-07-23 dor1s [libFuzzer] Fix __sanitizer_print_memory_profile return type in ExtFunctions.def
2019-07-09 dor1s [libFuzzer] Include FuzzedDataProvider.h in the test without "utils" subdir.
2019-06-27 phosek [libFuzzer] Migrate to the new exception syscalls on Fuchsia
2019-06-21 kcc [libFuzzer] split DataFlow.cpp into two .cpp files, one of which can be compiled w/o dfsan to speed things up (~25% speedup)

Created with:
  roll-dep src/third_party/libFuzzer/src

TBR=metzman@chromium.org

Bug: 539572
Change-Id: I5a8ec83cb4565fa6c519c2373020230e93f7d556
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928898Reviewed-by: Max Moroz <mmoroz@chromium.org>
Reviewed-by: Jonathan Metzman <metzman@chromium.org>
Commit-Queue: Max Moroz <mmoroz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#718277}

- Guard HungPluginTabHelper and PluginObserver with
  BUILDFLAG(ENABLE_PLUGINS).
- Sort sections guarded by buildflags alphabetically.

Bug: 1027360
Change-Id: Iab94fe425d160635554215b98494c7b7ac94f138
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929626Reviewed-by: Tommy Li <tommycli@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#718276}

This CL refactors and clarifies some of the terminology and code related
to CC's scroll chaining around viewport layers. A summary of the
changes:

- Remove the "MainScrollNode" terminology. It comes from a time when
  only the outer viewport was ever used in the scroll chain which is no
  longer the case. Given that this is just an alias for the outer node
  it only adds needless terminology.

- Adds GetNodeToScroll to turn a ScrollNode found while walking up the
  scroll tree into the node to use to get the appropriate viewport
  behavior.

- Audited all call sites of ViewportMainScrollNode and made sure we used
  either ShouldScroll or OuterViewportScrollNode as appropriate.
  ShouldScroll must be used when we want to know if the ScrollNode will
  use cc::Viewport for scrolling (i.e. it's either inner or outer).
  OuterViewportScrollNode is used only in cases where we want the full
  outer/inner distributing scroll behavior.

- Fixed some tests to create viewport layers. Needed because they were
  hitting the DCHECK I added but later removed; however, this is still
  a good change.

- Fixed RootScrollerScrollNonDescendant. This test was setup incorrectly
  since multiple ScrollNodes had |scrolls_outer_viewport| set and the
  inner viewport should have |prevent_viewport_scrolling_from_inner| set
  since we have a non-default root scroller. It passed because the
  original viewport had no scrolling so we never tried to scroll it. Now
  that DistributeScrollDelta will add the inner scroll node, and it
  didn't have the |prevent...| bit set, it caused the test to fail. This
  is a failure in the test, not in the logic.

- Change viewport() to be a ref rather than a pointer since it's never
  nullptr.

Bug: 1016229
Change-Id: I0094d203139362aa310848849c680ae664e4e5b5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866279Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#718275}

Added a flag to EndPositionStrategy which allows it to prioritize the
previously snapped targets when finding a snap point. If no target is
found then it defaults to finding the closest snap point as it does
normally. Also added unit tests.

This is currently not used, but will be used in a follow-up patch for
resnapping the container when layout changes occur.

Bug: 866127
Change-Id: I9c8d6db608a5219f4178afe0a79136b81cfb3378
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929644
Commit-Queue: Kaan Alsan <alsan@google.com>
Reviewed-by: Majid Valipour <majidvp@chromium.org>
Reviewed-by: Yi Gu <yigu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#718274}

Commit 5fc24a75 is confirmed to have broken these bots; however, after
local testing it was determined that it was just the removal of this
dependency that caused the break.

Bug: 1027334
Change-Id: I794f6702014affe986a2ddf0dd27f1a66a60cfc5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931157
Auto-Submit: Alexander Cooper <alcooper@chromium.org>
Commit-Queue: Ken Rockot <rockot@google.com>
Reviewed-by: Ken Rockot <rockot@google.com>
Cr-Commit-Position: refs/heads/master@{#718273}

Establish the deny list entries as enum string values.

Rename the existing 'printing.printer_type_blacklist' to
'printing.printer_type_deny_list'. Previously, there was no part of
the code that was able to set the pref; therefore, no migration code
is necessary in the renaming.

Follow-up of crrev.com/712342

Bug: 487875
Change-Id: I2fc8998772c36d752303c5abd62ea48b4fff6f7a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884287Reviewed-by: Owen Min <zmin@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Greg Thompson <grt@chromium.org>
Commit-Queue: Daniel Hosseinian <dhoss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#718272}

There is a possible race that results in a terminated gpu process.

That is, a surface may have been destroyed right before a request
that creates or commits buffers. To fix that, always create
buffers anonymously aka not attached to any surfaces, and simply
remove the pointer that the WaylandBufferManagerHost::Surface has
to the WaylandWindow so that it does not try to do anything except
the destruction of buffers, the call for which can come later
from the GPU process.

Bug: 1006813
Change-Id: I9f207ec8dac92b94a1e8f8b9fc9cd3fdb0186580
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1924247Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Maksim Sisov <msisov@igalia.com>
Cr-Commit-Position: refs/heads/master@{#718271}

https://chromium.googlesource.com/catapult.git/+log/102af505dafe..8412598cca10

git log 102af505dafe..8412598cca10 --date=short --no-merges --format='%ad %ae %s'
2019-11-22 dproy@chromium.org Add python inputs for tracing:generate_about_tracing

Created with:
  gclient setdep -r src/third_party/catapult@8412598cca10

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/catapult-autoroll
Please CC oysteine@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: chromium:1025132
Tbr: oysteine@google.com
Change-Id: I49eac51504449d7405e222b3154158aa6318e60f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928342Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#718270}

Before:
  File "/usr/local/google/home/dtseng/projects/chrome/src/third_party/chromevox/third_party/closure-library/closure/bin/build/depstree.py", line 56, in __init__
    raise NamespaceNotFoundError(require, source)
NamespaceNotFoundError: Namespace "cvox.AbstractEarcons" never provided. Required in <jsbundler.SourceWithPaths object at 0x7fcc566aa150>

After:
  File "/usr/local/google/home/dtseng/projects/chrome/src/third_party/chromevox/third_party/closure-library/closure/bin/build/depstree.py", line 56, in __init__
    raise NamespaceNotFoundError(require, source)
NamespaceNotFoundError: Namespace "cvox.AbstractEarcons" never provided. Required in common/classic_earcons.js
Issue:
closure-library/closure/bin/build/depstree.py
(part of Closure Library code)
does:
          raise NamespaceNotFoundError(require, source)

but |source| has no stringification that's friendly so you get the raw
jsbundler.SourceWithPaths
(which inherits from the Closure Library |Source| class).

Fix by providing __str__ in the jsbundler.SourceWithPaths object (so we don't have to mod Closure Library).

Change-Id: I72ca69869690661aabebc2b68843d7b2a8e6d428
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929915Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#718269}

R=fserb@chromium.org

Bug: 1018629
Change-Id: I8b552e92456bd8ee79e04f8f55e3c27a2d53e56f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1922305
Auto-Submit: Khushal <khushalsagar@chromium.org>
Commit-Queue: Fernando Serboncini <fserb@chromium.org>
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#718268}

The fix of multiple cycles of progress is at chromium:1926650.

Bug: chromium:1026443
Test: ./out/Default/unit_tests --gtest_filter=DlcserviceClientTest.*
Change-Id: I280d8c81041342feeb2a4701b689cae4922a5497
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930470
Commit-Queue: Jae Hoon Kim <kimjae@chromium.org>
Auto-Submit: Jae Hoon Kim <kimjae@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#718267}

Report animation smoothness for the transition into the hotseat in the
HomeLauncher.

Bug: 1022178, 1022177
Change-Id: I5dc5e76688aa5a88bcabb5d688b419d819932867
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917941
Commit-Queue: Ana Salazar <anasalazar@chromium.org>
Reviewed-by: Alex Newcomer <newcomer@chromium.org>
Reviewed-by: Manu Cornet <manucornet@chromium.org>
Reviewed-by: Nik Bhagat <nikunjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#718266}

Reverted due to "chromeos-*" builders not working with Goma RBE.
See crbug.com/1027312

The new version of the CL has had the failing builders removed.

================================================

CI:
- ChromiumOS ASAN Release
- Libfuzzer Upload Chrome OS ASan
- Linux Chromium OS ASan LSan Builder
- Linux ChromiumOS Full
- Linux ChromiumOS MSan Builder
- Mojo ChromiumOS
(remaining builders removed)

Try:
- linux_chromium_chromeos_asan_rel_ng
- linux_chromium_chromeos_msan_rel_ng
- linux_mojo_chromeos
(remaining builders removed)

Schedule of migration:
https://docs.google.com/spreadsheets/d/1TZhpasm6iceYm7zqkyEtZ1wn9ZcpREfH4LV4cusICJA/edit#gid=0

Bug: 950413, 1027312
Change-Id: I8bca8bff1af888e5167bb16ebf275920ff2aa30f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928386Reviewed-by: Ben Pastene <bpastene@chromium.org>
Reviewed-by: Aaron Gable <agable@chromium.org>
Reviewed-by: Yoshisato Yanagisawa <yyanagisawa@google.com>
Commit-Queue: Simon Que <sque@chromium.org>
Cr-Commit-Position: refs/heads/master@{#718265}

The use experience is largely the same, but it is very different from
our crash reporting perspective. Lost context shutdowns are clean and
don't show up as a crash report.

They are treated similarly by GPU blacklisting.

Bug: 1026872
Change-Id: I00559c7ef5276fe6c7c9aee832ff016a0a755156
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929153
Commit-Queue: Jonathan Backer <backer@chromium.org>
Auto-Submit: Jonathan Backer <backer@chromium.org>
Reviewed-by: Peng Huang <penghuang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#718264}

Using wpt-import in Chromium ff3bbb5d.
With Chromium commits locally applied on WPT:
e83dd93c "Limit backtracking on regexp called from blink."
500a74f5 "Add a runtime flag to enforce strict MIME type checks for workers."


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
foolip@chromium.org, lpz@chromium.org, robertma@chromium.org:
  external/wpt/tools

NOAUTOREVERT=true
TBR=robertma

No-Export: true
Change-Id: Ie5a2ae60d915b2a7aba393d6d9d08c367b0d7fe9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930342Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#718263}

Using extracted color occasionally causes a11y problems: contrast
between background and text is not sufficient (especially error view).
New background color is a combination of extracted dark muted color
and black. When in session blur is applied.

Bug: 999390
Change-Id: Id805a359d76acb9e09ae1c0ad2c392de0d16523c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930107Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Aga Wronska <agawronska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#718262}

Bug: 1027514
Change-Id: I0c4cbb90fae9cc3eecbeeb8f0e8c36702cbcf60b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931153
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Eric Stevenson <estevenson@chromium.org>
Auto-Submit: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Eric Stevenson <estevenson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#718261}

An id_path in the Tiger viewer is either a source path or a source path
prepended with some grouping information (a '>'-separated component like
"Blink>JavaScript>Runtime", or a template name like "std::vector<>").

Previously these concatenations were constructed and allocated, which
was extremely costly if the source path was very long. This change adds
a lightweight GroupPath object, which is basically a pair of
string_views with some utility methods for obtaining parent paths. This
also cleans up a lot of thorny logic for path-parsing: now, source_paths
are '/'-split, and the group can have a custom separator ('>' for "group
by component", '/' for other/group-by-template, since we don't want to
split on '>' characters in templates.

Unfortunately, now that id_paths are stored as this lightweight
GroupedPath object, TreeBuilder::Open(string path) can no longer do a
hashmap lookup by id_path key. In hindsight we could have maintained a
hashmap from GroupedPath -> TreeNode* and try all brute-force
string-splits of the path passed to Open(), but what I did instead was
split the input path into tokens and recurse down the tree looking for
nodes with matching names. This regresses tree performance for nodes
with many, many children, since tree traversal is doing a linear scan
on each level. Definitely not worth addressing in this CL, though.

Tests were added in a previous CL to ensure this change is safe.

Change-Id: I377d880ca1b8861a88d54bc2a208824fb4b8fb02
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929533
Commit-Queue: Jasper Chapman-Black <jaspercb@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Samuel Huang <huangs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#718260}

The downloader can have a retry loop up to 15 requests long, which is
almost 36 hours long under the existing strategy.

Bug: 899003
Change-Id: Ie585836154094f23e282ff700ad3bfa3dbd51ec4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1922358
Auto-Submit: Joshua Pawlicki <waffles@chromium.org>
Commit-Queue: Sorin Jianu <sorin@chromium.org>
Reviewed-by: Sorin Jianu <sorin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#718259}

This CL removes NullValue() from ComputeCurrentTime by returning an Optional.
Instead of NaN the method returns now a base::nullopt;

Some NullValue() had to be temporarily added in order to limit the amount of
required changes. They'll be all removed in a follow up patch that will remove
the NullValue() from CurrentTimeInternal().

Bug: 737867
Change-Id: I767e2a24ad7a99a64353acbdd651733ee19c93a0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928781Reviewed-by: Kevin Ellis <kevers@chromium.org>
Commit-Queue: Sergio Villar <svillar@igalia.com>
Cr-Commit-Position: refs/heads/master@{#718258}

TEST=calling the API from Tast, saw expected behavior
BUG=chromium:893332

Change-Id: Ie44376a1c2e5817a863b359550d1f0eade6e8cb0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918301Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Victor Hsieh <victorhsieh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#718257}

Add metrics to track the percentage of VTT sheets that contain embedded style blocks.

Bug: 1027239
Change-Id: I3bf549b3d10f7cede611861944536aa1082aff69
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928201
Commit-Queue: Evan Liu <evliu@google.com>
Reviewed-by: Fredrik Söderquist <fs@opera.com>
Reviewed-by: Brian White <bcwhite@chromium.org>
Cr-Commit-Position: refs/heads/master@{#718256}

https://skia.googlesource.com/skia.git/+log/fe13ca3e67d3..189c98042f16

git log fe13ca3e67d3..189c98042f16 --date=short --no-merges --format='%ad %ae %s'
2019-11-22 michaelludwig@google.com GrQuadPerEdgeAA::Tessellator owns GrVertexWriter

Created with:
  gclient setdep -r src/third_party/skia@189c98042f16

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC robertphillips@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: robertphillips@google.com
Change-Id: I1597df17e3a7610bce1a3f40a7ec886695e0b474
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928798Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#718255}

Bug: 1007656
Change-Id: Ibbcb4c8987516f96294243e2a08ebc8c2287f1a4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1924705
Auto-Submit: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#718254}

Skipping betty presubmits for now. See crbug.com/1024929 for details.
#CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-chrome
#CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome

CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-compile-chrome
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-compile-chrome

BUG=762641, 1024929
TBR=chrome-os-gardeners@google.com

Change-Id: I399e3c810b015de581a44145e7ef8083a38d6106
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930837
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Reviewed-by: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#718253}

googletest will no longer support empty prefix
for parameterized INSTANTIATE_TEST_SUITE_P.
Adding "All" prefix to existing empty prefix test suites.

This CL was uploaded by git cl split.

R=fserb@chromium.org

Bug: 1023677
Change-Id: Ibb1d4e3306f0ea0749604ae6ba1d4bd94a0f86b3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926816
Auto-Submit: Ilia Samsonov <isamsonov@google.com>
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Commit-Queue: Fernando Serboncini <fserb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#718252}

WrapVulkanImageOpaqueFD was deprecated in an earlier CL [1] in favor
of the new WrapVulkanImage API. Now that the Dawn CL has rolled into
Chromium, this CL switches over the call in Chromium.

[1] https://dawn-review.googlesource.com/c/dawn/+/13782

BUG=996470

Change-Id: I4b7438c01739ee0fa7fc1908324f6aab376bb581
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931145
Commit-Queue: Brian Ho <hob@chromium.org>
Reviewed-by: Peng Huang <penghuang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#718251}

Bug: 1007797
Change-Id: Ic18cf3733c107d3f24f9089095bc27276395ee60
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928387
Auto-Submit: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Ken Rockot <rockot@google.com>
Reviewed-by: Ken Rockot <rockot@google.com>
Cr-Commit-Position: refs/heads/master@{#718250}