GitLab

This adds a few header-only targets which are useful for explicitly
tracking our dependencies and propagating configs.

R=viettrungluu@chromium.org

Review URL: https://codereview.chromium.org/599283003

Cr-Commit-Position: refs/heads/master@{#296900}

The Page class was being declared in page/page.py which was creating problems
for several module-level functions handling pages which were being declared
(CL to follow). This CL kills page.py and moves the associated logic into
page/__init__.py, in line with e.g. value/.

R=dtu,nednguyen,chrishenry

Review URL: https://codereview.chromium.org/556453003

Cr-Commit-Position: refs/heads/master@{#296899}

Cleaning up weak_ptr_factory destruction order in "src/chrome/browser/ui"
module. WeakPtrFactory should remain the last member so it'll be destroyed and
invalidate its weak pointers before any other members are destroyed.

BUG=303818

Review URL: https://codereview.chromium.org/603383003

Cr-Commit-Position: refs/heads/master@{#296898}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/4a81f0d..17c2127

TBR=ager@chromium.org,zmo@chromium.org

Review URL: https://codereview.chromium.org/607003002

Cr-Commit-Position: refs/heads/master@{#296897}

main tag or aria role main is not exposed with correct
IA2 role.
The correct IA2 role for main is ROLE_SYSTEM_GROUPING

BUG=417654

Review URL: https://codereview.chromium.org/601173002

Cr-Commit-Position: refs/heads/master@{#296896}

Moving device_info* and local_device_info_provider.h to components/sync_driver
and updating namespaces for the related classes from browsing_sync to sync_driver.

Most of the changes are mechanical - trivial changes of header files and namespaces.
There are just few less trivial changes:
1) I've removed GetClientName from DeviceInfo because it depended on content/public.
Instead I've inlined GetClientName code (which is rather trivial) in two places where
it was used, including supervised_user_registration_utility.cc.
That required me to update DEPS file for supervised_user. There isn't anything new
in reality - these dependencies already existed indirectly.
2) Added two extra parameters to DeviceInfoDataTypeController to avoid having
direct dependencies on the browser.

TBR=pkasting@chromium.org,yoz@chromium.org
BUG=396136

Review URL: https://codereview.chromium.org/597423002

Cr-Commit-Position: refs/heads/master@{#296895}

This is part of a long-running background task to remove the remaining
uses of the unchecked IPC_ENUM_TRAITS() macro.

BUG=246708

Review URL: https://codereview.chromium.org/603893002

Cr-Commit-Position: refs/heads/master@{#296894}

Revert of Revert of Do not call run_webkit_tests.py in android buildbot scripts. (patchset #1 id:1 of https://codereview.chromium.org/609713002/)

Reason for revert:
That revert was apparrently a really bad idea. Now all the bots are failing. Reverting the revert and hoping that will bring us back to one failing bot.

Original issue's description:
> Revert of Do not call run_webkit_tests.py in android buildbot scripts. (patchset #2 id:20001 of https://codereview.chromium.org/603563002/)
>
> Reason for revert:
> Makes the webkit_lint step fail on android bots:
>
> @@@BUILD_STEP webkit_lint@@@
> > /b/build/slave/WebKit_Android__Nexus4_/build/src/third_party/WebKit/Tools/Scripts/lint-test-expectations --target Release
> Usage: lint-test-expectations [options]
>
> lint-test-expectations: error: no such option: --target
> < /b/build/slave/WebKit_Android__Nexus4_/build/src/third_party/WebKit/Tools/Scripts/lint-test-expectations --target Release
> ERROR: process exited with code 2
> @@@STEP_FAILURE@@@
>
> Original issue's description:
> > Do not call run_webkit_tests.py in android buildbot scripts.
> >
> > Replace its usage by lint-test-expectations and run-webkit-tests, both
> > scripts found in third_party/WebKit/Tools/Scripts.
> >
> > BUG=338338
> > TEST=None
> > R=dpranke@chromium.org,cmp@chromium.org
> >
> > Committed: https://crrev.com/9c330bf94b161a4a19b1bcccb33b169843b4fd10
> > Cr-Commit-Position: refs/heads/master@{#296883}
>
> TBR=cmp@chromium.org,dpranke@chromium.org,tfarina@chromium.org
> NOTREECHECKS=true
> NOTRY=true
> BUG=338338
>
> Committed: https://crrev.com/ce392c3ccf021a094e21ffa3ca3babeb313b4821
> Cr-Commit-Position: refs/heads/master@{#296892}

TBR=cmp@chromium.org,dpranke@chromium.org,tfarina@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=338338

Review URL: https://codereview.chromium.org/598083006

Cr-Commit-Position: refs/heads/master@{#296893}

Revert of Do not call run_webkit_tests.py in android buildbot scripts. (patchset #2 id:20001 of https://codereview.chromium.org/603563002/)

Reason for revert:
Makes the webkit_lint step fail on android bots:

@@@BUILD_STEP webkit_lint@@@
> /b/build/slave/WebKit_Android__Nexus4_/build/src/third_party/WebKit/Tools/Scripts/lint-test-expectations --target Release
Usage: lint-test-expectations [options]

lint-test-expectations: error: no such option: --target
< /b/build/slave/WebKit_Android__Nexus4_/build/src/third_party/WebKit/Tools/Scripts/lint-test-expectations --target Release
ERROR: process exited with code 2
@@@STEP_FAILURE@@@

Original issue's description:
> Do not call run_webkit_tests.py in android buildbot scripts.
>
> Replace its usage by lint-test-expectations and run-webkit-tests, both
> scripts found in third_party/WebKit/Tools/Scripts.
>
> BUG=338338
> TEST=None
> R=dpranke@chromium.org,cmp@chromium.org
>
> Committed: https://crrev.com/9c330bf94b161a4a19b1bcccb33b169843b4fd10
> Cr-Commit-Position: refs/heads/master@{#296883}

TBR=cmp@chromium.org,dpranke@chromium.org,tfarina@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=338338

Review URL: https://codereview.chromium.org/609713002

Cr-Commit-Position: refs/heads/master@{#296892}

The following lint warnings are issued every time when chrome/content
shell is built

../../../tmp/tmp6VcHbX/0/MediaResourceGetter.java:365 Do not hardcode "/sdcard/";
 use Environment.getExternalStorageDirectory().getPath() instead: SdCardPath [warning]
        result.add("/mnt/sdcard/");
                   ~~~~~~~~~~~~~~
../../../tmp/tmp6VcHbX/0/MediaResourceGetter.java:366 Do not hardcode "/sdcard/";
 use Environment.getExternalStorageDirectory().getPath() instead: SdCardPath [warning]
        result.add("/sdcard/");
                   ~~~~~~~~~~
../../../tmp/tmp6VcHbX/0/MediaResourceGetter.java:367 Do not hardcode "/data/";
 use Context.getFilesDir().getPath() instead: SdCardPath [warning]
        result.add("/data/data/" + context.getPackageName() + "/cache/");

As these hardcoded values are required and the warnings here are false positives
which are more explained in https://codereview.chromium.org/561743003/#msg5

BUG=None.

Review URL: https://codereview.chromium.org/597283007

Cr-Commit-Position: refs/heads/master@{#296891}

Replace placeholder extension ID for hotwording shared module with ID of module uploaded to the Chrome web store.

Also, auto-install hotword shared module when hotwording is enabled.

BUG=397019

Review URL: https://codereview.chromium.org/599053004

Cr-Commit-Position: refs/heads/master@{#296890}

BUG=none
TEST=none
R=avi@chromium.org

Review URL: https://codereview.chromium.org/603263003

Cr-Commit-Position: refs/heads/master@{#296889}

Becuase base/strings/string_split.h defines:
typedef std::vector<std::pair<std::string, std::string> > StringPairs;

BUG=412250

Review URL: https://codereview.chromium.org/591413002

Cr-Commit-Position: refs/heads/master@{#296888}

This is part of a long-running background task to remove the remaining
uses of the unchecked IPC_ENUM_TRAITS() macro.

BUG=246708

Review URL: https://codereview.chromium.org/603673003

Cr-Commit-Position: refs/heads/master@{#296887}

Move GetAppWindowForNativeWindowAnyProfile(), IsAppWindowRegisteredInAnyProfile(), CloseAllAppWindows() from extensions::AppWindowRegistry to a new class AppWindowRegistryUtil.
These functions are only needed by chrome.
Also, putting these functions in chrome/browser/apps
allows them to get the loaded profiles directly from ProfileManager rather than
requiring the AppsClient::GetLoadedBrowserContexts delegate method.

BUG=411352
TBR=sky@chromium.org for include fix & class rename under chrome/browser

Review URL: https://codereview.chromium.org/586613002

Cr-Commit-Position: refs/heads/master@{#296886}

* Populate volumes without resolving their display root.
The display root will be resolved after decorate() of the volume item.
If failed, the display root will be tried to be resolved when the volume item is activated (by click/Ctrl+N/etc...).
* Remove DirectoryTree.models_, which was a temporary variable to keep resolved display roots.

BUG=413317
TEST=manually tested the case when the first resolveDisplayRoot() fails. run browser_tests.

Review URL: https://codereview.chromium.org/593573003

Cr-Commit-Position: refs/heads/master@{#296885}

BUG=388083
TEST=code still compiles
R=guohui@chromium.org
NOPRESUBMIT=true
NOTRY=true

Review URL: https://codereview.chromium.org/579033002

Cr-Commit-Position: refs/heads/master@{#296884}

Replace its usage by lint-test-expectations and run-webkit-tests, both
scripts found in third_party/WebKit/Tools/Scripts.

BUG=338338
TEST=None
R=dpranke@chromium.org,cmp@chromium.org

Review URL: https://codereview.chromium.org/603563002

Cr-Commit-Position: refs/heads/master@{#296883}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/81a8a76..4a81f0d

TBR=ager@chromium.org,zmo@chromium.org

Review URL: https://codereview.chromium.org/605083002

Cr-Commit-Position: refs/heads/master@{#296882}

BUG=

Review URL: https://codereview.chromium.org/594393002

Cr-Commit-Position: refs/heads/master@{#296881}

Failure seen here:
http://build.chromium.org/p/chromium.perf/builders/Win%207%20Perf%20%281%29/builds/52
AssertionError: Negative energy consumption. (Starting energy was 65522.6123962.)

BUG=336556, 336558
TEST=None.
R=tonyg

Review URL: https://codereview.chromium.org/607733002

Cr-Commit-Position: refs/heads/master@{#296880}

Not exact revert of https://codereview.chromium.org/488853002

BUG=374321,416396

Committed: https://crrev.com/15daa893f50daebf33ccf06ba67d74788700e495
Cr-Commit-Position: refs/heads/master@{#296751}

Review URL: https://codereview.chromium.org/597933002

Cr-Commit-Position: refs/heads/master@{#296879}

This is part of a long-running background task to remove the remaining
uses of the unchecked IPC_ENUM_TRAITS() macro.

BUG=246708

Review URL: https://codereview.chromium.org/608443002

Cr-Commit-Position: refs/heads/master@{#296878}

This is in preparation for updating the buildbot code. First we need to
make sure we build those targets, otherwise buildbot will fail.

BUG=331829,373148,299841,103304
TEST=None
R=sky@chromium.org,maruel@chromium.org

Review URL: https://codereview.chromium.org/600833002

Cr-Commit-Position: refs/heads/master@{#296877}

Adds `gn format` command. Currently accepts one //path/to/BUILD.gn and
attempts to reformat it (to stdout). Handles the basics, but does not
handle all constructs yet, and doesn't attempt any rewrites.

R=brettw@chromium.org
BUG=348474

Review URL: https://codereview.chromium.org/591373002

Cr-Commit-Position: refs/heads/master@{#296876}

For some USB drives, writes on Mac are much slower than using the old image
creator. This is most likely because the implementation in Chrome uses
/dev/disk# whereas the old implementation used /dev/rdisk# whenever
possible.

The main requirement is that writes are in multiples of the block size, but
since ImageWriter::WriteChunk always writes in multiples of
kMemoryAlignment (4096), it should be fine to always use the raw disk.

My brief tests using a Lexar JumpDrive 16GB and a 1.6GB image:
before: ~6.5 minutes to write, same to verify
after: ~5 minutes to write, ~1.5 minutes to verify

BUG=415891

Review URL: https://codereview.chromium.org/599853002

Cr-Commit-Position: refs/heads/master@{#296875}

r296008 regressed TooltipAura vertical placement.
(that change removed vertical centering of multi-line text)
(TooltipAura implicitly used this for vertical padding)

Add an actual border and explicit Label sizing instead.
(this allocates space for the padding in the Label border)
(it also base-line centers the text in the correct bounds)

See before/after pics at http://crbug.com/417602#c5

BUG=417602
TEST=Chrome OS and "Windows 8 mode" Chrome tooltips look good.
R=sky@chromium.org

Review URL: https://codereview.chromium.org/602313002

Cr-Commit-Position: refs/heads/master@{#296874}

For answers prefetching, Chrome needs to know what the top search history
result for the current input is - _before_ issuing a search engine query
for that same input

BUG=406588

Review URL: https://codereview.chromium.org/470313004

Cr-Commit-Position: refs/heads/master@{#296873}

BUG=413488
TEST=components_unittests
R=tengs@chromium.org

Review URL: https://codereview.chromium.org/585743004

Cr-Commit-Position: refs/heads/master@{#296872}

In some case ChannelMojo outlives ChannelMojoHost because
two objects are living in diffent thread.
Instead of using lifecycle callbacks, this CL relies on
WeakPtr. See comment on ipc_channel_mojo_host.h for
more details.

This CL also fixes a crash on --single-process mode.

R=viettrungluu@chromium.org
TBR=jam@chromium.org
TEST=content_browsertests (with --enable-renderer-mojo-channel on)
BUG=377980

Review URL: https://codereview.chromium.org/599333002

Cr-Commit-Position: refs/heads/master@{#296871}

Also make the script revert local changes before 'svn co'
rather than afterwards to avoid merge conflicts if a previously
patched file changes upstream.

BUG=410810

Review URL: https://codereview.chromium.org/587433002

Cr-Commit-Position: refs/heads/master@{#296870}

This change consolidates all of the existing media indicator UI into a
new MediaIndicatorButton class.  When the indicator is transitioned to
the audio playing or muting state, the button functionality activates;
and, when clicked, will toggle tab-wide audio muting.  Otherwise, the
view only serves to paint the indicator icon with all mouse/gesture
events handled by Tab (its parent View).

Added UMA's to detect usage of the feature, attempted usage of the
disabled feature, and possible close button mis-clicks.

This new feature is off by default.  The plan is to run a UI experiment
and gather the data needed to drive later launch decisions.

Note: This change depends on: https://codereview.chromium.org/586303004/

BUG=360372,384179
TEST=With --enable-tab-audio-muting, user can click audio indicator to toggle tab muting, or use the tab context menu to toggle muting of one or more selected tabs.

Review URL: https://codereview.chromium.org/591963002

Cr-Commit-Position: refs/heads/master@{#296869}

This is part of a long-running background task to remove the remaining
uses of the unchecked IPC_ENUM_TRAITS() macro.

BUG=246708

Review URL: https://codereview.chromium.org/604753002

Cr-Commit-Position: refs/heads/master@{#296868}

machine) in prefs persistent store.

It is temporarily saved under kDummyHostname
(quic.global.props). Will change the code to save it in
globals in the next CL.

R=rch@chromium.org

Review URL: https://codereview.chromium.org/602763004

Cr-Commit-Position: refs/heads/master@{#296867}

Fixes the Ozone builder where udev isn't available.

BUG=none

Review URL: https://codereview.chromium.org/604143002

Cr-Commit-Position: refs/heads/master@{#296866}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/5be896b..81a8a76

TBR=ager@chromium.org,zmo@chromium.org

Review URL: https://codereview.chromium.org/602303002

Cr-Commit-Position: refs/heads/master@{#296865}

They don't seem to be flaky for me locally.

BUG=173621

Review URL: https://codereview.chromium.org/603853002

Cr-Commit-Position: refs/heads/master@{#296864}

BUG=N/A
TEST=N/A

Review URL: https://codereview.chromium.org/603863002

Cr-Commit-Position: refs/heads/master@{#296863}

Simplifies code as TimingFunction has no logical reason to inherit from AnimationCurve (apart from sharing a few method names). Make code more clear.

BUG=

Review URL: https://codereview.chromium.org/606543002

Cr-Commit-Position: refs/heads/master@{#296862}

Breakage caused by this case can be found in http://build.chromium.org/p/chromium.perf/builders/Android%20Nexus4%20Perf/builds/1416/steps/page_cycler.bloat/logs/stdio

BUG=

Review URL: https://codereview.chromium.org/610483002

Cr-Commit-Position: refs/heads/master@{#296861}