GitLab

Adding Test Fixture for initial test cases for the App Remoting Test Driver.  Also includes the public stubs for the remote application data methods.

Also ran clang-format on edited files to keep consistent with formatting
in my previous changelist.

BUG=467200

Review URL: https://codereview.chromium.org/1008043003

Cr-Commit-Position: refs/heads/master@{#322119}

Revert of Revert of Re-enable ChannelMojo (patchset #1 id:1 of https://codereview.chromium.org/1029263008/)

Reason for revert:
It seems it was not guilty.
According to Android Tests (dbg) bot, revering #322094 was enough.

Original issue's description:
> Revert of Re-enable ChannelMojo (patchset #1 id:1 of https://codereview.chromium.org/1021393002/)
>
> Reason for revert:
> speculative revert for "Too many open files" on various Mac bots.
> e.g. http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.9/builds/17511/steps/webkit_tests/logs/stdio
>
> Original issue's description:
> > Re-enable ChannelMojo
> >
> > It was disabled due to crbug.com/466814 that is now fixed.
> > It's time to turn it on again.
> >
> > R=viettrungluu@chromium.org
> > BUG=466814,377980
> >
> > Committed: https://crrev.com/c99c93842fa50f85888d069f0be962462f92a643
> > Cr-Commit-Position: refs/heads/master@{#322092}
>
> TBR=viettrungluu@chromium.org,morrita@chromium.org
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=466814,377980
>
> Committed: https://crrev.com/9e4596122cda5dbc959895b53679e14df45658b5
> Cr-Commit-Position: refs/heads/master@{#322113}

TBR=viettrungluu@chromium.org,morrita@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=466814,377980

Review URL: https://codereview.chromium.org/1031083002

Cr-Commit-Position: refs/heads/master@{#322118}

BUG=None
TEST=None

Review URL: https://codereview.chromium.org/1033893003

Cr-Commit-Position: refs/heads/master@{#322117}

- Update SessionInputInjectorWin and InputInjectorWin to
  handle touch events.
- Add TouchInjectorWin which converts TouchEvents to
  structs for Windows touch injection API.

BUG=314515

Review URL: https://codereview.chromium.org/991643002

Cr-Commit-Position: refs/heads/master@{#322116}

BUG=468494
R=oshima@chromium.org
TEST=the new test case fails before r321652, but succeeds on ToT.

Review URL: https://codereview.chromium.org/1026943002

Cr-Commit-Position: refs/heads/master@{#322115}

- Specified vertical-align:top, because inline blocks with vertical-align:baseline could insert unexpected vertical spacing for each lines.
- Consider the padding of the grid in getHitElements().

BUG=463042
TEST=manual test

Review URL: https://codereview.chromium.org/1034443002

Cr-Commit-Position: refs/heads/master@{#322114}

Reason for revert:
speculative revert for "Too many open files" on various Mac bots.
e.g. http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.9/builds/17511/steps/webkit_tests/logs/stdio

Original issue's description:
> Re-enable ChannelMojo
>
> It was disabled due to crbug.com/466814 that is now fixed.
> It's time to turn it on again.
>
> R=viettrungluu@chromium.org
> BUG=466814,377980
>
> Committed: https://crrev.com/c99c93842fa50f85888d069f0be962462f92a643
> Cr-Commit-Position: refs/heads/master@{#322092}

TBR=viettrungluu@chromium.org,morrita@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=466814,377980

Review URL: https://codereview.chromium.org/1029263008

Cr-Commit-Position: refs/heads/master@{#322113}

Revert of ChannelMojo: Let MessagePipeReader wait "peer closed" signal as well. (patchset #2 id:20001 of https://codereview.chromium.org/1023043002/)

Reason for revert:
speculative revert for "Too many open files" on various Mac bots.
e.g. http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.9/builds/17511/steps/webkit_tests/logs/stdio

Original issue's description:
> ChannelMojo: Let MessagePipeReader wait "peer closed" signal as well.
>
> This CL adds MOJO_SIGNAL_PEER_CLOSED for the MessagePipeReader's
> waiting bits. Without this, PRECONDITION_FAILED error can be notified
> at the end of the channel lifetime, and the browser process misinterprets
> it as a renderer crash, which results sadface screen.
>
> This rarely happens and is reproduced only with some underpowered CPU
> with excessive pressure. So we cannot have any reliable test.
>
> BUG=466814
> R=viettrungluu@chromium.org
>
> Committed: https://crrev.com/29d88220e88d21deaf6856b7ded300fa06ab94d3
> Cr-Commit-Position: refs/heads/master@{#322094}

TBR=viettrungluu@chromium.org,morrita@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=466814

Review URL: https://codereview.chromium.org/1035633002

Cr-Commit-Position: refs/heads/master@{#322112}

BUG=364645
TEST=trybots
R=dpranke@chromium.org

Review URL: https://codereview.chromium.org/1002353002

Cr-Commit-Position: refs/heads/master@{#322111}

Instead of simply outputting "Array", we now output the type of the array
(e.g., Array<number> or Array<MyCustomType>). Additionally, arrays should not
be nullable.

Choices (e.g., (DOMString or number) in an .idl) are also now supported.

BUG=461039

Review URL: https://codereview.chromium.org/1034553003

Cr-Commit-Position: refs/heads/master@{#322110}

ProxyScriptFetcherImplTest.HttpMimeType is flaky. Since proxy
script support isn't a huge priority, disable test for now.

BUG=internal b/19848784
R=gunsch@chromium.org

Review URL: https://codereview.chromium.org/1036683002

Cr-Commit-Position: refs/heads/master@{#322109}

BUG=b/19901904

Review URL: https://codereview.chromium.org/1032713002

Cr-Commit-Position: refs/heads/master@{#322108}

TBR=yoshiki@chromium.org
BUG=none
TEST=green closure bot

Review URL: https://codereview.chromium.org/1003283003

Cr-Commit-Position: refs/heads/master@{#322107}

The files.app version in the manifest is not regularly updated.  We'll get more accurate version info by using the chrome major release version.

BUG=469258

Review URL: https://codereview.chromium.org/1035483004

Cr-Commit-Position: refs/heads/master@{#322106}

> According to crash reports, it's not very common but still possible for the JsonPrefStore used by SupervisedUserSettingsService to fail initialization (which happens if the profile directory doesn't exist).

Review URL: https://codereview.chromium.org/960233003

This reverts commit 3490af83.

TBR=treib@chromium.org
BUG=463646

Review URL: https://codereview.chromium.org/1016423003

Cr-Commit-Position: refs/heads/master@{#322105}

Adding one more error code to convey process creation/spawn target error to the caller BrokerServices.

The code to use this error code will be in follow-up CL. This will be useful to differentiate UMA for launch errors.

R=rvargas@chromium.org,cpu@chromium.org,jschuh@chromium.org
BUG=

Review URL: https://codereview.chromium.org/1000863006

Cr-Commit-Position: refs/heads/master@{#322104}

We currently need it, so we should have a dependency on it.

R=erg@chromium.org

Review URL: https://codereview.chromium.org/1032733002

Cr-Commit-Position: refs/heads/master@{#322103}

We set the audible state every time after the pipeline
has successfully decoded the frame: to false if prerolling
and true otherwise, taking the volume into account.

Also, we set the state to false if the flow is going to be
 interrupted because of a coded error, abort or Pause.

As well, we set audible state to false when the starvation
happens and there is no data in the MediaDecoderJob queue,
we believe this indicates the demuxer freeze.

BUG=414810

Review URL: https://codereview.chromium.org/1008093002

Cr-Commit-Position: refs/heads/master@{#322102}

We use clang with Wextra which seems to be more reliable and report less false positives. We no longer have an intent to turn on Wextra for gcc on posix-like systems any more (except MacOS).

Review URL: https://codereview.chromium.org/1029953003

Cr-Commit-Position: refs/heads/master@{#322101}

With a few webgl aquarium demo windows open and a 1080p video playing
at the same time, you can notice the video dropping a lot frames. From
time to time being stuck on a same frame for a second or more.

This is due to the VideoRendererImpl dropping frames. It takes too
much time for the compositor to paint its content, keeping the GPU
busy and delaying decoded video frames too long. Decoded frames arrive
too late and are never presented and we stick to an old frame.

This changes the behavior of VideoRendererImpl to a best effort
strategy where we might start displaying images past their display
time, but at least we're not stuck on a same image for too long.

BUG=chrome-os-partner:37786
TEST=run the test as explained on the bug

Review URL: https://codereview.chromium.org/1005303004

Cr-Commit-Position: refs/heads/master@{#322100}

Update scanning to scan files in small batches (well batches of 1)...this fixes an issue where scanning appeared to be frozen for long periods of time.

This change also sets the stage for making Scans cancelable...which we'll want to do when a user changes directory...and even allow them to explicitly cancel a scan from the details panel.

TEST=MediaScannerTest

TBR=hirono  // for mock_media_scanner.js

Review URL: https://codereview.chromium.org/1038433002

Cr-Commit-Position: refs/heads/master@{#322099}

BUG=446327

Review URL: https://codereview.chromium.org/1026553005

Cr-Commit-Position: refs/heads/master@{#322098}

ICU 54 fixed this issue. (see http://bugs.icu-project.org/trac/ticket/10295 )

BUG=270037
TEST=TSAN build of unit_tests --gtest_filter=*ShorterUR*

Review URL: https://codereview.chromium.org/1024463010

Cr-Commit-Position: refs/heads/master@{#322097}

Needed for exposing graphics API to shared library replacement.

BUG=

Review URL: https://codereview.chromium.org/1036503003

Cr-Commit-Position: refs/heads/master@{#322096}

BUG=469868

Review URL: https://codereview.chromium.org/1027393002

Cr-Commit-Position: refs/heads/master@{#322095}

This CL adds MOJO_SIGNAL_PEER_CLOSED for the MessagePipeReader's
waiting bits. Without this, PRECONDITION_FAILED error can be notified
at the end of the channel lifetime, and the browser process misinterprets
it as a renderer crash, which results sadface screen.

This rarely happens and is reproduced only with some underpowered CPU
with excessive pressure. So we cannot have any reliable test.

BUG=466814
R=viettrungluu@chromium.org

Review URL: https://codereview.chromium.org/1023043002

Cr-Commit-Position: refs/heads/master@{#322094}

The button is still used for layout, the size of the user name text
remains resized according to the button, but this way we don't have
to override the Paint() function which helps us make Paint() no longer
virtual.

R=pkotwicz, skuhne,sky
BUG=466426

Review URL: https://codereview.chromium.org/1037443003

Cr-Commit-Position: refs/heads/master@{#322093}

It was disabled due to crbug.com/466814 that is now fixed.
It's time to turn it on again.

R=viettrungluu@chromium.org
BUG=466814,377980

Review URL: https://codereview.chromium.org/1021393002

Cr-Commit-Position: refs/heads/master@{#322092}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/3be346d..0ba31e2

TBR=alph@chromium.org,jchaffraix@chromium.org

Review URL: https://codereview.chromium.org/1035513004

Cr-Commit-Position: refs/heads/master@{#322091}

BUG=463125

Review URL: https://codereview.chromium.org/1032513003

Cr-Commit-Position: refs/heads/master@{#322090}

BUG=470229

Review URL: https://codereview.chromium.org/1033773002

Cr-Commit-Position: refs/heads/master@{#322089}

Only takes effect in --site-per-process mode.  Just the first phase of
adding frame entries; won't handle nested iframes or history navigations
yet.

BUG=236848
TEST=New unit and browser tests pass in --site-per-process mode.

Review URL: https://codereview.chromium.org/1029893002

Cr-Commit-Position: refs/heads/master@{#322088}

Remove references to android_webview_build now that we no longer support
that build configuration. Fold all conditions into the general
OS==android sections.

BUG=440793

Review URL: https://codereview.chromium.org/1010653003

Cr-Commit-Position: refs/heads/master@{#322087}

Enums used to simply be strings, but now we expose them (as string constants)
on the api object as part of the extension bindings. As such, it's appropriate
to have the externs generate an enum definition for them.

BUG=469920

Review URL: https://codereview.chromium.org/1015033003

Cr-Commit-Position: refs/heads/master@{#322086}

BUG=462584

Review URL: https://codereview.chromium.org/1028243002

Cr-Commit-Position: refs/heads/master@{#322085}

In this case Segoe UI and its linked fonts are already in the fallback list.
This is an attempt to fix the perf regression caused on the page_cycler.intl_hi_ru bot caused by the change to
remove duplicate fonts from the fallback list.

BUG=469700

Review URL: https://codereview.chromium.org/999173008

Cr-Commit-Position: refs/heads/master@{#322084}

R=brettw@chromium.org, erg@chromium.org, jamesr@chromium.org
TBR=jamesr@chromium.org

Review URL: https://codereview.chromium.org/1029113005

Cr-Commit-Position: refs/heads/master@{#322083}

This makes the BoundedLabel override View::OnPaint, allowing us to make
View::Paint non-virtual.

The functional difference is that Paint() calls PaintCommon() which:
 - Early outs if not visible
 - Paints any children

The BoundedLabel is used by NotificationView, but no children are ever
added to it and it's not exposed outside the class. So it's safe to
convert it to use OnPaint() and remove the visible early out.

R=dewittj@chromium.org, mukai@chromium.org, stevenjb@chromium.org
BUG=466426

Review URL: https://codereview.chromium.org/1035553002

Cr-Commit-Position: refs/heads/master@{#322082}

also, only cover the controls and not the instructions
also various tweaks to colors and font sizes and layout as per latest mocks.

BUG=none

Review URL: https://codereview.chromium.org/1008233004

Cr-Commit-Position: refs/heads/master@{#322081}

This upstreams all the injected JS for the web layer (but not any of
the packaging bits, which will come later)

BUG=464810

Review URL: https://codereview.chromium.org/1029983002

Cr-Commit-Position: refs/heads/master@{#322080}