- 21 Dec, 2020 40 commits
-
-
Rushan Suleymanov authored
The device info bridge should wait for all related data loaded before starting syncing. Otherwise the DeviceInfoSpecifics with some empty fields would be sent to the server on each browser startup. Bug: 1155030 Change-Id: I9ee4d5b2a1bb75c655b3ac183fc4c63fb1a19fa2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567922 Commit-Queue: Rushan Suleymanov <rushans@google.com> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#838644}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/0d23e521cc40..c65f224a7259 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Iea15e08cfe8be7559c2aff229ae350f5dcd5c07e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599398Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#838643}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1608529993-82d6d40e289e60063d3bd5c2eebe97dc9bb53838.profdata to chrome-mac-master-1608551422-fc95b9f468d4d803d74a281f45985087ff3374a0.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I542a73c729ea580dbaf5fe10c574045917da8cf1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599624Reviewed-by:
-
Finnur Thorarinsson authored
This reverts commit b8af3c0a. Reason for revert: Consistent failure on MemorySanitizer: use-of-uninitialized-value. Example: https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests/21799 Original change's description: > Oobe: Fix issue with metrics client id reset after sign in > > Issue is due to there's a small time difference between StatsReportingController::SetWithService and pref is properly set. We should only propagate the value from service until it is correctly set. > > Bug: 1154947 > Change-Id: I977249dd25e1402246b383401c9deef4ea8ebc56 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587065 > Reviewed-by: Steven Bennetts <stevenjb@chromium.org> > Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org> > Commit-Queue: Yunke Zhou <yunkez@google.com> > Cr-Commit-Position: refs/heads/master@{#838606} TBR=stevenjb@chromium.org,rsorokin@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,yunkez@google.com Change-Id: I128949522d5c3cfd6ddbaf9f769034544af4bd62 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1154947 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599535Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Cr-Commit-Position: refs/heads/master@{#838641}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/d034512dc4d9..cde5182f7aa4 2020-12-21 bmeurer@chromium.org Update Emscripten dependency to 2.0.11 2020-12-21 alcastano@google.com Make Issue Message in Source Tab link to Issues tab 2020-12-21 wolfi@chromium.org Make toolbar dropdowns optionally shrinkable 2020-12-21 janscheffler@chromium.org [Recorder] Wait for elements 2020-12-21 szuend@chromium.org [issues] Migrate SameSite issues to markdown 1/* If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1125465,chromium:1150883,chromium:1153134 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Iafe3cd2964bbd1f521a3d43a983b2895a4e049e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596647Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/5ddf384d1fb4..3974e6736435 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC finnur@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: finnur@google.com Change-Id: I0e9cb1f8eabf5d302091d51ab53ab1762bed23a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2598025Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#838639}
-
Henrik Boström authored
The SampleBufferTransformer CHECK-crashes if a sample buffer does not have a pixel buffer AND is not MJPEG. But the assumption that non-pixel buffer sample buffers most by MJPEG turns out not to hold, with the following consequences: In M89, this causes a CHECK-crash. In M88, this causes a DCHECK-crash, which in official builds means we don't crash but rather we most likely fail to decode the buffer and return null frames. This is believed to cause "no video" issues. This CL adds the workaround not to use the SampleBufferTransformer if "sampleBufferLacksPixelBufferAndIsNotMjpeg" is true. So in this edge case we fall back on the same code path that we run in M87 today. TBR=handellm@google.com Bug: chromium:1160647, chromium:1160315 Change-Id: I782a36cf38f5ce96a5010966c8b07aedf1b08efd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599531Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#838638}
-
Finnur Thorarinsson authored
This reverts commit 9d0120f3. Reason for revert: Very close to 100% failure rate since check-in, on bot "WebKit Linux Leak": https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Linux%20Leak/21884 Error message: Retrying 19 unexpected failures, attempt 1 of 3... Sharding tests ... Starting 8 workers ... [18/19] external/wpt/css/selectors/focus-visible-006.html failed unexpectedly (leak detected: ({"numberOfLiveContextLifecycleStateObservers":[2,4],"numberOfLiveDocuments":[1,2],"numberOfLiveNodes":[4,40],"numberOfLiveResourceFetchers":[1,2],"numberOfLiveResources":[0,5]})) stopping content_shell(pid 14917) timed out, killing it [19/19] external/wpt/referrer-policy/gen/worker-classic.http-rp/strict-origin-when-cross-origin/worker-classic.http.html failed unexpectedly (test timed out) Original change's description: > Simulate user inputs in focus-visible tests in css/selectors/ > > Use testdriver Action API to simulate mouse actions in > css/selectors/focus-visible-006.html and > css/selectors/focus-visible-008.html. > > Bug: 1145677 > Change-Id: Id25c6120f1dbd489d4c803ee979e67ad5ef49f8c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551818 > Reviewed-by: Mustaq Ahmed <mustaq@chromium.org> > Commit-Queue: Lan Wei <lanwei@chromium.org> > Cr-Commit-Position: refs/heads/master@{#838271} TBR=lanwei@chromium.org,mustaq@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1145677 Change-Id: Ie2e39aa960a80dd0ab5b9ec881ae9305c4294760 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599530Reviewed-by:
-
Viktor Semeniuk authored
This change adds function to add compromised credentials. Later it will be used sync compromised credentials. Bug: 1137775 Change-Id: I44732583482ad5bf9e2a2bb1f85c907914c86352 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580529 Commit-Queue: Viktor Semeniuk <vsemeniuk@google.com> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#838636}
-
Jérôme Lebel authored
This reverts commit f061483a. Reason for revert: go/async-identityservice-api-issue Original change's description: > [iOS]Adding WaitUntilCacheIsPopulated calls to populate the identity cache > > Adding WaitUntilCacheIsPopulated() before calls: > * ChromeIdentityService::GetIdentityWithGaiaID() > * ChromeIdentityService::HasIdentities() > * ChromeIdentityService::GetAllIdentities() > * ChromeIdentityService::GetAllIdentitiesSortedForDisplay() > * AuthenticationService::GetAuthenticatedIdentity() > * AuthenticationService::IsAuthenticated() > > This patch also adds the following method as an helper: > AuthenticationService::WaitUntilCacheIsPopulated() > > This method should be temporary, and should be replace by > ChromeIdentityService::RunAfterCacheIsPopulated() (or a > AuthenticationService version). > > Design doc: > http://go/async-identityservice-api > > crrev.com/c/2489915 Adding methods in ChromeIdentityService > crrev.com/i/3353161 Implementing in ChromeIdentityServiceImpl > crrev.com/c/2490110 Adding metrics > crrev.com/i/3353162 Implementing the metrics > => crrev.com/c/2490010 Adding WaitUntilCacheIsPopulated calls > crrev.com/i/3354983 Adding DCHECK for cache state > > Bug: 897470 > Change-Id: Iced6e7e50d704091abfe7d5b705157fe71c50ac0 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490010 > Commit-Queue: Jérôme Lebel <jlebel@chromium.org> > Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> > Cr-Commit-Position: refs/heads/master@{#825492} TBR=sdefresne@chromium.org,jlebel@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 897470 Change-Id: I0f0d87fcca171c3d5f730f86805b89d22268deec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593615Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#838635}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/22dd28af0ab7..d034512dc4d9 2020-12-21 jacktfranklin@chromium.org Component docs can load test helpers If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Idb290a0c4efe64328ed9f276dde1d0c787f56d85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599047Reviewed-by:
-
Pavol Marko authored
Move raw RSAPKCS1 signing code to its own function instead of an if-else in SignRSAOnWorkerThread. This should improve readability and unclutter the functions as special error handling for too long inputs will be added in a follow-up CL. Bug: 1158363 Change-Id: Id525119753f2d179e25846683778b42ee84253b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595422Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#838633}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/ed9213bca064..4ebcee3eb02f 2020-12-21 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from af73f1e9 to 4545fb53 (180 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: cwallez@google.com Change-Id: I97950460c51ec538dce4194d8ad3477c4a264fd9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599696Reviewed-by:
-
Fredrik Söderqvist authored
This moves the resolution of an image's "computed orientation" to LayoutImageResource where have sufficient context information to determine it. This avoids having user of LayoutImageResource have to dig out and know things about the internal implementation and contents of said class. Change-Id: I1dbe62218d980be23344ad50f79435be41471ff5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596346Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#838631}
-
Henrique Ferreiro authored
This is a follow-up to https://crrev.com/c/2523334 where the last user of the WebCursor traits was ported to ui::Cursor. Bug: 1028080 Change-Id: Ie6ada4e408392177260de6dcd83dc43b467a62ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353252Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Cr-Commit-Position: refs/heads/master@{#838630}
-
Eugene Zemtsov authored
This flag doesn't appear to be affecting anything, it certainly doesn't stop OpenH264 from being used in media or RTC. All it does is control whether OpenH264 is included into artificial testonly target "gn_all". Its value is false by default, and nobody seems to set it to true. Bug: 1158845 Change-Id: I27bdf215743d81aa65b643e1d3340345e7e56910 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599111Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Sergey Silkin <ssilkin@google.com> Commit-Queue: Eugene Zemtsov <eugene@chromium.org> Cr-Commit-Position: refs/heads/master@{#838629}
-
Alice Wang authored
This CL makes the subtitle texts of web sign-in bottom sheet focusable in talkback mode. Video demo: crbug.com/1159940#c1 Bug: 1159940 Change-Id: I571faecd0f26500a2c9a39336767bf8071926118 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595739Reviewed-by:
Peter Conn <peconn@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#838628}
-
David Jean authored
Bug: 1140990 Change-Id: I1ed3c06836d5dcedb40f8f9dde6c60f6ecffc671 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594908 Commit-Queue: David Jean <djean@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#838627}
-
Yao Xiao authored
What: Introduce the kFlocIdFinchConfigVersion feature param. On browser start, invalidate floc and trigger an immediate recompute if the version mismatches with the one when computing the last floc. Why: This allows us to configure an immediate recompute when we feel it's necessary. How: - Add the finch_config_version to FlocId, that allows it to be saved to prefs at each computation along with other fields. On browser start, check for version mismatch and handle it accordingly. - In the InterestCohort string, this version replaces the position of the previous constant kChromeFlocIdVersion. We expect most params to go through finch in the near future so replacing the "chrome floc version" part for now. - Also move the compute_time to FlocId, as it's also logically fit there, and we can keep the load/save function to one place. - Move the floc features to //components as now the it's being checked by the components. Bug: 1159235 Change-Id: I0c80ed35ac5f181b18b860eb2f1a73acf6fd1432 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595595Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: I245564a97657cd3fa8fb1712d5d9c44061a89b39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599482Reviewed-by:
-
Hiroki Nakagawa authored
CrossOriginAttributeValue corresponds to the CORS settings attributes defined in the HTML spec: https://html.spec.whatwg.org/C/#cors-settings-attributes This CL adds a reference in the header file. Bug: n/a Change-Id: I2dc044d7a2adbc4b44f3b709235037614e3b8991 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597129Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#838624}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/68649aff0ca8..22dd28af0ab7 2020-12-21 patrick.brosset@microsoft.com Flex: Draw a border around alignment arrows in the flex overlay 2020-12-21 wolfi@chromium.org Remove "blackbox" - refactor blackbox-a11y-test.js 2020-12-21 wolfi@chromium.org Remove "blackbox" - refactor TimelineFlameChartDataProvider.js If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1152082,chromium:1157856 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ia965818a489ff5c411503c28693d3a70e4333b4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599661Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/07d993711f33..5ddf384d1fb4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC finnur@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: finnur@google.com Change-Id: I33eed774b957f82eeddb7e5c02222980fd6a53a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599015Reviewed-by:
-
Aya ElAttar authored
Updated the strings of the clipboard notifications shown on block according to the latest update from UI review. Bug: 1158743 Change-Id: I21389225ed1fd83e9edfc753afc1a071a101d3e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595303 Commit-Queue: Aya Elsayed <ayaelattar@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#838621}
-
Jason Lin authored
Bug: b/167491603 Change-Id: I8682f941ba8a3cd282991f62c73dffedf91e3030 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2598094 Commit-Queue: Jason Lin <lxj@google.com> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Auto-Submit: Jason Lin <lxj@google.com> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#838620}
-
Hiroshige Hayashizaki authored
Bug: 1022182 Change-Id: I98d3897fdc99d42a0b6bb09461bfb228068ddd02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586206 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Auto-Submit: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#838619}
-
Ghazale Hosseinabadi authored
When starting a service worker fails, we need better error reporting to //extensions. In case of script evaluation error, which is a user error, this CL enables //extensions to propagate such an error to the ErrorConsole to give developers a hint about the issue. Bug: 1151017 Change-Id: Iccf8ecd2562d8d443968f06ecef00080b41d2ded Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576587 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: I25d824ccaa12c96fc59e2e4b3ac5e7732f6354b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596077Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#838617}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/c42f56dc3662..68649aff0ca8 2020-12-21 jegarc@microsoft.com This CL fixes the color for the css property names in high contrast If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1159577 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ib6959244dd43a8f92869ad2cc98394393e4a68fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599484Reviewed-by:
-
Shakti Sahu authored
Bug: 1159557 Change-Id: I0c2e5d759b17620dcb1333002e80943da253e8c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595889 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#838615}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/f4ad8c537982..88883c4ca259 2020-12-21 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 64c5d601f89b to 5d4fd88a7403 (1 revision) 2020-12-21 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from de703db564d6 to ed9213bca064 (7 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bungeman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: bungeman@google.com Change-Id: I40944984057b06c94fea0a420f8c02ad243972ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599481Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1608508387-4c99c0c6e0807bf68be573ad8b3c8353e1fc0e76.profdata to chrome-mac-master-1608529993-82d6d40e289e60063d3bd5c2eebe97dc9bb53838.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I7b9e879c5feed8fd4e01a04784017927555354c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599483Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/bec27c2c2a8e..07d993711f33 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC talp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: talp@google.com Change-Id: I2111fe4dc30a594e7d9e78fcfdb2cb7f215b79ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2598024Reviewed-by:
-
Tal Pressman authored
Bug: 1160616 Change-Id: I054dd1c1d8e0bf77f99b979ad12929f6f0d9af9c Tbr: hta@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596478Reviewed-by:
Tal Pressman <talp@google.com> Commit-Queue: Tal Pressman <talp@google.com> Cr-Commit-Position: refs/heads/master@{#838611}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/2622d88609d1..c42f56dc3662 2020-12-21 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I984bb74a9aa22ac185ec70925472e86a4620d0a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599479Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1608432581-ff55f7d7458123a29eec3ce7592821edeb11f86c.profdata to chrome-win32-master-1608508387-56780dae3832c65bafd36e4cfe96756ad3b86eef.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ibf13938de9afb2331feeba0a613cbe511229ac2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596555 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/73bf5d7d..b96d7e2a Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I3e8a2d8046df9afbfa49fd7fd433e862efa79336 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599010Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#838608}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1608480487-d09244758c3f22256fe9146780e06c2aad82d633.profdata to chrome-win64-master-1608508387-093abbef3f1d2d94b454a0cdd869bb44780245e6.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I7bbe09c58473c5f1e77bbe26eb3ac4047cef1b49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596646Reviewed-by:
-
Yunke Zhou authored
Issue is due to there's a small time difference between StatsReportingController::SetWithService and pref is properly set. We should only propagate the value from service until it is correctly set. Bug: 1154947 Change-Id: I977249dd25e1402246b383401c9deef4ea8ebc56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587065Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Yunke Zhou <yunkez@google.com> Cr-Commit-Position: refs/heads/master@{#838606}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/2d44549a1f3a..f4ad8c537982 2020-12-21 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from a51698b2 to fc46ab79 (188 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bungeman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: bungeman@google.com Change-Id: Iee72021fb7ad340758d86e1cddfb61e300ed0795 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599459Reviewed-by:
-
