- 14 Feb, 2020 40 commits
-
-
Eric Willigers authored
We enable the flag DesktopPWAsUnifiedUiController Web apps (PWAs and shortcuts) now use WebAppBrowserController instead of HostedAppBrowserController. Bug: 966290 Change-Id: I2cdf4bc8161e263838d22fc84ba793174eef0db4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056163Reviewed-by:
Alan Cutter <alancutter@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#741324}
-
Clark DuVall authored
This also introduces PermissionsClient, which allows code in //components/permissions to call embedder specific logic. Bug: 1025609 Change-Id: I76d9356917b5cb0efb2813548a8a977aa060a5ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032434Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#741323}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/ef599fb0f431..4f9608ca6afd git log ef599fb0f431..4f9608ca6afd --date=short --first-parent --format='%ad %ae %s' 2020-02-13 cnorthrop@google.com Vulkan: Update more bug numbers for ES 3.1 Created with: gclient setdep -r src/third_party/angle@4f9608ca6afd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: courtneygo@google.com Change-Id: Icd2d10c4c20a04a83ae68bb8ec9a8cf2da242547 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055769Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#741322}
-
Tim Song authored
This metric is logged whenever a notification popup times out and exipres to the tray. This CL also implements a new observer function for this event. BUG=1050809 Change-Id: Id45954d668637222a59062f8c022ba343fb8d1b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040919Reviewed-by:
Ahmed Mehfooz <amehfooz@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Tim Song <tengs@chromium.org> Cr-Commit-Position: refs/heads/master@{#741321}
-
Maggie Chen authored
Three histograms are added. GPU.WatchdogThread.WaitTime.ProgressAfterWait GPU.WatchdogThread.WaitTime.NumOfUsers GPU.WatchdogThread.ExtraThreadTime.NumOfUsers The purpose is to calculate the numbers of users who quit during the extra wait time. The number of users who quit is equal to the number of users who stay in Chrome plus the number of users who see the GPU makes a progress. Bug: 1051178 Change-Id: I1869489fa2bb4ff19c4cc15c1ecefdda11b9a5c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050040 Commit-Queue: Maggie Chen <magchen@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#741320}
-
Manu Cornet authored
Change-Id: Idf49601dd121fa93486672425ad563d0302fac45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056203Reviewed-by:
Matthew Mourgos <mmourgos@chromium.org> Commit-Queue: Manu Cornet <manucornet@chromium.org> Cr-Commit-Position: refs/heads/master@{#741319}
-
Jason Lin authored
This is based on review from the UX designer. Bug: 1016195 Change-Id: Ic48a9595b65a7b66fa21ae0f4e3d575906a275cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053943 Auto-Submit: Jason Lin <lxj@google.com> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#741318}
-
Yoichi Osato authored
Since LazyLoadFrameObserver and its caller only use request head info, we can apply ResourceRequestHead instead of ResourceRequest. Bug: 787704 Change-Id: I04b18290af315dcf1fcf5e986d875d2b032e729d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050409Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#741317}
-
Elly Fong-Jones authored
This change updates: * AcceleratorConfirmationDialog, to pass the provided callbacks directly to DialogDelegate * RemoveQueryConfirmationDialog, to use inline callback lambdas instead of overrides * MultiprofilesIntroDialog, to use inline callback lambdas * SessionAbortedDialog, to use an inline callback lambda * TeleportWarningDialog, to use inline callback lambdas * AccessibilityFeatureDisableDialog, to pass the provided callbacks directly to DialogDelegate * ScreenSwitchCheckController, to use private callback methods * LogoutConfirmationDialog, to use a private callback method * ShutdownConfirmationDialog, to pass the provided callbacks directly to DialogDelegate Bug: 1011446 Change-Id: Ib2608d8f9095335d1a00fea3b498cd7c29c23d3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2047413 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#741316}
-
Junbo Ke authored
Bug: b/148481368 Test: CQ Change-Id: I09ec5ef5f54d429a120fb32bba19820c688c4717 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026189Reviewed-by:
Sean Topping <seantopping@chromium.org> Commit-Queue: Junbo Ke <juke@chromium.org> Cr-Commit-Position: refs/heads/master@{#741315}
-
Kinuko Yasuda authored
- blink::mojom::ResourceType is deprecated, see crbug.com/960143 - Use network::mojom::RequestDestination instead when possible - For "resource_type == kMainFrame" checks I replaced this with "request_type == kDocument" (this should mean a main-frame main resource in most cases except for Portals cases) Request destination: https://fetch.spec.whatwg.org/#concept-request-destination A PR to introduce "frame", "iframe" etc: https://github.com/whatwg/fetch/pull/948 TBR=csharrison@chromium.org, tbansal@chromium.org Bug: 960143 Change-Id: I4a660833b3602b7d6f98a77d8a18206da0870aed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2043265 Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#741314}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/6a950951c780..08046edecf21 Created with: gclient setdep -r src-internal@08046edecf21 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: If120d61c571e3a9267a3eb744b3b259f5b48a17a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055771Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#741313}
-
Johannes Henkel authored
As is, this._dp.DOM.getDocument(3) results in a message with params set to 3 on the wire. Which the parser in the generated code then silently drops because DictionaryValue::cast makes it into a nullptr. // Prepare input parameters. protocol::DictionaryValue* object = DictionaryValue::cast(requestMessageObject->get("params")); A params set to nullptr means it's ignored. I plan on making this stricter, so I'd like to fix this test here beforehand. The intention was probably to set the depth param to 3, so let's do that. Change-Id: Iecc931174815110f91f513383920fa81cac273e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056109Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Johannes Henkel <johannes@chromium.org> Cr-Commit-Position: refs/heads/master@{#741312}
-
Tarun Bansal authored
This is no longer needed with NoStatePrefetch. Also, verified using UMA dashboard. Bug: 1038053 Change-Id: Id709b4cb406d28d52d4f6a9231d3f5bdb6281e94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2044998 Commit-Queue: Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#741311}
-
Andrew Moylan authored
Bug: 2048044 Change-Id: I1080fcf0f7309e40dd3b7ca096d8619e9d8b7120 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050406 Auto-Submit: Andrew Moylan <amoylan@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Reviewed-by:
Tony Yeoman <tby@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#741310}
-
Sam Bowen authored
This reverts commit 38b34519. Reason for revert: Clank is still having issues finding the dependency for the new mojo file. Original change's description: > Move entity and property mojo types to //components. > > We will use these types from both blink and //content and from code > inside //components. > > This patch affects Clank downstream and will be submitted together with > a patch in that repo to avoid breakage. Clank CL: > https://crrev.com/i/2545991 > > See discussion in design doc: > https://docs.google.com/document/d/1ZA-1EMq4d40K5qfsZoeMIhJmZA6-AXaSibD3SsqZjfU/edit# > > Bug: 1044252 > Change-Id: Id658caa422bedbcb6d2275a8ccdd76f73bf955c8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051363 > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Becca Hughes <beccahughes@chromium.org> > Commit-Queue: Sam Bowen <sgbowen@google.com> > Cr-Commit-Position: refs/heads/master@{#741227} TBR=kinuko@chromium.org,haraken@chromium.org,beccahughes@chromium.org,sgbowen@google.com Change-Id: I3a12da68b76133e49fd831f603dc35501a2eeb7d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1044252 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055997 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#741309}
-
Yue Li authored
The handling might bring the Assistant up unexpectedly in bowser tests, and cause DCHECK failures. Bug: b/149509996 Test: Run existing tests Change-Id: Ibe8c8598b1952bbf2dfb4b7e70bc7b754f4e566f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055354 Commit-Queue: Yue Li <updowndota@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#741308}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/475def0059a2..f9734c39b884 git log 475def0059a2..f9734c39b884 --date=short --first-parent --format='%ad %ae %s' 2020-02-13 jtphillips@google.com Adding fmls instruction Created with: gclient setdep -r src/third_party/skia@f9734c39b884 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC stani@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: stani@google.com Change-Id: Ic10fa854266ee0e080815e733f820f75070a384b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056123Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#741307}
-
Peter Boström authored
This fixes a bug when ShrinkDownThenClearText() is used by ToolbarButton as the label-side insets need to be cleared when the text goes away. There may be other root causes for layout issues in the linked bug, but this fixes at least one layout problem. I haven't been able to reproduce the second reliably. Possibly because my window manager is weird. Bug: chromium:1045013 Change-Id: Ia0191754673d3bd545af61145f7cc4ac0d6f3a0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055432 Commit-Queue: Peter Boström <pbos@chromium.org> Commit-Queue: Taylor Bergquist <tbergquist@chromium.org> Auto-Submit: Peter Boström <pbos@chromium.org> Reviewed-by:
Taylor Bergquist <tbergquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#741306}
-
Darwin Huang authored
Mechanical find/replace from "Trace(blink::Visitor*" to "Trace(Visitor*". Refactoring change only. No functional changes intended. Bug: 1051193 Change-Id: If666c97e208838a2b53483cbe3f7319ce66a9f3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055687Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#741305}
-
Wanming Lin authored
NDEFRecordInit#data for smart-poster record contains more than one uri record should throw TypeError. BUG=520391 Change-Id: I5d876f7cdf0f6a847412b34ce06b50a922138874 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053985 Commit-Queue: Wanming Lin <wanming.lin@intel.com> Reviewed-by:
Leon Han <leon.han@intel.com> Cr-Commit-Position: refs/heads/master@{#741304}
-
Nicholas Verne authored
The upgrade flow progress bar is now indeterminate (we don't have a good way of measuring progress.) The act of canceling the RESTORE phase leads to the ERROR state now (because RESTORE is only offered after an upgrade error). Bug: 1024693 Change-Id: I92bcecc44c075499ea17a9daa8cc45f8d3673aec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050291Reviewed-by:
David Munro <davidmunro@google.com> Commit-Queue: Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#741303}
-
Alex Newcomer authored
Move ownership of the metrics reporter up, so it outlives the HotseatWidget. TBR=mpearson@chromium.org,manucornet@chromium.org Bug: 1049385 Change-Id: Ic06978898ce022cac54de2b94e42e825e3e5c4dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055738 Commit-Queue: Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Manu Cornet <manucornet@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#741302}
-
Dominic Mazzoni authored
Previous work added support for exporting a tagged PDF, but only enabled it to work from the command-line using headless. This change enables the --export-tagged-pdf command-line switch to work when using Chrome's Print dialog on desktop platforms. The important changes are: * In PrintRenderFrameHelper, AXTreeSnapshotter needs to be alive throughout the duration of printing, in order to ensure that the document is printed with the extra node ID annotations and to ensure that the IDs match the ones from the accessibility tree snapshot. * The accessibility tree snapshot needs to be sent to PdfCompositorImpl. Because finishing the PDF document happens immediately upon receiving the final page, we can't wait until after finishing before sending it - so I added this code to send the tree before the first page. I excluded some of the code from compilation on Android to ensure the binary size doesn't grow. There are no plans to enable this feature on Android currently. Bug: 607777 Change-Id: Ie0b16a224cc02a719b07b257b01a8d7b67889746 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1996158 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#741301}
-
Eric Willigers authored
WebAppBrowserController::GetTitle() uses the web app's short name when the custom tab bar is being shown. .../extensions/hosted_app_browsertest.cc no longer contains any web app browser tests - they have all been moved to .../web_applications/... Bug: 966290 Change-Id: I699b28db635647541823e798dc90ff2ff7bcf9c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050286 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#741300}
-
James Cook authored
PrivetNotificationService uses IdentityManager::HasPrimaryAccount to detect if a Profile is for a signed-in user. However, that method returns false if the user has not consented to browser sync. Historically all Chrome OS users were consented to browser sync, but the SplitSettingsSync project is making it possible for users to opt-out. Change the call site to the new API, indicating that browser sync consent is not required. The updated call returns true for any signed-in user. See go/cros-primary-account and go/consent-aware-api-dd Also fix the startup delay timing, which was trying to generate a TimeDelta between 0 and 1.25 seconds, but always chose exactly 0 or exactly 1. Bug: 349098, 1042400, 1046746 Test: added to unit_tests Change-Id: Ic7484428cd718937173d5097e57672d74c8db614 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055963Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#741299}
-
Asanka Herath authored
`scripts/utilities.py`'s `write_file()` did not handle the case where the file being written is in the current directory. Bug: None Change-Id: I3bb294aa1c45ed3caed9153e2cbb6e73d151391c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055424 Auto-Submit: Asanka Herath <asanka@chromium.org> Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#741298}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/ca1907e58b82..86fbe04c6633 git log ca1907e58b82..86fbe04c6633 --date=short --first-parent --format='%ad %ae %s' 2020-02-13 yiwzhang@google.com Roll bb tool to @ 1ab4441 Created with: gclient setdep -r src/third_party/depot_tools@86fbe04c6633 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1039823 Tbr: agable@chromium.org Change-Id: I0f06158afd50f4df51df145a4cc749de767b9573 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055770Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#741297}
-
Kurt Horimoto authored
The previous implementation of InfobarOverlayRequestInserter and InfobarOverlayRequestFactoryImpl crashed if an unsupported infobar overlay was requested. This ultimately should be the case, as it helps future users of these classes to remember to add the request factory. However, when there are infobars that haven't been converted yet, this requirement makes debugging difficult becuase the app crashes when the session restoration infobar is added. This CL replaces this crash behavior with early returns to make debugging easier before the remaining infobars are converted. Bug: 1030357 Change-Id: I68ef5b758444e65b0985d970c92de0bf935785cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041032 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#741296}
-
Manu Cornet authored
Bug: 1044306, 1052077 Change-Id: I0471dfbfa622162015432617e5449853bb0c65f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055586 Commit-Queue: Manu Cornet <manucornet@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#741295}
-
Kurt Horimoto authored
When an InfoBar is removed from its InfoBarManager while an OverlayRequest is in a queue, that request is cancelled, which triggers an animated dismissal of the UI. However, by the time the UI is finished being dismissed, the InfoBar object has already been destroyed. This CL updates InfobarOverlayRequestConfig to hold a weak pointer to the InfoBar to prevent the destroyed infobar from being used after destruction. It also updates all callbacks to early return if the request's InfoBar has already been destroyed. Bug: 1030357 Change-Id: I66adbed780f6472c562eb2164193b8836da66670 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040953 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#741294}
-
Istiaque Ahmed authored
VerifierObserver previously exposed completed_fetches(), which is only used to ensure we wait for OnFetchComplete of a particular extension. This CL unifies those methods into EnsureFetchCompleted, which would wait for OnFetchComplete if we haven't seen it for an extension. Bug: 796395 Change-Id: Iffd23fa52df7a656ff453ac92829137283afe35a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2044413 Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Oleg Davydov <burunduk@chromium.org> Cr-Commit-Position: refs/heads/master@{#741293}
-
Max Moroz authored
- Move the FDP section upper in the page, as the class became even more helpful and widely used, plus we had feedback about its documentation in Chromium. - Remove the section about manually splitting the fuzz input into pieces, as FDP is a better and less error-prone way to do it. - Clarify upsides and downsides of FDP and hash-based argument solutions. Bug: 539572 Change-Id: I8a0d46008d36bf6a8f8df8007664411b3f32d4b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051298Reviewed-by:
Abhishek Arya <inferno@chromium.org> Commit-Queue: Abhishek Arya <inferno@chromium.org> Cr-Commit-Position: refs/heads/master@{#741292}
-
Daniel Hosseinian authored
Bug: 477699 Change-Id: I7377c6693f49232206b061c5cc1d9c9e80717a55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055845 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#741291}
-
Alex Danilo authored
Bug: 992823 Change-Id: I7a220f111fbd0ee624efc6fd450f9f1cb5eff15b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053646 Commit-Queue: Alex Danilo <adanilo@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#741290}
-
Carlos IL authored
Setting this to default on in preparation for launch, also change default behavior to exclude images since that is the mode launching in 80. Bug: 1025274 Change-Id: I6689b4fa90a345e4e6ecc193790757a11e54c6aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2052250 Auto-Submit: Carlos IL <carlosil@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#741289}
-
David Munro authored
Test: Load page, check for no errors in console Bug: None Change-Id: I5a83a112f742d5b86af941aa661df8dc5fcd0bc8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2054626 Commit-Queue: David Munro <davidmunro@google.com> Commit-Queue: Julian Watson <juwa@google.com> Auto-Submit: David Munro <davidmunro@google.com> Reviewed-by:
Julian Watson <juwa@google.com> Cr-Commit-Position: refs/heads/master@{#741288}
-
Richard Townsend authored
MSVC's support for Arm intrinsics is incomplete. To restore the build and make sure MSVC-compiled downstream projects can compile V8 for Windows on Arm, temporarily disable these optimizations until we can fix them or MSVC improves. Bug: v8:10012 Change-Id: Iaa599aa20ace167e0fcc2a2472e97e7f2ac53773 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2054884 Commit-Queue: Adenilson Cavalcanti <cavalcantii@chromium.org> Reviewed-by:
Adenilson Cavalcanti <cavalcantii@chromium.org> Reviewed-by:
Chris Blume <cblume@chromium.org> Cr-Commit-Position: refs/heads/master@{#741287}
-
Chromium WPT Sync authored
Using wpt-import in Chromium e71d7d88. With Chromium commits locally applied on WPT: acd8a467 "SharedWorker: Use CSP headers to outside settings" ec83d167 "Update performance.measureMemory to the latest proposal" ce4a5462 "[css-scroll-anchoring] Add WPT for zero scroll offset suppression." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: binji@chromium.org: external/wpt/wasm drott@chromium.org: external/wpt/css/css-text-decor foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools hbos@chromium.org, hta@chromium.org: external/wpt/webrtc hongchan@chromium.org, rtoy@chromium.org: external/wpt/webaudio jsbell@chromium.org: external/wpt/IndexedDB external/wpt/resources ksakamoto@chromium.org, npm@chromium.org: external/wpt/resource-timing mkwst@chromium.org: external/wpt/secure-contexts external/wpt/trusted-types mkwst@chromium.org, andypaicu@chromium.org: external/wpt/content-security-policy panicker@chromium.org: external/wpt/user-timing yhirano@chromium.org, mkwst@chromium.org, japhet@chromium.org: external/wpt/fetch NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: Ida26cb93d2ffd34309caf08890c823feed90147b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055704Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#741286}
-
Dominic Mazzoni authored
I made these categories of histograms expire never, for now (understanding that this may be done automatically at some point): * Core histograms that track usage of an important accessibility feature * Histograms that track a system setting that's important for accessibility In both of those cases, we look at long-term trends of those histograms to see how usage is growing and to determine how many users might be affected by potential changes. We shouldn't let those expire. I left alone any accessibility histograms that are tied to a smaller option or experiment. Many of those should expire after a while. Bug: 1045994, 1045992, 1041514, 1036908, 1036905, 1036904, 1036902, 1006995 Change-Id: I2104ebf2df81f0ac4d090f87ea2dfca06ad4c92d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036484Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Katie Dektar <katie@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#741285}
-