- 04 Feb, 2020 40 commits
-
-
Rachel Sugrono authored
The <dialog> element added in CL:2033012 is too dark. We should restyle it to lighten it up. Use transparent to allow the cr.ui.dialog background-color: rgba(...) to control the apparent lightness. No change in behavior, no new tests. Bug: 803259 Change-Id: I9a7a4b89419a2cc55d2aa249d17464d8bd523347 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035822 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#738088}
-
Matt Falkenhagen authored
It's meant for linux_builder not fyi_builder. Bug: 1040384 Change-Id: I9aadde22614b6e2e941e4dd3783451dd3e9a512d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037170Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#738087}
-
Hiroki Nakagawa authored
Bug: n/a Change-Id: I801524511be42b3e47c04ca93d7914c7df94968c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2034384Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#738086}
-
Tsuyoshi Horo authored
This reverts commit bbd20716. Reason for revert: Tests failing on Mac Retina bots. Bug: 1048497 Original change's description: > macOS HDR: Don't disable GMBs when display is HDR > > We always want HDR videos to use GMBs on macOS. > > Bug: 976426 > Change-Id: I9cf36ef2d031ec99320dde8ce4599664df0fa6f4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2034903 > Reviewed-by: Miguel Casas <mcasas@chromium.org> > Commit-Queue: ccameron <ccameron@chromium.org> > Cr-Commit-Position: refs/heads/master@{#737866} TBR=ccameron@chromium.org,mcasas@chromium.org,dcastagna@chromium.org Change-Id: I8cdb03e8c0029923ce2afbe89f2596e2e03a0a77 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 976426 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035649Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#738085}
-
David Staessens authored
This CL moves the video test helper code from media/gpu/test/video_player to media/gpu/test. This will allow us to reuse the code in the video encoder and other tests. A similar change has already been done for the image test helper code. TEST=./video_decode_accelerator_tests on hana BUG=1045825 Change-Id: I5184042b14154e4d290563346e5d45d690286c83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026848Reviewed-by:
Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Commit-Queue: David Staessens <dstaessens@chromium.org> Cr-Commit-Position: refs/heads/master@{#738084}
-
Xiaocheng Hu authored
The clipboard CSS sanitizer has a side effect that, it may add additional inline styles to elements to match their computed style in the dummy document. This isn't necessary when the markup doesn't have any style sheet to sanitize, in which case the side effects are undesirable and causes some regressions. Hence, this patch skips the sanitization when there are no style sheets. Bug: 1047806 Change-Id: I62e20fb5fe29d56bda9d86ca12499b7ffb1497e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036731Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#738083}
-
Delan Azabani authored
This CL should have been included in <https://crrev.com/c/2015875>, but I made a mistake in my regex that ended up excluding them. I used the following replacement under Sublime Text 2 (PCRE): Find: (?x-i) (?<escape>\\['"?\\abfnrtv]){0} (?<literal>"(?:(?=[ -~])[^"skSK]|(?&escape))*"){0} (?<any>(?:[^(),]|(\((?:[^()]*|(?-1))\)))*+){0} DeprecatedEqualIgnoringCase (\s*\(\s*+(?: (?&literal)\s*,\s*+(?&any) |(?&any)\s*,\s*+(?&literal) )\s*\)) Where: *.cc,-/path/to/src/out/*,-/path/to/src/.clangd/* Replace: EqualIgnoringASCIICase$5 Bug: 627682 Change-Id: Icf517d69122789a493ee19a051d18ffd61244d3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032654Reviewed-by:
Frédéric Wang <fwang@igalia.com> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Delan Azabani <dazabani@igalia.com> Cr-Commit-Position: refs/heads/master@{#738082}
-
Sadrul Habib Chowdhury authored
Doc: https://docs.google.com/document/d/1S42G9v8TKiXirvERZ-eFBZFNCJQ6d34MymXPJESV6fc/edit?ts=5e14ff92 BUG=none Change-Id: I524f2d5878f630402cdb90ea412979bf4bcdbd21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992505 Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#738081}
-
Timothy Loh authored
This reverts commit 88d22715. Reason for revert: ebuild was updated in 12853.0.0, workaround is no longer needed. Original change's description: > Temporarily allow kErrorInvalidDlc in Plugin VM installer > > Until the ebuild is actually updated to support DLC, the Plugin VM > installer shouldn't be failing due to DLC errors. This CL partially > reverts the behaviour of crrev.com/c/2001942 so we don't fail. > > We can revert this CL once the ebuild is updated. > > Bug: b:145814572 > Change-Id: I2a9aadef45f5e72d1e7841f0ec3438d4d19f352c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015871 > Reviewed-by: Julian Watson <juwa@google.com> > Commit-Queue: Timothy Loh <timloh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#734350} Bug: b:145814572 Change-Id: I67bcede53d48c9c61dd741e31709ed727eef5296 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035644Reviewed-by:
Julian Watson <juwa@google.com> Auto-Submit: Timothy Loh <timloh@chromium.org> Commit-Queue: Julian Watson <juwa@google.com> Cr-Commit-Position: refs/heads/master@{#738080}
-
Chris Cunningham authored
Previously enabled to collect experiment data. We don't mean to ship this all the way to stable just yet. Bug: 1048431 Change-Id: I03d05a1588d2064d6f10fba9cf6eb2b1b7d6fc57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037071 Auto-Submit: Chrome Cunningham <chcunningham@chromium.org> Commit-Queue: Frank Liberato <liberato@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#738079}
-
Koji Ishii authored
Following bot results are included. 1225 1226 1228 1229 1230 1231 1236 1238 1239 1240 1241 1242 1243 1244 1245 1246 1247 1248 1249 1250 1251 1252 1253 1255 1257 1258 1259 1260 1261 1262 14 lines were removed and 16 lines were deflaked by consecutive results since 1245. TBR=yosin@chromium.org NOTRY=true Bug: 982194 Change-Id: Id07e26bc406a6ee364131a454bab457095eac1e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032696Reviewed-by:
-
Yutaka Hirano authored
It is already essentially ref-counted, given we create a base::RefCountedData<std::unique_ptr<ExtraData>> in blink::ResourceRequest. Now we can have a ref counted class in blink/public/platform, so making it a ref counted class simplifies the situation. Bug: 860403, 688906 Change-Id: I31f38b603203e124d0d2ccd36e17939c1d14d54d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032684Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
-
Chris Hall authored
R=aboxhall Change-Id: Ia20e192b889fb3900be5e128fccf61b980ff2d81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2009596 Commit-Queue: Alice Boxhall <aboxhall@chromium.org> Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Cr-Commit-Position: refs/heads/master@{#738076}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/5bbc191e0e57..dbebc4acd3b6 git log 5bbc191e0e57..dbebc4acd3b6 --date=short --first-parent --format='%ad %ae %s' 2020-02-04 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. Created with: gclient setdep -r src/third_party/devtools-frontend/src@dbebc4acd3b6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I173be8e0ae1efdc8dad5247cf0054565b319732a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037091Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#738075}
-
Christopher Lam authored
This CL fixes and issue where it was assumed that all Chrome App Windows have the chrome.app.window API. Some broken corner cases don't have this API and it caused chrome.app.window.getAll() calls to fail. This CL filters out broken windows before returning to the caller. Bug: 1021014 Change-Id: Ia3f09b1393c62bd3e2dfc88de36c8f4cc9417910 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029397Reviewed-by:
Ben Wells <benwells@chromium.org> Commit-Queue: calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#738074}
-
Yuki Shiino authored
Produces only necessary trampolines. Bug: 839389 Change-Id: I7a665d42f5939929c5de965a4fb9394b883e7413 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035632 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#738073}
-
Christopher Cameron authored
Add ContentColorUsage to the SurfaceAggregator's PrewalkResult, and populate it during the pre-walk step. Add implementations of the GetContentColorUsage method to TextureLayerImpl, VideoLayerImpl. Set the corresponding CompositorFrameMetadata for VideoResourceUpdater as well. Bug: 955158, 976426 Change-Id: Iae00a5c413e3bb893cdc84319d8426b30b357667 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036634Reviewed-by:
Miguel Casas <mcasas@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#738072}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/42ede502db2f..a1ebb9c9e059 Created with: gclient setdep -r src-internal@a1ebb9c9e059 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: Idf3b8ac6449201b119e7c3465840aeec7bcff57f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037095Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#738071}
-
Eriko Kurimoto authored
This CL changes the constructor of blink::WebFetchClientSettingsObject to set blink::WebFetchClientSettingsObject::outgoing_referrer to a null string when given outgoing_referrer argument is a non-null empty string. outgoing_referrer is not allowed to take a non-null empty string (i.e. String("")). However, null string are converted into non-null empty string when outgoing_referrer is passed via mojo which takes url.mojom.Url. To keep prohibiting blink::WebFetchClientSettingsObject::outgoing_referrer to be non-null empty string, this CL converts empty strings back to null string at constructors. Bug: 1047612 Change-Id: Iac8ea9ca4e752454f524e6ee28a9dce932ca572c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033004 Commit-Queue: Eriko Kurimoto <elkurin@google.com> Reviewed-by:Dominic Farolino <dom@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
-
nancy authored
BUG=1038487 Change-Id: I067e0e6be20415b17cba391c1bef4c4175a58c07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035639Reviewed-by:
Jeevan Shikaram <jshikaram@chromium.org> Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#738069}
-
Frank Tang authored
https://chromium.googlesource.com/chromium/deps/icu.git/+log/dbd3825..9f4020916 Bug: chromium:1044570 Change-Id: If3612265bae968fdb64cbd5eeb3ec9d2e0ce3c4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036515 Commit-Queue: Jungshik Shin <jshin@chromium.org> Reviewed-by:
Jungshik Shin <jshin@chromium.org> Cr-Commit-Position: refs/heads/master@{#738068}
-
Hirokazu Honda authored
https://chromium.googlesource.com/codecs/libgav1.git/+log/16e312f50668..25dc90ee0776 $ git log 16e312f50..25dc90ee0 --date=short --no-merges --format='%ad %ae %s' 2020-02-01 wtc Rename AppleCVPixelBufferPool. 2020-01-31 wtc Add apple_gav1_decode_8bit, use CVPixelBufferPool. 2020-01-31 linfengz extended kCoeffBasePositionContextOffset[] size 2020-01-31 johannkoenig arm: use store from common_neon.h 2020-01-31 johannkoenig arm: add helper versions of Load{2,4}() 2020-01-30 jzern weight_mask_sse4: use LoadAligned16() 2020-01-30 jzern mask_blend_sse4: use LoadAligned16() 2020-01-30 jzern distance_weighted_blend_sse4: use LoadAligned16() 2020-01-30 jzern average_blend_sse4: use LoadAligned16() 2020-01-30 jzern common_sse4: add LoadAligned16() (...) 2019-11-13 jzern film_grain_neon.h: rm FilmGrainSynthesis defines 2019-11-13 chengchen Reduce memory usage for super res. 2019-11-11 petersonab Use memcpy for ConstructNoiseStripes functions 2019-11-11 wtc Allocate all noise stripes in one heap allocation. 2019-11-11 wtc Make ParseMetadata() work for ITU-T T.35 and HDR metadata. 2019-11-11 johannkoenig arm: use an array for cdef intermediate value 2019-11-11 wtc Add CountTrailingZeros(uint32_t n). 2019-11-11 petersonab Refactor ConstructNoiseImage and move to DSP table 2019-11-11 linfengz Update data sizes in BoxFilterPreProcess() 2019-11-08 johannkoenig cdef directional filter Created with: roll-dep src/third_party/libgav1/src Bug: b:142835450 Test: Build chromium Change-Id: I33612f8956e21af21a81475df4d4e24fb050c114 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007799Reviewed-by:
James Zern <jzern@google.com> Reviewed-by:
Johann Koenig <johannkoenig@google.com> Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#738067}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=govind@chromium.org Change-Id: Id34b699e8a79610a6c1a4bdf742274ad63bbed21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036646Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#738066}
-
Lukasz Anforowicz authored
When an extension message is received, we check `MessageSender.id` to disallow requests from unknown clients. Unfortunately, `MessageSender.id` is currently not trustworthy (issue 982361) and therefore this CL switches to using `MessageSender.origin` instead. Bug: 10321587 Change-Id: Ia4b63bbb0bff361b6695d930eb44fdd25a8b789e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035866 Commit-Queue: Shik Chen <shik@chromium.org> Reviewed-by:
Shik Chen <shik@chromium.org> Cr-Commit-Position: refs/heads/master@{#738065}
-
Jay Harris authored
This was causing a crash during uninstallation of apps when file handling was enabled. Bug: 1047481 Change-Id: Ib5657eb48b439058e236f9abe91c8c21a0fb3be9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016783 Commit-Queue: Jay Harris <harrisjay@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#738064}
-
Ted Meyer authored
Bug: 1012527 Fixed: 1012527 Change-Id: Id9ef248aadb0aa24704dec973b60ea23c9e1f1ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032332 Commit-Queue: Ted Meyer <tmathmeyer@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#738063}
-
Aleks Totic authored
Legacy code was not enforcing 2 invariants of colspan redistribution. - min_width <= max_width - redistribution should never shrink width. The fix introduces a part of new colspan redistribution test suite. Bug: 958381 Change-Id: I3cc6e55af86dd376ffbc0a4c4710900df8bccce5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030805 Commit-Queue: Aleks Totic <atotic@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#738062}
-
Varun Khaneja authored
R=xinghuilu Fixed: 1047696 Change-Id: Id567a2bd419dcb83d9b19a6ba231cc62cfa93b53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036811 Auto-Submit: Varun Khaneja <vakh@chromium.org> Reviewed-by:
Xinghui Lu <xinghuilu@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#738061}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/aae8a22141d0..42ede502db2f Created with: gclient setdep -r src-internal@42ede502db2f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I7ba365d855776fc1c522e7523e732377c8b65c27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036924Reviewed-by:
-
Jochen Eisinger authored
Bug: 873178 Change-Id: I58082258d173cd90281500c5ae5499c1e7df20f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031111Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#738059}
-
Jeremie Boulic authored
Before the change, on the storage page, the row "Android storage" displayed the size of the android apps. The size of the apps and extensions installed from the chrome web store were not reflected anywhere on this page. This row is renamed "Apps and extensions", and displays the size of - android apps (including the default ones, which can be deleted if the user disables the Play store) - apps and extensions installed from the web store, which data is located in the Extensions folder of the user's cryptohome, as opposed to the system apps/extensions. The size of web store apps/extensions and android apps are calculated separately. The UI is always updated with the sum of both. Bytes formatting happen on the C++ side, so summing web store and android apps has to happen on the C++ side. androidRunning_ on the JS side was used to display or hide the "Android storage". The "Apps and extensions" row is now always visible. androidRunning_ is not needed anymore. unit_tests --gtest_filter="*StorageHandlerTest.AppsExtensionsSize" browser_tests --gtest_filter="*OSSettingsDevicePageTest.StorageTest" Test: Bug: 1039916 Change-Id: I4aeffad4a258356ab1cb48834b6bf2cba155f33a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032703Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Jeremie Boulic <jboulic@chromium.org> Cr-Commit-Position: refs/heads/master@{#738058}
-
Hitoshi Yoshida authored
We used bindings original name style converter, and this CL changes to use NameStyleConverter for dictionary accessors. Because of the difference of acronyms' lists, there are few updates in C++ API names; e.g. hasURL => hasUrl hasURLs => hasUrls hasJSMemoryEstimate => hasJsMemoryEstimate Bug: 839389 Change-Id: If8803899d3359d8a3d5db8d22221b788fe19c97f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032555 Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#738057}
-
Demetrios Papadopoulos authored
Specifically adding the following to settings_resources_v3.grdp - global_scroll_target_behavior.js - page_visibility.js - route.js - settings_routes.js - site_favicon.js (also port tests and add type-checking) Bug: 1026426 Change-Id: I921ede15bc636b1b1ba3457cfd1cb3a3ec06a379 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036276 Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#738056}
-
Lei Zhang authored
GetApplicationLocale() should only be called on the UI thread. In r303655, GetApplicationLocale() calls in ResolveUILanguageList() got moved off the UI thread but nobody noticed because GetApplicationLocale() didn't have any DCHECKs. In the process of adding the DCHECKs, this issue now becomes apparent. Fix the issue by calling GetApplicationLocale() on the UI thread first, before posting a task to ResolveLanguageListInThreadPool(). This also replaces 4 GetApplicationLocale() calls with 1. Rearrange the logic inside ResolveLanguageListInThreadPool() slightly as well. Bug: 1033644 Change-Id: I3c350c34cf253052bad18b850381e2c92003b7f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036373Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#738055}
-
Ian Kilpatrick authored
Followup from: https://chromium-review.googlesource.com/c/chromium/src/+/2031547 Change-Id: I06de15554a90534978ef11c0516e81742058b834 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035860 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
-
Andrew Xu authored
ScrollableShelfView's layer is masked to create the gradient shader. In fact, when the scrollable shelf is not in overflow mode, the mask layer is not needed. This CL sets the mask layer to null when the scrollable shelf is not in overflow mode. Bug: 1045265 Change-Id: I32fce5bd13da47a1d0b89968a5be54cd68a13738 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033540 Commit-Queue: Andrew Xu <andrewxu@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#738053}
-
Fergal Daly authored
This relands https://crrev.com/c/1688957 It also updates it make it controlled by a feature-flag and parameterizes all render frame hosts tests to try with the flag on and off. - https://crrev.com/c/2006996 lands some CHECKs to help debug https://crbug.com/1006814 - https://crrev.com/c/2010511 lands some CHECKs to help debug https://crbug.com/1014212 - https://crrev.com/c/2011585 adds a test for the bug in https://crbug.com/993701 however this bug is no longer triggered. > On same-site navigations, the browser reuses the current > RenderFrameHost, even if the current RenderFrameHost is crashed. > > Instead of reviving the crashed one, we should get a new RenderFrameHost. > > This can be seen as a small step in the direction of RenderDocument, which > intend to get a new RenderFrameHost every time, even if the previous > RenderFrameHost is not crashed. > https://docs.google.com/document/d/1C2VKkFRSc0kdmqjKan1G4NlNlxWZqE4Wam41FNMgnmA/edit Bug: 981339 Change-Id: I0d89d65d2c12acaccd84454ecb4a1d00901f750b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006890 Commit-Queue: Fergal Daly <fergal@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#738052}
-
Kenneth Russell authored
Previously they were not checking whether they were running on the expected GPU (low-power or high-performance). In fact, they were accidentally misconfigured in test_suites.pyl, and were not exercising the desired code paths on the bots. Stop forcing the discrete GPU when running the pixel tests - allow them to use the natural GPU configuration of the browser - and make assertions about which GPU is active at various points during the low-to-high-power and high-to-low-power tests. Bug: 1047573 Change-Id: Icdb85c6fe2625ccce489f8bba4c053f5248e1e55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032190 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
James Darpinian <jdarpinian@chromium.org> Cr-Commit-Position: refs/heads/master@{#738051}
-
matterchen authored
The existing port forwarding class interface was meant to only handle one vm / container. The interface has been extended for multiple VMs and containers. The actual implementation however has not as it will introduce too much complexity. Additionally, the IPv4 address will be extracted from the crostini manager based on the current vm+container on every rule add + activate. This IPv4 address is saved by the CrostiniManager on signals from Cicerone. Includes small refactors. BUG: chromium:848127 TEST: crostini_port_forwarder_unittest.cc passes, crostini*, path_util* Change-Id: I13b1df2e910213611a22c9201130da49a30ac1c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029474Reviewed-by:
David Munro <davidmunro@google.com> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Fergus Dall <sidereal@google.com> Commit-Queue: Matthew Chen <matterchen@google.com> Cr-Commit-Position: refs/heads/master@{#738050}
-
Victor Fei authored
This change exposes hierarchical level for tablist in the accessibility tree. Hierarchical level is determined from `aria-level` or the DOM structure of the tablist in relation to its parent tablist. https://www.w3.org/TR/wai-aria-1.1/#tablist https://www.w3.org/TR/wai-aria-1.1/#aria-level Change-Id: I1d6aba1bf47b3998a7622a98ec75dae1e41c9452 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1996263 Commit-Queue: Victor Fei <vicfei@microsoft.com> Reviewed-by:
Ian Prest <iapres@microsoft.com> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#738049}
-
