- 30 Jul, 2019 35 commits
-
-
Hiroki Nakagawa authored
ServiceWorkerNavigationHandle can be destroyed while service worker interception is happining for workers. To avoid crashes, this CL adds guards in ServiceWorkerNavigationLoaderInterceptor and WorkerScriptLoader. For navigation, it's guaranteed that the handle outlives the interceptor, so it's safe. See https://bugs.chromium.org/p/chromium/issues/detail?id=988247#c3 Bug: 988247 Change-Id: Ib72005c4832895eb82f8e28160d5b879ad19794c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1722933 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#682085}
-
James Cook authored
Specifically, the "OSSettings" test files that were forked as part of the SplitSettings project. Bug: none Test: browser_tests Change-Id: Ice152bb936d541d956dc45a442b08eb177508371 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721380Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#682084}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/fee18fe49862..d31c667503bc git log fee18fe49862..d31c667503bc --date=short --no-merges --format='%ad %ae %s' 2019-07-29 benjamin.beaudry@microsoft.com Get the rotation angle of a character. 2019-07-29 myoki.crystal@gmail.com Observe CXFA_FFPageView across OnSetFocus() events. 2019-07-29 thestig@chromium.org Roll third_party/freetype/src/ b110acba9..12af46b64 (2 commits) 2019-07-29 thestig@chromium.org Fix some nits in FPDFDOC_InitFormFillEnvironment(). Created with: gclient setdep -r src/third_party/pdfium@d31c667503bc The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=pdfium-deps-rolls@chromium.org Bug: chromium:985604,chromium:982397 Change-Id: I0bcdc5298da26dc5baaa1e1556c78d4e42a8b900 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725216Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#682083}
-
Staphany Park authored
https://chromium.googlesource.com/external/github.com/google/googletest.git/+log/b77e5c76252b..a45c24ac1878 $ git log b77e5c762..a45c24ac1 --date=short --no-merges --format='%ad %ae %s' 2019-07-29 misterg Googletest export 2019-07-29 misterg Manual docs tweaks still in preparation for including docs with code pushes 2019-07-29 misterg Manual docs tweaks still in preparation for including docs with code pushes 2019-07-11 adam.f.badura Correct CMake to cover Cygwin 2019-07-25 absl-team Googletest export 2019-07-25 absl-team Googletest export 2019-07-18 misterg Googletest export Created with: roll-dep src/third_party/googletest/src Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel,mac_optional_gpu_tests_rel,linux_chromium_cfi_rel_ng;luci.chrome.try:win_chrome_official Change-Id: Ib2312c3484e9856a4a6703b3eeb8e633e807aa2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724812 Commit-Queue: Victor Costan <pwnall@chromium.org> Auto-Submit: Staphany Park <staphany@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#682082}
-
Karan Bhatia authored
This CL adds support for a new Redirect dictionary to the "action" field of a Rule. This allows specifying rules which redirect to extension paths or performing various url transformations. Eventually this is meant to replace the "redirectUrl" field. This CL adds support for the schema and indexing of these rules. In a subsequent CL, these rules will be evaluated. This also fixes a bug with the current handling of redirectUrl key when the redirect url is relative. The query and fragment paths within the relative url weren't being handled correctly. DOC=https://docs.google.com/document/d/1foL79VwByaVeUwYPBfZeqyC2SYcAawhjjH05eqHqW_E/edit BUG=983685 No-Presubmit: True Change-Id: Ief61eed0a640f5fcadbc17e58fe611691fa64e8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1705019 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#682081}
-
Nate Chapin authored
Bug: 984932 Test: fast/loader/target-blank-to-local-resource.html Change-Id: Ic257c6ed3d15522663cd96c3a9eb190afeb0e9ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721350 Commit-Queue: Nate Chapin <japhet@chromium.org> Auto-Submit: Nate Chapin <japhet@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#682080}
-
ziyangch authored
Bug: internal b/138405284 Test: Cast YouTube to the device and check the log. -Build the whole ota package with this change. -Build the whole ota package without this change and update the cast_shell with this change. Change-Id: I1645cabae8752c3a88d44d71c3b2d038fef5af6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725182Reviewed-by:Yuchen Liu <yucliu@chromium.org> Reviewed-by:
Sergey Volk <servolk@chromium.org> Commit-Queue: Ziyang Cheng <ziyangch@chromium.org> Cr-Commit-Position: refs/heads/master@{#682079}
-
Miyoung Shin authored
This CL renames mojo to mojom and *_struct_traits.* to *_mojom_traits.* in //ui/gfx/image. *_struct_traits.* => *_mojom_traits.* ui/gfx/image/mojo => ui/gfx/image/mojom Bug: 806965 Change-Id: I0c9eb26fdfdae25716f9754c76a6e5156624a0c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1723831Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Cr-Commit-Position: refs/heads/master@{#682078}
-
Mike Dougherty authored
Bots rolled with the following script: git grep -l '11m362v' | xargs sed -i '' -e 's/11m362v/11m374r/g' CIPD packages: infra_internal/ios/xcode/mac 11m374r infra_internal/ios/xcode/ios 11m374r Bug: 988580 Change-Id: Iddfdae41e6fcaabc7460fa2608fb1122780e5acd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724291 Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#682077}
-
James Cook authored
Spec calls for Roboto Medium, so use font-weight: 500; http://screen/gAwxGhYZaAb Bug: 967923 Change-Id: I402b69077cc3b83270bbba17f35b2113c77bbec1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725215 Commit-Queue: James Cook <jamescook@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Auto-Submit: James Cook <jamescook@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#682076}
-
Hiroki Nakagawa authored
In the current implementation, WorkerShadowPage provides DocumentLoader to ApplicationCacheHost for shared workers. This blocks WorkerShadowPage removal (see the issue). To unblock it, this series of CLs reduce dependencies on DocumentLoader from ApplicationCacheHost for shared workers. This CL... - moves WillStartLoading(), WillStartLoadingMainResource(), IsApplicationCacheEnabled(), and |document_loader_| from ApplicationCacheHost to ApplicationCacheHostForFrame. - introduces WebLocalFrameClient::GetAppCacheHostIDForSharedWorker() to take an appcache host ID from WorkerShadowPage with bypassing DocumentLoader. This is a stopgap implementation, and will be removed by follow-up CLs soon. - makes ApplicationCacheHostForSharedWorker binds itself with the backend in the constructor instead of WillStartLoadingMainResource() that is a part of the lifecycle of DocumentLoader. The follow-up CLs will create ApplicationCacheHostForSharedWorker in WebSharedWorkerImpl instead of DocumentLoader. That will completely remove DocumentLoader association from ApplicationCacheHost for shared workers. Bug: 982996 Change-Id: I5beedd7600291a6f4867d35505e658b7f7194fbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1722932Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#682075}
-
Kyle Milka authored
Restructure the tile. This will making adding the selected state to this tile easier. Bug: 937570 Change-Id: I0ea51b3c777b320772bba310269e30481e7ab77d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1723585 Commit-Queue: Kyle Milka <kmilka@chromium.org> Reviewed-by:
Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#682074}
-
Patrick Noland authored
Bug: 988554 Change-Id: I93ffb47de835fd4d32b0fe86335b885a7245ea41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724581 Commit-Queue: Patrick Noland <pnoland@chromium.org> Reviewed-by:
Brandon Wylie <wylieb@chromium.org> Cr-Commit-Position: refs/heads/master@{#682073}
-
Min Qin authored
On Q, download uses content URI. As a result, we cannot use download ID to query the DownloadManager. This CL fixes the issue by publishing the download to content URI. It also fixes some other issues: 1. File path is sometimes not returned when enqueueing the download from DownloadManagerBridge. 2. clearPendingOMADownload() is an async method, so we should call removeFromSystemDownloadIdMap() at the end of the async method. 3. Some file operations are done on UI thread. They are moved to doInBackground(). BUG=987460 Change-Id: I4796aca9090fb16e2159d7f692527b348f0ea6ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717597 Commit-Queue: Min Qin <qinmin@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#682072}
-
Yue Zhang authored
Bug: 987049 Change-Id: Iff2abc130cb1e3582005df5c5671455168f79cf2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724866Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Cr-Commit-Position: refs/heads/master@{#682071}
-
James Hollyer authored
When BluetoothAdapter::Observer::GattCharacteristicValueChanged() is called WebBluetoothServiceImpl notifies all blink::BluetoothRemoteGattCharacteristic objects even if startNotifications() has not been called or there are no listeners. This is inefficient. We have decided not to fix this at the moment but we wanted to put a comment in the code so if anyone is working on that function in the future they could be aware of this inefficiency and fix it if the change becomes more straightforward. Bug: 541390 Change-Id: Icfc54cb17ac76b856effbfac97af98574a6ee17a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724588Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: James Hollyer <jameshollyer@chromium.org> Cr-Commit-Position: refs/heads/master@{#682070}
-
Koji Ishii authored
NOTRY=true TBR: eae@chromium.org, futhark@chroium.org Bug: 988585 Change-Id: I527b5539ccb431012b437fc4589509fb78113c18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724088Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#682069}
-
Steven Bennetts authored
This CL creates a separate PolicySource enum from the OncSource enum, improves the documentation of each, and simplifies the code. This also adds cr_policy_network_behavior_mojo.js for mojo api specific policy behavior, and adds tests for the old and new behaviors. Bug: 853953 Change-Id: I6a43247fd2a92db5451e52039f156edb05c56be4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717148 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Alexander Hendrich <hendrich@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#682068}
-
Nico Weber authored
Happens to remove one reference to GOOGLE_CHROME_BUILD. Bug: 961769 Change-Id: I6fafffcffd3656826e59592935270c88b84396ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724635Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#682067}
-
Akihiro Ota authored
This change implements the HandleAccessibleAction function for the AutofillPopupRowView. When this view is hovered over using the mouse or is selected using the arrow keys, the associated form fields are autofilled with the contents of the suggestion. However, when this view is focused by assistive technology, the form fields do not get populated with the suggestion's contents. This change ensures that the behaviors for hovering over a suggestion using the mouse or arrow keys and focusing a suggestion with assistive technology are the same. Change-Id: Id9bb4a8cba78eb81d2c1f6520bba64f502292c46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717315Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Akihiro Ota <akihiroota@chromium.org> Cr-Commit-Position: refs/heads/master@{#682066}
-
Sven Zheng authored
As suggested in the design doc(go/chromium-browser-pixel-tests), we hope Skia Gold can also be used for views test. But ui/views can not access chrome/ and do not need browser instance. So we split it into two classes. One for views tests, and another one for browser tests. Bug: 958242 Change-Id: I4ce370e8f7eac43816670a611a0a869ece11cbe8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700542 Commit-Queue: Sven Zheng <svenzheng@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Reviewed-by:
Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#682065}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/3d031db7..ff3f2082 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I2b00172f8e1bd55c2b94a084f9790962b6a1c1bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724639Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#682064}
-
yilkal authored
When the owner of the device is a supervised user, then remove the 'Add Users' button in users_page. Bug: 945082 Change-Id: Ib3acc6aaa955165471ca1faa36186bf3efe1dd49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1722986Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Yilkal Abe <yilkal@chromium.org> Cr-Commit-Position: refs/heads/master@{#682063}
-
Jacob DeWitt authored
It was removed from the latest version of the WebXR spec. Bug: 987026 Change-Id: I44186ad46827dee8227e07b9f5039ff3ee5217aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721048Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Brandon Jones <bajones@chromium.org> Commit-Queue: Jacob DeWitt <jacde@chromium.org> Cr-Commit-Position: refs/heads/master@{#682062}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/0d8246fe06fb..2386ffedf334 git log 0d8246fe06fb..2386ffedf334 --date=short --no-merges --format='%ad %ae %s' 2019-07-29 crouleau@chromium.org [Telemetry] Refactor page_test_results to always output results. Created with: gclient setdep -r src/third_party/catapult@2386ffedf334 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=simonhatch@google.com Bug: chromium:985103 Change-Id: I0f0be0ee049331448ade9329bd8661e8bbf7bc2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725214Reviewed-by:
-
Sophie Chang authored
Change-Id: Ibc0ab6ef374575db330dd52e102c8c1f02176dbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724280 Auto-Submit: Sophie Chang <sophiechang@chromium.org> Reviewed-by:
Doug Arnett <dougarnett@chromium.org> Commit-Queue: Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/master@{#682060}
-
Khushal authored
This reverts commit 4ea64440. Reason for revert: Font issues on webview. BUG: 977231 Original change's description: > gpu: Enable OOPRaster by default on Android. > > The only thing holding back from enabling this by default was launching > on Webview due to font remoting issues. Some fixes were landed for this > in M75 but it looks like it didn't make things much better on webview in > comparison to Android (~45 vs ~1.5 misses per million tiles). > > Still the experiment has been on for webview at 50% on the stable > channel for almost one release with M74 with no user reported bugs. At > this point its safe to assume that these cache misses are not causing > any visual errors or are misreported failures. We can address them going > forward if we get any bug reports. The rest of the metrics on webview > are still looking good on M75 so turning this on by default now. > > R=ericrk@chromium.org,piman@chromium.org > > Change-Id: I52e676be3b0a3ac10ca400b3627764a81e6e00c7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1657431 > Auto-Submit: Khushal <khushalsagar@chromium.org> > Reviewed-by: Antoine Labour <piman@chromium.org> > Commit-Queue: Khushal <khushalsagar@chromium.org> > Cr-Commit-Position: refs/heads/master@{#668879} TBR=khushalsagar@chromium.org,piman@chromium.org,ericrk@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: I0215e82b426bd51d4d5a974e1e34a6eea930a80c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1722288Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#682059}
-
Eric Foo authored
This is CL is generated by a script. Data is pulled from review conducted in Q2 2019. See https://tinyurl.com/yxau5sc4 for context. Bug: 977050 Change-Id: I39d77923e2a826cdb24c0f5036ca06f24cd6e40c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700928Reviewed-by:
Thomas Tangl <tangltom@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Auto-Submit: Eric Foo <efoo@chromium.org> Cr-Commit-Position: refs/heads/master@{#682058}
-
Alex Cooper authored
The WebXR API used to have an intermediate device that must be obtained prior to requesting sessions. This device was removed from the API. This change removes the implementation backing it (across a mojo boundary) in the browser process. Effectively this change merges XRDeviceImpl and VRServiceImpl and simplifies some parts of the code related where multiple async operations were required. Bug: 944987 Change-Id: If1c426baab8e3149059f32773e9a21313769df0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1676344Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/9ef1b771afa7..5048a6a756bf git log 9ef1b771afa7..5048a6a756bf --date=short --no-merges --format='%ad %ae %s' 2019-07-29 senorblanco@chromium.org First draft of GrDawnBuffer. 2019-07-29 benjaminwagner@google.com Revert "experimental/editor: depend on ICU, handle word-left and word-right" 2019-07-29 benjaminwagner@google.com [infra] Update GalaxyS6 2019-07-29 mtklein@google.com flesh out SkVM ops a bit more 2019-07-29 halcanary@google.com experimental/editor: depend on ICU, handle word-left and word-right Created with: gclient setdep -r src/third_party/skia@5048a6a756bf The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=benjaminwagner@google.com Bug: None Change-Id: I42b448e033b19777120c57861cfa9c49a48e38b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724275Reviewed-by:
-
Ben Chan authored
The PRLVersion property has been deprecated along with cromo. This CL removes the PRLVersion property from ONC and shill D-Bus binding. Bug: 954634 Change-Id: If7ceb2810d6c61da3a60d857ce4a826a9732919e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721881Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
-
Anubha Mathur authored
Bug: 963183 Change-Id: I9d8e16d2768d4e18768ab4dab815d6539f1c8be7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719910Reviewed-by:
Joel Einbinder <einbinder@chromium.org> Commit-Queue: Anubha Mathur <anubmat@microsoft.com> Cr-Commit-Position: refs/heads/master@{#682054}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/f8bffc628dd5..6c73c7e11dbb git log f8bffc628dd5..6c73c7e11dbb --date=short --no-merges --format='%ad %ae %s' 2019-07-29 emmavukelj@google.com Clang-Tidy: Update builder to not run clang_tidy_warn.py 2019-07-29 richardfung@google.com Add betty-pi-arc to VM tests Created with: gclient setdep -r src/third_party/chromite@6c73c7e11dbb The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: Ie4dece2e76024349abeab5b3cda69f9dd90dd1f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1723648Reviewed-by:
-
Mark Pearson authored
Still TODO: - claim sync metrics Bug: 961157 Change-Id: I8107fd13a8f5d4612f7c2bab42f4251af617030c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1694141Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#682052}
-
Maggie Cai authored
Currently, the background color for the scroll_view in the intent picker bubble is set to be always white. However, when the theme is different, the bubble background could be different. This CL changes the color to theme background color. BUG=987542 Change-Id: I3f081cd62f15e804f3e639b96d76f3797080e646 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1720331Reviewed-by:
-
- 29 Jul, 2019 5 commits
-
-
Jinsuk Kim authored
This CL fixes a bug that makes navigation bubble invisible after a certain animation. - set NavigationBubble layer type to software - Removed an unnecessary, seemingly offending navigation when gesture is canceled. It performed 2 animations in succession, but the 2nd one is not necessary since the bubble will have already disappeared from the screen after the 1st one. - Do not clear animation at the gesture start. Bug: 988341 Change-Id: Ifce226a148c88b5c7db6290c0ebf2fafd10c3c85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724071Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#682050}
-
Brandon Goddard authored
In the HeapSnapshot memory tool, there are a few columns that contain both raw byte size as well as percentages. The percentages are wrapped in a span, but only separated by a space. This causes screen readers to read out the raw value and the percentage as 1 large percentage number. This change provides an aria-label for the containing div to read out the size and percentage as separate values. Before (Screen Reader, column reading near end of gif): https://imgur.com/B4hIVa3 After (Screen Reader, column reading near end of gif): https://imgur.com/OtqlzKL Bug: 963183 Change-Id: I941b3b9dd1f18eeaea99c69d723a49cf4a54912f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699215 Commit-Queue: Brandon Goddard <brgoddar@microsoft.com> Reviewed-by:
Erik Luo <luoe@chromium.org> Cr-Commit-Position: refs/heads/master@{#682049}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/758b12fa7e67..cbabea734cbd git log 758b12fa7e67..cbabea734cbd --date=short --no-merges --format='%ad %ae %s' 2019-07-29 timvp@google.com Vulkan: Desktop ETC/EAC formats support 2019-07-29 lujc@google.com Always set matrix uniform to dirty when it updates 2019-07-29 dongja@google.com Vulkan: support relative offset in attrib bindings Created with: gclient setdep -r src/third_party/angle@cbabea734cbd The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@google.com Bug: None Change-Id: I27fc3b04919710e14a3ba007710a313d4dcbe94e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1723750Reviewed-by:
-
Evan Stade authored
It used NOTIFICATION_BROWSER_OPENED. Most of the time in these tests, the new browser is opened with chrome::NewWindow or chrome::NewEmptyWindow, which are usually synchronous, so waiting is not needed. The exception is when they trigger session restore, and in those cases it's sufficient to use SessionRestoreTestHelper::Wait. Bug: 268984 Change-Id: Ia1de99068a9c6828dbb653b7cedcd7bda31a4f0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1706952 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#682047}
-
James Cook authored
The SplitSettings project has introduced a new WebUI settings page for Chrome OS. Add load time metrics similar to the browser WebUI settings. See SettingsUI::webui_load_timer_ for how browser does it. Bug: 988508 Test: Metrics appear in about:histograms after opening settings Change-Id: I40822f28b12773ed3ed99f3c6cf8746713450c36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724820 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
-
