- 05 Jun, 2014 28 commits
-
-
nbarth@chromium.org authored
* Explicitly include v8.h where used. * Do *not* forward declare v8 symbols in headers, per: http://www.chromium.org/developers/coding-style/cpp-dos-and-donts#TOC-Exceptions There are 27 files in core (9 .h + 18 .cpp) that use v8. This corrects usage. Review URL: https://codereview.chromium.org/318843003 git-svn-id: svn://svn.chromium.org/blink/trunk@175551 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
kochi@chromium.org authored
Removes <style scoped>. This was discussed and approved with LGTMs in blink-dev: https://groups.google.com/a/chromium.org/d/msg/blink-dev/R1x18ZLS5qQ/Bjuh_cENhlQJ Chrome status dashboard entry: http://www.chromestatus.com/features/5374137958662144 Note: this is based on esprehn's original cl: https://codereview.chromium.org/214693002/ BUG=379096 TEST=pass all layout tests Review URL: https://codereview.chromium.org/310443002 git-svn-id: svn://svn.chromium.org/blink/trunk@175550 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
nbarth@chromium.org authored
Followup to: Cleanup v8 usage in core https://codereview.chromium.org/318843003/ Review URL: https://codereview.chromium.org/319653002 git-svn-id: svn://svn.chromium.org/blink/trunk@175549 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
tyoshino@chromium.org authored
BUG=none Review URL: https://codereview.chromium.org/315113002 git-svn-id: svn://svn.chromium.org/blink/trunk@175548 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
srirama.m@samsung.com authored
Bug=350571 Review URL: https://codereview.chromium.org/306123003 git-svn-id: svn://svn.chromium.org/blink/trunk@175546 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
tasak@google.com authored
BUG=369451 Review URL: https://codereview.chromium.org/313263002 git-svn-id: svn://svn.chromium.org/blink/trunk@175545 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
yhirano@chromium.org authored
Upgrade pywebsocket to r804. BUG=NONE R=tyoshino Review URL: https://codereview.chromium.org/314043002 git-svn-id: svn://svn.chromium.org/blink/trunk@175544 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
malch@chromium.org authored
Review URL: https://codereview.chromium.org/312193002 Review URL: https://codereview.chromium.org/312193002 git-svn-id: svn://svn.chromium.org/blink/trunk@175543 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
ojan@chromium.org authored
Now that frames always get a RenderLayer, we don't need to actually do a layer update anymore. Not sure how to test this. The original patch that added it https://codereview.chromium.org/104433003 didn't have any new tests. Review URL: https://codereview.chromium.org/318863002 git-svn-id: svn://svn.chromium.org/blink/trunk@175542 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
sigbjornf@opera.com authored
These two public/web/ types hadn't been updated to use transition types over their underlying Oilpan-converted objects. R=tkent@chromium.org,haraken@chromium.org BUG=357163 Review URL: https://codereview.chromium.org/310393004 git-svn-id: svn://svn.chromium.org/blink/trunk@175540 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
falken@chromium.org authored
Multi-sided patch to implement blob-type fetch event response bodies: 1: blink-side, https://codereview.chromium.org/307063002/ 2: chromium-side, https://codereview.chromium.org/315023003/ 3: blink-side, THIS PATCH BUG=379074 Review URL: https://codereview.chromium.org/304233017 git-svn-id: svn://svn.chromium.org/blink/trunk@175538 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
tkent@chromium.org authored
BUG= Review URL: https://codereview.chromium.org/317073007 git-svn-id: svn://svn.chromium.org/blink/trunk@175537 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
rtoy@chromium.org authored
This allows the test to pass on Windows, but still detects that pre-emphasis is off. BUG=349523 Review URL: https://codereview.chromium.org/314743002 git-svn-id: svn://svn.chromium.org/blink/trunk@175536 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
eustas@chromium.org authored
Screenshot: http://picpaste.com/RaGXNCAZ.png BUG=91276 Review URL: https://codereview.chromium.org/300913002 git-svn-id: svn://svn.chromium.org/blink/trunk@175535 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
chrishtr@chromium.org authored
relative to their repaint container, not their enclosing composited ancestor. The latter is wrong for squashing. BUG=370664 Review URL: https://codereview.chromium.org/318793002 git-svn-id: svn://svn.chromium.org/blink/trunk@175534 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
keishi@chromium.org authored
BUG=357163 Review URL: https://codereview.chromium.org/298963003 git-svn-id: svn://svn.chromium.org/blink/trunk@175533 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
yhirano@chromium.org authored
The HTTP header parser in Blink forbids empty header values which should be allowed. This CL fix the issue. BUG=380075 R=tyoshino@chromium.org Review URL: https://codereview.chromium.org/318613002 git-svn-id: svn://svn.chromium.org/blink/trunk@175532 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
ojan@chromium.org authored
Review URL: https://codereview.chromium.org/313053008 git-svn-id: svn://svn.chromium.org/blink/trunk@175531 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
fs@opera.com authored
With (for instance) a to-animation, the frozen element will for instance provide the 'underlying value' to any following element. BUG=374793 Review URL: https://codereview.chromium.org/316013003 git-svn-id: svn://svn.chromium.org/blink/trunk@175530 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
tkent@chromium.org authored
BUG=357163 Review URL: https://codereview.chromium.org/311193007 git-svn-id: svn://svn.chromium.org/blink/trunk@175529 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
fs@opera.com authored
The 'HitTestChildBlockBackground' hit test action needs to be considered as well when detecting hits on the SVG root container itself. BUG=379299 Review URL: https://codereview.chromium.org/318663002 git-svn-id: svn://svn.chromium.org/blink/trunk@175528 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
tyoshino@chromium.org authored
updateRequestForAccessControl() updates ResourceRequest for access control, but ResourceLoaderOptions passed to FetchRequest also contains configuration items that must be updated for access control. This CL removes cookie handling code and iframe from the following layout tests since they're testing user:pass but not cookie. - access-control-preflight-credential-async.html - access-control-preflight-credential-sync.html A new test is added to check that no cookie is set in a preflight request. This new test uses third-party-cookie-relaxing-iframe.html which was loaded by the two tests but was not actually used. Missing testRunner.setAlwaysAcceptCookies() calls are added to third-party-cookie-relaxing-iframe.html. BUG=377541 R=japhet Review URL: https://codereview.chromium.org/312653002 git-svn-id: svn://svn.chromium.org/blink/trunk@175527 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
jchaffraix@chromium.org authored
The current UI was racy and would output the last roll and current roll in random order. This change fixes this and puts the roll information to a new line, so that it stands out from the bot information. Review URL: https://codereview.chromium.org/314913002 git-svn-id: svn://svn.chromium.org/blink/trunk@175525 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
ch.dumez@samsung.com authored
Avoid calling slower Node::firstChild() / Node::lastChild() when possible by using tighter typing. This way, we end up using ContainerNode::firstChild() / ContainerNode::lastChild(), bypassing a useless isContainerNode() check. R=eseidel@chromium.org, esprehn@chromium.org Review URL: https://codereview.chromium.org/307243004 git-svn-id: svn://svn.chromium.org/blink/trunk@175524 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
yosin@chromium.org authored
Make sure calling moveParagaph() with proper parameters in CompositeEditCommand::moveParagraphContentsToNewBlockIfNecessary() This patch changes CompositeEditCommand::moveParagraphContentsToNewBlockIfNecessary() to calculate start and end positions of paragraph to move before calling moveParagraph(), because inserting paragraph element at |upstream| can change start and end positions represented by |VisiblePosition|. This patch is similar to http://crrev.com/311593003, for InsertListCommand::listifyParagraph(). BUG=325222, 351291 TEST=LayoutTests/editing/execCommand/apply-style-empty-paragraph-start-crash.html Review URL: https://codereview.chromium.org/315513003 git-svn-id: svn://svn.chromium.org/blink/trunk@175523 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
tkent@chromium.org authored
- We need to update RefPtrs not in core/dom/ too because argument types of insertBefore/replaceChid/appendChild are changed. - Member<T> should support implicit conversion to RawPtr<SuperClassOfT>. This is necessary for code like: Member<HTMLFooElement> m_foo; .... parent->appendChild(m_foo); BUG=357163 Review URL: https://codereview.chromium.org/313813002 git-svn-id: svn://svn.chromium.org/blink/trunk@175522 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
dominicc@chromium.org authored
The value of this property will be null because it is not being set by the embedder yet. BUG=379012 Review URL: https://codereview.chromium.org/313553002 git-svn-id: svn://svn.chromium.org/blink/trunk@175520 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
bashi@chromium.org authored
The previous CL (r172433) was reverted because it caused regression. This is second attempt to set referrer for css resource fetching. - Add WebCore::Referrer (not String) object to CSSParserContext - Pass the referrer to CSSImageValue, CSSImageSetValue, and CSSFontFaceSrcValue - Set the referrer when fetching BUG=380457,377864 Review URL: https://codereview.chromium.org/314893003 git-svn-id: svn://svn.chromium.org/blink/trunk@175519 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
- 04 Jun, 2014 12 commits
-
-
ch.dumez@samsung.com authored
Return early in SelectorChecker::checkOne() if selector.isAttributeSelector() is true and the selector matched. Previously, we were only returning early if the selector did not match and we were falling through if it did. This means that we ended up doing the 2 if() checks below in the method unnecessarily: - selector.m_match == CSSSelector::PseudoClass - selector.m_match == CSSSelector::PseudoElement Review URL: https://codereview.chromium.org/319513005 git-svn-id: svn://svn.chromium.org/blink/trunk@175518 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
acolwell@chromium.org authored
This fixes a regression that was accidentally introduced in r169669. If autoplay is set, then loading should not be delayed even if preload was set to "none". BUG=372770, 378682 TEST=LayoutTests/media/autoplay-with-preload-none.html Review URL: https://codereview.chromium.org/313963004 git-svn-id: svn://svn.chromium.org/blink/trunk@175517 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
bjonesbe@adobe.com authored
StyleImage::image can be used to get a cached image just like it can be used to get a generated image. So we can just have one RefPtr and remove the raw pointer, simplifiying the code immensely. Review URL: https://codereview.chromium.org/316983003 git-svn-id: svn://svn.chromium.org/blink/trunk@175516 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
clamy@chromium.org authored
This CL makes use of the new ReloadBypassingCache policy and removes the setting of cache HTTP headers in blink. BUG=376025 Review URL: https://codereview.chromium.org/318673002 git-svn-id: svn://svn.chromium.org/blink/trunk@175515 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
donnd@chromium.org authored
We want to be able to recognize tap events that the page has not handled and provide some useful default behavior for those events. Currently taps are considered handled in many cases when they really have not been handled by the page or default behavior. This CL is a beginning at correcting this. We plan to also check if the tap interacted with an element with an ARIA role that indicates it was interactive. BUG=355154 Review URL: https://codereview.chromium.org/267313008 git-svn-id: svn://svn.chromium.org/blink/trunk@175514 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
c.shu@samsung.com authored
BUG=380054 Review URL: https://codereview.chromium.org/314783004 git-svn-id: svn://svn.chromium.org/blink/trunk@175513 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
https://codereview.chromium.org/302063002/jchaffraix@chromium.org authored
Reason for revert: This change breaks: org.chromium.android_webview.test.AwSettingsTest#testBlockNetworkImagesDoesNotBlockDataUrlImage Probably because it pre-loads images when "automatically load images" is disabled on Android. See http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered_tests/builds/159696/steps/androidwebview_instrumentation_tests/logs/stdio Original issue's description: > Always preload all tokens before parsing > > This change is in preparation for re-writing the path > through which tokens are handled on the main thread > to allow them to be batched and deferred until more > important work is done: > https://codereview.chromium.org/258013009/ > > Currently the threaded parser uses the main thread's > MessageQueue as its work-queue and we'll commonly > queue 10 chunks of work in the main thread MessageQueue > even if the first chunk takes a long time we'll still have to > process the next 9 before we can do more important things > like put up a frame because we don't have a separate > queue for parser work. 258013009 will fix that. > > http/tests/security/script-crossorigin-loads-correctly-credentials-2.html > originally started failing with this change and it > turns out that always-preloading found a real bug > in CORS handling with preloads. The ResourceFetcher > was incorrectly always reusing an in-flight preload > request, even if the CORS state didn't match. Nate > helped me re-order the calls in requestResource to fix it. > > This change also discovered 2 other bugs in the preloader. > 1. a preload request != LinkPrefect request > and one will cancel the other. crbug.com/379893 > 2. The preloader has no concept of script type and will > blindly issue preloads for all <script href> regardless > of <script type>. I decided this didn't matter in practice. > Making the <script type> handling threadsafe isn't > worth the trouble. > > I would anticipate that this change might make some > speed-index scores better (we'll now be preloading > all tokens slightly sooner, especially those > which are in the same chunk as a long inline > script block for instance), but may make non-network > PLT scores lower (due to extra mallocs required > to process every chunk since more loads will > be preloaded just before their actually loaded). > > BUG=356292 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175427 TBR=tonyg@chromium.org,japhet@chromium.org,eseidel@chromium.org NOTREECHECKS=true NOTRY=true BUG=356292 Review URL: https://codereview.chromium.org/317703005 git-svn-id: svn://svn.chromium.org/blink/trunk@175512 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
jam@chromium.org authored
BUG=380588 TBR=ojan Review URL: https://codereview.chromium.org/319503004 git-svn-id: svn://svn.chromium.org/blink/trunk@175510 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
eae@chromium.org authored
Change fast/text/decorations-transformed.html to use the Ahem font instead of ahem as test-only side-loaded fonts are case sensetive on Windows. Also fix similar issue in line-break-after-question-mark test. BUG=378610 R=dglazkov@chromium.org Review URL: https://codereview.chromium.org/316933003 git-svn-id: svn://svn.chromium.org/blink/trunk@175509 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
srirama.m@samsung.com authored
BUG=350571 Review URL: https://codereview.chromium.org/298093004 git-svn-id: svn://svn.chromium.org/blink/trunk@175508 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
yoav@yoav.ws authored
Following flakiness resulting from race conditions, I'm splitting the image-currentsrc test into 3 separate layout tests. BUG=380664 Review URL: https://codereview.chromium.org/317723003 git-svn-id: svn://svn.chromium.org/blink/trunk@175507 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
rjkroege@chromium.org authored
patch 3 of 4 to specify the deviceSource of a desired fling animation request via enum throughout Blink and Chromium. BUG=343327 Review URL: https://codereview.chromium.org/304823002 git-svn-id: svn://svn.chromium.org/blink/trunk@175506 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-