GitLab

In order for RenderPass to own allocation of DrawQuads and
SharedQuadState, update surface type converter code in mojo so when
convert to DrawQuad and SharedQuadState, function takes in pointer to RenderPass
as parameter. Also in unittest, create RenderPass to deal with DrawQuad and
SharedQuadState creation.

Follows 398533002.

BUG=344962

Review URL: https://codereview.chromium.org/393103003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284104 0039d316-1c4b-4281-b951-d872f2087c98

Make it possible for clients pass in a custom task runner to be used for
posting compositor related work onto the main thread. This will be used
for prioritizing compositor tasks by the Blink scheduler.

Covered by existing tests.

BUG=391005

Review URL: https://codereview.chromium.org/400773002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284103 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284102 0039d316-1c4b-4281-b951-d872f2087c98

This pulls in the following CLs:
 - r1346 Don't free pointer in BasicCodeModules::BasicCodeModules before possibly using it
 - r1347 Stringify minidump stream_type constants in minidump_dump output
 - r1348 Ensure C:/Dumps/ exists in crash_generation_app
 - r1349 Change some ELF utils to return the length as a size_t
 - r1350 Add frame pointer recovery to the AMD64 Stackwalker.
 - r1351 [Android]: Remove __system_property_get(ro.build.fingerprint) from
WriteOSInformation.

BUG=394841,393903

Review URL: https://codereview.chromium.org/400203002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284101 0039d316-1c4b-4281-b951-d872f2087c98

Experimentally disable termination on heap corruption in order to measure the contribution of this feature to missing crash reports.

Because this feature is configured very early in the process lifetime it cannot be directly controlled by a field-trial. Rather, we query the status during a given execution, store that status in the registry, and then query the registry during startup. This means the experiment will only take effect the 2nd time it is executed.

BUG=394842

Review URL: https://codereview.chromium.org/402723002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284100 0039d316-1c4b-4281-b951-d872f2087c98

Port DeleteHistoryAndBookmarks, DeleteHistory and DeleteSearchTerms to use
base::CancelableTaskTracker instead of CancelableRequestConsumer.

BUG=371818

Review URL: https://codereview.chromium.org/370533003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284099 0039d316-1c4b-4281-b951-d872f2087c98

Added method to allow "copy image" menu tests for elements that
need capturePixels to verify test results.

BUG=392765

Review URL: https://codereview.chromium.org/396953002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284098 0039d316-1c4b-4281-b951-d872f2087c98

This adds a new GpuMemoryBuffer type that can be used to create
a GpuMemoryBuffer from an existing X11 pixmap.

This removes Create/DeleteImage IPC and reduces complexity
significantly as it allows the ImageManager to be moved to
the decoder and simply track images.

A new platform dependent GpuMemoryBufferFactory interface
is introduced to allow this new type of buffer to be created
on the GPU service side. To avoid the need for any global
variables, this factory instance is also responsible for
creating GLImage instances.

The old factory interface used by android_webview is renamed
InProcessGpuMemoryBufferFactory until it can be removed in
favor of this new interface.

BUG=368716
TEST=gpu_unittests, gl_tests --gtest_filter=GpuMemoryBufferTest.Lifecycle

Review URL: https://codereview.chromium.org/331723003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284097 0039d316-1c4b-4281-b951-d872f2087c98

The problem was that we only created the new profile if we deleted the
active profile, and it was the only existing profile. Since guest mode came
along, we could also delete the only profile when the active profile was
the guest one (which doesn't really count as a profile), so you'd be left in
this borked state of "no profiles in Chrome, oops".

For brownie points, I also added tests for both of these "only existing profile
deleted" scenarios. :)

BUG=393901
TEST=See bug description.

Review URL: https://codereview.chromium.org/396773002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284096 0039d316-1c4b-4281-b951-d872f2087c98

On Android we explicitly allow the OS to kill Chrome's background
renderers when under memory pressure and we don't try to control the
number of renderers ourselves.

The process limit logic in content causes process sharing
between unrelated tabs when the number of renderer process hosts
(not the number of actual live processes) is too high. Because on
Android the system adjusts the number of actual live processes for us,
we don't want to limit the number of process hosts or to ever share
renderers between unrelated tabs.

This patch:
- disables the renderer process host limit on Android. If not
  overridden, ShouldTryToUseExistingProcessHost() will always return
  false.
- drops the logic that sets the renderer limit based on the number of
  declared renderer services

BUG=325842

Review URL: https://codereview.chromium.org/356453003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284095 0039d316-1c4b-4281-b951-d872f2087c98

bug:
When distilling a page with new WebContents, document.offsetWidth in
domdistiller.js is always 0, because the newly created RenderView doesn't have a
size.

fix:
DistillerPageWebContents extends WebContentsDelegate and implements
GetNewSizeForRenderView() to return the size for the new RenderView.  This size
is the container bounds of the WebContents from where the distillation is
triggered.  The size is plumbed through the pipeline from the following sources
all the way down to DistillerPageWebContents.
1) WebUI: WebContents of chrome:://dom-distiller
3) ReadingList: WebContents currently associated with the extension
2) standalone ContentExtractor: WebContents of content::Shell
As for the reused WebContents (via "Distill page" in wrench menu), it already
has a size, so we just use it.

BUG=368941,367254
TBR=danakj (ui/gfx/size.h)

Review URL: https://codereview.chromium.org/396503003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284094 0039d316-1c4b-4281-b951-d872f2087c98

Added reminder message for ash_resources so that we don't forget to remove it when it becomes unnecessary.

BUG=None
R=abodenha@chromium.org

Review URL: https://codereview.chromium.org/402643003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284093 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Bypass the favicon_service when importing favicons. (https://codereview.chromium.org/375613002/)

Reason for revert:
There's a better approach.

Original issue's description:
> Bypass the favicon_service when importing favicons.
> 
> BUG=391795
> TBR=gab
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284045

TBR=blundell@chromium.org,jif@google.com,gab@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=391795

Review URL: https://codereview.chromium.org/407513002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284092 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284091 0039d316-1c4b-4281-b951-d872f2087c98

https://skia.googlesource.com/skia/+log/384b0202c040034ba1e8f2e3789a01e4b05a6a2b..19eb3b2f0aa6dce5c0335230a8930e90733e5d5d

CQ_EXTRA_TRYBOTS=tryserver.chromium:linux_layout_rel
TBR=halcanary@google.com
BUG=

Review URL: https://codereview.chromium.org/400543005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284090 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=browser_tests gtest_filter=*FileManager*

Review URL: https://codereview.chromium.org/400133002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284089 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Change SPACEPARITY in the Windows serial api implementation to ODDPARITY. (https://codereview.chromium.org/396023003/)

Reason for revert:
Very speculative revert for current XP bots failures (all 3 bots are failing with obscure errors and this is our last suspect in the list...).

I'll reland if that's not it.

Thanks for your understanding!

Original issue's description:
> Change SPACEPARITY in the Windows serial api implementation to ODDPARITY.
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284000

TBR=rockot@chromium.org,sammc@chromium.org
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/399353007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284087 0039d316-1c4b-4281-b951-d872f2087c98

BUG=379967

Review URL: https://codereview.chromium.org/392333003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284086 0039d316-1c4b-4281-b951-d872f2087c98

Add EF_FINAL_MODIFIERS to ui::KeyEventFlags to suppress modifier key
remapping on artifical events. This replaces using the X11 send_event
field.

BUG=380349
TEST=EventRewriterTest.TestRewriteKeyEventSentByXSendEvent
R=sadrul@chromium.org,derat@chromium.org

Review URL: https://codereview.chromium.org/394553002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284085 0039d316-1c4b-4281-b951-d872f2087c98

Adds WrenchMenuBadgeController which is responsible for notifying toolbar 
UI implementations (i.e. views and cocoa) about how they should be badged. 

Logic is moved from Cocoa and Views toolbar implementations and from 
wrench_icon_painter.cc to this new class. 

This refactor allows to easily expand the functionality of this class to add 
new sources of badging without needing to make the same changes to 
several platform-specific implementations. 

No functional changes. 

BUG=394855

Review URL: https://codereview.chromium.org/395193003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284084 0039d316-1c4b-4281-b951-d872f2087c98

Restrict triggering of enrollment recovery to a smaller subset of
DeviceSettingsService status codes just to be on the safe side.

BUG=389481

Review URL: https://codereview.chromium.org/400623002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284083 0039d316-1c4b-4281-b951-d872f2087c98

BUG=393611

Review URL: https://codereview.chromium.org/406463002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284082 0039d316-1c4b-4281-b951-d872f2087c98

SignAndStore method is moved out from DeviceSettingsService to OwnerSettingsService. It's still called by DeviceSettingsService via delegate, but later it will be invoked by OwnerSettingsService::Set().

BUG=230018
TEST=unit_tests:DeviceSettingsService*

Review URL: https://codereview.chromium.org/399613003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284081 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284080 0039d316-1c4b-4281-b951-d872f2087c98

(This is a reland of r283813 which was reverted in r283845 because it broke
WebRTC tests on Android. That, in turn, was a reland of of r283542 which was
reverted in r283591 because it broke the WebView build.)

This is a much larger change than its diff suggests. If it breaks
something, please revert first and ask questions later.

BUG=none

Review URL: https://codereview.chromium.org/401613008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284079 0039d316-1c4b-4281-b951-d872f2087c98

Followup to https://codereview.chromium.org/384023002/

This CL renames ChromeOS-specific code.

Still missing:
- ChromeOS-specific resource IDs (strings and images)
- JavaScript, HTML, CSS
- The global ENABLE_MANAGED_USERS define

TBR=atwilson@chromium.org (c/b/signin)
TBR=nkostylev@chromium.org (c/b/chromeos)
TBR=noms@chromium.org (c/b/profiles)
TBR=oshima@chromium.org (ash and c/b/ui/ash)
All TBRs are simple renamings.

BUG=385113

Review URL: https://codereview.chromium.org/393343002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284078 0039d316-1c4b-4281-b951-d872f2087c98

In a componentized world, ThumbnailManager will stay in Chrome and ImageManager will be the interface on which SuggestionsService will depend on.

BUG=387751
TBR=jam
TEST=Suggestions*,ThumbnailManager*

Review URL: https://codereview.chromium.org/392983007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284077 0039d316-1c4b-4281-b951-d872f2087c98

This updates the GPU rasterization whitelist to include
under-development Android versions. As of http://crrev.com/282281, 
these are treated as version 4.4.99 for blacklisting purposes.

BUG=394504

Review URL: https://codereview.chromium.org/397143002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284076 0039d316-1c4b-4281-b951-d872f2087c98

BUG=393149

Review URL: https://codereview.chromium.org/386023003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284075 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/403573003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284074 0039d316-1c4b-4281-b951-d872f2087c98

BUG=394028, 385074
TBR=eugenis@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/405613002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284073 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284072 0039d316-1c4b-4281-b951-d872f2087c98

Please reply to the V8 sheriff titzer@chromium.org in case of problems.

TBR=titzer@chromium.org

Review URL: https://codereview.chromium.org/400933003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284071 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284070 0039d316-1c4b-4281-b951-d872f2087c98

Port UpdateHistoryAndBookmarks and UpdateSearchTerms to use a
base::CancelableTaskTracker instead of a CancelableRequestConsumer.

BUG=371818

Review URL: https://codereview.chromium.org/368283003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284069 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=178418:178426&mode=html
TBR=abarth@chromium.org,johnme@chromium.org,eseidel@chromium.org
BUG=

Review URL: https://codereview.chromium.org/400953002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284068 0039d316-1c4b-4281-b951-d872f2087c98

Cleaning code that became redundant.

Review URL: https://codereview.chromium.org/384983003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284067 0039d316-1c4b-4281-b951-d872f2087c98

The previous minimum size does not fit the controls and the trach icon was
cropped.

BUG=None
TEST=manually

Review URL: https://codereview.chromium.org/398643004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284066 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Revert of Migrate accessibility from RenderView to RenderFrame. (https://codereview.chromium.org/407493002/)

Reason for revert:
Reverting the revert. This didn't break the tree; it's still broken without the patch. :(

Sorry for the noise!

Original issue's description:
> Revert of Migrate accessibility from RenderView to RenderFrame. (https://codereview.chromium.org/273423004/)
> 
> Reason for revert:
> Speculative revert to fix XP bots.
> 
> XP bots started crashing http://build.chromium.org/p/chromium.win/builders/XP%20Tests%20%281%29/builds/32011 and http://build.chromium.org/p/chromium.win/builders/XP%20Tests%20%282%29/builds/34677
> 
> This CL is the most suspicious in the range. If it doesn't fix the bots, I'll unrevert it.
> 
> Original issue's description:
> > Migrate accessibility from RenderView to RenderFrame and RVH to RFH.
> > 
> > In preparation for out-of-process iframes, move almost all accessibility
> > functionality from RenderView to RenderFrame, and from RVHI and RWHI
> > to RFHI.
> > 
> > In addition, the accessibility mode is moved to WebContents, and changing
> > the mode triggers changing it on all frames.
> > 
> > BUG=368298
> > R=jam@chromium.org, kenrb@chromium.org, nick@chromium.org
> > 
> > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283994
> 
> TBR=dmazzoni@chromium.org
> NOTRY=true
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284032

TBR=creis@chromium.org,nick@chromium.org,nasko@chromium.org,jam@chromium.org,dtseng@chromium.org,jschuh@chromium.org,tsepez@chromium.org,kenrb@chromium.org,dmazzoni@chromium.org
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/407493004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284065 0039d316-1c4b-4281-b951-d872f2087c98

This CL modifies the LeakDetector to force immediate crash when an
optional commandline argument is specified to content_shell.

Usage:
$ content_shell --dump-render-tree --enable-leak-detection=crash-on-failure

This enables us to use the ClusterFuzz infrastructure to investigate and
minimize leaks, as the tool currently detects the test case pass/fail by
seeing if the process crashes.

BUG=None

Review URL: https://codereview.chromium.org/405433011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284064 0039d316-1c4b-4281-b951-d872f2087c98