- 17 Jun, 2020 40 commits
-
-
Hans Wennborg authored
Add direct includes for things provided transitively by logging.h (or by other headers including logging.h). This is in preparation for cleaning up unnecessary includes of logging.h in header files (so if something depends on logging.h, it needs include it explicitly), and for when logging.h no longer includes check.h, check_op.h, and notreached.h. Bug: 1031540 Change-Id: I2bb6d98fe58955ec4bca2a4a2c73ce786c8d16aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248632 Auto-Submit: Hans Wennborg <hans@chromium.org> Commit-Queue: Joshua Bell <jsbell@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#779445}
-
Archana Simha authored
Add migration code for the deprecated disable reason DEPRECATED_DISABLE_UNKNOWN_FROM_SYNC and remove it from our extension metrics(ExtensionInstallProto). Bug: 860198 Change-Id: I3fb7d05f1e4a519283380aad19602d2900d32a66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222628Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Archana Simha <archanasimha@chromium.org> Cr-Commit-Position: refs/heads/master@{#779444}
-
Hans Wennborg authored
Add direct includes for things provided transitively by logging.h (or by other headers including logging.h). This is in preparation for cleaning up unnecessary includes of logging.h in header files (so if something depends on logging.h, it needs include it explicitly), and for when logging.h no longer includes check.h, check_op.h, and notreached.h. Bug: 1031540 Change-Id: I4fefb48ce89c4ae5571ecd462567f8401f61b0d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249780 Auto-Submit: Hans Wennborg <hans@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#779443}
-
Victor Costan authored
QuotaClient's methods will only be called with a StorageType in the list of types provided to QuotaManager::RegisterClient(). IndexedDB only provides kTemporary, like all modern storage APIs. Therefore, its QuotaClient implementation does not need to handle other StorageType values. Bug: 1016065 Change-Id: Ic3570a0b19bd4cb8d2dddc68a7841fbfb8c21a6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249382Reviewed-by:
Jarryd Goodman <jarrydg@chromium.org> Commit-Queue: Jarryd Goodman <jarrydg@chromium.org> Auto-Submit: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#779442}
-
Evan Liu authored
This reverts commit fa903e53. Reason for revert: Reverting while investigating bug #1095555 TBR=haraken@chromium.org, dalecurtis@chromium.org, hbos@chromium.org Change-Id: Ica1a173b8c26b6db8277dc74c5384e01cb811841 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248558 Commit-Queue: Evan Liu <evliu@google.com> Reviewed-by:
Evan Liu <evliu@google.com> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Auto-Submit: Evan Liu <evliu@google.com> Cr-Commit-Position: refs/heads/master@{#779441}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-compile-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-compile-chrome TBR=chrome-os-gardeners@google.com Change-Id: I3400d46a7e0d41a0a89e3c7021ce02f48acac430 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250458Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#779440}
-
Caitlin Fischer authored
Bug: 1094303 Change-Id: If114cee18f9c4fd9a1e75869a3626957fc222928 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2243341 Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#779439}
-
Patrick Noland authored
This test usually runs <50s, but has gone over the 60s @SmallTest limit a few times without any obvious cause, so this change increases the timeout. Bug: 1095826 Change-Id: Ia78c632276188b430159c7c49a7c751802d7908d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249592Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Patrick Noland <pnoland@chromium.org> Cr-Commit-Position: refs/heads/master@{#779438}
-
Tomasz Wiszkowski authored
Bug: 1095224 Change-Id: I39c018db582264d8e98dae9ebe04a1f4776ba324 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248074 Commit-Queue: Ender <ender@google.com> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#779437}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1592384236-ee91207a6b4e00f77c95555e5c7822ae3e4b8a11.profdata to chrome-win32-master-1592405921-bce006983aa98b323332c89a671c929444d0e708.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I63b1d452e4f89735d820cf214637df24dd590859 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250478Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#779436}
-
Patrick To authored
When XR compatibility is requested, determine whether the GPU process is using the same adapter that the active XR runtime is attached to. If not, restart the GPU process and notify it to initialize and use the XR runtime adapter. This is the last series of changes to add multi-GPU support for XR behind a flag. This change was initially reviewed as one large CL here: crrev.com/c/2096778 That CL was split into this CL and the following: crrev.com/c/2226071 crrev.com/c/2219780 crrev.com/c/2216166 crrev.com/c/2225366 After these land, there is followup work before enabling by default: - crbug.com/1086697: Return a WebGL context if no XR runtimes available - crbug.com/1090951: Migrate back to the default GPU on navigation - crbug.com/1090955: Remove flicker when GPU process is restarting - crbug.com/1087356: WebGL2 context Bug: 792657 Change-Id: Ie3342afd630b624b78a4f24a70fedf2cae5eace4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228544 Commit-Queue: Patrick To <patrto@microsoft.com> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#779435}
-
David Roger authored
Bug: 1076880 Change-Id: I67027ee8963c3f432ee11ec333d6233d8646dc41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2245706 Commit-Queue: David Roger <droger@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#779434}
-
Aaron Leventhal authored
Previous code rerouted accessibility focus reporting when any menu item or list item was focused/selected, and the current menu depth > 0. However, the menu depth calculation has shown to easily break. Since the focus override is only necessary for autofill menus, this CL changes the focus override so that it is is only turned on when needed by a popup that is overriding focus in the web page. Bug: 1039422 Change-Id: I49bd0db88bd945a6fc7be3309701d394670d7099 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247039 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#779433}
-
Evan Stade authored
Bug: 1071603 Change-Id: Idaa3ecd17791bf5ab0edb5074b07978e30e85706 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248669 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I68f4f9d48c0331f324b72700a36d616da8bef1e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250121Reviewed-by:
-
Alex Moshchuk authored
Bug: 1096047 Tbr: caitlinfischer@google.com, bcwhite@chromium.org Change-Id: I04eac398fedffae21e7e6988a691c88b8522bed9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250503Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#779430}
-
Sinan Sahin authored
This reverts commit 5dc6e2ab. Reason for revert: CL that caused the failures has been reverted. Change-Id: Id59a55078a070212dc991c792f46698220a46d24 TBR=twellington@chromium.org Bug: 1094334 Change-Id: Id59a55078a070212dc991c792f46698220a46d24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250341 Commit-Queue: Sinan Sahin <sinansahin@google.com> Reviewed-by:
Sky Malice <skym@chromium.org> Reviewed-by:
Andrew Luo <aluo@chromium.org> Reviewed-by:
Sinan Sahin <sinansahin@google.com> Cr-Commit-Position: refs/heads/master@{#779429}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1592394610-7518c1df9a0c2bd855627c235c38489e194d3191.profdata to chrome-mac-master-1592416728-1cfd8ef1020d6c6c9f6035d77a4acfb93f1c4dcb.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I77cf1292a3fa97d2528b919b67b2cefe208f8b84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250441Reviewed-by:
-
ckitagawa authored
This CL adds support for Zoom gestures for the top level frame. go/fdt-player-zoom There is a remaining issue that after zoom has finished new tiles need to be fetched causing a brief yet noticeable delay. Bug: 1020702 Change-Id: If39d73674bcd7c993711c3d1de3d8cb9e7836d91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218762Reviewed-by:
Mehran Mahmoudi <mahmoudi@chromium.org> Reviewed-by:
Fred Mello <fredmello@chromium.org> Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#779427}
-
Sylvain Defresne authored
Generated by //tools/gn/roll_gn.py https://gn.googlesource.com/gn/+log/fbe7aec7..db55efd4 db55efd4 Generate a single project with --ide=xcode a121127b Disable code signing in generated Xcode project Change-Id: Ie548b60a3c0a5f0a7971ecd54180fb33e9676274 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248761 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Dirk Pranke <dpranke@google.com> Reviewed-by:
Dirk Pranke <dpranke@google.com> Cr-Commit-Position: refs/heads/master@{#779426}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1592394610-918984ddb97fe9042cd9fa15afdd7d2534645615.profdata to chrome-win64-master-1592405921-ea7a225ddfaf855aec0c62a2999f900e2d639591.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I47554c7fe156c0ffad683b5c3e0b98aa259e7f88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248552Reviewed-by:
-
Wenyu Fu authored
TBR=ntfschr@chromium.org Bug: 1096140 Change-Id: I55af5b120e3646dc5e1a4bb530cfe43c301b201e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250464Reviewed-by:
Wenyu Fu <wenyufu@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Commit-Queue: Wenyu Fu <wenyufu@chromium.org> Cr-Commit-Position: refs/heads/master@{#779424}
-
Jae Hoon Kim authored
When a progress is reported back, we should only send the progress if it is in fact the DLC that is held onto. BUG=none TEST=unit_tests -gtest_filter=*Dlc* Change-Id: I3506dbd7735816a0bb11ed985e2c9b4af9c1d3e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248132Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Jae Hoon Kim <kimjae@chromium.org> Auto-Submit: Jae Hoon Kim <kimjae@chromium.org> Cr-Commit-Position: refs/heads/master@{#779423}
-
Nate Fischer authored
No change to logic. This extends the histogram markdown to add a Java example. This is just a copy of the C++ "NewTabPageAction" example. Test: Upload to gerrit > open file > click "gitiles" Change-Id: Id8fdce03b86a40939711eeaf76ab2842c5da5e40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247338Reviewed-by:
-
Hans Wennborg authored
Add direct includes for things provided transitively by logging.h (or by other headers including logging.h). This is in preparation for cleaning up unnecessary includes of logging.h in header files (so if something depends on logging.h, it needs include it explicitly), and for when logging.h no longer includes check.h, check_op.h, and notreached.h. Bug: 1031540 Change-Id: I2cd3fa4b60cbdf85475731ab5835d0eebac8e6e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249803 Commit-Queue: Hans Wennborg <hans@chromium.org> Auto-Submit: Hans Wennborg <hans@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#779421}
-
Hirokazu Honda authored
A frame dimension to be encoded is specified by visible size at Initialize() in VideoEncodeAccelerator API. VP9HWEncoder used by a HW video encoder on ChromeOS intel platform refuses an odd frame dimension. In other words, the HW video encoder fails the initialization with an odd frame dimension even if the HW encoder supports the odd frame dimension. There is no restriction of a frame dimension in visible size, although a coded size must be divisible by 16. This CL changes HWVP9Encoder to allow an odd dimension stream by removing the check of the frame dimension. VP8HWEncoder is able to encode an odd dimension stream in crrev.com/c/1735234. This is the similar CL for VP9 encoding. Bug: 990670 Test: video_encode_accelerator_unittest on atlas Test: https://appr.tc/?debug=loopback&vsc=vp9&video=maxWidth=641,maxHeight=361,minWidth=641,minHeight=361 Change-Id: I579640fe1f21f44411aeb91f8bf07b6b955f6300 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763658Reviewed-by:
Miguel Casas <mcasas@chromium.org> Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#779420}
-
Dominic Mazzoni authored
http://crrev.com/c/2118693 caused the invert bubble to start showing up on Mac, but only in incognito windows, which is unintentional. The bubble doesn't show up for non-incognito windows. As a quick fix, disable the bubble for incognito windows since it should never show up in one of those. Later we can follow up to address when it should show up on Mac. Bug: 1095855 Change-Id: I169f000b1657528e46fd9fc7e6786ef2834e27cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247407 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Auto-Submit: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#779419}
-
Mark Yacoub authored
Enabling and disabling displays share a lot of code that it's safe to combine them. The intention is to pass all displays bundled and go through the same path to be configured together. BUG=1082882 TEST=no changes enabling and disabling displays. Change-Id: Ibfefa497fab863315bb36f58586ac23bb402a431 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2245173Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Mark Yacoub <markyacoub@google.com> Cr-Commit-Position: refs/heads/master@{#779418}
-
Brian Sheedy authored
Adds the --bypass-skia-gold-functionality flag in the skia_gold_test mixin, ready to be uncommented if ever needed. Also updates the sheriffing documentation to identify Skia Gold outages as a special case of the failing test scenario, and how to deal with it using the above flag. Bug: 1057848 Change-Id: Ibdc66af836cd22caa2ccc970f6074c8c3e50823a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147550 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Auto-Submit: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#779417}
-
Devlin Cronin authored
Update various references to runtime.lastError to use $(ref:runtime.lastError) so that they are auto-link-ified in the generated documentation. Do this for files in //chrome/common/extensions/api. A followup will do the same for //extensions/common/api. Bug: None Change-Id: I9fddbbf2529df941b27b8585f2a8110665a8bc3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249396Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#779416}
-
Stephen McGruer authored
We briefly rolled tooling which added print-reftest, then had to revert it due to python/vpython issues. Unfortunately during this time the WPT importer updated WPT_BASE_MANIFEST_8.json with print-reftests, which is no longer recognized once the tool roll was reverted. Bug: 1095643 Change-Id: I083d3c7d3d96e5157e5cc04a686ab6e8c581bd28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250338Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#779415}
-
Trent Begin authored
This fetcher calls the network health mojo interface and populates chrome://system and feedback reports with an overview of the network state. reports Bug: chromium:1085092 Test: network-health-snapshot populated in chrome://system and feedback Change-Id: Iab76001e273a6f1911e5045c796ac0f5441e9138 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2244091 Commit-Queue: Trent Begin <tbegin@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#779414}
-
Alexander Cooper authored
android-pie-arm64-dbg routinely takes (on average) 2.5 hours to compile, though sometimes it can take over 3 hours. This change attempts to mitigate this by bumping the number of goma jobs from 80 (the default) to 300, which matches what other android arm64 builders use. Bug: 1040644 Change-Id: I9b4810a65c1fafbee8a26951e6a2c83b4a2903be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250261Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#779413}
-
Olivier Robin authored
This is a partial revert of https://chromium-review.googlesource.com/c/chromium/src/+/2248681 Version of gn used still set an incorrect value for the code signing identity, so clear it while converting the project. This is needed until landing https://chromium-review.googlesource.com/c/chromium/src/+/2248761 Bug: None Change-Id: I2af4d1e10e92972e9f6f57a4ea41674b90990e06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250060 Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Auto-Submit: Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#779412}
-
phillis authored
Adds install_time to WebApp and saves to local database. Publish install_time update via WebAppsBase. Bug: 1093025 Change-Id: Ibfb77329f075b53fcc91b72e9064c33be0520c7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247121Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Phillis Tang <phillis@chromium.org> Cr-Commit-Position: refs/heads/master@{#779411}
-
Ramin Halavati authored
Profile API is being updated (issue 1033903) and the usage of GetOffTheRecordProfile and HasOffTheRecordProfile without argument is getting deprecated. Use cases of this call that ONLY refer to incognito or guest mode can use [Get/Has]PrimaryOTRProfile() instead. Two use cases of these functions in c/b/media are updated to use the new API. This CL does not change any behavior. Bug: 1060940 Change-Id: I11dbf3845c32c6fd0cdebc542b85efc312e78b0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238830Reviewed-by:
Brandon Tolsch <btolsch@chromium.org> Auto-Submit: Ramin Halavati <rhalavati@chromium.org> Commit-Queue: Brandon Tolsch <btolsch@chromium.org> Cr-Commit-Position: refs/heads/master@{#779410}
-
Marc Treib authored
In some situations, FormFetcherImpl triggers an automatic migration of credentials from an HTTP origin to the corresponding HTTPS origin. However, this functionality was missing from MultiStoreFormFetcher. This CL adds the same logic to MultiStoreFormFetcher (though still only for the profile-scoped store - migration in the account-scoped store is left as a potential followup). This required introducing a new PasswordStoreConsumer::OnGetPasswordStoreResultsFrom() method, which is similar to the existing OnGetPasswordStoreResults(), but also receives the PasswordStore as an additional parameters. Bug: 1095556 Change-Id: I1b01ba6b723c9c4716f5d4f44569aa59ee94cd97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249898Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#779409}
-
Xiaoqian Dai authored
Bug: 1071236 Change-Id: If37eb5af5c976ad7d713cb7519ade25fa2f32984 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249393 Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#779408}
-
Olivier Li authored
Using the alias instead of T directly to make this class more similar to ScopedGeneric<T> to which it is similar. Also switch to taking const elemen_type& instead of element_type in the == operator to avoid copies but also be more idiomatic. Change-Id: Ia366b19f52b9b566319df300d75f5187152e3a69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2245885Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: Oliver Li <olivierli@chromium.org> Cr-Commit-Position: refs/heads/master@{#779407}
-
Takumi Fujimoto authored
Use the QUEUE_UPDATE Cast v2 message type instead of QUEUE_NEXT and QUEUE_PREV, given the latter two are deprecated. Bug: 1078601, b/155890949 Change-Id: I573df3df96a868dacd0db13ca5cc4d93d6075c8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2240302Reviewed-by:
-
