- 09 May, 2019 40 commits
-
-
Xiaocheng Hu authored
This is a follow-up of changing left/right caret movements from visual to logical. As NGCaretNavigator is designed for visual caret movements, it no longer serves any purpose here and hence is also removed. Bug: 958831 Change-Id: I2b18cf81ca9a997851e05617927c608b4831abbe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1602975Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#658277}
-
Kevin Strohbehn authored
Also removes dead code for ProgressBar from search results Bug: 931909 Change-Id: I37633fc95ff01508ce9a4afc8bfa9ed237f874d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600507Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Commit-Queue: Kevin Strohbehn <ginko@google.com> Cr-Commit-Position: refs/heads/master@{#658276}
-
Devlin Cronin authored
Mark Extensions.ThrottledNetworkRequests as obsolete. It has been expired since 2018-08. We haven't been looking at it lately, and we can always add it back later if we need it again. Bug: 878106 Change-Id: I24fc5e7105976da3cbfbfeb52110e8483edc7c8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600859Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#658275}
-
Bailey Berro authored
Introduces the AutomaticUsbPrinterConfigurer class. This class will be owned by CupsPrintersManager. It observes CupsPrintersManager, and when it sees a usb printer in the kAutomatic class, it installs the printer. Eventually, we will wire up a notification to let the user know that their printer is ready for use. Bug: 951135 Change-Id: I79f2a447eef6adfebbbf8d16fb84549870703adc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1585472 Commit-Queue: Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#658274}
-
Owen Min authored
The timer is a variant of base::RetainingOntshotTimer. It allows different delay for the first task and run with repeat delay every time it's reset. Also creates the enterprise_reporting folder with OWNERS file. Bug: 956237 Change-Id: Ic29e57e69051b71407007a65e68e76f3ce913968 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1590448Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#658273}
-
Etienne Bergeron authored
This CL is fixing an old bug that keeps spiking in our crash metrics. The TextElide function may produce a text that has more bytes than the original text due to the two codepoint that can be added (e.g. Ellipsis and Direction Marker). see: https://bugs.chromium.org/p/chromium/issues/detail?id=960477#c7 This CL is adding a test that is failing on this corner case. The current fix is to avoid returning a longer text than the original. The main problem is that the BreakList are also represented over input ranges and having an extra character will leads to crash. R=msw@chromium.org CC=ccameron@chromium.org,asvitkine@chromium.org Bug: 960477 Change-Id: I422a12bdd6bde1c785a74c64e1c8c4817cf9b994 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1602972 Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#658272}
-
Sahel Sharify authored
JourneyLogger::IncrementSelection[Adds/Changes/Edits] methods are used to count the number of times that each of the shipping, payment, and contact info sections are added, changed, or edited by the user during a payment process. After calling these methods on desktop payment request code path the following UMA metrics are correctly logged on desktop platforms: PaymentRequest.NumberOfSelection[Adds/Changes/Edits].[ContactInfo/ShippingAddress/PaymentMethod].[Completed/UserAborded/OtherAborted] Bug: 959979 Change-Id: I0d82b1c7dfe90a5dcde364fd4c4d8c4b6bd8e696 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600448 Commit-Queue: Sahel Sharify <sahel@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#658271}
-
Jun Mukai authored
With this CL, I confirmed that some metrics for LauncherAnimationsTest gets worse, which is expected (since previously it only showed an empty layer). Most notably, FullscreenAllApps smoothness becomes 50-75 -> 15-45. Interestingly the smoothness for Close isn't affected and it's mostly 100 when testing on nocturne. Bug: 954521 Test: manually with interactive_ui_tests --enable-pixel-output-in-tests Change-Id: Ia9ba9b70ea55c0e78c0fbfb5f8152771e0b67515 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1601415Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Jun Mukai <mukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#658270}
-
Charlie Andrews authored
NOTRY=true TBR=sullivan@chromium.org CC=tdresser@chromium.org,mythria@chromium.org,ulan@chromium.org Bug: 96434 Change-Id: Ic34d4f6221eecd7907273526a11021d57556a3a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1603544 Commit-Queue: Charlie Andrews <charliea@chromium.org> Reviewed-by:
Charlie Andrews <charliea@chromium.org> Cr-Commit-Position: refs/heads/master@{#658269}
-
Albert J. Wong authored
In a number of cases, the minidumps are lost. Also crash clustering accidentally groups separate CHECKs probably due to inlining. As this is a debug function, speed isn't important so breaking explicit failure functions is a valid way to get better data even when the minidump is lost. Bug: 960470 Change-Id: I6b2d00484d9c9690baef0e9c003a1a7c73749f02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600429 Commit-Queue: Albert J. Wong <ajwong@chromium.org> Reviewed-by:
Albert J. Wong <ajwong@chromium.org> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#658268}
-
Robert Ogden authored
We've launched and enabled this by default for everybody, so the feature code is no longer needed. Bug: 909915 Change-Id: Ib1bcac2d23a6960155f944f3c11c4cda2e40c440 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1601977Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#658267}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/370d193c8e46..8a2a5a8d2777 git log 370d193c8e46..8a2a5a8d2777 --date=short --no-merges --format='%ad %ae %s' 2019-05-09 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@8a2a5a8d2777 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I26f7015a93d84745c5cf34f1e8203c2d17f177d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1602569Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#658266}
-
Kyle Milka authored
Add the menu that opens when a collection is clicked. Allow pressing back to return to the main menu. LTR: http://go/scrcast/NTQ4MzI5ODMwNjM5MjA2NHw2MDFhZmIyMi03Yg RTL: http://go/scrcast/NDY3NjE1MDA2ODUxMDcyMHw4OTE3Y2IxMS1iYw Bug: 937570 Change-Id: Idaea005cc212004ec314b720ede63a1d1d51e159 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1603206Reviewed-by:
Kristi Park <kristipark@chromium.org> Commit-Queue: Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#658265}
-
Danyao Wang authored
This is a master flag that early-adopter partners can use to toggle all experimental Web Payments API features. New features will be conditioned on a per-feature flag OR this master flag. Bug: 960400 Change-Id: If93d90a1a41e82ddef737fe239e2ca526613ba06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600427 Commit-Queue: Danyao Wang <danyao@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#658264}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e932f4a7787d..136b57f5f7ce Created with: gclient setdep -r src-internal@136b57f5f7ce The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome BUG=chromium:958163,chromium:790666,chromium:790670 TBR=dvadym@google.com,noel@google.com,jbroman@google.com,xialinyan@google.com Change-Id: I49163bce086f71394a14f871d422a78b30faf847 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1603164Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#658263}
-
Vladislav Kuzkokov authored
The "requesting-user-name" option gets overridden with value from |cupsUser|. Eventually we would want to move away from |cupsCreateDestJob| to creating IPP request directly. Bug: 951541 Change-Id: Id5f5efe5846c9acc8770ffdbaa5f33e448e52038 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1598702Reviewed-by:
Sean Kau <skau@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Auto-Submit: Vladislav Kuzkokov <vkuzkokov@chromium.org> Cr-Commit-Position: refs/heads/master@{#658262}
-
Sergey Ulanov authored
Previously AudioOutputStreamFuchsia could call AddPayloadBuffer() while there is some data in flight. Sometimes that was resulting in AddPayloadBuffer() failure. Now DiscardAllPacketsNoReply() whenever the buffer is resized, which ensures that there are no packets in flights when AddPayloadBuffer() is called. Bug: 960938 Change-Id: If16a3fb711dbb4f2e5c9c3a0880b08ad7f1b95c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1601561 Auto-Submit: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#658261}
-
Chih-Yu Huang authored
This CL removes "const scoped_refptr<>&" at video_utility.cc, and change its caller as well. BUG=946265 TEST=compile media/cast:cast_unittests Change-Id: I70aad94d9f5c1cff53d0ffab23bf4e32db46ed46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1597477 Auto-Submit: Chih-Yu Huang <akahuang@chromium.org> Commit-Queue: Yuri Wiitala <miu@chromium.org> Reviewed-by:
John Rummell <jrummell@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Cr-Commit-Position: refs/heads/master@{#658260}
-
Elly Fong-Jones authored
Per IM conversation. Bug: None Change-Id: I4a4a069b4867348d94383cfd5bb5e1b46d77c8dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1602219 Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#658259}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/4b03532de07b..694e64da2e57 git log 4b03532de07b..694e64da2e57 --date=short --no-merges --format='%ad %ae %s' 2019-05-09 dhanyaganesh@chromium.org chromeos_config: switch lakitu-release to 'triggered' Created with: gclient setdep -r src/third_party/chromite@694e64da2e57 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Change-Id: I451d1d2c07a398f3652e43c254c35aba7d356a77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1602568Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#658258}
-
rbpotter authored
resource_map substitutes '\\' for '/' in normal paths, but not for generated paths. On Windows, this causes unexpected output, because the call to os.path.join creates paths\like\this. Ensure the substitutions happen for these paths also. Bug: 715296 Change-Id: I41572aad600a47397e1e0ac484aafbf14a2a9d4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1602855Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#658257}
-
Bruno Santos authored
Test grd simulates a grd with a part file that doesn't exist for unit tests. This same grd is also analyzed by the translation script when run for real, so it should also be ignored. Bug: 961345 Change-Id: I5808e814ed59dbbf41b158057adcbbc67e3e5892 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1602595Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Bruno Santos <brunoad@chromium.org> Cr-Commit-Position: refs/heads/master@{#658256}
-
Etienne Pierre-doray authored
Before: TaskTracker counts Task for shutdown and flushing. This prevents us from scheduling job TaskSources with unknown number of tasks. This CL: TaskTracker counts queued TaskSource instead of tasks. - Adds Sequence::WillPushTask() which returns if the Sequence will be queued after pushing. - Moves has_worker_ from TaskSource to Sequence (Job TaskSource won't need it) and deletes TaskSource unittests since there no more behavior to test. - Adds TaskTracker::WillQueueTaskSource() which must be called before pushing a tasksource to a priority queue for the first time. Bug: 839091 Change-Id: I4e1c72463b7554e48744ba78b2f5bb68a674fe66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1591417 Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#658255}
-
Devlin Cronin authored
The MusicManagerPrivate test to exercise getDeviceId() needs to accommodate an empty device ID; however, this can (and did) mask other errors that should be caught. Improve the test by expecting a specific error if the device ID is empty. Bug: 923599 Change-Id: I545d36ab87ad263d8d725eeb5a94608dc0381b1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1601739Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#658254}
-
Devlin Cronin authored
Stop recording Extensions.ExtensionCreationTime.* and mark it as obsolete in histograms.xml. We haven't been looking at it lately, so we shouldn't continue recording it. We can always add it back later if we need it again. Bug: 917738 Change-Id: If3711f0e04de29fb5f4e00acdada2b97fbd37d8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600854Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#658253}
-
Owen Min authored
CloudPolicyOverridesPlatformPolicy should be supported since M75 instead of M65. Bug: 961432 Change-Id: I3a62576aa8d5c19aced9b339571e53f925078c91 Tbr: pastarmovj Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1601644Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Auto-Submit: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#658252}
-
Chris Lu authored
When a non-coordinator dismissal of the InfoBarModal (i.e. via shortcut) occurs, this change informs the coordinator of the dismissal so the proper cleanup can happen and the badge state can be set. Bug: 911864 Change-Id: Ic1b9b8091e64d2f884963b9bfa656dccccf1c291 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1601565Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#658251}
-
Collin Baker authored
This flag is enabled by default, not exposed in about://flags, and not used in any experiments. Additionally, this flag is queried in hot code. Removing the flag eliminates the need to refactor the check out of the hot path. Bug: 960913 Change-Id: Ida88f9c7b999eece39ea6bc434e041364819fda3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1601935 Commit-Queue: Collin Baker <collinbaker@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
Malay Keshav <malaykeshav@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#658250}
-
Peter Wen authored
Ignores output about ignored configuration for attribute. See bug for more examples. Bug: 961382 Change-Id: Icec399f78e249e4bb00757e525a7da0e15a10fcf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1602287 Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Auto-Submit: Peter Wen <wnwen@chromium.org> Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Cr-Commit-Position: refs/heads/master@{#658249}
-
Michael Crouse authored
Add histogram retry check to make test more reliable. This is a reland of 5264a3a1 Original change's description: > [Previews] Record the store entry type of a hint being loaded. > > Adds a histogram to record whether the store entry that contains the hint > returned by LoadHint/OnLoadHint was a fetched or component hint. > > Implements a browsertest to confirm that fetched hints are prioritized > over component hints using the histogram. Additionally, the browsertest > checks that malformed GetHintsResponse allows previously stored component > hints to continue to be used. > > Bug: 932707 > Change-Id: I67d3af5fbfa813ee9bb39c75e9724b05ec510438 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1601359 > Commit-Queue: Michael Crouse <mcrouse@chromium.org> > Auto-Submit: Michael Crouse <mcrouse@chromium.org> > Reviewed-by: Tarun Bansal <tbansal@chromium.org> > Reviewed-by: Doug Arnett <dougarnett@chromium.org> > Cr-Commit-Position: refs/heads/master@{#657976} Bug: 932707 Change-Id: I6dd2a6ae4143883a6b1c2a188db17e4047d9ef2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1602156 Auto-Submit: Michael Crouse <mcrouse@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Michael Crouse <mcrouse@chromium.org> Cr-Commit-Position: refs/heads/master@{#658248}
-
sczs authored
This is needed since we need to be able to compare against Save and Update legacy password Infobars. If not we will have one big bucket with no way to differentiate if it was originally a Save or Update banner. Bug: 945478 Change-Id: Icf8bb338080d3ee38469733b0d51e9e347865eab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1597691Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Peter Lee <pkl@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#658247}
-
Anthony Vallee-Dubois authored
Bug: 958348 Change-Id: I3245764685899068e126025a1f164018cac9965d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1602597Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: anthonyvd <anthonyvd@chromium.org> Cr-Commit-Position: refs/heads/master@{#658246}
-
Nico Weber authored
No behavior change. Bug: 960800,908474,917355,124610 Change-Id: Id801cce3b6a9eeab828d9fe36ba4f629879c455f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1603061Reviewed-by:
Raymond Toy <rtoy@chromium.org> Commit-Queue: Raymond Toy <rtoy@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#658245}
-
Yi Xu authored
The detached canvas now respect the specified size instead of the minimum font size in settings. Bug:953385 Change-Id: I56f68869504cdd59864cc5d2530f008e885f8bdd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1601667 Commit-Queue: Yi Xu <yiyix@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Cr-Commit-Position: refs/heads/master@{#658244}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/00714a05fb5d..706619bb28a4 git log 00714a05fb5d..706619bb28a4 --date=short --no-merges --format='%ad %ae %s' 2019-05-09 tsepez@chromium.org Remove tree-corrupting methods from CXFA_LayoutItem, try #3. Created with: gclient setdep -r src/third_party/pdfium@706619bb28a4 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=pdfium-deps-rolls@chromium.org Change-Id: Iaff50f57c2b837faa9c613b698ecf7ef74ff27a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1602860Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#658243}
-
Charlie Andrews authored
The story is failing consistently across all benchmarks and a bisect has been launched. NOTRY=true TBR=sullivan@chromium.org Bug: 961417 Change-Id: I92da79682df2d0653a2c12fac2609cce4de5b292 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1603216Reviewed-by:
Charlie Andrews <charliea@chromium.org> Commit-Queue: Charlie Andrews <charliea@chromium.org> Cr-Commit-Position: refs/heads/master@{#658242}
-
Elly Fong-Jones authored
Bug: None Change-Id: I505d8962290dc52d4270b48214f1d09270181eb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1601643 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#658241}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/38230814..a7414797 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I99eeb17e6b8112d64e7223498ca5f9ff2b220335 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1602853Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#658240}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/3e6f60b3096f..e4605daf9407 git log 3e6f60b3096f..e4605daf9407 --date=short --no-merges --format='%ad %ae %s' 2019-05-09 bclayton@google.com SpirvShader: Implement OpArrayLength 2019-05-09 bclayton@google.com SpirvShader: Implement OpCopyObject 2019-05-09 chrisforbes@google.com Set up uniform texel buffers as SampledImageDescriptor Created with: gclient setdep -r src/third_party/swiftshader@e4605daf9407 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:b/132336662,chromium:b/132333003,chromium:b/132336537 TBR=swiftshader-team+autoroll@google.com Change-Id: I5c48de13ab2da1d892935dfce5812ba3c4ac9d3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1602558Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#658239}
-
Georges Winkenbach authored
On some Chrome OS keyboards, the left-Windows key should work as the multilingual key. To this end: 1. Map linux key-code 0x248 (KEY_KBD_LAYOUT_NEXT) and usb HID code 0x0c029d to DomCode::KEYBOARD_LAYOUT_SELECT and DomKey::MODE_CHANGE. (Note: DomKey::MODE_CHANGE is already mapped to VKEY_MODECHANGE.) 2. In EventRewriterChromeOs, for keyboard-layout 3, remap VKEY_MODECHANGE to key combination control-down + shift-down + space, which triggers the next IME layout in Chrome. Bug: 955106, b:120873301 Change-Id: Ib8a2e48e317840f97223b0e62ee9d3fa84306d5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1579322 Commit-Queue: Georges Winkenbach <gwink@chromium.org> Auto-Submit: Georges Winkenbach <gwink@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Gary Kacmarcik <garykac@chromium.org> Reviewed-by:
Kevin Schoedel <kpschoedel@chromium.org> Cr-Commit-Position: refs/heads/master@{#658238}
-