- 04 Oct, 2018 40 commits
-
-
Sylvain Defresne authored
TestingFactoryFunction is a simple function pointer. It is deprecated in favor of TestingFactory which is a Callback<>. Convert indirect uses by using base::BindRepeating() in all invocation of SetTestingFactory/AddTestingFactory. This converts uses in src//chrome/browser/plugins. This CL was uploaded by git cl split. R=tommycli@chromium.org Bug: 809610 Change-Id: Ic5c4219a327a8ab038371a21c5d62bba54595d2d Reviewed-on: https://chromium-review.googlesource.com/c/1258919 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#596634}
-
Sylvain Defresne authored
TestingFactoryFunction is a simple function pointer. It is deprecated in favor of TestingFactory which is a Callback<>. Convert indirect uses by using base::BindRepeating() in all invocation of SetTestingFactory/AddTestingFactory. This converts uses in src//chrome/browser/search_engines. This CL was uploaded by git cl split. R=pkasting@chromium.org Bug: 809610 Change-Id: I8f556cf9c85b9103051c036d2a81720d6bdcdb87 Reviewed-on: https://chromium-review.googlesource.com/c/1258173 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#596633}
-
Sylvain Defresne authored
TestingFactoryFunction is a simple function pointer. It is deprecated in favor of TestingFactory which is a Callback<>. Convert indirect uses by using base::BindRepeating() in all invocation of SetTestingFactory/AddTestingFactory. This converts uses in src//chrome/browser/extensions. This CL was uploaded by git cl split. R=lazyboy@chromium.org Bug: 809610 Change-Id: I8acd294b25decd9f81be9cb8b76c41f3302644af Reviewed-on: https://chromium-review.googlesource.com/c/1258171 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#596632}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/7f6417f480e7..4a72ba99a704 git log 7f6417f480e7..4a72ba99a704 --date=short --no-merges --format='%ad %ae %s' 2018-10-04 nisse@webrtc.org Delete RtpReceiver and related code. 2018-10-04 oprypin@webrtc.org Autoroller: don't run presubmit hooks Created with: gclient setdep -r src/third_party/webrtc@4a72ba99a704 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:836566 TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Id76b42048cc8fd3cf92a5c316127332381b58717 Reviewed-on: https://chromium-review.googlesource.com/c/1261415Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#596631}
-
Sylvain Defresne authored
TestingFactoryFunction is a simple function pointer. It is deprecated in favor of TestingFactory which is a Callback<>. Convert indirect uses by using base::BindRepeating() in all invocation of SetTestingFactory/AddTestingFactory. This converts uses in src//chrome. This CL was uploaded by git cl split. R=sky@chromium.org Bug: 809610 Change-Id: I69743ec252e8de02491fb85992a9f74ce197f696 Reviewed-on: https://chromium-review.googlesource.com/c/1257795 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#596630}
-
Sylvain Defresne authored
TestingFactoryFunction is a simple function pointer. It is deprecated in favor of TestingFactory which is a Callback<>. Convert indirect uses by using base::BindRepeating() in all invocation of SetTestingFactory/AddTestingFactory. This converts uses in src//chrome/browser/password_manager. This CL was uploaded by git cl split. R=vasilii@chromium.org Bug: 809610 Change-Id: Icfc16e13a6e72e0fbf99e3024c87470ead622e53 Reviewed-on: https://chromium-review.googlesource.com/c/1259012 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#596629}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/3fbdcc7add70..e3685e77a08d Created with: gclient setdep -r src-internal@e3685e77a08d The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ide3af0e4308b467c618ea78564a700025f617a56 Reviewed-on: https://chromium-review.googlesource.com/c/1261417Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#596628}
-
Sylvain Defresne authored
TestingFactoryFunction is a simple function pointer. It is deprecated in favor of TestingFactory which is a Callback<>. Convert indirect uses by using base::BindRepeating() in all invocation of SetTestingFactory/AddTestingFactory. This converts uses in src//chrome/browser/chromeos/arc. This CL was uploaded by git cl split. R=hidehiko@chromium.org Bug: 809610 Change-Id: I5fc6a8372a65e5433e17abdbd60c54c397ecc4d1 Reviewed-on: https://chromium-review.googlesource.com/c/1258351 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Cr-Commit-Position: refs/heads/master@{#596627}
-
Sylvain Defresne authored
TestingFactoryFunction is a simple function pointer. It is deprecated in favor of TestingFactory which is a Callback<>. Convert indirect uses by using base::BindRepeating() in all invocation of SetTestingFactory/AddTestingFactory. This converts uses in src//chrome/browser/search. This CL was uploaded by git cl split. R=treib@chromium.org Bug: 809610 Change-Id: I3c0bdf40ecbde2810d84368080ed8e316e2bd938 Reviewed-on: https://chromium-review.googlesource.com/c/1257861 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#596626}
-
David 'Digit' Turner authored
This reverts commit 04c5a83e. Reason for revert: it broke the translation import process (see related bugs). A fix is in the work in [1] but is not ready yet. Reverting will unblock the situation. Once [1] is submitted, the original should be applied without breaking anything. [1] https://chromium-review.googlesource.com/c/chromium/src/+/1256822 BUG=890511,890035 R=jshin@chromium.org,govind@chromium.org TBR=thestig@chromium.org Change-Id: I70ec089a438175edd13c4cd577e5c7327509b633 Reviewed-on: https://chromium-review.googlesource.com/c/1261635Reviewed-by:
David Turner <digit@chromium.org> Commit-Queue: David Turner <digit@chromium.org> Cr-Commit-Position: refs/heads/master@{#596625}
-
Sylvain Defresne authored
TestingFactoryFunction is a simple function pointer. It is deprecated in favor of TestingFactory which is a Callback<>. Convert indirect uses by using base::BindRepeating() in all invocation of SetTestingFactory/AddTestingFactory. This converts uses in src//chrome/browser/ui/startup. This CL was uploaded by git cl split. R=tmartino@chromium.org Bug: 809610 Change-Id: I90d1bbb37bbb2fefa701b1505a5e901c25bcbeda Reviewed-on: https://chromium-review.googlesource.com/c/1259022 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Tommy Martino <tmartino@chromium.org> Cr-Commit-Position: refs/heads/master@{#596624}
-
Sylvain Defresne authored
TestingFactoryFunction is a simple function pointer. It is deprecated in favor of TestingFactory which is a Callback<>. Convert indirect uses by using base::BindRepeating() in all invocation of SetTestingFactory/AddTestingFactory. This converts uses in src//chrome/browser/resource_coordinator. This CL was uploaded by git cl split. R=haraken@chromium.org Bug: 809610 Change-Id: I057b0bd65c07e68f71692e9f02259cd1e02448c9 Reviewed-on: https://chromium-review.googlesource.com/c/1259030 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#596623}
-
Sylvain Defresne authored
TestingFactoryFunction is a simple function pointer. It is deprecated in favor of TestingFactory which is a Callback<>. Convert indirect uses by using base::BindRepeating() in all invocation of SetTestingFactory/AddTestingFactory. This converts uses in src//chrome/browser/extensions/api/language_settings_private. This CL was uploaded by git cl split. R=michaelpg@chromium.org Bug: 809610 Change-Id: I565984f1f787a2b730d1f0c659e4d9c2f084fcd0 Reviewed-on: https://chromium-review.googlesource.com/c/1258920 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#596622}
-
Sylvain Defresne authored
TestingFactoryFunction is a simple function pointer. It is deprecated in favor of TestingFactory which is a Callback<>. Convert indirect uses by using base::BindRepeating() in all invocation of SetTestingFactory/AddTestingFactory. This converts uses in src//chrome/browser/media/router. This CL was uploaded by git cl split. R=btolsch@chromium.org Bug: 809610 Change-Id: I04ceb8b57dfd8772d31bee0ea7f49e9025325934 Reviewed-on: https://chromium-review.googlesource.com/c/1258350 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Brandon Tolsch <btolsch@chromium.org> Cr-Commit-Position: refs/heads/master@{#596621}
-
Sylvain Defresne authored
TestingFactoryFunction is a simple function pointer. It is deprecated in favor of TestingFactory which is a Callback<>. Convert indirect uses by using base::BindRepeating() in all invocation of SetTestingFactory/AddTestingFactory. This converts uses in src//chrome/browser/gcm. This CL was uploaded by git cl split. R=fgorski@chromium.org Bug: 809610 Change-Id: I977d7f9586dffd411471f2c5a201f3d2cd386211 Reviewed-on: https://chromium-review.googlesource.com/c/1258985 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#596620}
-
Eric Seckler authored
This fixes a bug where the order of scheduled timeouts is reshuffled during debugging via DevTools, since these timeouts are paused and unpaused when a breakpoint is reached, and notified about this via a Lifecycle observer. I'd like to try replacing the HeapHashSet currently used by Lifecycle observers with a HeapLinkedHashSet to preserve the observer iteration order, resolving the problem above. If this turns out to negatively impact performance elsewhere significantly, we can revert. Bug: 638255 Change-Id: I5c0be5c2132d3869863e3be6b8913c1f3ea3859f Reviewed-on: https://chromium-review.googlesource.com/c/1261182Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#596619}
-
Sylvain Defresne authored
TestingFactoryFunction is a simple function pointer. It is deprecated in favor of TestingFactory which is a Callback<>. Convert indirect uses by using base::BindRepeating() in all invocation of SetTestingFactory/AddTestingFactory. This converts uses in src//chrome/browser/chromeos/arc/auth. This CL was uploaded by git cl split. R=khmel@chromium.org Bug: 809610 Change-Id: I16703180cb1ca7b4acdf5b2d5eb7d81125b5695e Reviewed-on: https://chromium-review.googlesource.com/c/1259010 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Cr-Commit-Position: refs/heads/master@{#596618}
-
Sylvain Defresne authored
TestingFactoryFunction is a simple function pointer. It is deprecated in favor of TestingFactory which is a Callback<>. Convert indirect uses by using base::BindRepeating() in all invocation of SetTestingFactory/AddTestingFactory. This converts uses in src//chrome/browser/media/media_engagement_service_unittest.cc. This CL was uploaded by git cl split. R=mlamouri@chromium.org Bug: 809610 Change-Id: I6bef551f35ebab6bb192af99f86365e62ebe0b55 Reviewed-on: https://chromium-review.googlesource.com/c/1259002 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#596617}
-
Sylvain Defresne authored
TestingFactoryFunction is a simple function pointer. It is deprecated in favor of TestingFactory which is a Callback<>. Convert indirect uses by using base::BindRepeating() in all invocation of SetTestingFactory/AddTestingFactory. This converts uses in src//chrome/browser/ui/webui/print_preview. This CL was uploaded by git cl split. R=rbpotter@chromium.org Bug: 809610 Change-Id: I054ccb17b5557e700aff2ccb0f72307af5e41a5f Reviewed-on: https://chromium-review.googlesource.com/c/1258353 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#596616}
-
Sylvain Defresne authored
TestingFactoryFunction is a simple function pointer. It is deprecated in favor of TestingFactory which is a Callback<>. Convert indirect uses by using base::BindRepeating() in all invocation of SetTestingFactory/AddTestingFactory. This converts uses in src//chrome/browser/ui/views/bookmarks. This CL was uploaded by git cl split. R=sky@chromium.org Bug: 809610 Change-Id: I7e0ba402a061a981339b38f1544c867f1052f803 Reviewed-on: https://chromium-review.googlesource.com/c/1259035 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
-
Sylvain Defresne authored
TestingFactoryFunction is a simple function pointer. It is deprecated in favor of TestingFactory which is a Callback<>. Convert indirect uses by using base::BindRepeating() in all invocation of SetTestingFactory/AddTestingFactory. This converts uses in src//chrome/browser/policy. This CL was uploaded by git cl split. R=pmarko@chromium.org Bug: 809610 Change-Id: I04cc21ab7c00b7062f78eb8b54fdcaf576f93ec6 Reviewed-on: https://chromium-review.googlesource.com/c/1258332 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#596614}
-
Sylvain Defresne authored
TestingFactoryFunction is a simple function pointer. It is deprecated in favor of TestingFactory which is a Callback<>. Convert indirect uses by using base::BindRepeating() in all invocation of SetTestingFactory/AddTestingFactory. This converts uses in src//chrome/browser/safe_browsing/safe_browsing_blocking_page_unittest.cc. This CL was uploaded by git cl split. R=felt@chromium.org Bug: 809610 Change-Id: Ide7e3f2e71665f015d1ec556a96bfcd956abbffc Reviewed-on: https://chromium-review.googlesource.com/c/1259033 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Adrienne Porter Felt <felt@chromium.org> Cr-Commit-Position: refs/heads/master@{#596613}
-
Sylvain Defresne authored
TestingFactoryFunction is a simple function pointer. It is deprecated in favor of TestingFactory which is a Callback<>. Convert indirect uses by using base::BindRepeating() in all invocation of SetTestingFactory/AddTestingFactory. This converts uses in src//chrome/browser/signin. This CL was uploaded by git cl split. R=droger@chromium.org Bug: 809610 Change-Id: I5e99fe5b0d4f6ffa748dbdc8983f831de17cdcc1 Reviewed-on: https://chromium-review.googlesource.com/c/1258911 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#596612}
-
Sylvain Defresne authored
TestingFactoryFunction is a simple function pointer. It is deprecated in favor of TestingFactory which is a Callback<>. Convert indirect uses by using base::BindRepeating() in all invocation of SetTestingFactory/AddTestingFactory. This converts uses in src//chrome/browser/download. This CL was uploaded by git cl split. R=dtrainor@chromium.org Bug: 809610 Change-Id: Iac3369d290d17c49dac03816169bde2648cce8fd Reviewed-on: https://chromium-review.googlesource.com/c/1258909 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#596611}
-
Vladislav Kuzkokov authored
Bug: 885265 Change-Id: Ie90159a22ad932496921782defab4d8ca5ee6c64 Reviewed-on: https://chromium-review.googlesource.com/c/1254721 Commit-Queue: Vladislav Kuzkokov <vkuzkokov@chromium.org> Reviewed-by:
-
Sylvain Defresne authored
TestingFactoryFunction is a simple function pointer. It is deprecated in favor of TestingFactory which is a Callback<>. Convert indirect uses by using base::BindRepeating() in all invocation of SetTestingFactory/AddTestingFactory. This converts uses in src//chrome/browser/android/download. This CL was uploaded by git cl split. R=xingliu@chromium.org Bug: 809610 Change-Id: I196b778462b96eebc23acfe59de4a293aab0496e Reviewed-on: https://chromium-review.googlesource.com/c/1257837 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#596609}
-
Sylvain Defresne authored
TestingFactoryFunction is a simple function pointer. It is deprecated in favor of TestingFactory which is a Callback<>. Convert indirect uses by using base::BindRepeating() in all invocation of SetTestingFactory/AddTestingFactory. This converts uses in src//chrome/browser/ui/toolbar/media_router_contextual_menu_unittest.cc. This CL was uploaded by git cl split. R=btolsch@chromium.org Bug: 809610 Change-Id: I9a429817f8de25ca22a37a19bc564d3e408b9287 Reviewed-on: https://chromium-review.googlesource.com/c/1257794 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
-
Sylvain Defresne authored
TestingFactoryFunction is a simple function pointer. It is deprecated in favor of TestingFactory which is a Callback<>. Convert indirect uses by using base::BindRepeating() in all invocation of SetTestingFactory/AddTestingFactory. This converts uses in src//chrome/browser/feature_engagement. This CL was uploaded by git cl split. R=dtrainor@chromium.org Bug: 809610 Change-Id: Ie13b1a5069995cf5166c455a6631b55d4978b8f4 Reviewed-on: https://chromium-review.googlesource.com/c/1258916 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
-
Sylvain Defresne authored
TestingFactoryFunction is a simple function pointer. It is deprecated in favor of TestingFactory which is a Callback<>. Convert indirect uses by using base::BindRepeating() in all invocation of SetTestingFactory/AddTestingFactory. This converts uses in src//chrome/browser/ui/media_router. This CL was uploaded by git cl split. R=takumif@chromium.org Bug: 809610 Change-Id: I446325a4f9a288be91031ecf8d8465a5d84d2d8f Reviewed-on: https://chromium-review.googlesource.com/c/1257935 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#596606}
-
Sylvain Defresne authored
TestingFactoryFunction is a simple function pointer. It is deprecated in favor of TestingFactory which is a Callback<>. Convert indirect uses by using base::BindRepeating() in all invocation of SetTestingFactory/AddTestingFactory. This converts uses in src//chrome/browser/prerender. This CL was uploaded by git cl split. R=mattcary@chromium.org Bug: 809610 Change-Id: I34264dec9e444fac342146dadbdf8453d3dad870 Reviewed-on: https://chromium-review.googlesource.com/c/1259036 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Matthew Cary <mattcary@chromium.org> Cr-Commit-Position: refs/heads/master@{#596605}
-
Sylvain Defresne authored
TestingFactoryFunction is a simple function pointer. It is deprecated in favor of TestingFactory which is a Callback<>. Convert indirect uses by using base::BindRepeating() in all invocation of SetTestingFactory/AddTestingFactory. This converts uses in src//chrome/browser/profile_resetter. This CL was uploaded by git cl split. R=vabr@chromium.org Bug: 809610 Change-Id: Ia86d7d59f8025845c04432b4fa92fed0de53d511 Reviewed-on: https://chromium-review.googlesource.com/c/1259027 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
-
Sylvain Defresne authored
TestingFactoryFunction is a simple function pointer. It is deprecated in favor of TestingFactory which is a Callback<>. Convert indirect uses by using base::BindRepeating() in all invocation of SetTestingFactory/AddTestingFactory. This converts uses in src//chrome/browser/ui/views/media_router. This CL was uploaded by git cl split. R=takumif@chromium.org Bug: 809610 Change-Id: I1fe6c352e5560dae357b5ab6aec08c493d47513a Reviewed-on: https://chromium-review.googlesource.com/c/1258008 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/723e82b649de..333dfc148ff3 git log 723e82b649de..333dfc148ff3 --date=short --no-merges --format='%ad %ae %s' 2018-10-04 hjd@google.com Merge "perfetto-ui: Refactor action/reducer" Created with: gclient setdep -r src/third_party/perfetto@333dfc148ff3 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I3d3577eff595a7c8140723f13992b646c77f18ea Reviewed-on: https://chromium-review.googlesource.com/c/1261416Reviewed-by:
-
Findit authored
This reverts commit 831290e1. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 596428 as the culprit for flakes in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vODMxMjkwZTE3YWQwZmNjYzRhZjcwNTE2MjE4YmYzNTgzM2Q4OGFjNww Sample Failed Build: https://ci.chromium.org/buildbot/chromium.chromiumos/linux-chromeos-rel/14218 Sample Failed Step: viz_content_browsertests Sample Flaky Test: PortalBrowserTest.ActivatePortalInShell Original change's description: > Portals: Support activating a portal. > > When a portal is activated, the portal contents replace the tab contents. > > Bug: 865565 > Change-Id: Id666e94b0c98294dbc2eb1ce942101a2f158ebf3 > Reviewed-on: https://chromium-review.googlesource.com/c/1188884 > Commit-Queue: Lucas Gadani <lfg@chromium.org> > Reviewed-by: Nasko Oskov <nasko@chromium.org> > Reviewed-by: Jeremy Roman <jbroman@chromium.org> > Reviewed-by: Avi Drissman <avi@chromium.org> > Reviewed-by: Yaron Friedman <yfriedman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#596428} Change-Id: I8700b1340612578081c2b3ccd12a57ff48f0fd84 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 865565, 892004 Reviewed-on: https://chromium-review.googlesource.com/c/1261595 Cr-Commit-Position: refs/heads/master@{#596601}
-
Sylvain Defresne authored
TestingFactoryFunction is a simple function pointer. It is deprecated in favor of TestingFactory which is a Callback<>. Convert indirect uses by using base::BindRepeating() in all invocation of SetTestingFactory/AddTestingFactory. This converts uses in src//chrome/browser/chromeos/login/easy_unlock. This CL was uploaded by git cl split. R=xiyuan@chromium.org Bug: 809610 Change-Id: I4025e052bfa65fa8853cfff92216c4707d2ad2fa Reviewed-on: https://chromium-review.googlesource.com/c/1259007 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#596600}
-
Sylvain Defresne authored
TestingFactoryFunction is a simple function pointer. It is deprecated in favor of TestingFactory which is a Callback<>. Convert indirect uses by using base::BindRepeating() in all invocation of SetTestingFactory/AddTestingFactory. This converts uses in src//chrome/browser/ui/extensions. This CL was uploaded by git cl split. R=rdevlin.cronin@chromium.org Bug: 809610 Change-Id: I6946ce73781d65738ac93e0b32868cd69087ac20 Reviewed-on: https://chromium-review.googlesource.com/c/1258921 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#596599}
-
Sylvain Defresne authored
TestingFactoryFunction is a simple function pointer. It is deprecated in favor of TestingFactory which is a Callback<>. Convert indirect uses by using base::BindRepeating() in all invocation of SetTestingFactory/AddTestingFactory. This converts uses in src//chrome/browser/ui/desktop_ios_promotion. This CL was uploaded by git cl split. R=justincohen@chromium.org Bug: 809610 Change-Id: I5a51b5d4ada1e22557b10645166aaaa44b721bc0 Reviewed-on: https://chromium-review.googlesource.com/c/1258915 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#596598}
-
Sylvain Defresne authored
TestingFactoryFunction is a simple function pointer. It is deprecated in favor of TestingFactory which is a Callback<>. Convert indirect uses by using base::BindRepeating() in all invocation of SetTestingFactory/AddTestingFactory. This converts uses in src//chrome/browser/extensions/api/mdns. This CL was uploaded by git cl split. R=gene@chromium.org Bug: 809610 Change-Id: If3c540d1d4a21995f64f4774615a27fc374c2762 Reviewed-on: https://chromium-review.googlesource.com/c/1258910 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Gene Gutnik <gene@chromium.org> Cr-Commit-Position: refs/heads/master@{#596597}
-
Sylvain Defresne authored
TestingFactoryFunction is a simple function pointer. It is deprecated in favor of TestingFactory which is a Callback<>. Convert indirect uses by using base::BindRepeating() in all invocation of SetTestingFactory/AddTestingFactory. This converts uses in src//chrome/browser/ui/views/omnibox. This CL was uploaded by git cl split. R=tommycli@chromium.org Bug: 809610 Change-Id: Id899615e5de24f082ed88441d255c57f73d17b34 Reviewed-on: https://chromium-review.googlesource.com/c/1258359 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
-
Sylvain Defresne authored
TestingFactoryFunction is a simple function pointer. It is deprecated in favor of TestingFactory which is a Callback<>. Convert indirect uses by using base::BindRepeating() in all invocation of SetTestingFactory/AddTestingFactory. This converts uses in src//chrome/browser/chromeos. This CL was uploaded by git cl split. R=xiyuan@chromium.org Bug: 809610 Change-Id: Id2dce79aff71ae34ea51f32f7f5c631cda602997 Reviewed-on: https://chromium-review.googlesource.com/c/1259015 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
-
