- 16 Jul, 2019 40 commits
-
-
Chase Phillips authored
Bug: 984521 Change-Id: I7b89323f4fcb8fadcc9926387729fa508463c6a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1704858Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Commit-Queue: Chase Phillips <cmp@chromium.org> Cr-Commit-Position: refs/heads/master@{#677999}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/ec9ff8ce3909..f92fc916887e git log ec9ff8ce3909..f92fc916887e --date=short --no-merges --format='%ad %ae %s' 2019-07-16 syoussefi@chromium.org Vulkan: Compute shader support 2019-07-16 clemendeng@google.com Generate openGL32.dll in a separate output folder Created with: gclient setdep -r src/third_party/angle@f92fc916887e The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@chromium.org Bug: None Change-Id: Ib79f68afc8f6479dc0f53108c461428b7433f93e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1704801Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#677998}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/0fb33b26eb53..282a1f2f7798 git log 0fb33b26eb53..282a1f2f7798 --date=short --no-merges --format='%ad %ae %s' 2019-07-16 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@282a1f2f7798 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: Ia919b614a0d6c16ab8022b87b49a07ca5ac05d66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1704800Reviewed-by:
-
John Emau authored
For the devtools-node-modules change see: https://github.com/ChromeDevTools/devtools-node-modules/commit/08f835aae2a552cd8b449ec1be9d292cbacbfb8b Change-Id: Ie69565ee2eba491e5d9c4674967bab0cfbe39da9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1703126Reviewed-by:
Joel Einbinder <einbinder@chromium.org> Commit-Queue: John Emau <johnemau@microsoft.com> Cr-Commit-Position: refs/heads/master@{#677996}
-
Jeroen Dhollander authored
This is a reland of 31b40abf The original push failed because there was an API change in |ScopedTaskEnvironment| between the time I implemented this CL, and the time it was submitted. Original change's description: > Respect assistant notification expiration > > Assistant notifications can now be given an expiration time through the > |expiry_timestamp_ms| field. > > A new AssistantNotificationExpiryMonitor class will monitor all > notifications and remove them (from the AssistantNotificationModel) > when they expire. > > BUG=b/116618188 > TEST=unittests and manual create notification with expiry_timestamp_ms > > Change-Id: I5d0c0b3bcd3a26d772bccb883a5a8d5914d9c929 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1688019 > Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Tao Wu <wutao@chromium.org> > Commit-Queue: Jeroen Dhollander <jeroendh@google.com> > Cr-Commit-Position: refs/heads/master@{#677864} Bug: b/116618188 Change-Id: I93281eba85fb532877f409637d8f82820756d614 TBR=dcheng@chromium.org,xiaohuic@chromium.org,wutao@chromium.org Change-Id: I93281eba85fb532877f409637d8f82820756d614 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1704674 Commit-Queue: Jeroen Dhollander <jeroendh@google.com> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#677995}
-
Wez authored
This reverts commit eb26f201. Reason for revert: This was relanded without any changes to address the LOG(ERROR) debugging issues that prompted it to be reverted the first time. Original change's description: > Reland "[Logging] Disable always-log-ERRORs-to-stderr unless LOG_TO_FILE is set." > > This reverts commit c6b8b53b. > > Reason for revert: Fixing the debugging issues. > > Original change's description: > > Revert "[Logging] Disable always-log-ERRORs-to-stderr unless LOG_TO_FILE is set." > > > > This reverts commit ffa05b99. > > > > Reason for revert: This breaks a lot of debugging workflows. > > > > Original change's description: > > > [Logging] Disable always-log-ERRORs-to-stderr unless LOG_TO_FILE is set. > > > > > > logging::LogMessage has a special-case to write LOG_ERROR messages > > > to stderr, even if LOG_TO_STDERR is not enabled, to make ERROR and > > > FATAL messages more visible, especially in tests. > > > > > > Restrict this behaviour to apply only if LOG_TO_FILE is set, so that > > > binaries which only LOG_TO_SYSTEM_DEBUG_LOG will never emit logspam > > > to stderr. > > > > > > Tested by adding a unit test for this case. > > > > > > Bug: 968387 > > > Change-Id: Icfe094e7d7bf9697a70a589eab48edbe79c36091 > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638782 > > > Commit-Queue: Sharon Yang <yangsharon@chromium.org> > > > Reviewed-by: Wez <wez@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#666507} > > > > TBR=wez@chromium.org,kmarshall@chromium.org,yangsharon@chromium.org > > > > Change-Id: I857fd9bc95afedf204a5e981e6a362cd8990b4a8 > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Bug: 968387 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1647361 > > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > > Commit-Queue: Daniel Cheng <dcheng@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#666753} > > TBR=dcheng@chromium.org,wez@chromium.org,kmarshall@chromium.org,yangsharon@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 968387 > Change-Id: Id656bff53e3b53e4df981ca8e819f33900c966f4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1682954 > Reviewed-by: Will Harris <wfh@chromium.org> > Commit-Queue: Aidan Wolter <awolter@chromium.org> > Auto-Submit: Aidan Wolter <awolter@chromium.org> > Cr-Commit-Position: refs/heads/master@{#677030} TBR=wez@chromium.org,agl@chromium.org,wfh@chromium.org,awolter@chromium.org,yangsharon@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 968387, 984379 Change-Id: I46779692208bef6db0fb442df22868fdeecf932e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1704681Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Adam Langley <agl@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#677994}
-
yilkal authored
Bug: 977019 Change-Id: Ie6547867532f9883a84713cde0d39b8c40a07fce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1686052 Commit-Queue: Yilkal Abe <yilkal@chromium.org> Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#677993}
-
Devlin Cronin authored
Postpone the expiration of Extensions.HasPermissions_WebStoreInstall3 and Extensions.HasPermissions_WebStoreInstallCancel3 until June 2020. We'll be looking at the install prompt more in the future, and these could prove useful. Bug: 975451 Change-Id: I202e214dda5d0de37f6d0be3cd752d239031d3a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1703303Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#677992}
-
Brian Sheedy authored
Unsuppresses Pixel_Canvas2DRedBox and Pixel_CanvasLowLatency2D failures on Nexus 5 devices. Both of these appear to have been initially suppressed due to the produced image changing without the reference image being updated accordingly. Now that the tests use Skia Gold and the currently produced images are marked as approved, the tests are no longer failing. Bug: 957714, 900706 Change-Id: Ibf5180c52ec26230e0b491b89f1f8a424af272ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1703144 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Auto-Submit: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#677991}
-
Owen Min authored
Add zmin@ to chrome/brwoser/policy/* chrome/browesr/ui/webui/policy* components/policy/* Change-Id: I8fbb4a247afa8f877952ec93b77214884b39c72b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699267Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#677990}
-
Jarryd authored
Change-Id: I23cb1e95a45482f1e43a734231dd52ce432f868f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1703266Reviewed-by:
-
Wez authored
This function is used by code under //fuchsia/engine, so must be tagged for NET_EXPORT in order for component builds to succeed. Change-Id: I4a8e721749e1636dfb77128bbf3130e54f6de7f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1703343Reviewed-by:
Eric Roman <eroman@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#677988}
-
Takuto Ikuta authored
linux-archive-rel and code coverage builder do not run any tests. Bug: 954450 Change-Id: I254004a9d232f3328a0fab8b8288e7611b1e85e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1703224 Commit-Queue: John Budorick <jbudorick@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#677987}
-
Alex Cooper authored
Updates the MockXRInputSource to match the newly added gamepad support and also ports related gamepad tests to external wpts. Bug: 984154 Change-Id: I29ce501bcbea0f7bcfef6de60f17a6961fa165c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1704387Reviewed-by:
Brandon Jones <bajones@chromium.org> Commit-Queue: Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#677986}
-
Eric Roman authored
It was only used by unittests, for which the same effect can be accomplished by removing and then adding back the observer. Change-Id: Ibc79006379e8e8c550e2fe99fd9d10a06cd64f39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1703285 Commit-Queue: Eric Roman <eroman@chromium.org> Auto-Submit: Eric Roman <eroman@chromium.org> Reviewed-by:
Robbie McElrath <rmcelrath@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#677985}
-
John Rummell authored
As base::File objects are not supported in incognito mode, switch the reading of CDM files to use FileStreamReader. FileStreamWriter changes will be done in a later CL. Bug: 958204 Test: Encrypted media file IO browser_tests pass Change-Id: Iba656bc8a9e2f4d86d039569b6bd4daac32cd7ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1659604Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Commit-Queue: John Rummell <jrummell@chromium.org> Cr-Commit-Position: refs/heads/master@{#677984}
-
Xiao Yang authored
1.When the audio focus service enforces audio focus it does not assume the state of the media sessions in the stack. Therefore it may call StopDucking() even though you are not ducking. 2. We need to check the ducking status before we perform StopDucking/StartDucking action. Bug: b/135064564 Change-Id: I5b4dd778e1eb036f3c0b913402d618dba4946343 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1704391Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/ff2e8fe65f56..96d2ee0fd0bb git log ff2e8fe65f56..96d2ee0fd0bb --date=short --no-merges --format='%ad %ae %s' 2019-07-16 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-07-16 egdaniel@google.com Revert "Changes to gl BGRA renderbuffer format support." 2019-07-16 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-07-16 brianosman@google.com Generate identical shader keys for X and Y blurs when there is no domain 2019-07-16 egdaniel@google.com Changes to gl BGRA renderbuffer format support. 2019-07-16 bsalomon@google.com Rework how initial clearing of texture works. 2019-07-16 bsalomon@google.com Remove GrGLGpu/GrGLCaps readPixelsSupported. Created with: gclient setdep -r src/third_party/skia@96d2ee0fd0bb The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=nifong@google.com Change-Id: I9c368bc52c56aaaf8841c98b60520c54ade7e19b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1704593Reviewed-by:
-
Yuri Wiitala authored
To allow downstream "mirroring" product features to continue to work in a video-only mode, for really old hardware lacking a high-resolution clock, this change allows audio loopback to run in a silent mode. The old behavior was to error-out at creation time. This is accomplished by letting the audio::LoopbackStream worker thread run, just writing-out zeros to the consumer, and never starting "snooping" on any audio output streams that are discovered. Background: The new audio loopback implementation in the Audio Service dropped support for really-old hardware that lacks a high-resolution system clock. This has resulted in start-up errors in downstream products using loopback (e.g., tab mirroring via WebRTC/Chromecast) for a tiny fraction of users (~1.7%, according to metrics). Bug: 981973 Change-Id: I8c6737f16d31d5e2619dcddf86477eb83d7399e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1702771Reviewed-by:
Olga Sharonova <olka@chromium.org> Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Commit-Queue: Yuri Wiitala <miu@chromium.org> Cr-Commit-Position: refs/heads/master@{#677981}
-
Harry Cutts authored
When enabled with a flag, this service will translate D-Bus calls to the Mojo calls expected by `GesturePropertiesService`. This CL just adds `ListDevices` to keep the line count count down; the next few will add `ListProperties`, `GetProperty`, and `SetProperty`. See go/cros-gesture-properties-dbus-design (Google internal only, sorry) for more details about the full design. Some of this code is based on Jacek Fedoryński's https://crrev.com/c/1350982. dbus-send --print-reply --system \ --dest=org.chromium.GesturePropertiesService \ /org/chromium/GesturePropertiesService \ org.chromium.GesturePropertiesServiceInterface.ListDevices Bug: 952054 Test: call the `ListDevices` method from a terminal with this command: Change-Id: Iff8c6e38b9219238e8d54d98d2f4e442a1a1c1d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1589447Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Jorge Lucangeli Obes <jorgelo@chromium.org> Commit-Queue: Harry Cutts <hcutts@chromium.org> Cr-Commit-Position: refs/heads/master@{#677980}
-
Alex Cooper authored
This change ports all tests that were previously internal to external tests due to the new availability of the new input methods on the test api. There are also a few minor cleanups: * consolidate xr-test-asserts and webxr_test_asserts.js * Make Epsilon params in asserts optional and dependent on constants * Remove a few places that specified only epsilon - Some future cleanup could consider flipping the order of the params getInputPose_ray seemed to be mostly a duplicated/trimmed down version of getInputPose_hand with the addition of also using XRRay. In order to reduce dependency on XRRay, getInputPose_ray was deleted, and getInputPose_hand was renamed to getInputPose_pointer to more accurately reflect what it tests. All other changes should be direct 1:1 renames + mostly mechanical updates which reflect the different test harnesses and expectations. Bug: 979318,976980 Change-Id: Ifee8f6686f3706f73ecfee72e8c28ad5b81cc320 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1702587 Auto-Submit: Alexander Cooper <alcooper@chromium.org> Commit-Queue: Brandon Jones <bajones@chromium.org> Reviewed-by:
-
Jeremy Chinsen authored
To calculate a PDF's layout for two-up view, PDFiumEngine creates a vector of pp::Rect objects from a PDF document, calculating each page's size and the document's height and width. Then it iterates through the vector, calculating the positioning of the pp:Rect objects. GetLeftRectForTwoUpView() and GetRightRectForTwoUpView() are util functions that calculates the position of pp::Rect within a two-up view layout. Having these as util functions in pdf/draw_utils lets this logic be tested and reduces complexity of the two-up view backend. Bug: 51472 Change-Id: I98c5d9cc6ca8b7f5a381d706da4b796f8e5bc5b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699344 Commit-Queue: Jeremy Chinsen <chinsenj@google.com> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#677978}
-
yilkal authored
Bug: 977019 Change-Id: Iab08445809e063305943559657960049898a8c92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1685817 Commit-Queue: Yilkal Abe <yilkal@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
-
Kush Sinha authored
|GaiaAuthFetcher::GenerateAuthError| parses error messages from Gaia based on the "readable" error message. But in most cases, Gaia generates short error codes and not long error messages. This causes Chrome to sometimes misclassify permanent authentication errors as transient service unavailable errors, and keep retrying Gaia requests with invalid tokens/credentials. Please check the attached bugs and http://b/137322331#comment14 for more context. Bug: b/136640443, b/137322331 Change-Id: I166a7a4475e074cbb5f79296ea047a4622fc7c7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1704095 Commit-Queue: Kush Sinha <sinhak@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#677976}
-
Yuwei Huang authored
This contains a fix for the bug below. Bug: 984478 Change-Id: Ic563cce6fbc06d7ebb0f9454eb620325dd90caeb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1704860 Commit-Queue: Yuwei Huang <yuweih@chromium.org> Commit-Queue: Joe Downing <joedow@chromium.org> Auto-Submit: Yuwei Huang <yuweih@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#677975}
-
Cliff Smolinsky authored
On Windows 10 there's a new Manage/Add Printers UI in the modern settings app that is much more user friendly than the legacy control panel UI. On RS1+ there's a simple protocol launch that can be done to redirect users to it. This change follows the model of https://chromium-review.googlesource.com/c/chromium/src/+/1642818 and uses the new protocol launch to give users a better experience. Bug: 983687 Change-Id: I25d494e4acaacece18fe7a296b89ea645e7885ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700331Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
-
Henry Jian authored
Remove its instrumentation in code and mark it as obsolete in histograms.xml Bug: 975640 Change-Id: Ia7931fe8ff1b67b9c454e3501296954b5a510b1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699413Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Henry Jian <hzjian@google.com> Cr-Commit-Position: refs/heads/master@{#677973}
-
Khushal authored
Cache the snapshot for the CanvasResourceProvider to avoid repeated calls to query it while the resource has not been updated from getting expensive. R=fserb@chromium.org Bug: 974778,983549 Change-Id: I72a9b216bc5d0bc078d60ad00863be16dee4b2b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1704285 Commit-Queue: Khushal <khushalsagar@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Auto-Submit: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#677972}
-
Koji Ishii authored
Legacy, WebKit, and Edge support an undefined quirks that: a. In a quirks mode document b. A parent list item of a nested list has nothing other than the child `<ul>` or `<ol>`. then the parent list item occupies the whole line. When this occurs, list marker position is correct for symbol markers (e.g., `disc`) but not for other types (e.g., `decimal`). This patch fixes the positioning for all types. Bug: 983863 Change-Id: I1c6945a8668a56b148d6a0cbd39f8d15926b7fa0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1704854Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#677971}
-
Collin Baker authored
This is necessary until (if ever) all InstallableInkDrop users are completely migrated away from InkDropHostView. Bug: 933384 Change-Id: I74e7ba7035262524b51794c81e3562c93cbbbf32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700643 Commit-Queue: Collin Baker <collinbaker@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#677970}
-
Vladimir Levin authored
This patch changes the way we create a WebURLLoaderFactory in tests. The change is that we will inform the client that the load has resulted in an error (for both sync and async cases), instead of crashing when accessing nullptr objects in WebURLLoaderImpl This ensures that fuzzer tests avoid the async load crash, and can continue. R=yhirano@chromium.org, avi@chromium.org Change-Id: I1c0dd8c37fc6c08c1afb11dbe8b1e63b62b13524 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1691145Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#677969}
-
Ce Chen authored
component ID. The registration is currently guarded by Finch omnibox::kOnDeviceHeadProvider. Bug: 925072 Change-Id: Ia34eb90b961339ad6c9b141bcc55100e726d5aab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700273Reviewed-by:
Sorin Jianu <sorin@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Ce Chen <cch@chromium.org> Cr-Commit-Position: refs/heads/master@{#677968}
-
Brian Ho authored
Bug: 981080 Change-Id: I366366a3a6863302a8382de65a32b10956d6c1ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1704516 Commit-Queue: Brian Ho <hob@chromium.org> Reviewed-by:
Andres Calderon Jaramillo <andrescj@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#677967}
-
Cameron authored
CrOS: Adding new SearchResult flags to dinner for one to allow for future-proof placement of it and other future policy tile apps. Bug: 981023 Change-Id: I06933a73ffafa91c8388d0325c008d2bd8e436e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1687296 Commit-Queue: Cameron Womack <camw@google.com> Reviewed-by:
Yury Khmel <khmel@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#677966}
-
Gabriel Charette authored
MOCK_TIME is now applied through TimeSource::MOCK_TIME as it applies to all threads no longer only the main thread. This comment was missed in the mass migration CL @ https://chromium-review.googlesource.com/c/chromium/src/+/1702461 R=cduvall@chromium.org Bug: 946657 Change-Id: Ie576f77160c258c36166cfc06e8ec395a4af5d99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1704536 Commit-Queue: Gabriel Charette <gab@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#677965}
-
Kyle Milka authored
This is a reland of 160aa047 Missed a test that relied on the removed flag. TBR=holte@chromium.org Original change's description: > [NTP] Remove DefaultSearchShortcut experiment > > Does *NOT* remove FirstRunDefaultSearchShortcut. > > Bug: 962558 > Change-Id: Ie16cba17020cc111c15469fa9c2cdfe1b70e348a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699220 > Reviewed-by: Steven Holte <holte@chromium.org> > Reviewed-by: Kristi Park <kristipark@chromium.org> > Commit-Queue: Kyle Milka <kmilka@chromium.org> > Cr-Commit-Position: refs/heads/master@{#677823} Bug: 962558 Change-Id: Ie977330bdd263534cb61653fed8c130779448e87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1704736 Commit-Queue: Kyle Milka <kmilka@chromium.org> Reviewed-by:
Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#677964}
-
Lukasz Anforowicz authored
Removing process-per-site for WebUI pages is desirable: - It removes a special case where WebUI used a different process model, giving fewer corner cases to reason about. - process-per-site means that heavier WebUI pages (like chrome://tracing) are likely to hit an OOM in a shared renderer process, as pointed out in https://crbug.com/982266 Removing process-per-site should have only limited side-effects on process count: - Cross-origin WebUI pages get a separate site URL which means a separate process (after r595259 this is true even when over the process limit). This means that removing process-per-site should have very small effect on process count - process count will only increase in some limited scenarios - e.g. where previously two chrome://tracing tabs (i.e. same-origin WebUI tabs) would share a process. Removing process-per-site should have no undesired side-effects: - No functional behavior depends on process-per-site (e.g. WebUI pages are not able to get cross-browsing-instance references to other windows, so there is no need for hosting cross-browsing-instance, same-origin pages in the same process). - The CL preserves process-per-site behavior for NTP and adds browser tests for this aspect of NTP performance. FWIW, process-per-site for WebUI seems to go back all the way back to the initial commit: https://chromium.googlesource.com/chromium/src/+/09911bf300f1a419907a9412154760efd0b7abc3/chrome/browser/browsing_instance.cc#55 Bug: 982266 Change-Id: If28180c7113e3b352b40276601ade944cbfd97b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1693202 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Ramya Nagarajan <ramyan@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#677963}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/9a756b715c28..ded8bf94b4c3 Created with: gclient setdep -r src-internal@ded8bf94b4c3 The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome BUG=chromium:982874 TBR=holte@google.com,shimazu@google.com,mohsen@google.com,pmarko@google.com,mamir@google.com Change-Id: I5efcedd02abc59b2450ad7efb655919e525c8bda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1704592Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#677962}
-
Nick Harper authored
TBR=rsleevi@chromium.org Change-Id: Ia36f6b872428ab521fb9562cef0b1d069901dab5 Binary-Size: Increase due to adding more domains to HSTS preload list Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1702294 Commit-Queue: Nick Harper <nharper@chromium.org> Reviewed-by:
Nick Harper <nharper@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Cr-Commit-Position: refs/heads/master@{#677961}
-
Jeremy Roman authored
This is now the more common, and simpler, pattern. Bug: 981415 Change-Id: I082e75425a33f6256c2ddc3228d61f8b6fe8bc58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1704677Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#677960}
-
