GitLab

DrmOverlayValidator::TestPageFlip() can be called before
HardwareDisplayController is installed in GPU process. In the case, it reports
any planes are not overlayable. However, the client keeps this information as cache and the
overlay never happens.

To fix it, when the browser updates display configuration, it resets the cache.

BUG=683347
TEST=Run chrome on samus

Review-Url: https://codereview.chromium.org/2920613002
Cr-Commit-Position: refs/heads/master@{#476426}

1. Expose IconDescription in vector icon code so when we add or
   modify parameters we don't have to update the API.
   TODO: remove the parts of the API that use multiple parameters
         and replace them all with IconDescription.
2. Add AnimatedIconView, which caches the start and end states and
   controls animating in between as well.
3. Add an animated version of browser_tools.icon. This was crafted
   by hand based on the non-animated version and a visual description,
   but in the future designers should deliver Android vector drawables
   which will make the process of creating these icons much easier
   (and perhaps automate-able).
   TODO: actually craft a 2x version instead of reusing 1x.
4. Apply this all to the app menu. This solves the issue of pixel
   perfection in the steady state.

BUG=718549,704786

Review-Url: https://codereview.chromium.org/2892563004
Cr-Commit-Position: refs/heads/master@{#476425}

https://chromium.googlesource.com/angle/angle.git/+log/9216a6e..cae72d6

BUG=None

TEST=bots

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2919583004
Cr-Commit-Position: refs/heads/master@{#476424}

Since the client-side DPI in ARC is configured at build time based on
the internal display, the client must scale the cursor by the DSF of
the internal (not the primary) display to convert from pixels to DIPs.

BUG=642894
TEST=caroline: Cursor scale is correct for each display/resolution.

Review-Url: https://codereview.chromium.org/2779823002
Cr-Commit-Position: refs/heads/master@{#476423}

This reverts commit 5d0edd94.

Reason for revert: Possible cause of Chromium Win x64 PGO Builder compile failures; hypothesis is that filenames are exceeding the maximum path length.  See https://build.chromium.org/p/chromium.fyi/builders/Chromium%20Win%20x64%20PGO%20Builder/builds/19881 .

This will likely also fix bug 728584 as a side effect, though we could fix that differently long term.

Original change's description:
> bindings: Generate entries for .cpp/.h files from IDL dictionaries in GN
> 
> By auto-generating those entries, we can stop requiring people to manually
> update lists such as |generated_core_dictionary_files| every time Blink's
> lists of IDL dictionary files change.
> 
> Since the names of the generated .cpp/.h follow a fixed, specific format
> that only depends on their respective IDL file's path and file name, we can
> use GN itself to do some path introspection and generate the file names we
> want in idl_impl().
> 
> While here, change the names of idl_impl()'s required arguments to make
> their purpose more explicit: it is not immediately obvious that we
> differentiate unions and callback functions from dictionary files in terms
> of where the latter are generated and their file names, as well as why
> idl_impl() only expects non-dictionary files in its outputs list. A good
> next step would be generating dictionary impl files separately from unions
> and callbacks to avoid the confusion altogether.
> 
> Bug: 725996
> Change-Id: I41b06e8d71f33b21d77944216fcb07d0557ac47b
> Reviewed-on: https://chromium-review.googlesource.com/517795
> Commit-Queue: Raphael Kubo da Costa (rakuco) <raphael.kubo.da.costa@intel.com>
> Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
> Reviewed-by: Kentaro Hara <haraken@chromium.org>
> Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
> Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#476262}

TBR=peria@chromium.org,yukishiino@chromium.org,raphael.kubo.da.costa@intel.com,bashi@chromium.org,haraken@chromium.org
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 725996,728584

Change-Id: I3d41d2517c33b30b92b72686f669881eb62a7a00
Reviewed-on: https://chromium-review.googlesource.com/521702
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476422}

This makes it so that if some bot fails to run for some reason,
new expectation lines include the port for the builder that didn't
have results.

For example, suppose mac10.9_blink_rel fails compile and there
are cross-platform test failures that are observed on all other bots.
The newly-added lines would be cross-platform.
(This is what happened last week.)

Bug: 722887
Change-Id: I209267ba9e63ec912e62b08b6469f47db7bba6df
Reviewed-on: https://chromium-review.googlesource.com/520582
Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>
Reviewed-by: Jeff Carpenter <jeffcarp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476421}

This change was intended as a test for rebaseline-cl.

Change-Id: I91e843aa461e2bbd66a2608330fcbb238d1dafdb
Reviewed-on: https://chromium-review.googlesource.com/513616
Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>
Reviewed-by: Manuel Rego Casasnovas <rego@igalia.com>
Cr-Commit-Position: refs/heads/master@{#476420}

In https://codereview.chromium.org/2904093002, I'm eliminating the
DocumentMarkerDetails subclass for TextMatchMarker in favor of storing the
TextMatchMarker-specific data directly on TextMatchMarker. In
https://codereview.chromium.org/2908643002, I'm creaing a similar subclass for
CompositionMarker. In this CL, I'm doing the same for SpellingMarker and
GrammarMarker, which means we can now eliminate DocumentMarkerDetails.

In a follow-up CL, I will make MarkerType() virtual so we won't have to store
the MarkerType as a field in DocumentMarker.

BUG=707867

Review-Url: https://codereview.chromium.org/2911723002
Cr-Commit-Position: refs/heads/master@{#476419}

Modules generate fake script to report an import exception, this fake script should have correct start_position.

Bug: chromium:721589
Change-Id: Iac2aa91b9269210d39e834c5467e6ae071cce1e4
Reviewed-on: https://chromium-review.googlesource.com/521143Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476418}

BUG=chromium:724273

Review-Url: https://codereview.chromium.org/2901173002
Cr-Original-Commit-Position: refs/heads/master@{#474725}
Committed: https://chromium.googlesource.com/chromium/src/+/cb9bde9860d070b022407e3d988ba3239e00f35a
Review-Url: https://codereview.chromium.org/2901173002
Cr-Commit-Position: refs/heads/master@{#476417}

BUG=726776

Review-Url: https://codereview.chromium.org/2914883003
Cr-Commit-Position: refs/heads/master@{#476416}

Note to crash team: This CL is a refactor and has no intended behavior change.

This change was scripted by https://crbug.com/676387#c8.

Note-worthy for the reviewer:
 * SequenceChecker enforces thread-safety but not thread-affinity!
   If the classes that were updated are thread-affine (use thread local
   storage or a third-party API that does) they should be migrated to
   ThreadChecker instead.
 * ~NonThreadSafe() used to implcitly check in its destructor
   ~Sequence/ThreadChecker() doesn't by design. To keep this CL a
   no-op, an explicit check was added to the destructor of migrated
   classes.
 * NonThreadSafe used to provide access to subclasses, as such
   the |sequence_checker_| member was made protected rather than
   private where necessary.

BUG=676387
This CL was uploaded by git cl split.

R=jianli@chromium.org

Review-Url: https://codereview.chromium.org/2912823002
Cr-Commit-Position: refs/heads/master@{#476415}

- introduces mojom interface for safe browsing URL checks. This interface is registered on each render frame.
- introduces a C++ interface URLLoaderThrottle in content/ for renderers, which is similar to ResourceThrottle at the browser side; implements a subclass SafeBrowsingURLLoaderThrottle in chrome/.
- extends ContentRendererClient::WillSendRequest() to also return a list of throttle objects, so that chrome can attach the safe browsing throttle.
- provides ThrottlingURLLoader which wraps URLLoader(Factory) mojom interfaces and handles throttling properly.

The following will be in follow-up CLs:
- make sure it works on Android. The work should be minimal. But I haven't got a chance to test it on Android so I didn't bother adding Android-specific code.
- delete cache entry when safe browsing considers a URL as bad.
- handle sync loading.

BUG=715673

Review-Url: https://codereview.chromium.org/2900563002
Cr-Commit-Position: refs/heads/master@{#476414}

Note to crash team: This CL is a refactor and has no intended behavior change.

This change was scripted by https://crbug.com/676387#c8.

Note-worthy for the reviewer:
 * SequenceChecker enforces thread-safety but not thread-affinity!
   If the classes that were updated are thread-affine (use thread local
   storage or a third-party API that does) they should be migrated to
   ThreadChecker instead.
 * ~NonThreadSafe() used to implcitly check in its destructor
   ~Sequence/ThreadChecker() doesn't by design. To keep this CL a
   no-op, an explicit check was added to the destructor of migrated
   classes.
 * NonThreadSafe used to provide access to subclasses, as such
   the |sequence_checker_| member was made protected rather than
   private where necessary.

BUG=676387
This CL was uploaded by git cl split.

Review-Url: https://codereview.chromium.org/2908273002
Cr-Commit-Position: refs/heads/master@{#476413}

This is in preparation for normalizing DeviceStatus updates received as part of the KeepAliveTickle flow.

BUG=672263

Review-Url: https://codereview.chromium.org/2917813002
Cr-Commit-Position: refs/heads/master@{#476412}

BUG=546208

Review-Url: https://codereview.chromium.org/2816213002
Cr-Commit-Position: refs/heads/master@{#476411}

There's no /dev/urandom on Fuchsia, but mx_cprng_draw() is similar to
base::RandBytes().

Ref: https://fuchsia.googlesource.com/magenta/+/HEAD/docs/syscalls/cprng_draw.md

Makes RandUtilTest.* pass.

Bug: 706592
Change-Id: Idd16d322b965be498d733aa29a2d7764145408d7
Reviewed-on: https://chromium-review.googlesource.com/520607
Commit-Queue: Scott Graham <scottmg@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476410}

Re-enables the previously flaky WebVrTest#testPoseDataUnfocusedTab.
Flakiness appears to have been caused by the move to JUnit4 and fixed
in one of the CLs that did additional cleanup and improvements after the move.

Bug: 726986
Change-Id: I6e54b87e21eaed91ac668125857c09e6df4b46e2
Reviewed-on: https://chromium-review.googlesource.com/521842Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476409}

Note to crash team: This CL is a refactor and has no intended behavior change.

This change was scripted by https://crbug.com/676387#c8.

Note-worthy for the reviewer:
 * SequenceChecker enforces thread-safety but not thread-affinity!
   If the classes that were updated are thread-affine (use thread local
   storage or a third-party API that does) they should be migrated to
   ThreadChecker instead.
 * ~NonThreadSafe() used to implcitly check in its destructor
   ~Sequence/ThreadChecker() doesn't by design. To keep this CL a
   no-op, an explicit check was added to the destructor of migrated
   classes.
 * NonThreadSafe used to provide access to subclasses, as such
   the |sequence_checker_| member was made protected rather than
   private where necessary.

BUG=676387
This CL was uploaded by git cl split.

R=jianli@chromium.org

Review-Url: https://codereview.chromium.org/2915503002
Cr-Commit-Position: refs/heads/master@{#476408}

M59-M60 are controlled by the feature, while M61+ will use the
new URL exclusively, except for Cast.

BUG=703835

Review-Url: https://codereview.chromium.org/2922493002
Cr-Commit-Position: refs/heads/master@{#476407}

Note to crash team: This CL is a refactor and has no intended behavior change.

This change was scripted by https://crbug.com/676387#c8.

Note-worthy for the reviewer:
 * SequenceChecker enforces thread-safety but not thread-affinity!
   If the classes that were updated are thread-affine (use thread local
   storage or a third-party API that does) they should be migrated to
   ThreadChecker instead.
 * ~NonThreadSafe() used to implcitly check in its destructor
   ~Sequence/ThreadChecker() doesn't by design. To keep this CL a
   no-op, an explicit check was added to the destructor of migrated
   classes.
 * NonThreadSafe used to provide access to subclasses, as such
   the |sequence_checker_| member was made protected rather than
   private where necessary.

BUG=676387
This CL was uploaded by git cl split.

R=rogerta@chromium.org

Review-Url: https://codereview.chromium.org/2910983003
Cr-Commit-Position: refs/heads/master@{#476406}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/4bb4a24e..dccdc028

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2914243002
Cr-Commit-Position: refs/heads/master@{#476405}

BUG=546208

Review-Url: https://codereview.chromium.org/2823623002
Cr-Commit-Position: refs/heads/master@{#476404}

The variables.sh file was only copied for the installer tools
generation, meaning the signing scripts alone could not be built and
run. This corrects the dependency problem.

BUG=728241

Review-Url: https://codereview.chromium.org/2914783003
Cr-Commit-Position: refs/heads/master@{#476403}

Skia change: https://skia-review.googlesource.com/c/18238/

BUG=728566
NOTRY=True

Review-Url: https://codereview.chromium.org/2916143002
Cr-Commit-Position: refs/heads/master@{#476402}

Note to crash team: This CL is a refactor and has no intended behavior change.

This change was scripted by https://crbug.com/676387#c8.

Note-worthy for the reviewer:
 * SequenceChecker enforces thread-safety but not thread-affinity!
   If the classes that were updated are thread-affine (use thread local
   storage or a third-party API that does) they should be migrated to
   ThreadChecker instead.
 * ~NonThreadSafe() used to implcitly check in its destructor
   ~Sequence/ThreadChecker() doesn't by design. To keep this CL a
   no-op, an explicit check was added to the destructor of migrated
   classes.
 * NonThreadSafe used to provide access to subclasses, as such
   the |sequence_checker_| member was made protected rather than
   private where necessary.

BUG=676387
This CL was uploaded by git cl split.

R=rogerta@chromium.org

Review-Url: https://codereview.chromium.org/2908263003
Cr-Commit-Position: refs/heads/master@{#476401}

Same goal as https://codereview.chromium.org/2921463003

I think that one didn't suppress properly because the TestBody itself
isn't in the racy stacks (merely in the spawning stacks which might
not count in the suppression rules)...

Unsuppressed race report @
https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.memory%2FLinux_TSan_Tests%2F6818%2F%2B%2Frecipes%2Fsteps%2Fbase_unittests%2F0%2Flogs%2FTimerSequenceTest.OneShotTimerUsedAndTaskedOnDifferentPools%2F0

BUG=552633
TBR=danakj@chromium.org
NOTRY=True

Review-Url: https://codereview.chromium.org/2921623005
Cr-Commit-Position: refs/heads/master@{#476400}

Note to crash team: This CL is a refactor and has no intended behavior change.

This change was scripted by https://crbug.com/676387#c8.

Note-worthy for the reviewer:
 * SequenceChecker enforces thread-safety but not thread-affinity!
   If the classes that were updated are thread-affine (use thread local
   storage or a third-party API that does) they should be migrated to
   ThreadChecker instead.
 * ~NonThreadSafe() used to implcitly check in its destructor
   ~Sequence/ThreadChecker() doesn't by design. To keep this CL a
   no-op, an explicit check was added to the destructor of migrated
   classes.
 * NonThreadSafe used to provide access to subclasses, as such
   the |sequence_checker_| member was made protected rather than
   private where necessary.

BUG=676387
This CL was uploaded by git cl split.

R=nparker@chromium.org

Review-Url: https://codereview.chromium.org/2909123003
Cr-Commit-Position: refs/heads/master@{#476399}

BUG=

Review-Url: https://codereview.chromium.org/2914833003
Cr-Commit-Position: refs/heads/master@{#476398}

Note to crash team: This CL is a refactor and has no intended behavior change.

This change was scripted by https://crbug.com/676387#c8.

(and then amended to use ThreadChecker instead for StatusTrayStateChangerWin)

Note-worthy for the reviewer:
 * SequenceChecker enforces thread-safety but not thread-affinity!
   If the classes that were updated are thread-affine (use thread local
   storage or a third-party API that does) they should be migrated to
   ThreadChecker instead.
 * ~NonThreadSafe() used to implcitly check in its destructor
   ~Sequence/ThreadChecker() doesn't by design. To keep this CL a
   no-op, an explicit check was added to the destructor of migrated
   classes.
 * NonThreadSafe used to provide access to subclasses, as such
   the |sequence_checker_| member was made protected rather than
   private where necessary.

BUG=676387
This CL was uploaded by git cl split.

R=pkasting@chromium.org

Review-Url: https://codereview.chromium.org/2909213002
Cr-Commit-Position: refs/heads/master@{#476397}

Bug: 728507
Change-Id: I15a6fdc5dca349894d1682520e7c99958b3953f3
Reviewed-on: https://chromium-review.googlesource.com/521863
Commit-Queue: Anthony Vallee-Dubois <anthonyvd@chromium.org>
Commit-Queue: Mathieu Perreault <mathp@chromium.org>
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476396}

Also remove the flags from chromeos restart request since those flags
aren't passed in the browser command line or about flags.

Bug: 514813
Change-Id: I353204417c4e054aa2969e2894272d7e8e96c829
Reviewed-on: https://chromium-review.googlesource.com/515704Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476395}

Review-Url: https://codereview.chromium.org/2914973002
Cr-Commit-Position: refs/heads/master@{#476394}

This patch reorganizes the initialization of TextIterator for better code
health.

1. Members originally initialized in the function body of TextIterator::ctor
   are changed to be initialized in the initialization list. Some wrapper
   functions are created for members with non-trivial initialization.
   - start_container_
   - start_offset_
   - end_container_
   - end_offset_
   - end_node_
   - past_end_node_
   - node_
   - iteration_progress_
   - shadow_depth_

2. Members with trivial initialization are initialized in class declaration
   instead of ctor:
   - needs_another_new_line_
   - needs_handle_replaced_element_
   - should_stop_
   - handle_shadow_root_

BUG=721957
TEST=n/a; no behavioral change

Review-Url: https://codereview.chromium.org/2921483002
Cr-Commit-Position: refs/heads/master@{#476393}

BUG=699244

Review-Url: https://codereview.chromium.org/2907243002
Cr-Commit-Position: refs/heads/master@{#476392}

Solely for experimenting with new query "tail" suggestions.

BUG=726769

Review-Url: https://codereview.chromium.org/2889823002
Cr-Commit-Position: refs/heads/master@{#476391}

Bug: 713222
Change-Id: I89dc5253a173a6d64ead697db765181282a14b6b
Reviewed-on: https://chromium-review.googlesource.com/515622
Commit-Queue: rnephew <rnephew@chromium.org>
Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org>
Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
Reviewed-by: Charlie Andrews <charliea@chromium.org>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#476390}

WebView autofill implementation doesn't use chrome's autofill service
and UI, instead, it use autofill service in Android platform to get
form autofilled.

BUG=693204

Review-Url: https://codereview.chromium.org/2839023003
Cr-Commit-Position: refs/heads/master@{#476389}

https://pdfium.googlesource.com/pdfium.git/+log/a64cd6c86438..f6ca07b3fda4

$ git log a64cd6c86..f6ca07b3f --date=short --no-merges --format='%ad %ae %s'
2017-06-01 tsepez Replace some repeated code with existing CFXJS_Engine::NewString() helper.

Created with:
  roll-dep src/third_party/pdfium


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


TBR=dsinclair@chromium.org

Change-Id: I39203fdc81880f9440fbbbb80f3d3320cdaa0b6a
Reviewed-on: https://chromium-review.googlesource.com/521722
Reviewed-by: <pdfium-deps-roller@chromium.org>
Commit-Queue: <pdfium-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476388}

BUG=623344
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2816713003
Cr-Commit-Position: refs/heads/master@{#476387}