GitLab

Bug: 
Change-Id: Ib2ced6b11cf9fe1736c8e97c8f06005d660ce028
Reviewed-on: https://chromium-review.googlesource.com/567173
Commit-Queue: Kamila Hasanbega <hkamila@google.com>
Reviewed-by: Varun Khaneja <vakh@chromium.org>
Reviewed-by: Luke Z <lpz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485861}

This roll includes only a single revision:
https://chromium.googlesource.com/chromium/buildtools/+/3d2d34dde457f07ca410d1c06f4f3b9063c28643

TBR=michaelpg@chromium.org

Bug: 701919
Change-Id: I2924e4db1cad21ce8aa4c99f5090dea69d53a720
Reviewed-on: https://chromium-review.googlesource.com/567777
Commit-Queue: Peter Collingbourne <pcc@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485860}

This CL implements the "module responses map" concept defined in the Worklet
spec. This map caches module scripts to ensure that WorkletGlobalScopes created
at different times contain the same set of script source text and have the same
behaviour.

The map is not used yet in this CL. Following CLs will wire it up with
ModuleScriptLoader via WorkletModuleResponsesMapProxy (see the design doc for
details).

Worklet spec: https://drafts.css-houdini.org/worklets/#module-responses-map
Design doc: https://docs.google.com/document/d/1cgLcrua7H_7x_o5GlzYrAi2qt-TqTzgtOeixFAugR6g/edit?usp=sharing

Bug: 726576
Change-Id: Ib2af974e4b48eaf23ed2a38c74da5f2a503568d9
Reviewed-on: https://chromium-review.googlesource.com/549601Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485859}

Now ArcIntentHelperBridge can be obtained via ArcServiceManager.
So, LocalActivityResolver can be merged into ArcServiceManager
to get rid of unnecessary reference from ArcServiceManager to it.

BUG=739097
TEST=Ran trybot.

Change-Id: Idaee93706e14b268feb28d98811f7b290de2165e
Reviewed-on: https://chromium-review.googlesource.com/566785Reviewed-by: Yusuke Sato <yusukes@chromium.org>
Commit-Queue: Hidehiko Abe <hidehiko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485858}

The default ripple color for toolbar buttons is white, which is invisible on
white background.
We need to set custom style to make the ripple visible.

Bug: 740836
Change-Id: I7dc62bef120d5a06e8f42247cc1e5c604c6fd4ff
Reviewed-on: https://chromium-review.googlesource.com/566981Reviewed-by: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
Commit-Queue: Naoki Fukino <fukino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485857}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/cc60e4e3..4f9afdad

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org

Change-Id: I99b6876fe0f0eb934ab1f7df234be4232b210b25
Reviewed-on: https://chromium-review.googlesource.com/567623Reviewed-by: v8 autoroll <v8-autoroll@chromium.org>
Commit-Queue: v8 autoroll <v8-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485856}

TBR=yzshen@chromium.org
NOTRY=true

Change-Id: I2d987a880c31dfb97f37935e3f5d41a8b273f6bd
Reviewed-on: https://chromium-review.googlesource.com/567647Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485855}

For more on JUnit4 migration, please check src/testing/android/docs/junit4.md

BUG: 640116
Change-Id: I1f2ed7d46f173ff84f6d3d284c3b0fcdb0657e8f
Reviewed-on: https://chromium-review.googlesource.com/567461Reviewed-by: Lambros Lambrou <lambroslambrou@chromium.org>
Reviewed-by: Zijie He <zijiehe@chromium.org>
Commit-Queue: Yoland Yan <yolandyan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485854}

This reverts commit 2096391c.

Reason for revert: Maybe caused jingle_unittests to fail crbug.com/741256

Original change's description:
> Reimplement base::WaitableEvent with a kqueue on Mac.
> 
> For a single WaitableEvent, a custom EVFILT_USER kevent is used to wait and
> signal. This replaces the default POSIX implementation that uses a
> pthread_cond_t and a boolean flag.
> 
> To implement WaitMany, a new kqueue is created to wait on all the individual
> WaitableEvent's kqueue descriptor. This replaces a complex locking algorithm
> used in the default POSIX implementation.
> 
> For the asynchronous WaitableEventWatcher, a TYPE_READ dispatch_source_t is
> used to watch the WaitableEvent's kqueue. This replaces the POSIX
> implementation of a reference-counted list of async watchers guarded by a lock.
> 
> Microbenchmarks show that the kqueue implementation is significantly faster in
> most cases. The one potential drawback is hitting the low RLIMIT_NOFILE on
> macOS, since each WaitableEvent and WaitableEventWatcher requires a new
> descriptor.
> 
> Bug: 681167
> Change-Id: I135012fdd25e547ffb911fc7adc97c203df38241
> Reviewed-on: https://chromium-review.googlesource.com/553497
> Reviewed-by: Robert Liao <robliao@chromium.org>
> Reviewed-by: Mark Mentovai <mark@chromium.org>
> Commit-Queue: Robert Sesek <rsesek@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#485788}

TBR=robliao@chromium.org,rsesek@chromium.org,mark@chromium.org

Change-Id: I5b8740bf353f86b0ac5b600793826cd7724cd784
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 681167
Reviewed-on: https://chromium-review.googlesource.com/566700Reviewed-by: Keishi Hattori <keishi@chromium.org>
Commit-Queue: Keishi Hattori <keishi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485853}

This patch moves values_struct_traits into a separate target to be shared by the
chromium and blink variant, and adds values.typemap to blink's typemap config.

BUG=740288

Change-Id: Iae1bf24dd90ca16af6f7b3e0d3e83d255ae41b16
Reviewed-on: https://chromium-review.googlesource.com/565337
Commit-Queue: lpy <lpy@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Yuzhu Shen <yzshen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485852}

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I0b58757a8c56cf1ae9a5ba82fe2d485651f3c52e
Bug: 662541
Reviewed-on: https://chromium-review.googlesource.com/558381
Commit-Queue: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Paweł Hajdan Jr. <phajdan.jr@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485851}

Remove the "if(ServiceManagerConnection::GetForProcess())", use the DCHECK()
instead to make sure the ServiceManagerConnection is always initialized in
production code.

BUG=689415

Change-Id: I85dc481a80ddbef9faa0b5c99d8da8991d4f85be
Reviewed-on: https://chromium-review.googlesource.com/545436Reviewed-by: Yuri Wiitala <miu@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Commit-Queue: Ke He <ke.he@intel.com>
Cr-Commit-Position: refs/heads/master@{#485850}

Bug: 730828
Change-Id: Ibf29dfcac0180a1c5240e47ad59f6c6f6c9479de
Reviewed-on: https://chromium-review.googlesource.com/567703Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485849}

Bug: 730904
Change-Id: Id37a8a9c5d9e7ec5d5112ad2567a6c376c6e591e
Reviewed-on: https://chromium-review.googlesource.com/567332Reviewed-by: Dave Schuyler <dschuyler@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485848}

https://skia.googlesource.com/skia.git/+log/51b2f1b64c4d..d96ed9d0def2

$ git log 51b2f1b64..d96ed9d0d --date=short --no-merges --format='%ad %ae %s'
2017-07-11 herb Experimental blur code.
2017-07-11 bungeman Check first deserialized verb of path is a move.

Created with:
  roll-dep src/third_party/skia
BUG=740789


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=ethannicholas@chromium.org

Change-Id: Ieacea59c9b71b45e1ab7ac21194f69d5bc37e131
Reviewed-on: https://chromium-review.googlesource.com/567813Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485847}

Added constants to FeatureEngagementTracker demo arrays. This allows
the tracker's demo mode to interact with the new features.

R=edchin@chromium.org, gchatz@chromium.org

Bug: 738164
Change-Id: Ib29370c7d8e68af2021b8e8b77c78270cf86b577
Reviewed-on: https://chromium-review.googlesource.com/556466Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Ed Chin <edchin@chromium.org>
Reviewed-by: Gregory Chatzinoff <gchatz@chromium.org>
Commit-Queue: Cooper Knaak <cooperknaak@google.com>
Cr-Commit-Position: refs/heads/master@{#485846}

Previously there was a lot of platform-specific code in
network_interfaces_unittest.cc, which made it hard to work with.
Moved that code to separate files.

Change-Id: I5e3827a42b78895ddf6007ca73f46053b9c45916
Reviewed-on: https://chromium-review.googlesource.com/562363Reviewed-by: Eric Roman <eroman@chromium.org>
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485845}

Currently, there are two types of callsites:
1) onSelectionChanged / onTextChanged: these should update user-visible
autocompletetext.
2) Inside endBatchEdit(): these should only internally update states.

We can call separate methods to serve these purposes better, and make
notification path a bit clearer.

Also, this CL polishes up test, by
1) removing unnecessary null check and
2) removing unnecessary method overriding for hasFocus() - now we're
   calling requestFocus() anyways.

BUG=539536

Change-Id: If116ba53ec15a378545f3faa0f8cb0357d0dec85
Reviewed-on: https://chromium-review.googlesource.com/567392Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Changwan Ryu <changwan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485844}

Create new BUILD.gn file for media/cdm and moved respective
media component changes from media/BUILD.gn file to new BUILD.gn
file.

BUG=613033,739673
Signed-off-by: Suchit Agrawal <a.suchit@samsung.com>
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I944b712791833edf6417db308225295c6cb3bdbf
Reviewed-on: https://chromium-review.googlesource.com/561265Reviewed-by: Alexander Potapenko <glider@chromium.org>
Reviewed-by: Nick Carter <nick@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: SUCHIT AGRAWAL <a.suchit@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485843}

Previously, XMLDOcumentParser uses ScriptResource directly.
This CL replaces the ScriptResource with PendingScript, in order to:
- Replace a call of ScriptLoader::ExecuteScript() with
  ExecuteScriptBlock() to unify load/error event handling within
  ExecuteScriptBlock(), as follow-up of
  https://chromium-review.googlesource.com/c/554098 (Issue 686281),
- Prepare for module script support in XHTMLs (Issue 717643), and
- Enable SRI check in XHTMLs (Issue 684306).

Bug: 686281, 717643, 684306
Change-Id: Ibedded79223d30952dee4c8370fc9eed2201a462
Reviewed-on: https://chromium-review.googlesource.com/557304
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Daniel Vogelheim <vogelheim@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485842}

This was already present, now use it to populate the information read
by the compositor and renderers.

Bug: 735613
Change-Id: Id5c85b2bc3a0891e35760dd27b65d85c898d9176
Reviewed-on: https://chromium-review.googlesource.com/564392Reviewed-by: Fredrik Hubinette <hubbe@chromium.org>
Commit-Queue: ccameron chromium <ccameron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485841}

Added Steven because of file ownership.
Added Catherine and Robert for file overview.

Bug: 734248
Change-Id: I64eeabf9785d1b98ac0d5c615c0e082db327b1e5
Reviewed-on: https://chromium-review.googlesource.com/564184Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Bettina Dea <bdea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485840}

In the current implementation, when SiteInstance was used to get the
process, the Service Worker UMAs are recorded as NEW_PROCESS. But This
is not accurate. SiteInstance can reuse the existing process.

This CL also splits the EXISTING_PROCESS UMAs to EXISTING_READY_PROCESS
and EXISTING_UNREADY_PROCESS. When PlzNavigate is enabled, the service
worker is likely to be started in an existing unready process which was
newly created for the navigation. We should record this case apart from
starting in an existing ready process.

Bug: 740102
Change-Id: I523cea926fb78eb25e2669cfa0a3d56ca003e08c
Reviewed-on: https://chromium-review.googlesource.com/564912Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Tsuyoshi Horo <horo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485839}

This patch ensures all trees (pending and recycle) are synchronized if
scroll offset is modified on the active tree. This lets us remove LayerImpl's
UpdatePropertyTreeScrollOffset which duplicated the transform tree update
logic found in LayerTreeImpl::DidUpdateScrollOffset. This removes more
LayerImpl scroll logic.

This patch reverts [1] which updated the recycle tree in
LayerTreeHostImpl::InvalidateContentOnImplSide and instead updates the
recycle tree in LayerTreeImpl::DidUpdateScrollOffset.
[1] https://chromium.googlesource.com/chromium/src/+/0e55c1eae61583ba6634a8a58cb30a2b38c922a9

Bug: 
Change-Id: I326176b7089b1bc9f6d8064af94844b3999a0b11
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Reviewed-on: https://chromium-review.googlesource.com/562556Reviewed-by: enne <enne@chromium.org>
Reviewed-by: Weiliang Chen <weiliangc@chromium.org>
Commit-Queue: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485838}

The ctrl+d developer accelerator was broken with the switch to
simplified display management. Add the plumbing in
ScreenManagerForwarding for TestDisplayController. Make the window close
button remove the display again too.

The ctrl+d accelerator will only work properly in mash, since mus does
something different with accelerators, but it would be fairly simple to
fix in mus too. The window close button should work in both mus and mash
mode.

This CL also removes ToggleDisplayResolution from the
TestDisplayController since it's not used anymore.

Bug: 548429
Change-Id: I0f664af246a98d13eda6f312e44d226d599cecd1
Reviewed-on: https://chromium-review.googlesource.com/567333Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: kylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485837}

This patch changes SelectionModifier::ModifyExtendingForward() to utilize
early-return style for improving readability.

Change-Id: I005c7064bacafca1ffaf2f805b31d5860f326389
Reviewed-on: https://chromium-review.googlesource.com/566203
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Reviewed-by: Yoichi Osato <yoichio@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485836}

Cookies have their own permissions, so a cookie created by one origin can
potentially also be read by other origins. Since the "Site Details" page only
shows origin-scoped permissions, having cookies in Site Details complicates the
UI by suggesting they can be cleared for only one origin. Instead, clearing
cookies for just one origin can cause other origins to enter an invalid state,
and render sites effectively broken. Avoid this problem by removing it from
Site Details entirely.

Note that cookie settings will still be available via chrome:settings ->
Advanced -> Content Settings -> Cookies.

the Page Info bubble and click "Site settings" to open the Site Details page.
Verify "Cookies" is not listed as one of the content settings there.

Bug: 656758
Change-Id: I44ecd7aaea594659d286244380a8cd8d9510de4d
Test: With #enable-site-details on, navigate to https://permission.site. Open
Reviewed-on: https://chromium-review.googlesource.com/563137Reviewed-by: Tim Sergeant <tsergeant@chromium.org>
Reviewed-by: Dave Schuyler <dschuyler@chromium.org>
Commit-Queue: Patricia Lor <patricialor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485835}

This patch builds on the earlier patch where we passed the URLLoaderFactory for AppCache
to the renderer process. The renderer invokes CreateLoaderAndStart which comes to the AppCache
factory. We then instantiate the AppCacheRequestHandler instance here and call into it to handle
the request. The handler creates the AppCacheURLLoaderJob and passes itself to the job. The job controls
the lifetime of the handler.

The AppCacheSubresourceURLFactory class is passed the precreated AppCache host during init. We save
maintain this as a weak reference in the class to protect against the case where the host dies while we are
processing the call from the renderer. Added support to get a weak pointer in the AppCacheHost class.
The AppCacheRequestHandler saves away the host as a weak reference during InitializeForNavigationNetworkService()
and passes to the factory in MaybeCreateSubresourceFactory()

The other changes are to pass the information from CreateLoaderAndStart() to the AppCacheRequestHandler class
and from there to the job. A bug was fixed in the AppCacheURLLoaderJob where we weren't terminating the write correctly
causing the renderer to not consider the load as complete.

With this change normal subresource loads will work. Fallback support is not added yet and will happen in a followup.

BUG=715632
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2956373002
Cr-Commit-Position: refs/heads/master@{#485834}

This CL fixes the bug that the generated coalesced events always report
the same position of touchdown.

BUG=741004
TEST=Build/deploy chrome to chromeos, run google keep and inspect logs.

Change-Id: Iba1f12623397a07d5aeba89a67bdce9db5337dd3
Reviewed-on: https://chromium-review.googlesource.com/567318Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Commit-Queue: Jingkui Wang <jkwang@google.com>
Cr-Commit-Position: refs/heads/master@{#485833}

Moving the ChildProcessLauncher class to base.
This will allow the Multiprocess tests (used by mojo/ and ipc/) to
reuse the launching code instead of duplicating it.

TBR=dcheng

Bug: 702316
Change-Id: I8f05ce382bd87fe4f681fa510e1a61eab2d15428
Reviewed-on: https://chromium-review.googlesource.com/559833
Commit-Queue: Jay Civelli <jcivelli@chromium.org>
Reviewed-by: Jay Civelli <jcivelli@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Bo Liu <boliu@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485832}

This is done with avoiding explicit chrome package name (using
component name instead) and using
EXTRA_SEND_TO_EXTERNAL_DEFAULT_HANDLER on the intent.

With this patch the redirect works, however it takes a long time for CCT to
consult ExternalNavigationHandler. This results in suboptimal UX. Same redirect
in ChromeTabbedActivity is almost instantaneous. Result is that
for _blank links CCT shows up briefly before redirecting to an external app.
In a follow up it should be investigated why it is the case and if it cannot
be improved, we might need to bypass CCT in such case, which would diverge
from existing navigation paths for _blank links in Clank.

BUG=740402

Review-Url: https://codereview.chromium.org/2969143002
Cr-Commit-Position: refs/heads/master@{#485831}

More tests are going to be added soon that need to run differently. This
change extracts some repeated code into re-usable functions so these
future tests can use them.

A few is_particular_state functions are also removed (e.g. is_inactive)
and instead the state is just exposed and tested directly.

Bug: 729919
Change-Id: Ia453f0017c0c127e40277d51931c5452381a663d
Reviewed-on: https://chromium-review.googlesource.com/566763Reviewed-by: Dominick Ng <dominickn@chromium.org>
Commit-Queue: Ben Wells <benwells@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485830}

Bug: 672263
Change-Id: I34f0836f35b9e25416abefa2088db96104ee5160
Reviewed-on: https://chromium-review.googlesource.com/562573
Commit-Queue: Ryan Hansberry <hansberry@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485829}

Variable 'x' is assigned a value that isn't used after the assignment.

R=kojii@chromium.org

Review-Url: https://codereview.chromium.org/2982513002
Cr-Commit-Position: refs/heads/master@{#485828}

This CL removes the unused member variable |make_context_current_| and
associated file static function MakeDecoderContextCurrent(), because
they are unused.

Bug: 736517
Change-Id: I5e294cdc00b5703fafed3afb96fbd5e54aa31991
Reviewed-on: https://chromium-review.googlesource.com/567603Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Emircan Uysaler <emircan@chromium.org>
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485827}

Android O introduces a new authentication model for accessing the list
of accounts on the device. Each account has to be specifically
authorized for the app before it will appear in the list returned by
the system's AccountsManager.

This CL rewrites the open-source account-switcher so it will work on
Android O devices, now that the app's AndroidManifest has been updated
to target Android O.

Bug: 704216
Change-Id: I35497209114d10a818424d04ca3215cca68c386d
Reviewed-on: https://chromium-review.googlesource.com/566989Reviewed-by: Joe Downing <joedow@chromium.org>
Commit-Queue: Lambros Lambrou <lambroslambrou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485826}

This reverts commit 45df4f39.

Reason for revert: compile fail due to unused variable https://build.chromium.org/p/chromium/builders/Linux%20x64/builds/43945

Original change's description:
> Fix threading in FileDescriptorWatcher and MessagePumpLibevent tests.
> 
> Changes to MessagePumpLibevent & tests:
> 1. Add an explicit wait for thread start-up to TestWatchingFromBadThread,
> which was not updated when the base::ThreadStart() call was changed to
> not wait for the thread startup to complete.
> 2. Reinstate TestWatchingFromBadThread on all libevent platforms.
> 3. Add sanity-check tests for readable/writable notifications.
> 4. Clean up some .get()s and add some DPLOGs.
> 
> Changes to FileDescriptorWatcher & tests:
> 1. Add a DLOG_IF() to StartWatching, to make it easier to spot
> WatchFileDescriptor failures. This can't be a DCHECK or CHECK, since the
> StartWatching operation is racey with file-descriptor close() on the
> calling thread.
> 2. Fix the test fixture to Stop() |other_thread_| to ensure it is done
> working before we tear down the test file descriptors.
> 3. Fix the WatchWritable test to request write notifications for the
> correct end of the pipe (since pipe()s are uni-directional).
> 
> Bug: 138845,740692
> 
> TBR=dcheng,fdoray
> 
> Change-Id: I86bdd100561fbc56c1e6291216cafc3168b185dc
> Reviewed-on: https://chromium-review.googlesource.com/565227
> Commit-Queue: Wez <wez@chromium.org>
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Reviewed-by: Wez <wez@chromium.org>
> Reviewed-by: Nico Weber <thakis@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#485822}

TBR=dcheng@chromium.org,wez@chromium.org,thakis@chromium.org,fdoray@chromium.org,sergeyu@chromium.org

Change-Id: Idbb8c3cc0f6889c546195e62df552241d67312b9
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 138845, 740692
Reviewed-on: https://chromium-review.googlesource.com/566839Reviewed-by: Christopher Lam <calamity@chromium.org>
Commit-Queue: Christopher Lam <calamity@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485825}

TBR=dimu@chromium.org

Change-Id: I93113c343cbfaf61e62a5b56d6c82c9041698182
Reviewed-on: https://chromium-review.googlesource.com/567628Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485824}

Refactor string classes and utility functions:
* std::string to Http2String,
* base::StringPiece to Http2StringPiece,
* StringPiece::AppendToString and StringPiece::append to Http2StrAppend
* base::StringPrintf to Http2StringPrintf,
* implement Http2StrCat
in net/http2/platform, just like it has been done in net/spdy/platform.

This lands server side CL 161074972 by bnc.

BUG=488484

Change-Id: I893bf6c0b97eeea92aa06d3503edea85a9ce302c
Reviewed-on: https://chromium-review.googlesource.com/561756Reviewed-by: Helen Li <xunjieli@chromium.org>
Commit-Queue: Bence Béky <bnc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485823}

Changes to MessagePumpLibevent & tests:
1. Add an explicit wait for thread start-up to TestWatchingFromBadThread,
which was not updated when the base::ThreadStart() call was changed to
not wait for the thread startup to complete.
2. Reinstate TestWatchingFromBadThread on all libevent platforms.
3. Add sanity-check tests for readable/writable notifications.
4. Clean up some .get()s and add some DPLOGs.

Changes to FileDescriptorWatcher & tests:
1. Add a DLOG_IF() to StartWatching, to make it easier to spot
WatchFileDescriptor failures. This can't be a DCHECK or CHECK, since the
StartWatching operation is racey with file-descriptor close() on the
calling thread.
2. Fix the test fixture to Stop() |other_thread_| to ensure it is done
working before we tear down the test file descriptors.
3. Fix the WatchWritable test to request write notifications for the
correct end of the pipe (since pipe()s are uni-directional).

Bug: 138845,740692

TBR=dcheng,fdoray

Change-Id: I86bdd100561fbc56c1e6291216cafc3168b185dc
Reviewed-on: https://chromium-review.googlesource.com/565227
Commit-Queue: Wez <wez@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485822}