GitLab

we decided to show "duplicate" items in the recently closed menu because they may not actually be duplicates. For example, they may have different history even if the url and title for the tab is the same.

BUG=105760
TEST=none


Review URL: http://codereview.chromium.org/8764013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112396 0039d316-1c4b-4281-b951-d872f2087c98

BUG=104535
TBR=viettrungluu@chromium.org

Review URL: http://codereview.chromium.org/8762018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112395 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=unit tests

R=jbates@chromium.org


Review URL: http://codereview.chromium.org/8756001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112394 0039d316-1c4b-4281-b951-d872f2087c98

Note: another CL will attempt to free the command buffer as well.

Also note: I didn't want to change the function signature of
GLES2Implementation as that would have been a much larger change.
So, the startup code in renderer_gl_context.cc still creates
the initial transfer buffer and info about that is passed into
GLES2Implementation. A cleaner approach would probably have
been to let GLES2Implemetation allocate the initial buffer but
that's a much larger change.

TEST=unit tests and ran Chrome testing a few pages and stepping in debugger.
BUG=103989

R=apatrick@chromium.org


Review URL: http://codereview.chromium.org/8536045

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112393 0039d316-1c4b-4281-b951-d872f2087c98

This also removes the curtain-mode hooks from DesktopEnvironment and ChromotingHost.

Me2Me hosts will no longer show the Disconnect or Continue windows.  It2Me hosts should be unaffected, except for the removal of curtain-mode (which will be added back in a later CL).


BUG=104377
TEST=Manual and unittests


Review URL: http://codereview.chromium.org/8725016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112392 0039d316-1c4b-4281-b951-d872f2087c98

BUG=88782
TEST=X509UtilNSSTest


Review URL: http://codereview.chromium.org/8537025

TBR=mattm@chromium.org
Review URL: http://codereview.chromium.org/8764017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112391 0039d316-1c4b-4281-b951-d872f2087c98

BUG=105542
TEST=Start a new user so you see the sync promo page. Sign into Sync. Check about:histograms and ensure that SyncPromo.MessageDisplayed and SyncPromo.MessageOnSignIn both have the same enum value recorded.

Review URL: http://codereview.chromium.org/8689006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112388 0039d316-1c4b-4281-b951-d872f2087c98

Touch-specific builds are being retired.  Instead we want to be able to enable touch-friendly UI dynamically.  For now I'm adding a --touch-optimized-ui flag which can be used to enable the touch-optimized CSS tweaks we've made to WebUI.

This undoes the tweak to use the non-ChromeOS language UI for touch_ui builds.  The conditional HTML for the add-language-overlay-page is non-trivial to convert to something dynamic - I'll do something in a separate changelist.

Also fix a number of issues where overrides of WebUI virtuals (like RenderViewCreated) weren't properly delegating back to their base class (or were delegating to WebUI instead of the immediate base ChromeWebUI).

Also removes the Touch-specific User-Agent string.

BUG=105315
TEST=


Review URL: http://codereview.chromium.org/8695007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112387 0039d316-1c4b-4281-b951-d872f2087c98

BUG=88782
TEST=X509UtilNSSTest


Review URL: http://codereview.chromium.org/8537025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112385 0039d316-1c4b-4281-b951-d872f2087c98

BUG=101025
TEST=none


Review URL: http://codereview.chromium.org/8762012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112384 0039d316-1c4b-4281-b951-d872f2087c98

This leak was fixed in r112297.

BUG=105864
TEST=


Review URL: http://codereview.chromium.org/8766002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112383 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112382 0039d316-1c4b-4281-b951-d872f2087c98

TEST=unit-tests
BUG=105577
Review URL: http://codereview.chromium.org/8736001

TBR=georgey@chromium.org

Review URL: http://codereview.chromium.org/8762016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112381 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
TEST=


Review URL: http://codereview.chromium.org/8761010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112380 0039d316-1c4b-4281-b951-d872f2087c98

Also, fix a bug in the proxy (also for audio input) -- it should fail if the
callback provided is null.


Review URL: http://codereview.chromium.org/8749017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112379 0039d316-1c4b-4281-b951-d872f2087c98

For now (on GTK only), "shell" windows are not drawn with a frame at all.

R=miket@chromium.org


Review URL: http://codereview.chromium.org/8734016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112378 0039d316-1c4b-4281-b951-d872f2087c98

Use a real flash url instead of local URL. Looks like exception formatting for local urls has changed or removed.

R=dennisjeffrey@chromium.org
BUG=105632,100595
TEST=pyauto test: plugins.PluginsTest.testBlockPluginException

Review URL: http://codereview.chromium.org/8757011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112377 0039d316-1c4b-4281-b951-d872f2087c98

BUG=105999
TEST=
TBR=rsimha

Review URL: http://codereview.chromium.org/8763015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112376 0039d316-1c4b-4281-b951-d872f2087c98

BUG=105139
TEST=trigger an error during model association, inspect about:sync to ensure
line numbers are displayed in error message.


Review URL: http://codereview.chromium.org/8637023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112375 0039d316-1c4b-4281-b951-d872f2087c98

BUG=102135
TEST=Have multiple profiles created. Go to "Personal Stuff" options. Delete one of the profiles from the list of profiles. The avatar for the profile being deleted should appear in the dialog.


Review URL: http://codereview.chromium.org/8715009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112374 0039d316-1c4b-4281-b951-d872f2087c98

until all the private IDL files can generate the correct .h files.

BUG= none
TEST= ./generator.py && ./generator.py --wnone --cgen --range=start,end --include_private --out private/ppb_flash_fullscreen.idl

R=noelallen@chromium.org,piman@chromium.org


Review URL: http://codereview.chromium.org/8760016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112373 0039d316-1c4b-4281-b951-d872f2087c98

shutting down if StartupTimeBomb is still Arm'ed.

BUG=105475
R=jar
TEST=browser unit tests

Review URL: http://codereview.chromium.org/8728035

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112372 0039d316-1c4b-4281-b951-d872f2087c98

The sync confirmation bubble would show multiple times.

Fix was to clear the NTP resource cache after the bubble was shown.

BUG=103699
TEST=Verfied that without my patch the sync confirmation bubble would show up multiple times. Applied my patch and verified that the confirmation bubble only showed once.


Review URL: http://codereview.chromium.org/8698010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112371 0039d316-1c4b-4281-b951-d872f2087c98

BUG=NONE
TEST=NONE

Review URL: http://codereview.chromium.org/8662049

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112370 0039d316-1c4b-4281-b951-d872f2087c98

Part of libcros removal -- removing chromeos_screen_lock

BUG=chromium-os:16559
TEST=Make sure screen lock/unlock works
Signed-off-by: Simon Que <sque@chromium.org>

R=satorux@chromium.org,stevenjb@chromium.org


Review URL: http://codereview.chromium.org/8664014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112369 0039d316-1c4b-4281-b951-d872f2087c98

BUG=91241
TEST=


Review URL: http://codereview.chromium.org/8743007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112368 0039d316-1c4b-4281-b951-d872f2087c98

Not sure what happened here, but I felt dirty when I checked that
crx in the first time, so just removed it.

BUG=105728

Review URL: http://codereview.chromium.org/8741004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112367 0039d316-1c4b-4281-b951-d872f2087c98

remove unused strings, and in one case start using an unused string (most visited delete tooltip)

a couple of the strings may still used by touch ntp and in the bookmarks pane, but both of these are getting removed quite soon

BUG=none
TEST=compile and visual inspection


Review URL: http://codereview.chromium.org/8746007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112366 0039d316-1c4b-4281-b951-d872f2087c98

BUG=98716
Review URL: http://codereview.chromium.org/8760012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112365 0039d316-1c4b-4281-b951-d872f2087c98

requests don't fail. Re-enable cross-origin tests.
BUG=103690
TEST=ui_tests, --gtest_filter=PPAPITest.URLLoader*
Review URL: http://codereview.chromium.org/8692015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112364 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=existing


Review URL: http://codereview.chromium.org/8537029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112363 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

R=groby@chromium.org

Review URL: http://codereview.chromium.org/8734017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112362 0039d316-1c4b-4281-b951-d872f2087c98

BUG=98716
Review URL: http://codereview.chromium.org/8758011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112361 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=

Review URL: http://codereview.chromium.org/8758007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112360 0039d316-1c4b-4281-b951-d872f2087c98

 The test timeouts occasionally on aura.

BUG=105957
TEST=none


Review URL: http://codereview.chromium.org/8760002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112359 0039d316-1c4b-4281-b951-d872f2087c98

We're also syncing this value, which has the nice side effect of letting us get rid of the "setup done" boolean we were planning on using.

BUG=105682
TEST=Setting up app notifications should leave a "app_notif_client_id" key
in your Preferences file in the extensions section associated with the app
in question.


Review URL: http://codereview.chromium.org/8727024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112357 0039d316-1c4b-4281-b951-d872f2087c98

Also rename "Everything" to "ValidConfigs" and update the (Mac) Valgrind
exclusion. And preemptively add an exclusion for the new test. :(


Review URL: http://codereview.chromium.org/8742026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112356 0039d316-1c4b-4281-b951-d872f2087c98

BUG=105882
TEST=see bug.

Review URL: http://codereview.chromium.org/8741023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112355 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/8678035

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112354 0039d316-1c4b-4281-b951-d872f2087c98

Move the ProcessType enum out to its own file. This is in preparation for getting rid of ChildProcessInfo.

BUG=98716
Review URL: http://codereview.chromium.org/8760011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112353 0039d316-1c4b-4281-b951-d872f2087c98