GitLab

BUG=none

Review-Url: https://codereview.chromium.org/2756733003
Cr-Commit-Position: refs/heads/master@{#457761}

Changes include:
- if a window specifies a non-default shadow elevation, use that for both the active and inactive state (shadow_controller.cc) instead of just the inactive state.
- make the contents of the info bubble a single, multi-line, selectable label. To be selectable, the bubble must be activatable. This is somewhat trickier because the system menu bubble wants to close itself whenever activation changes.*
- Better internationalization for contents of network info bubble.
- New layout for InfoBubble.

*Network info bubble should close when the user mouses out, when the system bubble closes, when the user presses the back arrow, or when the user presses the (i) again.

BUG=676395,341706

Review-Url: https://codereview.chromium.org/2754963002
Cr-Commit-Position: refs/heads/master@{#457760}

This migrates the variables in chromeos.gyp to BUILD.gn, making the
source easier to read. This also lets us remove a use of exec_script, so
chromeos/BUILD.gn no longer has to be whitelisted to use it.

BUG=701617

Review-Url: https://codereview.chromium.org/2753883002
Cr-Commit-Position: refs/heads/master@{#457759}

This CL relaxes the precision of a floating-point comparison made in the
zoom browsertest to avoid spurious test failures.

BUG=702269

Review-Url: https://codereview.chromium.org/2761473002
Cr-Commit-Position: refs/heads/master@{#457758}

Use a NavigationThrottle to check infringement of the 'frame-src' on the
browser-side. Before this patch, a redirect during the navigation could
led to a child frame to be displayed inside its parent, even if it was
disallowed by its parent.

BUG=685074
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation;master.tryserver.chromium.linux:linux_site_isolation,linux_chromium_browser_side_navigation_rel

Review-Url: https://codereview.chromium.org/2655463006
Cr-Commit-Position: refs/heads/master@{#457757}

Revert of Disable flaky TextureLayerChangeInvisibleMailboxTest.RunMultiThread_DelegatingRenderer (patchset #2 id:20001 of https://codereview.chromium.org/2756853002/ )

Reason for revert:
Disables half of cc unittests, this is of course not good.

Original issue's description:
> Disable flaky TextureLayerChangeInvisibleMailboxTest.RunMultiThread_DelegatingRenderer
>
> BUG=702329
> TBR=enne@chromium.org
> CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
>
> Review-Url: https://codereview.chromium.org/2756853002
> Cr-Commit-Position: refs/heads/master@{#457697}
> Committed: https://chromium.googlesource.com/chromium/src/+/a2ef1195d4f15d4a589110dd682baaa1174225b8

TBR=enne@chromium.org,nhiroki@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=702329

Review-Url: https://codereview.chromium.org/2761483002
Cr-Commit-Position: refs/heads/master@{#457756}

During restore save the result of the restore (success, or failure with
reason) in a SharedPreference. The first time Chrome is run copy this
value to a UMA histogram, or record that no restore happened.

BUG=685774

Review-Url: https://codereview.chromium.org/2750323002
Cr-Commit-Position: refs/heads/master@{#457755}

Taking a method pointer to Callback::Run is problematic for upcoming
refactoring of it.

Review-Url: https://codereview.chromium.org/2754793003
Cr-Commit-Position: refs/heads/master@{#457754}

Attempt to diagnose a crash condition by locking out main thread GCs
while the audio thread propagates consumeAudio() updates.

R=haraken
BUG=682945

Review-Url: https://codereview.chromium.org/2761463002
Cr-Commit-Position: refs/heads/master@{#457753}

SecurityExploitBrowserTest.AttemptDuplicateRenderWidgetHost has been
failing a flaky manner on Android. This CL makes it return early on
Android when PlzNavigate is enabled while we investigate the root cause
of the failure.

BUG=702584
TBR=nasko@chromium.org

Review-Url: https://codereview.chromium.org/2759653002
Cr-Commit-Position: refs/heads/master@{#457752}

https://skia.googlesource.com/skia.git/+log/14583e11fd62..73e21af21390

$ git log 14583e11f..73e21af21 --date=short --no-merges --format='%ad %ae %s'
2017-03-17 borenet Revert "Add color spin test for SkColorSpaceXformCanvas"

Created with:
  roll-dep src/third_party/skia


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=borenet@chromium.org

Change-Id: I48d3b774634d0e148a33f96b85af5df082d85c19
Reviewed-on: https://chromium-review.googlesource.com/456486Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#457751}

BUG=689662
TBR=gangwu@chromium.org

Review-Url: https://codereview.chromium.org/2757833004 .
Cr-Commit-Position: refs/heads/master@{#457750}

This flag will allow devs having access to the internal Chrome for
Android repo to choose whether to use it in their builds.

BUG=702323

Review-Url: https://codereview.chromium.org/2753273002
Cr-Commit-Position: refs/heads/master@{#457749}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/bac1574d..f8189977

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2759503003
Cr-Commit-Position: refs/heads/master@{#457748}

BUG=701924
TBR=yoshiki@chromium.org

Review-Url: https://codereview.chromium.org/2756593005 .
Cr-Commit-Position: refs/heads/master@{#457747}

This is a step towards making getUserMedia() more spec-compliant.
See https://w3c.github.io/mediacapture-main/#dom-mediadevices-getusermedia

BUG=690491

Review-Url: https://codereview.chromium.org/2749893004
Cr-Commit-Position: refs/heads/master@{#457746}

Adding visibility property will enable a window/widget/view to be shown
or hidden by simply changing the value 1 (visible) to 0 (hide) in the
element CSS style.

BUG=697175

Review-Url: https://codereview.chromium.org/2739523002
Cr-Commit-Position: refs/heads/master@{#457745}

R=stgao@chromium.org, tandrii@chromium.org
CC=sshruthi@chromium.org
BUG=702202

Review-Url: https://codereview.chromium.org/2754063002
Cr-Commit-Position: refs/heads/master@{#457744}

A CL (https://codereview.chromium.org/2741343017) failed to compile on
Windows Debug try bots because files in wtf/ lacked __declspec(dllimport)
even though they need to import symbols defined in platform_wtf.

Conceptually, platform_wtf and wtf are a single link unit, thus the target
type of "component" was inappropriate; it should have been "source_set"
instead.

This change is supposed to fix the compile error mentioned above.

BUG=691465

Review-Url: https://codereview.chromium.org/2760573002
Cr-Commit-Position: refs/heads/master@{#457743}

BUG=702171
TBR=nhiroki@chromium.org

Review-Url: https://codereview.chromium.org/2753223003 .
Cr-Commit-Position: refs/heads/master@{#457742}

This is the first step towards implementing a new Photo Picker for Chrome for
Android, broken down into multiple steps for easier reviewing.

First part includes simply replacing the stock Android picker with a Toast
saying "Not implemented".

Includes a Finch tie-in and a flag to turn this on manually ("Enable new
photopicker" in chrome://flags).

BUG=656015

Review-Url: https://codereview.chromium.org/2737393002
Cr-Commit-Position: refs/heads/master@{#457741}

https://skia.googlesource.com/skia.git/+log/dea7428b96ba..14583e11fd62

$ git log dea7428b9..14583e11f --date=short --no-merges --format='%ad %ae %s'
2017-03-16 reed More SkVertices implementation work

Created with:
  roll-dep src/third_party/skia


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=borenet@chromium.org

Change-Id: I9586804667a1f5cab2677afb99db39383b5050db
Reviewed-on: https://chromium-review.googlesource.com/456588Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#457740}

This CL removes DOMWrapperWorld::fromWorldId() that looks like a simple getter
but actually has a side effect like this:
1) When a given id is for the main world, ensures the main world and returns it.
2) When a given id is for an isolated world, ensures the isolated world and
   returns it.
3) Otherwise, looks up a given id in the world map and then returns the finding.
   If the world doesn't exist, returns nullptr.

After this CL, mainWorld() is used for 1) and ensureIsolatedWorld() is used for
2). fromWorldId() hasn't been used for 3), so this CL does not introduce an
alternative for the case.

Also, this CL pushes the main world into the world map for cleanup. Before this
CL, the main world is managed separately from other worlds. Managing all worlds
in the single map would be simpler.

BUG=697622, 697629

Review-Url: https://codereview.chromium.org/2753013003
Cr-Commit-Position: refs/heads/master@{#457739}

This CL adds headers for the Content Suggestions sections.

BUG=702236

Review-Url: https://codereview.chromium.org/2751653008
Cr-Commit-Position: refs/heads/master@{#457738}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/4e3e3842..bac1574d

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2756123002
Cr-Commit-Position: refs/heads/master@{#457737}

This CL blocks responding to requests which redirect mode is not 'follow' with redirected responses.

BUG=669363,658249

Review-Url: https://codereview.chromium.org/2755643004
Cr-Commit-Position: refs/heads/master@{#457736}

BUG=702498

Review-Url: https://codereview.chromium.org/2753063003
Cr-Commit-Position: refs/heads/master@{#457735}

BUG=chromium:702201
R=sullivan@chromium.org, nednguyen@google.com

Review-Url: https://codereview.chromium.org/2744243007
Cr-Commit-Position: refs/heads/master@{#457734}

adds a warning when the --use-fake-ui-for-media-stream flag is used.
This flag is used in automated testing and skips the getUserMedia permissions
prompt. It might be slightly harmful to real users.

BUG=520377

Review-Url: https://codereview.chromium.org/2727143006
Cr-Commit-Position: refs/heads/master@{#457733}

The scheduleFreeMemoryMonitoring method post a task to the IO thread to log the
free memory. There is no need to defer it further.

BUG=649338

Review-Url: https://codereview.chromium.org/2751993003
Cr-Commit-Position: refs/heads/master@{#457732}

This allows to reset references inside PasswordFormManager to data owned by the
associated FormFetcher instances.  See
https://docs.google.com/document/d/12CH_SV1gIJKaEIGTs7gWBiXrCMlBa3o32OyC2LRtPAo/edit#heading=h.jz2q52kebs7k
for more details.

BUG=621355

Review-Url: https://codereview.chromium.org/2752173003
Cr-Commit-Position: refs/heads/master@{#457731}

BUG=702554
TBR=tapted@chromium.org

Review-Url: https://codereview.chromium.org/2753263002 .
Cr-Commit-Position: refs/heads/master@{#457730}

Disable DevToolsBeforeUnloadTest.TestUndockedDevToolsInspectedTabClose and DevToolsBeforeUnloadTest.TestDockedDevToolsInspectedBrowserClose on Win

BUG=702171
TBR=nhiroki@chromium.org

Review-Url: https://codereview.chromium.org/2756143002 .
Cr-Commit-Position: refs/heads/master@{#457729}

https://codereview.chromium.org/2754883002 enables
perf_json_generator to also generate benchmark.csv. This change
updates the name of perf_json_generator to reflect that it is
also generating a csv file.

BUG=chromium:575318

Review-Url: https://codereview.chromium.org/2757433003
Cr-Commit-Position: refs/heads/master@{#457728}

Revert of Fuzzer for TextCodecs (patchset #8 id:140001 of https://codereview.chromium.org/2731643002/ )

Reason for revert:
Huge size regression on fuzzer archives.

BUG=702485

Original issue's description:
> Fuzzer for TextCodecs
>
> Fuzzer originally written by jsbell here:
> https://codereview.chromium.org/2546233002
>
> This introduces a libFuzzer-based fuzzer template (which can be run locally
> or via ClusterFuzz) for the WTF::TextCodec implementations. It
> introduces a new target for every text codec.
>
> Fuzzer docs: https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/getting_started.md
>
> This patch also includes a generated fuzzer corpus.
>
> Review-Url: https://codereview.chromium.org/2731643002
> Cr-Commit-Position: refs/heads/master@{#457512}
> Committed: https://chromium.googlesource.com/chromium/src/+/bb69cdf76b25cee534e6b84a5c55f4453ee3c828

TBR=mmoroz@chromium.org,jsbell@chromium.org,aizatsky@google.com,haraken@chromium.org,csharrison@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review-Url: https://codereview.chromium.org/2755083002
Cr-Commit-Position: refs/heads/master@{#457727}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/f7036b13..4e3e3842

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2756513005
Cr-Commit-Position: refs/heads/master@{#457726}

Use it in https://codereview.chromium.org/2751833005/

BUG=694451

Review-Url: https://codereview.chromium.org/2747253004
Cr-Commit-Position: refs/heads/master@{#457725}

BUG=None
TEST=None

Review-Url: https://codereview.chromium.org/2747373006
Cr-Commit-Position: refs/heads/master@{#457724}

The headers and footer of the CollectionViewModel should not be parameterized
as the implementation as Item is a convenience.

BUG=none

Review-Url: https://codereview.chromium.org/2750373004
Cr-Commit-Position: refs/heads/master@{#457723}

BUG=700859
TBR=guidou@chromium.org

Review-Url: https://codereview.chromium.org/2757833003
Cr-Commit-Position: refs/heads/master@{#457722}