- 19 May, 2019 19 commits
-
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d4e4026d364b..49840624d1ce Created with: gclient setdep -r src-internal@49840624d1ce The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=beverloo@google.com,collinbaker@google.com,bcwhite@google.com,tasak@google.com Change-Id: I225bbdc6d2716a7b65fb48ca2b2f3cf3e97f912a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1619202Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#661215}
-
Koji Ishii authored
This patch retains temporary styles |TextAutosizer| creates during the layout. Normally, these temporary styles need to be kept alive only during the lifetime of the |TextAutosizer| instance. However, in case something bad happens, these temporary styles can lead to use-after-free. This patch keeps them alive until the layout cycle ends. Bug: 963563 Change-Id: Id657409a3b93f34c76297848c5ded3128486f031 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617565 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#661214}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/8c6bfe5350cf..ed2255b4ea13 git log 8c6bfe5350cf..ed2255b4ea13 --date=short --no-merges --format='%ad %ae %s' 2019-05-19 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update SKP version Created with: gclient setdep -r src/third_party/skia@ed2255b4ea13 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=csmartdalton@google.com Change-Id: Iaafff4663c4c715d9f77b2fc6fedd338820f6058 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1619007Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#661213}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I1efca2a6cd1411528916fefdd757d4a6854eac25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1619044Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ab84c6b5f1a2..d4e4026d364b Created with: gclient setdep -r src-internal@d4e4026d364b The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=beverloo@google.com,collinbaker@google.com,bcwhite@google.com,tasak@google.com Change-Id: Ieaf4b96bf0f23883b86f9aa5017da70f4d5822f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617274Reviewed-by:
-
jdragon.bae authored
There are the same things in two files. components/autofill/core/browser/autofill_address_util.cc, browser/extensions/api/autofill_private/autofill_private_api.cc. This patch means refactoring to use a single code path for this. Bug: 903594 Change-Id: I3f0b18363805d76dc232ce3eaf4147d07f9dcba5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1331448Reviewed-by:
Jeffrey Cohen <jeffreycohen@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Reviewed-by:
anthonyvd <anthonyvd@chromium.org> Reviewed-by:
sebsg <sebsg@chromium.org> Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Auto-Submit: Jaeyong Bae <jdragon.bae@gmail.com> Commit-Queue: Jaeyong Bae <jdragon.bae@gmail.com> Cr-Commit-Position: refs/heads/master@{#661210}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/f4f427ad1082..977a0a436918 git log f4f427ad1082..977a0a436918 --date=short --no-merges --format='%ad %ae %s' 2019-05-19 capn@google.com Implement OpImageQueryLod Created with: gclient setdep -r src/third_party/swiftshader@977a0a436918 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:b/129523279 TBR=swiftshader-team+autoroll@google.com Change-Id: I792625c239a78c387b7c90417e26b5c842271b18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617699Reviewed-by:
-
Dan Erat authored
This reverts commit 097960fa. Reason for revert: Breaks SyncChrome stage in Chrome OS due to old depot_tools on Chrome OS builders: https://crbug.com/963259, https://crbug.com/964720 Original change's description: > Roll third_party/openscreen dependency > > This patch rolls openscreen to the latest HEAD. > > Change-Id: I9890293e3b2ed62a702bd0aa08a0615cf26798a2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618022 > Reviewed-by: Brandon Tolsch <btolsch@chromium.org> > Commit-Queue: Jordan Bayles <jophba@chromium.org> > Cr-Commit-Position: refs/heads/master@{#661020} TBR=mfoltz@chromium.org,btolsch@chromium.org,pthatcher@chromium.org,jophba@chromium.org Bug: chromium:963259, chromium:964720 # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: I2e31746dd66e0572f8002d9a9312ea2e4b1d63b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618593Reviewed-by:
Robbie Iannucci <iannucci@chromium.org> Commit-Queue: Dan Erat <derat@chromium.org> Cr-Commit-Position: refs/heads/master@{#661208}
-
Sigurdur Asgeirsson authored
Change-Id: I53e12a84340df56e24bc78abddf479e109a7aba0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617085 Commit-Queue: Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Auto-Submit: Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#661207}
-
Nico Weber authored
This reverts commit a6f001ae. Reason for revert: Speculative. These 3 tests started failing on all main waterfall mac tester bots in browser_tests: ServiceProcessControlBrowserTest.HistogramsNoService ServiceProcessControlBrowserTest.LaunchAndIPC ServiceProcessControlBrowserTest.LaunchAndReconnect All builds where this started happening had this CL in common. The build that best shows this is: https://ci.chromium.org/p/chromium/builders/ci/Mac10.11%20Tests/37949 The other 3 CLs in that build look like they're likely no-ops on macOS. This CL also doesn't look super related to the failure message, but relanding is easy if this turns out to not help. Original change's description: > Add pre- and post-commit modes to LoginHandler > > LoginHandler currently handles two tasks when showing an interstitial: > running the request through extensions and then showing a login > prompt. When converted to committed interstitials, we need to run the > request through extensions before the navigation commits, and then > show a login prompt on top of a committed error page. This CL adds a > "mode" argument to LoginHandler. When committed interstitials are > enabled, the "mode" argument determines whether we should just run the > request through extensions and then cancel it (pre-commit mode), or > show a login prompt (post-commit). The post-commit mode is currently > not reachable; we'll use it once we add the WebContentsObserver that > observes the committed error page (https://crbug.com/963313). > > Note: this "mode" design is kind of messy and we'll probably want to > come back and clean it up later. For now, it's the simplest way to > leave LoginHandler intact for when committed interstitials are > disabled, and use the parts of it that we need before+after commit > when committed interstitials are enabled. Once committed interstitials > land and we clean up the old code, we will probably want to split > LoginHandler into two classes rather than having one class that can > operate in two different modes. > > Bug: 963311 > Change-Id: I1efddb3eca3a6b822135bd721db05f2f47561a86 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1616943 > Reviewed-by: Carlos IL <carlosil@chromium.org> > Reviewed-by: Joe DeBlasio <jdeblasio@chromium.org> > Commit-Queue: Emily Stark <estark@chromium.org> > Cr-Commit-Position: refs/heads/master@{#661141} TBR=estark@chromium.org,carlosil@chromium.org,jdeblasio@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 963311 Change-Id: Id22a831ac81cd1056da31efbf5f045edb5533726 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1619069Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#661206}
-
Wez authored
Bug: 831024, 814914 Change-Id: I8281b6a6538352f9d08e8e426a210a9af012b7fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614473 Commit-Queue: Wez <wez@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Auto-Submit: Wez <wez@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#661205}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I99d05ff7353f293cf634311dbcc20e4c4c8a0424 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617696Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/54575315ea69..ab84c6b5f1a2 Created with: gclient setdep -r src-internal@ab84c6b5f1a2 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=beverloo@google.com,collinbaker@google.com,bcwhite@google.com,tasak@google.com Change-Id: I2856d88f9ac3b791d31a45a27e4fe6fed157b4cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1619006Reviewed-by:
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=kariah@chromium.org Change-Id: Iceeb1a7e2a7426a3f04a8e562851431b877a5716 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1619067Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#661202}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/190d4698fe8f..54575315ea69 Created with: gclient setdep -r src-internal@54575315ea69 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=beverloo@google.com,collinbaker@google.com,bcwhite@google.com,tasak@google.com Change-Id: I88e4528203da0808d9918b4f8b309efdff1b5b7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1619004Reviewed-by:
-
Nico Weber authored
This reverts commit 53511d46. Reason for revert: The test is failing everywhere, because sheriffbot reverted https://chromium-review.googlesource.com/c/chromium/src/+/1615499 which was apparently required to let this pass. Original change's description: > Portals: Add test that portals can't load data, javascript or about URLs. > > Bug: 962500 > Change-Id: Ib5e275a7f31be3a7e24dfc7bf976b6e2866624fb > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614703 > Commit-Queue: Lucas Gadani <lfg@chromium.org> > Reviewed-by: Jeremy Roman <jbroman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#661004} TBR=jbroman@chromium.org,lfg@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 962500 Change-Id: I3422d26293a92bfd5653222b1335251a0f398dae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1619065Reviewed-by:
-
Nico Weber authored
This reverts commit d95be619. Reason for revert: New test fails on cros test bots, rel and dbg: https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-dbg/12442 https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-rel/24516 Original change's description: > UI Notification for Gnubby U2F UI. > > Bug: 757077 > Change-Id: I54305669b9fbbcb9191c814790ebe29a7dff0d62 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1404060 > Commit-Queue: Yulun Wu <yulunwu@chromium.org> > Reviewed-by: Alexander Alekseev <alemate@chromium.org> > Cr-Commit-Position: refs/heads/master@{#661147} TBR=alemate@chromium.org,apronin@chromium.org,yulunwu@chromium.org Change-Id: Ibb4a66731dd358844c271117cf7a37565cc3643b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 757077 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1619063Reviewed-by:
-
Nico Weber authored
Ran `tools/clang/scripts/upload_revision.py 361104`. TBR=hans Bug: 962839 Binary-Size: Code size goes down. Resource size goes up because of regression fix for bug 960881 Change-Id: I1830b561612b379cbe415da0107d36783dbd3c8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618802Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ca7fa9c514e8..190d4698fe8f Created with: gclient setdep -r src-internal@190d4698fe8f The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=beverloo@google.com,collinbaker@google.com,bcwhite@google.com,tasak@google.com Change-Id: I9289eee803236769c1a1586523de85129cc8bfa3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618650Reviewed-by:
-
- 18 May, 2019 21 commits
-
-
John Budorick authored
Bug: 964674 Change-Id: Ib243128c333c2a685706834340198ca3ed3a600d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617695 Commit-Queue: John Budorick <jbudorick@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
-
Stefan Zager authored
BUG=961286 R=cbiesinger@chromium.org Change-Id: I6c827744b69a5f2d36c0cc219fe8e490fe851f55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618017 Commit-Queue: Stefan Zager <szager@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#661195}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/23da073ba80c..f4f427ad1082 git log 23da073ba80c..f4f427ad1082 --date=short --no-merges --format='%ad %ae %s' 2019-05-18 chrisforbes@google.com Use custom normalization for SNORM formats in sampler Created with: gclient setdep -r src/third_party/swiftshader@f4f427ad1082 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:b/129523279 TBR=swiftshader-team+autoroll@google.com Change-Id: Idb794a4192f9fb658c05bb625dcccabb87a951d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617693Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0df8374b1ade..ca7fa9c514e8 Created with: gclient setdep -r src-internal@ca7fa9c514e8 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=beverloo@google.com,collinbaker@google.com,bcwhite@google.com,tasak@google.com Change-Id: I095ec75f35acb10075564799729e19f97905d688 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618785Reviewed-by:
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I107a3f661890bbaa5fcf620987d6c782965ce0de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618786Reviewed-by:
-
Ian Kilpatrick authored
NGExclusion::operator== didn't previous compare shape_data. This turned out to be a bad optimization. :) Without this we'd end up in a situation where we would have: - An exclusion vector containing an exclusion with shape data. - Derived geometry which wasn't tracking shape data. Bug: 963580 Change-Id: I21746f8fd081ff24658768ee6074122f2e913bd5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1613560 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/05082a5d997c..0df8374b1ade Created with: gclient setdep -r src-internal@0df8374b1ade The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=beverloo@google.com,collinbaker@google.com,bcwhite@google.com,tasak@google.com Change-Id: Ib3e89c4e1fc9937196cd390b1293ef71a3dc0126 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618784Reviewed-by:
-
Nico Weber authored
This reverts commit 810a8608. Reason for revert: Tests fail on UBSanVptr bot: https://ci.chromium.org/p/chromium/builders/ci/ToTLinuxUBSanVptr/6837 All failures look like: [ RUN ] PromiseTest.CatchThenVoid ../../base/task/promise/then_and_catch_executor.h:177:5: runtime error: member call on address 0x357fcd736278 which does not point to an object of type 'base::internal::ThenAndCatchExecutor<base::OnceCallback<void ()>, base::OnceCallback<int ()>, base::internal::NoCallback, void, base::Resolved<int>, base::Rejected<base::NoReject> >' 0x357fcd736278: note: object has invalid vptr 74 55 00 00 7b 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 28 8c 7b cd ^~~~~~~~~~~~~~~~~~~~~~~ invalid vptr Original change's description: > Reland: Promises: Implement Promise<> handle with Then and Catch > > Original patch https://crrev.com/c/1599620 > > MultiThreadedPromiseTest.CrossThreadThens had a race between the > resolve on thread b and thread a posting a bunch of tasks including > the quit closure which would sometimes arrive mid way through > thread b posting eligible thens. > > > > Implements Then and Catch on top of AbstractPromise as well as > ManualPromiseResolver<> which is needed for testing at this > stage (PostTask doesn't yet return a promise). It's also > necessary for promises to interface with old style callback > based libraries which are extremely common in Chromium. > > Design: https://docs.google.com/document/d/1l12PAJgEtlrqTXKiw6mk2cR2jP7FAfCCDr-DGIdiC9w/edit > > TBR=fdoray@chromium.org, etiennep@chromium.org > > Bug: 906125 > Change-Id: I95bbd0f1a709643cd4a813e378b625a91f2abe7a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617769 > Reviewed-by: Alex Clarke <alexclarke@chromium.org> > Commit-Queue: Alex Clarke <alexclarke@chromium.org> > Cr-Commit-Position: refs/heads/master@{#661171} TBR=alexclarke@chromium.org Change-Id: I7f5d8fb65620b8d0dd44066f6da9d077d1e7edcd No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 906125 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618803Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0e244bb8b945..05082a5d997c Created with: gclient setdep -r src-internal@05082a5d997c The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=beverloo@google.com,collinbaker@google.com,bcwhite@google.com,tasak@google.com Change-Id: I7719e8ca6a98bcf668f327ce48da6593d40fdbbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618782Reviewed-by:
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/626a016091fa..23da073ba80c git log 626a016091fa..23da073ba80c --date=short --no-merges --format='%ad %ae %s' 2019-05-18 amaiorano@google.com CMake: add C4471 warning as error for MSVC: enum forward declare must have underlying type Created with: gclient setdep -r src/third_party/swiftshader@23da073ba80c The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:b/131224705 TBR=swiftshader-team+autoroll@google.com Change-Id: I3b06dae64071f4a2998aeb2b8d24ff45c56fb966 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618781Reviewed-by:
-
W. James MacLean authored
This refactor moves the logic in RenderWidget::PageScaleFactorChanged() to RenderWidget::SetPageScaleStateAndLimits(). This removes the need for RenderViewImpl::PageScaleFactorChanged() to call GetWidget(). This is a re-land of https://chromium-review.googlesource.com/c/chromium/src/+/1614080. TBR=dcheng@chromium.org TBR=collinbaker@chromium.org Bug: 924336 Change-Id: I77856534a30dcd78576f4ac5bdb7e03b38ec59ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618182Reviewed-by:
James MacLean <wjmaclean@chromium.org> Commit-Queue: James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#661186}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/05395845d3f2..0e244bb8b945 Created with: gclient setdep -r src-internal@0e244bb8b945 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=beverloo@google.com,collinbaker@google.com,bcwhite@google.com,tasak@google.com Change-Id: Ic1336333e9e785e76d5c54392496d3e8c6751822 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618744Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/dba816954b29..f9db023d2092 git log dba816954b29..f9db023d2092 --date=short --no-merges --format='%ad %ae %s' 2019-05-18 jclinton@chromium.org Revert "Require LCQ label for all CL's processed by legacy PreCQ and CQ" Created with: gclient setdep -r src/third_party/chromite@f9db023d2092 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Change-Id: I6f7326d6e285f57ce96264cd501065491f67e547 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618743Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/7bf160e6d5c4..8c6bfe5350cf git log 7bf160e6d5c4..8c6bfe5350cf --date=short --no-merges --format='%ad %ae %s' 2019-05-18 rmistry@google.com Whitespace test Created with: gclient setdep -r src/third_party/skia@8c6bfe5350cf The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=michaelludwig@google.com Change-Id: I7e2b4ada183ad3c79b1b99c96a6cc85ad3f0be2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618742Reviewed-by:
-
Haohao Wang authored
This change introduces two new desktop UI options - TAB and BUTTON_GM2, to translate bubble for experimentation. The flags has been added to chrome://flags. Implementation for TAB and BUTTON_GM2 are in progress. Default is set to existing BUTTON option. Note that TAB option has been released on IOS and Android. Change-Id: Icc79269c4364b431797ef3635b773ad5e2ad7fc4 Bug: 963148 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610567 Commit-Queue: Haohao Wang <hhw@google.com> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ae59c2e6b722..05395845d3f2 Created with: gclient setdep -r src-internal@05395845d3f2 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=beverloo@google.com,collinbaker@google.com,bcwhite@google.com,tasak@google.com Change-Id: Ib49ec77eaa3437af38f09d4c8d6b152aa45e04fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618741Reviewed-by:
-
Maksim Sisov authored
This is a prerequisite to unite the buffer managers and share most of the buffer management APIs between software and hardware paths. When software compositing is used, make sure that the calls to mojo happen on the gpu thread. Otherwise, OnSubmission and OnPresentation may happen on a completely different thread and hit the DCHECK. Bug: 963853 Change-Id: I537b7734f88dab23a9f97897ffd48e07bc36a537 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617502Reviewed-by:
Michael Spang <spang@chromium.org> Commit-Queue: Maksim Sisov <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#661180}
-
Maksim Ivanov authored
Remove the "full-width" CSS class from the code - it seems to have no usage anymore. Previously, this class was enabled during the SAML mode, however after the SAML mode has been migrated to Gaia V2 API all CSS rules associated with ".full-width" become overridden by other ones. Bug: 470893 Test: manual - verify UI hasn't changed for OOBE/login/SAML interstitial pages Change-Id: Id2dab371bc1d0da21501f1ce32ab07344e160480 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617767Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#661179}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Icb1ff2c3631f96ace91cd82bf09eaddfe63d80ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618079Reviewed-by:
-
Maxim Kolosovskiy authored
This reverts commit 3442d9cc. Reason for revert: we don't need to disable crowdsourcing anymore. Original change's description: > [Password Manager] Disable uploading noisified info about special symbols > > We may need to disable the uploading and merge it to late Beta. With this CL, I test that disabling doesn't cause any crashes or other issues. If we don't need to disable uploading, this CL will be reverted. > > The uploading was introduced in https://chromium-review.googlesource.com/c/chromium/src/+/1567751. > > Bug: 953668, 552420 > Change-Id: I6e85bc047bcf1a263b60c5a0cbea19eb5e86f576 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1615023 > Reviewed-by: Vadym Doroshenko <dvadym@chromium.org> > Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> > Cr-Commit-Position: refs/heads/master@{#660352} TBR=dvadym@chromium.org,kolos@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 953668, 552420 Change-Id: Ied3dedfba52c5d57a696548ce99ff0c334c4257b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617446Reviewed-by:
Maxim Kolosovskiy <kolos@chromium.org> Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> Cr-Commit-Position: refs/heads/master@{#661177}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 05059d2b. With Chromium commits locally applied on WPT: c4dc3441 "[WPT] Reland Upload a test for sending mouse events with key pressed" fec827fb "Added wpt tests for overscroll customization." c9077e39 "Restore original tail-processing for ScriptProcessor and AudioWorklet" d814fafc "Check for detached ArrayBuffers in Web Bluetooth writeValue functions" 64cbdf7a "Replace originOffset public member with getOffsetReferenceSpace method" e90c6ef0 "NG/DL: Implement size containment (and display lock) for NG fieldset algo" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: Iaef5cdcc74bff0f105cea8ee9847731bdf7b3f77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617690Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#661176}
-
