- 08 Dec, 2020 40 commits
-
-
Mikel Astiz authored
SyncData::ToString() is used for logging and, starting with https://crrev.com/c/2562659, it can DCHECK-fail if the sync entity's title is empty. This patch removes the DCHECK from SyncData::GetTitle(), since it seems overly strict, and the main calling site in SyncableServiceBasedBridge already verifies that the title is non-empty. To make this more obvious, an additional DCHECKs is introduced (which is redundant with pre-existing DCHECKs) and two functions renamed for clarity. Change-Id: Ib499e6a07132ab21033d83a241e5e380226913b0 Fixed: 1156130 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577468 Auto-Submit: Mikel Astiz <mastiz@chromium.org> Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Reviewed-by:
Maksim Moskvitin <mmoskvitin@google.com> Cr-Commit-Position: refs/heads/master@{#834673}
-
Ramin Halavati authored
Password manager client and and generated password leak pref are updated to be disabled for ephemeral Guest profiles, similar to off-the-record Guest profiles. Please see go/ephemeral-guest-profiles for more context. Bug: 1125474 Change-Id: I3a2187c25f5940047d61722769f8d286886818e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577501 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#834672}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/53fee9259fa3..2e018a8f25cf 2020-12-08 sigurds@chromium.org Mutually link requests with their prefetch requests 2020-12-08 changhaohan@chromium.org Temporarily disable two wasm-related tests. 2020-12-08 sigurds@chromium.org Prevent name-clash of CSS class names If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1141824,chromium:1156555 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I50563645779b732c24fd38b5305de6cdfd076431 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2578669Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#834671}
-
dpapad authored
In this CL creating subfolders for - chrome://flags - chrome://interventions - chrome://version - chrome://webapks This is part of an effort to clean up chrome/browser/resources folder, such that most (if not all) files are under a subfolder dedicated to to the WebUI page that uses them, along with appropriate OWNERS files. Bug: None Change-Id: Idd2d85fa0b938a0f51937adc4ae79cd0991fbf72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575953Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#834670}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e94373d60dc3..9f9233f23f55 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC engedy@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: engedy@google.com Change-Id: I234fcf774800f98c9f3652a491be01c4faf55ed5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2578667Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#834669}
-
Maksim Moskvitin authored
This reverts commit f357a95c. Reason for revert: rollout is not completed yet and has to be done using finch. Original change's description: > Enable SyncTriggerFullKeystoreMigration by default > > Bug: 1094326 > Change-Id: I1cc440f13b92fc825cc749c042e8599fdab793c8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2455447 > Commit-Queue: Mikel Astiz <mastiz@chromium.org> > Auto-Submit: Maksim Moskvitin <mmoskvitin@google.com> > Reviewed-by: Mikel Astiz <mastiz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#814665} TBR=mastiz@chromium.org,mmoskvitin@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1094326 Change-Id: I4df81e8a74ba25d6cb3ff3c71989e701f4b21b17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576239Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Cr-Commit-Position: refs/heads/master@{#834668}
-
Balazs Engedy authored
Bug: 1156285 Change-Id: Ib2abc6d9524fde559d52be9c8498fa3868bad355 TBR: dullweber@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574987Reviewed-by:
Balazs Engedy <engedy@chromium.org> Commit-Queue: Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#834667}
-
Balazs Engedy authored
Bug: 1156576 Change-Id: I463f384ab10fa81d1a2888de85dd03374c2a1d0f TBR: shengfa@google.com Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577367Reviewed-by:
-
Elizabeth Popova authored
The new input is placed above the name field and only shown if Address Editor is opened from Autofill Settings (purpose = AUTOFILL_SETTINGS) and kAutofillEnableUIForHonorificPrefixesInSettings feature is enabled. The entered value will not be saved, because honorifics are temporarily disabled (crbug/1113617). Screenshot: https://storage.cloud.google.com/chromium-translation-screenshots/4dcf597fed4da10035e80a4f22cf4a73b927a84e Bug: 1141884 Change-Id: I2ff12dfb6935d576e3ca73c3b3cdaddd75b82b2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2571759Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Christoph Schwering <schwering@google.com> Commit-Queue: Elizabeth Popova <lizapopova@google.com> Cr-Commit-Position: refs/heads/master@{#834665}
-
Zakhar Voit authored
This adds a test for the previous CL: https://crrev.com/2564643 BUG=1113272 Change-Id: Ia43f3d0d788cb79ce4ec91baee5c0207660dfd52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566960Reviewed-by:
Maksim Sisov (GMT+2) <msisov@igalia.com> Commit-Queue: Zakhar Voit <zvoit@igalia.com> Cr-Commit-Position: refs/heads/master@{#834664}
-
Wojciech Dzierżanowski authored
Introduce a GetOverlayWindow() getter that returns the overlay window object cast to the intended type OverlayWindowViews. This avoids a fair amount of repetition in the test. No functionality change. Bug: 985303 Change-Id: I0e1a4a510e9703b1480480bcadc2c75070ba7b7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575022 Commit-Queue: Wojciech Dzierżanowski <wdzierzanowski@opera.com> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#834663}
-
Ramin Halavati authored
The "force signin" policy is updated to handle ephemeral Guest profiles similar to off the record Guest profiles. Please see go/ephemeral-guest-profiles for more context. Bug: 1125474 Change-Id: I5527423c3fbc9abe3ac005242b11203d25121066 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577682 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#834662}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/e59d8716b300..a13f6847238e 2020-12-08 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from bbe26af2 to a3984b7e (468 revisions) 2020-12-08 syoussefi@chromium.org Suppress flaky multithreading swiftshader test If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: syoussefi@google.com Change-Id: I12ee3f84b478a59d567fdceb8d157892f08ed5f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2578780Reviewed-by:
-
arthursonzogni authored
With real users, we are seeing unexpected difference in between the sandbox flags computed from the renderer and the browser process. This is implemented by those two functions: - content::NavigationRequest::ComputeSandboxFlagsToCommit() - blink::FrameLoader::CalculateSandboxFlags After a navigation, the new document gets sandbox_flags from: - FramePolicy.sandbox, which contains everything except CSP. - The response's CSP sandbox. That's basically it. Both function does the same and are fed from the same data. The only difference is blink, which used "forced_sandbox_flags". This looked a bit mysterious at first. It turns out to be needed only for setting the sandbox flags for the initial empty document and the second 'initial empty document'. (e.g. not via navigation). Removing forced_sandbox_flags from CalculateSandboxFlags helps guaranteeing both browser side and renderer side computation always match. This make it explicit in the code from where the inheritance happens. This patch aligns inheriting sandbox from the opener with "OpenerFeatureState" (1), by moving it toward Frame, instead of the FrameLoader. (1) Turns out this will be removed: https://chromium-review.googlesource.com/c/chromium/src/+/2564396 Change-Id: I7098b459e485485630ab9edc99d392fcdbfdef4e Bug: 1153708 Fixed: 1153708 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2573362 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#834660}
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: I15d8d049626c71d53e06afe21437ac0b64aed21b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2578479Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#834659}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1607374595-14878fd6c473cc4aebbe55be6f54c0ff79c3ed8e.profdata to chrome-win32-master-1607396289-70fddd0960b2020da66aa7308994f58594fe5850.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I1a8e7dae44013f1b9dd93d079a22a6d8c58f383a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2578399Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1607374595-d12d27ca344e18f0b40a9dc8f54420fe6b49bde9.profdata to chrome-win64-master-1607396289-b814d12d89d9aa0b6942a46cc974733f2726887a.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I628099855f27bcc8065e6183d1aac2d67a30089b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2578108Reviewed-by:
-
Ramin Halavati authored
Updates ProfilePickerHandler to record ephemeral Guest profiles launch similar to off the record Guest profiles. Please see go/ephemeral-guest-profiles for more context. Bug: 1125474 Change-Id: I12625f7db4addfe6f8dcd7bc05584dbf45d404c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574755Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/7843c257dbae..53fee9259fa3 2020-12-08 sigurds@chromium.org Improve types in front_end/sdk/SDKModel.js If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ibf01fc2779e7e81a88f9c21af5b49cecb5e8fd90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2578663Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: Ib0da17331a3638a708a8b43a79a74bf0f7702017 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2578658Reviewed-by:
-
Jiawei Shao authored
BUG=dawn:529 Change-Id: I9cae2840f7e653372d9434a2d8a9ea386ede988b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574062 Commit-Queue: Jiawei Shao <jiawei.shao@intel.com> Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#834653}
-
Alice Gong authored
BUG=1154032 Change-Id: Idb1cfb620b41e6dfe7bed4ed316de76679e6e250 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2578056Reviewed-by:
Roger Tawa <rogerta@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Commit-Queue: Alex Ilin <alexilin@chromium.org> Auto-Submit: Alice Gong <alicego@google.com> Cr-Commit-Position: refs/heads/master@{#834652}
-
Alex Ilin authored
This refactor will enable ProfilePicker to use UserManagerProfileDialogDelegate for displaying force signin dialogs. Bug: 1156096 Change-Id: I2ae84c3bc882b45aa0a016d28e182d11cc87a0de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577220 Commit-Queue: Alex Ilin <alexilin@chromium.org> Reviewed-by:
-
Rainhard Findling authored
* Update the PW check UI to show compromised and weak password counts the same way as safety check does with crrev.com/c/2547582. * Also moves the corresponding strings from the SC to the PW check. Translation screenshots: IDS_SETTINGS_COMPROMISED_PASSWORDS_COUNT_SHORT https://storage.cloud.google.com/chromium-translation-screenshots/57beb450355e12e0a3ca2c8c9a4ce2b41a892535 IDS_SETTINGS_WEAK_PASSWORDS_COUNT_SHORT https://storage.cloud.google.com/chromium-translation-screenshots/3530dd0582d65de57d6d71d472576ce8c41fd292 Bug: 1128904 Change-Id: Ic98ed21c020132e3e36221b441eec138b2e85d63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567779 Commit-Queue: Rainhard Findling <rainhard@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#834650}
-
Wojciech Dzierżanowski authored
Ignore invalid display work area that is reported as a transient value in some cases, e.g. when reconnecting via Remote Desktop. Bug: 1154202 Change-Id: I4915fbdd5dd23248692ab6a66b382349e262dc89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2571302 Commit-Queue: Wojciech Dzierżanowski <wdzierzanowski@opera.com> Reviewed-by:
François Beaufort <beaufort.francois@gmail.com> Cr-Commit-Position: refs/heads/master@{#834649}
-
Alice Wang authored
This CL cleans up redundant GoogleActivityController. Bug: 1153038 Change-Id: I7a81ce074648c2830cb539d029784068eeb73ffa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577197 Commit-Queue: Alice Wang <aliceywang@chromium.org> Reviewed-by:
Tanmoy Mollik <triploblastic@chromium.org> Cr-Commit-Position: refs/heads/master@{#834648}
-
sauski authored
Replace the stub functions for conversion measurement on the PrivacySettingsSandbox class with implementations that respect both the privacy sandbox preferences and cookie content settings. Bug: 1152336 Change-Id: I1d7baed13f9830f95f389d26d80629cec17e2988 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2569653Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Commit-Queue: Theodore Olsauskas-Warren <sauski@google.com> Cr-Commit-Position: refs/heads/master@{#834647}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/03c2a0ffe52f..e94373d60dc3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC engedy@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: engedy@google.com Change-Id: I8b3596d44255fa22405935cb772e72581023f185 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2578779Reviewed-by:
-
Hitoshi Yoshida authored
The test failure happens only on BF cache bot. Dropped the flakiness expectation from general TestExpectations to catch actual failures. Bug: 1155125 Change-Id: I0966a5b76962b60e24870640249c65faeec4bdb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576224 Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Auto-Submit: Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Rakina Zata Amni <rakina@chromium.org> Cr-Commit-Position: refs/heads/master@{#834645}
-
Richard Knoll authored
This flag will be enabled on M88 Beta to launch the Mute Notifications feature on Desktop platforms. This will prevent potentially sensitive notification content from showing up on full-screen-share recordings. Approved launch bug for Beta: crbug.com/1133886 Bug: 1133886 Change-Id: I4a549738a02d73883c87731e4cef1ce846a30de8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577224Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#834644}
-
sandromaggi authored
This changes the |SelfDeleteFullCardRequester| to respond with adding details to the failure status according to the the result it got from the |FullCardRequest|. The |UseCreditCardAction| does not treat a failed status, but passes it on as the response to the action. Bug: b/174304769 Change-Id: Idcad69cf74eab14a9a59d5b6dc1ea166b230db67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577218 Commit-Queue: Sandro Maggi <sandromaggi@google.com> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#834643}
-
Minggang Wang authored
URLLoaderClientImpl is an implementation of network::mojom::URLLoaderClient and used by ResourceDispatcher only to receives messages from a single URLLoader, it couples with the ResourceDispatcher tightly. As part of the OnionSoup project, this patch implements: 1. Moves URLLoaderClientImpl to third_party/blink/public/platform/ and decouples it from the ResourceDispatcher by adding an interface of WebURLLoaderClientObserver. 2. Moves url_loader_client_impl_unittest.cc into blink and decouples it from the dependency of TestRequestPeer by implementing a MockWebURLLoaderClientObserver that mostly inherits the functionality of TestRequestPeer. So, after this patch, the TestRequestPeer will be only used by the unit test of ResourceDispatcher and could be removed with the ResourceDispatcher together eventually. Change-Id: I08793d58623713ee1fc40f9e2395e19ea141f952 Bug: 1110032 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560678Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Minggang Wang <minggang.wang@intel.com> Cr-Commit-Position: refs/heads/master@{#834642}
-
Keishi Hattori authored
When BackupRefPtr is used for LocalStorageImpl::StorageAreaHolder::area_ptr_, the destruction order of the fields causes a null dereference. ~StorageAreaHolder() ends up calling StorageAreaHolder::PrepareToCommit() which tries to use area_ptr_ without a null check Bug: 1080832 Change-Id: Iff06bbf440eb5a3d26226c85b13b36ac037f1fca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2564932Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Keishi Hattori <keishi@chromium.org> Cr-Commit-Position: refs/heads/master@{#834641}
-
Luciano Pacheco authored
Generate the JS modules for the following elements: * <xf-button> * <xf-circular-progress> * <xf-display-panel> * <xf-panel-item> And their test: files_xf_elements.unittest.m.js. Bug: 1133186 Change-Id: I22c71f6a6e648c4a1b027ef1766eb4df060f9f93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576299 Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Jeremie Boulic <jboulic@chromium.org> Commit-Queue: Jeremie Boulic <jboulic@chromium.org> Cr-Commit-Position: refs/heads/master@{#834640}
-
Victor Hugo Vianna Silva authored
The feature has been launched to 100% Stable for over a month [1], so this CL removes the feature toggle. Besides this, some instances of base::RepeatingClosure() in profile_sync_service_unittest.cc are replaced with base::DoNothing(). [1]https://groups.google.com/a/google.com/g/cr-rel-notify/c/_DOaHr_-x10/m/CA_P823xAQAJ https://groups.google.com/a/google.com/g/cr-rel-notify/c/mOOb_eXMgy4/m/aRpz0POPAAAJ https://groups.google.com/a/google.com/g/cr-rel-notify/c/bJ323M0Nrr4/m/jVRaVJWIBAAJ https://groups.google.com/a/google.com/g/cr-rel-notify/c/ad3g3moxG4k/m/n-KJcTuTAAAJ Bug: 1140447 Change-Id: Ifc72d6a35402d72bb5935a3dbc2d838fb5855bcb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489894Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Victor Vianna <victorvianna@google.com> Cr-Commit-Position: refs/heads/master@{#834639}
-
Heng-Ruey Hsu authored
Simply rename *_halv3 to *_delegate to keep git history. Add an intermediate layer to prepare further refactor to support multiple streams. Bug: b:151047537 Test: Manually Change-Id: Ic2db36b003206972aabd70a5ceafd00e9f8f1c3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351931 Commit-Queue: Heng-ruey Hsu <henryhsu@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Reviewed-by:
Wei Lee <wtlee@chromium.org> Auto-Submit: Heng-ruey Hsu <henryhsu@chromium.org> Cr-Commit-Position: refs/heads/master@{#834638}
-
sauski authored
Fixes an issue where the mouse interactions with the toggle buttons under a settings-collapse-radio-button which has been disabled by poliy do not work. Bug: 1156264 Change-Id: Ifac3bd2767378b9f05ad95586ec4a46ea262a561 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577225Reviewed-by:
Rainhard Findling <rainhard@chromium.org> Commit-Queue: Theodore Olsauskas-Warren <sauski@google.com> Cr-Commit-Position: refs/heads/master@{#834637}
-
Daniel Vogelheim authored
Fix-it week: Fix failing WPT test. Change-Id: I3bf43d39f19bc9b690bb943185e7ddb8961699da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574951Reviewed-by:
Yifan Luo <lyf@chromium.org> Commit-Queue: Daniel Vogelheim <vogelheim@chromium.org> Cr-Commit-Position: refs/heads/master@{#834636}
-
Daniel Vogelheim authored
Fix-It week: The test passes, but will then report an error in the test harness, because the string chosen for the example test is not actually a valid script. If we simply return "0" - which is valid JS - the bug disappears. (The test doesn't care about the script anyhow, only about whether it's accepted as input ot not.) Change-Id: Ie36c27965494f71b796176d3818aefd41b3067ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574953Reviewed-by:
-
Side Yilmaz authored
This CL passes the correct profile in LayerTitleCache by accessing profile with tab#isIncognito boolean. Bug: 1048632 Change-Id: I9555f637a890ea5052ac044667d953d221d0f84a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567226Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Side YILMAZ <sideyilmaz@chromium.org> Cr-Commit-Position: refs/heads/master@{#834634}
-
